Completed
Pull Request — master (#4212)
by Individual IT
13:52
created
apps/lookup_server_connector/appinfo/app.php 1 patch
Indentation   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -22,24 +22,24 @@
 block discarded – undo
22 22
 $dispatcher = \OC::$server->getEventDispatcher();
23 23
 
24 24
 $dispatcher->addListener('OC\AccountManager::userUpdated', function(\Symfony\Component\EventDispatcher\GenericEvent $event) {
25
-	$user = $event->getSubject();
25
+    $user = $event->getSubject();
26 26
 
27
-	$keyManager = new \OC\Security\IdentityProof\Manager(
28
-		\OC::$server->getAppDataDir('identityproof'),
29
-		\OC::$server->getCrypto()
30
-	);
31
-	$updateLookupServer = new \OCA\LookupServerConnector\UpdateLookupServer(
32
-		new \OC\Accounts\AccountManager(\OC::$server->getDatabaseConnection(), \OC::$server->getEventDispatcher()),
33
-		\OC::$server->getConfig(),
34
-		\OC::$server->getSecureRandom(),
35
-		\OC::$server->getHTTPClientService(),
36
-		$keyManager,
37
-		new \OC\Security\IdentityProof\Signer(
38
-			$keyManager,
39
-			new \OC\AppFramework\Utility\TimeFactory(),
40
-			\OC::$server->getUserManager()
41
-		),
42
-		\OC::$server->getJobList()
43
-	);
44
-	$updateLookupServer->userUpdated($user);
27
+    $keyManager = new \OC\Security\IdentityProof\Manager(
28
+        \OC::$server->getAppDataDir('identityproof'),
29
+        \OC::$server->getCrypto()
30
+    );
31
+    $updateLookupServer = new \OCA\LookupServerConnector\UpdateLookupServer(
32
+        new \OC\Accounts\AccountManager(\OC::$server->getDatabaseConnection(), \OC::$server->getEventDispatcher()),
33
+        \OC::$server->getConfig(),
34
+        \OC::$server->getSecureRandom(),
35
+        \OC::$server->getHTTPClientService(),
36
+        $keyManager,
37
+        new \OC\Security\IdentityProof\Signer(
38
+            $keyManager,
39
+            new \OC\AppFramework\Utility\TimeFactory(),
40
+            \OC::$server->getUserManager()
41
+        ),
42
+        \OC::$server->getJobList()
43
+    );
44
+    $updateLookupServer->userUpdated($user);
45 45
 });
Please login to merge, or discard this patch.
apps/user_ldap/templates/settings.php 1 patch
Indentation   +46 added lines, -46 removed lines patch added patch discarded remove patch
@@ -5,46 +5,46 @@  discard block
 block discarded – undo
5 5
 vendor_style('user_ldap', 'ui-multiselect/jquery.multiselect');
6 6
 
7 7
 script('user_ldap', [
8
-	'wizard/controller',
9
-	'wizard/configModel',
10
-	'wizard/view',
11
-	'wizard/wizardObject',
12
-	'wizard/wizardTabGeneric',
13
-	'wizard/wizardTabElementary',
14
-	'wizard/wizardTabAbstractFilter',
15
-	'wizard/wizardTabUserFilter',
16
-	'wizard/wizardTabLoginFilter',
17
-	'wizard/wizardTabGroupFilter',
18
-	'wizard/wizardTabAdvanced',
19
-	'wizard/wizardTabExpert',
20
-	'wizard/wizardDetectorQueue',
21
-	'wizard/wizardDetectorGeneric',
22
-	'wizard/wizardDetectorPort',
23
-	'wizard/wizardDetectorBaseDN',
24
-	'wizard/wizardDetectorFeatureAbstract',
25
-	'wizard/wizardDetectorUserObjectClasses',
26
-	'wizard/wizardDetectorGroupObjectClasses',
27
-	'wizard/wizardDetectorGroupsForUsers',
28
-	'wizard/wizardDetectorGroupsForGroups',
29
-	'wizard/wizardDetectorSimpleRequestAbstract',
30
-	'wizard/wizardDetectorFilterUser',
31
-	'wizard/wizardDetectorFilterLogin',
32
-	'wizard/wizardDetectorFilterGroup',
33
-	'wizard/wizardDetectorUserCount',
34
-	'wizard/wizardDetectorGroupCount',
35
-	'wizard/wizardDetectorEmailAttribute',
36
-	'wizard/wizardDetectorUserDisplayNameAttribute',
37
-	'wizard/wizardDetectorUserGroupAssociation',
38
-	'wizard/wizardDetectorAvailableAttributes',
39
-	'wizard/wizardDetectorTestAbstract',
40
-	'wizard/wizardDetectorTestLoginName',
41
-	'wizard/wizardDetectorTestBaseDN',
42
-	'wizard/wizardDetectorTestConfiguration',
43
-	'wizard/wizardDetectorClearUserMappings',
44
-	'wizard/wizardDetectorClearGroupMappings',
45
-	'wizard/wizardFilterOnType',
46
-	'wizard/wizardFilterOnTypeFactory',
47
-	'wizard/wizard'
8
+    'wizard/controller',
9
+    'wizard/configModel',
10
+    'wizard/view',
11
+    'wizard/wizardObject',
12
+    'wizard/wizardTabGeneric',
13
+    'wizard/wizardTabElementary',
14
+    'wizard/wizardTabAbstractFilter',
15
+    'wizard/wizardTabUserFilter',
16
+    'wizard/wizardTabLoginFilter',
17
+    'wizard/wizardTabGroupFilter',
18
+    'wizard/wizardTabAdvanced',
19
+    'wizard/wizardTabExpert',
20
+    'wizard/wizardDetectorQueue',
21
+    'wizard/wizardDetectorGeneric',
22
+    'wizard/wizardDetectorPort',
23
+    'wizard/wizardDetectorBaseDN',
24
+    'wizard/wizardDetectorFeatureAbstract',
25
+    'wizard/wizardDetectorUserObjectClasses',
26
+    'wizard/wizardDetectorGroupObjectClasses',
27
+    'wizard/wizardDetectorGroupsForUsers',
28
+    'wizard/wizardDetectorGroupsForGroups',
29
+    'wizard/wizardDetectorSimpleRequestAbstract',
30
+    'wizard/wizardDetectorFilterUser',
31
+    'wizard/wizardDetectorFilterLogin',
32
+    'wizard/wizardDetectorFilterGroup',
33
+    'wizard/wizardDetectorUserCount',
34
+    'wizard/wizardDetectorGroupCount',
35
+    'wizard/wizardDetectorEmailAttribute',
36
+    'wizard/wizardDetectorUserDisplayNameAttribute',
37
+    'wizard/wizardDetectorUserGroupAssociation',
38
+    'wizard/wizardDetectorAvailableAttributes',
39
+    'wizard/wizardDetectorTestAbstract',
40
+    'wizard/wizardDetectorTestLoginName',
41
+    'wizard/wizardDetectorTestBaseDN',
42
+    'wizard/wizardDetectorTestConfiguration',
43
+    'wizard/wizardDetectorClearUserMappings',
44
+    'wizard/wizardDetectorClearGroupMappings',
45
+    'wizard/wizardFilterOnType',
46
+    'wizard/wizardFilterOnTypeFactory',
47
+    'wizard/wizard'
48 48
 ]);
49 49
 
50 50
 style('user_ldap', 'settings');
@@ -67,12 +67,12 @@  discard block
 block discarded – undo
67 67
 		<li class="ldapSettingsTabs"><a href="#ldapSettings-1"><?php p($l->t('Advanced'));?></a></li>
68 68
 	</ul>
69 69
 	<?php if(OCP\App::isEnabled('user_webdavauth')) {
70
-		print_unescaped('<p class="ldapwarning">'.$l->t('<b>Warning:</b> Apps user_ldap and user_webdavauth are incompatible. You may experience unexpected behavior. Please ask your system administrator to disable one of them.').'</p>');
71
-	}
72
-	if(!function_exists('ldap_connect')) {
73
-		print_unescaped('<p class="ldapwarning">'.$l->t('<b>Warning:</b> The PHP LDAP module is not installed, the backend will not work. Please ask your system administrator to install it.').'</p>');
74
-	}
75
-	?>
70
+        print_unescaped('<p class="ldapwarning">'.$l->t('<b>Warning:</b> Apps user_ldap and user_webdavauth are incompatible. You may experience unexpected behavior. Please ask your system administrator to disable one of them.').'</p>');
71
+    }
72
+    if(!function_exists('ldap_connect')) {
73
+        print_unescaped('<p class="ldapwarning">'.$l->t('<b>Warning:</b> The PHP LDAP module is not installed, the backend will not work. Please ask your system administrator to install it.').'</p>');
74
+    }
75
+    ?>
76 76
 	<?php require_once(__DIR__ . '/part.wizard-server.php'); ?>
77 77
 	<?php require_once(__DIR__ . '/part.wizard-userfilter.php'); ?>
78 78
 	<?php require_once(__DIR__ . '/part.wizard-loginfilter.php'); ?>
Please login to merge, or discard this patch.
apps/user_ldap/templates/part.wizard-server.php 1 patch
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -9,19 +9,19 @@
 block discarded – undo
9 9
 		<p>
10 10
 		<select id="ldap_serverconfig_chooser" name="ldap_serverconfig_chooser">
11 11
 		<?php if(count($_['serverConfigurationPrefixes']) === 0 ) {
12
-			?>
12
+            ?>
13 13
 				<option value="" selected><?php p($l->t('1. Server'));?></option>');
14 14
 			<?php
15
-		} else {
16
-			$i = 1;
17
-			$sel = ' selected';
18
-			foreach($_['serverConfigurationPrefixes'] as $prefix) {
19
-				?>
15
+        } else {
16
+            $i = 1;
17
+            $sel = ' selected';
18
+            foreach($_['serverConfigurationPrefixes'] as $prefix) {
19
+                ?>
20 20
 				<option value="<?php p($prefix); ?>"<?php p($sel); $sel = ''; ?>><?php p($l->t('%s. Server:', array($i++)));?> <?php p(' '.$_['serverConfigurationHosts'][$prefix]); ?></option>
21 21
 				<?php
22
-			}
23
-		}
24
-		?>
22
+            }
23
+        }
24
+        ?>
25 25
 		</select>
26 26
 		<button type="button" id="ldap_action_add_configuration"
27 27
 			name="ldap_action_add_configuration" class="icon-add icon-default-style"
Please login to merge, or discard this patch.
apps/user_ldap/ajax/clearMappings.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -34,16 +34,16 @@
 block discarded – undo
34 34
 $subject = (string)$_POST['ldap_clear_mapping'];
35 35
 $mapping = null;
36 36
 if($subject === 'user') {
37
-	$mapping = new UserMapping(\OC::$server->getDatabaseConnection());
37
+    $mapping = new UserMapping(\OC::$server->getDatabaseConnection());
38 38
 } else if($subject === 'group') {
39
-	$mapping = new GroupMapping(\OC::$server->getDatabaseConnection());
39
+    $mapping = new GroupMapping(\OC::$server->getDatabaseConnection());
40 40
 }
41 41
 try {
42
-	if(is_null($mapping) || !$mapping->clear()) {
43
-		$l = \OC::$server->getL10N('user_ldap');
44
-		throw new \Exception($l->t('Failed to clear the mappings.'));
45
-	}
46
-	OCP\JSON::success();
42
+    if(is_null($mapping) || !$mapping->clear()) {
43
+        $l = \OC::$server->getL10N('user_ldap');
44
+        throw new \Exception($l->t('Failed to clear the mappings.'));
45
+    }
46
+    OCP\JSON::success();
47 47
 } catch (\Exception $e) {
48
-	OCP\JSON::error(array('message' => $e->getMessage()));
48
+    OCP\JSON::error(array('message' => $e->getMessage()));
49 49
 }
Please login to merge, or discard this patch.
apps/user_ldap/ajax/testConfiguration.php 1 patch
Indentation   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -37,24 +37,24 @@  discard block
 block discarded – undo
37 37
 
38 38
 
39 39
 try {
40
-	$configurationOk = true;
41
-	$conf = $connection->getConfiguration();
42
-	if ($conf['ldap_configuration_active'] === '0') {
43
-		//needs to be true, otherwise it will also fail with an irritating message
44
-		$conf['ldap_configuration_active'] = '1';
45
-		$configurationOk = $connection->setConfiguration($conf);
46
-	}
47
-	if ($configurationOk) {
48
-		//Configuration is okay
49
-		/*
40
+    $configurationOk = true;
41
+    $conf = $connection->getConfiguration();
42
+    if ($conf['ldap_configuration_active'] === '0') {
43
+        //needs to be true, otherwise it will also fail with an irritating message
44
+        $conf['ldap_configuration_active'] = '1';
45
+        $configurationOk = $connection->setConfiguration($conf);
46
+    }
47
+    if ($configurationOk) {
48
+        //Configuration is okay
49
+        /*
50 50
 		 * Clossing the session since it won't be used from this point on. There might be a potential
51 51
 		 * race condition if a second request is made: either this request or the other might not
52 52
 		 * contact the LDAP backup server the first time when it should, but there shouldn't be any
53 53
 		 * problem with that other than the extra connection.
54 54
 		 */
55
-		\OC::$server->getSession()->close();
56
-		if ($connection->bind()) {
57
-			/*
55
+        \OC::$server->getSession()->close();
56
+        if ($connection->bind()) {
57
+            /*
58 58
 			 * This shiny if block is an ugly hack to find out whether anonymous
59 59
 			 * bind is possible on AD or not. Because AD happily and constantly
60 60
 			 * replies with success to any anonymous bind request, we need to
@@ -63,24 +63,24 @@  discard block
 block discarded – undo
63 63
 			 * exception by the LDAP wrapper. We catch this. Other cases may
64 64
 			 * pass (like e.g. expected syntax error).
65 65
 			 */
66
-			try {
67
-				$ldapWrapper->read($connection->getConnectionResource(), '', 'objectClass=*', array('dn'));
68
-			} catch (\Exception $e) {
69
-				if($e->getCode() === 1) {
70
-					OCP\JSON::error(array('message' => $l->t('The configuration is invalid: anonymous bind is not allowed.')));
71
-					exit;
72
-				}
73
-			}
74
-			OCP\JSON::success(array('message'
75
-			=> $l->t('The configuration is valid and the connection could be established!')));
76
-		} else {
77
-			OCP\JSON::error(array('message'
78
-			=> $l->t('The configuration is valid, but the Bind failed. Please check the server settings and credentials.')));
79
-		}
80
-	} else {
81
-		OCP\JSON::error(array('message'
82
-		=> $l->t('The configuration is invalid. Please have a look at the logs for further details.')));
83
-	}
66
+            try {
67
+                $ldapWrapper->read($connection->getConnectionResource(), '', 'objectClass=*', array('dn'));
68
+            } catch (\Exception $e) {
69
+                if($e->getCode() === 1) {
70
+                    OCP\JSON::error(array('message' => $l->t('The configuration is invalid: anonymous bind is not allowed.')));
71
+                    exit;
72
+                }
73
+            }
74
+            OCP\JSON::success(array('message'
75
+            => $l->t('The configuration is valid and the connection could be established!')));
76
+        } else {
77
+            OCP\JSON::error(array('message'
78
+            => $l->t('The configuration is valid, but the Bind failed. Please check the server settings and credentials.')));
79
+        }
80
+    } else {
81
+        OCP\JSON::error(array('message'
82
+        => $l->t('The configuration is invalid. Please have a look at the logs for further details.')));
83
+    }
84 84
 } catch (\Exception $e) {
85
-	OCP\JSON::error(array('message' => $e->getMessage()));
85
+    OCP\JSON::error(array('message' => $e->getMessage()));
86 86
 }
Please login to merge, or discard this patch.
apps/user_ldap/ajax/getConfiguration.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
 $connection = new \OCA\User_LDAP\Connection($ldapWrapper, $prefix);
35 35
 $configuration = $connection->getConfiguration();
36 36
 if (isset($configuration['ldap_agent_password']) && $configuration['ldap_agent_password'] !== '') {
37
-	// hide password
38
-	$configuration['ldap_agent_password'] = '**PASSWORD SET**';
37
+    // hide password
38
+    $configuration['ldap_agent_password'] = '**PASSWORD SET**';
39 39
 }
40 40
 OCP\JSON::success(array('configuration' => $configuration));
Please login to merge, or discard this patch.
apps/user_ldap/ajax/setConfiguration.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -36,11 +36,11 @@
 block discarded – undo
36 36
 // only legacy checkboxes (Advanced and Expert tab) need to be handled here,
37 37
 // the Wizard-like tabs handle it on their own
38 38
 $chkboxes = array('ldap_configuration_active', 'ldap_override_main_server',
39
-				  'ldap_turn_off_cert_check');
39
+                    'ldap_turn_off_cert_check');
40 40
 foreach($chkboxes as $boxid) {
41
-	if(!isset($_POST[$boxid])) {
42
-		$_POST[$boxid] = 0;
43
-	}
41
+    if(!isset($_POST[$boxid])) {
42
+        $_POST[$boxid] = 0;
43
+    }
44 44
 }
45 45
 
46 46
 $ldapWrapper = new OCA\User_LDAP\LDAP();
Please login to merge, or discard this patch.
apps/user_ldap/ajax/deleteConfiguration.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,8 +34,8 @@
 block discarded – undo
34 34
 $prefix = (string)$_POST['ldap_serverconfig_chooser'];
35 35
 $helper = new \OCA\User_LDAP\Helper(\OC::$server->getConfig());
36 36
 if($helper->deleteServerConfiguration($prefix)) {
37
-	OCP\JSON::success();
37
+    OCP\JSON::success();
38 38
 } else {
39
-	$l = \OC::$server->getL10N('user_ldap');
40
-	OCP\JSON::error(array('message' => $l->t('Failed to delete the server configuration')));
39
+    $l = \OC::$server->getL10N('user_ldap');
40
+    OCP\JSON::error(array('message' => $l->t('Failed to delete the server configuration')));
41 41
 }
Please login to merge, or discard this patch.
apps/user_ldap/ajax/wizard.php 1 patch
Indentation   +79 added lines, -79 removed lines patch added patch discarded remove patch
@@ -33,13 +33,13 @@  discard block
 block discarded – undo
33 33
 $l = \OC::$server->getL10N('user_ldap');
34 34
 
35 35
 if(!isset($_POST['action'])) {
36
-	\OCP\JSON::error(array('message' => $l->t('No action specified')));
36
+    \OCP\JSON::error(array('message' => $l->t('No action specified')));
37 37
 }
38 38
 $action = (string)$_POST['action'];
39 39
 
40 40
 
41 41
 if(!isset($_POST['ldap_serverconfig_chooser'])) {
42
-	\OCP\JSON::error(array('message' => $l->t('No configuration specified')));
42
+    \OCP\JSON::error(array('message' => $l->t('No configuration specified')));
43 43
 }
44 44
 $prefix = (string)$_POST['ldap_serverconfig_chooser'];
45 45
 
@@ -52,90 +52,90 @@  discard block
 block discarded – undo
52 52
 $con->setIgnoreValidation(true);
53 53
 
54 54
 $userManager = new \OCA\User_LDAP\User\Manager(
55
-	\OC::$server->getConfig(),
56
-	new \OCA\User_LDAP\FilesystemHelper(),
57
-	new \OCA\User_LDAP\LogWrapper(),
58
-	\OC::$server->getAvatarManager(),
59
-	new \OCP\Image(),
60
-	\OC::$server->getDatabaseConnection(),
61
-	\OC::$server->getUserManager());
55
+    \OC::$server->getConfig(),
56
+    new \OCA\User_LDAP\FilesystemHelper(),
57
+    new \OCA\User_LDAP\LogWrapper(),
58
+    \OC::$server->getAvatarManager(),
59
+    new \OCP\Image(),
60
+    \OC::$server->getDatabaseConnection(),
61
+    \OC::$server->getUserManager());
62 62
 
63 63
 $access = new \OCA\User_LDAP\Access($con, $ldapWrapper, $userManager, new \OCA\User_LDAP\Helper(
64
-	\OC::$server->getConfig()
64
+    \OC::$server->getConfig()
65 65
 ));
66 66
 
67 67
 $wizard = new \OCA\User_LDAP\Wizard($configuration, $ldapWrapper, $access);
68 68
 
69 69
 switch($action) {
70
-	case 'guessPortAndTLS':
71
-	case 'guessBaseDN':
72
-	case 'detectEmailAttribute':
73
-	case 'detectUserDisplayNameAttribute':
74
-	case 'determineGroupMemberAssoc':
75
-	case 'determineUserObjectClasses':
76
-	case 'determineGroupObjectClasses':
77
-	case 'determineGroupsForUsers':
78
-	case 'determineGroupsForGroups':
79
-	case 'determineAttributes':
80
-	case 'getUserListFilter':
81
-	case 'getUserLoginFilter':
82
-	case 'getGroupFilter':
83
-	case 'countUsers':
84
-	case 'countGroups':
85
-	case 'countInBaseDN':
86
-		try {
87
-			$result = $wizard->$action();
88
-			if($result !== false) {
89
-				OCP\JSON::success($result->getResultArray());
90
-				exit;
91
-			}
92
-		} catch (\Exception $e) {
93
-			\OCP\JSON::error(array('message' => $e->getMessage(), 'code' => $e->getCode()));
94
-			exit;
95
-		}
96
-		\OCP\JSON::error();
97
-		exit;
98
-		break;
70
+    case 'guessPortAndTLS':
71
+    case 'guessBaseDN':
72
+    case 'detectEmailAttribute':
73
+    case 'detectUserDisplayNameAttribute':
74
+    case 'determineGroupMemberAssoc':
75
+    case 'determineUserObjectClasses':
76
+    case 'determineGroupObjectClasses':
77
+    case 'determineGroupsForUsers':
78
+    case 'determineGroupsForGroups':
79
+    case 'determineAttributes':
80
+    case 'getUserListFilter':
81
+    case 'getUserLoginFilter':
82
+    case 'getGroupFilter':
83
+    case 'countUsers':
84
+    case 'countGroups':
85
+    case 'countInBaseDN':
86
+        try {
87
+            $result = $wizard->$action();
88
+            if($result !== false) {
89
+                OCP\JSON::success($result->getResultArray());
90
+                exit;
91
+            }
92
+        } catch (\Exception $e) {
93
+            \OCP\JSON::error(array('message' => $e->getMessage(), 'code' => $e->getCode()));
94
+            exit;
95
+        }
96
+        \OCP\JSON::error();
97
+        exit;
98
+        break;
99 99
 
100
-	case 'testLoginName': {
101
-		try {
102
-			$loginName = $_POST['ldap_test_loginname'];
103
-			$result = $wizard->$action($loginName);
104
-			if($result !== false) {
105
-				OCP\JSON::success($result->getResultArray());
106
-				exit;
107
-			}
108
-		} catch (\Exception $e) {
109
-			\OCP\JSON::error(array('message' => $e->getMessage()));
110
-			exit;
111
-		}
112
-		\OCP\JSON::error();
113
-		exit;
114
-		break;
115
-	}
100
+    case 'testLoginName': {
101
+        try {
102
+            $loginName = $_POST['ldap_test_loginname'];
103
+            $result = $wizard->$action($loginName);
104
+            if($result !== false) {
105
+                OCP\JSON::success($result->getResultArray());
106
+                exit;
107
+            }
108
+        } catch (\Exception $e) {
109
+            \OCP\JSON::error(array('message' => $e->getMessage()));
110
+            exit;
111
+        }
112
+        \OCP\JSON::error();
113
+        exit;
114
+        break;
115
+    }
116 116
 
117
-	case 'save':
118
-		$key = isset($_POST['cfgkey']) ? $_POST['cfgkey'] : false;
119
-		$val = isset($_POST['cfgval']) ? $_POST['cfgval'] : null;
120
-		if($key === false || is_null($val)) {
121
-			\OCP\JSON::error(array('message' => $l->t('No data specified')));
122
-			exit;
123
-		}
124
-		$cfg = array($key => $val);
125
-		$setParameters = array();
126
-		$configuration->setConfiguration($cfg, $setParameters);
127
-		if(!in_array($key, $setParameters)) {
128
-			\OCP\JSON::error(array('message' => $l->t($key.
129
-				' Could not set configuration %s', $setParameters[0])));
130
-			exit;
131
-		}
132
-		$configuration->saveConfiguration();
133
-		//clear the cache on save
134
-		$connection = new \OCA\User_LDAP\Connection($ldapWrapper, $prefix);
135
-		$connection->clearCache();
136
-		OCP\JSON::success();
137
-		break;
138
-	default:
139
-		\OCP\JSON::error(array('message' => $l->t('Action does not exist')));
140
-		break;
117
+    case 'save':
118
+        $key = isset($_POST['cfgkey']) ? $_POST['cfgkey'] : false;
119
+        $val = isset($_POST['cfgval']) ? $_POST['cfgval'] : null;
120
+        if($key === false || is_null($val)) {
121
+            \OCP\JSON::error(array('message' => $l->t('No data specified')));
122
+            exit;
123
+        }
124
+        $cfg = array($key => $val);
125
+        $setParameters = array();
126
+        $configuration->setConfiguration($cfg, $setParameters);
127
+        if(!in_array($key, $setParameters)) {
128
+            \OCP\JSON::error(array('message' => $l->t($key.
129
+                ' Could not set configuration %s', $setParameters[0])));
130
+            exit;
131
+        }
132
+        $configuration->saveConfiguration();
133
+        //clear the cache on save
134
+        $connection = new \OCA\User_LDAP\Connection($ldapWrapper, $prefix);
135
+        $connection->clearCache();
136
+        OCP\JSON::success();
137
+        break;
138
+    default:
139
+        \OCP\JSON::error(array('message' => $l->t('Action does not exist')));
140
+        break;
141 141
 }
Please login to merge, or discard this patch.