nextcloud / server

apps/files_sharing/lib/Activity/Providers/Groups.php

Indentation +78 added lines, -78 removed lines

@@ -25,92 +25,92 @@
 
 class Groups extends Base {
 
-	const SUBJECT_SHARED_GROUP_SELF = 'shared_group_self';
-	const SUBJECT_RESHARED_GROUP_BY = 'reshared_group_by';
-	const SUBJECT_UNSHARED_GROUP_SELF = 'unshared_group_self';
-	const SUBJECT_UNSHARED_GROUP_BY = 'unshared_group_by';
+    const SUBJECT_SHARED_GROUP_SELF = 'shared_group_self';
+    const SUBJECT_RESHARED_GROUP_BY = 'reshared_group_by';
+    const SUBJECT_UNSHARED_GROUP_SELF = 'unshared_group_self';
+    const SUBJECT_UNSHARED_GROUP_BY = 'unshared_group_by';
 
-	/**
-	 * @param IEvent $event
-	 * @return IEvent
-	 * @throws \InvalidArgumentException
-	 * @since 11.0.0
-	 */
-	public function parseShortVersion(IEvent $event) {
-		$parsedParameters = $this->getParsedParameters($event);
+    /**
+     * @param IEvent $event
+     * @return IEvent
+     * @throws \InvalidArgumentException
+     * @since 11.0.0
+     */
+    public function parseShortVersion(IEvent $event) {
+        $parsedParameters = $this->getParsedParameters($event);
 
-		if ($event->getSubject() === self::SUBJECT_SHARED_GROUP_SELF) {
-			$subject = $this->l->t('Shared with group {group}');
-		} else if ($event->getSubject() === self::SUBJECT_UNSHARED_GROUP_SELF) {
-			$subject = $this->l->t('Removed share for group {group}');
-		} else if ($event->getSubject() === self::SUBJECT_RESHARED_GROUP_BY) {
-			$subject = $this->l->t('{actor} shared with group {group}');
-		} else if ($event->getSubject() === self::SUBJECT_UNSHARED_GROUP_BY) {
-			$subject = $this->l->t('{actor} removed share for group {group}');
-		} else {
-			throw new \InvalidArgumentException();
-		}
+        if ($event->getSubject() === self::SUBJECT_SHARED_GROUP_SELF) {
+            $subject = $this->l->t('Shared with group {group}');
+        } else if ($event->getSubject() === self::SUBJECT_UNSHARED_GROUP_SELF) {
+            $subject = $this->l->t('Removed share for group {group}');
+        } else if ($event->getSubject() === self::SUBJECT_RESHARED_GROUP_BY) {
+            $subject = $this->l->t('{actor} shared with group {group}');
+        } else if ($event->getSubject() === self::SUBJECT_UNSHARED_GROUP_BY) {
+            $subject = $this->l->t('{actor} removed share for group {group}');
+        } else {
+            throw new \InvalidArgumentException();
+        }
 
-		$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/share.svg')));
-		$this->setSubjects($event, $subject, $parsedParameters);
+        $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/share.svg')));
+        $this->setSubjects($event, $subject, $parsedParameters);
 
-		return $event;
-	}
+        return $event;
+    }
 
-	/**
-	 * @param IEvent $event
-	 * @return IEvent
-	 * @throws \InvalidArgumentException
-	 * @since 11.0.0
-	 */
-	public function parseLongVersion(IEvent $event) {
-		$parsedParameters = $this->getParsedParameters($event);
+    /**
+     * @param IEvent $event
+     * @return IEvent
+     * @throws \InvalidArgumentException
+     * @since 11.0.0
+     */
+    public function parseLongVersion(IEvent $event) {
+        $parsedParameters = $this->getParsedParameters($event);
 
-		if ($event->getSubject() === self::SUBJECT_SHARED_GROUP_SELF) {
-			$subject = $this->l->t('You shared {file} with group {group}');
-		} else if ($event->getSubject() === self::SUBJECT_UNSHARED_GROUP_SELF) {
-			$subject = $this->l->t('You removed group {group} from {file}');
-		} else if ($event->getSubject() === self::SUBJECT_RESHARED_GROUP_BY) {
-			$subject = $this->l->t('{actor} shared {file} with group {group}');
-		} else if ($event->getSubject() === self::SUBJECT_UNSHARED_GROUP_BY) {
-			$subject = $this->l->t('{actor} removed group {group} from {file}');
-		} else {
-			throw new \InvalidArgumentException();
-		}
+        if ($event->getSubject() === self::SUBJECT_SHARED_GROUP_SELF) {
+            $subject = $this->l->t('You shared {file} with group {group}');
+        } else if ($event->getSubject() === self::SUBJECT_UNSHARED_GROUP_SELF) {
+            $subject = $this->l->t('You removed group {group} from {file}');
+        } else if ($event->getSubject() === self::SUBJECT_RESHARED_GROUP_BY) {
+            $subject = $this->l->t('{actor} shared {file} with group {group}');
+        } else if ($event->getSubject() === self::SUBJECT_UNSHARED_GROUP_BY) {
+            $subject = $this->l->t('{actor} removed group {group} from {file}');
+        } else {
+            throw new \InvalidArgumentException();
+        }
 
-		$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/share.svg')));
-		$this->setSubjects($event, $subject, $parsedParameters);
+        $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/share.svg')));
+        $this->setSubjects($event, $subject, $parsedParameters);
 
-		return $event;
-	}
+        return $event;
+    }
 
-	protected function getParsedParameters(IEvent $event) {
-		$subject = $event->getSubject();
-		$parameters = $event->getSubjectParameters();
+    protected function getParsedParameters(IEvent $event) {
+        $subject = $event->getSubject();
+        $parameters = $event->getSubjectParameters();
 
-		switch ($subject) {
-			case self::SUBJECT_RESHARED_GROUP_BY:
-			case self::SUBJECT_UNSHARED_GROUP_BY:
-				return [
-					'file' => $this->getFile($parameters[0], $event),
-					'group' => [
-						'type' => 'group',
-						'id' => $parameters[2],
-						'name' => $parameters[2],
-					],
-					'actor' => $this->getUser($parameters[1]),
-				];
-			case self::SUBJECT_SHARED_GROUP_SELF:
-			case self::SUBJECT_UNSHARED_GROUP_SELF:
-				return [
-					'file' => $this->getFile($parameters[0], $event),
-					'group' => [
-						'type' => 'group',
-						'id' => $parameters[1],
-						'name' => $parameters[1],
-					],
-				];
-		}
-		return [];
-	}
+        switch ($subject) {
+            case self::SUBJECT_RESHARED_GROUP_BY:
+            case self::SUBJECT_UNSHARED_GROUP_BY:
+                return [
+                    'file' => $this->getFile($parameters[0], $event),
+                    'group' => [
+                        'type' => 'group',
+                        'id' => $parameters[2],
+                        'name' => $parameters[2],
+                    ],
+                    'actor' => $this->getUser($parameters[1]),
+                ];
+            case self::SUBJECT_SHARED_GROUP_SELF:
+            case self::SUBJECT_UNSHARED_GROUP_SELF:
+                return [
+                    'file' => $this->getFile($parameters[0], $event),
+                    'group' => [
+                        'type' => 'group',
+                        'id' => $parameters[1],
+                        'name' => $parameters[1],
+                    ],
+                ];
+        }
+        return [];
+    }
 }

apps/files_sharing/lib/Activity/Settings/Shared.php

Indentation +59 added lines, -59 removed lines

@@ -27,72 +27,72 @@
 
 class Shared implements ISetting {
 
-	/** @var IL10N */
-	protected $l;
+    /** @var IL10N */
+    protected $l;
 
-	/**
-	 * @param IL10N $l
-	 */
-	public function __construct(IL10N $l) {
-		$this->l = $l;
-	}
+    /**
+     * @param IL10N $l
+     */
+    public function __construct(IL10N $l) {
+        $this->l = $l;
+    }
 
-	/**
-	 * @return string Lowercase a-z and underscore only identifier
-	 * @since 11.0.0
-	 */
-	public function getIdentifier() {
-		return 'shared';
-	}
+    /**
+     * @return string Lowercase a-z and underscore only identifier
+     * @since 11.0.0
+     */
+    public function getIdentifier() {
+        return 'shared';
+    }
 
-	/**
-	 * @return string A translated string
-	 * @since 11.0.0
-	 */
-	public function getName() {
-		return $this->l->t('A file or folder has been <strong>shared</strong>');
-	}
+    /**
+     * @return string A translated string
+     * @since 11.0.0
+     */
+    public function getName() {
+        return $this->l->t('A file or folder has been <strong>shared</strong>');
+    }
 
-	/**
-	 * @return int whether the filter should be rather on the top or bottom of
-	 * the admin section. The filters are arranged in ascending order of the
-	 * priority values. It is required to return a value between 0 and 100.
-	 * @since 11.0.0
-	 */
-	public function getPriority() {
-		return 10;
-	}
+    /**
+     * @return int whether the filter should be rather on the top or bottom of
+     * the admin section. The filters are arranged in ascending order of the
+     * priority values. It is required to return a value between 0 and 100.
+     * @since 11.0.0
+     */
+    public function getPriority() {
+        return 10;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function canChangeStream() {
-		return true;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function canChangeStream() {
+        return true;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function isDefaultEnabledStream() {
-		return true;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function isDefaultEnabledStream() {
+        return true;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the mail
-	 * @since 11.0.0
-	 */
-	public function canChangeMail() {
-		return true;
-	}
+    /**
+     * @return bool True when the option can be changed for the mail
+     * @since 11.0.0
+     */
+    public function canChangeMail() {
+        return true;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function isDefaultEnabledMail() {
-		return true;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function isDefaultEnabledMail() {
+        return true;
+    }
 }
 

apps/files_sharing/lib/Activity/Settings/PublicLinks.php

Indentation +59 added lines, -59 removed lines

@@ -27,72 +27,72 @@
 
 class PublicLinks implements ISetting {
 
-	/** @var IL10N */
-	protected $l;
+    /** @var IL10N */
+    protected $l;
 
-	/**
-	 * @param IL10N $l
-	 */
-	public function __construct(IL10N $l) {
-		$this->l = $l;
-	}
+    /**
+     * @param IL10N $l
+     */
+    public function __construct(IL10N $l) {
+        $this->l = $l;
+    }
 
-	/**
-	 * @return string Lowercase a-z and underscore only identifier
-	 * @since 11.0.0
-	 */
-	public function getIdentifier() {
-		return 'public_links';
-	}
+    /**
+     * @return string Lowercase a-z and underscore only identifier
+     * @since 11.0.0
+     */
+    public function getIdentifier() {
+        return 'public_links';
+    }
 
-	/**
-	 * @return string A translated string
-	 * @since 11.0.0
-	 */
-	public function getName() {
-		return $this->l->t('A file or folder shared by mail or by public link was <strong>downloaded</strong>');
-	}
+    /**
+     * @return string A translated string
+     * @since 11.0.0
+     */
+    public function getName() {
+        return $this->l->t('A file or folder shared by mail or by public link was <strong>downloaded</strong>');
+    }
 
-	/**
-	 * @return int whether the filter should be rather on the top or bottom of
-	 * the admin section. The filters are arranged in ascending order of the
-	 * priority values. It is required to return a value between 0 and 100.
-	 * @since 11.0.0
-	 */
-	public function getPriority() {
-		return 20;
-	}
+    /**
+     * @return int whether the filter should be rather on the top or bottom of
+     * the admin section. The filters are arranged in ascending order of the
+     * priority values. It is required to return a value between 0 and 100.
+     * @since 11.0.0
+     */
+    public function getPriority() {
+        return 20;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function canChangeStream() {
-		return true;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function canChangeStream() {
+        return true;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function isDefaultEnabledStream() {
-		return true;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function isDefaultEnabledStream() {
+        return true;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the mail
-	 * @since 11.0.0
-	 */
-	public function canChangeMail() {
-		return true;
-	}
+    /**
+     * @return bool True when the option can be changed for the mail
+     * @since 11.0.0
+     */
+    public function canChangeMail() {
+        return true;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function isDefaultEnabledMail() {
-		return false;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function isDefaultEnabledMail() {
+        return false;
+    }
 }
 

apps/files_sharing/lib/Activity/Settings/RemoteShare.php

Indentation +59 added lines, -59 removed lines

@@ -27,72 +27,72 @@
 
 class RemoteShare implements ISetting {
 
-	/** @var IL10N */
-	protected $l;
+    /** @var IL10N */
+    protected $l;
 
-	/**
-	 * @param IL10N $l
-	 */
-	public function __construct(IL10N $l) {
-		$this->l = $l;
-	}
+    /**
+     * @param IL10N $l
+     */
+    public function __construct(IL10N $l) {
+        $this->l = $l;
+    }
 
-	/**
-	 * @return string Lowercase a-z and underscore only identifier
-	 * @since 11.0.0
-	 */
-	public function getIdentifier() {
-		return 'remote_share';
-	}
+    /**
+     * @return string Lowercase a-z and underscore only identifier
+     * @since 11.0.0
+     */
+    public function getIdentifier() {
+        return 'remote_share';
+    }
 
-	/**
-	 * @return string A translated string
-	 * @since 11.0.0
-	 */
-	public function getName() {
-		return $this->l->t('A file or folder was shared from <strong>another server</strong>');
-	}
+    /**
+     * @return string A translated string
+     * @since 11.0.0
+     */
+    public function getName() {
+        return $this->l->t('A file or folder was shared from <strong>another server</strong>');
+    }
 
-	/**
-	 * @return int whether the filter should be rather on the top or bottom of
-	 * the admin section. The filters are arranged in ascending order of the
-	 * priority values. It is required to return a value between 0 and 100.
-	 * @since 11.0.0
-	 */
-	public function getPriority() {
-		return 11;
-	}
+    /**
+     * @return int whether the filter should be rather on the top or bottom of
+     * the admin section. The filters are arranged in ascending order of the
+     * priority values. It is required to return a value between 0 and 100.
+     * @since 11.0.0
+     */
+    public function getPriority() {
+        return 11;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function canChangeStream() {
-		return true;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function canChangeStream() {
+        return true;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function isDefaultEnabledStream() {
-		return true;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function isDefaultEnabledStream() {
+        return true;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the mail
-	 * @since 11.0.0
-	 */
-	public function canChangeMail() {
-		return true;
-	}
+    /**
+     * @return bool True when the option can be changed for the mail
+     * @since 11.0.0
+     */
+    public function canChangeMail() {
+        return true;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function isDefaultEnabledMail() {
-		return true;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function isDefaultEnabledMail() {
+        return true;
+    }
 }
 

apps/files_sharing/lib/Activity/Filter.php

Indentation +56 added lines, -56 removed lines

@@ -27,69 +27,69 @@
 use OCP\IURLGenerator;
 
 class Filter implements IFilter {
-	const TYPE_REMOTE_SHARE = 'remote_share';
-	const TYPE_SHARED = 'shared';
+    const TYPE_REMOTE_SHARE = 'remote_share';
+    const TYPE_SHARED = 'shared';
 
-	/** @var IL10N */
-	protected $l;
+    /** @var IL10N */
+    protected $l;
 
-	/** @var IURLGenerator */
-	protected $url;
+    /** @var IURLGenerator */
+    protected $url;
 
-	public function __construct(IL10N $l, IURLGenerator $url) {
-		$this->l = $l;
-		$this->url = $url;
-	}
+    public function __construct(IL10N $l, IURLGenerator $url) {
+        $this->l = $l;
+        $this->url = $url;
+    }
 
-	/**
-	 * @return string Lowercase a-z only identifier
-	 * @since 11.0.0
-	 */
-	public function getIdentifier() {
-		return 'files_sharing';
-	}
+    /**
+     * @return string Lowercase a-z only identifier
+     * @since 11.0.0
+     */
+    public function getIdentifier() {
+        return 'files_sharing';
+    }
 
-	/**
-	 * @return string A translated string
-	 * @since 11.0.0
-	 */
-	public function getName() {
-		return $this->l->t('File shares');
-	}
+    /**
+     * @return string A translated string
+     * @since 11.0.0
+     */
+    public function getName() {
+        return $this->l->t('File shares');
+    }
 
-	/**
-	 * @return int
-	 * @since 11.0.0
-	 */
-	public function getPriority() {
-		return 31;
-	}
+    /**
+     * @return int
+     * @since 11.0.0
+     */
+    public function getPriority() {
+        return 31;
+    }
 
-	/**
-	 * @return string Full URL to an icon, empty string when none is given
-	 * @since 11.0.0
-	 */
-	public function getIcon() {
-		return $this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/share.svg'));
-	}
+    /**
+     * @return string Full URL to an icon, empty string when none is given
+     * @since 11.0.0
+     */
+    public function getIcon() {
+        return $this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/share.svg'));
+    }
 
-	/**
-	 * @param string[] $types
-	 * @return string[] An array of allowed apps from which activities should be displayed
-	 * @since 11.0.0
-	 */
-	public function filterTypes(array $types) {
-		return array_intersect([
-			self::TYPE_SHARED,
-			self::TYPE_REMOTE_SHARE
-		], $types);
-	}
+    /**
+     * @param string[] $types
+     * @return string[] An array of allowed apps from which activities should be displayed
+     * @since 11.0.0
+     */
+    public function filterTypes(array $types) {
+        return array_intersect([
+            self::TYPE_SHARED,
+            self::TYPE_REMOTE_SHARE
+        ], $types);
+    }
 
-	/**
-	 * @return string[] An array of allowed apps from which activities should be displayed
-	 * @since 11.0.0
-	 */
-	public function allowedApps() {
-		return ['files_sharing'];
-	}
+    /**
+     * @return string[] An array of allowed apps from which activities should be displayed
+     * @since 11.0.0
+     */
+    public function allowedApps() {
+        return ['files_sharing'];
+    }
 }

apps/files_sharing/lib/Migration.php

Indentation +247 added lines, -247 removed lines

@@ -39,252 +39,252 @@
  */
 class Migration {
 
-	/** @var IDBConnection */
-	private $connection;
-
-	/** @var  IConfig */
-	private $config;
-
-	/** @var  ICache with all shares we already saw */
-	private $shareCache;
-
-	/** @var string */
-	private $table = 'share';
-
-	public function __construct(IDBConnection $connection, IConfig $config) {
-		$this->connection = $connection;
-		$this->config = $config;
-
-		// We cache up to 10k share items (~20MB)
-		$this->shareCache = new CappedMemoryCache(10000);
-	}
-
-	/**
-	 * move all re-shares to the owner in order to have a flat list of shares
-	 * upgrade from oC 8.2 to 9.0 with the new sharing
-	 */
-	public function removeReShares() {
-
-		$stmt = $this->getReShares();
-
-		$owners = [];
-		while($share = $stmt->fetch()) {
-
-			$this->shareCache[$share['id']] = $share;
-
-			$owners[$share['id']] = [
-					'owner' => $this->findOwner($share),
-					'initiator' => $share['uid_owner'],
-					'type' => $share['share_type'],
-			];
-
-			if (count($owners) === 1000) {
-				$this->updateOwners($owners);
-				$owners = [];
-			}
-		}
-
-		$stmt->closeCursor();
-
-		if (count($owners)) {
-			$this->updateOwners($owners);
-		}
-	}
-
-	/**
-	 * update all owner information so that all shares have an owner
-	 * and an initiator for the upgrade from oC 8.2 to 9.0 with the new sharing
-	 */
-	public function updateInitiatorInfo() {
-		while (true) {
-			$shares = $this->getMissingInitiator(1000);
-
-			if (empty($shares)) {
-				break;
-			}
-
-			$owners = [];
-			foreach ($shares as $share) {
-				$owners[$share['id']] = [
-					'owner' => $share['uid_owner'],
-					'initiator' => $share['uid_owner'],
-					'type' => $share['share_type'],
-				];
-			}
-			$this->updateOwners($owners);
-		}
-	}
-
-	/**
-	 * this was dropped for Nextcloud 11 in favour of share by mail
-	 */
-	public function removeSendMailOption() {
-		$this->config->deleteAppValue('core', 'shareapi_allow_mail_notification');
-		$this->config->deleteAppValue('core', 'shareapi_allow_public_notification');
-	}
-
-	/**
-	 * find the owner of a re-shared file/folder
-	 *
-	 * @param array $share
-	 * @return array
-	 */
-	private function findOwner($share) {
-		$currentShare = $share;
-		while(!is_null($currentShare['parent'])) {
-			if (isset($this->shareCache[$currentShare['parent']])) {
-				$currentShare = $this->shareCache[$currentShare['parent']];
-			} else {
-				$currentShare = $this->getShare((int)$currentShare['parent']);
-				$this->shareCache[$currentShare['id']] = $currentShare;
-			}
-		}
-
-		return $currentShare['uid_owner'];
-	}
-
-	/**
-	 * Get $n re-shares from the database
-	 *
-	 * @param int $n The max number of shares to fetch
-	 * @return \Doctrine\DBAL\Driver\Statement
-	 */
-	private function getReShares() {
-		$query = $this->connection->getQueryBuilder();
-		$query->select(['id', 'parent', 'uid_owner', 'share_type'])
-			->from($this->table)
-			->where($query->expr()->in(
-				'share_type',
-				$query->createNamedParameter(
-					[
-						\OCP\Share::SHARE_TYPE_USER,
-						\OCP\Share::SHARE_TYPE_GROUP,
-						\OCP\Share::SHARE_TYPE_LINK,
-						\OCP\Share::SHARE_TYPE_REMOTE,
-					],
-					Connection::PARAM_INT_ARRAY
-				)
-			))
-			->andWhere($query->expr()->in(
-				'item_type',
-				$query->createNamedParameter(
-					['file', 'folder'],
-					Connection::PARAM_STR_ARRAY
-				)
-			))
-			->andWhere($query->expr()->isNotNull('parent'))
-			->orderBy('id', 'asc');
-		return $query->execute();
-
-
-		$shares = $result->fetchAll();
-		$result->closeCursor();
-
-		$ordered = [];
-		foreach ($shares as $share) {
-			$ordered[(int)$share['id']] = $share;
-		}
-
-		return $ordered;
-	}
-
-	/**
-	 * Get $n re-shares from the database
-	 *
-	 * @param int $n The max number of shares to fetch
-	 * @return array
-	 */
-	private function getMissingInitiator($n = 1000) {
-		$query = $this->connection->getQueryBuilder();
-		$query->select(['id', 'uid_owner', 'share_type'])
-			->from($this->table)
-			->where($query->expr()->in(
-				'share_type',
-				$query->createNamedParameter(
-					[
-						\OCP\Share::SHARE_TYPE_USER,
-						\OCP\Share::SHARE_TYPE_GROUP,
-						\OCP\Share::SHARE_TYPE_LINK,
-						\OCP\Share::SHARE_TYPE_REMOTE,
-					],
-					Connection::PARAM_INT_ARRAY
-				)
-			))
-			->andWhere($query->expr()->in(
-				'item_type',
-				$query->createNamedParameter(
-					['file', 'folder'],
-					Connection::PARAM_STR_ARRAY
-				)
-			))
-			->andWhere($query->expr()->isNull('uid_initiator'))
-			->orderBy('id', 'asc')
-			->setMaxResults($n);
-		$result = $query->execute();
-		$shares = $result->fetchAll();
-		$result->closeCursor();
-
-		$ordered = [];
-		foreach ($shares as $share) {
-			$ordered[(int)$share['id']] = $share;
-		}
-
-		return $ordered;
-	}
-
-	/**
-	 * get a specific share
-	 *
-	 * @param int $id
-	 * @return array
-	 */
-	private function getShare($id) {
-		$query = $this->connection->getQueryBuilder();
-		$query->select(['id', 'parent', 'uid_owner'])
-			->from($this->table)
-			->where($query->expr()->eq('id', $query->createNamedParameter($id)));
-		$result = $query->execute();
-		$share = $result->fetchAll();
-		$result->closeCursor();
-
-		return $share[0];
-	}
-
-	/**
-	 * update database with the new owners
-	 *
-	 * @param array $owners
-	 * @throws \Exception
-	 */
-	private function updateOwners($owners) {
-
-		$this->connection->beginTransaction();
-
-		try {
-
-			foreach ($owners as $id => $owner) {
-				$query = $this->connection->getQueryBuilder();
-				$query->update($this->table)
-					->set('uid_owner', $query->createNamedParameter($owner['owner']))
-					->set('uid_initiator', $query->createNamedParameter($owner['initiator']));
-
-
-				if ((int)$owner['type'] !== \OCP\Share::SHARE_TYPE_LINK) {
-					$query->set('parent', $query->createNamedParameter(null));
-				}
-
-				$query->where($query->expr()->eq('id', $query->createNamedParameter($id)));
-
-				$query->execute();
-			}
-
-			$this->connection->commit();
-
-		} catch (\Exception $e) {
-			$this->connection->rollBack();
-			throw $e;
-		}
-
-	}
+    /** @var IDBConnection */
+    private $connection;
+
+    /** @var  IConfig */
+    private $config;
+
+    /** @var  ICache with all shares we already saw */
+    private $shareCache;
+
+    /** @var string */
+    private $table = 'share';
+
+    public function __construct(IDBConnection $connection, IConfig $config) {
+        $this->connection = $connection;
+        $this->config = $config;
+
+        // We cache up to 10k share items (~20MB)
+        $this->shareCache = new CappedMemoryCache(10000);
+    }
+
+    /**
+     * move all re-shares to the owner in order to have a flat list of shares
+     * upgrade from oC 8.2 to 9.0 with the new sharing
+     */
+    public function removeReShares() {
+
+        $stmt = $this->getReShares();
+
+        $owners = [];
+        while($share = $stmt->fetch()) {
+
+            $this->shareCache[$share['id']] = $share;
+
+            $owners[$share['id']] = [
+                    'owner' => $this->findOwner($share),
+                    'initiator' => $share['uid_owner'],
+                    'type' => $share['share_type'],
+            ];
+
+            if (count($owners) === 1000) {
+                $this->updateOwners($owners);
+                $owners = [];
+            }
+        }
+
+        $stmt->closeCursor();
+
+        if (count($owners)) {
+            $this->updateOwners($owners);
+        }
+    }
+
+    /**
+     * update all owner information so that all shares have an owner
+     * and an initiator for the upgrade from oC 8.2 to 9.0 with the new sharing
+     */
+    public function updateInitiatorInfo() {
+        while (true) {
+            $shares = $this->getMissingInitiator(1000);
+
+            if (empty($shares)) {
+                break;
+            }
+
+            $owners = [];
+            foreach ($shares as $share) {
+                $owners[$share['id']] = [
+                    'owner' => $share['uid_owner'],
+                    'initiator' => $share['uid_owner'],
+                    'type' => $share['share_type'],
+                ];
+            }
+            $this->updateOwners($owners);
+        }
+    }
+
+    /**
+     * this was dropped for Nextcloud 11 in favour of share by mail
+     */
+    public function removeSendMailOption() {
+        $this->config->deleteAppValue('core', 'shareapi_allow_mail_notification');
+        $this->config->deleteAppValue('core', 'shareapi_allow_public_notification');
+    }
+
+    /**
+     * find the owner of a re-shared file/folder
+     *
+     * @param array $share
+     * @return array
+     */
+    private function findOwner($share) {
+        $currentShare = $share;
+        while(!is_null($currentShare['parent'])) {
+            if (isset($this->shareCache[$currentShare['parent']])) {
+                $currentShare = $this->shareCache[$currentShare['parent']];
+            } else {
+                $currentShare = $this->getShare((int)$currentShare['parent']);
+                $this->shareCache[$currentShare['id']] = $currentShare;
+            }
+        }
+
+        return $currentShare['uid_owner'];
+    }
+
+    /**
+     * Get $n re-shares from the database
+     *
+     * @param int $n The max number of shares to fetch
+     * @return \Doctrine\DBAL\Driver\Statement
+     */
+    private function getReShares() {
+        $query = $this->connection->getQueryBuilder();
+        $query->select(['id', 'parent', 'uid_owner', 'share_type'])
+            ->from($this->table)
+            ->where($query->expr()->in(
+                'share_type',
+                $query->createNamedParameter(
+                    [
+                        \OCP\Share::SHARE_TYPE_USER,
+                        \OCP\Share::SHARE_TYPE_GROUP,
+                        \OCP\Share::SHARE_TYPE_LINK,
+                        \OCP\Share::SHARE_TYPE_REMOTE,
+                    ],
+                    Connection::PARAM_INT_ARRAY
+                )
+            ))
+            ->andWhere($query->expr()->in(
+                'item_type',
+                $query->createNamedParameter(
+                    ['file', 'folder'],
+                    Connection::PARAM_STR_ARRAY
+                )
+            ))
+            ->andWhere($query->expr()->isNotNull('parent'))
+            ->orderBy('id', 'asc');
+        return $query->execute();
+
+
+        $shares = $result->fetchAll();
+        $result->closeCursor();
+
+        $ordered = [];
+        foreach ($shares as $share) {
+            $ordered[(int)$share['id']] = $share;
+        }
+
+        return $ordered;
+    }
+
+    /**
+     * Get $n re-shares from the database
+     *
+     * @param int $n The max number of shares to fetch
+     * @return array
+     */
+    private function getMissingInitiator($n = 1000) {
+        $query = $this->connection->getQueryBuilder();
+        $query->select(['id', 'uid_owner', 'share_type'])
+            ->from($this->table)
+            ->where($query->expr()->in(
+                'share_type',
+                $query->createNamedParameter(
+                    [
+                        \OCP\Share::SHARE_TYPE_USER,
+                        \OCP\Share::SHARE_TYPE_GROUP,
+                        \OCP\Share::SHARE_TYPE_LINK,
+                        \OCP\Share::SHARE_TYPE_REMOTE,
+                    ],
+                    Connection::PARAM_INT_ARRAY
+                )
+            ))
+            ->andWhere($query->expr()->in(
+                'item_type',
+                $query->createNamedParameter(
+                    ['file', 'folder'],
+                    Connection::PARAM_STR_ARRAY
+                )
+            ))
+            ->andWhere($query->expr()->isNull('uid_initiator'))
+            ->orderBy('id', 'asc')
+            ->setMaxResults($n);
+        $result = $query->execute();
+        $shares = $result->fetchAll();
+        $result->closeCursor();
+
+        $ordered = [];
+        foreach ($shares as $share) {
+            $ordered[(int)$share['id']] = $share;
+        }
+
+        return $ordered;
+    }
+
+    /**
+     * get a specific share
+     *
+     * @param int $id
+     * @return array
+     */
+    private function getShare($id) {
+        $query = $this->connection->getQueryBuilder();
+        $query->select(['id', 'parent', 'uid_owner'])
+            ->from($this->table)
+            ->where($query->expr()->eq('id', $query->createNamedParameter($id)));
+        $result = $query->execute();
+        $share = $result->fetchAll();
+        $result->closeCursor();
+
+        return $share[0];
+    }
+
+    /**
+     * update database with the new owners
+     *
+     * @param array $owners
+     * @throws \Exception
+     */
+    private function updateOwners($owners) {
+
+        $this->connection->beginTransaction();
+
+        try {
+
+            foreach ($owners as $id => $owner) {
+                $query = $this->connection->getQueryBuilder();
+                $query->update($this->table)
+                    ->set('uid_owner', $query->createNamedParameter($owner['owner']))
+                    ->set('uid_initiator', $query->createNamedParameter($owner['initiator']));
+
+
+                if ((int)$owner['type'] !== \OCP\Share::SHARE_TYPE_LINK) {
+                    $query->set('parent', $query->createNamedParameter(null));
+                }
+
+                $query->where($query->expr()->eq('id', $query->createNamedParameter($id)));
+
+                $query->execute();
+            }
+
+            $this->connection->commit();
+
+        } catch (\Exception $e) {
+            $this->connection->rollBack();
+            throw $e;
+        }
+
+    }
 
 }

apps/files_sharing/lib/ExpireSharesJob.php

Indentation +38 added lines, -38 removed lines

@@ -29,49 +29,49 @@
  */
 class ExpireSharesJob extends TimedJob {
 
-	/**
-	 * sets the correct interval for this timed job
-	 */
-	public function __construct() {
-		// Run once a day
-		$this->setInterval(24 * 60 * 60);
-	}
+    /**
+     * sets the correct interval for this timed job
+     */
+    public function __construct() {
+        // Run once a day
+        $this->setInterval(24 * 60 * 60);
+    }
 
-	/**
-	 * Makes the background job do its work
-	 *
-	 * @param array $argument unused argument
-	 */
-	public function run($argument) {
-		$connection = \OC::$server->getDatabaseConnection();
-		$logger = \OC::$server->getLogger();
+    /**
+     * Makes the background job do its work
+     *
+     * @param array $argument unused argument
+     */
+    public function run($argument) {
+        $connection = \OC::$server->getDatabaseConnection();
+        $logger = \OC::$server->getLogger();
 
-		//Current time
-		$now = new \DateTime();
-		$now = $now->format('Y-m-d H:i:s');
+        //Current time
+        $now = new \DateTime();
+        $now = $now->format('Y-m-d H:i:s');
 
-		/*
+        /*
 		 * Expire file link shares only (for now)
 		 */
-		$qb = $connection->getQueryBuilder();
-		$qb->select('id', 'file_source', 'uid_owner', 'item_type')
-			->from('share')
-			->where(
-				$qb->expr()->andX(
-					$qb->expr()->eq('share_type', $qb->expr()->literal(\OCP\Share::SHARE_TYPE_LINK)),
-					$qb->expr()->lte('expiration', $qb->expr()->literal($now)),
-					$qb->expr()->orX(
-						$qb->expr()->eq('item_type', $qb->expr()->literal('file')),
-						$qb->expr()->eq('item_type', $qb->expr()->literal('folder'))
-					)
-				)
-			);
+        $qb = $connection->getQueryBuilder();
+        $qb->select('id', 'file_source', 'uid_owner', 'item_type')
+            ->from('share')
+            ->where(
+                $qb->expr()->andX(
+                    $qb->expr()->eq('share_type', $qb->expr()->literal(\OCP\Share::SHARE_TYPE_LINK)),
+                    $qb->expr()->lte('expiration', $qb->expr()->literal($now)),
+                    $qb->expr()->orX(
+                        $qb->expr()->eq('item_type', $qb->expr()->literal('file')),
+                        $qb->expr()->eq('item_type', $qb->expr()->literal('folder'))
+                    )
+                )
+            );
 
-		$shares = $qb->execute();
-		while($share = $shares->fetch()) {
-			\OCP\Share::unshare($share['item_type'], $share['file_source'], \OCP\Share::SHARE_TYPE_LINK, null, $share['uid_owner']);
-		}
-		$shares->closeCursor();
-	}
+        $shares = $qb->execute();
+        while($share = $shares->fetch()) {
+            \OCP\Share::unshare($share['item_type'], $share['file_source'], \OCP\Share::SHARE_TYPE_LINK, null, $share['uid_owner']);
+        }
+        $shares->closeCursor();
+    }
 
 }

apps/files_sharing/lib/Controller/ExternalSharesController.php

Indentation +100 added lines, -100 removed lines

@@ -39,112 +39,112 @@
  */
 class ExternalSharesController extends Controller {
 
-	/** @var \OCA\Files_Sharing\External\Manager */
-	private $externalManager;
-	/** @var IClientService */
-	private $clientService;
+    /** @var \OCA\Files_Sharing\External\Manager */
+    private $externalManager;
+    /** @var IClientService */
+    private $clientService;
 
-	/**
-	 * @param string $appName
-	 * @param IRequest $request
-	 * @param \OCA\Files_Sharing\External\Manager $externalManager
-	 * @param IClientService $clientService
-	 */
-	public function __construct($appName,
-								IRequest $request,
-								\OCA\Files_Sharing\External\Manager $externalManager,
-								IClientService $clientService) {
-		parent::__construct($appName, $request);
-		$this->externalManager = $externalManager;
-		$this->clientService = $clientService;
-	}
+    /**
+     * @param string $appName
+     * @param IRequest $request
+     * @param \OCA\Files_Sharing\External\Manager $externalManager
+     * @param IClientService $clientService
+     */
+    public function __construct($appName,
+                                IRequest $request,
+                                \OCA\Files_Sharing\External\Manager $externalManager,
+                                IClientService $clientService) {
+        parent::__construct($appName, $request);
+        $this->externalManager = $externalManager;
+        $this->clientService = $clientService;
+    }
 
-	/**
-	 * @NoAdminRequired
-	 * @NoOutgoingFederatedSharingRequired
-	 *
-	 * @return JSONResponse
-	 */
-	public function index() {
-		return new JSONResponse($this->externalManager->getOpenShares());
-	}
+    /**
+     * @NoAdminRequired
+     * @NoOutgoingFederatedSharingRequired
+     *
+     * @return JSONResponse
+     */
+    public function index() {
+        return new JSONResponse($this->externalManager->getOpenShares());
+    }
 
-	/**
-	 * @NoAdminRequired
-	 * @NoOutgoingFederatedSharingRequired
-	 *
-	 * @param int $id
-	 * @return JSONResponse
-	 */
-	public function create($id) {
-		$this->externalManager->acceptShare($id);
-		return new JSONResponse();
-	}
+    /**
+     * @NoAdminRequired
+     * @NoOutgoingFederatedSharingRequired
+     *
+     * @param int $id
+     * @return JSONResponse
+     */
+    public function create($id) {
+        $this->externalManager->acceptShare($id);
+        return new JSONResponse();
+    }
 
-	/**
-	 * @NoAdminRequired
-	 * @NoOutgoingFederatedSharingRequired
-	 *
-	 * @param integer $id
-	 * @return JSONResponse
-	 */
-	public function destroy($id) {
-		$this->externalManager->declineShare($id);
-		return new JSONResponse();
-	}
+    /**
+     * @NoAdminRequired
+     * @NoOutgoingFederatedSharingRequired
+     *
+     * @param integer $id
+     * @return JSONResponse
+     */
+    public function destroy($id) {
+        $this->externalManager->declineShare($id);
+        return new JSONResponse();
+    }
 
-	/**
-	 * Test whether the specified remote is accessible
-	 *
-	 * @param string $remote
-	 * @param bool $checkVersion
-	 * @return bool
-	 */
-	protected function testUrl($remote, $checkVersion = false) {
-		try {
-			$client = $this->clientService->newClient();
-			$response = json_decode($client->get(
-				$remote,
-				[
-					'timeout' => 3,
-					'connect_timeout' => 3,
-				]
-			)->getBody());
+    /**
+     * Test whether the specified remote is accessible
+     *
+     * @param string $remote
+     * @param bool $checkVersion
+     * @return bool
+     */
+    protected function testUrl($remote, $checkVersion = false) {
+        try {
+            $client = $this->clientService->newClient();
+            $response = json_decode($client->get(
+                $remote,
+                [
+                    'timeout' => 3,
+                    'connect_timeout' => 3,
+                ]
+            )->getBody());
 
-			if ($checkVersion) {
-				return !empty($response->version) && version_compare($response->version, '7.0.0', '>=');
-			} else {
-				return is_object($response);
-			}
-		} catch (\Exception $e) {
-			return false;
-		}
-	}
+            if ($checkVersion) {
+                return !empty($response->version) && version_compare($response->version, '7.0.0', '>=');
+            } else {
+                return is_object($response);
+            }
+        } catch (\Exception $e) {
+            return false;
+        }
+    }
 
-	/**
-	 * @PublicPage
-	 * @NoOutgoingFederatedSharingRequired
-	 * @NoIncomingFederatedSharingRequired
-	 *
-	 * @param string $remote
-	 * @return DataResponse
-	 */
-	public function testRemote($remote) {
-		if (
-			$this->testUrl('https://' . $remote . '/ocs-provider/') ||
-			$this->testUrl('https://' . $remote . '/ocs-provider/index.php') ||
-			$this->testUrl('https://' . $remote . '/status.php', true)
-		) {
-			return new DataResponse('https');
-		} elseif (
-			$this->testUrl('http://' . $remote . '/ocs-provider/') ||
-			$this->testUrl('http://' . $remote . '/ocs-provider/index.php') ||
-			$this->testUrl('http://' . $remote . '/status.php', true)
-		) {
-			return new DataResponse('http');
-		} else {
-			return new DataResponse(false);
-		}
-	}
+    /**
+     * @PublicPage
+     * @NoOutgoingFederatedSharingRequired
+     * @NoIncomingFederatedSharingRequired
+     *
+     * @param string $remote
+     * @return DataResponse
+     */
+    public function testRemote($remote) {
+        if (
+            $this->testUrl('https://' . $remote . '/ocs-provider/') ||
+            $this->testUrl('https://' . $remote . '/ocs-provider/index.php') ||
+            $this->testUrl('https://' . $remote . '/status.php', true)
+        ) {
+            return new DataResponse('https');
+        } elseif (
+            $this->testUrl('http://' . $remote . '/ocs-provider/') ||
+            $this->testUrl('http://' . $remote . '/ocs-provider/index.php') ||
+            $this->testUrl('http://' . $remote . '/status.php', true)
+        ) {
+            return new DataResponse('http');
+        } else {
+            return new DataResponse(false);
+        }
+    }
 
 }

apps/files_sharing/lib/Controller/PublicPreviewController.php

Indentation +54 added lines, -54 removed lines

@@ -36,67 +36,67 @@
 
 class PublicPreviewController extends Controller {
 
-	/** @var ShareManager */
-	private $shareManager;
+    /** @var ShareManager */
+    private $shareManager;
 
-	/** @var IPreview */
-	private $previewManager;
+    /** @var IPreview */
+    private $previewManager;
 
-	public function __construct($appName,
-								IRequest $request,
-								ShareManager $shareManger,
-								IPreview $previewManager) {
-		parent::__construct($appName, $request);
+    public function __construct($appName,
+                                IRequest $request,
+                                ShareManager $shareManger,
+                                IPreview $previewManager) {
+        parent::__construct($appName, $request);
 
-		$this->shareManager = $shareManger;
-		$this->previewManager = $previewManager;
-	}
+        $this->shareManager = $shareManger;
+        $this->previewManager = $previewManager;
+    }
 
-	/**
-	 * @PublicPage
-	 * @NoCSRFRequired
-	 *
-	 * @param string $file
-	 * @param int $x
-	 * @param int $y
-	 * @param string $t
-	 * @param bool $a
-	 * @return DataResponse|FileDisplayResponse
-	 */
-	public function getPreview(
-		$file = '',
-		$x = 32,
-		$y = 32,
-		$t = '',
-		$a = false
-	) {
+    /**
+     * @PublicPage
+     * @NoCSRFRequired
+     *
+     * @param string $file
+     * @param int $x
+     * @param int $y
+     * @param string $t
+     * @param bool $a
+     * @return DataResponse|FileDisplayResponse
+     */
+    public function getPreview(
+        $file = '',
+        $x = 32,
+        $y = 32,
+        $t = '',
+        $a = false
+    ) {
 
-		if ($t === '' || $x === 0 || $y === 0) {
-			return new DataResponse([], Http::STATUS_BAD_REQUEST);
-		}
+        if ($t === '' || $x === 0 || $y === 0) {
+            return new DataResponse([], Http::STATUS_BAD_REQUEST);
+        }
 
-		try {
-			$share = $this->shareManager->getShareByToken($t);
-		} catch (ShareNotFound $e) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		}
+        try {
+            $share = $this->shareManager->getShareByToken($t);
+        } catch (ShareNotFound $e) {
+            return new DataResponse([], Http::STATUS_NOT_FOUND);
+        }
 
-		if (($share->getPermissions() & Constants::PERMISSION_READ) === 0) {
-			return new DataResponse([], Http::STATUS_FORBIDDEN);
-		}
+        if (($share->getPermissions() & Constants::PERMISSION_READ) === 0) {
+            return new DataResponse([], Http::STATUS_FORBIDDEN);
+        }
 
-		try {
-			$node = $share->getNode();
-			if ($node instanceof Folder) {
-				$file = $node->get($file);
-			} else {
-				$file = $node;
-			}
+        try {
+            $node = $share->getNode();
+            if ($node instanceof Folder) {
+                $file = $node->get($file);
+            } else {
+                $file = $node;
+            }
 
-			$f = $this->previewManager->getPreview($file, $x, $y, !$a);
-			return new FileDisplayResponse($f, Http::STATUS_OK, ['Content-Type' => $f->getMimeType()]);
-		} catch (NotFoundException $e) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		}
-	}
+            $f = $this->previewManager->getPreview($file, $x, $y, !$a);
+            return new FileDisplayResponse($f, Http::STATUS_OK, ['Content-Type' => $f->getMimeType()]);
+        } catch (NotFoundException $e) {
+            return new DataResponse([], Http::STATUS_NOT_FOUND);
+        }
+    }
 }