nextcloud / server

lib/private/legacy/files.php

Doc Comments +1 added lines, -1 removed lines

@@ -334,7 +334,7 @@
 	 *
 	 * @param int $size file size in bytes
 	 * @param array $files override '.htaccess' and '.user.ini' locations
-	 * @return bool false on failure, size on success
+	 * @return integer false on failure, size on success
 	 */
 	public static function setUploadLimit($size, $files = []) {
 		//don't allow user to break his config

lib/private/Settings/Manager.php

Doc Comments +13 added lines, -2 removed lines

@@ -129,7 +129,7 @@ 
 	/**
 	 * returns the registerd classes in the given table
 	 *
-	 * @param $table
+	 * @param string $table
 	 * @return string[]
 	 */
 	private function getClasses($table) {
@@ -225,6 +225,11 @@ 
 		);
 	}
 
+	/**
+	 * @param string $table
+	 * @param string $idCol
+	 * @param string $id
+	 */
 	private function update($table, $idCol, $id, $values) {
 		$query = $this->dbc->getQueryBuilder();
 		$query->update($table);
@@ -275,7 +280,7 @@ 
 	/**
 	 * deletes an settings or admin entry from the given table
 	 *
-	 * @param $table
+	 * @param string $table
 	 * @param $className
 	 */
 	private function remove($table, $className) {
@@ -358,6 +363,9 @@ 
 		return $sections;
 	}
 
+	/**
+	 * @param string $section
+	 */
 	private function getBuiltInAdminSettings($section) {
 		$forms = [];
 		try {
@@ -397,6 +405,9 @@ 
 		return $forms;
 	}
 
+	/**
+	 * @param string $section
+	 */
 	private function getAdminSettingsFromDB($section, &$settings) {
 		$query = $this->dbc->getQueryBuilder();
 		$query->select(['class', 'priority'])

settings/Controller/CertificateController.php

Doc Comments +2 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
 	 *
 	 * @NoAdminRequired
 	 * @NoSubadminRequired
-	 * @return array
+	 * @return DataResponse
 	 */
 	public function addPersonalRootCertificate() {
 		return $this->addCertificate($this->userCertificateManager);
@@ -160,7 +160,7 @@ 
 	/**
 	 * Add a new personal root certificate to the system's trust store
 	 *
-	 * @return array
+	 * @return DataResponse
 	 */
 	public function addSystemRootCertificate() {
 		return $this->addCertificate($this->systemCertificateManager);

apps/files_sharing/lib/sharedstorage.php

Unused Use Statements -1 removed lines

@@ -36,7 +36,6 @@
 use OCA\Files_Sharing\ISharedStorage;
 use OCP\Constants;
 use OCP\Files\Cache\ICacheEntry;
-use OCP\Files\Storage\IStorage;
 use OCP\Lock\ILockingProvider;
 
 /**

lib/private/Cache/File.php

Doc Comments +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
 	 * @param string $key
 	 * @param mixed $value
 	 * @param int $ttl
-	 * @return bool|mixed
+	 * @return boolean
 	 * @throws \OC\ForbiddenException
 	 */
 	public function set($key, $value, $ttl = 0) {

apps/files_sharing/lib/Controller/ShareesAPIController.php

Doc Comments +1 added lines, -1 removed lines

@@ -335,7 +335,7 @@
 	 * split user and remote from federated cloud id
 	 *
 	 * @param string $address federated share address
-	 * @return array [user, remoteURL]
+	 * @return string[] [user, remoteURL]
 	 * @throws \Exception
 	 */
 	public function splitUserRemote($address) {

core/Controller/LostController.php

Doc Comments +1 added lines, -1 removed lines

@@ -132,7 +132,7 @@
 	}
 
 	/**
-	 * @param $message
+	 * @param string $message
 	 * @param array $additional
 	 * @return array
 	 */

apps/user_ldap/lib/Access.php

Doc Comments +8 added lines, -6 removed lines

@@ -361,7 +361,7 @@ 
 
 	/**
 	 * returns the internal ownCloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @return string|false with with the name to use in ownCloud
 	 */
@@ -378,7 +378,7 @@ 
 
 	/**
 	 * returns an internal ownCloud name for the given LDAP DN, false on DN outside of search DN
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
 	 * @return string|false with with the name to use in ownCloud
@@ -638,7 +638,7 @@ 
 	 * the login filter.
 	 *
 	 * @param string $loginName
-	 * @param array $attributes optional, list of attributes to read
+	 * @param string[] $attributes optional, list of attributes to read
 	 * @return array
 	 */
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -711,7 +711,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return array
@@ -759,7 +759,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return false|int
@@ -809,6 +809,7 @@ 
 	 * retrieved. Results will according to the order in the array.
 	 * @param int $limit optional, maximum results to be counted
 	 * @param int $offset optional, a starting point
+	 * @param string $filter
 	 * @return array|false array with the search result as first value and pagedSearchOK as
 	 * second | false if not successful
 	 */
@@ -1063,7 +1064,7 @@ 
 
 	/**
 	 * @param string $name
-	 * @return bool|mixed|string
+	 * @return string
 	 */
 	public function sanitizeUsername($name) {
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1087,6 +1088,7 @@ 
 	* escapes (user provided) parts for LDAP filter
 	* @param string $input, the provided value
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
+	* @param string $input
 	* @return string the escaped string
 	*/
 	public function escapeFilterPart($input, $allowAsterisk = false) {

core/Application.php

Unused Use Statements -1 removed lines

@@ -35,7 +35,6 @@
 use OC\Core\Controller\LostController;
 use OC\Core\Controller\TokenController;
 use OC\Core\Controller\TwoFactorChallengeController;
-use OC\Core\Controller\UserController;
 use OCP\AppFramework\App;
 use OCP\Util;