Completed
Pull Request — master (#854)
by Olivier
09:36
created
lib/public/Files/StorageAuthException.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 	 * StorageTimeoutException constructor.
31 31
 	 *
32 32
 	 * @param string $message
33
-	 * @param int $code
34 33
 	 * @param \Exception $previous
35 34
 	 * @since 9.0.0
36 35
 	 */
Please login to merge, or discard this patch.
lib/public/Files/StorageBadConfigException.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 	 * StorageTimeoutException constructor.
31 31
 	 *
32 32
 	 * @param string $message
33
-	 * @param int $code
34 33
 	 * @param \Exception $previous
35 34
 	 * @since 9.0.0
36 35
 	 */
Please login to merge, or discard this patch.
lib/public/Files/StorageConnectionException.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 	 * StorageTimeoutException constructor.
31 31
 	 *
32 32
 	 * @param string $message
33
-	 * @param int $code
34 33
 	 * @param \Exception $previous
35 34
 	 * @since 9.0.0
36 35
 	 */
Please login to merge, or discard this patch.
lib/private/Repair/RemoveOldShares.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,6 @@
 block discarded – undo
37 37
 	/**
38 38
 	 * RemoveOldCalendarShares constructor.
39 39
 	 *
40
-	 * @param IDBConnection $db
41 40
 	 */
42 41
 	public function __construct(IDBConnection $connection) {
43 42
 		$this->connection = $connection;
Please login to merge, or discard this patch.
apps/dav/lib/AppInfo/Application.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -26,7 +26,6 @@  discard block
 block discarded – undo
26 26
 use OCA\DAV\CalDAV\CalDavBackend;
27 27
 use OCA\DAV\CardDAV\CardDavBackend;
28 28
 use OCA\DAV\CardDAV\ContactsManager;
29
-use OCA\DAV\CardDAV\SyncJob;
30 29
 use OCA\DAV\CardDAV\SyncService;
31 30
 use OCA\DAV\Connector\Sabre\Principal;
32 31
 use OCA\DAV\DAV\GroupPrincipalBackend;
@@ -36,8 +35,6 @@  discard block
 block discarded – undo
36 35
 use \OCP\AppFramework\App;
37 36
 use OCP\AppFramework\IAppContainer;
38 37
 use OCP\Contacts\IManager;
39
-use OCP\IUser;
40
-use Sabre\VObject\Reader;
41 38
 use Symfony\Component\EventDispatcher\GenericEvent;
42 39
 
43 40
 class Application extends App {
Please login to merge, or discard this patch.
apps/files_sharing/lib/Helper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -303,6 +303,7 @@
 block discarded – undo
303 303
 	 * get default share folder
304 304
 	 *
305 305
 	 * @param \OC\Files\View
306
+	 * @param View $view
306 307
 	 * @return string
307 308
 	 */
308 309
 	public static function getShareFolder($view = null) {
Please login to merge, or discard this patch.
lib/private/DB/Migrator.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -273,6 +273,10 @@  discard block
 block discarded – undo
273 273
 		return '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
274 274
 	}
275 275
 
276
+	/**
277
+	 * @param integer $step
278
+	 * @param integer $max
279
+	 */
276 280
 	protected function emit($sql, $step, $max) {
277 281
 		if ($this->noEmit) {
278 282
 			return;
@@ -283,6 +287,10 @@  discard block
 block discarded – undo
283 287
 		$this->dispatcher->dispatch('\OC\DB\Migrator::executeSql', new GenericEvent($sql, [$step+1, $max]));
284 288
 	}
285 289
 
290
+	/**
291
+	 * @param integer $step
292
+	 * @param integer $max
293
+	 */
286 294
 	private function emitCheckStep($tableName, $step, $max) {
287 295
 		if(is_null($this->dispatcher)) {
288 296
 			return;
Please login to merge, or discard this patch.
lib/private/User/Session.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 	 * @param IRequest $request
301 301
 	 * @throws LoginException
302 302
 	 * @throws PasswordLoginForbiddenException
303
-	 * @return boolean
303
+	 * @return boolean|null
304 304
 	 */
305 305
 	public function logClientIn($user, $password, IRequest $request) {
306 306
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -340,6 +340,9 @@  discard block
 block discarded – undo
340 340
 		return $this->config->getSystemValue('token_auth_enforced', false);
341 341
 	}
342 342
 
343
+	/**
344
+	 * @param string $username
345
+	 */
343 346
 	protected function isTwoFactorEnforced($username) {
344 347
 		Util::emitHook(
345 348
 			'\OCA\Files_Sharing\API\Server2Server',
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Backends.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -27,13 +27,8 @@
 block discarded – undo
27 27
 use OCA\Files_External\Lib\DefinitionParameter;
28 28
 use OCA\Files_External\Service\BackendService;
29 29
 use Symfony\Component\Console\Command\Command;
30
-use Symfony\Component\Console\Helper\Table;
31
-use Symfony\Component\Console\Helper\TableHelper;
32
-use Symfony\Component\Console\Input\ArrayInput;
33 30
 use Symfony\Component\Console\Input\InputArgument;
34 31
 use Symfony\Component\Console\Input\InputInterface;
35
-use Symfony\Component\Console\Input\InputOption;
36
-use Symfony\Component\Console\Input\Input;
37 32
 use Symfony\Component\Console\Output\OutputInterface;
38 33
 
39 34
 class Backends extends Base {
Please login to merge, or discard this patch.