Inspection of "Merge pull request #20587 from nextcloud/enh/allow..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 768b01...652639 )

by Roeland

created 2020-04-24 15:08 UTC

Status

Switch Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -62,18 +62,18 @@
 block discarded – undo
 				$placeholder = substr($placeholder, 1);
 			}
 			switch ($placeholder[0]) {
-			case '!':
-				$type = DefinitionParameter::VALUE_BOOLEAN;
-				$placeholder = substr($placeholder, 1);
-				break;
-			case '*':
-				$type = DefinitionParameter::VALUE_PASSWORD;
-				$placeholder = substr($placeholder, 1);
-				break;
-			case '#':
-				$type = DefinitionParameter::VALUE_HIDDEN;
-				$placeholder = substr($placeholder, 1);
-				break;
+			    case '!':
+				    $type = DefinitionParameter::VALUE_BOOLEAN;
+				    $placeholder = substr($placeholder, 1);
+				    break;
+			    case '*':
+				    $type = DefinitionParameter::VALUE_PASSWORD;
+				    $placeholder = substr($placeholder, 1);
+				    break;
+			    case '#':
+				    $type = DefinitionParameter::VALUE_HIDDEN;
+				    $placeholder = substr($placeholder, 1);
+				    break;
 			}
 			$this->addParameter((new DefinitionParameter($name, $placeholder))
 				->setType($type)

Please login to merge, or discard this patch.

apps/files_external/templates/settings.php 1 patch

Switch Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -41,48 +41,48 @@
 block discarded – undo
 		$is_optional = $parameter->isFlagSet(DefinitionParameter::FLAG_OPTIONAL);
 
 		switch ($parameter->getType()) {
-		case DefinitionParameter::VALUE_PASSWORD: ?>
-			<?php if ($is_optional) {
-			$classes[] = 'optional';
-		} ?>
-			<input type="password"
+		    case DefinitionParameter::VALUE_PASSWORD: ?>
+    			<?php if ($is_optional) {
+			    $classes[] = 'optional';
+		    } ?>
+    			<input type="password"
 				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
-				data-parameter="<?php p($parameter->getName()); ?>"
+    				data-parameter="<?php p($parameter->getName()); ?>"
 				value="<?php p($value); ?>"
 				placeholder="<?php p($placeholder); ?>"
 			/>
 			<?php
-			break;
-		case DefinitionParameter::VALUE_BOOLEAN: ?>
-			<?php $checkboxId = uniqid("checkbox_"); ?>
+			    break;
+		    case DefinitionParameter::VALUE_BOOLEAN: ?>
+    			<?php $checkboxId = uniqid("checkbox_"); ?>
 			<div>
 			<label>
 			<input type="checkbox"
 				id="<?php p($checkboxId); ?>"
 				<?php if (!empty($classes)): ?> class="checkbox <?php p(implode(' ', $classes)); ?>"<?php endif; ?>
-				data-parameter="<?php p($parameter->getName()); ?>"
+    				data-parameter="<?php p($parameter->getName()); ?>"
 				<?php if ($value === true): ?> checked="checked"<?php endif; ?>
-			/>
+    			/>
 			<?php p($placeholder); ?>
 			</label>
 			</div>
 			<?php
-			break;
-		case DefinitionParameter::VALUE_HIDDEN: ?>
-			<input type="hidden"
+			    break;
+		    case DefinitionParameter::VALUE_HIDDEN: ?>
+    			<input type="hidden"
 				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
-				data-parameter="<?php p($parameter->getName()); ?>"
+    				data-parameter="<?php p($parameter->getName()); ?>"
 				value="<?php p($value); ?>"
 			/>
 			<?php
-			break;
-		default: ?>
-			<?php if ($is_optional) {
-			$classes[] = 'optional';
-		} ?>
-			<input type="text"
+			    break;
+		    default: ?>
+    			<?php if ($is_optional) {
+			    $classes[] = 'optional';
+		    } ?>
+    			<input type="text"
 				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
-				data-parameter="<?php p($parameter->getName()); ?>"
+    				data-parameter="<?php p($parameter->getName()); ?>"
 				value="<?php p($value); ?>"
 				placeholder="<?php p($placeholder); ?>"
 			/>

Please login to merge, or discard this patch.

core/Command/Log/Manage.php 1 patch

Switch Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -142,18 +142,18 @@  discard block
 block discarded – undo
 	protected function convertLevelString($level) {
 		$level = strtolower($level);
 		switch ($level) {
-		case 'debug':
-			return 0;
-		case 'info':
-			return 1;
-		case 'warning':
-		case 'warn':
-			return 2;
-		case 'error':
-		case 'err':
-			return 3;
-		case 'fatal':
-			return 4;
+		    case 'debug':
+			    return 0;
+		    case 'info':
+			    return 1;
+		    case 'warning':
+		    case 'warn':
+			    return 2;
+		    case 'error':
+		    case 'err':
+			    return 3;
+		    case 'fatal':
+			    return 4;
 		}
 		throw new \InvalidArgumentException('Invalid log level string');
 	}
@@ -165,16 +165,16 @@  discard block
 block discarded – undo
 	 */
 	protected function convertLevelNumber($levelNum) {
 		switch ($levelNum) {
-		case 0:
-			return 'Debug';
-		case 1:
-			return 'Info';
-		case 2:
-			return 'Warning';
-		case 3:
-			return 'Error';
-		case 4:
-			return 'Fatal';
+		    case 0:
+			    return 'Debug';
+		    case 1:
+			    return 'Info';
+		    case 2:
+			    return 'Warning';
+		    case 3:
+			    return 'Error';
+		    case 4:
+			    return 'Fatal';
 		}
 		throw new \InvalidArgumentException('Invalid log level number');
 	}

Please login to merge, or discard this patch.

		@@ -142,18 +142,18 @@ discard block
		block discarded – undo
142	142	protected function convertLevelString($level) {
143	143	$level = strtolower($level);
144	144	switch ($level) {
145		- case 'debug':
146		- return 0;
147		- case 'info':
148		- return 1;
149		- case 'warning':
150		- case 'warn':
151		- return 2;
152		- case 'error':
153		- case 'err':
154		- return 3;
155		- case 'fatal':
156		- return 4;
	145	+ case 'debug':
	146	+ return 0;
	147	+ case 'info':
	148	+ return 1;
	149	+ case 'warning':
	150	+ case 'warn':
	151	+ return 2;
	152	+ case 'error':
	153	+ case 'err':
	154	+ return 3;
	155	+ case 'fatal':
	156	+ return 4;
157	157	}
158	158	throw new \InvalidArgumentException('Invalid log level string');
159	159	}
		@@ -165,16 +165,16 @@ discard block
		block discarded – undo
165	165	*/
166	166	protected function convertLevelNumber($levelNum) {
167	167	switch ($levelNum) {
168		- case 0:
169		- return 'Debug';
170		- case 1:
171		- return 'Info';
172		- case 2:
173		- return 'Warning';
174		- case 3:
175		- return 'Error';
176		- case 4:
177		- return 'Fatal';
	168	+ case 0:
	169	+ return 'Debug';
	170	+ case 1:
	171	+ return 'Info';
	172	+ case 2:
	173	+ return 'Warning';
	174	+ case 3:
	175	+ return 'Error';
	176	+ case 4:
	177	+ return 'Fatal';
178	178	}
179	179	throw new \InvalidArgumentException('Invalid log level number');
180	180	}

		@@ -62,18 +62,18 @@
		block discarded – undo
62	62	$placeholder = substr($placeholder, 1);
63	63	}
64	64	switch ($placeholder[0]) {
65		- case '!':
66		- $type = DefinitionParameter::VALUE_BOOLEAN;
67		- $placeholder = substr($placeholder, 1);
68		- break;
69		- case '*':
70		- $type = DefinitionParameter::VALUE_PASSWORD;
71		- $placeholder = substr($placeholder, 1);
72		- break;
73		- case '#':
74		- $type = DefinitionParameter::VALUE_HIDDEN;
75		- $placeholder = substr($placeholder, 1);
76		- break;
	65	+ case '!':
	66	+ $type = DefinitionParameter::VALUE_BOOLEAN;
	67	+ $placeholder = substr($placeholder, 1);
	68	+ break;
	69	+ case '*':
	70	+ $type = DefinitionParameter::VALUE_PASSWORD;
	71	+ $placeholder = substr($placeholder, 1);
	72	+ break;
	73	+ case '#':
	74	+ $type = DefinitionParameter::VALUE_HIDDEN;
	75	+ $placeholder = substr($placeholder, 1);
	76	+ break;
77	77	}
78	78	$this->addParameter((new DefinitionParameter($name, $placeholder))
79	79	->setType($type)

		@@ -41,48 +41,48 @@
		block discarded – undo
41	41	$is_optional = $parameter->isFlagSet(DefinitionParameter::FLAG_OPTIONAL);
42	42
43	43	switch ($parameter->getType()) {
44		- case DefinitionParameter::VALUE_PASSWORD: ?>
45		- <?php if ($is_optional) {
46		- $classes[] = 'optional';
47		- } ?>
48		- <input type="password"
	44	+ case DefinitionParameter::VALUE_PASSWORD: ?>
	45	+ <?php if ($is_optional) {
	46	+ $classes[] = 'optional';
	47	+ } ?>
	48	+ <input type="password"
49	49	<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
50		- data-parameter="<?php p($parameter->getName()); ?>"
	50	+ data-parameter="<?php p($parameter->getName()); ?>"
51	51	value="<?php p($value); ?>"
52	52	placeholder="<?php p($placeholder); ?>"
53	53	/>
54	54	<?php
55		- break;
56		- case DefinitionParameter::VALUE_BOOLEAN: ?>
57		- <?php $checkboxId = uniqid("checkbox_"); ?>
	55	+ break;
	56	+ case DefinitionParameter::VALUE_BOOLEAN: ?>
	57	+ <?php $checkboxId = uniqid("checkbox_"); ?>
58	58	<div>
59	59	<label>
60	60	<input type="checkbox"
61	61	id="<?php p($checkboxId); ?>"
62	62	<?php if (!empty($classes)): ?> class="checkbox <?php p(implode(' ', $classes)); ?>"<?php endif; ?>
63		- data-parameter="<?php p($parameter->getName()); ?>"
	63	+ data-parameter="<?php p($parameter->getName()); ?>"
64	64	<?php if ($value === true): ?> checked="checked"<?php endif; ?>
65		- />
	65	+ />
66	66	<?php p($placeholder); ?>
67	67	</label>
68	68	</div>
69	69	<?php
70		- break;
71		- case DefinitionParameter::VALUE_HIDDEN: ?>
72		- <input type="hidden"
	70	+ break;
	71	+ case DefinitionParameter::VALUE_HIDDEN: ?>
	72	+ <input type="hidden"
73	73	<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
74		- data-parameter="<?php p($parameter->getName()); ?>"
	74	+ data-parameter="<?php p($parameter->getName()); ?>"
75	75	value="<?php p($value); ?>"
76	76	/>
77	77	<?php
78		- break;
79		- default: ?>
80		- <?php if ($is_optional) {
81		- $classes[] = 'optional';
82		- } ?>
83		- <input type="text"
	78	+ break;
	79	+ default: ?>
	80	+ <?php if ($is_optional) {
	81	+ $classes[] = 'optional';
	82	+ } ?>
	83	+ <input type="text"
84	84	<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
85		- data-parameter="<?php p($parameter->getName()); ?>"
	85	+ data-parameter="<?php p($parameter->getName()); ?>"
86	86	value="<?php p($value); ?>"
87	87	placeholder="<?php p($placeholder); ?>"
88	88	/>

nextcloud / server

Push — master ( 768b01...652639 )

Status

Category

Switch Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Switch Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

Switch Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch