nextcloud / server

apps/dav/lib/Connector/Sabre/TagList.php

Doc Comments +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
 	 * the next element.
 	 *
 	 * @param Reader $reader
-	 * @return mixed
+	 * @return null|TagList
 	 */
 	static function xmlDeserialize(Reader $reader) {
 		$tags = [];

lib/private/Share/MailNotifications.php

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 
 namespace OC\Share;
 
-use DateTime;
 use OCP\IL10N;
 use OCP\IURLGenerator;
 use OCP\IUser;

lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php

Doc Comments +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 	 * @param bool $isLoggedIn
 	 * @param bool $isAdminUser
 	 * @param ContentSecurityPolicyManager $contentSecurityPolicyManager
-	 * @param CSRFTokenManager $csrfTokenManager
+	 * @param CsrfTokenManager $csrfTokenManager
 	 */
 	public function __construct(IRequest $request,
 								ControllerMethodReflector $reflector,

lib/private/legacy/app.php

Doc Comments +6 added lines, -3 removed lines

@@ -1036,7 +1036,7 @@ 
 	 * @param string $app
 	 * @param \OCP\IConfig $config
 	 * @param \OCP\IL10N $l
-	 * @return bool
+	 * @return string
 	 *
 	 * @throws Exception if app is not compatible with this version of ownCloud
 	 * @throws Exception if no app-name was specified
@@ -1216,6 +1216,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $lang
+	 */
 	protected static function findBestL10NOption($options, $lang) {
 		$fallback = $similarLangFallback = $englishFallback = false;
 
@@ -1310,8 +1313,8 @@ 
 	}
 
 	/**
-	 * @param $config
-	 * @param $l
+	 * @param OCP\IConfig $config
+	 * @param OCP\IL10N $l
 	 * @param $info
 	 * @throws Exception
 	 */

Unused Use Statements -1 removed lines

@@ -51,7 +51,6 @@
 use OC\App\InfoParser;
 use OC\App\Platform;
 use OC\Installer;
-use OC\OCSClient;
 use OC\Repair;
 use OCP\App\ManagerEvent;
 

lib/private/L10N/Factory.php

Doc Comments +5 added lines

@@ -318,6 +318,11 @@
 	 */
 	// FIXME This method is only public, until OC_L10N does not need it anymore,
 	// FIXME This is also the reason, why it is not in the public interface
+
+	/**
+	 * @param string $app
+	 * @param string $lang
+	 */
 	public function getL10nFilesForApp($app, $lang) {
 		$languageFiles = [];
 

lib/private/Installer.php

Unused Use Statements -1 removed lines

@@ -45,7 +45,6 @@
 use OC\App\CodeChecker\CodeChecker;
 use OC\App\CodeChecker\EmptyCheck;
 use OC\App\CodeChecker\PrivateCheck;
-use OC\Archive\Archive;
 use OC\Archive\TAR;
 use OC_App;
 use OC_DB;

lib/private/Share20/ProviderFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -131,7 +131,7 @@
 	/**
 	 * Create the federated share provider
 	 *
-	 * @return FederatedShareProvider
+	 * @return null|ShareByMailProvider
 	 */
 	protected function getShareByMailProvider() {
 		if ($this->shareByMailProvider === null) {

apps/sharebymail/lib/ShareByMailProvider.php

Doc Comments +11 added lines, -4 removed lines

@@ -184,10 +184,10 @@ 
 	 * publish activity if a file/folder was shared by mail
 	 *
 	 * @param $subject
-	 * @param $parameters
-	 * @param $affectedUser
+	 * @param string[] $parameters
+	 * @param string $affectedUser
 	 * @param $fileId
-	 * @param $filePath
+	 * @param string $filePath
 	 */
 	protected function publishActivity($subject, $parameters, $affectedUser, $fileId, $filePath) {
 		$event = $this->activityManager->generateEvent();
@@ -239,6 +239,12 @@ 
 
 	}
 
+	/**
+	 * @param string $link
+	 * @param string $owner
+	 * @param string $initiator
+	 * @param string $shareWith
+	 */
 	protected function sendMailNotification($filename, $link, $owner, $initiator, $shareWith) {
 		if ($owner === $initiator) {
 			$subject = (string)$this->l->t('%s shared »%s« with you', array($owner, $filename));
@@ -264,6 +270,7 @@ 
 	 * @param $link
 	 * @param $owner
 	 * @param $initiator
+	 * @param string $template
 	 * @return string plain text mail
 	 * @throws HintException
 	 */
@@ -703,7 +710,7 @@ 
 	/**
 	 * get database row of a give share
 	 *
-	 * @param $id
+	 * @param integer $id
 	 * @return array
 	 * @throws ShareNotFound
 	 */

apps/files_sharing/lib/Controller/ShareController.php

Doc Comments +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
 	/**
 	 * Performs a DELETE or UPDATE query to the database.
 	 * @param \Doctrine\DBAL\Driver\Statement $query
-	 * @param array $parameters
+	 * @param string[] $parameters
 	 * @return bool true if at least one row was modified, false otherwise
 	 */
 	protected function modify($query, $parameters) {