nextcloud / server

apps/federation/lib/AppInfo/Application.php

Unused Use Statements -3 removed lines

@@ -24,16 +24,13 @@
 
 namespace OCA\Federation\AppInfo;
 
-use OCA\Federation\API\OCSAuthAPI;
 use OCA\Federation\Controller\SettingsController;
 use OCA\Federation\DAV\FedAuth;
 use OCA\Federation\DbHandler;
 use OCA\Federation\Hooks;
 use OCA\Federation\Middleware\AddServerMiddleware;
 use OCA\Federation\SyncFederationAddressBooks;
-use OCA\Federation\SyncJob;
 use OCA\Federation\TrustedServers;
-use OCP\API;
 use OCP\App;
 use OCP\AppFramework\IAppContainer;
 use OCP\SabrePluginEvent;

lib/private/AppFramework/OCS/BaseResponse.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 	/**
 	 * BaseResponse constructor.
 	 *
-	 * @param DataResponse|null $dataResponse
+	 * @param DataResponse $dataResponse
 	 * @param string $format
 	 * @param string|null $statusMessage
 	 * @param int|null $itemsCount

lib/private/Server.php

Doc Comments +2 added lines, -1 removed lines

@@ -1143,7 +1143,7 @@ 
 	 * Get the certificate manager for the user
 	 *
 	 * @param string $userId (optional) if not specified the current loggedin user is used, use null to get the system certificate manager
-	 * @return \OCP\ICertificateManager | null if $uid is null and no user is logged in
+	 * @return null|CertificateManager | null if $uid is null and no user is logged in
 	 */
 	public function getCertificateManager($userId = '') {
 		if ($userId === '') {
@@ -1464,6 +1464,7 @@ 
 	}
 
 	/**
+	 * @param string $app
 	 * @return \OCP\Files\IAppData
 	 */
 	public function getAppDataDir($app) {

lib/public/AppFramework/Http/Response.php

Doc Comments +2 added lines, -2 removed lines

@@ -226,7 +226,7 @@ 
 
 	/**
 	 * By default renders no output
-	 * @return null
+	 * @return string
 	 * @since 6.0.0
 	 */
 	public function render() {
@@ -259,7 +259,7 @@ 
 
 	/**
 	 * Get the currently used Content-Security-Policy
-	 * @return EmptyContentSecurityPolicy|null Used Content-Security-Policy or null if
+	 * @return ContentSecurityPolicy|null Used Content-Security-Policy or null if
 	 *                                    none specified.
 	 * @since 8.1.0
 	 */

apps/dav/lib/CalDAV/Publishing/PublishPlugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
 	 * @param RequestInterface $request
 	 * @param ResponseInterface $response
 	 *
-	 * @return void|bool
+	 * @return null|false
 	 */
 	public function httpPost(RequestInterface $request, ResponseInterface $response) {
 		$path = $request->getPath();

apps/dav/lib/CardDAV/AddressBookRoot.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
 
 	/**
 	 * @param \Sabre\DAVACL\PrincipalBackend\BackendInterface $principalBackend
-	 * @param \Sabre\CardDAV\Backend\BackendInterface $carddavBackend
+	 * @param CardDavBackend $carddavBackend
 	 * @param string $principalPrefix
 	 */
 	public function __construct(\Sabre\DAVACL\PrincipalBackend\BackendInterface $principalBackend, \Sabre\CardDAV\Backend\BackendInterface $carddavBackend, $principalPrefix = 'principals') {

lib/private/Share20/DefaultShareProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -770,7 +770,7 @@
 
 	/**
 	 * @param Share[] $shares
-	 * @param $userId
+	 * @param string $userId
 	 * @return Share[] The updates shares if no update is found for a share return the original
 	 */
 	private function resolveGroupShares($shares, $userId) {

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 namespace OC\Share20;
 
 use OC\Files\Cache\Cache;
-use OC\Files\Cache\CacheEntry;
 use OCP\Files\File;
 use OCP\Files\Folder;
 use OCP\Share\IShareProvider;

apps/user_ldap/lib/Helper.php

Doc Comments +3 added lines

@@ -105,6 +105,9 @@
 		return $result;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	private function getServersConfig($value) {
 		$regex = '/' . $value . '$/S';
 

lib/private/Repair/Collation.php

Doc Comments +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
 	}
 
 	/**
-	 * @param \Doctrine\DBAL\Connection $connection
+	 * @param IDBConnection $connection
 	 * @return string[]
 	 */
 	protected function getAllNonUTF8BinTables($connection) {