nextcloud / server

lib/private/AppFramework/Middleware/Security/RateLimitingMiddleware.php

Spacing +4 added lines, -4 removed lines

@@ -84,8 +84,8 @@ 
 		$anonPeriod = $this->reflector->getAnnotationParameter('AnonRateThrottle', 'period');
 		$userLimit = $this->reflector->getAnnotationParameter('UserRateThrottle', 'limit');
 		$userPeriod = $this->reflector->getAnnotationParameter('UserRateThrottle', 'period');
-		$rateLimitIdentifier = get_class($controller) . '::' . $methodName;
-		if($userLimit !== '' && $userPeriod !== '' && $this->userSession->isLoggedIn()) {
+		$rateLimitIdentifier = get_class($controller).'::'.$methodName;
+		if ($userLimit !== '' && $userPeriod !== '' && $this->userSession->isLoggedIn()) {
 			$this->limiter->registerUserRequest(
 				$rateLimitIdentifier,
 				$userLimit,
@@ -106,8 +106,8 @@ 
 	 * {@inheritDoc}
 	 */
 	public function afterException($controller, $methodName, \Exception $exception) {
-		if($exception instanceof RateLimitExceededException) {
-			if (stripos($this->request->getHeader('Accept'),'html') === false) {
+		if ($exception instanceof RateLimitExceededException) {
+			if (stripos($this->request->getHeader('Accept'), 'html') === false) {
 				$response = new JSONResponse(
 					[
 						'message' => $exception->getMessage(),

lib/private/Security/RateLimiting/Backend/MemoryCache.php

Spacing +5 added lines, -5 removed lines

@@ -54,7 +54,7 @@ 
 	 */
 	private function hash($methodIdentifier,
 						  $userIdentifier) {
-		return hash('sha512', $methodIdentifier . $userIdentifier);
+		return hash('sha512', $methodIdentifier.$userIdentifier);
 	}
 
 	/**
@@ -63,7 +63,7 @@ 
 	 */
 	private function getExistingAttempts($identifier) {
 		$cachedAttempts = json_decode($this->cache->get($identifier), true);
-		if(is_array($cachedAttempts)) {
+		if (is_array($cachedAttempts)) {
 			return $cachedAttempts;
 		}
 
@@ -83,7 +83,7 @@ 
 		$currentTime = $this->timeFactory->getTime();
 		/** @var array $existingAttempts */
 		foreach ($existingAttempts as $attempt) {
-			if(($attempt + $seconds) > $currentTime) {
+			if (($attempt + $seconds) > $currentTime) {
 				$count++;
 			}
 		}
@@ -103,14 +103,14 @@ 
 
 		// Unset all attempts older than $period
 		foreach ($existingAttempts as $key => $attempt) {
-			if(($attempt + $period) < $currentTime) {
+			if (($attempt + $period) < $currentTime) {
 				unset($existingAttempts[$key]);
 			}
 		}
 		$existingAttempts = array_values($existingAttempts);
 
 		// Store the new attempt
-		$existingAttempts[] = (string)$currentTime;
+		$existingAttempts[] = (string) $currentTime;
 		$this->cache->set($identifier, json_encode($existingAttempts));
 	}
 }

lib/private/AppFramework/Middleware/Security/BruteForceMiddleware.php

Spacing +2 added lines, -2 removed lines

@@ -61,7 +61,7 @@ 
 	public function beforeController($controller, $methodName) {
 		parent::beforeController($controller, $methodName);
 
-		if($this->reflector->hasAnnotation('BruteForceProtection')) {
+		if ($this->reflector->hasAnnotation('BruteForceProtection')) {
 			$action = $this->reflector->getAnnotationParameter('BruteForceProtection', 'action');
 			$this->throttler->sleepDelay($this->request->getRemoteAddress(), $action);
 		}
@@ -71,7 +71,7 @@ 
 	 * {@inheritDoc}
 	 */
 	public function afterController($controller, $methodName, Response $response) {
-		if($this->reflector->hasAnnotation('BruteForceProtection') && $response->isThrottled()) {
+		if ($this->reflector->hasAnnotation('BruteForceProtection') && $response->isThrottled()) {
 			$action = $this->reflector->getAnnotationParameter('BruteForceProtection', 'action');
 			$ip = $this->request->getRemoteAddress();
 			$this->throttler->sleepDelay($ip, $action);

apps/federatedfilesharing/lib/Controller/MountPublicLinkController.php

Spacing +6 added lines, -6 removed lines

@@ -147,7 +147,7 @@ 
 		$storedPassword = $share->getPassword();
 		$authenticated = $this->session->get('public_link_authenticated') === $share->getId() ||
 			$this->shareManager->checkPassword($share, $password);
-		if (!empty($storedPassword) && !$authenticated ) {
+		if (!empty($storedPassword) && !$authenticated) {
 			$response = new JSONResponse(
 				['message' => 'No permission to access the share'],
 				Http::STATUS_BAD_REQUEST
@@ -191,7 +191,7 @@ 
 		$httpClient = $this->clientService->newClient();
 
 		try {
-			$response = $httpClient->post($remote . '/index.php/apps/federatedfilesharing/createFederatedShare',
+			$response = $httpClient->post($remote.'/index.php/apps/federatedfilesharing/createFederatedShare',
 				[
 					'body' =>
 						[
@@ -285,14 +285,14 @@ 
 			// note: checkStorageAvailability will already remove the invalid share
 			Util::writeLog(
 				'federatedfilesharing',
-				'Invalid remote storage: ' . get_class($e) . ': ' . $e->getMessage(),
+				'Invalid remote storage: '.get_class($e).': '.$e->getMessage(),
 				Util::DEBUG
 			);
 			return new JSONResponse(['message' => $this->l->t('Could not authenticate to remote share, password might be wrong')], Http::STATUS_BAD_REQUEST);
 		} catch (\Exception $e) {
 			Util::writeLog(
 				'federatedfilesharing',
-				'Invalid remote storage: ' . get_class($e) . ': ' . $e->getMessage(),
+				'Invalid remote storage: '.get_class($e).': '.$e->getMessage(),
 				Util::DEBUG
 			);
 			$externalManager->removeShare($mount->getMountPoint());
@@ -311,14 +311,14 @@ 
 			} catch (StorageInvalidException $e) {
 				Util::writeLog(
 					'federatedfilesharing',
-					'Invalid remote storage: ' . get_class($e) . ': ' . $e->getMessage(),
+					'Invalid remote storage: '.get_class($e).': '.$e->getMessage(),
 					Util::DEBUG
 				);
 				return new JSONResponse(['message' => $this->l->t('Storage not valid')], Http::STATUS_BAD_REQUEST);
 			} catch (\Exception $e) {
 				Util::writeLog(
 					'federatedfilesharing',
-					'Invalid remote storage: ' . get_class($e) . ': ' . $e->getMessage(),
+					'Invalid remote storage: '.get_class($e).': '.$e->getMessage(),
 					Util::DEBUG
 				);
 				return new JSONResponse(['message' => $this->l->t('Couldn\'t add remote share')], Http::STATUS_BAD_REQUEST);

apps/files_external/lib/Controller/UserStoragesController.php

Spacing +1 added lines, -1 removed lines

@@ -198,7 +198,7 @@
 		} catch (NotFoundException $e) {
 			return new DataResponse(
 				[
-					'message' => (string)$this->l10n->t('Storage with ID "%d" not found', array($id))
+					'message' => (string) $this->l10n->t('Storage with ID "%d" not found', array($id))
 				],
 				Http::STATUS_NOT_FOUND
 			);

apps/files_external/lib/Controller/StoragesController.php

Spacing +11 added lines, -11 removed lines

@@ -127,7 +127,7 @@ 
 			$this->logger->logException($e);
 			return new DataResponse(
 				[
-					'message' => (string)$this->l10n->t('Invalid backend or authentication mechanism class')
+					'message' => (string) $this->l10n->t('Invalid backend or authentication mechanism class')
 				],
 				Http::STATUS_UNPROCESSABLE_ENTITY
 			);
@@ -146,7 +146,7 @@ 
 		if ($mountPoint === '') {
 			return new DataResponse(
 				array(
-					'message' => (string)$this->l10n->t('Invalid mount point')
+					'message' => (string) $this->l10n->t('Invalid mount point')
 				),
 				Http::STATUS_UNPROCESSABLE_ENTITY
 			);
@@ -156,7 +156,7 @@ 
 			// objectstore must not be sent from client side
 			return new DataResponse(
 				array(
-					'message' => (string)$this->l10n->t('Objectstore forbidden')
+					'message' => (string) $this->l10n->t('Objectstore forbidden')
 				),
 				Http::STATUS_UNPROCESSABLE_ENTITY
 			);
@@ -170,7 +170,7 @@ 
 			// invalid backend
 			return new DataResponse(
 				array(
-					'message' => (string)$this->l10n->t('Invalid storage backend "%s"', [
+					'message' => (string) $this->l10n->t('Invalid storage backend "%s"', [
 						$backend->getIdentifier()
 					])
 				),
@@ -182,7 +182,7 @@ 
 			// not permitted to use backend
 			return new DataResponse(
 				array(
-					'message' => (string)$this->l10n->t('Not permitted to use backend "%s"', [
+					'message' => (string) $this->l10n->t('Not permitted to use backend "%s"', [
 						$backend->getIdentifier()
 					])
 				),
@@ -193,7 +193,7 @@ 
 			// not permitted to use auth mechanism
 			return new DataResponse(
 				array(
-					'message' => (string)$this->l10n->t('Not permitted to use authentication mechanism "%s"', [
+					'message' => (string) $this->l10n->t('Not permitted to use authentication mechanism "%s"', [
 						$authMechanism->getIdentifier()
 					])
 				),
@@ -205,7 +205,7 @@ 
 			// unsatisfied parameters
 			return new DataResponse(
 				array(
-					'message' => (string)$this->l10n->t('Unsatisfied backend parameters')
+					'message' => (string) $this->l10n->t('Unsatisfied backend parameters')
 				),
 				Http::STATUS_UNPROCESSABLE_ENTITY
 			);
@@ -214,7 +214,7 @@ 
 			// unsatisfied parameters
 			return new DataResponse(
 				[
-					'message' => (string)$this->l10n->t('Unsatisfied authentication mechanism parameters')
+					'message' => (string) $this->l10n->t('Unsatisfied authentication mechanism parameters')
 				],
 				Http::STATUS_UNPROCESSABLE_ENTITY
 			);
@@ -241,7 +241,7 @@ 
 	 * @param StorageConfig $storage storage configuration
 	 * @param bool $testOnly whether to storage should only test the connection or do more things
 	 */
-	protected function updateStorageStatus(StorageConfig &$storage, $testOnly = true) {
+	protected function updateStorageStatus(StorageConfig & $storage, $testOnly = true) {
 		try {
 			$this->manipulateStorageConfig($storage);
 
@@ -306,7 +306,7 @@ 
 		} catch (NotFoundException $e) {
 			return new DataResponse(
 				[
-					'message' => (string)$this->l10n->t('Storage with ID "%d" not found', array($id))
+					'message' => (string) $this->l10n->t('Storage with ID "%d" not found', array($id))
 				],
 				Http::STATUS_NOT_FOUND
 			);
@@ -331,7 +331,7 @@ 
 		} catch (NotFoundException $e) {
 			return new DataResponse(
 				[
-					'message' => (string)$this->l10n->t('Storage with ID "%d" not found', array($id))
+					'message' => (string) $this->l10n->t('Storage with ID "%d" not found', array($id))
 				],
 				Http::STATUS_NOT_FOUND
 			);

apps/user_ldap/templates/part.wizard-groupfilter.php

Spacing +11 added lines, -11 removed lines

@@ -1,11 +1,11 @@ 
 <fieldset id="ldapWizard4">
 	<div>
 		<p>
-			<?php p($l->t('Groups meeting these criteria are available in %s:', $theme->getName()));?>
+			<?php p($l->t('Groups meeting these criteria are available in %s:', $theme->getName())); ?>
 		</p>
 		<p>
 			<label for="ldap_groupfilter_objectclass">
-				<?php p($l->t('Only these object classes:'));?>
+				<?php p($l->t('Only these object classes:')); ?>
 			</label>
 
 			<select id="ldap_groupfilter_objectclass" multiple="multiple"
@@ -14,10 +14,10 @@ 
 		</p>
 		<p>
 			<label for="ldap_groupfilter_groups">
-				<?php p($l->t('Only from these groups:'));?>
+				<?php p($l->t('Only from these groups:')); ?>
 			</label>
 
-			<input type="text" class="ldapManyGroupsSupport ldapManyGroupsSearch hidden" placeholder="<?php p($l->t('Search groups'));?>" />
+			<input type="text" class="ldapManyGroupsSupport ldapManyGroupsSearch hidden" placeholder="<?php p($l->t('Search groups')); ?>" />
 
 			<select id="ldap_groupfilter_groups" multiple="multiple"
 			 name="ldap_groupfilter_groups" class="multiSelectPlugin">
@@ -27,25 +27,25 @@ 
 		<p class="ldapManyGroupsSupport hidden">
 			<label></label>
 			<select class="ldapGroupList ldapGroupListAvailable" multiple="multiple"
-					title="<?php p($l->t('Available groups'));?>"></select>
+					title="<?php p($l->t('Available groups')); ?>"></select>
 			<span class="buttonSpan">
 				<button class="ldapGroupListSelect" type="button">&gt;</button><br/>
 				<button class="ldapGroupListDeselect" type="button">&lt;</button>
 			</span>
 			<select class="ldapGroupList ldapGroupListSelected" multiple="multiple"
-					title="<?php p($l->t('Selected groups'));?>"></select>
+					title="<?php p($l->t('Selected groups')); ?>"></select>
 		</p>
 		<p>
-			<label><a id='toggleRawGroupFilter' class='ldapToggle'>↓ <?php p($l->t('Edit LDAP Query'));?></a></label>
+			<label><a id='toggleRawGroupFilter' class='ldapToggle'>↓ <?php p($l->t('Edit LDAP Query')); ?></a></label>
 		</p>
 		<p id="ldapReadOnlyGroupFilterContainer" class="hidden ldapReadOnlyFilterContainer">
-			<label><?php p($l->t('LDAP Filter:'));?></label>
+			<label><?php p($l->t('LDAP Filter:')); ?></label>
 			<span class="ldapFilterReadOnlyElement ldapInputColElement"></span>
 		</p>
 		<p id="rawGroupFilterContainer" class="invisible">
 			<textarea type="text" id="ldap_group_filter" name="ldap_group_filter"
-					  placeholder="<?php p($l->t('Edit LDAP Query'));?>"
-					  title="<?php p($l->t('The filter specifies which LDAP groups shall have access to the %s instance.', $theme->getName()));?>">
+					  placeholder="<?php p($l->t('Edit LDAP Query')); ?>"
+					  title="<?php p($l->t('The filter specifies which LDAP groups shall have access to the %s instance.', $theme->getName())); ?>">
 			</textarea>
 		</p>
 		<p>
@@ -53,7 +53,7 @@ 
 		</p>
 		<p class="ldap_count">
 			<button class="ldapGetEntryCount ldapGetGroupCount" name="ldapGetEntryCount" type="button">
-				<?php p($l->t('Verify settings and count the groups'));?>
+				<?php p($l->t('Verify settings and count the groups')); ?>
 			</button>
 			<span id="ldap_group_count"></span>
 		</p>

apps/files_external/lib/Controller/UserGlobalStoragesController.php

Spacing +3 added lines, -3 removed lines

@@ -122,7 +122,7 @@ 
 		} catch (NotFoundException $e) {
 			return new DataResponse(
 				[
-					'message' => (string)$this->l10n->t('Storage with ID "%d" not found', array($id))
+					'message' => (string) $this->l10n->t('Storage with ID "%d" not found', array($id))
 				],
 				Http::STATUS_NOT_FOUND
 			);
@@ -162,7 +162,7 @@ 
 			} else {
 				return new DataResponse(
 					[
-						'message' => (string)$this->l10n->t('Storage with ID "%d" is not user editable', array($id))
+						'message' => (string) $this->l10n->t('Storage with ID "%d" is not user editable', array($id))
 					],
 					Http::STATUS_FORBIDDEN
 				);
@@ -170,7 +170,7 @@ 
 		} catch (NotFoundException $e) {
 			return new DataResponse(
 				[
-					'message' => (string)$this->l10n->t('Storage with ID "%d" not found', array($id))
+					'message' => (string) $this->l10n->t('Storage with ID "%d" not found', array($id))
 				],
 				Http::STATUS_NOT_FOUND
 			);

apps/files_external/lib/Controller/GlobalStoragesController.php

Spacing +1 added lines, -1 removed lines

@@ -198,7 +198,7 @@
 		} catch (NotFoundException $e) {
 			return new DataResponse(
 				[
-					'message' => (string)$this->l10n->t('Storage with ID "%d" not found', array($id))
+					'message' => (string) $this->l10n->t('Storage with ID "%d" not found', array($id))
 				],
 				Http::STATUS_NOT_FOUND
 			);