Completed
Pull Request — master (#7490)
by Tobia
19:43 queued 01:32
created
apps/user_ldap/composer/composer/ClassLoader.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      * appending or prepending to the ones previously set for this namespace.
149 149
      *
150 150
      * @param string       $prefix  The prefix/namespace, with trailing '\\'
151
-     * @param array|string $paths   The PSR-4 base directories
151
+     * @param string $paths   The PSR-4 base directories
152 152
      * @param bool         $prepend Whether to prepend the directories
153 153
      *
154 154
      * @throws \InvalidArgumentException
@@ -367,6 +367,10 @@  discard block
 block discarded – undo
367 367
         return $file;
368 368
     }
369 369
 
370
+    /**
371
+     * @param string $class
372
+     * @param string $ext
373
+     */
370 374
     private function findFileWithExtension($class, $ext)
371 375
     {
372 376
         // PSR-4 lookup
Please login to merge, or discard this patch.
lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
 	 * @param bool $isLoggedIn
103 103
 	 * @param bool $isAdminUser
104 104
 	 * @param ContentSecurityPolicyManager $contentSecurityPolicyManager
105
-	 * @param CSRFTokenManager $csrfTokenManager
105
+	 * @param CsrfTokenManager $csrfTokenManager
106 106
 	 * @param ContentSecurityPolicyNonceManager $cspNonceManager
107 107
 	 * @param IAppManager $appManager
108 108
 	 */
Please login to merge, or discard this patch.
lib/private/legacy/files.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -338,7 +338,7 @@
 block discarded – undo
338 338
 	 *
339 339
 	 * @param int $size file size in bytes
340 340
 	 * @param array $files override '.htaccess' and '.user.ini' locations
341
-	 * @return bool|int false on failure, size on success
341
+	 * @return integer false on failure, size on success
342 342
 	 */
343 343
 	public static function setUploadLimit($size, $files = []) {
344 344
 		//don't allow user to break his config
Please login to merge, or discard this patch.
lib/private/Avatar.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 	 * @param int $r
269 269
 	 * @param int $g
270 270
 	 * @param int $b
271
-	 * @return double[] Array containing h s l in [0, 1] range
271
+	 * @return double Array containing h s l in [0, 1] range
272 272
 	 */
273 273
 	private function rgbToHsl($r, $g, $b) {
274 274
 		$r /= 255.0;
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
 
307 307
 	/**
308 308
 	 * @param string $text
309
-	 * @return int[] Array containting r g b in the range [0, 255]
309
+	 * @return double[] Array containting r g b in the range [0, 255]
310 310
 	 */
311 311
 	private function avatarBackgroundColor($text) {
312 312
 		$hash = preg_replace('/[^0-9a-f]+/', '', $text);
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
 	 * @param double $h Hue in range [0, 1]
356 356
 	 * @param double $s Saturation in range [0, 1]
357 357
 	 * @param double $l Lightness in range [0, 1]
358
-	 * @return int[] Array containing r g b in the range [0, 255]
358
+	 * @return double[] Array containing r g b in the range [0, 255]
359 359
 	 */
360 360
 	private function hslToRgb($h, $s, $l){
361 361
 		$hue2rgb = function ($p, $q, $t){
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 	 * @param ILogger $logger
96 96
 	 * @param ITimeFactory $timeFactory
97 97
 	 * @param L10NFactory $l10nFactory
98
-	 * @param IUrlGenerator $urlGenerator
98
+	 * @param IURLGenerator $urlGenerator
99 99
 	 * @param Defaults $defaults
100 100
 	 * @param string $userId
101 101
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/File.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -261,6 +261,9 @@  discard block
 block discarded – undo
261 261
 		return '"' . $this->info->getEtag() . '"';
262 262
 	}
263 263
 
264
+	/**
265
+	 * @param string $path
266
+	 */
264 267
 	private function getPartFileBasePath($path) {
265 268
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
266 269
 		if ($partFileInStorage) {
@@ -606,6 +609,9 @@  discard block
 block discarded – undo
606 609
 		return $this->info->getChecksum();
607 610
 	}
608 611
 
612
+	/**
613
+	 * @param string $string
614
+	 */
609 615
 	protected function header($string) {
610 616
 		\header($string);
611 617
 	}
Please login to merge, or discard this patch.
apps/files_sharing/lib/Cache.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -135,6 +135,10 @@
 block discarded – undo
135 135
 		return parent::moveFromCache($sourceCache, $sourcePath, $targetPath);
136 136
 	}
137 137
 
138
+	/**
139
+	 * @param ICacheEntry $entry
140
+	 * @param string $path
141
+	 */
138 142
 	protected function formatCacheEntry($entry, $path = null) {
139 143
 		if (is_null($path)) {
140 144
 			$path = isset($entry['path']) ? $entry['path'] : '';
Please login to merge, or discard this patch.
apps/user_ldap/lib/Access.php 1 patch
Doc Comments   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -503,7 +503,7 @@  discard block
 block discarded – undo
503 503
 
504 504
 	/**
505 505
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
506
-	 * @param string $dn the dn of the user object
506
+	 * @param string $fdn the dn of the user object
507 507
 	 * @param string $ldapName optional, the display name of the object
508 508
 	 * @return string|false with with the name to use in Nextcloud
509 509
 	 */
@@ -790,7 +790,7 @@  discard block
 block discarded – undo
790 790
 	 * the login filter.
791 791
 	 *
792 792
 	 * @param string $loginName
793
-	 * @param array $attributes optional, list of attributes to read
793
+	 * @param string[] $attributes optional, list of attributes to read
794 794
 	 * @return array
795 795
 	 */
796 796
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -876,7 +876,7 @@  discard block
 block discarded – undo
876 876
 
877 877
 	/**
878 878
 	 * @param string $filter
879
-	 * @param string|string[] $attr
879
+	 * @param string[] $attr
880 880
 	 * @param int $limit
881 881
 	 * @param int $offset
882 882
 	 * @return array
@@ -924,7 +924,7 @@  discard block
 block discarded – undo
924 924
 
925 925
 	/**
926 926
 	 * @param string $filter
927
-	 * @param string|string[] $attr
927
+	 * @param string[] $attr
928 928
 	 * @param int $limit
929 929
 	 * @param int $offset
930 930
 	 * @return false|int
@@ -1023,7 +1023,7 @@  discard block
 block discarded – undo
1023 1023
 	/**
1024 1024
 	 * retrieved. Results will according to the order in the array.
1025 1025
 	 *
1026
-	 * @param $filter
1026
+	 * @param string $filter
1027 1027
 	 * @param $base
1028 1028
 	 * @param string[]|string|null $attr
1029 1029
 	 * @param int $limit optional, maximum results to be counted
@@ -1285,7 +1285,7 @@  discard block
 block discarded – undo
1285 1285
 
1286 1286
 	/**
1287 1287
 	 * @param string $name
1288
-	 * @return bool|mixed|string
1288
+	 * @return string
1289 1289
 	 */
1290 1290
 	public function sanitizeUsername($name) {
1291 1291
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1309,6 +1309,7 @@  discard block
 block discarded – undo
1309 1309
 	* escapes (user provided) parts for LDAP filter
1310 1310
 	* @param string $input, the provided value
1311 1311
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
1312
+	* @param string $input
1312 1313
 	* @return string the escaped string
1313 1314
 	*/
1314 1315
 	public function escapeFilterPart($input, $allowAsterisk = false) {
Please login to merge, or discard this patch.
apps/dav/lib/AppInfo/Application.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
 	}
77 77
 
78 78
 	/**
79
-	 * @param IManager $contactsManager
79
+	 * @param IContactsManager $contactsManager
80 80
 	 */
81 81
 	public function setupSystemContactsProvider(IContactsManager $contactsManager) {
82 82
 		/** @var ContactsManager $cm */
Please login to merge, or discard this patch.