Passed
Push — master ( 0e53be...4a2921 )
by Roeland
25:30 queued 15:28
created
apps/comments/lib/Collaboration/CommentersSorter.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -49,12 +49,12 @@  discard block
 block discarded – undo
49 49
 	 */
50 50
 	public function sort(array &$sortArray, array $context) {
51 51
 		$commenters = $this->retrieveCommentsInformation($context['itemType'], $context['itemId']);
52
-		if(count($commenters) === 0) {
52
+		if (count($commenters) === 0) {
53 53
 			return;
54 54
 		}
55 55
 
56 56
 		foreach ($sortArray as $type => &$byType) {
57
-			if(!isset($commenters[$type])) {
57
+			if (!isset($commenters[$type])) {
58 58
 				continue;
59 59
 			}
60 60
 
@@ -65,9 +65,9 @@  discard block
 block discarded – undo
65 65
 				return [$i++, $element];
66 66
 			}, $byType);
67 67
 
68
-			usort($workArray, function ($a, $b) use ($commenters, $type) {
68
+			usort($workArray, function($a, $b) use ($commenters, $type) {
69 69
 				$r = $this->compare($a[1], $b[1], $commenters[$type]);
70
-				if($r === 0) {
70
+				if ($r === 0) {
71 71
 					$r = $a[0] - $b[0];
72 72
 				}
73 73
 				return $r;
@@ -85,16 +85,16 @@  discard block
 block discarded – undo
85 85
 	 */
86 86
 	protected function retrieveCommentsInformation($type, $id) {
87 87
 		$comments = $this->commentsManager->getForObject($type, $id);
88
-		if(count($comments) === 0) {
88
+		if (count($comments) === 0) {
89 89
 			return [];
90 90
 		}
91 91
 
92 92
 		$actors = [];
93 93
 		foreach ($comments as $comment) {
94
-			if(!isset($actors[$comment->getActorType()])) {
94
+			if (!isset($actors[$comment->getActorType()])) {
95 95
 				$actors[$comment->getActorType()] = [];
96 96
 			}
97
-			if(!isset($actors[$comment->getActorType()][$comment->getActorId()])) {
97
+			if (!isset($actors[$comment->getActorType()][$comment->getActorId()])) {
98 98
 				$actors[$comment->getActorType()][$comment->getActorId()] = 1;
99 99
 			} else {
100 100
 				$actors[$comment->getActorType()][$comment->getActorId()]++;
Please login to merge, or discard this patch.
lib/private/DB/OracleMigrator.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 				$column->changedProperties = array_diff($column->changedProperties, ['autoincrement', 'unsigned']);
155 155
 			}
156 156
 			// remove columns that no longer have changed (because autoincrement and unsigned are not supported)
157
-			$tableDiff->changedColumns = array_filter($tableDiff->changedColumns, function (ColumnDiff $column) {
157
+			$tableDiff->changedColumns = array_filter($tableDiff->changedColumns, function(ColumnDiff $column) {
158 158
 				return count($column->changedProperties) > 0;
159 159
 			});
160 160
 
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 	 * @return string
204 204
 	 */
205 205
 	protected function generateTemporaryTableName($name) {
206
-		return 'oc_' . uniqid();
206
+		return 'oc_'.uniqid();
207 207
 	}
208 208
 
209 209
 	/**
@@ -212,16 +212,16 @@  discard block
 block discarded – undo
212 212
 	 */
213 213
 	protected function convertStatementToScript($statement) {
214 214
 		if (substr($statement, -1) === ';') {
215
-			return $statement . PHP_EOL . '/' . PHP_EOL;
215
+			return $statement.PHP_EOL.'/'.PHP_EOL;
216 216
 		}
217
-		$script = $statement . ';';
217
+		$script = $statement.';';
218 218
 		$script .= PHP_EOL;
219 219
 		$script .= PHP_EOL;
220 220
 		return $script;
221 221
 	}
222 222
 
223 223
 	protected function getFilterExpression() {
224
-		return '/^"' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
224
+		return '/^"'.preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')).'/';
225 225
 	}
226 226
 
227 227
 }
Please login to merge, or discard this patch.
apps/user_ldap/lib/UserPluginManager.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -58,13 +58,13 @@  discard block
 block discarded – undo
58 58
 		$respondToActions = $plugin->respondToActions();
59 59
 		$this->respondToActions |= $respondToActions;
60 60
 
61
-		foreach($this->which as $action => $v) {
62
-			if (is_int($action) && (bool)($respondToActions & $action)) {
61
+		foreach ($this->which as $action => $v) {
62
+			if (is_int($action) && (bool) ($respondToActions & $action)) {
63 63
 				$this->which[$action] = $plugin;
64 64
 				\OC::$server->getLogger()->debug("Registered action ".$action." to plugin ".get_class($plugin), ['app' => 'user_ldap']);
65 65
 			}
66 66
 		}
67
-		if (method_exists($plugin,'deleteUser')) {
67
+		if (method_exists($plugin, 'deleteUser')) {
68 68
 			$this->which['deleteUser'] = $plugin;
69 69
 			\OC::$server->getLogger()->debug("Registered action deleteUser to plugin ".get_class($plugin), ['app' => 'user_ldap']);
70 70
 		}
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 		$plugin = $this->which[Backend::CREATE_USER];
92 92
 
93 93
 		if ($plugin) {
94
-			return $plugin->createUser($username,$password);
94
+			return $plugin->createUser($username, $password);
95 95
 		}
96 96
 		throw new \Exception('No plugin implements createUser in this LDAP Backend.');
97 97
 	}
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 		$plugin = $this->which[Backend::SET_PASSWORD];
108 108
 
109 109
 		if ($plugin) {
110
-			return $plugin->setPassword($uid,$password);
110
+			return $plugin->setPassword($uid, $password);
111 111
 		}
112 112
 		throw new \Exception('No plugin implements setPassword in this LDAP Backend.');
113 113
 	}
Please login to merge, or discard this patch.
apps/user_ldap/lib/GroupPluginManager.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,8 +53,8 @@  discard block
 block discarded – undo
53 53
 		$respondToActions = $plugin->respondToActions();
54 54
 		$this->respondToActions |= $respondToActions;
55 55
 
56
-		foreach($this->which as $action => $v) {
57
-			if ((bool)($respondToActions & $action)) {
56
+		foreach ($this->which as $action => $v) {
57
+			if ((bool) ($respondToActions & $action)) {
58 58
 				$this->which[$action] = $plugin;
59 59
 				\OC::$server->getLogger()->debug("Registered action ".$action." to plugin ".get_class($plugin), ['app' => 'user_ldap']);
60 60
 			}
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 		$plugin = $this->which[GroupInterface::COUNT_USERS];
148 148
 
149 149
 		if ($plugin) {
150
-			return $plugin->countUsersInGroup($gid,$search);
150
+			return $plugin->countUsersInGroup($gid, $search);
151 151
 		}
152 152
 		throw new \Exception('No plugin implements countUsersInGroup in this LDAP Backend.');
153 153
 	}
Please login to merge, or discard this patch.
apps/dav/lib/DAV/SystemPrincipalBackend.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@
 block discarded – undo
163 163
 	 * @return array
164 164
 	 */
165 165
 	function getGroupMembership($principal) {
166
-		list($prefix, ) = \Sabre\Uri\split($principal);
166
+		list($prefix,) = \Sabre\Uri\split($principal);
167 167
 
168 168
 		if ($prefix === 'principals/system') {
169 169
 			$principal = $this->getPrincipalByPath($principal);
Please login to merge, or discard this patch.
lib/private/Calendar/Manager.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,12 +30,12 @@  discard block
 block discarded – undo
30 30
 	/**
31 31
 	 * @var ICalendar[] holds all registered calendars
32 32
 	 */
33
-	private $calendars=[];
33
+	private $calendars = [];
34 34
 
35 35
 	/**
36 36
 	 * @var \Closure[] to call to load/register calendar providers
37 37
 	 */
38
-	private $calendarLoaders=[];
38
+	private $calendarLoaders = [];
39 39
 
40 40
 	/**
41 41
 	 * This function is used to search and find objects within the user's calendars.
@@ -50,12 +50,12 @@  discard block
 block discarded – undo
50 50
 	 * @return array an array of events/journals/todos which are arrays of arrays of key-value-pairs
51 51
 	 * @since 13.0.0
52 52
 	 */
53
-	public function search($pattern, array $searchProperties=[], array $options=[], $limit=null, $offset=null) {
53
+	public function search($pattern, array $searchProperties = [], array $options = [], $limit = null, $offset = null) {
54 54
 		$this->loadCalendars();
55 55
 		$result = [];
56
-		foreach($this->calendars as $calendar) {
56
+		foreach ($this->calendars as $calendar) {
57 57
 			$r = $calendar->search($pattern, $searchProperties, $options, $limit, $offset);
58
-			foreach($r as $o) {
58
+			foreach ($r as $o) {
59 59
 				$o['calendar-key'] = $calendar->getKey();
60 60
 				$result[] = $o;
61 61
 			}
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 	 * loads all calendars
133 133
 	 */
134 134
 	private function loadCalendars() {
135
-		foreach($this->calendarLoaders as $callable) {
135
+		foreach ($this->calendarLoaders as $callable) {
136 136
 			$callable($this);
137 137
 		}
138 138
 		$this->calendarLoaders = [];
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalendarImpl.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 	 * @return array an array of events/journals/todos which are arrays of key-value-pairs
88 88
 	 * @since 13.0.0
89 89
 	 */
90
-	public function search($pattern, array $searchProperties=[], array $options=[], $limit=null, $offset=null) {
90
+	public function search($pattern, array $searchProperties = [], array $options = [], $limit = null, $offset = null) {
91 91
 		return $this->backend->search($this->calendarInfo, $pattern,
92 92
 			$searchProperties, $options, $limit, $offset);
93 93
 	}
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 		$permissions = $this->calendar->getACL();
101 101
 		$result = 0;
102 102
 		foreach ($permissions as $permission) {
103
-			switch($permission['privilege']) {
103
+			switch ($permission['privilege']) {
104 104
 				case '{DAV:}read':
105 105
 					$result |= Constants::PERMISSION_READ;
106 106
 					break;
Please login to merge, or discard this patch.
apps/dav/lib/Controller/BirthdayCalendarController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
 								IDBConnection $db, IConfig $config,
78 78
 								IJobList $jobList,
79 79
 								IUserManager $userManager,
80
-								CalDavBackend $calDavBackend){
80
+								CalDavBackend $calDavBackend) {
81 81
 		parent::__construct($appName, $request);
82 82
 		$this->db = $db;
83 83
 		$this->config = $config;
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesReportPlugin.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -174,14 +174,14 @@  discard block
 block discarded – undo
174 174
 			return;
175 175
 		}
176 176
 
177
-		$ns = '{' . $this::NS_OWNCLOUD . '}';
177
+		$ns = '{'.$this::NS_OWNCLOUD.'}';
178 178
 		$requestedProps = [];
179 179
 		$filterRules = [];
180 180
 
181 181
 		// parse report properties and gather filter info
182 182
 		foreach ($report as $reportProps) {
183 183
 			$name = $reportProps['name'];
184
-			if ($name === $ns . 'filter-rules') {
184
+			if ($name === $ns.'filter-rules') {
185 185
 				$filterRules = $reportProps['value'];
186 186
 			} else if ($name === '{DAV:}prop') {
187 187
 				// propfind properties
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 		if (empty($filesUri)) {
243 243
 			return '';
244 244
 		}
245
-		return '/' . $filesUri;
245
+		return '/'.$filesUri;
246 246
 	}
247 247
 
248 248
 	/**
@@ -254,19 +254,19 @@  discard block
 block discarded – undo
254 254
 	 * @throws TagNotFoundException whenever a tag was not found
255 255
 	 */
256 256
 	protected function processFilterRules($filterRules) {
257
-		$ns = '{' . $this::NS_OWNCLOUD . '}';
257
+		$ns = '{'.$this::NS_OWNCLOUD.'}';
258 258
 		$resultFileIds = null;
259 259
 		$systemTagIds = [];
260 260
 		$circlesIds = [];
261 261
 		$favoriteFilter = null;
262 262
 		foreach ($filterRules as $filterRule) {
263
-			if ($filterRule['name'] === $ns . 'systemtag') {
263
+			if ($filterRule['name'] === $ns.'systemtag') {
264 264
 				$systemTagIds[] = $filterRule['value'];
265 265
 			}
266 266
 			if ($filterRule['name'] === self::CIRCLE_PROPERTYNAME) {
267 267
 				$circlesIds[] = $filterRule['value'];
268 268
 			}
269
-			if ($filterRule['name'] === $ns . 'favorite') {
269
+			if ($filterRule['name'] === $ns.'favorite') {
270 270
 				$favoriteFilter = true;
271 271
 			}
272 272
 
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
 			}
316 316
 
317 317
 			if (!empty($unknownTagIds)) {
318
-				throw new TagNotFoundException('Tag with ids ' . implode(', ', $unknownTagIds) . ' not found');
318
+				throw new TagNotFoundException('Tag with ids '.implode(', ', $unknownTagIds).' not found');
319 319
 			}
320 320
 		}
321 321
 
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
 	public function prepareResponses($filesUri, $requestedProps, $nodes) {
368 368
 		$responses = [];
369 369
 		foreach ($nodes as $node) {
370
-			$propFind = new PropFind($filesUri . $node->getPath(), $requestedProps);
370
+			$propFind = new PropFind($filesUri.$node->getPath(), $requestedProps);
371 371
 
372 372
 			$this->server->getPropertiesByNode($propFind, $node);
373 373
 			// copied from Sabre Server's getPropertiesForPath
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
 			}
381 381
 
382 382
 			$responses[] = new Response(
383
-				rtrim($this->server->getBaseUri(), '/') . $filesUri . $node->getPath(),
383
+				rtrim($this->server->getBaseUri(), '/').$filesUri.$node->getPath(),
384 384
 				$result,
385 385
 				200
386 386
 			);
Please login to merge, or discard this patch.