| Conditions | 2 |
| Paths | 1 |
| Total Lines | 55 |
| Code Lines | 34 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 72 | public function register(IRegistrationContext $context): void { |
||
| 73 | // Register Middleware |
||
| 74 | $context->registerServiceAlias('SubadminMiddleware', SubadminMiddleware::class); |
||
| 75 | $context->registerMiddleware(SubadminMiddleware::class); |
||
| 76 | $context->registerSearchProvider(SectionSearch::class); |
||
| 77 | $context->registerSearchProvider(AppSearch::class); |
||
| 78 | |||
| 79 | // Register listeners |
||
| 80 | $context->registerEventListener(AppPasswordCreatedEvent::class, AppPasswordCreatedActivityListener::class); |
||
| 81 | $context->registerEventListener(UserAddedEvent::class, UserAddedToGroupActivityListener::class); |
||
| 82 | $context->registerEventListener(UserRemovedEvent::class, UserRemovedFromGroupActivityListener::class); |
||
| 83 | |||
| 84 | /** |
||
| 85 | * Core class wrappers |
||
| 86 | */ |
||
| 87 | /** FIXME: Remove once OC_User is non-static and mockable */ |
||
| 88 | $context->registerService('isAdmin', function () { |
||
| 89 | return \OC_User::isAdminUser(\OC_User::getUser()); |
||
| 90 | }); |
||
| 91 | /** FIXME: Remove once OC_SubAdmin is non-static and mockable */ |
||
| 92 | $context->registerService('isSubAdmin', function () { |
||
| 93 | $userObject = \OC::$server->getUserSession()->getUser(); |
||
| 94 | $isSubAdmin = false; |
||
| 95 | if ($userObject !== null) { |
||
| 96 | $isSubAdmin = \OC::$server->getGroupManager()->getSubAdmin()->isSubAdmin($userObject); |
||
| 97 | } |
||
| 98 | return $isSubAdmin; |
||
| 99 | }); |
||
| 100 | $context->registerService(IProvider::class, function (IAppContainer $appContainer) { |
||
| 101 | /** @var IServerContainer $serverContainer */ |
||
| 102 | $serverContainer = $appContainer->query(IServerContainer::class); |
||
| 103 | return $serverContainer->query(IProvider::class); |
||
| 104 | }); |
||
| 105 | $context->registerService(IManager::class, function (IAppContainer $appContainer) { |
||
| 106 | /** @var IServerContainer $serverContainer */ |
||
| 107 | $serverContainer = $appContainer->query(IServerContainer::class); |
||
| 108 | return $serverContainer->getSettingsManager(); |
||
|
|
|||
| 109 | }); |
||
| 110 | |||
| 111 | $context->registerService(NewUserMailHelper::class, function (IAppContainer $appContainer) { |
||
| 112 | /** @var Server $server */ |
||
| 113 | $server = $appContainer->query(IServerContainer::class); |
||
| 114 | /** @var Defaults $defaults */ |
||
| 115 | $defaults = $server->query(Defaults::class); |
||
| 116 | |||
| 117 | return new NewUserMailHelper( |
||
| 118 | $defaults, |
||
| 119 | $server->getURLGenerator(), |
||
| 120 | $server->getL10NFactory(), |
||
| 121 | $server->getMailer(), |
||
| 122 | $server->getSecureRandom(), |
||
| 123 | new TimeFactory(), |
||
| 124 | $server->getConfig(), |
||
| 125 | $server->getCrypto(), |
||
| 126 | Util::getDefaultEmailAddress('no-reply') |
||
| 127 | ); |
||
| 166 |