SettingsController::setMaxUploadSize() - Code Metrics - Inspection of "Merge pull request #1022 from nextcloud/backport-1..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — stable10 ( 94b84f...e5eff3 )

by Lukas

created 2016-08-23 13:44 UTC

SettingsController::setMaxUploadSize() A

↳ Parent: SettingsController

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	7
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	11
rs	9.4285

<?php
/**
 *
 *
 * @author Roeland Jago Douma <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */
namespace OCA\Files\Controller;

use OCP\AppFramework\Controller;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\JSONResponse;
use OCP\IRequest;
use OCP\Util;

class SettingsController extends Controller {
	public function __construct($appName, IRequest $request) {
		parent::__construct($appName, $request);
	}

	/**
	 * @param string $maxUploadSize
	 * @return JSONResponse
	 */
	public function setMaxUploadSize($maxUploadSize) {
		$setMaxSize = \OC_Files::setUploadLimit(Util::computerFileSize($maxUploadSize));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		if ($setMaxSize === false) {
			return new JSONResponse([], Http::STATUS_BAD_REQUEST);
		} else {
			return new JSONResponse([
				'maxUploadSize' => Util::humanFileSize($setMaxSize)
			]);
		}
	}
}


1			<?php
2			/**
3			*
4			*
5			* @author Roeland Jago Douma <[email protected]>
6			*
7			* @license GNU AGPL version 3 or any later version
8			*
9			* This program is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License as
11			* published by the Free Software Foundation, either version 3 of the
12			* License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU Affero General Public License for more details.
18			*
19			* You should have received a copy of the GNU Affero General Public License
20			* along with this program. If not, see <http://www.gnu.org/licenses/>.
21			*
22			*/
23			namespace OCA\Files\Controller;
24
25			use OCP\AppFramework\Controller;
26			use OCP\AppFramework\Http;
27			use OCP\AppFramework\Http\JSONResponse;
28			use OCP\IRequest;
29			use OCP\Util;
30
31			class SettingsController extends Controller {
32			public function __construct($appName, IRequest $request) {
33			parent::__construct($appName, $request);
34			}
35
36			/**
37			* @param string $maxUploadSize
38			* @return JSONResponse
39			*/
40			public function setMaxUploadSize($maxUploadSize) {
41			$setMaxSize = \OC_Files::setUploadLimit(Util::computerFileSize($maxUploadSize));
			0 ignored issues – show Documentation introduced 2016-08-22 10:27 UTC by Report Bug Copy Issue Report `\OCP\Util::computerFileSize($maxUploadSize)` is of type `double\|false`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42
43			if ($setMaxSize === false) {
44			return new JSONResponse([], Http::STATUS_BAD_REQUEST);
45			} else {
46			return new JSONResponse([
47			'maxUploadSize' => Util::humanFileSize($setMaxSize)
48			]);
49			}
50			}
51			}
52

nextcloud / server

Push — stable10 ( 94b84f...e5eff3 )

SettingsController::setMaxUploadSize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like