@@ -132,7 +132,7 @@ |
||
132 | 132 | if (isset($jsonBlob['ncversion']) && $jsonBlob['ncversion'] === $this->getVersion()) { |
133 | 133 | |
134 | 134 | // If the timestamp is older than 300 seconds request the files new |
135 | - if ((int)$jsonBlob['timestamp'] > ($this->timeFactory->getTime() - self::INVALIDATE_AFTER_SECONDS)) { |
|
135 | + if ((int) $jsonBlob['timestamp'] > ($this->timeFactory->getTime() - self::INVALIDATE_AFTER_SECONDS)) { |
|
136 | 136 | return $jsonBlob['data']; |
137 | 137 | } |
138 | 138 |
@@ -72,7 +72,7 @@ discard block |
||
72 | 72 | return true; |
73 | 73 | } |
74 | 74 | |
75 | - $size = isset($queryParams['size']) ? (int)$queryParams['size'] : -1; |
|
75 | + $size = isset($queryParams['size']) ? (int) $queryParams['size'] : -1; |
|
76 | 76 | |
77 | 77 | $path = $request->getPath(); |
78 | 78 | $node = $this->server->tree->getNodeForPath($path); |
@@ -97,7 +97,7 @@ discard block |
||
97 | 97 | $addressbook = $this->server->tree->getNodeForPath($addressbookpath); |
98 | 98 | |
99 | 99 | $response->setHeader('Cache-Control', 'private, max-age=3600, must-revalidate'); |
100 | - $response->setHeader('Etag', $node->getETag() ); |
|
100 | + $response->setHeader('Etag', $node->getETag()); |
|
101 | 101 | $response->setHeader('Pragma', 'public'); |
102 | 102 | |
103 | 103 | try { |
@@ -85,7 +85,7 @@ discard block |
||
85 | 85 | * @return mixed the value or $default |
86 | 86 | */ |
87 | 87 | public function getValue($key, $default = null) { |
88 | - $envValue = getenv(self::ENV_PREFIX . $key); |
|
88 | + $envValue = getenv(self::ENV_PREFIX.$key); |
|
89 | 89 | if ($envValue !== false) { |
90 | 90 | return $envValue; |
91 | 91 | } |
@@ -197,7 +197,7 @@ discard block |
||
197 | 197 | foreach ($configFiles as $file) { |
198 | 198 | $fileExistsAndIsReadable = file_exists($file) && is_readable($file); |
199 | 199 | $filePointer = $fileExistsAndIsReadable ? fopen($file, 'r') : false; |
200 | - if($file === $this->configFilePath && |
|
200 | + if ($file === $this->configFilePath && |
|
201 | 201 | $filePointer === false) { |
202 | 202 | // Opening the main config might not be possible, e.g. if the wrong |
203 | 203 | // permissions are set (likely on a new installation) |
@@ -205,13 +205,13 @@ discard block |
||
205 | 205 | } |
206 | 206 | |
207 | 207 | // Try to acquire a file lock |
208 | - if(!flock($filePointer, LOCK_SH)) { |
|
208 | + if (!flock($filePointer, LOCK_SH)) { |
|
209 | 209 | throw new \Exception(sprintf('Could not acquire a shared lock on the config file %s', $file)); |
210 | 210 | } |
211 | 211 | |
212 | 212 | unset($CONFIG); |
213 | 213 | include $file; |
214 | - if(isset($CONFIG) && is_array($CONFIG)) { |
|
214 | + if (isset($CONFIG) && is_array($CONFIG)) { |
|
215 | 215 | $this->cache = array_merge($this->cache, $CONFIG); |
216 | 216 | } |
217 | 217 | |
@@ -236,29 +236,29 @@ discard block |
||
236 | 236 | $content .= var_export($this->cache, true); |
237 | 237 | $content .= ";\n"; |
238 | 238 | |
239 | - touch ($this->configFilePath); |
|
239 | + touch($this->configFilePath); |
|
240 | 240 | $filePointer = fopen($this->configFilePath, 'r+'); |
241 | 241 | |
242 | 242 | // Prevent others not to read the config |
243 | 243 | chmod($this->configFilePath, 0640); |
244 | 244 | |
245 | 245 | // File does not exist, this can happen when doing a fresh install |
246 | - if(!is_resource ($filePointer)) { |
|
246 | + if (!is_resource($filePointer)) { |
|
247 | 247 | // TODO fix this via DI once it is very clear that this doesn't cause side effects due to initialization order |
248 | 248 | // currently this breaks app routes but also could have other side effects especially during setup and exception handling |
249 | 249 | $url = \OC::$server->getURLGenerator()->linkToDocs('admin-dir_permissions'); |
250 | 250 | throw new HintException( |
251 | 251 | "Can't write into config directory!", |
252 | - 'This can usually be fixed by giving the webserver write access to the config directory. See ' . $url); |
|
252 | + 'This can usually be fixed by giving the webserver write access to the config directory. See '.$url); |
|
253 | 253 | } |
254 | 254 | |
255 | 255 | // Try to acquire a file lock |
256 | - if(!flock($filePointer, LOCK_EX)) { |
|
256 | + if (!flock($filePointer, LOCK_EX)) { |
|
257 | 257 | throw new \Exception(sprintf('Could not acquire an exclusive lock on the config file %s', $this->configFilePath)); |
258 | 258 | } |
259 | 259 | |
260 | 260 | // Write the config and release the lock |
261 | - ftruncate ($filePointer, 0); |
|
261 | + ftruncate($filePointer, 0); |
|
262 | 262 | fwrite($filePointer, $content); |
263 | 263 | fflush($filePointer); |
264 | 264 | flock($filePointer, LOCK_UN); |
@@ -35,12 +35,12 @@ discard block |
||
35 | 35 | throw new \RuntimeException("No app with given id <$appId> known."); |
36 | 36 | } |
37 | 37 | |
38 | - if (!is_dir($appPath . '/l10n/')) { |
|
38 | + if (!is_dir($appPath.'/l10n/')) { |
|
39 | 39 | return []; |
40 | 40 | } |
41 | 41 | |
42 | 42 | $errors = []; |
43 | - $directory = new \DirectoryIterator($appPath . '/l10n/'); |
|
43 | + $directory = new \DirectoryIterator($appPath.'/l10n/'); |
|
44 | 44 | |
45 | 45 | foreach ($directory as $file) { |
46 | 46 | if ($file->getExtension() !== 'json') { |
@@ -51,7 +51,7 @@ discard block |
||
51 | 51 | json_decode($content, true); |
52 | 52 | |
53 | 53 | if (json_last_error() !== JSON_ERROR_NONE) { |
54 | - $errors[] = 'Invalid language file found: l10n/' . $file->getFilename() . ': ' . json_last_error_msg(); |
|
54 | + $errors[] = 'Invalid language file found: l10n/'.$file->getFilename().': '.json_last_error_msg(); |
|
55 | 55 | } |
56 | 56 | } |
57 | 57 |
@@ -112,7 +112,7 @@ discard block |
||
112 | 112 | $json = file_get_contents('php://stdin'); |
113 | 113 | } else { |
114 | 114 | if (!file_exists($path)) { |
115 | - $output->writeln('<error>File not found: ' . $path . '</error>'); |
|
115 | + $output->writeln('<error>File not found: '.$path.'</error>'); |
|
116 | 116 | return 1; |
117 | 117 | } |
118 | 118 | $json = file_get_contents($path); |
@@ -164,7 +164,7 @@ discard block |
||
164 | 164 | $existingMount->getApplicableUsers() === $mount->getApplicableUsers() && |
165 | 165 | $existingMount->getBackendOptions() === $mount->getBackendOptions() |
166 | 166 | ) { |
167 | - $output->writeln("<error>Duplicate mount (" . $mount->getMountPoint() . ")</error>"); |
|
167 | + $output->writeln("<error>Duplicate mount (".$mount->getMountPoint().")</error>"); |
|
168 | 168 | return 1; |
169 | 169 | } |
170 | 170 | } |
@@ -31,8 +31,8 @@ discard block |
||
31 | 31 | OCP\User::checkLoggedIn(); |
32 | 32 | \OC::$server->getSession()->close(); |
33 | 33 | |
34 | -$files = isset($_GET['files']) ? (string)$_GET['files'] : ''; |
|
35 | -$dir = isset($_GET['dir']) ? (string)$_GET['dir'] : ''; |
|
34 | +$files = isset($_GET['files']) ? (string) $_GET['files'] : ''; |
|
35 | +$dir = isset($_GET['dir']) ? (string) $_GET['dir'] : ''; |
|
36 | 36 | |
37 | 37 | $files_list = json_decode($files); |
38 | 38 | // in case we get only a single file |
@@ -45,13 +45,13 @@ discard block |
||
45 | 45 | * the content must not be longer than 32 characters and must only contain |
46 | 46 | * alphanumeric characters |
47 | 47 | */ |
48 | -if(isset($_GET['downloadStartSecret']) |
|
48 | +if (isset($_GET['downloadStartSecret']) |
|
49 | 49 | && !isset($_GET['downloadStartSecret'][32]) |
50 | 50 | && preg_match('!^[a-zA-Z0-9]+$!', $_GET['downloadStartSecret']) === 1) { |
51 | 51 | setcookie('ocDownloadStarted', $_GET['downloadStartSecret'], time() + 20, '/'); |
52 | 52 | } |
53 | 53 | |
54 | -$server_params = array( 'head' => \OC::$server->getRequest()->getMethod() === 'HEAD' ); |
|
54 | +$server_params = array('head' => \OC::$server->getRequest()->getMethod() === 'HEAD'); |
|
55 | 55 | |
56 | 56 | /** |
57 | 57 | * Http range requests support |
@@ -68,7 +68,7 @@ |
||
68 | 68 | |
69 | 69 | $query = $this->connection->getQueryBuilder(); |
70 | 70 | $query->update('share') |
71 | - ->set('share_type', $query->createNamedParameter(Share::SHARE_TYPE_GUEST)) |
|
71 | + ->set('share_type', $query->createNamedParameter(Share::SHARE_TYPE_GUEST)) |
|
72 | 72 | ->where($query->expr()->eq('share_type', $query->createNamedParameter(Share::SHARE_TYPE_EMAIL))); |
73 | 73 | $query->execute(); |
74 | 74 | } |
@@ -14,8 +14,8 @@ |
||
14 | 14 | |
15 | 15 | <?php if ($_['tooBig']) { ?> |
16 | 16 | <div class="warning updateAnyways"> |
17 | - <?php p($l->t('I know that if I continue doing the update via web UI has the risk, that the request runs into a timeout and could cause data loss, but I have a backup and know how to restore my instance in case of a failure.' )); ?> |
|
18 | - <a href="?IKnowThatThisIsABigInstanceAndTheUpdateRequestCouldRunIntoATimeoutAndHowToRestoreABackup=IAmSuperSureToDoThis" class="button updateAnywaysButton"><?php p($l->t('Upgrade via web on my own risk' )); ?></a> |
|
17 | + <?php p($l->t('I know that if I continue doing the update via web UI has the risk, that the request runs into a timeout and could cause data loss, but I have a backup and know how to restore my instance in case of a failure.')); ?> |
|
18 | + <a href="?IKnowThatThisIsABigInstanceAndTheUpdateRequestCouldRunIntoATimeoutAndHowToRestoreABackup=IAmSuperSureToDoThis" class="button updateAnywaysButton"><?php p($l->t('Upgrade via web on my own risk')); ?></a> |
|
19 | 19 | </div> |
20 | 20 | <?php } ?> |
21 | 21 |
@@ -84,7 +84,7 @@ |
||
84 | 84 | |
85 | 85 | if (isset($this->namespaces[$namespace])) { |
86 | 86 | if (!isset($this->hasNoAppContainer[$namespace])) { |
87 | - $applicationClassName = 'OCA\\' . $sensitiveNamespace . '\\AppInfo\\Application'; |
|
87 | + $applicationClassName = 'OCA\\'.$sensitiveNamespace.'\\AppInfo\\Application'; |
|
88 | 88 | if (class_exists($applicationClassName)) { |
89 | 89 | new $applicationClassName(); |
90 | 90 | if (isset($this->appContainers[$namespace])) { |