Version010401Date20181207190718::changeSchema() - Code Metrics - Inspection of "Merge pull request #12920 from nextcloud/oauth2/mi..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5a9fc0...866c42 )

by Roeland

created 2018-12-10 14:46 UTC

Version010401Date20181207190718::changeSchema() A

↳ Parent: Version010401Date20181207190718

Complexity

Conditions	3
Paths	4

Size

Total Lines	57
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	41
nc	4
nop	3
dl	0
loc	57
rs	9.264
c	0
b	0
f	0

How to fix Long Method

<?php
declare(strict_types=1);
/**
 * @copyright Copyright 2018, Roeland Jago Douma <[email protected]>
 *
 * @author Roeland Jago Douma <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\OAuth2\Migration;

use Closure;
use OCP\DB\ISchemaWrapper;
use OCP\Migration\SimpleMigrationStep;
use OCP\Migration\IOutput;

class Version010401Date20181207190718 extends SimpleMigrationStep {

	/**
	 * @param IOutput $output
	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	 * @param array $options
	 * @return null|ISchemaWrapper
	 */
	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
		/** @var ISchemaWrapper $schema */
		$schema = $schemaClosure();

		if (!$schema->hasTable('oauth2_clients')) {
			$table = $schema->createTable('oauth2_clients');
			$table->addColumn('id', 'integer', [
				'autoincrement' => true,
				'notnull' => true,
				'unsigned' => true,
			]);
			$table->addColumn('name', 'string', [
				'notnull' => true,
				'length' => 64,
			]);
			$table->addColumn('redirect_uri', 'string', [
				'notnull' => true,
				'length' => 2000,
			]);
			$table->addColumn('client_identifier', 'string', [
				'notnull' => true,
				'length' => 64,
			]);
			$table->addColumn('secret', 'string', [
				'notnull' => true,
				'length' => 64,
			]);
			$table->setPrimaryKey(['id']);
			$table->addIndex(['client_identifier'], 'oauth2_client_id_idx');
		}

		if (!$schema->hasTable('oauth2_access_tokens')) {
			$table = $schema->createTable('oauth2_access_tokens');
			$table->addColumn('id', 'integer', [
				'autoincrement' => true,
				'notnull' => true,
				'unsigned' => true,
			]);
			$table->addColumn('token_id', 'integer', [
				'notnull' => true,
			]);
			$table->addColumn('client_id', 'integer', [
				'notnull' => true,
			]);
			$table->addColumn('hashed_code', 'string', [
				'notnull' => true,
				'length' => 128,
			]);
			$table->addColumn('encrypted_token', 'string', [
				'notnull' => true,
				'length' => 786,
			]);
			$table->setPrimaryKey(['id']);
			$table->addUniqueIndex(['hashed_code'], 'oauth2_access_hash_idx');
			$table->addIndex(['client_id'], 'oauth2_access_client_id_idx');
		}
		return $schema;
	}
}


1			<?php
2			declare(strict_types=1);
3			/**
4			* @copyright Copyright 2018, Roeland Jago Douma <[email protected]>
5			*
6			* @author Roeland Jago Douma <[email protected]>
7			*
8			* @license GNU AGPL version 3 or any later version
9			*
10			* This program is free software: you can redistribute it and/or modify
11			* it under the terms of the GNU Affero General Public License as
12			* published by the Free Software Foundation, either version 3 of the
13			* License, or (at your option) any later version.
14			*
15			* This program is distributed in the hope that it will be useful,
16			* but WITHOUT ANY WARRANTY; without even the implied warranty of
17			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18			* GNU Affero General Public License for more details.
19			*
20			* You should have received a copy of the GNU Affero General Public License
21			* along with this program. If not, see <http://www.gnu.org/licenses/>.
22			*
23			*/
24
25			namespace OCA\OAuth2\Migration;
26
27			use Closure;
28			use OCP\DB\ISchemaWrapper;
29			use OCP\Migration\SimpleMigrationStep;
30			use OCP\Migration\IOutput;
31
32			class Version010401Date20181207190718 extends SimpleMigrationStep {
33
34			/**
35			* @param IOutput $output
36			* @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
37			* @param array $options
38			* @return null\|ISchemaWrapper
39			*/
40			public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
41			/** @var ISchemaWrapper $schema */
42			$schema = $schemaClosure();
43
44			if (!$schema->hasTable('oauth2_clients')) {
45			$table = $schema->createTable('oauth2_clients');
46			$table->addColumn('id', 'integer', [
47			'autoincrement' => true,
48			'notnull' => true,
49			'unsigned' => true,
50			]);
51			$table->addColumn('name', 'string', [
52			'notnull' => true,
53			'length' => 64,
54			]);
55			$table->addColumn('redirect_uri', 'string', [
56			'notnull' => true,
57			'length' => 2000,
58			]);
59			$table->addColumn('client_identifier', 'string', [
60			'notnull' => true,
61			'length' => 64,
62			]);
63			$table->addColumn('secret', 'string', [
64			'notnull' => true,
65			'length' => 64,
66			]);
67			$table->setPrimaryKey(['id']);
68			$table->addIndex(['client_identifier'], 'oauth2_client_id_idx');
69			}
70
71			if (!$schema->hasTable('oauth2_access_tokens')) {
72			$table = $schema->createTable('oauth2_access_tokens');
73			$table->addColumn('id', 'integer', [
74			'autoincrement' => true,
75			'notnull' => true,
76			'unsigned' => true,
77			]);
78			$table->addColumn('token_id', 'integer', [
79			'notnull' => true,
80			]);
81			$table->addColumn('client_id', 'integer', [
82			'notnull' => true,
83			]);
84			$table->addColumn('hashed_code', 'string', [
85			'notnull' => true,
86			'length' => 128,
87			]);
88			$table->addColumn('encrypted_token', 'string', [
89			'notnull' => true,
90			'length' => 786,
91			]);
92			$table->setPrimaryKey(['id']);
93			$table->addUniqueIndex(['hashed_code'], 'oauth2_access_hash_idx');
94			$table->addIndex(['client_id'], 'oauth2_access_client_id_idx');
95			}
96			return $schema;
97			}
98			}
99

nextcloud / server

Push — master ( 5a9fc0...866c42 )

Version010401Date20181207190718::changeSchema() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like