nextcloud / server

lib/private/IntegrityCheck/Helpers/AppLocator.php

Indentation +22 added lines, -22 removed lines

@@ -34,27 +34,27 @@
  * @package OC\IntegrityCheck\Helpers
  */
 class AppLocator {
-	/**
-	 * Provides \OC_App::getAppPath($appId)
-	 *
-	 * @param string $appId
-	 * @return string
-	 * @throws \Exception If the app cannot be found
-	 */
-	public function getAppPath(string $appId): string {
-		$path = \OC_App::getAppPath($appId);
-		if ($path === false) {
-			throw new \Exception('App not found');
-		}
-		return $path;
-	}
+    /**
+     * Provides \OC_App::getAppPath($appId)
+     *
+     * @param string $appId
+     * @return string
+     * @throws \Exception If the app cannot be found
+     */
+    public function getAppPath(string $appId): string {
+        $path = \OC_App::getAppPath($appId);
+        if ($path === false) {
+            throw new \Exception('App not found');
+        }
+        return $path;
+    }
 
-	/**
-	 * Providers \OC_App::getAllApps()
-	 *
-	 * @return array
-	 */
-	public function getAllApps(): array {
-		return \OC_App::getAllApps();
-	}
+    /**
+     * Providers \OC_App::getAllApps()
+     *
+     * @return array
+     */
+    public function getAllApps(): array {
+        return \OC_App::getAllApps();
+    }
 }

lib/private/Encryption/DecryptAll.php

Spacing +8 added lines, -8 removed lines

@@ -87,7 +87,7 @@ 
 		$this->output = $output;
 
 		if ($user !== '' && $this->userManager->userExists($user) === false) {
-			$this->output->writeln('User "' . $user . '" does not exist. Please check the username and try again');
+			$this->output->writeln('User "'.$user.'" does not exist. Please check the username and try again');
 			return false;
 		}
 
@@ -105,9 +105,9 @@ 
 			$this->output->writeln('Files for following users couldn\'t be decrypted, ');
 			$this->output->writeln('maybe the user is not set up in a way that supports this operation: ');
 			foreach ($this->failed as $uid => $paths) {
-				$this->output->writeln('    ' . $uid);
+				$this->output->writeln('    '.$uid);
 				foreach ($paths as $path) {
-					$this->output->writeln('        ' . $path);
+					$this->output->writeln('        '.$path);
 				}
 			}
 			$this->output->writeln('');
@@ -129,10 +129,10 @@ 
 			/** @var IEncryptionModule $module */
 			$module = call_user_func($moduleDesc['callback']);
 			$this->output->writeln('');
-			$this->output->writeln('Prepare "' . $module->getDisplayName() . '"');
+			$this->output->writeln('Prepare "'.$module->getDisplayName().'"');
 			$this->output->writeln('');
 			if ($module->prepareDecryptAll($this->input, $this->output, $user) === false) {
-				$this->output->writeln('Module "' . $moduleDesc['displayName'] . '" does not support the functionality to decrypt all files again or the initialization of the module failed!');
+				$this->output->writeln('Module "'.$moduleDesc['displayName'].'" does not support the functionality to decrypt all files again or the initialization of the module failed!');
 				return false;
 			}
 		}
@@ -206,7 +206,7 @@ 
 	protected function decryptUsersFiles($uid, ProgressBar $progress, $userCount) {
 		$this->setupUserFS($uid);
 		$directories = [];
-		$directories[] = '/' . $uid . '/files';
+		$directories[] = '/'.$uid.'/files';
 
 		while ($root = array_pop($directories)) {
 			$content = $this->rootView->getDirectoryContent($root);
@@ -215,7 +215,7 @@ 
 				if ($file->getStorage()->instanceOfStorage('OCA\Files_Sharing\SharedStorage')) {
 					continue;
 				}
-				$path = $root . '/' . $file['name'];
+				$path = $root.'/'.$file['name'];
 				if ($this->rootView->is_dir($path)) {
 					$directories[] = $path;
 					continue;
@@ -259,7 +259,7 @@ 
 		}
 
 		$source = $path;
-		$target = $path . '.decrypted.' . $this->getTimestamp();
+		$target = $path.'.decrypted.'.$this->getTimestamp();
 
 		try {
 			$this->rootView->copy($source, $target);

Indentation +254 added lines, -254 removed lines

@@ -37,258 +37,258 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class DecryptAll {
-	/** @var  OutputInterface */
-	protected $output;
-
-	/** @var  InputInterface */
-	protected $input;
-
-	/** @var  Manager */
-	protected $encryptionManager;
-
-	/** @var IUserManager */
-	protected $userManager;
-
-	/** @var View */
-	protected $rootView;
-
-	/** @var  array files which couldn't be decrypted */
-	protected $failed;
-
-	/**
-	 * @param Manager $encryptionManager
-	 * @param IUserManager $userManager
-	 * @param View $rootView
-	 */
-	public function __construct(
-		Manager $encryptionManager,
-		IUserManager $userManager,
-		View $rootView
-	) {
-		$this->encryptionManager = $encryptionManager;
-		$this->userManager = $userManager;
-		$this->rootView = $rootView;
-		$this->failed = [];
-	}
-
-	/**
-	 * start to decrypt all files
-	 *
-	 * @param InputInterface $input
-	 * @param OutputInterface $output
-	 * @param string $user which users data folder should be decrypted, default = all users
-	 * @return bool
-	 * @throws \Exception
-	 */
-	public function decryptAll(InputInterface $input, OutputInterface $output, $user = '') {
-		$this->input = $input;
-		$this->output = $output;
-
-		if ($user !== '' && $this->userManager->userExists($user) === false) {
-			$this->output->writeln('User "' . $user . '" does not exist. Please check the username and try again');
-			return false;
-		}
-
-		$this->output->writeln('prepare encryption modules...');
-		if ($this->prepareEncryptionModules($user) === false) {
-			return false;
-		}
-		$this->output->writeln(' done.');
-
-		$this->decryptAllUsersFiles($user);
-
-		if (empty($this->failed)) {
-			$this->output->writeln('all files could be decrypted successfully!');
-		} else {
-			$this->output->writeln('Files for following users couldn\'t be decrypted, ');
-			$this->output->writeln('maybe the user is not set up in a way that supports this operation: ');
-			foreach ($this->failed as $uid => $paths) {
-				$this->output->writeln('    ' . $uid);
-				foreach ($paths as $path) {
-					$this->output->writeln('        ' . $path);
-				}
-			}
-			$this->output->writeln('');
-		}
-
-		return true;
-	}
-
-	/**
-	 * prepare encryption modules to perform the decrypt all function
-	 *
-	 * @param $user
-	 * @return bool
-	 */
-	protected function prepareEncryptionModules($user) {
-		// prepare all encryption modules for decrypt all
-		$encryptionModules = $this->encryptionManager->getEncryptionModules();
-		foreach ($encryptionModules as $moduleDesc) {
-			/** @var IEncryptionModule $module */
-			$module = call_user_func($moduleDesc['callback']);
-			$this->output->writeln('');
-			$this->output->writeln('Prepare "' . $module->getDisplayName() . '"');
-			$this->output->writeln('');
-			if ($module->prepareDecryptAll($this->input, $this->output, $user) === false) {
-				$this->output->writeln('Module "' . $moduleDesc['displayName'] . '" does not support the functionality to decrypt all files again or the initialization of the module failed!');
-				return false;
-			}
-		}
-
-		return true;
-	}
-
-	/**
-	 * iterate over all user and encrypt their files
-	 *
-	 * @param string $user which users files should be decrypted, default = all users
-	 */
-	protected function decryptAllUsersFiles($user = '') {
-		$this->output->writeln("\n");
-
-		$userList = [];
-		if ($user === '') {
-			$fetchUsersProgress = new ProgressBar($this->output);
-			$fetchUsersProgress->setFormat(" %message% \n [%bar%]");
-			$fetchUsersProgress->start();
-			$fetchUsersProgress->setMessage("Fetch list of users...");
-			$fetchUsersProgress->advance();
-
-			foreach ($this->userManager->getBackends() as $backend) {
-				$limit = 500;
-				$offset = 0;
-				do {
-					$users = $backend->getUsers('', $limit, $offset);
-					foreach ($users as $user) {
-						$userList[] = $user;
-					}
-					$offset += $limit;
-					$fetchUsersProgress->advance();
-				} while (count($users) >= $limit);
-				$fetchUsersProgress->setMessage("Fetch list of users... finished");
-				$fetchUsersProgress->finish();
-			}
-		} else {
-			$userList[] = $user;
-		}
-
-		$this->output->writeln("\n\n");
-
-		$progress = new ProgressBar($this->output);
-		$progress->setFormat(" %message% \n [%bar%]");
-		$progress->start();
-		$progress->setMessage("starting to decrypt files...");
-		$progress->advance();
-
-		$numberOfUsers = count($userList);
-		$userNo = 1;
-		foreach ($userList as $uid) {
-			$userCount = "$uid ($userNo of $numberOfUsers)";
-			$this->decryptUsersFiles($uid, $progress, $userCount);
-			$userNo++;
-		}
-
-		$progress->setMessage("starting to decrypt files... finished");
-		$progress->finish();
-
-		$this->output->writeln("\n\n");
-	}
-
-	/**
-	 * encrypt files from the given user
-	 *
-	 * @param string $uid
-	 * @param ProgressBar $progress
-	 * @param string $userCount
-	 */
-	protected function decryptUsersFiles($uid, ProgressBar $progress, $userCount) {
-		$this->setupUserFS($uid);
-		$directories = [];
-		$directories[] = '/' . $uid . '/files';
-
-		while ($root = array_pop($directories)) {
-			$content = $this->rootView->getDirectoryContent($root);
-			foreach ($content as $file) {
-				// only decrypt files owned by the user
-				if ($file->getStorage()->instanceOfStorage('OCA\Files_Sharing\SharedStorage')) {
-					continue;
-				}
-				$path = $root . '/' . $file['name'];
-				if ($this->rootView->is_dir($path)) {
-					$directories[] = $path;
-					continue;
-				} else {
-					try {
-						$progress->setMessage("decrypt files for user $userCount: $path");
-						$progress->advance();
-						if ($file->isEncrypted() === false) {
-							$progress->setMessage("decrypt files for user $userCount: $path (already decrypted)");
-							$progress->advance();
-						} else {
-							if ($this->decryptFile($path) === false) {
-								$progress->setMessage("decrypt files for user $userCount: $path (already decrypted)");
-								$progress->advance();
-							}
-						}
-					} catch (\Exception $e) {
-						if (isset($this->failed[$uid])) {
-							$this->failed[$uid][] = $path;
-						} else {
-							$this->failed[$uid] = [$path];
-						}
-					}
-				}
-			}
-		}
-	}
-
-	/**
-	 * encrypt file
-	 *
-	 * @param string $path
-	 * @return bool
-	 */
-	protected function decryptFile($path) {
-		// skip already decrypted files
-		$fileInfo = $this->rootView->getFileInfo($path);
-		if ($fileInfo !== false && !$fileInfo->isEncrypted()) {
-			return true;
-		}
-
-		$source = $path;
-		$target = $path . '.decrypted.' . $this->getTimestamp();
-
-		try {
-			$this->rootView->copy($source, $target);
-			$this->rootView->touch($target, $fileInfo->getMTime());
-			$this->rootView->rename($target, $source);
-		} catch (DecryptionFailedException $e) {
-			if ($this->rootView->file_exists($target)) {
-				$this->rootView->unlink($target);
-			}
-			return false;
-		}
-
-		return true;
-	}
-
-	/**
-	 * get current timestamp
-	 *
-	 * @return int
-	 */
-	protected function getTimestamp() {
-		return time();
-	}
-
-
-	/**
-	 * setup user file system
-	 *
-	 * @param string $uid
-	 */
-	protected function setupUserFS($uid) {
-		\OC_Util::tearDownFS();
-		\OC_Util::setupFS($uid);
-	}
+    /** @var  OutputInterface */
+    protected $output;
+
+    /** @var  InputInterface */
+    protected $input;
+
+    /** @var  Manager */
+    protected $encryptionManager;
+
+    /** @var IUserManager */
+    protected $userManager;
+
+    /** @var View */
+    protected $rootView;
+
+    /** @var  array files which couldn't be decrypted */
+    protected $failed;
+
+    /**
+     * @param Manager $encryptionManager
+     * @param IUserManager $userManager
+     * @param View $rootView
+     */
+    public function __construct(
+        Manager $encryptionManager,
+        IUserManager $userManager,
+        View $rootView
+    ) {
+        $this->encryptionManager = $encryptionManager;
+        $this->userManager = $userManager;
+        $this->rootView = $rootView;
+        $this->failed = [];
+    }
+
+    /**
+     * start to decrypt all files
+     *
+     * @param InputInterface $input
+     * @param OutputInterface $output
+     * @param string $user which users data folder should be decrypted, default = all users
+     * @return bool
+     * @throws \Exception
+     */
+    public function decryptAll(InputInterface $input, OutputInterface $output, $user = '') {
+        $this->input = $input;
+        $this->output = $output;
+
+        if ($user !== '' && $this->userManager->userExists($user) === false) {
+            $this->output->writeln('User "' . $user . '" does not exist. Please check the username and try again');
+            return false;
+        }
+
+        $this->output->writeln('prepare encryption modules...');
+        if ($this->prepareEncryptionModules($user) === false) {
+            return false;
+        }
+        $this->output->writeln(' done.');
+
+        $this->decryptAllUsersFiles($user);
+
+        if (empty($this->failed)) {
+            $this->output->writeln('all files could be decrypted successfully!');
+        } else {
+            $this->output->writeln('Files for following users couldn\'t be decrypted, ');
+            $this->output->writeln('maybe the user is not set up in a way that supports this operation: ');
+            foreach ($this->failed as $uid => $paths) {
+                $this->output->writeln('    ' . $uid);
+                foreach ($paths as $path) {
+                    $this->output->writeln('        ' . $path);
+                }
+            }
+            $this->output->writeln('');
+        }
+
+        return true;
+    }
+
+    /**
+     * prepare encryption modules to perform the decrypt all function
+     *
+     * @param $user
+     * @return bool
+     */
+    protected function prepareEncryptionModules($user) {
+        // prepare all encryption modules for decrypt all
+        $encryptionModules = $this->encryptionManager->getEncryptionModules();
+        foreach ($encryptionModules as $moduleDesc) {
+            /** @var IEncryptionModule $module */
+            $module = call_user_func($moduleDesc['callback']);
+            $this->output->writeln('');
+            $this->output->writeln('Prepare "' . $module->getDisplayName() . '"');
+            $this->output->writeln('');
+            if ($module->prepareDecryptAll($this->input, $this->output, $user) === false) {
+                $this->output->writeln('Module "' . $moduleDesc['displayName'] . '" does not support the functionality to decrypt all files again or the initialization of the module failed!');
+                return false;
+            }
+        }
+
+        return true;
+    }
+
+    /**
+     * iterate over all user and encrypt their files
+     *
+     * @param string $user which users files should be decrypted, default = all users
+     */
+    protected function decryptAllUsersFiles($user = '') {
+        $this->output->writeln("\n");
+
+        $userList = [];
+        if ($user === '') {
+            $fetchUsersProgress = new ProgressBar($this->output);
+            $fetchUsersProgress->setFormat(" %message% \n [%bar%]");
+            $fetchUsersProgress->start();
+            $fetchUsersProgress->setMessage("Fetch list of users...");
+            $fetchUsersProgress->advance();
+
+            foreach ($this->userManager->getBackends() as $backend) {
+                $limit = 500;
+                $offset = 0;
+                do {
+                    $users = $backend->getUsers('', $limit, $offset);
+                    foreach ($users as $user) {
+                        $userList[] = $user;
+                    }
+                    $offset += $limit;
+                    $fetchUsersProgress->advance();
+                } while (count($users) >= $limit);
+                $fetchUsersProgress->setMessage("Fetch list of users... finished");
+                $fetchUsersProgress->finish();
+            }
+        } else {
+            $userList[] = $user;
+        }
+
+        $this->output->writeln("\n\n");
+
+        $progress = new ProgressBar($this->output);
+        $progress->setFormat(" %message% \n [%bar%]");
+        $progress->start();
+        $progress->setMessage("starting to decrypt files...");
+        $progress->advance();
+
+        $numberOfUsers = count($userList);
+        $userNo = 1;
+        foreach ($userList as $uid) {
+            $userCount = "$uid ($userNo of $numberOfUsers)";
+            $this->decryptUsersFiles($uid, $progress, $userCount);
+            $userNo++;
+        }
+
+        $progress->setMessage("starting to decrypt files... finished");
+        $progress->finish();
+
+        $this->output->writeln("\n\n");
+    }
+
+    /**
+     * encrypt files from the given user
+     *
+     * @param string $uid
+     * @param ProgressBar $progress
+     * @param string $userCount
+     */
+    protected function decryptUsersFiles($uid, ProgressBar $progress, $userCount) {
+        $this->setupUserFS($uid);
+        $directories = [];
+        $directories[] = '/' . $uid . '/files';
+
+        while ($root = array_pop($directories)) {
+            $content = $this->rootView->getDirectoryContent($root);
+            foreach ($content as $file) {
+                // only decrypt files owned by the user
+                if ($file->getStorage()->instanceOfStorage('OCA\Files_Sharing\SharedStorage')) {
+                    continue;
+                }
+                $path = $root . '/' . $file['name'];
+                if ($this->rootView->is_dir($path)) {
+                    $directories[] = $path;
+                    continue;
+                } else {
+                    try {
+                        $progress->setMessage("decrypt files for user $userCount: $path");
+                        $progress->advance();
+                        if ($file->isEncrypted() === false) {
+                            $progress->setMessage("decrypt files for user $userCount: $path (already decrypted)");
+                            $progress->advance();
+                        } else {
+                            if ($this->decryptFile($path) === false) {
+                                $progress->setMessage("decrypt files for user $userCount: $path (already decrypted)");
+                                $progress->advance();
+                            }
+                        }
+                    } catch (\Exception $e) {
+                        if (isset($this->failed[$uid])) {
+                            $this->failed[$uid][] = $path;
+                        } else {
+                            $this->failed[$uid] = [$path];
+                        }
+                    }
+                }
+            }
+        }
+    }
+
+    /**
+     * encrypt file
+     *
+     * @param string $path
+     * @return bool
+     */
+    protected function decryptFile($path) {
+        // skip already decrypted files
+        $fileInfo = $this->rootView->getFileInfo($path);
+        if ($fileInfo !== false && !$fileInfo->isEncrypted()) {
+            return true;
+        }
+
+        $source = $path;
+        $target = $path . '.decrypted.' . $this->getTimestamp();
+
+        try {
+            $this->rootView->copy($source, $target);
+            $this->rootView->touch($target, $fileInfo->getMTime());
+            $this->rootView->rename($target, $source);
+        } catch (DecryptionFailedException $e) {
+            if ($this->rootView->file_exists($target)) {
+                $this->rootView->unlink($target);
+            }
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * get current timestamp
+     *
+     * @return int
+     */
+    protected function getTimestamp() {
+        return time();
+    }
+
+
+    /**
+     * setup user file system
+     *
+     * @param string $uid
+     */
+    protected function setupUserFS($uid) {
+        \OC_Util::tearDownFS();
+        \OC_Util::setupFS($uid);
+    }
 }

lib/private/Federation/CloudFederationNotification.php

Indentation +29 added lines, -29 removed lines

@@ -33,35 +33,35 @@
  * @since 14.0.0
  */
 class CloudFederationNotification implements ICloudFederationNotification {
-	private $message = [];
+    private $message = [];
 
-	/**
-	 * add a message to the notification
-	 *
-	 * @param string $notificationType (e.g. SHARE_ACCEPTED)
-	 * @param string $resourceType (e.g. file, calendar, contact,...)
-	 * @param string $providerId id of the share
-	 * @param array $notification payload of the notification
-	 *
-	 * @since 14.0.0
-	 */
-	public function setMessage($notificationType, $resourceType, $providerId, array $notification) {
-		$this->message = [
-			'notificationType' => $notificationType,
-			'resourceType' => $resourceType,
-			'providerId' => $providerId,
-			'notification' => $notification,
-		];
-	}
+    /**
+     * add a message to the notification
+     *
+     * @param string $notificationType (e.g. SHARE_ACCEPTED)
+     * @param string $resourceType (e.g. file, calendar, contact,...)
+     * @param string $providerId id of the share
+     * @param array $notification payload of the notification
+     *
+     * @since 14.0.0
+     */
+    public function setMessage($notificationType, $resourceType, $providerId, array $notification) {
+        $this->message = [
+            'notificationType' => $notificationType,
+            'resourceType' => $resourceType,
+            'providerId' => $providerId,
+            'notification' => $notification,
+        ];
+    }
 
-	/**
-	 * get message, ready to send out
-	 *
-	 * @return array
-	 *
-	 * @since 14.0.0
-	 */
-	public function getMessage() {
-		return $this->message;
-	}
+    /**
+     * get message, ready to send out
+     *
+     * @return array
+     *
+     * @since 14.0.0
+     */
+    public function getMessage() {
+        return $this->message;
+    }
 }

lib/private/Log/Rotate.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
 
 	public function run($dummy) {
 		$systemConfig = \OC::$server->getSystemConfig();
-		$this->filePath = $systemConfig->getValue('logfile', $systemConfig->getValue('datadirectory', \OC::$SERVERROOT . '/data') . '/nextcloud.log');
+		$this->filePath = $systemConfig->getValue('logfile', $systemConfig->getValue('datadirectory', \OC::$SERVERROOT.'/data').'/nextcloud.log');
 
 		$this->maxSize = \OC::$server->getConfig()->getSystemValue('log_rotate_size', 100 * 1024 * 1024);
 		if ($this->shouldRotateBySize()) {

Indentation +11 added lines, -11 removed lines

@@ -33,17 +33,17 @@
  * location and manage that with your own tools.
  */
 class Rotate extends \OCP\BackgroundJob\Job {
-	use RotationTrait;
+    use RotationTrait;
 
-	public function run($dummy) {
-		$systemConfig = \OC::$server->getSystemConfig();
-		$this->filePath = $systemConfig->getValue('logfile', $systemConfig->getValue('datadirectory', \OC::$SERVERROOT . '/data') . '/nextcloud.log');
+    public function run($dummy) {
+        $systemConfig = \OC::$server->getSystemConfig();
+        $this->filePath = $systemConfig->getValue('logfile', $systemConfig->getValue('datadirectory', \OC::$SERVERROOT . '/data') . '/nextcloud.log');
 
-		$this->maxSize = \OC::$server->getConfig()->getSystemValue('log_rotate_size', 100 * 1024 * 1024);
-		if ($this->shouldRotateBySize()) {
-			$rotatedFile = $this->rotate();
-			$msg = 'Log file "'.$this->filePath.'" was over '.$this->maxSize.' bytes, moved to "'.$rotatedFile.'"';
-			\OC::$server->getLogger()->warning($msg, ['app' => Rotate::class]);
-		}
-	}
+        $this->maxSize = \OC::$server->getConfig()->getSystemValue('log_rotate_size', 100 * 1024 * 1024);
+        if ($this->shouldRotateBySize()) {
+            $rotatedFile = $this->rotate();
+            $msg = 'Log file "'.$this->filePath.'" was over '.$this->maxSize.' bytes, moved to "'.$rotatedFile.'"';
+            \OC::$server->getLogger()->warning($msg, ['app' => Rotate::class]);
+        }
+    }
 }

lib/private/Security/FeaturePolicy/FeaturePolicy.php

Indentation +36 added lines, -36 removed lines

@@ -27,51 +27,51 @@
 namespace OC\Security\FeaturePolicy;
 
 class FeaturePolicy extends \OCP\AppFramework\Http\FeaturePolicy {
-	public function getAutoplayDomains(): array {
-		return $this->autoplayDomains;
-	}
+    public function getAutoplayDomains(): array {
+        return $this->autoplayDomains;
+    }
 
-	public function setAutoplayDomains(array $autoplayDomains): void {
-		$this->autoplayDomains = $autoplayDomains;
-	}
+    public function setAutoplayDomains(array $autoplayDomains): void {
+        $this->autoplayDomains = $autoplayDomains;
+    }
 
-	public function getCameraDomains(): array {
-		return $this->cameraDomains;
-	}
+    public function getCameraDomains(): array {
+        return $this->cameraDomains;
+    }
 
-	public function setCameraDomains(array $cameraDomains): void {
-		$this->cameraDomains = $cameraDomains;
-	}
+    public function setCameraDomains(array $cameraDomains): void {
+        $this->cameraDomains = $cameraDomains;
+    }
 
-	public function getFullscreenDomains(): array {
-		return $this->fullscreenDomains;
-	}
+    public function getFullscreenDomains(): array {
+        return $this->fullscreenDomains;
+    }
 
-	public function setFullscreenDomains(array $fullscreenDomains): void {
-		$this->fullscreenDomains = $fullscreenDomains;
-	}
+    public function setFullscreenDomains(array $fullscreenDomains): void {
+        $this->fullscreenDomains = $fullscreenDomains;
+    }
 
-	public function getGeolocationDomains(): array {
-		return $this->geolocationDomains;
-	}
+    public function getGeolocationDomains(): array {
+        return $this->geolocationDomains;
+    }
 
-	public function setGeolocationDomains(array $geolocationDomains): void {
-		$this->geolocationDomains = $geolocationDomains;
-	}
+    public function setGeolocationDomains(array $geolocationDomains): void {
+        $this->geolocationDomains = $geolocationDomains;
+    }
 
-	public function getMicrophoneDomains(): array {
-		return $this->microphoneDomains;
-	}
+    public function getMicrophoneDomains(): array {
+        return $this->microphoneDomains;
+    }
 
-	public function setMicrophoneDomains(array $microphoneDomains): void {
-		$this->microphoneDomains = $microphoneDomains;
-	}
+    public function setMicrophoneDomains(array $microphoneDomains): void {
+        $this->microphoneDomains = $microphoneDomains;
+    }
 
-	public function getPaymentDomains(): array {
-		return $this->paymentDomains;
-	}
+    public function getPaymentDomains(): array {
+        return $this->paymentDomains;
+    }
 
-	public function setPaymentDomains(array $paymentDomains): void {
-		$this->paymentDomains = $paymentDomains;
-	}
+    public function setPaymentDomains(array $paymentDomains): void {
+        $this->paymentDomains = $paymentDomains;
+    }
 }

lib/private/Security/IdentityProof/Manager.php

Spacing +3 added lines, -3 removed lines

@@ -144,7 +144,7 @@ 
 	 */
 	public function getKey(IUser $user): Key {
 		$uid = $user->getUID();
-		return $this->retrieveKey('user-' . $uid);
+		return $this->retrieveKey('user-'.$uid);
 	}
 
 	/**
@@ -158,7 +158,7 @@ 
 		if ($instanceId === null) {
 			throw new \RuntimeException('no instance id!');
 		}
-		return $this->retrieveKey('system-' . $instanceId);
+		return $this->retrieveKey('system-'.$instanceId);
 	}
 
 	private function logOpensslError(): void {
@@ -166,6 +166,6 @@ 
 		while ($error = openssl_error_string()) {
 			$errors[] = $error;
 		}
-		$this->logger->critical('Something is wrong with your openssl setup: ' . implode(', ', $errors));
+		$this->logger->critical('Something is wrong with your openssl setup: '.implode(', ', $errors));
 	}
 }

Indentation +130 added lines, -130 removed lines

@@ -37,134 +37,134 @@
 use Psr\Log\LoggerInterface;
 
 class Manager {
-	/** @var IAppData */
-	private $appData;
-	/** @var ICrypto */
-	private $crypto;
-	/** @var IConfig */
-	private $config;
-	private LoggerInterface $logger;
-
-	public function __construct(Factory $appDataFactory,
-								ICrypto $crypto,
-								IConfig $config,
-								LoggerInterface $logger
-	) {
-		$this->appData = $appDataFactory->get('identityproof');
-		$this->crypto = $crypto;
-		$this->config = $config;
-		$this->logger = $logger;
-	}
-
-	/**
-	 * Calls the openssl functions to generate a public and private key.
-	 * In a separate function for unit testing purposes.
-	 *
-	 * @return array [$publicKey, $privateKey]
-	 * @throws \RuntimeException
-	 */
-	protected function generateKeyPair(): array {
-		$config = [
-			'digest_alg' => 'sha512',
-			'private_key_bits' => 2048,
-		];
-
-		// Generate new key
-		$res = openssl_pkey_new($config);
-
-		if ($res === false) {
-			$this->logOpensslError();
-			throw new \RuntimeException('OpenSSL reported a problem');
-		}
-
-		if (openssl_pkey_export($res, $privateKey, null, $config) === false) {
-			$this->logOpensslError();
-			throw new \RuntimeException('OpenSSL reported a problem');
-		}
-
-		// Extract the public key from $res to $pubKey
-		$publicKey = openssl_pkey_get_details($res);
-		$publicKey = $publicKey['key'];
-
-		return [$publicKey, $privateKey];
-	}
-
-	/**
-	 * Generate a key for a given ID
-	 * Note: If a key already exists it will be overwritten
-	 *
-	 * @param string $id key id
-	 * @return Key
-	 * @throws \RuntimeException
-	 */
-	protected function generateKey(string $id): Key {
-		[$publicKey, $privateKey] = $this->generateKeyPair();
-
-		// Write the private and public key to the disk
-		try {
-			$this->appData->newFolder($id);
-		} catch (\Exception $e) {
-		}
-		$folder = $this->appData->getFolder($id);
-		$folder->newFile('private')
-			->putContent($this->crypto->encrypt($privateKey));
-		$folder->newFile('public')
-			->putContent($publicKey);
-
-		return new Key($publicKey, $privateKey);
-	}
-
-	/**
-	 * Get key for a specific id
-	 *
-	 * @param string $id
-	 * @return Key
-	 * @throws \RuntimeException
-	 */
-	protected function retrieveKey(string $id): Key {
-		try {
-			$folder = $this->appData->getFolder($id);
-			$privateKey = $this->crypto->decrypt(
-				$folder->getFile('private')->getContent()
-			);
-			$publicKey = $folder->getFile('public')->getContent();
-			return new Key($publicKey, $privateKey);
-		} catch (\Exception $e) {
-			return $this->generateKey($id);
-		}
-	}
-
-	/**
-	 * Get public and private key for $user
-	 *
-	 * @param IUser $user
-	 * @return Key
-	 * @throws \RuntimeException
-	 */
-	public function getKey(IUser $user): Key {
-		$uid = $user->getUID();
-		return $this->retrieveKey('user-' . $uid);
-	}
-
-	/**
-	 * Get instance wide public and private key
-	 *
-	 * @return Key
-	 * @throws \RuntimeException
-	 */
-	public function getSystemKey(): Key {
-		$instanceId = $this->config->getSystemValue('instanceid', null);
-		if ($instanceId === null) {
-			throw new \RuntimeException('no instance id!');
-		}
-		return $this->retrieveKey('system-' . $instanceId);
-	}
-
-	private function logOpensslError(): void {
-		$errors = [];
-		while ($error = openssl_error_string()) {
-			$errors[] = $error;
-		}
-		$this->logger->critical('Something is wrong with your openssl setup: ' . implode(', ', $errors));
-	}
+    /** @var IAppData */
+    private $appData;
+    /** @var ICrypto */
+    private $crypto;
+    /** @var IConfig */
+    private $config;
+    private LoggerInterface $logger;
+
+    public function __construct(Factory $appDataFactory,
+                                ICrypto $crypto,
+                                IConfig $config,
+                                LoggerInterface $logger
+    ) {
+        $this->appData = $appDataFactory->get('identityproof');
+        $this->crypto = $crypto;
+        $this->config = $config;
+        $this->logger = $logger;
+    }
+
+    /**
+     * Calls the openssl functions to generate a public and private key.
+     * In a separate function for unit testing purposes.
+     *
+     * @return array [$publicKey, $privateKey]
+     * @throws \RuntimeException
+     */
+    protected function generateKeyPair(): array {
+        $config = [
+            'digest_alg' => 'sha512',
+            'private_key_bits' => 2048,
+        ];
+
+        // Generate new key
+        $res = openssl_pkey_new($config);
+
+        if ($res === false) {
+            $this->logOpensslError();
+            throw new \RuntimeException('OpenSSL reported a problem');
+        }
+
+        if (openssl_pkey_export($res, $privateKey, null, $config) === false) {
+            $this->logOpensslError();
+            throw new \RuntimeException('OpenSSL reported a problem');
+        }
+
+        // Extract the public key from $res to $pubKey
+        $publicKey = openssl_pkey_get_details($res);
+        $publicKey = $publicKey['key'];
+
+        return [$publicKey, $privateKey];
+    }
+
+    /**
+     * Generate a key for a given ID
+     * Note: If a key already exists it will be overwritten
+     *
+     * @param string $id key id
+     * @return Key
+     * @throws \RuntimeException
+     */
+    protected function generateKey(string $id): Key {
+        [$publicKey, $privateKey] = $this->generateKeyPair();
+
+        // Write the private and public key to the disk
+        try {
+            $this->appData->newFolder($id);
+        } catch (\Exception $e) {
+        }
+        $folder = $this->appData->getFolder($id);
+        $folder->newFile('private')
+            ->putContent($this->crypto->encrypt($privateKey));
+        $folder->newFile('public')
+            ->putContent($publicKey);
+
+        return new Key($publicKey, $privateKey);
+    }
+
+    /**
+     * Get key for a specific id
+     *
+     * @param string $id
+     * @return Key
+     * @throws \RuntimeException
+     */
+    protected function retrieveKey(string $id): Key {
+        try {
+            $folder = $this->appData->getFolder($id);
+            $privateKey = $this->crypto->decrypt(
+                $folder->getFile('private')->getContent()
+            );
+            $publicKey = $folder->getFile('public')->getContent();
+            return new Key($publicKey, $privateKey);
+        } catch (\Exception $e) {
+            return $this->generateKey($id);
+        }
+    }
+
+    /**
+     * Get public and private key for $user
+     *
+     * @param IUser $user
+     * @return Key
+     * @throws \RuntimeException
+     */
+    public function getKey(IUser $user): Key {
+        $uid = $user->getUID();
+        return $this->retrieveKey('user-' . $uid);
+    }
+
+    /**
+     * Get instance wide public and private key
+     *
+     * @return Key
+     * @throws \RuntimeException
+     */
+    public function getSystemKey(): Key {
+        $instanceId = $this->config->getSystemValue('instanceid', null);
+        if ($instanceId === null) {
+            throw new \RuntimeException('no instance id!');
+        }
+        return $this->retrieveKey('system-' . $instanceId);
+    }
+
+    private function logOpensslError(): void {
+        $errors = [];
+        while ($error = openssl_error_string()) {
+            $errors[] = $error;
+        }
+        $this->logger->critical('Something is wrong with your openssl setup: ' . implode(', ', $errors));
+    }
 }

lib/private/Security/CSRF/CsrfToken.php

Indentation +38 added lines, -38 removed lines

@@ -36,46 +36,46 @@
  * @package OC\Security\CSRF
  */
 class CsrfToken {
-	/** @var string */
-	private $value;
-	/** @var string */
-	private $encryptedValue = '';
+    /** @var string */
+    private $value;
+    /** @var string */
+    private $encryptedValue = '';
 
-	/**
-	 * @param string $value Value of the token. Can be encrypted or not encrypted.
-	 */
-	public function __construct(string $value) {
-		$this->value = $value;
-	}
+    /**
+     * @param string $value Value of the token. Can be encrypted or not encrypted.
+     */
+    public function __construct(string $value) {
+        $this->value = $value;
+    }
 
-	/**
-	 * Encrypted value of the token. This is used to mitigate BREACH alike
-	 * vulnerabilities. For display measures do use this functionality.
-	 *
-	 * @return string
-	 */
-	public function getEncryptedValue(): string {
-		if ($this->encryptedValue === '') {
-			$sharedSecret = random_bytes(\strlen($this->value));
-			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret) . ':' . base64_encode($sharedSecret);
-		}
+    /**
+     * Encrypted value of the token. This is used to mitigate BREACH alike
+     * vulnerabilities. For display measures do use this functionality.
+     *
+     * @return string
+     */
+    public function getEncryptedValue(): string {
+        if ($this->encryptedValue === '') {
+            $sharedSecret = random_bytes(\strlen($this->value));
+            $this->encryptedValue = base64_encode($this->value ^ $sharedSecret) . ':' . base64_encode($sharedSecret);
+        }
 
-		return $this->encryptedValue;
-	}
+        return $this->encryptedValue;
+    }
 
-	/**
-	 * The unencrypted value of the token. Used for decrypting an already
-	 * encrypted token.
-	 *
-	 * @return string
-	 */
-	public function getDecryptedValue(): string {
-		$token = explode(':', $this->value);
-		if (\count($token) !== 2) {
-			return '';
-		}
-		$obfuscatedToken = $token[0];
-		$secret = $token[1];
-		return base64_decode($obfuscatedToken) ^ base64_decode($secret);
-	}
+    /**
+     * The unencrypted value of the token. Used for decrypting an already
+     * encrypted token.
+     *
+     * @return string
+     */
+    public function getDecryptedValue(): string {
+        $token = explode(':', $this->value);
+        if (\count($token) !== 2) {
+            return '';
+        }
+        $obfuscatedToken = $token[0];
+        $secret = $token[1];
+        return base64_decode($obfuscatedToken) ^ base64_decode($secret);
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
 	public function getEncryptedValue(): string {
 		if ($this->encryptedValue === '') {
 			$sharedSecret = random_bytes(\strlen($this->value));
-			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret) . ':' . base64_encode($sharedSecret);
+			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret).':'.base64_encode($sharedSecret);
 		}
 
 		return $this->encryptedValue;

lib/private/Security/CSRF/TokenStorage/SessionStorage.php

Indentation +49 added lines, -49 removed lines

@@ -35,59 +35,59 @@
  * @package OC\Security\CSRF\TokenStorage
  */
 class SessionStorage {
-	/** @var ISession */
-	private $session;
+    /** @var ISession */
+    private $session;
 
-	/**
-	 * @param ISession $session
-	 */
-	public function __construct(ISession $session) {
-		$this->session = $session;
-	}
+    /**
+     * @param ISession $session
+     */
+    public function __construct(ISession $session) {
+        $this->session = $session;
+    }
 
-	/**
-	 * @param ISession $session
-	 */
-	public function setSession(ISession $session) {
-		$this->session = $session;
-	}
+    /**
+     * @param ISession $session
+     */
+    public function setSession(ISession $session) {
+        $this->session = $session;
+    }
 
-	/**
-	 * Returns the current token or throws an exception if none is found.
-	 *
-	 * @return string
-	 * @throws \Exception
-	 */
-	public function getToken(): string {
-		$token = $this->session->get('requesttoken');
-		if (empty($token)) {
-			throw new \Exception('Session does not contain a requesttoken');
-		}
+    /**
+     * Returns the current token or throws an exception if none is found.
+     *
+     * @return string
+     * @throws \Exception
+     */
+    public function getToken(): string {
+        $token = $this->session->get('requesttoken');
+        if (empty($token)) {
+            throw new \Exception('Session does not contain a requesttoken');
+        }
 
-		return $token;
-	}
+        return $token;
+    }
 
-	/**
-	 * Set the valid current token to $value.
-	 *
-	 * @param string $value
-	 */
-	public function setToken(string $value) {
-		$this->session->set('requesttoken', $value);
-	}
+    /**
+     * Set the valid current token to $value.
+     *
+     * @param string $value
+     */
+    public function setToken(string $value) {
+        $this->session->set('requesttoken', $value);
+    }
 
-	/**
-	 * Removes the current token.
-	 */
-	public function removeToken() {
-		$this->session->remove('requesttoken');
-	}
-	/**
-	 * Whether the storage has a storage.
-	 *
-	 * @return bool
-	 */
-	public function hasToken(): bool {
-		return $this->session->exists('requesttoken');
-	}
+    /**
+     * Removes the current token.
+     */
+    public function removeToken() {
+        $this->session->remove('requesttoken');
+    }
+    /**
+     * Whether the storage has a storage.
+     *
+     * @return bool
+     */
+    public function hasToken(): bool {
+        return $this->session->exists('requesttoken');
+    }
 }

lib/private/Security/CSRF/CsrfTokenManager.php

Indentation +66 added lines, -66 removed lines

@@ -34,78 +34,78 @@
  * @package OC\Security\CSRF
  */
 class CsrfTokenManager {
-	/** @var CsrfTokenGenerator */
-	private $tokenGenerator;
-	/** @var SessionStorage */
-	private $sessionStorage;
-	/** @var CsrfToken|null */
-	private $csrfToken = null;
+    /** @var CsrfTokenGenerator */
+    private $tokenGenerator;
+    /** @var SessionStorage */
+    private $sessionStorage;
+    /** @var CsrfToken|null */
+    private $csrfToken = null;
 
-	/**
-	 * @param CsrfTokenGenerator $tokenGenerator
-	 * @param SessionStorage $storageInterface
-	 */
-	public function __construct(CsrfTokenGenerator $tokenGenerator,
-								SessionStorage $storageInterface) {
-		$this->tokenGenerator = $tokenGenerator;
-		$this->sessionStorage = $storageInterface;
-	}
+    /**
+     * @param CsrfTokenGenerator $tokenGenerator
+     * @param SessionStorage $storageInterface
+     */
+    public function __construct(CsrfTokenGenerator $tokenGenerator,
+                                SessionStorage $storageInterface) {
+        $this->tokenGenerator = $tokenGenerator;
+        $this->sessionStorage = $storageInterface;
+    }
 
-	/**
-	 * Returns the current CSRF token, if none set it will create a new one.
-	 *
-	 * @return CsrfToken
-	 */
-	public function getToken(): CsrfToken {
-		if (!\is_null($this->csrfToken)) {
-			return $this->csrfToken;
-		}
+    /**
+     * Returns the current CSRF token, if none set it will create a new one.
+     *
+     * @return CsrfToken
+     */
+    public function getToken(): CsrfToken {
+        if (!\is_null($this->csrfToken)) {
+            return $this->csrfToken;
+        }
 
-		if ($this->sessionStorage->hasToken()) {
-			$value = $this->sessionStorage->getToken();
-		} else {
-			$value = $this->tokenGenerator->generateToken();
-			$this->sessionStorage->setToken($value);
-		}
+        if ($this->sessionStorage->hasToken()) {
+            $value = $this->sessionStorage->getToken();
+        } else {
+            $value = $this->tokenGenerator->generateToken();
+            $this->sessionStorage->setToken($value);
+        }
 
-		$this->csrfToken = new CsrfToken($value);
-		return $this->csrfToken;
-	}
+        $this->csrfToken = new CsrfToken($value);
+        return $this->csrfToken;
+    }
 
-	/**
-	 * Invalidates any current token and sets a new one.
-	 *
-	 * @return CsrfToken
-	 */
-	public function refreshToken(): CsrfToken {
-		$value = $this->tokenGenerator->generateToken();
-		$this->sessionStorage->setToken($value);
-		$this->csrfToken = new CsrfToken($value);
-		return $this->csrfToken;
-	}
+    /**
+     * Invalidates any current token and sets a new one.
+     *
+     * @return CsrfToken
+     */
+    public function refreshToken(): CsrfToken {
+        $value = $this->tokenGenerator->generateToken();
+        $this->sessionStorage->setToken($value);
+        $this->csrfToken = new CsrfToken($value);
+        return $this->csrfToken;
+    }
 
-	/**
-	 * Remove the current token from the storage.
-	 */
-	public function removeToken() {
-		$this->csrfToken = null;
-		$this->sessionStorage->removeToken();
-	}
+    /**
+     * Remove the current token from the storage.
+     */
+    public function removeToken() {
+        $this->csrfToken = null;
+        $this->sessionStorage->removeToken();
+    }
 
-	/**
-	 * Verifies whether the provided token is valid.
-	 *
-	 * @param CsrfToken $token
-	 * @return bool
-	 */
-	public function isTokenValid(CsrfToken $token): bool {
-		if (!$this->sessionStorage->hasToken()) {
-			return false;
-		}
+    /**
+     * Verifies whether the provided token is valid.
+     *
+     * @param CsrfToken $token
+     * @return bool
+     */
+    public function isTokenValid(CsrfToken $token): bool {
+        if (!$this->sessionStorage->hasToken()) {
+            return false;
+        }
 
-		return hash_equals(
-			$this->sessionStorage->getToken(),
-			$token->getDecryptedValue()
-		);
-	}
+        return hash_equals(
+            $this->sessionStorage->getToken(),
+            $token->getDecryptedValue()
+        );
+    }
 }