nextcloud / server

tests/lib/Security/CSP/ContentSecurityPolicyNonceManagerTest.php

Indentation +44 added lines, -44 removed lines

@@ -17,55 +17,55 @@
 use Test\TestCase;
 
 class ContentSecurityPolicyNonceManagerTest extends TestCase {
-	/** @var CsrfTokenManager&MockObject */
-	private $CSRFTokenManager;
-	/** @var Request&MockObject */
-	private $request;
-	/** @var ContentSecurityPolicyNonceManager */
-	private $nonceManager;
+    /** @var CsrfTokenManager&MockObject */
+    private $CSRFTokenManager;
+    /** @var Request&MockObject */
+    private $request;
+    /** @var ContentSecurityPolicyNonceManager */
+    private $nonceManager;
 
-	protected function setUp(): void {
-		$this->CSRFTokenManager = $this->createMock(CsrfTokenManager::class);
-		$this->request = $this->createMock(Request::class);
-		$this->nonceManager = new ContentSecurityPolicyNonceManager(
-			$this->CSRFTokenManager,
-			$this->request
-		);
-	}
+    protected function setUp(): void {
+        $this->CSRFTokenManager = $this->createMock(CsrfTokenManager::class);
+        $this->request = $this->createMock(Request::class);
+        $this->nonceManager = new ContentSecurityPolicyNonceManager(
+            $this->CSRFTokenManager,
+            $this->request
+        );
+    }
 
-	public function testGetNonce(): void {
-		$secret = base64_encode('secret');
-		$tokenValue = base64_encode('secret' ^ 'value_') . ':' . $secret;
-		$token = $this->createMock(CsrfToken::class);
-		$token
-			->expects($this->once())
-			->method('getEncryptedValue')
-			->willReturn($tokenValue);
+    public function testGetNonce(): void {
+        $secret = base64_encode('secret');
+        $tokenValue = base64_encode('secret' ^ 'value_') . ':' . $secret;
+        $token = $this->createMock(CsrfToken::class);
+        $token
+            ->expects($this->once())
+            ->method('getEncryptedValue')
+            ->willReturn($tokenValue);
 
-		$this->CSRFTokenManager
-			->expects($this->once())
-			->method('getToken')
-			->willReturn($token);
+        $this->CSRFTokenManager
+            ->expects($this->once())
+            ->method('getToken')
+            ->willReturn($token);
 
-		$this->assertSame($secret, $this->nonceManager->getNonce());
-		// call it twice but `getEncryptedValue` is expected to be called only once
-		$this->assertSame($secret, $this->nonceManager->getNonce());
-	}
+        $this->assertSame($secret, $this->nonceManager->getNonce());
+        // call it twice but `getEncryptedValue` is expected to be called only once
+        $this->assertSame($secret, $this->nonceManager->getNonce());
+    }
 
-	public function testGetNonceServerVar(): void {
-		$token = 'SERVERNONCE';
-		$this->request
-			->method('__isset')
-			->with('server')
-			->willReturn(true);
+    public function testGetNonceServerVar(): void {
+        $token = 'SERVERNONCE';
+        $this->request
+            ->method('__isset')
+            ->with('server')
+            ->willReturn(true);
 
-		$this->request
-			->method('__get')
-			->with('server')
-			->willReturn(['CSP_NONCE' => $token]);
+        $this->request
+            ->method('__get')
+            ->with('server')
+            ->willReturn(['CSP_NONCE' => $token]);
 
-		$this->assertSame($token, $this->nonceManager->getNonce());
-		// call it twice but `CSP_NONCE` variable is expected to be loaded only once
-		$this->assertSame($token, $this->nonceManager->getNonce());
-	}
+        $this->assertSame($token, $this->nonceManager->getNonce());
+        // call it twice but `CSP_NONCE` variable is expected to be loaded only once
+        $this->assertSame($token, $this->nonceManager->getNonce());
+    }
 }

tests/lib/Security/CSP/AddContentSecurityPolicyEventTest.php

Indentation +9 added lines, -9 removed lines

@@ -15,15 +15,15 @@
 use Test\TestCase;
 
 class AddContentSecurityPolicyEventTest extends TestCase {
-	public function testAddEvent(): void {
-		$cspManager = $this->createMock(ContentSecurityPolicyManager::class);
-		$policy = $this->createMock(ContentSecurityPolicy::class);
-		$event = new AddContentSecurityPolicyEvent($cspManager);
+    public function testAddEvent(): void {
+        $cspManager = $this->createMock(ContentSecurityPolicyManager::class);
+        $policy = $this->createMock(ContentSecurityPolicy::class);
+        $event = new AddContentSecurityPolicyEvent($cspManager);
 
-		$cspManager->expects($this->once())
-			->method('addDefaultPolicy')
-			->with($policy);
+        $cspManager->expects($this->once())
+            ->method('addDefaultPolicy')
+            ->with($policy);
 
-		$event->addPolicy($policy);
-	}
+        $event->addPolicy($policy);
+    }
 }

tests/lib/Security/Events/GenerateSecurePasswordEventTest.php

Indentation +16 added lines, -16 removed lines

@@ -14,20 +14,20 @@
 
 class GenerateSecurePasswordEventTest extends \Test\TestCase {
 
-	public function testDefaultProperties(): void {
-		$event = new GenerateSecurePasswordEvent();
-		$this->assertNull($event->getPassword());
-		$this->assertEquals(PasswordContext::ACCOUNT, $event->getContext());
-	}
-
-	public function testSettingPassword(): void {
-		$event = new GenerateSecurePasswordEvent();
-		$event->setPassword('example');
-		$this->assertEquals('example', $event->getPassword());
-	}
-
-	public function testSettingContext(): void {
-		$event = new GenerateSecurePasswordEvent(PasswordContext::SHARING);
-		$this->assertEquals(PasswordContext::SHARING, $event->getContext());
-	}
+    public function testDefaultProperties(): void {
+        $event = new GenerateSecurePasswordEvent();
+        $this->assertNull($event->getPassword());
+        $this->assertEquals(PasswordContext::ACCOUNT, $event->getContext());
+    }
+
+    public function testSettingPassword(): void {
+        $event = new GenerateSecurePasswordEvent();
+        $event->setPassword('example');
+        $this->assertEquals('example', $event->getPassword());
+    }
+
+    public function testSettingContext(): void {
+        $event = new GenerateSecurePasswordEvent(PasswordContext::SHARING);
+        $this->assertEquals(PasswordContext::SHARING, $event->getContext());
+    }
 }

tests/lib/Security/Events/ValidatePasswordPolicyEventTest.php

Indentation +10 added lines, -10 removed lines

@@ -14,15 +14,15 @@
 
 class ValidatePasswordPolicyEventTest extends \Test\TestCase {
 
-	public function testDefaultProperties(): void {
-		$password = 'example';
-		$event = new ValidatePasswordPolicyEvent($password);
-		$this->assertEquals($password, $event->getPassword());
-		$this->assertEquals(PasswordContext::ACCOUNT, $event->getContext());
-	}
+    public function testDefaultProperties(): void {
+        $password = 'example';
+        $event = new ValidatePasswordPolicyEvent($password);
+        $this->assertEquals($password, $event->getPassword());
+        $this->assertEquals(PasswordContext::ACCOUNT, $event->getContext());
+    }
 
-	public function testSettingContext(): void {
-		$event = new ValidatePasswordPolicyEvent('example', PasswordContext::SHARING);
-		$this->assertEquals(PasswordContext::SHARING, $event->getContext());
-	}
+    public function testSettingContext(): void {
+        $event = new ValidatePasswordPolicyEvent('example', PasswordContext::SHARING);
+        $this->assertEquals(PasswordContext::SHARING, $event->getContext());
+    }
 }

tests/lib/Security/VerificationToken/VerificationTokenTest.php

Indentation +271 added lines, -271 removed lines

@@ -21,275 +21,275 @@
 use Test\TestCase;
 
 class VerificationTokenTest extends TestCase {
-	/** @var VerificationToken */
-	protected $token;
-	/** @var IConfig|MockObject */
-	protected $config;
-	/** @var ISecureRandom|MockObject */
-	protected $secureRandom;
-	/** @var ICrypto|MockObject */
-	protected $crypto;
-	/** @var ITimeFactory|MockObject */
-	protected $timeFactory;
-	/** @var IJobList|MockObject */
-	protected $jobList;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->createMock(IConfig::class);
-		$this->crypto = $this->createMock(ICrypto::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->secureRandom = $this->createMock(ISecureRandom::class);
-		$this->jobList = $this->createMock(IJobList::class);
-
-		$this->token = new VerificationToken(
-			$this->config,
-			$this->crypto,
-			$this->timeFactory,
-			$this->secureRandom,
-			$this->jobList
-		);
-	}
-
-	public function testTokenUserUnknown(): void {
-		$this->expectException(InvalidTokenException::class);
-		$this->expectExceptionCode(InvalidTokenException::USER_UNKNOWN);
-		$this->token->check('encryptedToken', null, 'fingerprintToken', 'foobar');
-	}
-
-	public function testTokenUserUnknown2(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->atLeastOnce())
-			->method('isEnabled')
-			->willReturn(false);
-
-		$this->expectException(InvalidTokenException::class);
-		$this->expectExceptionCode(InvalidTokenException::USER_UNKNOWN);
-		$this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
-	}
-
-	public function testTokenNotFound(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->atLeastOnce())
-			->method('isEnabled')
-			->willReturn(true);
-		$user->expects($this->atLeastOnce())
-			->method('getUID')
-			->willReturn('alice');
-
-		// implicit: IConfig::getUserValue returns null by default
-
-		$this->expectException(InvalidTokenException::class);
-		$this->expectExceptionCode(InvalidTokenException::TOKEN_NOT_FOUND);
-		$this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
-	}
-
-	public function testTokenDecryptionError(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->atLeastOnce())
-			->method('isEnabled')
-			->willReturn(true);
-		$user->expects($this->atLeastOnce())
-			->method('getUID')
-			->willReturn('alice');
-
-		$this->config->expects($this->atLeastOnce())
-			->method('getUserValue')
-			->with('alice', 'core', 'fingerprintToken', null)
-			->willReturn('encryptedToken');
-		$this->config->expects($this->any())
-			->method('getSystemValueString')
-			->with('secret')
-			->willReturn('357111317');
-
-		$this->crypto->method('decrypt')
-			->with('encryptedToken', 'foobar' . '357111317')
-			->willThrowException(new \Exception('decryption failed'));
-
-		$this->expectException(InvalidTokenException::class);
-		$this->expectExceptionCode(InvalidTokenException::TOKEN_DECRYPTION_ERROR);
-		$this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
-	}
-
-	public function testTokenInvalidFormat(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->atLeastOnce())
-			->method('isEnabled')
-			->willReturn(true);
-		$user->expects($this->atLeastOnce())
-			->method('getUID')
-			->willReturn('alice');
-
-		$this->config->expects($this->atLeastOnce())
-			->method('getUserValue')
-			->with('alice', 'core', 'fingerprintToken', null)
-			->willReturn('encryptedToken');
-		$this->config->expects($this->any())
-			->method('getSystemValueString')
-			->with('secret')
-			->willReturn('357111317');
-
-		$this->crypto->method('decrypt')
-			->with('encryptedToken', 'foobar' . '357111317')
-			->willReturn('decrypted^nonsense');
-
-		$this->expectException(InvalidTokenException::class);
-		$this->expectExceptionCode(InvalidTokenException::TOKEN_INVALID_FORMAT);
-		$this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
-	}
-
-	public function testTokenExpired(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->atLeastOnce())
-			->method('isEnabled')
-			->willReturn(true);
-		$user->expects($this->atLeastOnce())
-			->method('getUID')
-			->willReturn('alice');
-		$user->expects($this->any())
-			->method('getLastLogin')
-			->willReturn(604803);
-
-		$this->config->expects($this->atLeastOnce())
-			->method('getUserValue')
-			->with('alice', 'core', 'fingerprintToken', null)
-			->willReturn('encryptedToken');
-		$this->config->expects($this->any())
-			->method('getSystemValueString')
-			->with('secret')
-			->willReturn('357111317');
-
-		$this->crypto->method('decrypt')
-			->with('encryptedToken', 'foobar' . '357111317')
-			->willReturn('604800:mY70K3n');
-
-		$this->timeFactory->expects($this->any())
-			->method('getTime')
-			->willReturn(604800 * 3);
-
-		$this->expectException(InvalidTokenException::class);
-		$this->expectExceptionCode(InvalidTokenException::TOKEN_EXPIRED);
-		$this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
-	}
-
-	public function testTokenExpiredByLogin(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->atLeastOnce())
-			->method('isEnabled')
-			->willReturn(true);
-		$user->expects($this->atLeastOnce())
-			->method('getUID')
-			->willReturn('alice');
-		$user->expects($this->any())
-			->method('getLastLogin')
-			->willReturn(604803);
-
-		$this->config->expects($this->atLeastOnce())
-			->method('getUserValue')
-			->with('alice', 'core', 'fingerprintToken', null)
-			->willReturn('encryptedToken');
-		$this->config->expects($this->any())
-			->method('getSystemValueString')
-			->with('secret')
-			->willReturn('357111317');
-
-		$this->crypto->method('decrypt')
-			->with('encryptedToken', 'foobar' . '357111317')
-			->willReturn('604800:mY70K3n');
-
-		$this->timeFactory->expects($this->any())
-			->method('getTime')
-			->willReturn(604801);
-
-		$this->expectException(InvalidTokenException::class);
-		$this->expectExceptionCode(InvalidTokenException::TOKEN_EXPIRED);
-		$this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar', true);
-	}
-
-	public function testTokenMismatch(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->atLeastOnce())
-			->method('isEnabled')
-			->willReturn(true);
-		$user->expects($this->atLeastOnce())
-			->method('getUID')
-			->willReturn('alice');
-		$user->expects($this->any())
-			->method('getLastLogin')
-			->willReturn(604703);
-
-		$this->config->expects($this->atLeastOnce())
-			->method('getUserValue')
-			->with('alice', 'core', 'fingerprintToken', null)
-			->willReturn('encryptedToken');
-		$this->config->expects($this->any())
-			->method('getSystemValueString')
-			->with('secret')
-			->willReturn('357111317');
-
-		$this->crypto->method('decrypt')
-			->with('encryptedToken', 'foobar' . '357111317')
-			->willReturn('604802:mY70K3n');
-
-		$this->timeFactory->expects($this->any())
-			->method('getTime')
-			->willReturn(604801);
-
-		$this->expectException(InvalidTokenException::class);
-		$this->expectExceptionCode(InvalidTokenException::TOKEN_MISMATCH);
-		$this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
-	}
-
-	public function testTokenSuccess(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->atLeastOnce())
-			->method('isEnabled')
-			->willReturn(true);
-		$user->expects($this->atLeastOnce())
-			->method('getUID')
-			->willReturn('alice');
-		$user->expects($this->any())
-			->method('getLastLogin')
-			->willReturn(604703);
-
-		$this->config->expects($this->atLeastOnce())
-			->method('getUserValue')
-			->with('alice', 'core', 'fingerprintToken', null)
-			->willReturn('encryptedToken');
-		$this->config->expects($this->any())
-			->method('getSystemValueString')
-			->with('secret')
-			->willReturn('357111317');
-
-		$this->crypto->method('decrypt')
-			->with('encryptedToken', 'foobar' . '357111317')
-			->willReturn('604802:barfoo');
-
-		$this->timeFactory->expects($this->any())
-			->method('getTime')
-			->willReturn(604801);
-
-		$this->token->check('barfoo', $user, 'fingerprintToken', 'foobar');
-	}
-
-	public function testCreate(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('alice');
-
-		$this->secureRandom->expects($this->atLeastOnce())
-			->method('generate')
-			->willReturn('barfoo');
-		$this->crypto->expects($this->atLeastOnce())
-			->method('encrypt')
-			->willReturn('encryptedToken');
-		$this->config->expects($this->atLeastOnce())
-			->method('setUserValue')
-			->with('alice', 'core', 'fingerprintToken', 'encryptedToken');
-
-		$vToken = $this->token->create($user, 'fingerprintToken', 'foobar');
-		$this->assertSame('barfoo', $vToken);
-	}
+    /** @var VerificationToken */
+    protected $token;
+    /** @var IConfig|MockObject */
+    protected $config;
+    /** @var ISecureRandom|MockObject */
+    protected $secureRandom;
+    /** @var ICrypto|MockObject */
+    protected $crypto;
+    /** @var ITimeFactory|MockObject */
+    protected $timeFactory;
+    /** @var IJobList|MockObject */
+    protected $jobList;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->createMock(IConfig::class);
+        $this->crypto = $this->createMock(ICrypto::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->secureRandom = $this->createMock(ISecureRandom::class);
+        $this->jobList = $this->createMock(IJobList::class);
+
+        $this->token = new VerificationToken(
+            $this->config,
+            $this->crypto,
+            $this->timeFactory,
+            $this->secureRandom,
+            $this->jobList
+        );
+    }
+
+    public function testTokenUserUnknown(): void {
+        $this->expectException(InvalidTokenException::class);
+        $this->expectExceptionCode(InvalidTokenException::USER_UNKNOWN);
+        $this->token->check('encryptedToken', null, 'fingerprintToken', 'foobar');
+    }
+
+    public function testTokenUserUnknown2(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->atLeastOnce())
+            ->method('isEnabled')
+            ->willReturn(false);
+
+        $this->expectException(InvalidTokenException::class);
+        $this->expectExceptionCode(InvalidTokenException::USER_UNKNOWN);
+        $this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
+    }
+
+    public function testTokenNotFound(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->atLeastOnce())
+            ->method('isEnabled')
+            ->willReturn(true);
+        $user->expects($this->atLeastOnce())
+            ->method('getUID')
+            ->willReturn('alice');
+
+        // implicit: IConfig::getUserValue returns null by default
+
+        $this->expectException(InvalidTokenException::class);
+        $this->expectExceptionCode(InvalidTokenException::TOKEN_NOT_FOUND);
+        $this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
+    }
+
+    public function testTokenDecryptionError(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->atLeastOnce())
+            ->method('isEnabled')
+            ->willReturn(true);
+        $user->expects($this->atLeastOnce())
+            ->method('getUID')
+            ->willReturn('alice');
+
+        $this->config->expects($this->atLeastOnce())
+            ->method('getUserValue')
+            ->with('alice', 'core', 'fingerprintToken', null)
+            ->willReturn('encryptedToken');
+        $this->config->expects($this->any())
+            ->method('getSystemValueString')
+            ->with('secret')
+            ->willReturn('357111317');
+
+        $this->crypto->method('decrypt')
+            ->with('encryptedToken', 'foobar' . '357111317')
+            ->willThrowException(new \Exception('decryption failed'));
+
+        $this->expectException(InvalidTokenException::class);
+        $this->expectExceptionCode(InvalidTokenException::TOKEN_DECRYPTION_ERROR);
+        $this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
+    }
+
+    public function testTokenInvalidFormat(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->atLeastOnce())
+            ->method('isEnabled')
+            ->willReturn(true);
+        $user->expects($this->atLeastOnce())
+            ->method('getUID')
+            ->willReturn('alice');
+
+        $this->config->expects($this->atLeastOnce())
+            ->method('getUserValue')
+            ->with('alice', 'core', 'fingerprintToken', null)
+            ->willReturn('encryptedToken');
+        $this->config->expects($this->any())
+            ->method('getSystemValueString')
+            ->with('secret')
+            ->willReturn('357111317');
+
+        $this->crypto->method('decrypt')
+            ->with('encryptedToken', 'foobar' . '357111317')
+            ->willReturn('decrypted^nonsense');
+
+        $this->expectException(InvalidTokenException::class);
+        $this->expectExceptionCode(InvalidTokenException::TOKEN_INVALID_FORMAT);
+        $this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
+    }
+
+    public function testTokenExpired(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->atLeastOnce())
+            ->method('isEnabled')
+            ->willReturn(true);
+        $user->expects($this->atLeastOnce())
+            ->method('getUID')
+            ->willReturn('alice');
+        $user->expects($this->any())
+            ->method('getLastLogin')
+            ->willReturn(604803);
+
+        $this->config->expects($this->atLeastOnce())
+            ->method('getUserValue')
+            ->with('alice', 'core', 'fingerprintToken', null)
+            ->willReturn('encryptedToken');
+        $this->config->expects($this->any())
+            ->method('getSystemValueString')
+            ->with('secret')
+            ->willReturn('357111317');
+
+        $this->crypto->method('decrypt')
+            ->with('encryptedToken', 'foobar' . '357111317')
+            ->willReturn('604800:mY70K3n');
+
+        $this->timeFactory->expects($this->any())
+            ->method('getTime')
+            ->willReturn(604800 * 3);
+
+        $this->expectException(InvalidTokenException::class);
+        $this->expectExceptionCode(InvalidTokenException::TOKEN_EXPIRED);
+        $this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
+    }
+
+    public function testTokenExpiredByLogin(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->atLeastOnce())
+            ->method('isEnabled')
+            ->willReturn(true);
+        $user->expects($this->atLeastOnce())
+            ->method('getUID')
+            ->willReturn('alice');
+        $user->expects($this->any())
+            ->method('getLastLogin')
+            ->willReturn(604803);
+
+        $this->config->expects($this->atLeastOnce())
+            ->method('getUserValue')
+            ->with('alice', 'core', 'fingerprintToken', null)
+            ->willReturn('encryptedToken');
+        $this->config->expects($this->any())
+            ->method('getSystemValueString')
+            ->with('secret')
+            ->willReturn('357111317');
+
+        $this->crypto->method('decrypt')
+            ->with('encryptedToken', 'foobar' . '357111317')
+            ->willReturn('604800:mY70K3n');
+
+        $this->timeFactory->expects($this->any())
+            ->method('getTime')
+            ->willReturn(604801);
+
+        $this->expectException(InvalidTokenException::class);
+        $this->expectExceptionCode(InvalidTokenException::TOKEN_EXPIRED);
+        $this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar', true);
+    }
+
+    public function testTokenMismatch(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->atLeastOnce())
+            ->method('isEnabled')
+            ->willReturn(true);
+        $user->expects($this->atLeastOnce())
+            ->method('getUID')
+            ->willReturn('alice');
+        $user->expects($this->any())
+            ->method('getLastLogin')
+            ->willReturn(604703);
+
+        $this->config->expects($this->atLeastOnce())
+            ->method('getUserValue')
+            ->with('alice', 'core', 'fingerprintToken', null)
+            ->willReturn('encryptedToken');
+        $this->config->expects($this->any())
+            ->method('getSystemValueString')
+            ->with('secret')
+            ->willReturn('357111317');
+
+        $this->crypto->method('decrypt')
+            ->with('encryptedToken', 'foobar' . '357111317')
+            ->willReturn('604802:mY70K3n');
+
+        $this->timeFactory->expects($this->any())
+            ->method('getTime')
+            ->willReturn(604801);
+
+        $this->expectException(InvalidTokenException::class);
+        $this->expectExceptionCode(InvalidTokenException::TOKEN_MISMATCH);
+        $this->token->check('encryptedToken', $user, 'fingerprintToken', 'foobar');
+    }
+
+    public function testTokenSuccess(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->atLeastOnce())
+            ->method('isEnabled')
+            ->willReturn(true);
+        $user->expects($this->atLeastOnce())
+            ->method('getUID')
+            ->willReturn('alice');
+        $user->expects($this->any())
+            ->method('getLastLogin')
+            ->willReturn(604703);
+
+        $this->config->expects($this->atLeastOnce())
+            ->method('getUserValue')
+            ->with('alice', 'core', 'fingerprintToken', null)
+            ->willReturn('encryptedToken');
+        $this->config->expects($this->any())
+            ->method('getSystemValueString')
+            ->with('secret')
+            ->willReturn('357111317');
+
+        $this->crypto->method('decrypt')
+            ->with('encryptedToken', 'foobar' . '357111317')
+            ->willReturn('604802:barfoo');
+
+        $this->timeFactory->expects($this->any())
+            ->method('getTime')
+            ->willReturn(604801);
+
+        $this->token->check('barfoo', $user, 'fingerprintToken', 'foobar');
+    }
+
+    public function testCreate(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('alice');
+
+        $this->secureRandom->expects($this->atLeastOnce())
+            ->method('generate')
+            ->willReturn('barfoo');
+        $this->crypto->expects($this->atLeastOnce())
+            ->method('encrypt')
+            ->willReturn('encryptedToken');
+        $this->config->expects($this->atLeastOnce())
+            ->method('setUserValue')
+            ->with('alice', 'core', 'fingerprintToken', 'encryptedToken');
+
+        $vToken = $this->token->create($user, 'fingerprintToken', 'foobar');
+        $this->assertSame('barfoo', $vToken);
+    }
 }

tests/lib/Security/RateLimiting/Backend/MemoryCacheBackendTest.php

Indentation +123 added lines, -123 removed lines

@@ -17,127 +17,127 @@
 use Test\TestCase;
 
 class MemoryCacheBackendTest extends TestCase {
-	/** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
-	private $config;
-	/** @var ICacheFactory|\PHPUnit\Framework\MockObject\MockObject */
-	private $cacheFactory;
-	/** @var ITimeFactory|\PHPUnit\Framework\MockObject\MockObject */
-	private $timeFactory;
-	/** @var ICache|\PHPUnit\Framework\MockObject\MockObject */
-	private $cache;
-	/** @var MemoryCacheBackend */
-	private $memoryCache;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->createMock(IConfig::class);
-		$this->cacheFactory = $this->createMock(ICacheFactory::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->cache = $this->createMock(ICache::class);
-
-		$this->cacheFactory
-			->expects($this->once())
-			->method('createDistributed')
-			->with('OC\Security\RateLimiting\Backend\MemoryCacheBackend')
-			->willReturn($this->cache);
-
-		$this->config->method('getSystemValueBool')
-			->with('ratelimit.protection.enabled')
-			->willReturn(true);
-
-		$this->memoryCache = new MemoryCacheBackend(
-			$this->config,
-			$this->cacheFactory,
-			$this->timeFactory
-		);
-	}
-
-	public function testGetAttemptsWithNoAttemptsBefore(): void {
-		$this->cache
-			->expects($this->once())
-			->method('get')
-			->with('eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b')
-			->willReturn(null);
-
-		$this->assertSame(0, $this->memoryCache->getAttempts('Method', 'User'));
-	}
-
-	public function testGetAttempts(): void {
-		$this->timeFactory
-			->expects($this->once())
-			->method('getTime')
-			->willReturn(210);
-		$this->cache
-			->expects($this->once())
-			->method('get')
-			->with('eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b')
-			->willReturn(json_encode([
-				'1',
-				'2',
-				'87',
-				'223',
-				'223',
-				'224',
-			]));
-
-		$this->assertSame(3, $this->memoryCache->getAttempts('Method', 'User'));
-	}
-
-	public function testRegisterAttemptWithNoAttemptsBefore(): void {
-		$this->timeFactory
-			->expects($this->once())
-			->method('getTime')
-			->willReturn(123);
-
-		$this->cache
-			->expects($this->once())
-			->method('get')
-			->with('eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b')
-			->willReturn(null);
-		$this->cache
-			->expects($this->once())
-			->method('set')
-			->with(
-				'eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b',
-				json_encode(['223'])
-			);
-
-		$this->memoryCache->registerAttempt('Method', 'User', 100);
-	}
-
-	public function testRegisterAttempt(): void {
-		$this->timeFactory
-			->expects($this->once())
-			->method('getTime')
-			->willReturn(86);
-
-		$this->cache
-			->expects($this->once())
-			->method('get')
-			->with('eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b')
-			->willReturn(json_encode([
-				'1',
-				'2',
-				'87',
-				'123',
-				'123',
-				'124',
-			]));
-		$this->cache
-			->expects($this->once())
-			->method('set')
-			->with(
-				'eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b',
-				json_encode([
-					'87',
-					'123',
-					'123',
-					'124',
-					'186',
-				])
-			);
-
-		$this->memoryCache->registerAttempt('Method', 'User', 100);
-	}
+    /** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
+    private $config;
+    /** @var ICacheFactory|\PHPUnit\Framework\MockObject\MockObject */
+    private $cacheFactory;
+    /** @var ITimeFactory|\PHPUnit\Framework\MockObject\MockObject */
+    private $timeFactory;
+    /** @var ICache|\PHPUnit\Framework\MockObject\MockObject */
+    private $cache;
+    /** @var MemoryCacheBackend */
+    private $memoryCache;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->createMock(IConfig::class);
+        $this->cacheFactory = $this->createMock(ICacheFactory::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->cache = $this->createMock(ICache::class);
+
+        $this->cacheFactory
+            ->expects($this->once())
+            ->method('createDistributed')
+            ->with('OC\Security\RateLimiting\Backend\MemoryCacheBackend')
+            ->willReturn($this->cache);
+
+        $this->config->method('getSystemValueBool')
+            ->with('ratelimit.protection.enabled')
+            ->willReturn(true);
+
+        $this->memoryCache = new MemoryCacheBackend(
+            $this->config,
+            $this->cacheFactory,
+            $this->timeFactory
+        );
+    }
+
+    public function testGetAttemptsWithNoAttemptsBefore(): void {
+        $this->cache
+            ->expects($this->once())
+            ->method('get')
+            ->with('eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b')
+            ->willReturn(null);
+
+        $this->assertSame(0, $this->memoryCache->getAttempts('Method', 'User'));
+    }
+
+    public function testGetAttempts(): void {
+        $this->timeFactory
+            ->expects($this->once())
+            ->method('getTime')
+            ->willReturn(210);
+        $this->cache
+            ->expects($this->once())
+            ->method('get')
+            ->with('eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b')
+            ->willReturn(json_encode([
+                '1',
+                '2',
+                '87',
+                '223',
+                '223',
+                '224',
+            ]));
+
+        $this->assertSame(3, $this->memoryCache->getAttempts('Method', 'User'));
+    }
+
+    public function testRegisterAttemptWithNoAttemptsBefore(): void {
+        $this->timeFactory
+            ->expects($this->once())
+            ->method('getTime')
+            ->willReturn(123);
+
+        $this->cache
+            ->expects($this->once())
+            ->method('get')
+            ->with('eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b')
+            ->willReturn(null);
+        $this->cache
+            ->expects($this->once())
+            ->method('set')
+            ->with(
+                'eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b',
+                json_encode(['223'])
+            );
+
+        $this->memoryCache->registerAttempt('Method', 'User', 100);
+    }
+
+    public function testRegisterAttempt(): void {
+        $this->timeFactory
+            ->expects($this->once())
+            ->method('getTime')
+            ->willReturn(86);
+
+        $this->cache
+            ->expects($this->once())
+            ->method('get')
+            ->with('eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b')
+            ->willReturn(json_encode([
+                '1',
+                '2',
+                '87',
+                '123',
+                '123',
+                '124',
+            ]));
+        $this->cache
+            ->expects($this->once())
+            ->method('set')
+            ->with(
+                'eea460b8d756885099c7f0a4c083bf6a745069ee4a301984e726df58fd4510bffa2dac4b7fd5d835726a6753ffa8343ba31c7e902bbef78fc68c2e743667cb4b',
+                json_encode([
+                    '87',
+                    '123',
+                    '123',
+                    '124',
+                    '186',
+                ])
+            );
+
+        $this->memoryCache->registerAttempt('Method', 'User', 100);
+    }
 }

tests/lib/EventSourceFactoryTest.php

Indentation +6 added lines, -6 removed lines

@@ -11,11 +11,11 @@
 use OCP\IRequest;
 
 class EventSourceFactoryTest extends TestCase {
-	public function testCreate(): void {
-		$request = $this->createMock(IRequest::class);
-		$factory = new EventSourceFactory($request);
+    public function testCreate(): void {
+        $request = $this->createMock(IRequest::class);
+        $factory = new EventSourceFactory($request);
 
-		$instance = $factory->create();
-		$this->assertInstanceOf(IEventSource::class, $instance);
-	}
+        $instance = $factory->create();
+        $this->assertInstanceOf(IEventSource::class, $instance);
+    }
 }

tests/lib/Template/JSResourceLocatorTest.php

Indentation +162 added lines, -162 removed lines

@@ -17,166 +17,166 @@
 use Psr\Log\LoggerInterface;
 
 class JSResourceLocatorTest extends \Test\TestCase {
-	/** @var IAppData|\PHPUnit\Framework\MockObject\MockObject */
-	protected $appData;
-	/** @var IURLGenerator|\PHPUnit\Framework\MockObject\MockObject */
-	protected $urlGenerator;
-	/** @var SystemConfig|\PHPUnit\Framework\MockObject\MockObject */
-	protected $config;
-	/** @var ICacheFactory|\PHPUnit\Framework\MockObject\MockObject */
-	protected $cacheFactory;
-	/** @var LoggerInterface|\PHPUnit\Framework\MockObject\MockObject */
-	protected $logger;
-	/** @var IAppManager|\PHPUnit\Framework\MockObject\MockObject */
-	protected $appManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->appData = $this->createMock(IAppData::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->config = $this->createMock(SystemConfig::class);
-		$this->cacheFactory = $this->createMock(ICacheFactory::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-	}
-
-	private function jsResourceLocator() {
-		$jsCombiner = new JSCombiner(
-			$this->appData,
-			$this->urlGenerator,
-			$this->cacheFactory,
-			$this->config,
-			$this->logger
-		);
-		return new JSResourceLocator(
-			$this->logger,
-			$jsCombiner,
-			$this->appManager,
-		);
-	}
-
-	private function rrmdir($directory) {
-		$files = array_diff(scandir($directory), ['.','..']);
-		foreach ($files as $file) {
-			if (is_dir($directory . '/' . $file)) {
-				$this->rrmdir($directory . '/' . $file);
-			} else {
-				unlink($directory . '/' . $file);
-			}
-		}
-		return rmdir($directory);
-	}
-
-	private function randomString() {
-		return sha1(uniqid(mt_rand(), true));
-	}
-
-	public function testFindWithAppPathSymlink(): void {
-		$appName = 'test-js-app';
-
-		// First create new apps path, and a symlink to it
-		$apps_dirname = $this->randomString();
-		$new_apps_path = sys_get_temp_dir() . '/' . $apps_dirname;
-		$new_apps_path_symlink = $new_apps_path . '_link';
-		$this->assertTrue((
-			mkdir($new_apps_path) && symlink($apps_dirname, $new_apps_path_symlink)
-		), 'Setup of apps path failed');
-
-		// Create an app within that path
-		$this->assertTrue((
-			mkdir($new_apps_path . '/' . $appName) && touch($new_apps_path . '/' . $appName . '/' . 'test-file.js')
-		), 'Setup of app within the new apps path failed');
-
-		// Use the symlink as the app path
-		$this->appManager->expects($this->once())
-			->method('getAppPath')
-			->with($appName)
-			->willReturn("$new_apps_path_symlink/$appName");
-		$this->appManager->expects($this->once())
-			->method('getAppWebPath')
-			->with($appName)
-			->willReturn("/js-apps-test/$appName");
-
-		// Run the tests
-		$locator = $this->jsResourceLocator();
-		$locator->find(["$appName/test-file"]);
-
-		$resources = $locator->getResources();
-		$this->assertCount(1, $resources);
-		$resource = $resources[0];
-		$this->assertCount(3, $resource);
-		$root = $resource[0];
-		$webRoot = $resource[1];
-		$file = $resource[2];
-
-		$expectedRoot = $new_apps_path;
-		$expectedWebRoot = \OC::$WEBROOT . '/js-apps-test';
-		$expectedFile = $appName . '/test-file.js';
-
-		$this->assertEquals($expectedRoot, $root,
-			'Ensure the app path symlink is resolved into the real path');
-		$this->assertEquals($expectedWebRoot, $webRoot);
-		$this->assertEquals($expectedFile, $file);
-
-		unlink($new_apps_path_symlink);
-		$this->rrmdir($new_apps_path);
-	}
-
-	public function testNotExistingTranslationHandledSilent(): void {
-		$this->appManager->expects($this->once())
-			->method('getAppPath')
-			->with('core')
-			->willThrowException(new AppPathNotFoundException());
-		$this->appManager->expects($this->atMost(1))
-			->method('getAppWebPath')
-			->with('core')
-			->willThrowException(new AppPathNotFoundException());
-		// Assert logger is not called
-		$this->logger->expects($this->never())
-			->method('error');
-
-		// Run the tests
-		$locator = $this->jsResourceLocator();
-		$locator->find(['core/l10n/en.js']);
-
-		$resources = $locator->getResources();
-		$this->assertCount(0, $resources);
-	}
-
-	public function testFindModuleJSWithFallback(): void {
-		// First create new apps path, and a symlink to it
-		$apps_dirname = $this->randomString();
-		$new_apps_path = sys_get_temp_dir() . '/' . $apps_dirname;
-		mkdir($new_apps_path);
-
-		// Create an app within that path
-		mkdir("$new_apps_path/test-js-app");
-		touch("$new_apps_path/test-js-app/module.mjs");
-		touch("$new_apps_path/test-js-app/both.mjs");
-		touch("$new_apps_path/test-js-app/both.js");
-		touch("$new_apps_path/test-js-app/plain.js");
-
-		// Use the app path
-		$this->appManager->expects($this->any())
-			->method('getAppPath')
-			->with('test-js-app')
-			->willReturn("$new_apps_path/test-js-app");
-
-		$locator = $this->jsResourceLocator();
-		$locator->find(['test-js-app/module', 'test-js-app/both', 'test-js-app/plain']);
-
-		$resources = $locator->getResources();
-		$this->assertCount(3, $resources);
-
-		$expectedWebRoot = \OC::$WEBROOT . '/js-apps-test/test-js-app';
-		$expectedFiles = ['module.mjs', 'both.mjs', 'plain.js'];
-
-		for ($idx = 0; $idx++; $idx < 3) {
-			$this->assertEquals($expectedWebRoot, $resources[$idx][1]);
-			$this->assertEquals($expectedFiles[$idx], $resources[$idx][2]);
-		}
-
-		$this->rrmdir($new_apps_path);
-	}
+    /** @var IAppData|\PHPUnit\Framework\MockObject\MockObject */
+    protected $appData;
+    /** @var IURLGenerator|\PHPUnit\Framework\MockObject\MockObject */
+    protected $urlGenerator;
+    /** @var SystemConfig|\PHPUnit\Framework\MockObject\MockObject */
+    protected $config;
+    /** @var ICacheFactory|\PHPUnit\Framework\MockObject\MockObject */
+    protected $cacheFactory;
+    /** @var LoggerInterface|\PHPUnit\Framework\MockObject\MockObject */
+    protected $logger;
+    /** @var IAppManager|\PHPUnit\Framework\MockObject\MockObject */
+    protected $appManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->appData = $this->createMock(IAppData::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->config = $this->createMock(SystemConfig::class);
+        $this->cacheFactory = $this->createMock(ICacheFactory::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+    }
+
+    private function jsResourceLocator() {
+        $jsCombiner = new JSCombiner(
+            $this->appData,
+            $this->urlGenerator,
+            $this->cacheFactory,
+            $this->config,
+            $this->logger
+        );
+        return new JSResourceLocator(
+            $this->logger,
+            $jsCombiner,
+            $this->appManager,
+        );
+    }
+
+    private function rrmdir($directory) {
+        $files = array_diff(scandir($directory), ['.','..']);
+        foreach ($files as $file) {
+            if (is_dir($directory . '/' . $file)) {
+                $this->rrmdir($directory . '/' . $file);
+            } else {
+                unlink($directory . '/' . $file);
+            }
+        }
+        return rmdir($directory);
+    }
+
+    private function randomString() {
+        return sha1(uniqid(mt_rand(), true));
+    }
+
+    public function testFindWithAppPathSymlink(): void {
+        $appName = 'test-js-app';
+
+        // First create new apps path, and a symlink to it
+        $apps_dirname = $this->randomString();
+        $new_apps_path = sys_get_temp_dir() . '/' . $apps_dirname;
+        $new_apps_path_symlink = $new_apps_path . '_link';
+        $this->assertTrue((
+            mkdir($new_apps_path) && symlink($apps_dirname, $new_apps_path_symlink)
+        ), 'Setup of apps path failed');
+
+        // Create an app within that path
+        $this->assertTrue((
+            mkdir($new_apps_path . '/' . $appName) && touch($new_apps_path . '/' . $appName . '/' . 'test-file.js')
+        ), 'Setup of app within the new apps path failed');
+
+        // Use the symlink as the app path
+        $this->appManager->expects($this->once())
+            ->method('getAppPath')
+            ->with($appName)
+            ->willReturn("$new_apps_path_symlink/$appName");
+        $this->appManager->expects($this->once())
+            ->method('getAppWebPath')
+            ->with($appName)
+            ->willReturn("/js-apps-test/$appName");
+
+        // Run the tests
+        $locator = $this->jsResourceLocator();
+        $locator->find(["$appName/test-file"]);
+
+        $resources = $locator->getResources();
+        $this->assertCount(1, $resources);
+        $resource = $resources[0];
+        $this->assertCount(3, $resource);
+        $root = $resource[0];
+        $webRoot = $resource[1];
+        $file = $resource[2];
+
+        $expectedRoot = $new_apps_path;
+        $expectedWebRoot = \OC::$WEBROOT . '/js-apps-test';
+        $expectedFile = $appName . '/test-file.js';
+
+        $this->assertEquals($expectedRoot, $root,
+            'Ensure the app path symlink is resolved into the real path');
+        $this->assertEquals($expectedWebRoot, $webRoot);
+        $this->assertEquals($expectedFile, $file);
+
+        unlink($new_apps_path_symlink);
+        $this->rrmdir($new_apps_path);
+    }
+
+    public function testNotExistingTranslationHandledSilent(): void {
+        $this->appManager->expects($this->once())
+            ->method('getAppPath')
+            ->with('core')
+            ->willThrowException(new AppPathNotFoundException());
+        $this->appManager->expects($this->atMost(1))
+            ->method('getAppWebPath')
+            ->with('core')
+            ->willThrowException(new AppPathNotFoundException());
+        // Assert logger is not called
+        $this->logger->expects($this->never())
+            ->method('error');
+
+        // Run the tests
+        $locator = $this->jsResourceLocator();
+        $locator->find(['core/l10n/en.js']);
+
+        $resources = $locator->getResources();
+        $this->assertCount(0, $resources);
+    }
+
+    public function testFindModuleJSWithFallback(): void {
+        // First create new apps path, and a symlink to it
+        $apps_dirname = $this->randomString();
+        $new_apps_path = sys_get_temp_dir() . '/' . $apps_dirname;
+        mkdir($new_apps_path);
+
+        // Create an app within that path
+        mkdir("$new_apps_path/test-js-app");
+        touch("$new_apps_path/test-js-app/module.mjs");
+        touch("$new_apps_path/test-js-app/both.mjs");
+        touch("$new_apps_path/test-js-app/both.js");
+        touch("$new_apps_path/test-js-app/plain.js");
+
+        // Use the app path
+        $this->appManager->expects($this->any())
+            ->method('getAppPath')
+            ->with('test-js-app')
+            ->willReturn("$new_apps_path/test-js-app");
+
+        $locator = $this->jsResourceLocator();
+        $locator->find(['test-js-app/module', 'test-js-app/both', 'test-js-app/plain']);
+
+        $resources = $locator->getResources();
+        $this->assertCount(3, $resources);
+
+        $expectedWebRoot = \OC::$WEBROOT . '/js-apps-test/test-js-app';
+        $expectedFiles = ['module.mjs', 'both.mjs', 'plain.js'];
+
+        for ($idx = 0; $idx++; $idx < 3) {
+            $this->assertEquals($expectedWebRoot, $resources[$idx][1]);
+            $this->assertEquals($expectedFiles[$idx], $resources[$idx][2]);
+        }
+
+        $this->rrmdir($new_apps_path);
+    }
 }

tests/lib/Talk/ConversationOptionsTest.php

Indentation +4 added lines, -4 removed lines

@@ -13,9 +13,9 @@
 use Test\TestCase;
 
 class ConversationOptionsTest extends TestCase {
-	public function testDefaults(): void {
-		ConversationOptions::default();
+    public function testDefaults(): void {
+        ConversationOptions::default();
 
-		$this->addToAssertionCount(1);
-	}
+        $this->addToAssertionCount(1);
+    }
 }