Inspection of "Merge pull request #56195 from nextcloud/addUserMi..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 90bbef...7a7d0b )

unknown

created 2025-11-05 08:30 UTC

Status

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -32,30 +32,30 @@
 block discarded – undo
 use OCP\Migration\SimpleMigrationStep;
 
 class Version1016Date20201109085907 extends SimpleMigrationStep {
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
-
-		$result = $this->ensureColumnIsNullable($schema, 'calendar_reminders', 'is_recurring');
-
-		return $result ? $schema : null;
-	}
-
-	protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
-		$table = $schema->getTable($tableName);
-		$column = $table->getColumn($columnName);
-
-		if ($column->getNotnull()) {
-			$column->setNotnull(false);
-			return true;
-		}
-
-		return false;
-	}
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
+
+        $result = $this->ensureColumnIsNullable($schema, 'calendar_reminders', 'is_recurring');
+
+        return $result ? $schema : null;
+    }
+
+    protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
+        $table = $schema->getTable($tableName);
+        $column = $table->getColumn($columnName);
+
+        if ($column->getNotnull()) {
+            $column->setNotnull(false);
+            return true;
+        }
+
+        return false;
+    }
 }

Please login to merge, or discard this patch.

core/Migrations/Version20000Date20201111081915.php 1 patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -32,30 +32,30 @@
 block discarded – undo
 use OCP\Migration\SimpleMigrationStep;
 
 class Version20000Date20201111081915 extends SimpleMigrationStep {
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
-
-		$result = $this->ensureColumnIsNullable($schema, 'direct_edit', 'accessed');
-
-		return $result ? $schema : null;
-	}
-
-	protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
-		$table = $schema->getTable($tableName);
-		$column = $table->getColumn($columnName);
-
-		if ($column->getNotnull()) {
-			$column->setNotnull(false);
-			return true;
-		}
-
-		return false;
-	}
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
+
+        $result = $this->ensureColumnIsNullable($schema, 'direct_edit', 'accessed');
+
+        return $result ? $schema : null;
+    }
+
+    protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
+        $table = $schema->getTable($tableName);
+        $column = $table->getColumn($columnName);
+
+        if ($column->getNotnull()) {
+            $column->setNotnull(false);
+            return true;
+        }
+
+        return false;
+    }
 }

Please login to merge, or discard this patch.

apps/user_status/lib/Migration/Version0001Date20200602134824.php 1 patch

Indentation +54 added lines, -54 removed lines patch added patch discarded remove patch

@@ -37,61 +37,61 @@
 block discarded – undo
  */
 class Version0001Date20200602134824 extends SimpleMigrationStep {
 
-	/**
-	 * @param IOutput $output
-	 * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 * @since 20.0.0
-	 */
-	public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
+    /**
+     * @param IOutput $output
+     * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     * @since 20.0.0
+     */
+    public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
 
-		$statusTable = $schema->createTable('user_status');
-		$statusTable->addColumn('id', Types::BIGINT, [
-			'autoincrement' => true,
-			'notnull' => true,
-			'length' => 20,
-			'unsigned' => true,
-		]);
-		$statusTable->addColumn('user_id', Types::STRING, [
-			'notnull' => true,
-			'length' => 255,
-		]);
-		$statusTable->addColumn('status', Types::STRING, [
-			'notnull' => true,
-			'length' => 255,
-		]);
-		$statusTable->addColumn('status_timestamp', Types::INTEGER, [
-			'notnull' => true,
-			'length' => 11,
-			'unsigned' => true,
-		]);
-		$statusTable->addColumn('is_user_defined', Types::BOOLEAN, [
-			'notnull' => false,
-		]);
-		$statusTable->addColumn('message_id', Types::STRING, [
-			'notnull' => false,
-			'length' => 255,
-		]);
-		$statusTable->addColumn('custom_icon', Types::STRING, [
-			'notnull' => false,
-			'length' => 255,
-		]);
-		$statusTable->addColumn('custom_message', Types::TEXT, [
-			'notnull' => false,
-		]);
-		$statusTable->addColumn('clear_at', Types::INTEGER, [
-			'notnull' => false,
-			'length' => 11,
-			'unsigned' => true,
-		]);
+        $statusTable = $schema->createTable('user_status');
+        $statusTable->addColumn('id', Types::BIGINT, [
+            'autoincrement' => true,
+            'notnull' => true,
+            'length' => 20,
+            'unsigned' => true,
+        ]);
+        $statusTable->addColumn('user_id', Types::STRING, [
+            'notnull' => true,
+            'length' => 255,
+        ]);
+        $statusTable->addColumn('status', Types::STRING, [
+            'notnull' => true,
+            'length' => 255,
+        ]);
+        $statusTable->addColumn('status_timestamp', Types::INTEGER, [
+            'notnull' => true,
+            'length' => 11,
+            'unsigned' => true,
+        ]);
+        $statusTable->addColumn('is_user_defined', Types::BOOLEAN, [
+            'notnull' => false,
+        ]);
+        $statusTable->addColumn('message_id', Types::STRING, [
+            'notnull' => false,
+            'length' => 255,
+        ]);
+        $statusTable->addColumn('custom_icon', Types::STRING, [
+            'notnull' => false,
+            'length' => 255,
+        ]);
+        $statusTable->addColumn('custom_message', Types::TEXT, [
+            'notnull' => false,
+        ]);
+        $statusTable->addColumn('clear_at', Types::INTEGER, [
+            'notnull' => false,
+            'length' => 11,
+            'unsigned' => true,
+        ]);
 
-		$statusTable->setPrimaryKey(['id']);
-		$statusTable->addUniqueIndex(['user_id'], 'user_status_uid_ix');
-		$statusTable->addIndex(['clear_at'], 'user_status_clr_ix');
+        $statusTable->setPrimaryKey(['id']);
+        $statusTable->addUniqueIndex(['user_id'], 'user_status_uid_ix');
+        $statusTable->addIndex(['clear_at'], 'user_status_clr_ix');
 
-		return $schema;
-	}
+        return $schema;
+    }
 }

Please login to merge, or discard this patch.

apps/user_status/lib/Migration/Version1000Date20201111130204.php 1 patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -33,30 +33,30 @@
 block discarded – undo
 
 class Version1000Date20201111130204 extends SimpleMigrationStep {
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
-
-		$result = $this->ensureColumnIsNullable($schema, 'user_status', 'is_user_defined');
-
-		return $result ? $schema : null;
-	}
-
-	protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
-		$table = $schema->getTable($tableName);
-		$column = $table->getColumn($columnName);
-
-		if ($column->getNotnull()) {
-			$column->setNotnull(false);
-			return true;
-		}
-
-		return false;
-	}
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
+
+        $result = $this->ensureColumnIsNullable($schema, 'user_status', 'is_user_defined');
+
+        return $result ? $schema : null;
+    }
+
+    protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
+        $table = $schema->getTable($tableName);
+        $column = $table->getColumn($columnName);
+
+        if ($column->getNotnull()) {
+            $column->setNotnull(false);
+            return true;
+        }
+
+        return false;
+    }
 }

Please login to merge, or discard this patch.

core/Migrations/Version21000Date20201202095923.php 1 patch

Indentation +37 added lines, -37 removed lines patch added patch discarded remove patch

@@ -32,44 +32,44 @@
 block discarded – undo
 use OCP\Migration\SimpleMigrationStep;
 
 class Version21000Date20201202095923 extends SimpleMigrationStep {
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
 
-		if (!$schema->hasTable('accounts_data')) {
-			$table = $schema->createTable('accounts_data');
-			$table->addColumn('id', Types::BIGINT, [
-				'autoincrement' => true,
-				'notnull' => true,
-				'length' => 20,
-			]);
-			$table->addColumn('uid', Types::STRING, [
-				'notnull' => true,
-				'length' => 64,
-			]);
-			$table->addColumn('name', Types::STRING, [
-				'notnull' => true,
-				'length' => 64,
-			]);
-			$table->addColumn('value', Types::STRING, [
-				'notnull' => false,
-				'length' => 255,
-				'default' => '',
-			]);
-			$table->setPrimaryKey(['id']);
-			$table->addIndex(['uid'], 'accounts_data_uid');
-			$table->addIndex(['name'], 'accounts_data_name');
-			$table->addIndex(['value'], 'accounts_data_value');
+        if (!$schema->hasTable('accounts_data')) {
+            $table = $schema->createTable('accounts_data');
+            $table->addColumn('id', Types::BIGINT, [
+                'autoincrement' => true,
+                'notnull' => true,
+                'length' => 20,
+            ]);
+            $table->addColumn('uid', Types::STRING, [
+                'notnull' => true,
+                'length' => 64,
+            ]);
+            $table->addColumn('name', Types::STRING, [
+                'notnull' => true,
+                'length' => 64,
+            ]);
+            $table->addColumn('value', Types::STRING, [
+                'notnull' => false,
+                'length' => 255,
+                'default' => '',
+            ]);
+            $table->setPrimaryKey(['id']);
+            $table->addIndex(['uid'], 'accounts_data_uid');
+            $table->addIndex(['name'], 'accounts_data_name');
+            $table->addIndex(['value'], 'accounts_data_value');
 
-			return $schema;
-		}
+            return $schema;
+        }
 
-		return null;
-	}
+        return null;
+    }
 }

Please login to merge, or discard this patch.

apps/files_trashbin/lib/Migration/Version1010Date20200630192639.php 1 patch

Indentation +50 added lines, -50 removed lines patch added patch discarded remove patch

@@ -33,55 +33,55 @@
 block discarded – undo
 use OCP\Migration\SimpleMigrationStep;
 
 class Version1010Date20200630192639 extends SimpleMigrationStep {
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
 
-		if (!$schema->hasTable('files_trash')) {
-			$table = $schema->createTable('files_trash');
-			$table->addColumn('auto_id', Types::BIGINT, [
-				'autoincrement' => true,
-				'notnull' => true,
-			]);
-			$table->addColumn('id', Types::STRING, [
-				'notnull' => true,
-				'length' => 250,
-				'default' => '',
-			]);
-			$table->addColumn('user', Types::STRING, [
-				'notnull' => true,
-				'length' => 64,
-				'default' => '',
-			]);
-			$table->addColumn('timestamp', Types::STRING, [
-				'notnull' => true,
-				'length' => 12,
-				'default' => '',
-			]);
-			$table->addColumn('location', Types::STRING, [
-				'notnull' => true,
-				'length' => 512,
-				'default' => '',
-			]);
-			$table->addColumn('type', Types::STRING, [
-				'notnull' => false,
-				'length' => 4,
-			]);
-			$table->addColumn('mime', Types::STRING, [
-				'notnull' => false,
-				'length' => 255,
-			]);
-			$table->setPrimaryKey(['auto_id']);
-			$table->addIndex(['id'], 'id_index');
-			$table->addIndex(['timestamp'], 'timestamp_index');
-			$table->addIndex(['user'], 'user_index');
-		}
-		return $schema;
-	}
+        if (!$schema->hasTable('files_trash')) {
+            $table = $schema->createTable('files_trash');
+            $table->addColumn('auto_id', Types::BIGINT, [
+                'autoincrement' => true,
+                'notnull' => true,
+            ]);
+            $table->addColumn('id', Types::STRING, [
+                'notnull' => true,
+                'length' => 250,
+                'default' => '',
+            ]);
+            $table->addColumn('user', Types::STRING, [
+                'notnull' => true,
+                'length' => 64,
+                'default' => '',
+            ]);
+            $table->addColumn('timestamp', Types::STRING, [
+                'notnull' => true,
+                'length' => 12,
+                'default' => '',
+            ]);
+            $table->addColumn('location', Types::STRING, [
+                'notnull' => true,
+                'length' => 512,
+                'default' => '',
+            ]);
+            $table->addColumn('type', Types::STRING, [
+                'notnull' => false,
+                'length' => 4,
+            ]);
+            $table->addColumn('mime', Types::STRING, [
+                'notnull' => false,
+                'length' => 255,
+            ]);
+            $table->setPrimaryKey(['auto_id']);
+            $table->addIndex(['id'], 'id_index');
+            $table->addIndex(['timestamp'], 'timestamp_index');
+            $table->addIndex(['user'], 'user_index');
+        }
+        return $schema;
+    }
 }

Please login to merge, or discard this patch.

apps/files_sharing/lib/Migration/Version21000Date20201223143245.php 1 patch

Indentation +30 added lines, -30 removed lines patch added patch discarded remove patch

@@ -34,37 +34,37 @@
 block discarded – undo
 use OCP\Migration\SimpleMigrationStep;
 
 class Version21000Date20201223143245 extends SimpleMigrationStep {
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
 
-		if ($schema->hasTable('share_external')) {
-			$table = $schema->getTable('share_external');
-			$changed = false;
-			if (!$table->hasColumn('parent')) {
-				$table->addColumn('parent', Types::BIGINT, [
-					'notnull' => false,
-					'default' => -1,
-				]);
-				$changed = true;
-			}
-			if (!$table->hasColumn('share_type')) {
-				$table->addColumn('share_type', Types::INTEGER, [
-					'notnull' => false,
-					'length' => 4,
-				]);
-				$changed = true;
-			}
-			if ($table->hasColumn('lastscan')) {
-				$table->dropColumn('lastscan');
-				$changed = true;
-			}
+        if ($schema->hasTable('share_external')) {
+            $table = $schema->getTable('share_external');
+            $changed = false;
+            if (!$table->hasColumn('parent')) {
+                $table->addColumn('parent', Types::BIGINT, [
+                    'notnull' => false,
+                    'default' => -1,
+                ]);
+                $changed = true;
+            }
+            if (!$table->hasColumn('share_type')) {
+                $table->addColumn('share_type', Types::INTEGER, [
+                    'notnull' => false,
+                    'length' => 4,
+                ]);
+                $changed = true;
+            }
+            if ($table->hasColumn('lastscan')) {
+                $table->dropColumn('lastscan');
+                $changed = true;
+            }
 
-			if ($changed) {
-				return $schema;
-			}
-		}
+            if ($changed) {
+                return $schema;
+            }
+        }
 
-		return null;
-	}
+        return null;
+    }
 }

Please login to merge, or discard this patch.

lib/private/DB/SQLiteSessionInit.php 1 patch

Indentation +34 added lines, -34 removed lines patch added patch discarded remove patch

@@ -31,42 +31,42 @@
 block discarded – undo
 use Doctrine\DBAL\Events;
 
 class SQLiteSessionInit implements EventSubscriber {
-	/**
-	 * @var bool
-	 */
-	private $caseSensitiveLike;
+    /**
+     * @var bool
+     */
+    private $caseSensitiveLike;
 
-	/**
-	 * @var string
-	 */
-	private $journalMode;
+    /**
+     * @var string
+     */
+    private $journalMode;
 
-	/**
-	 * Configure case sensitive like for each connection
-	 *
-	 * @param bool $caseSensitiveLike
-	 * @param string $journalMode
-	 */
-	public function __construct($caseSensitiveLike, $journalMode) {
-		$this->caseSensitiveLike = $caseSensitiveLike;
-		$this->journalMode = $journalMode;
-	}
+    /**
+     * Configure case sensitive like for each connection
+     *
+     * @param bool $caseSensitiveLike
+     * @param string $journalMode
+     */
+    public function __construct($caseSensitiveLike, $journalMode) {
+        $this->caseSensitiveLike = $caseSensitiveLike;
+        $this->journalMode = $journalMode;
+    }
 
-	/**
-	 * @param ConnectionEventArgs $args
-	 * @return void
-	 */
-	public function postConnect(ConnectionEventArgs $args) {
-		$sensitive = $this->caseSensitiveLike ? 'true' : 'false';
-		$args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = ' . $sensitive);
-		$args->getConnection()->executeUpdate('PRAGMA journal_mode = ' . $this->journalMode);
-		/** @var \Doctrine\DBAL\Driver\PDO\Connection $connection */
-		$connection = $args->getConnection()->getWrappedConnection();
-		$pdo = $connection->getWrappedConnection();
-		$pdo->sqliteCreateFunction('md5', 'md5', 1);
-	}
+    /**
+     * @param ConnectionEventArgs $args
+     * @return void
+     */
+    public function postConnect(ConnectionEventArgs $args) {
+        $sensitive = $this->caseSensitiveLike ? 'true' : 'false';
+        $args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = ' . $sensitive);
+        $args->getConnection()->executeUpdate('PRAGMA journal_mode = ' . $this->journalMode);
+        /** @var \Doctrine\DBAL\Driver\PDO\Connection $connection */
+        $connection = $args->getConnection()->getWrappedConnection();
+        $pdo = $connection->getWrappedConnection();
+        $pdo->sqliteCreateFunction('md5', 'md5', 1);
+    }
 
-	public function getSubscribedEvents() {
-		return [Events::postConnect];
-	}
+    public function getSubscribedEvents() {
+        return [Events::postConnect];
+    }
 }

Please login to merge, or discard this patch.

core/Migrations/Version21000Date20210119195004.php 1 patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -35,21 +35,21 @@
 block discarded – undo
  * Auto-generated migration step: Please modify to your needs!
  */
 class Version21000Date20210119195004 extends SimpleMigrationStep {
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
 
-		$table = $schema->getTable('authtoken');
-		if ($table->hasIndex('authtoken_version_index')) {
-			$table->dropIndex('authtoken_version_index');
-		}
+        $table = $schema->getTable('authtoken');
+        if ($table->hasIndex('authtoken_version_index')) {
+            $table->dropIndex('authtoken_version_index');
+        }
 
-		return $schema;
-	}
+        return $schema;
+    }
 }

Please login to merge, or discard this patch.

		@@ -32,30 +32,30 @@
		block discarded – undo
32	32	use OCP\Migration\SimpleMigrationStep;
33	33
34	34	class Version1016Date20201109085907 extends SimpleMigrationStep {
35		- /**
36		- * @param IOutput $output
37		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
38		- * @param array $options
39		- * @return null\|ISchemaWrapper
40		- */
41		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
42		- /** @var ISchemaWrapper $schema */
43		- $schema = $schemaClosure();
44		-
45		- $result = $this->ensureColumnIsNullable($schema, 'calendar_reminders', 'is_recurring');
46		-
47		- return $result ? $schema : null;
48		- }
49		-
50		- protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
51		- $table = $schema->getTable($tableName);
52		- $column = $table->getColumn($columnName);
53		-
54		- if ($column->getNotnull()) {
55		- $column->setNotnull(false);
56		- return true;
57		- }
58		-
59		- return false;
60		- }
	35	+ /**
	36	+ * @param IOutput $output
	37	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	38	+ * @param array $options
	39	+ * @return null\|ISchemaWrapper
	40	+ */
	41	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
	42	+ /** @var ISchemaWrapper $schema */
	43	+ $schema = $schemaClosure();
	44	+
	45	+ $result = $this->ensureColumnIsNullable($schema, 'calendar_reminders', 'is_recurring');
	46	+
	47	+ return $result ? $schema : null;
	48	+ }
	49	+
	50	+ protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
	51	+ $table = $schema->getTable($tableName);
	52	+ $column = $table->getColumn($columnName);
	53	+
	54	+ if ($column->getNotnull()) {
	55	+ $column->setNotnull(false);
	56	+ return true;
	57	+ }
	58	+
	59	+ return false;
	60	+ }
61	61	}

		@@ -37,61 +37,61 @@
		block discarded – undo
37	37	*/
38	38	class Version0001Date20200602134824 extends SimpleMigrationStep {
39	39
40		- /**
41		- * @param IOutput $output
42		- * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
43		- * @param array $options
44		- * @return null\|ISchemaWrapper
45		- * @since 20.0.0
46		- */
47		- public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
48		- /** @var ISchemaWrapper $schema */
49		- $schema = $schemaClosure();
	40	+ /**
	41	+ * @param IOutput $output
	42	+ * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	43	+ * @param array $options
	44	+ * @return null\|ISchemaWrapper
	45	+ * @since 20.0.0
	46	+ */
	47	+ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
	48	+ /** @var ISchemaWrapper $schema */
	49	+ $schema = $schemaClosure();
50	50
51		- $statusTable = $schema->createTable('user_status');
52		- $statusTable->addColumn('id', Types::BIGINT, [
53		- 'autoincrement' => true,
54		- 'notnull' => true,
55		- 'length' => 20,
56		- 'unsigned' => true,
57		- ]);
58		- $statusTable->addColumn('user_id', Types::STRING, [
59		- 'notnull' => true,
60		- 'length' => 255,
61		- ]);
62		- $statusTable->addColumn('status', Types::STRING, [
63		- 'notnull' => true,
64		- 'length' => 255,
65		- ]);
66		- $statusTable->addColumn('status_timestamp', Types::INTEGER, [
67		- 'notnull' => true,
68		- 'length' => 11,
69		- 'unsigned' => true,
70		- ]);
71		- $statusTable->addColumn('is_user_defined', Types::BOOLEAN, [
72		- 'notnull' => false,
73		- ]);
74		- $statusTable->addColumn('message_id', Types::STRING, [
75		- 'notnull' => false,
76		- 'length' => 255,
77		- ]);
78		- $statusTable->addColumn('custom_icon', Types::STRING, [
79		- 'notnull' => false,
80		- 'length' => 255,
81		- ]);
82		- $statusTable->addColumn('custom_message', Types::TEXT, [
83		- 'notnull' => false,
84		- ]);
85		- $statusTable->addColumn('clear_at', Types::INTEGER, [
86		- 'notnull' => false,
87		- 'length' => 11,
88		- 'unsigned' => true,
89		- ]);
	51	+ $statusTable = $schema->createTable('user_status');
	52	+ $statusTable->addColumn('id', Types::BIGINT, [
	53	+ 'autoincrement' => true,
	54	+ 'notnull' => true,
	55	+ 'length' => 20,
	56	+ 'unsigned' => true,
	57	+ ]);
	58	+ $statusTable->addColumn('user_id', Types::STRING, [
	59	+ 'notnull' => true,
	60	+ 'length' => 255,
	61	+ ]);
	62	+ $statusTable->addColumn('status', Types::STRING, [
	63	+ 'notnull' => true,
	64	+ 'length' => 255,
	65	+ ]);
	66	+ $statusTable->addColumn('status_timestamp', Types::INTEGER, [
	67	+ 'notnull' => true,
	68	+ 'length' => 11,
	69	+ 'unsigned' => true,
	70	+ ]);
	71	+ $statusTable->addColumn('is_user_defined', Types::BOOLEAN, [
	72	+ 'notnull' => false,
	73	+ ]);
	74	+ $statusTable->addColumn('message_id', Types::STRING, [
	75	+ 'notnull' => false,
	76	+ 'length' => 255,
	77	+ ]);
	78	+ $statusTable->addColumn('custom_icon', Types::STRING, [
	79	+ 'notnull' => false,
	80	+ 'length' => 255,
	81	+ ]);
	82	+ $statusTable->addColumn('custom_message', Types::TEXT, [
	83	+ 'notnull' => false,
	84	+ ]);
	85	+ $statusTable->addColumn('clear_at', Types::INTEGER, [
	86	+ 'notnull' => false,
	87	+ 'length' => 11,
	88	+ 'unsigned' => true,
	89	+ ]);
90	90
91		- $statusTable->setPrimaryKey(['id']);
92		- $statusTable->addUniqueIndex(['user_id'], 'user_status_uid_ix');
93		- $statusTable->addIndex(['clear_at'], 'user_status_clr_ix');
	91	+ $statusTable->setPrimaryKey(['id']);
	92	+ $statusTable->addUniqueIndex(['user_id'], 'user_status_uid_ix');
	93	+ $statusTable->addIndex(['clear_at'], 'user_status_clr_ix');
94	94
95		- return $schema;
96		- }
	95	+ return $schema;
	96	+ }
97	97	}

		@@ -33,30 +33,30 @@
		block discarded – undo
33	33
34	34	class Version1000Date20201111130204 extends SimpleMigrationStep {
35	35
36		- /**
37		- * @param IOutput $output
38		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
39		- * @param array $options
40		- * @return null\|ISchemaWrapper
41		- */
42		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
43		- /** @var ISchemaWrapper $schema */
44		- $schema = $schemaClosure();
45		-
46		- $result = $this->ensureColumnIsNullable($schema, 'user_status', 'is_user_defined');
47		-
48		- return $result ? $schema : null;
49		- }
50		-
51		- protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
52		- $table = $schema->getTable($tableName);
53		- $column = $table->getColumn($columnName);
54		-
55		- if ($column->getNotnull()) {
56		- $column->setNotnull(false);
57		- return true;
58		- }
59		-
60		- return false;
61		- }
	36	+ /**
	37	+ * @param IOutput $output
	38	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	39	+ * @param array $options
	40	+ * @return null\|ISchemaWrapper
	41	+ */
	42	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
	43	+ /** @var ISchemaWrapper $schema */
	44	+ $schema = $schemaClosure();
	45	+
	46	+ $result = $this->ensureColumnIsNullable($schema, 'user_status', 'is_user_defined');
	47	+
	48	+ return $result ? $schema : null;
	49	+ }
	50	+
	51	+ protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
	52	+ $table = $schema->getTable($tableName);
	53	+ $column = $table->getColumn($columnName);
	54	+
	55	+ if ($column->getNotnull()) {
	56	+ $column->setNotnull(false);
	57	+ return true;
	58	+ }
	59	+
	60	+ return false;
	61	+ }
62	62	}

		@@ -32,44 +32,44 @@
		block discarded – undo
32	32	use OCP\Migration\SimpleMigrationStep;
33	33
34	34	class Version21000Date20201202095923 extends SimpleMigrationStep {
35		- /**
36		- * @param IOutput $output
37		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
38		- * @param array $options
39		- * @return null\|ISchemaWrapper
40		- */
41		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
42		- /** @var ISchemaWrapper $schema */
43		- $schema = $schemaClosure();
	35	+ /**
	36	+ * @param IOutput $output
	37	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	38	+ * @param array $options
	39	+ * @return null\|ISchemaWrapper
	40	+ */
	41	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
	42	+ /** @var ISchemaWrapper $schema */
	43	+ $schema = $schemaClosure();
44	44
45		- if (!$schema->hasTable('accounts_data')) {
46		- $table = $schema->createTable('accounts_data');
47		- $table->addColumn('id', Types::BIGINT, [
48		- 'autoincrement' => true,
49		- 'notnull' => true,
50		- 'length' => 20,
51		- ]);
52		- $table->addColumn('uid', Types::STRING, [
53		- 'notnull' => true,
54		- 'length' => 64,
55		- ]);
56		- $table->addColumn('name', Types::STRING, [
57		- 'notnull' => true,
58		- 'length' => 64,
59		- ]);
60		- $table->addColumn('value', Types::STRING, [
61		- 'notnull' => false,
62		- 'length' => 255,
63		- 'default' => '',
64		- ]);
65		- $table->setPrimaryKey(['id']);
66		- $table->addIndex(['uid'], 'accounts_data_uid');
67		- $table->addIndex(['name'], 'accounts_data_name');
68		- $table->addIndex(['value'], 'accounts_data_value');
	45	+ if (!$schema->hasTable('accounts_data')) {
	46	+ $table = $schema->createTable('accounts_data');
	47	+ $table->addColumn('id', Types::BIGINT, [
	48	+ 'autoincrement' => true,
	49	+ 'notnull' => true,
	50	+ 'length' => 20,
	51	+ ]);
	52	+ $table->addColumn('uid', Types::STRING, [
	53	+ 'notnull' => true,
	54	+ 'length' => 64,
	55	+ ]);
	56	+ $table->addColumn('name', Types::STRING, [
	57	+ 'notnull' => true,
	58	+ 'length' => 64,
	59	+ ]);
	60	+ $table->addColumn('value', Types::STRING, [
	61	+ 'notnull' => false,
	62	+ 'length' => 255,
	63	+ 'default' => '',
	64	+ ]);
	65	+ $table->setPrimaryKey(['id']);
	66	+ $table->addIndex(['uid'], 'accounts_data_uid');
	67	+ $table->addIndex(['name'], 'accounts_data_name');
	68	+ $table->addIndex(['value'], 'accounts_data_value');
69	69
70		- return $schema;
71		- }
	70	+ return $schema;
	71	+ }
72	72
73		- return null;
74		- }
	73	+ return null;
	74	+ }
75	75	}

		@@ -33,55 +33,55 @@
		block discarded – undo
33	33	use OCP\Migration\SimpleMigrationStep;
34	34
35	35	class Version1010Date20200630192639 extends SimpleMigrationStep {
36		- /**
37		- * @param IOutput $output
38		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
39		- * @param array $options
40		- * @return null\|ISchemaWrapper
41		- */
42		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
43		- /** @var ISchemaWrapper $schema */
44		- $schema = $schemaClosure();
	36	+ /**
	37	+ * @param IOutput $output
	38	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	39	+ * @param array $options
	40	+ * @return null\|ISchemaWrapper
	41	+ */
	42	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
	43	+ /** @var ISchemaWrapper $schema */
	44	+ $schema = $schemaClosure();
45	45
46		- if (!$schema->hasTable('files_trash')) {
47		- $table = $schema->createTable('files_trash');
48		- $table->addColumn('auto_id', Types::BIGINT, [
49		- 'autoincrement' => true,
50		- 'notnull' => true,
51		- ]);
52		- $table->addColumn('id', Types::STRING, [
53		- 'notnull' => true,
54		- 'length' => 250,
55		- 'default' => '',
56		- ]);
57		- $table->addColumn('user', Types::STRING, [
58		- 'notnull' => true,
59		- 'length' => 64,
60		- 'default' => '',
61		- ]);
62		- $table->addColumn('timestamp', Types::STRING, [
63		- 'notnull' => true,
64		- 'length' => 12,
65		- 'default' => '',
66		- ]);
67		- $table->addColumn('location', Types::STRING, [
68		- 'notnull' => true,
69		- 'length' => 512,
70		- 'default' => '',
71		- ]);
72		- $table->addColumn('type', Types::STRING, [
73		- 'notnull' => false,
74		- 'length' => 4,
75		- ]);
76		- $table->addColumn('mime', Types::STRING, [
77		- 'notnull' => false,
78		- 'length' => 255,
79		- ]);
80		- $table->setPrimaryKey(['auto_id']);
81		- $table->addIndex(['id'], 'id_index');
82		- $table->addIndex(['timestamp'], 'timestamp_index');
83		- $table->addIndex(['user'], 'user_index');
84		- }
85		- return $schema;
86		- }
	46	+ if (!$schema->hasTable('files_trash')) {
	47	+ $table = $schema->createTable('files_trash');
	48	+ $table->addColumn('auto_id', Types::BIGINT, [
	49	+ 'autoincrement' => true,
	50	+ 'notnull' => true,
	51	+ ]);
	52	+ $table->addColumn('id', Types::STRING, [
	53	+ 'notnull' => true,
	54	+ 'length' => 250,
	55	+ 'default' => '',
	56	+ ]);
	57	+ $table->addColumn('user', Types::STRING, [
	58	+ 'notnull' => true,
	59	+ 'length' => 64,
	60	+ 'default' => '',
	61	+ ]);
	62	+ $table->addColumn('timestamp', Types::STRING, [
	63	+ 'notnull' => true,
	64	+ 'length' => 12,
	65	+ 'default' => '',
	66	+ ]);
	67	+ $table->addColumn('location', Types::STRING, [
	68	+ 'notnull' => true,
	69	+ 'length' => 512,
	70	+ 'default' => '',
	71	+ ]);
	72	+ $table->addColumn('type', Types::STRING, [
	73	+ 'notnull' => false,
	74	+ 'length' => 4,
	75	+ ]);
	76	+ $table->addColumn('mime', Types::STRING, [
	77	+ 'notnull' => false,
	78	+ 'length' => 255,
	79	+ ]);
	80	+ $table->setPrimaryKey(['auto_id']);
	81	+ $table->addIndex(['id'], 'id_index');
	82	+ $table->addIndex(['timestamp'], 'timestamp_index');
	83	+ $table->addIndex(['user'], 'user_index');
	84	+ }
	85	+ return $schema;
	86	+ }
87	87	}

		@@ -34,37 +34,37 @@
		block discarded – undo
34	34	use OCP\Migration\SimpleMigrationStep;
35	35
36	36	class Version21000Date20201223143245 extends SimpleMigrationStep {
37		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
38		- /** @var ISchemaWrapper $schema */
39		- $schema = $schemaClosure();
	37	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
	38	+ /** @var ISchemaWrapper $schema */
	39	+ $schema = $schemaClosure();
40	40
41		- if ($schema->hasTable('share_external')) {
42		- $table = $schema->getTable('share_external');
43		- $changed = false;
44		- if (!$table->hasColumn('parent')) {
45		- $table->addColumn('parent', Types::BIGINT, [
46		- 'notnull' => false,
47		- 'default' => -1,
48		- ]);
49		- $changed = true;
50		- }
51		- if (!$table->hasColumn('share_type')) {
52		- $table->addColumn('share_type', Types::INTEGER, [
53		- 'notnull' => false,
54		- 'length' => 4,
55		- ]);
56		- $changed = true;
57		- }
58		- if ($table->hasColumn('lastscan')) {
59		- $table->dropColumn('lastscan');
60		- $changed = true;
61		- }
	41	+ if ($schema->hasTable('share_external')) {
	42	+ $table = $schema->getTable('share_external');
	43	+ $changed = false;
	44	+ if (!$table->hasColumn('parent')) {
	45	+ $table->addColumn('parent', Types::BIGINT, [
	46	+ 'notnull' => false,
	47	+ 'default' => -1,
	48	+ ]);
	49	+ $changed = true;
	50	+ }
	51	+ if (!$table->hasColumn('share_type')) {
	52	+ $table->addColumn('share_type', Types::INTEGER, [
	53	+ 'notnull' => false,
	54	+ 'length' => 4,
	55	+ ]);
	56	+ $changed = true;
	57	+ }
	58	+ if ($table->hasColumn('lastscan')) {
	59	+ $table->dropColumn('lastscan');
	60	+ $changed = true;
	61	+ }
62	62
63		- if ($changed) {
64		- return $schema;
65		- }
66		- }
	63	+ if ($changed) {
	64	+ return $schema;
	65	+ }
	66	+ }
67	67
68		- return null;
69		- }
	68	+ return null;
	69	+ }
70	70	}

		@@ -31,42 +31,42 @@
		block discarded – undo
31	31	use Doctrine\DBAL\Events;
32	32
33	33	class SQLiteSessionInit implements EventSubscriber {
34		- /**
35		- * @var bool
36		- */
37		- private $caseSensitiveLike;
	34	+ /**
	35	+ * @var bool
	36	+ */
	37	+ private $caseSensitiveLike;
38	38
39		- /**
40		- * @var string
41		- */
42		- private $journalMode;
	39	+ /**
	40	+ * @var string
	41	+ */
	42	+ private $journalMode;
43	43
44		- /**
45		- * Configure case sensitive like for each connection
46		- *
47		- * @param bool $caseSensitiveLike
48		- * @param string $journalMode
49		- */
50		- public function __construct($caseSensitiveLike, $journalMode) {
51		- $this->caseSensitiveLike = $caseSensitiveLike;
52		- $this->journalMode = $journalMode;
53		- }
	44	+ /**
	45	+ * Configure case sensitive like for each connection
	46	+ *
	47	+ * @param bool $caseSensitiveLike
	48	+ * @param string $journalMode
	49	+ */
	50	+ public function __construct($caseSensitiveLike, $journalMode) {
	51	+ $this->caseSensitiveLike = $caseSensitiveLike;
	52	+ $this->journalMode = $journalMode;
	53	+ }
54	54
55		- /**
56		- * @param ConnectionEventArgs $args
57		- * @return void
58		- */
59		- public function postConnect(ConnectionEventArgs $args) {
60		- $sensitive = $this->caseSensitiveLike ? 'true' : 'false';
61		- $args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = ' . $sensitive);
62		- $args->getConnection()->executeUpdate('PRAGMA journal_mode = ' . $this->journalMode);
63		- /** @var \Doctrine\DBAL\Driver\PDO\Connection $connection */
64		- $connection = $args->getConnection()->getWrappedConnection();
65		- $pdo = $connection->getWrappedConnection();
66		- $pdo->sqliteCreateFunction('md5', 'md5', 1);
67		- }
	55	+ /**
	56	+ * @param ConnectionEventArgs $args
	57	+ * @return void
	58	+ */
	59	+ public function postConnect(ConnectionEventArgs $args) {
	60	+ $sensitive = $this->caseSensitiveLike ? 'true' : 'false';
	61	+ $args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = ' . $sensitive);
	62	+ $args->getConnection()->executeUpdate('PRAGMA journal_mode = ' . $this->journalMode);
	63	+ /** @var \Doctrine\DBAL\Driver\PDO\Connection $connection */
	64	+ $connection = $args->getConnection()->getWrappedConnection();
	65	+ $pdo = $connection->getWrappedConnection();
	66	+ $pdo->sqliteCreateFunction('md5', 'md5', 1);
	67	+ }
68	68
69		- public function getSubscribedEvents() {
70		- return [Events::postConnect];
71		- }
	69	+ public function getSubscribedEvents() {
	70	+ return [Events::postConnect];
	71	+ }
72	72	}

		@@ -35,21 +35,21 @@
		block discarded – undo
35	35	* Auto-generated migration step: Please modify to your needs!
36	36	*/
37	37	class Version21000Date20210119195004 extends SimpleMigrationStep {
38		- /**
39		- * @param IOutput $output
40		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
41		- * @param array $options
42		- * @return null\|ISchemaWrapper
43		- */
44		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
45		- /** @var ISchemaWrapper $schema */
46		- $schema = $schemaClosure();
	38	+ /**
	39	+ * @param IOutput $output
	40	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	41	+ * @param array $options
	42	+ * @return null\|ISchemaWrapper
	43	+ */
	44	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
	45	+ /** @var ISchemaWrapper $schema */
	46	+ $schema = $schemaClosure();
47	47
48		- $table = $schema->getTable('authtoken');
49		- if ($table->hasIndex('authtoken_version_index')) {
50		- $table->dropIndex('authtoken_version_index');
51		- }
	48	+ $table = $schema->getTable('authtoken');
	49	+ if ($table->hasIndex('authtoken_version_index')) {
	50	+ $table->dropIndex('authtoken_version_index');
	51	+ }
52	52
53		- return $schema;
54		- }
	53	+ return $schema;
	54	+ }
55	55	}

nextcloud / server

Push — master ( 90bbef...7a7d0b )

Status

Category

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

Indentation +54 added lines, -54 removed lines patch added patch discarded remove patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

Indentation +37 added lines, -37 removed lines patch added patch discarded remove patch

Indentation +50 added lines, -50 removed lines patch added patch discarded remove patch

Indentation +30 added lines, -30 removed lines patch added patch discarded remove patch

Indentation +34 added lines, -34 removed lines patch added patch discarded remove patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch