nextcloud / server

lib/private/DB/MDB2SchemaReader.php

Spacing +22 added lines, -22 removed lines

@@ -99,7 +99,7 @@ 
 					$this->loadTable($schema, $child);
 					break;
 				default:
-					throw new \DomainException('Unknown element: ' . $child->getName());
+					throw new \DomainException('Unknown element: '.$child->getName());
 
 			}
 		}
@@ -119,13 +119,13 @@ 
 			 */
 			switch ($child->getName()) {
 				case 'name':
-					$name = (string)$child;
+					$name = (string) $child;
 					$name = str_replace('*dbprefix*', $this->DBTABLEPREFIX, $name);
 					$name = $this->platform->quoteIdentifier($name);
 					$table = $schema->createTable($name);
 					$table->setSchemaConfig($this->schemaConfig);
 
-					if($this->platform instanceof MySqlPlatform && $this->config->getSystemValue('mysql.utf8mb4', false)) {
+					if ($this->platform instanceof MySqlPlatform && $this->config->getSystemValue('mysql.utf8mb4', false)) {
 						$table->addOption('charset', 'utf8mb4');
 						$table->addOption('collate', 'utf8mb4_bin');
 						$table->addOption('row_format', 'compressed');
@@ -144,7 +144,7 @@ 
 					$this->loadDeclaration($table, $child);
 					break;
 				default:
-					throw new \DomainException('Unknown element: ' . $child->getName());
+					throw new \DomainException('Unknown element: '.$child->getName());
 
 			}
 		}
@@ -168,7 +168,7 @@ 
 					$this->loadIndex($table, $child);
 					break;
 				default:
-					throw new \DomainException('Unknown element: ' . $child->getName());
+					throw new \DomainException('Unknown element: '.$child->getName());
 
 			}
 		}
@@ -180,18 +180,18 @@ 
 	 * @throws \DomainException
 	 */
 	private function loadField($table, $xml) {
-		$options = array( 'notnull' => false );
+		$options = array('notnull' => false);
 		foreach ($xml->children() as $child) {
 			/**
 			 * @var \SimpleXMLElement $child
 			 */
 			switch ($child->getName()) {
 				case 'name':
-					$name = (string)$child;
+					$name = (string) $child;
 					$name = $this->platform->quoteIdentifier($name);
 					break;
 				case 'type':
-					$type = (string)$child;
+					$type = (string) $child;
 					switch ($type) {
 						case 'text':
 							$type = 'string';
@@ -208,7 +208,7 @@ 
 					}
 					break;
 				case 'length':
-					$length = (string)$child;
+					$length = (string) $child;
 					$options['length'] = $length;
 					break;
 				case 'unsigned':
@@ -224,11 +224,11 @@ 
 					$options['autoincrement'] = $autoincrement;
 					break;
 				case 'default':
-					$default = (string)$child;
+					$default = (string) $child;
 					$options['default'] = $default;
 					break;
 				case 'comments':
-					$comment = (string)$child;
+					$comment = (string) $child;
 					$options['comment'] = $comment;
 					break;
 				case 'primary':
@@ -236,15 +236,15 @@ 
 					$options['primary'] = $primary;
 					break;
 				case 'precision':
-					$precision = (string)$child;
+					$precision = (string) $child;
 					$options['precision'] = $precision;
 					break;
 				case 'scale':
-					$scale = (string)$child;
+					$scale = (string) $child;
 					$options['scale'] = $scale;
 					break;
 				default:
-					throw new \DomainException('Unknown element: ' . $child->getName());
+					throw new \DomainException('Unknown element: '.$child->getName());
 
 			}
 		}
@@ -266,7 +266,7 @@ 
 				}
 			}
 			if ($type === 'integer' && isset($options['default'])) {
-				$options['default'] = (int)$options['default'];
+				$options['default'] = (int) $options['default'];
 			}
 			if ($type === 'integer' && isset($options['length'])) {
 				$length = $options['length'];
@@ -305,7 +305,7 @@ 
 			 */
 			switch ($child->getName()) {
 				case 'name':
-					$name = (string)$child;
+					$name = (string) $child;
 					break;
 				case 'primary':
 					$primary = $this->asBool($child);
@@ -320,20 +320,20 @@ 
 						 */
 						switch ($field->getName()) {
 							case 'name':
-								$field_name = (string)$field;
+								$field_name = (string) $field;
 								$field_name = $this->platform->quoteIdentifier($field_name);
 								$fields[] = $field_name;
 								break;
 							case 'sorting':
 								break;
 							default:
-								throw new \DomainException('Unknown element: ' . $field->getName());
+								throw new \DomainException('Unknown element: '.$field->getName());
 
 						}
 					}
 					break;
 				default:
-					throw new \DomainException('Unknown element: ' . $child->getName());
+					throw new \DomainException('Unknown element: '.$child->getName());
 
 			}
 		}
@@ -351,7 +351,7 @@ 
 				}
 			}
 		} else {
-			throw new \DomainException('Empty index definition: ' . $name . ' options:' . print_r($fields, true));
+			throw new \DomainException('Empty index definition: '.$name.' options:'.print_r($fields, true));
 		}
 	}
 
@@ -360,13 +360,13 @@ 
 	 * @return bool
 	 */
 	private function asBool($xml) {
-		$result = (string)$xml;
+		$result = (string) $xml;
 		if ($result == 'true') {
 			$result = true;
 		} elseif ($result == 'false') {
 			$result = false;
 		}
-		return (bool)$result;
+		return (bool) $result;
 	}
 
 }

lib/private/DB/MDB2SchemaWriter.php

Spacing +8 added lines, -8 removed lines

@@ -43,7 +43,7 @@ 
 		$xml->addChild('name', $config->getSystemValue('dbname', 'owncloud'));
 		$xml->addChild('create', 'true');
 		$xml->addChild('overwrite', 'false');
-		if($config->getSystemValue('dbtype', 'sqlite') === 'mysql' && $config->getSystemValue('mysql.utf8mb4', false)) {
+		if ($config->getSystemValue('dbtype', 'sqlite') === 'mysql' && $config->getSystemValue('mysql.utf8mb4', false)) {
 			$xml->addChild('charset', 'utf8mb4');
 		} else {
 			$xml->addChild('charset', 'utf8');
@@ -51,9 +51,9 @@ 
 
 		// FIX ME: bloody work around
 		if ($config->getSystemValue('dbtype', 'sqlite') === 'oci') {
-			$filterExpression = '/^"' . preg_quote($conn->getPrefix()) . '/';
+			$filterExpression = '/^"'.preg_quote($conn->getPrefix()).'/';
 		} else {
-			$filterExpression = '/^' . preg_quote($conn->getPrefix()) . '/';
+			$filterExpression = '/^'.preg_quote($conn->getPrefix()).'/';
 		}
 		$conn->getConfiguration()->setFilterSchemaAssetsExpression($filterExpression);
 
@@ -71,13 +71,13 @@ 
 	private static function saveTable($table, $xml) {
 		$xml->addChild('name', $table->getName());
 		$declaration = $xml->addChild('declaration');
-		foreach($table->getColumns() as $column) {
+		foreach ($table->getColumns() as $column) {
 			self::saveColumn($column, $declaration->addChild('field'));
 		}
-		foreach($table->getIndexes() as $index) {
+		foreach ($table->getIndexes() as $index) {
 			if ($index->getName() == 'PRIMARY') {
 				$autoincrement = false;
-				foreach($index->getColumns() as $column) {
+				foreach ($index->getColumns() as $column) {
 					if ($table->getColumn($column)->getAutoincrement()) {
 						$autoincrement = true;
 					}
@@ -96,7 +96,7 @@ 
 	 */
 	private static function saveColumn($column, $xml) {
 		$xml->addChild('name', $column->getName());
-		switch($column->getType()) {
+		switch ($column->getType()) {
 			case 'SmallInt':
 			case 'Integer':
 			case 'BigInt':
@@ -169,7 +169,7 @@ 
 		elseif ($index->isUnique()) {
 			$xml->addChild('unique', 'true');
 		}
-		foreach($index->getColumns() as $column) {
+		foreach ($index->getColumns() as $column) {
 			$field = $xml->addChild('field');
 			$field->addChild('name', $column);
 			$field->addChild('sorting', 'ascending');

lib/private/DB/OracleMigrator.php

Spacing +5 added lines, -5 removed lines

@@ -44,7 +44,7 @@ 
 				// auto increment is not relevant for oracle and can anyhow not be applied on change
 				$column->changedProperties = array_diff($column->changedProperties, ['autoincrement', 'unsigned']);
 			}
-			$tableDiff->changedColumns = array_filter($tableDiff->changedColumns, function (ColumnDiff $column) {
+			$tableDiff->changedColumns = array_filter($tableDiff->changedColumns, function(ColumnDiff $column) {
 				return count($column->changedProperties) > 0;
 			});
 		}
@@ -57,7 +57,7 @@ 
 	 * @return string
 	 */
 	protected function generateTemporaryTableName($name) {
-		return 'oc_' . uniqid();
+		return 'oc_'.uniqid();
 	}
 
 	/**
@@ -66,16 +66,16 @@ 
 	 */
 	protected function convertStatementToScript($statement) {
 		if (substr($statement, -1) === ';') {
-			return $statement . PHP_EOL . '/' . PHP_EOL;
+			return $statement.PHP_EOL.'/'.PHP_EOL;
 		}
-		$script = $statement . ';';
+		$script = $statement.';';
 		$script .= PHP_EOL;
 		$script .= PHP_EOL;
 		return $script;
 	}
 
 	protected function getFilterExpression() {
-		return '/^"' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
+		return '/^"'.preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')).'/';
 	}
 
 }

lib/private/DB/Migrator.php

Spacing +11 added lines, -11 removed lines

@@ -137,7 +137,7 @@ 
 	 * @return string
 	 */
 	protected function generateTemporaryTableName($name) {
-		return $this->config->getSystemValue('dbtableprefix', 'oc_') . $name . '_' . $this->random->generate(13, ISecureRandom::CHAR_LOWER . ISecureRandom::CHAR_DIGITS);
+		return $this->config->getSystemValue('dbtableprefix', 'oc_').$name.'_'.$this->random->generate(13, ISecureRandom::CHAR_LOWER.ISecureRandom::CHAR_DIGITS);
 	}
 
 	/**
@@ -188,7 +188,7 @@ 
 				$indexName = $index->getName();
 			} else {
 				// avoid conflicts in index names
-				$indexName = $this->config->getSystemValue('dbtableprefix', 'oc_') . $this->random->generate(13, ISecureRandom::CHAR_LOWER);
+				$indexName = $this->config->getSystemValue('dbtableprefix', 'oc_').$this->random->generate(13, ISecureRandom::CHAR_LOWER);
 			}
 			$newIndexes[] = new Index($indexName, $index->getColumns(), $index->isUnique(), $index->isPrimary());
 		}
@@ -268,15 +268,15 @@ 
 		$quotedSource = $this->connection->quoteIdentifier($sourceName);
 		$quotedTarget = $this->connection->quoteIdentifier($targetName);
 
-		$this->connection->exec('CREATE TABLE ' . $quotedTarget . ' (LIKE ' . $quotedSource . ')');
-		$this->connection->exec('INSERT INTO ' . $quotedTarget . ' SELECT * FROM ' . $quotedSource);
+		$this->connection->exec('CREATE TABLE '.$quotedTarget.' (LIKE '.$quotedSource.')');
+		$this->connection->exec('INSERT INTO '.$quotedTarget.' SELECT * FROM '.$quotedSource);
 	}
 
 	/**
 	 * @param string $name
 	 */
 	protected function dropTable($name) {
-		$this->connection->exec('DROP TABLE ' . $this->connection->quoteIdentifier($name));
+		$this->connection->exec('DROP TABLE '.$this->connection->quoteIdentifier($name));
 	}
 
 	/**
@@ -284,30 +284,30 @@ 
 	 * @return string
 	 */
 	protected function convertStatementToScript($statement) {
-		$script = $statement . ';';
+		$script = $statement.';';
 		$script .= PHP_EOL;
 		$script .= PHP_EOL;
 		return $script;
 	}
 
 	protected function getFilterExpression() {
-		return '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
+		return '/^'.preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')).'/';
 	}
 
 	protected function emit($sql, $step, $max) {
 		if ($this->noEmit) {
 			return;
 		}
-		if(is_null($this->dispatcher)) {
+		if (is_null($this->dispatcher)) {
 			return;
 		}
-		$this->dispatcher->dispatch('\OC\DB\Migrator::executeSql', new GenericEvent($sql, [$step+1, $max]));
+		$this->dispatcher->dispatch('\OC\DB\Migrator::executeSql', new GenericEvent($sql, [$step + 1, $max]));
 	}
 
 	private function emitCheckStep($tableName, $step, $max) {
-		if(is_null($this->dispatcher)) {
+		if (is_null($this->dispatcher)) {
 			return;
 		}
-		$this->dispatcher->dispatch('\OC\DB\Migrator::checkTable', new GenericEvent($tableName, [$step+1, $max]));
+		$this->dispatcher->dispatch('\OC\DB\Migrator::checkTable', new GenericEvent($tableName, [$step + 1, $max]));
 	}
 }

lib/private/DB/SQLiteMigrator.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
 	 * @return string
 	 */
 	private function buildTempDatabase() {
-		$dataDir = $this->config->getSystemValue("datadirectory", \OC::$SERVERROOT . '/data');
+		$dataDir = $this->config->getSystemValue("datadirectory", \OC::$SERVERROOT.'/data');
 		$tmpFile = uniqid("oc_");
 		return "$dataDir/$tmpFile.db";
 	}

lib/private/DB/AdapterPgSql.php

Spacing +2 added lines, -2 removed lines

@@ -31,8 +31,8 @@
 
 	const UNIX_TIMESTAMP_REPLACEMENT = 'cast(extract(epoch from current_timestamp) as integer)';
 	public function fixupStatement($statement) {
-		$statement = str_replace( '`', '"', $statement );
-		$statement = str_ireplace( 'UNIX_TIMESTAMP()', self::UNIX_TIMESTAMP_REPLACEMENT, $statement );
+		$statement = str_replace('`', '"', $statement);
+		$statement = str_ireplace('UNIX_TIMESTAMP()', self::UNIX_TIMESTAMP_REPLACEMENT, $statement);
 		return $statement;
 	}
 }

lib/private/DB/ConnectionFactory.php

Spacing +3 added lines, -3 removed lines

@@ -66,7 +66,7 @@ 
 	);
 
 	public function __construct(IConfig $config) {
-		if($config->getSystemValue('mysql.utf8mb4', false)) {
+		if ($config->getSystemValue('mysql.utf8mb4', false)) {
 			$this->defaultConnectionParams['mysql']['charset'] = 'utf8mb4';
 		}
 	}
@@ -167,8 +167,8 @@ 
 		$name = $config->getValue('dbname', 'owncloud');
 
 		if ($this->normalizeType($type) === 'sqlite3') {
-			$dataDir = $config->getValue("datadirectory", \OC::$SERVERROOT . '/data');
-			$connectionParams['path'] = $dataDir . '/' . $name . '.db';
+			$dataDir = $config->getValue("datadirectory", \OC::$SERVERROOT.'/data');
+			$connectionParams['path'] = $dataDir.'/'.$name.'.db';
 		} else {
 			$host = $config->getValue('dbhost', '');
 			if (strpos($host, ':')) {

lib/private/App/AppStore/Fetcher/AppFetcher.php

Spacing +7 added lines, -7 removed lines

@@ -70,13 +70,13 @@ 
 
 		$ncVersion = $this->config->getSystemValue('version');
 		$ncMajorVersion = explode('.', $ncVersion)[0];
-		foreach($response['data'] as $dataKey => $app) {
+		foreach ($response['data'] as $dataKey => $app) {
 			$releases = [];
 
 			// Filter all compatible releases
-			foreach($app['releases'] as $release) {
+			foreach ($app['releases'] as $release) {
 				// Exclude all nightly and pre-releases
-				if($release['isNightly'] === false
+				if ($release['isNightly'] === false
 					&& strpos($release['version'], '-') === false) {
 					// Exclude all versions not compatible with the current version
 					$versionParser = new VersionParser();
@@ -94,23 +94,23 @@ 
 
 			// Get the highest version
 			$versions = [];
-			foreach($releases as $release) {
+			foreach ($releases as $release) {
 				$versions[] = $release['version'];
 			}
 			usort($versions, 'version_compare');
 			$versions = array_reverse($versions);
 			$compatible = false;
-			if(isset($versions[0])) {
+			if (isset($versions[0])) {
 				$highestVersion = $versions[0];
 				foreach ($releases as $release) {
-					if ((string)$release['version'] === (string)$highestVersion) {
+					if ((string) $release['version'] === (string) $highestVersion) {
 						$compatible = true;
 						$response['data'][$dataKey]['releases'] = [$release];
 						break;
 					}
 				}
 			}
-			if(!$compatible) {
+			if (!$compatible) {
 				unset($response['data'][$dataKey]);
 			}
 		}

lib/private/App/AppStore/Version/VersionParser.php

Spacing +6 added lines, -6 removed lines

@@ -32,7 +32,7 @@ 
 	 * @return bool
 	 */
 	private function isValidVersionString($versionString) {
-		return (bool)preg_match('/^[0-9.]+$/', $versionString);
+		return (bool) preg_match('/^[0-9.]+$/', $versionString);
 	}
 
 	/**
@@ -44,7 +44,7 @@ 
 	 */
 	public function getVersion($versionSpec) {
 		// * indicates that the version is compatible with all versions
-		if($versionSpec === '*') {
+		if ($versionSpec === '*') {
 			return new Version('', '');
 		}
 
@@ -56,18 +56,18 @@ 
 		$secondVersion = isset($versionElements[1]) ? $versionElements[1] : '';
 		$secondVersionNumber = substr($secondVersion, 2);
 
-		switch(count($versionElements)) {
+		switch (count($versionElements)) {
 			case 1:
-				if(!$this->isValidVersionString($firstVersionNumber)) {
+				if (!$this->isValidVersionString($firstVersionNumber)) {
 					break;
 				}
-				if(substr($firstVersion, 0, 1) === '>') {
+				if (substr($firstVersion, 0, 1) === '>') {
 					return new Version($firstVersionNumber, '');
 				} else {
 					return new Version('', $firstVersionNumber);
 				}
 			case 2:
-				if(!$this->isValidVersionString($firstVersionNumber) || !$this->isValidVersionString($secondVersionNumber)) {
+				if (!$this->isValidVersionString($firstVersionNumber) || !$this->isValidVersionString($secondVersionNumber)) {
 					break;
 				}
 				return new Version($firstVersionNumber, $secondVersionNumber);