Completed
Pull Request — master (#9895)
by Björn
168:09 queued 150:46
created
apps/federatedfilesharing/lib/Controller/RequestHandlerController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -450,7 +450,7 @@
 block discarded – undo
450 450
 	/**
451 451
 	 * translate Nextcloud permissions to OCM Permissions
452 452
 	 *
453
-	 * @param $ncPermissions
453
+	 * @param integer $ncPermissions
454 454
 	 * @return array
455 455
 	 */
456 456
 	protected function ncPermissions2ocmPermissions($ncPermissions) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Storage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -407,7 +407,7 @@
 block discarded – undo
407 407
 	/**
408 408
 	 * calculate default permissions in case no permissions are provided
409 409
 	 *
410
-	 * @param $path
410
+	 * @param string $path
411 411
 	 * @return int
412 412
 	 */
413 413
 	protected function getDefaultPermissions($path) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -450,7 +450,7 @@
 block discarded – undo
450 450
 	/**
451 451
 	 * translate Nextcloud permissions to OCM Permissions
452 452
 	 *
453
-	 * @param $ncPermissions
453
+	 * @param integer $ncPermissions
454 454
 	 * @return array
455 455
 	 */
456 456
 	protected function ncPermissions2ocmPermissions($ncPermissions) {
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/ocm/CloudFederationProviderFiles.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 	 * share received from another server
151 151
 	 *
152 152
 	 * @param ICloudFederationShare $share
153
-	 * @return string provider specific unique ID of the share
153
+	 * @return integer provider specific unique ID of the share
154 154
 	 *
155 155
 	 * @throws ProviderCouldNotAddShareException
156 156
 	 * @throws \OCP\AppFramework\QueryException
@@ -325,11 +325,11 @@  discard block
 block discarded – undo
325 325
 	/**
326 326
 	 * notify user about new federated share
327 327
 	 *
328
-	 * @param $shareWith
329
-	 * @param $shareId
330
-	 * @param $ownerFederatedId
331
-	 * @param $sharedByFederatedId
332
-	 * @param $name
328
+	 * @param string $shareWith
329
+	 * @param integer $shareId
330
+	 * @param string $ownerFederatedId
331
+	 * @param string $sharedByFederatedId
332
+	 * @param string $name
333 333
 	 */
334 334
 	private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name) {
335 335
 		$notification = $this->notificationManager->createNotification();
@@ -821,7 +821,7 @@  discard block
 block discarded – undo
821 821
 	/**
822 822
 	 * get the supported share types, e.g. "user", "group", etc.
823 823
 	 *
824
-	 * @return array
824
+	 * @return string[]
825 825
 	 *
826 826
 	 * @since 14.0.0
827 827
 	 */
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Manager.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -210,12 +210,12 @@  discard block
 block discarded – undo
210 210
 	 * @param $password
211 211
 	 * @param $name
212 212
 	 * @param $owner
213
-	 * @param $user
213
+	 * @param string $user
214 214
 	 * @param $mountPoint
215 215
 	 * @param $hash
216
-	 * @param $accepted
216
+	 * @param integer $accepted
217 217
 	 * @param $remoteId
218
-	 * @param $parent
218
+	 * @param integer $parent
219 219
 	 * @param $shareType
220 220
 	 */
221 221
 	private function writeShareToDb($remote, $token, $password, $name, $owner, $user, $mountPoint, $hash, $accepted, $remoteId, $parent, $shareType) {
@@ -408,7 +408,7 @@  discard block
 block discarded – undo
408 408
 	 *
409 409
 	 * @param string $remoteDomain
410 410
 	 * @param string $token
411
-	 * @param $remoteId id of the share
411
+	 * @param integer $remoteId id of the share
412 412
 	 * @param string $feedback
413 413
 	 * @return bool
414 414
 	 */
@@ -505,6 +505,9 @@  discard block
 block discarded – undo
505 505
 		return $result;
506 506
 	}
507 507
 
508
+	/**
509
+	 * @param string $mountPoint
510
+	 */
508 511
 	public function removeShare($mountPoint) {
509 512
 
510 513
 		$mountPointObj = $this->mountManager->find($mountPoint);
Please login to merge, or discard this patch.