nextcloud / server

apps/cloud_federation_api/lib/Controller/RequestHandlerController.php

Braces +1 added lines, -2 removed lines

@@ -247,8 +247,7 @@
 			return new JSONResponse($e->getReturnMessage(), Http::STATUS_BAD_REQUEST);
 		} catch (AuthenticationFailedException $e) {
 			return new JSONResponse(["message" => "RESOURCE_NOT_FOUND"], Http::STATUS_FORBIDDEN);
-		}
-		catch (\Exception $e) {
+		} catch (\Exception $e) {
 			return new JSONResponse(
 				['message' => 'Internal error at ' . $this->urlGenerator->getBaseUrl()],
 				Http::STATUS_BAD_REQUEST

apps/federatedfilesharing/lib/Controller/RequestHandlerController.php

Doc Comments +1 added lines, -1 removed lines

@@ -450,7 +450,7 @@
 	/**
 	 * translate Nextcloud permissions to OCM Permissions
 	 *
-	 * @param $ncPermissions
+	 * @param integer $ncPermissions
 	 * @return array
 	 */
 	protected function ncPermissions2ocmPermissions($ncPermissions) {

apps/files_sharing/lib/External/Storage.php

Doc Comments +1 added lines, -1 removed lines

@@ -407,7 +407,7 @@
 	/**
 	 * calculate default permissions in case no permissions are provided
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return int
 	 */
 	protected function getDefaultPermissions($path) {

apps/dav/lib/Connector/Sabre/FilesPlugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -450,7 +450,7 @@
 	/**
 	 * translate Nextcloud permissions to OCM Permissions
 	 *
-	 * @param $ncPermissions
+	 * @param integer $ncPermissions
 	 * @return array
 	 */
 	protected function ncPermissions2ocmPermissions($ncPermissions) {

apps/federatedfilesharing/templates/settings-admin.php

Braces +24 added lines, -6 removed lines

@@ -18,14 +18,20 @@ 
 
 	<p>
 		<input type="checkbox" name="outgoing_server2server_share_enabled" id="outgoingServer2serverShareEnabled" class="checkbox"
-			   value="1" <?php if ($_['outgoingServer2serverShareEnabled']) print_unescaped('checked="checked"'); ?> />
+			   value="1" <?php if ($_['outgoingServer2serverShareEnabled']) {
+    print_unescaped('checked="checked"');
+}
+?> />
 		<label for="outgoingServer2serverShareEnabled">
 			<?php p($l->t('Allow users on this server to send shares to other servers'));?>
 		</label>
 	</p>
 	<p>
 		<input type="checkbox" name="incoming_server2server_share_enabled" id="incomingServer2serverShareEnabled" class="checkbox"
-			   value="1" <?php if ($_['incomingServer2serverShareEnabled']) print_unescaped('checked="checked"'); ?> />
+			   value="1" <?php if ($_['incomingServer2serverShareEnabled']) {
+    print_unescaped('checked="checked"');
+}
+?> />
 		<label for="incomingServer2serverShareEnabled">
 			<?php p($l->t('Allow users on this server to receive shares from other servers'));?>
 		</label><br/>
@@ -33,14 +39,20 @@ 
 	<?php if($_['federatedGroupSharingSupported']): ?>
 	<p>
 		<input type="checkbox" name="outgoing_server2server_group_share_enabled" id="outgoingServer2serverGroupShareEnabled" class="checkbox"
-			   value="1" <?php if ($_['outgoingServer2serverGroupShareEnabled']) print_unescaped('checked="checked"'); ?> />
+			   value="1" <?php if ($_['outgoingServer2serverGroupShareEnabled']) {
+    print_unescaped('checked="checked"');
+}
+?> />
 		<label for="outgoingServer2serverGroupShareEnabled">
 			<?php p($l->t('Allow users on this server to send shares to groups on other servers'));?>
 		</label>
 	</p>
 	<p>
 		<input type="checkbox" name="incoming_server2server_group_share_enabled" id="incomingServer2serverGroupShareEnabled" class="checkbox"
-			   value="1" <?php if ($_['incomingServer2serverGroupShareEnabled']) print_unescaped('checked="checked"'); ?> />
+			   value="1" <?php if ($_['incomingServer2serverGroupShareEnabled']) {
+    print_unescaped('checked="checked"');
+}
+?> />
 		<label for="incomingServer2serverGroupShareEnabled">
 			<?php p($l->t('Allow users on this server to receive group shares from other servers'));?>
 		</label><br/>
@@ -48,14 +60,20 @@ 
 	<?php endif; ?>
 	<p>
 		<input type="checkbox" name="lookupServerEnabled" id="lookupServerEnabled" class="checkbox"
-			   value="1" <?php if ($_['lookupServerEnabled']) print_unescaped('checked="checked"'); ?> />
+			   value="1" <?php if ($_['lookupServerEnabled']) {
+    print_unescaped('checked="checked"');
+}
+?> />
 		<label for="lookupServerEnabled">
 			<?php p($l->t('Search global and public address book for users'));?>
 		</label><br/>
 	</p>
 	<p>
 		<input type="checkbox" name="lookupServerUploadEnabled" id="lookupServerUploadEnabled" class="checkbox"
-			   value="1" <?php if ($_['lookupServerUploadEnabled']) print_unescaped('checked="checked"'); ?> />
+			   value="1" <?php if ($_['lookupServerUploadEnabled']) {
+    print_unescaped('checked="checked"');
+}
+?> />
 		<label for="lookupServerUploadEnabled">
 			<?php p($l->t('Allow users to publish their data to a global and public address book'));?>
 		</label><br/>

apps/federatedfilesharing/lib/ocm/CloudFederationProviderFiles.php

Doc Comments +7 added lines, -7 removed lines

@@ -150,7 +150,7 @@ 
 	 * share received from another server
 	 *
 	 * @param ICloudFederationShare $share
-	 * @return string provider specific unique ID of the share
+	 * @return integer provider specific unique ID of the share
 	 *
 	 * @throws ProviderCouldNotAddShareException
 	 * @throws \OCP\AppFramework\QueryException
@@ -325,11 +325,11 @@ 
 	/**
 	 * notify user about new federated share
 	 *
-	 * @param $shareWith
-	 * @param $shareId
-	 * @param $ownerFederatedId
-	 * @param $sharedByFederatedId
-	 * @param $name
+	 * @param string $shareWith
+	 * @param integer $shareId
+	 * @param string $ownerFederatedId
+	 * @param string $sharedByFederatedId
+	 * @param string $name
 	 */
 	private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name) {
 		$notification = $this->notificationManager->createNotification();
@@ -821,7 +821,7 @@ 
 	/**
 	 * get the supported share types, e.g. "user", "group", etc.
 	 *
-	 * @return array
+	 * @return string[]
 	 *
 	 * @since 14.0.0
 	 */

apps/files_sharing/lib/External/Manager.php

Doc Comments +7 added lines, -4 removed lines

@@ -210,12 +210,12 @@ 
 	 * @param $password
 	 * @param $name
 	 * @param $owner
-	 * @param $user
+	 * @param string $user
 	 * @param $mountPoint
 	 * @param $hash
-	 * @param $accepted
+	 * @param integer $accepted
 	 * @param $remoteId
-	 * @param $parent
+	 * @param integer $parent
 	 * @param $shareType
 	 */
 	private function writeShareToDb($remote, $token, $password, $name, $owner, $user, $mountPoint, $hash, $accepted, $remoteId, $parent, $shareType) {
@@ -408,7 +408,7 @@ 
 	 *
 	 * @param string $remoteDomain
 	 * @param string $token
-	 * @param $remoteId id of the share
+	 * @param integer $remoteId id of the share
 	 * @param string $feedback
 	 * @return bool
 	 */
@@ -505,6 +505,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param string $mountPoint
+	 */
 	public function removeShare($mountPoint) {
 
 		$mountPointObj = $this->mountManager->find($mountPoint);