nextcloud / server

apps/files/lib/Activity/Provider.php

Doc Comments +6 added lines

@@ -112,6 +112,9 @@ 
 		return $this->parseLongVersion($event, $previousEvent);
 	}
 
+	/**
+	 * @param string $icon
+	 */
 	protected function setIcon(IEvent $event, $icon) {
 		if ($this->activityManager->getRequirePNG()) {
 			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', $icon . '.png')));
@@ -252,6 +255,9 @@ 
 		return $event;
 	}
 
+	/**
+	 * @param string $subject
+	 */
 	protected function setSubjects(IEvent $event, $subject, array $parameters) {
 		$placeholders = $replacements = [];
 		foreach ($parameters as $placeholder => $parameter) {

apps/files_external/lib/Lib/Storage/Swift.php

Doc Comments +4 added lines, -1 removed lines

@@ -83,7 +83,7 @@ 
 
 	/**
 	 * @param string $path
-	 * @return mixed|string
+	 * @return string
 	 */
 	private function normalizePath(string $path) {
 		$path = trim($path, '/');
@@ -570,6 +570,9 @@ 
 		return $this->container;
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public function writeBack($tmpFile, $path) {
 		$fileData = fopen($tmpFile, 'r');
 		$this->objectStore->writeObject($path, $fileData);

lib/private/legacy/app.php

Doc Comments +1 added lines, -1 removed lines

@@ -269,7 +269,7 @@
 	 * check if an app is of a specific type
 	 *
 	 * @param string $app
-	 * @param array $types
+	 * @param string[] $types
 	 * @return bool
 	 */
 	public static function isType(string $app, array $types): bool {

lib/private/AppFramework/Utility/ControllerMethodReflector.php

Doc Comments +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 	private $parameters = [];
 
 	/**
-	 * @param object $object an object or classname
+	 * @param \OCP\AppFramework\Controller $object an object or classname
 	 * @param string $method the method which we want to inspect
 	 */
 	public function reflect($object, string $method){

apps/theming/lib/ThemingDefaults.php

Doc Comments +1 added lines, -1 removed lines

@@ -261,7 +261,7 @@
 	 *
 	 * @param string $app name of the app
 	 * @param string $image filename of the image
-	 * @return bool|string false if image should not replaced, otherwise the location of the image
+	 * @return string|false false if image should not replaced, otherwise the location of the image
 	 */
 	public function replaceImagePath($app, $image) {
 		if($app==='') {

lib/private/Session/Internal.php

Doc Comments +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
 	 * @param array $parameters
 	 * @param bool $silence whether to suppress warnings
 	 * @throws \ErrorException via trapError
-	 * @return mixed
+	 * @return string
 	 */
 	private function invoke(string $functionName, array $parameters = [], bool $silence = false) {
 		try {

apps/user_ldap/lib/Access.php

Doc Comments +6 added lines, -5 removed lines

@@ -506,7 +506,7 @@ 
 
 	/**
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @return string|false with with the name to use in Nextcloud
 	 */
@@ -805,7 +805,7 @@ 
 	 * the login filter.
 	 *
 	 * @param string $loginName
-	 * @param array $attributes optional, list of attributes to read
+	 * @param string[] $attributes optional, list of attributes to read
 	 * @return array
 	 */
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -889,7 +889,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return array
@@ -937,7 +937,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return false|int
@@ -1036,7 +1036,7 @@ 
 	/**
 	 * retrieved. Results will according to the order in the array.
 	 *
-	 * @param $filter
+	 * @param string $filter
 	 * @param $base
 	 * @param string[]|string|null $attr
 	 * @param int $limit optional, maximum results to be counted
@@ -1331,6 +1331,7 @@ 
 	* escapes (user provided) parts for LDAP filter
 	* @param string $input, the provided value
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
+	* @param string $input
 	* @return string the escaped string
 	*/
 	public function escapeFilterPart($input, $allowAsterisk = false) {

lib/public/Mail/IEMailTemplate.php

Doc Comments +8 added lines

@@ -62,6 +62,7 @@ 
 	 * @param string $subject
 	 *
 	 * @since 13.0.0
+	 * @return void
 	 */
 	public function setSubject(string $subject);
 
@@ -69,6 +70,7 @@ 
 	 * Adds a header to the email
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addHeader();
 
@@ -80,6 +82,7 @@ 
 	 *   if empty the $title is used, if false none will be used
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addHeading(string $title, $plainTitle = '');
 
@@ -91,6 +94,7 @@ 
 	 *   if empty the $text is used, if false none will be used
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addBodyText(string $text, $plainText = '');
 
@@ -105,6 +109,7 @@ 
 	 * @param string|bool $plainMetaInfo Meta info that is used in the plain text email
 	 *   if empty the $metaInfo is used, if false none will be used
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addBodyListItem(string $text, string $metaInfo = '', string $icon = '', $plainText = '', $plainMetaInfo = '');
 
@@ -119,6 +124,7 @@ 
 	 * @param string $plainTextRight Text of right button that is used in the plain text version - if empty the $textRight is used
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addBodyButtonGroup(string $textLeft, string $urlLeft, string $textRight, string $urlRight, string $plainTextLeft = '', string $plainTextRight = '');
 
@@ -131,6 +137,7 @@ 
 	 * 		if empty the $text is used, if false none will be used
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addBodyButton(string $text, string $url, $plainText = '');
 
@@ -140,6 +147,7 @@ 
 	 * @param string $text If the text is empty the default "Name - Slogan<br>This is an automatically sent email" will be used
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addFooter(string $text = '');
 

settings/Controller/CommonSettingsTrait.php

Doc Comments +13 added lines

@@ -56,6 +56,9 @@ 
 		];
 	}
 
+	/**
+	 * @param string $type
+	 */
 	protected function formatSections($sections, $currentSection, $type, $currentType) {
 		$templateParameters = [];
 		/** @var \OCP\Settings\ISection[] $prioritizedSections */
@@ -89,6 +92,9 @@ 
 		return $templateParameters;
 	}
 
+	/**
+	 * @param string $currentSections
+	 */
 	protected function formatPersonalSections($currentType, $currentSections) {
 		$sections = $this->settingsManager->getPersonalSections();
 		$templateParameters = $this->formatSections($sections, $currentSections, 'personal', $currentType);
@@ -96,6 +102,9 @@ 
 		return $templateParameters;
 	}
 
+	/**
+	 * @param string $currentSections
+	 */
 	protected function formatAdminSections($currentType, $currentSections) {
 		$sections = $this->settingsManager->getAdminSections();
 		$templateParameters = $this->formatSections($sections, $currentSections, 'admin', $currentType);
@@ -119,6 +128,10 @@ 
 		return ['content' => $html];
 	}
 
+	/**
+	 * @param string $type
+	 * @param string $section
+	 */
 	private function getIndexResponse($type, $section) {
 		$this->navigationManager->setActiveEntry('settings');
 		$templateParams = [];