Completed
Pull Request — master (#9895)
by Björn
168:09 queued 150:46
created
apps/dav/lib/Upload/ChunkingPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
 	 *
68 68
 	 * @param string $path source path
69 69
 	 * @param string $destination destination path
70
-	 * @return bool|void false to stop handling, void to skip this handler
70
+	 * @return null|false false to stop handling, void to skip this handler
71 71
 	 */
72 72
 	public function performMove($path, $destination) {
73 73
 		if (!$this->server->tree->nodeExists($destination)) {
Please login to merge, or discard this patch.
lib/private/Files/ObjectStore/S3Signature.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -119,6 +119,9 @@
 block discarded – undo
119 119
 		return Psr7\modify_request($request, $modify);
120 120
 	}
121 121
 
122
+	/**
123
+	 * @param string $string
124
+	 */
122 125
 	private function signString($string, CredentialsInterface $credentials)
123 126
 	{
124 127
 		return base64_encode(
Please login to merge, or discard this patch.
lib/private/Files/Cache/QuerySearchHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@
 block discarded – undo
85 85
 
86 86
 	/**
87 87
 	 * @param IQueryBuilder $builder
88
-	 * @param ISearchOperator $operator
88
+	 * @param ISearchOperator $operators
89 89
 	 */
90 90
 	public function searchOperatorArrayToDBExprArray(IQueryBuilder $builder, array $operators) {
91 91
 		return array_map(function ($operator) use ($builder) {
Please login to merge, or discard this patch.
lib/private/legacy/image.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -299,7 +299,7 @@
 block discarded – undo
299 299
 	}
300 300
 
301 301
 	/**
302
-	 * @param resource Returns the image resource in any.
302
+	 * @param resource resource the image resource in any.
303 303
 	 * @throws \InvalidArgumentException in case the supplied resource does not have the type "gd"
304 304
 	 */
305 305
 	public function setResource($resource) {
Please login to merge, or discard this patch.
lib/private/AppConfig.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@
 block discarded – undo
160 160
 	 *
161 161
 	 * @param string $app app
162 162
 	 * @param string $key key
163
-	 * @param string|float|int $value value
163
+	 * @param string $value value
164 164
 	 * @return bool True if the value was inserted or updated, false if the value was the same
165 165
 	 */
166 166
 	public function setValue($app, $key, $value) {
Please login to merge, or discard this patch.
lib/private/User/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -193,7 +193,7 @@
 block discarded – undo
193 193
 	 * @internal
194 194
 	 * @param string $loginName
195 195
 	 * @param string $password
196
-	 * @return mixed the User object on success, false otherwise
196
+	 * @return IUser the User object on success, false otherwise
197 197
 	 */
198 198
 	public function checkPasswordNoLogging($loginName, $password) {
199 199
 		$loginName = str_replace("\0", '', $loginName);
Please login to merge, or discard this patch.
lib/private/User/Session.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
 	 * @param IUser $user
340 340
 	 * @param array $loginDetails
341 341
 	 * @param bool $regenerateSessionId
342
-	 * @return true returns true if login successful or an exception otherwise
342
+	 * @return boolean returns true if login successful or an exception otherwise
343 343
 	 * @throws LoginException
344 344
 	 */
345 345
 	public function completeLogin(IUser $user, array $loginDetails, $regenerateSessionId = true) {
@@ -446,6 +446,9 @@  discard block
 block discarded – undo
446 446
 		return $this->config->getSystemValue('token_auth_enforced', false);
447 447
 	}
448 448
 
449
+	/**
450
+	 * @param string $username
451
+	 */
449 452
 	protected function isTwoFactorEnforced($username) {
450 453
 		Util::emitHook(
451 454
 			'\OCA\Files_Sharing\API\Server2Server',
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/AmazonS3.php 1 patch
Doc Comments   +10 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,6 +85,9 @@  discard block
 block discarded – undo
85 85
 		return $path === '.';
86 86
 	}
87 87
 
88
+	/**
89
+	 * @param string $path
90
+	 */
88 91
 	private function cleanKey($path) {
89 92
 		if ($this->isRoot($path)) {
90 93
 			return '/';
@@ -108,7 +111,7 @@  discard block
 block discarded – undo
108 111
 	}
109 112
 
110 113
 	/**
111
-	 * @param $key
114
+	 * @param string $key
112 115
 	 * @return Result|boolean
113 116
 	 */
114 117
 	private function headObject($key) {
@@ -234,6 +237,9 @@  discard block
 block discarded – undo
234 237
 		}
235 238
 	}
236 239
 
240
+	/**
241
+	 * @param string $path
242
+	 */
237 243
 	private function batchDelete($path = null) {
238 244
 		$params = array(
239 245
 			'Bucket' => $this->bucket
@@ -579,6 +585,9 @@  discard block
 block discarded – undo
579 585
 		return $this->id;
580 586
 	}
581 587
 
588
+	/**
589
+	 * @param string $path
590
+	 */
582 591
 	public function writeBack($tmpFile, $path) {
583 592
 		try {
584 593
 			$source = fopen($tmpFile, 'r');
Please login to merge, or discard this patch.
lib/private/Comments/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -213,7 +213,7 @@
 block discarded – undo
213 213
 	/**
214 214
 	 * removes an entry from the comments run time cache
215 215
 	 *
216
-	 * @param mixed $id the comment's id
216
+	 * @param string $id the comment's id
217 217
 	 */
218 218
 	protected function uncache($id) {
219 219
 		$id = (string)$id;
Please login to merge, or discard this patch.