nextcloud / server

apps/cloud_federation_api/lib/Controller/RequestHandlerController.php

Spacing +14 added lines, -14 removed lines

@@ -130,7 +130,7 @@ 
 		$supportedShareTypes = $this->config->getSupportedShareTypes($resourceType);
 		if (!in_array($shareType, $supportedShareTypes)) {
 			return new JSONResponse(
-				['message' => 'Share type "' . $shareType . '" not implemented'],
+				['message' => 'Share type "'.$shareType.'" not implemented'],
 				Http::STATUS_NOT_IMPLEMENTED
 			);
 		}
@@ -144,7 +144,7 @@ 
 			if (!$this->userManager->userExists($shareWith)) {
 				$response = new JSONResponse(
 					[
-						'message' => 'User "' . $shareWith . '" does not exists at ' . $this->urlGenerator->getBaseUrl(),
+						'message' => 'User "'.$shareWith.'" does not exists at '.$this->urlGenerator->getBaseUrl(),
 						'validationErrors' => [],
 					],
 					Http::STATUS_BAD_REQUEST
@@ -158,7 +158,7 @@ 
 			if (!$this->groupManager->groupExists($shareWith)) {
 				$response = new JSONResponse(
 					[
-						'message' => 'Group "' . $shareWith . '" does not exists at ' . $this->urlGenerator->getBaseUrl(),
+						'message' => 'Group "'.$shareWith.'" does not exists at '.$this->urlGenerator->getBaseUrl(),
 						'validationErrors' => [],
 					],
 					Http::STATUS_BAD_REQUEST
@@ -183,7 +183,7 @@ 
 			$share = $this->factory->getCloudFederationShare($shareWith, $name, $description, $providerId, $owner, $ownerDisplayName, $sharedBy, $sharedByDisplayName, '', $shareType, $resourceType);
 			$share->setProtocol($protocol);
 			$provider->shareReceived($share);
-		} catch (ProviderDoesNotExistsException|ProviderCouldNotAddShareException $e) {
+		} catch (ProviderDoesNotExistsException | ProviderCouldNotAddShareException $e) {
 			return new JSONResponse(
 				['message' => $e->getMessage()],
 				Http::STATUS_NOT_IMPLEMENTED
@@ -192,7 +192,7 @@ 
 			$this->logger->error($e->getMessage(), ['exception' => $e]);
 			return new JSONResponse(
 				[
-					'message' => 'Internal error at ' . $this->urlGenerator->getBaseUrl(),
+					'message' => 'Internal error at '.$this->urlGenerator->getBaseUrl(),
 					'validationErrors' => [],
 				],
 				Http::STATUS_BAD_REQUEST
@@ -293,7 +293,7 @@ 
 			$this->logger->warning('incoming notification exception', ['exception' => $e]);
 			return new JSONResponse(
 				[
-					'message' => 'Internal error at ' . $this->urlGenerator->getBaseUrl(),
+					'message' => 'Internal error at '.$this->urlGenerator->getBaseUrl(),
 					'validationErrors' => [],
 				],
 				Http::STATUS_BAD_REQUEST
@@ -311,13 +311,13 @@ 
 	 */
 	private function mapUid($uid) {
 		// FIXME this should be a method in the user management instead
-		$this->logger->debug('shareWith before, ' . $uid, ['app' => $this->appName]);
+		$this->logger->debug('shareWith before, '.$uid, ['app' => $this->appName]);
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',
 			'preLoginNameUsedAsUserName',
 			['uid' => &$uid]
 		);
-		$this->logger->debug('shareWith after, ' . $uid, ['app' => $this->appName]);
+		$this->logger->debug('shareWith after, '.$uid, ['app' => $this->appName]);
 
 		return $uid;
 	}
@@ -337,7 +337,7 @@ 
 			$signedRequest = $this->signatureManager->getIncomingSignedRequest($this->signatoryManager);
 			$this->logger->debug('signed request available', ['signedRequest' => $signedRequest]);
 			return $signedRequest;
-		} catch (SignatureNotFoundException|SignatoryNotFoundException $e) {
+		} catch (SignatureNotFoundException | SignatoryNotFoundException $e) {
 			$this->logger->debug('remote does not support signed request', ['exception' => $e]);
 			// remote does not support signed request.
 			// currently we still accept unsigned request until lazy appconfig
@@ -381,7 +381,7 @@ 
 		$body = json_decode($signedRequest->getBody(), true) ?? [];
 		$entry = trim($body[$key] ?? '', '@');
 		if ($this->getHostFromFederationId($entry) !== $signedRequest->getOrigin()) {
-			throw new IncomingRequestException('share initiation (' . $signedRequest->getOrigin() . ') from different instance (' . $entry . ') [key=' . $key . ']');
+			throw new IncomingRequestException('share initiation ('.$signedRequest->getOrigin().') from different instance ('.$entry.') [key='.$key.']');
 		}
 	}
 
@@ -441,7 +441,7 @@ 
 				return;
 			}
 		} elseif ($instance !== $signedRequest->getOrigin()) {
-			throw new IncomingRequestException('remote instance ' . $instance . ' not linked to origin ' . $signedRequest->getOrigin());
+			throw new IncomingRequestException('remote instance '.$instance.' not linked to origin '.$signedRequest->getOrigin());
 		}
 	}
 
@@ -452,16 +452,16 @@ 
 	 */
 	private function getHostFromFederationId(string $entry): string {
 		if (!str_contains($entry, '@')) {
-			throw new IncomingRequestException('entry ' . $entry . ' does not contain @');
+			throw new IncomingRequestException('entry '.$entry.' does not contain @');
 		}
 		$rightPart = substr($entry, strrpos($entry, '@') + 1);
 
 		// in case the full scheme is sent; getting rid of it
 		$rightPart = $this->addressHandler->removeProtocolFromUrl($rightPart);
 		try {
-			return $this->signatureManager->extractIdentityFromUri('https://' . $rightPart);
+			return $this->signatureManager->extractIdentityFromUri('https://'.$rightPart);
 		} catch (IdentityNotFoundException) {
-			throw new IncomingRequestException('invalid host within federation id: ' . $entry);
+			throw new IncomingRequestException('invalid host within federation id: '.$entry);
 		}
 	}
 }