nextcloud / server

lib/private/User/Session.php

Doc Comments +5 added lines, -2 removed lines

@@ -329,7 +329,7 @@ 
 	 * @param IUser $user
 	 * @param array $loginDetails
 	 * @param bool $regenerateSessionId
-	 * @return true returns true if login successful or an exception otherwise
+	 * @return boolean returns true if login successful or an exception otherwise
 	 * @throws LoginException
 	 */
 	public function completeLogin(IUser $user, array $loginDetails, $regenerateSessionId = true) {
@@ -377,7 +377,7 @@ 
 	 * @param OC\Security\Bruteforce\Throttler $throttler
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user,
 								$password,
@@ -431,6 +431,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',

apps/sharebymail/lib/ShareByMailProvider.php

Doc Comments +5 added lines, -4 removed lines

@@ -276,10 +276,10 @@ 
 	 * publish activity if a file/folder was shared by mail
 	 *
 	 * @param $subject
-	 * @param $parameters
-	 * @param $affectedUser
+	 * @param string[] $parameters
+	 * @param string $affectedUser
 	 * @param $fileId
-	 * @param $filePath
+	 * @param string $filePath
 	 */
 	protected function publishActivity($subject, $parameters, $affectedUser, $fileId, $filePath) {
 		$event = $this->activityManager->generateEvent();
@@ -557,6 +557,7 @@ 
 	 * @param string $uidOwner
 	 * @param int $permissions
 	 * @param string $token
+	 * @param string $password
 	 * @return int
 	 */
 	protected function addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $uidOwner, $permissions, $token, $password) {
@@ -950,7 +951,7 @@ 
 	/**
 	 * get database row of a give share
 	 *
-	 * @param $id
+	 * @param integer $id
 	 * @return array
 	 * @throws ShareNotFound
 	 */

lib/private/BackgroundJob/JobList.php

Doc Comments +1 added lines, -1 removed lines

@@ -320,7 +320,7 @@
 
 	/**
 	 * @param IJob $job
-	 * @param $timeTaken
+	 * @param integer $timeTaken
 	 */
 	public function setExecutionTime(IJob $job, $timeTaken) {
 		$query = $this->connection->getQueryBuilder();

lib/private/Updater.php

Doc Comments +1 added lines, -1 removed lines

@@ -431,7 +431,7 @@
 	}
 
 	/**
-	 * @param array $disabledApps
+	 * @param string[] $disabledApps
 	 * @throws \Exception
 	 */
 	private function upgradeAppStoreApps(array $disabledApps) {

lib/private/Diagnostics/Query.php

Doc Comments +4 added lines, -1 removed lines

@@ -48,6 +48,9 @@ 
 		$this->stack = $stack;
 	}
 
+	/**
+	 * @param double $time
+	 */
 	public function end($time) {
 		$this->end = $time;
 	}
@@ -67,7 +70,7 @@ 
 	}
 
 	/**
-	 * @return float
+	 * @return integer
 	 */
 	public function getStart() {
 		return $this->start;

apps/dav/lib/Connector/Sabre/FilesPlugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -448,7 +448,7 @@
 	 *
 	 * @param string $path source path
 	 * @param string $destination destination path
-	 * @return bool|void false to stop handling, void to skip this handler
+	 * @return null|false false to stop handling, void to skip this handler
 	 */
 	public function beforeMoveFutureFile($path, $destination) {
 		$sourceNode = $this->tree->getNodeForPath($path);

apps/theming/lib/Util.php

Doc Comments +4 added lines, -4 removed lines

@@ -71,7 +71,7 @@ 
 	/**
 	 * get color for on-page elements:
 	 * theme color by default, grey if theme color is to bright
-	 * @param $color
+	 * @param string $color
 	 * @return string
 	 */
 	public function elementColor($color) {
@@ -114,7 +114,7 @@ 
 
 	/**
 	 * @param $app string app name
-	 * @return string|ISimpleFile path to app icon / file of logo
+	 * @return string path to app icon / file of logo
 	 */
 	public function getAppIcon($app) {
 		$app = str_replace(array('\0', '/', '\\', '..'), '', $app);
@@ -190,8 +190,8 @@ 
 	/**
 	 * replace default color with a custom one
 	 *
-	 * @param $svg string content of a svg file
-	 * @param $color string color to match
+	 * @param string $svg string content of a svg file
+	 * @param string $color string color to match
 	 * @return string
 	 */
 	public function colorizeSvg($svg, $color) {

lib/private/Settings/Manager.php

Doc Comments +6 added lines

@@ -265,6 +265,9 @@ 
 		return $this->mapper->has($table, $className);
 	}
 
+	/**
+	 * @param string $type
+	 */
 	private function setupSettingsEntry($settingsClassName, $type) {
 		if (!class_exists($settingsClassName)) {
 			$this->log->debug('Could not find ' . $type . ' section class ' . $settingsClassName);
@@ -294,6 +297,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $type
+	 */
 	private function getSectionTableForType($type) {
 		if($type === 'admin') {
 			return Mapper::TABLE_ADMIN_SECTIONS;

apps/user_ldap/lib/Access.php

Doc Comments +8 added lines, -6 removed lines

@@ -491,7 +491,7 @@ 
 
 	/**
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @return string|false with with the name to use in Nextcloud
 	 */
@@ -508,7 +508,7 @@ 
 
 	/**
 	 * returns an internal Nextcloud name for the given LDAP DN, false on DN outside of search DN
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
 	 * @return string|false with with the name to use in Nextcloud
@@ -771,7 +771,7 @@ 
 	 * the login filter.
 	 *
 	 * @param string $loginName
-	 * @param array $attributes optional, list of attributes to read
+	 * @param string[] $attributes optional, list of attributes to read
 	 * @return array
 	 */
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -844,7 +844,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return array
@@ -892,7 +892,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return false|int
@@ -989,6 +989,7 @@ 
 	 * retrieved. Results will according to the order in the array.
 	 * @param int $limit optional, maximum results to be counted
 	 * @param int $offset optional, a starting point
+	 * @param string $filter
 	 * @return array|false array with the search result as first value and pagedSearchOK as
 	 * second | false if not successful
 	 * @throws \OC\ServerNotAvailableException
@@ -1240,7 +1241,7 @@ 
 
 	/**
 	 * @param string $name
-	 * @return bool|mixed|string
+	 * @return string
 	 */
 	public function sanitizeUsername($name) {
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1264,6 +1265,7 @@ 
 	* escapes (user provided) parts for LDAP filter
 	* @param string $input, the provided value
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
+	* @param string $input
 	* @return string the escaped string
 	*/
 	public function escapeFilterPart($input, $allowAsterisk = false) {