nextcloud / server

lib/private/Activity/LegacySetting.php

Indentation +86 added lines, -86 removed lines

@@ -25,99 +25,99 @@
 
 class LegacySetting implements ISetting {
 
-	/** @var string */
-	protected $identifier;
-	/** @var string */
-	protected $name;
-	/** @var bool */
-	protected $canChangeStream;
-	/** @var bool */
-	protected $isDefaultEnabledStream;
-	/** @var bool */
-	protected $canChangeMail;
-	/** @var bool */
-	protected $isDefaultEnabledMail;
+    /** @var string */
+    protected $identifier;
+    /** @var string */
+    protected $name;
+    /** @var bool */
+    protected $canChangeStream;
+    /** @var bool */
+    protected $isDefaultEnabledStream;
+    /** @var bool */
+    protected $canChangeMail;
+    /** @var bool */
+    protected $isDefaultEnabledMail;
 
-	/**
-	 * LegacySetting constructor.
-	 *
-	 * @param string $identifier
-	 * @param string $name
-	 * @param bool $canChangeStream
-	 * @param bool $isDefaultEnabledStream
-	 * @param bool $canChangeMail
-	 * @param bool $isDefaultEnabledMail
-	 */
-	public function __construct($identifier,
-								$name,
-								$canChangeStream,
-								$isDefaultEnabledStream,
-								$canChangeMail,
-								$isDefaultEnabledMail) {
-		$this->identifier = $identifier;
-		$this->name = $name;
-		$this->canChangeStream = $canChangeStream;
-		$this->isDefaultEnabledStream = $isDefaultEnabledStream;
-		$this->canChangeMail = $canChangeMail;
-		$this->isDefaultEnabledMail = $isDefaultEnabledMail;
-	}
+    /**
+     * LegacySetting constructor.
+     *
+     * @param string $identifier
+     * @param string $name
+     * @param bool $canChangeStream
+     * @param bool $isDefaultEnabledStream
+     * @param bool $canChangeMail
+     * @param bool $isDefaultEnabledMail
+     */
+    public function __construct($identifier,
+                                $name,
+                                $canChangeStream,
+                                $isDefaultEnabledStream,
+                                $canChangeMail,
+                                $isDefaultEnabledMail) {
+        $this->identifier = $identifier;
+        $this->name = $name;
+        $this->canChangeStream = $canChangeStream;
+        $this->isDefaultEnabledStream = $isDefaultEnabledStream;
+        $this->canChangeMail = $canChangeMail;
+        $this->isDefaultEnabledMail = $isDefaultEnabledMail;
+    }
 
-	/**
-	 * @return string Lowercase a-z and underscore only identifier
-	 * @since 11.0.0
-	 */
-	public function getIdentifier() {
-		return $this->identifier;
-	}
+    /**
+     * @return string Lowercase a-z and underscore only identifier
+     * @since 11.0.0
+     */
+    public function getIdentifier() {
+        return $this->identifier;
+    }
 
-	/**
-	 * @return string A translated string
-	 * @since 11.0.0
-	 */
-	public function getName() {
-		return $this->name;
-	}
+    /**
+     * @return string A translated string
+     * @since 11.0.0
+     */
+    public function getName() {
+        return $this->name;
+    }
 
-	/**
-	 * @return int whether the filter should be rather on the top or bottom of
-	 * the admin section. The filters are arranged in ascending order of the
-	 * priority values. It is required to return a value between 0 and 100.
-	 * @since 11.0.0
-	 */
-	public function getPriority() {
-		return 70;
-	}
+    /**
+     * @return int whether the filter should be rather on the top or bottom of
+     * the admin section. The filters are arranged in ascending order of the
+     * priority values. It is required to return a value between 0 and 100.
+     * @since 11.0.0
+     */
+    public function getPriority() {
+        return 70;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function canChangeStream() {
-		return $this->canChangeStream;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function canChangeStream() {
+        return $this->canChangeStream;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function isDefaultEnabledStream() {
-		return $this->isDefaultEnabledStream;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function isDefaultEnabledStream() {
+        return $this->isDefaultEnabledStream;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the mail
-	 * @since 11.0.0
-	 */
-	public function canChangeMail() {
-		return $this->canChangeMail;
-	}
+    /**
+     * @return bool True when the option can be changed for the mail
+     * @since 11.0.0
+     */
+    public function canChangeMail() {
+        return $this->canChangeMail;
+    }
 
-	/**
-	 * @return bool True when the option can be changed for the stream
-	 * @since 11.0.0
-	 */
-	public function isDefaultEnabledMail() {
-		return $this->isDefaultEnabledMail;
-	}
+    /**
+     * @return bool True when the option can be changed for the stream
+     * @since 11.0.0
+     */
+    public function isDefaultEnabledMail() {
+        return $this->isDefaultEnabledMail;
+    }
 }
 

lib/private/Security/CSP/ContentSecurityPolicyNonceManager.php

Indentation +42 added lines, -42 removed lines

@@ -29,52 +29,52 @@
  * @package OC\Security\CSP
  */
 class ContentSecurityPolicyNonceManager {
-	/** @var CsrfTokenManager */
-	private $csrfTokenManager;
-	/** @var IRequest */
-	private $request;
-	/** @var string */
-	private $nonce = '';
+    /** @var CsrfTokenManager */
+    private $csrfTokenManager;
+    /** @var IRequest */
+    private $request;
+    /** @var string */
+    private $nonce = '';
 
-	/**
-	 * @param CsrfTokenManager $csrfTokenManager
-	 * @param IRequest $request
-	 */
-	public function __construct(CsrfTokenManager $csrfTokenManager,
-								IRequest $request) {
-		$this->csrfTokenManager = $csrfTokenManager;
-		$this->request = $request;
-	}
+    /**
+     * @param CsrfTokenManager $csrfTokenManager
+     * @param IRequest $request
+     */
+    public function __construct(CsrfTokenManager $csrfTokenManager,
+                                IRequest $request) {
+        $this->csrfTokenManager = $csrfTokenManager;
+        $this->request = $request;
+    }
 
-	/**
-	 * Returns the current CSP nounce
-	 *
-	 * @return string
-	 */
-	public function getNonce() {
-		if($this->nonce === '') {
-			$this->nonce = base64_encode($this->csrfTokenManager->getToken()->getEncryptedValue());
-		}
+    /**
+     * Returns the current CSP nounce
+     *
+     * @return string
+     */
+    public function getNonce() {
+        if($this->nonce === '') {
+            $this->nonce = base64_encode($this->csrfTokenManager->getToken()->getEncryptedValue());
+        }
 
-		return $this->nonce;
-	}
+        return $this->nonce;
+    }
 
-	/**
-	 * Check if the browser supports CSP v3
-	 *
-	 * @return bool
-	 */
-	public function browserSupportsCspV3() {
-		$browserWhitelist = [
-			Request::USER_AGENT_CHROME,
-			// Firefox 45+
-			'/^Mozilla\/5\.0 \([^)]+\) Gecko\/[0-9.]+ Firefox\/(4[5-9]|[5-9][0-9])\.[0-9.]+$/',
-		];
+    /**
+     * Check if the browser supports CSP v3
+     *
+     * @return bool
+     */
+    public function browserSupportsCspV3() {
+        $browserWhitelist = [
+            Request::USER_AGENT_CHROME,
+            // Firefox 45+
+            '/^Mozilla\/5\.0 \([^)]+\) Gecko\/[0-9.]+ Firefox\/(4[5-9]|[5-9][0-9])\.[0-9.]+$/',
+        ];
 
-		if($this->request->isUserAgent($browserWhitelist)) {
-			return true;
-		}
+        if($this->request->isUserAgent($browserWhitelist)) {
+            return true;
+        }
 
-		return false;
-	}
+        return false;
+    }
 }

lib/private/Security/CSP/ContentSecurityPolicy.php

Indentation +167 added lines, -167 removed lines

@@ -29,172 +29,172 @@
  * @package OC\Security\CSP
  */
 class ContentSecurityPolicy extends \OCP\AppFramework\Http\ContentSecurityPolicy {
-	/**
-	 * @return boolean
-	 */
-	public function isInlineScriptAllowed() {
-		return $this->inlineScriptAllowed;
-	}
-
-	/**
-	 * @param boolean $inlineScriptAllowed
-	 */
-	public function setInlineScriptAllowed($inlineScriptAllowed) {
-		$this->inlineScriptAllowed = $inlineScriptAllowed;
-	}
-
-	/**
-	 * @return boolean
-	 */
-	public function isEvalScriptAllowed() {
-		return $this->evalScriptAllowed;
-	}
-
-	/**
-	 * @param boolean $evalScriptAllowed
-	 */
-	public function setEvalScriptAllowed($evalScriptAllowed) {
-		$this->evalScriptAllowed = $evalScriptAllowed;
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getAllowedScriptDomains() {
-		return $this->allowedScriptDomains;
-	}
-
-	/**
-	 * @param array $allowedScriptDomains
-	 */
-	public function setAllowedScriptDomains($allowedScriptDomains) {
-		$this->allowedScriptDomains = $allowedScriptDomains;
-	}
-
-	/**
-	 * @return boolean
-	 */
-	public function isInlineStyleAllowed() {
-		return $this->inlineStyleAllowed;
-	}
-
-	/**
-	 * @param boolean $inlineStyleAllowed
-	 */
-	public function setInlineStyleAllowed($inlineStyleAllowed) {
-		$this->inlineStyleAllowed = $inlineStyleAllowed;
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getAllowedStyleDomains() {
-		return $this->allowedStyleDomains;
-	}
-
-	/**
-	 * @param array $allowedStyleDomains
-	 */
-	public function setAllowedStyleDomains($allowedStyleDomains) {
-		$this->allowedStyleDomains = $allowedStyleDomains;
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getAllowedImageDomains() {
-		return $this->allowedImageDomains;
-	}
-
-	/**
-	 * @param array $allowedImageDomains
-	 */
-	public function setAllowedImageDomains($allowedImageDomains) {
-		$this->allowedImageDomains = $allowedImageDomains;
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getAllowedConnectDomains() {
-		return $this->allowedConnectDomains;
-	}
-
-	/**
-	 * @param array $allowedConnectDomains
-	 */
-	public function setAllowedConnectDomains($allowedConnectDomains) {
-		$this->allowedConnectDomains = $allowedConnectDomains;
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getAllowedMediaDomains() {
-		return $this->allowedMediaDomains;
-	}
-
-	/**
-	 * @param array $allowedMediaDomains
-	 */
-	public function setAllowedMediaDomains($allowedMediaDomains) {
-		$this->allowedMediaDomains = $allowedMediaDomains;
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getAllowedObjectDomains() {
-		return $this->allowedObjectDomains;
-	}
-
-	/**
-	 * @param array $allowedObjectDomains
-	 */
-	public function setAllowedObjectDomains($allowedObjectDomains) {
-		$this->allowedObjectDomains = $allowedObjectDomains;
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getAllowedFrameDomains() {
-		return $this->allowedFrameDomains;
-	}
-
-	/**
-	 * @param array $allowedFrameDomains
-	 */
-	public function setAllowedFrameDomains($allowedFrameDomains) {
-		$this->allowedFrameDomains = $allowedFrameDomains;
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getAllowedFontDomains() {
-		return $this->allowedFontDomains;
-	}
-
-	/**
-	 * @param array $allowedFontDomains
-	 */
-	public function setAllowedFontDomains($allowedFontDomains) {
-		$this->allowedFontDomains = $allowedFontDomains;
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getAllowedChildSrcDomains() {
-		return $this->allowedChildSrcDomains;
-	}
-
-	/**
-	 * @param array $allowedChildSrcDomains
-	 */
-	public function setAllowedChildSrcDomains($allowedChildSrcDomains) {
-		$this->allowedChildSrcDomains = $allowedChildSrcDomains;
-	}
+    /**
+     * @return boolean
+     */
+    public function isInlineScriptAllowed() {
+        return $this->inlineScriptAllowed;
+    }
+
+    /**
+     * @param boolean $inlineScriptAllowed
+     */
+    public function setInlineScriptAllowed($inlineScriptAllowed) {
+        $this->inlineScriptAllowed = $inlineScriptAllowed;
+    }
+
+    /**
+     * @return boolean
+     */
+    public function isEvalScriptAllowed() {
+        return $this->evalScriptAllowed;
+    }
+
+    /**
+     * @param boolean $evalScriptAllowed
+     */
+    public function setEvalScriptAllowed($evalScriptAllowed) {
+        $this->evalScriptAllowed = $evalScriptAllowed;
+    }
+
+    /**
+     * @return array
+     */
+    public function getAllowedScriptDomains() {
+        return $this->allowedScriptDomains;
+    }
+
+    /**
+     * @param array $allowedScriptDomains
+     */
+    public function setAllowedScriptDomains($allowedScriptDomains) {
+        $this->allowedScriptDomains = $allowedScriptDomains;
+    }
+
+    /**
+     * @return boolean
+     */
+    public function isInlineStyleAllowed() {
+        return $this->inlineStyleAllowed;
+    }
+
+    /**
+     * @param boolean $inlineStyleAllowed
+     */
+    public function setInlineStyleAllowed($inlineStyleAllowed) {
+        $this->inlineStyleAllowed = $inlineStyleAllowed;
+    }
+
+    /**
+     * @return array
+     */
+    public function getAllowedStyleDomains() {
+        return $this->allowedStyleDomains;
+    }
+
+    /**
+     * @param array $allowedStyleDomains
+     */
+    public function setAllowedStyleDomains($allowedStyleDomains) {
+        $this->allowedStyleDomains = $allowedStyleDomains;
+    }
+
+    /**
+     * @return array
+     */
+    public function getAllowedImageDomains() {
+        return $this->allowedImageDomains;
+    }
+
+    /**
+     * @param array $allowedImageDomains
+     */
+    public function setAllowedImageDomains($allowedImageDomains) {
+        $this->allowedImageDomains = $allowedImageDomains;
+    }
+
+    /**
+     * @return array
+     */
+    public function getAllowedConnectDomains() {
+        return $this->allowedConnectDomains;
+    }
+
+    /**
+     * @param array $allowedConnectDomains
+     */
+    public function setAllowedConnectDomains($allowedConnectDomains) {
+        $this->allowedConnectDomains = $allowedConnectDomains;
+    }
+
+    /**
+     * @return array
+     */
+    public function getAllowedMediaDomains() {
+        return $this->allowedMediaDomains;
+    }
+
+    /**
+     * @param array $allowedMediaDomains
+     */
+    public function setAllowedMediaDomains($allowedMediaDomains) {
+        $this->allowedMediaDomains = $allowedMediaDomains;
+    }
+
+    /**
+     * @return array
+     */
+    public function getAllowedObjectDomains() {
+        return $this->allowedObjectDomains;
+    }
+
+    /**
+     * @param array $allowedObjectDomains
+     */
+    public function setAllowedObjectDomains($allowedObjectDomains) {
+        $this->allowedObjectDomains = $allowedObjectDomains;
+    }
+
+    /**
+     * @return array
+     */
+    public function getAllowedFrameDomains() {
+        return $this->allowedFrameDomains;
+    }
+
+    /**
+     * @param array $allowedFrameDomains
+     */
+    public function setAllowedFrameDomains($allowedFrameDomains) {
+        $this->allowedFrameDomains = $allowedFrameDomains;
+    }
+
+    /**
+     * @return array
+     */
+    public function getAllowedFontDomains() {
+        return $this->allowedFontDomains;
+    }
+
+    /**
+     * @param array $allowedFontDomains
+     */
+    public function setAllowedFontDomains($allowedFontDomains) {
+        $this->allowedFontDomains = $allowedFontDomains;
+    }
+
+    /**
+     * @return array
+     */
+    public function getAllowedChildSrcDomains() {
+        return $this->allowedChildSrcDomains;
+    }
+
+    /**
+     * @param array $allowedChildSrcDomains
+     */
+    public function setAllowedChildSrcDomains($allowedChildSrcDomains) {
+        $this->allowedChildSrcDomains = $allowedChildSrcDomains;
+    }
 
 }

lib/private/Security/CSP/ContentSecurityPolicyManager.php

Indentation +40 added lines, -40 removed lines

@@ -27,48 +27,48 @@
 use OCP\Security\IContentSecurityPolicyManager;
 
 class ContentSecurityPolicyManager implements IContentSecurityPolicyManager {
-	/** @var ContentSecurityPolicy[] */
-	private $policies = [];
+    /** @var ContentSecurityPolicy[] */
+    private $policies = [];
 
-	/** {@inheritdoc} */
-	public function addDefaultPolicy(EmptyContentSecurityPolicy $policy) {
-		$this->policies[] = $policy;
-	}
+    /** {@inheritdoc} */
+    public function addDefaultPolicy(EmptyContentSecurityPolicy $policy) {
+        $this->policies[] = $policy;
+    }
 
-	/**
-	 * Get the configured default policy. This is not in the public namespace
-	 * as it is only supposed to be used by core itself.
-	 *
-	 * @return ContentSecurityPolicy
-	 */
-	public function getDefaultPolicy() {
-		$defaultPolicy = new \OC\Security\CSP\ContentSecurityPolicy();
-		foreach($this->policies as $policy) {
-			$defaultPolicy = $this->mergePolicies($defaultPolicy, $policy);
-		}
-		return $defaultPolicy;
-	}
+    /**
+     * Get the configured default policy. This is not in the public namespace
+     * as it is only supposed to be used by core itself.
+     *
+     * @return ContentSecurityPolicy
+     */
+    public function getDefaultPolicy() {
+        $defaultPolicy = new \OC\Security\CSP\ContentSecurityPolicy();
+        foreach($this->policies as $policy) {
+            $defaultPolicy = $this->mergePolicies($defaultPolicy, $policy);
+        }
+        return $defaultPolicy;
+    }
 
-	/**
-	 * Merges the first given policy with the second one
-	 *
-	 * @param ContentSecurityPolicy $defaultPolicy
-	 * @param EmptyContentSecurityPolicy $originalPolicy
-	 * @return ContentSecurityPolicy
-	 */
-	public function mergePolicies(ContentSecurityPolicy $defaultPolicy,
-								  EmptyContentSecurityPolicy $originalPolicy) {
-		foreach((object)(array)$originalPolicy as $name => $value) {
-			$setter = 'set'.ucfirst($name);
-			if(is_array($value)) {
-				$getter = 'get'.ucfirst($name);
-				$currentValues = is_array($defaultPolicy->$getter()) ? $defaultPolicy->$getter() : [];
-				$defaultPolicy->$setter(array_values(array_unique(array_merge($currentValues, $value))));
-			} elseif (is_bool($value)) {
-				$defaultPolicy->$setter($value);
-			}
-		}
+    /**
+     * Merges the first given policy with the second one
+     *
+     * @param ContentSecurityPolicy $defaultPolicy
+     * @param EmptyContentSecurityPolicy $originalPolicy
+     * @return ContentSecurityPolicy
+     */
+    public function mergePolicies(ContentSecurityPolicy $defaultPolicy,
+                                    EmptyContentSecurityPolicy $originalPolicy) {
+        foreach((object)(array)$originalPolicy as $name => $value) {
+            $setter = 'set'.ucfirst($name);
+            if(is_array($value)) {
+                $getter = 'get'.ucfirst($name);
+                $currentValues = is_array($defaultPolicy->$getter()) ? $defaultPolicy->$getter() : [];
+                $defaultPolicy->$setter(array_values(array_unique(array_merge($currentValues, $value))));
+            } elseif (is_bool($value)) {
+                $defaultPolicy->$setter($value);
+            }
+        }
 
-		return $defaultPolicy;
-	}
+        return $defaultPolicy;
+    }
 }

lib/private/Security/CredentialsManager.php

Indentation +78 added lines, -78 removed lines

@@ -34,93 +34,93 @@
  */
 class CredentialsManager implements ICredentialsManager {
 
-	const DB_TABLE = 'credentials';
+    const DB_TABLE = 'credentials';
 
-	/** @var ICrypto */
-	protected $crypto;
+    /** @var ICrypto */
+    protected $crypto;
 
-	/** @var IDBConnection */
-	protected $dbConnection;
+    /** @var IDBConnection */
+    protected $dbConnection;
 
-	/**
-	 * @param ICrypto $crypto
-	 * @param IDBConnection $dbConnection
-	 */
-	public function __construct(ICrypto $crypto, IDBConnection $dbConnection) {
-		$this->crypto = $crypto;
-		$this->dbConnection = $dbConnection;
-	}
+    /**
+     * @param ICrypto $crypto
+     * @param IDBConnection $dbConnection
+     */
+    public function __construct(ICrypto $crypto, IDBConnection $dbConnection) {
+        $this->crypto = $crypto;
+        $this->dbConnection = $dbConnection;
+    }
 
-	/**
-	 * Store a set of credentials
-	 *
-	 * @param string|null $userId Null for system-wide credentials
-	 * @param string $identifier
-	 * @param mixed $credentials
-	 */
-	public function store($userId, $identifier, $credentials) {
-		$value = $this->crypto->encrypt(json_encode($credentials));
+    /**
+     * Store a set of credentials
+     *
+     * @param string|null $userId Null for system-wide credentials
+     * @param string $identifier
+     * @param mixed $credentials
+     */
+    public function store($userId, $identifier, $credentials) {
+        $value = $this->crypto->encrypt(json_encode($credentials));
 
-		$this->dbConnection->setValues(self::DB_TABLE, [
-			'user' => $userId,
-			'identifier' => $identifier,
-		], [
-			'credentials' => $value,
-		]);
-	}
+        $this->dbConnection->setValues(self::DB_TABLE, [
+            'user' => $userId,
+            'identifier' => $identifier,
+        ], [
+            'credentials' => $value,
+        ]);
+    }
 
-	/**
-	 * Retrieve a set of credentials
-	 *
-	 * @param string|null $userId Null for system-wide credentials
-	 * @param string $identifier
-	 * @return mixed
-	 */
-	public function retrieve($userId, $identifier) {
-		$qb = $this->dbConnection->getQueryBuilder();
-		$qb->select('credentials')
-			->from(self::DB_TABLE)
-			->where($qb->expr()->eq('user', $qb->createNamedParameter($userId)))
-			->andWhere($qb->expr()->eq('identifier', $qb->createNamedParameter($identifier)))
-		;
-		$result = $qb->execute()->fetch();
+    /**
+     * Retrieve a set of credentials
+     *
+     * @param string|null $userId Null for system-wide credentials
+     * @param string $identifier
+     * @return mixed
+     */
+    public function retrieve($userId, $identifier) {
+        $qb = $this->dbConnection->getQueryBuilder();
+        $qb->select('credentials')
+            ->from(self::DB_TABLE)
+            ->where($qb->expr()->eq('user', $qb->createNamedParameter($userId)))
+            ->andWhere($qb->expr()->eq('identifier', $qb->createNamedParameter($identifier)))
+        ;
+        $result = $qb->execute()->fetch();
 
-		if (!$result) {
-			return null;
-		}
-		$value = $result['credentials'];
+        if (!$result) {
+            return null;
+        }
+        $value = $result['credentials'];
 
-		return json_decode($this->crypto->decrypt($value), true);
-	}
+        return json_decode($this->crypto->decrypt($value), true);
+    }
 
-	/**
-	 * Delete a set of credentials
-	 *
-	 * @param string|null $userId Null for system-wide credentials
-	 * @param string $identifier
-	 * @return int rows removed
-	 */
-	public function delete($userId, $identifier) {
-		$qb = $this->dbConnection->getQueryBuilder();
-		$qb->delete(self::DB_TABLE)
-			->where($qb->expr()->eq('user', $qb->createNamedParameter($userId)))
-			->andWhere($qb->expr()->eq('identifier', $qb->createNamedParameter($identifier)))
-		;
-		return $qb->execute();
-	}
+    /**
+     * Delete a set of credentials
+     *
+     * @param string|null $userId Null for system-wide credentials
+     * @param string $identifier
+     * @return int rows removed
+     */
+    public function delete($userId, $identifier) {
+        $qb = $this->dbConnection->getQueryBuilder();
+        $qb->delete(self::DB_TABLE)
+            ->where($qb->expr()->eq('user', $qb->createNamedParameter($userId)))
+            ->andWhere($qb->expr()->eq('identifier', $qb->createNamedParameter($identifier)))
+        ;
+        return $qb->execute();
+    }
 
-	/**
-	 * Erase all credentials stored for a user
-	 *
-	 * @param string $userId
-	 * @return int rows removed
-	 */
-	public function erase($userId) {
-		$qb = $this->dbConnection->getQueryBuilder();
-		$qb->delete(self::DB_TABLE)
-			->where($qb->expr()->eq('user', $qb->createNamedParameter($userId)))
-		;
-		return $qb->execute();
-	}
+    /**
+     * Erase all credentials stored for a user
+     *
+     * @param string $userId
+     * @return int rows removed
+     */
+    public function erase($userId) {
+        $qb = $this->dbConnection->getQueryBuilder();
+        $qb->delete(self::DB_TABLE)
+            ->where($qb->expr()->eq('user', $qb->createNamedParameter($userId)))
+        ;
+        return $qb->execute();
+    }
 
 }

lib/private/Security/TrustedDomainHelper.php

Indentation +59 added lines, -59 removed lines

@@ -32,68 +32,68 @@
  * @package OC\Security
  */
 class TrustedDomainHelper {
-	/** @var IConfig */
-	private $config;
+    /** @var IConfig */
+    private $config;
 
-	/**
-	 * @param IConfig $config
-	 */
-	function __construct(IConfig $config) {
-		$this->config = $config;
-	}
+    /**
+     * @param IConfig $config
+     */
+    function __construct(IConfig $config) {
+        $this->config = $config;
+    }
 
-	/**
-	 * Strips a potential port from a domain (in format domain:port)
-	 * @param string $host
-	 * @return string $host without appended port
-	 */
-	private function getDomainWithoutPort($host) {
-		$pos = strrpos($host, ':');
-		if ($pos !== false) {
-			$port = substr($host, $pos + 1);
-			if (is_numeric($port)) {
-				$host = substr($host, 0, $pos);
-			}
-		}
-		return $host;
-	}
+    /**
+     * Strips a potential port from a domain (in format domain:port)
+     * @param string $host
+     * @return string $host without appended port
+     */
+    private function getDomainWithoutPort($host) {
+        $pos = strrpos($host, ':');
+        if ($pos !== false) {
+            $port = substr($host, $pos + 1);
+            if (is_numeric($port)) {
+                $host = substr($host, 0, $pos);
+            }
+        }
+        return $host;
+    }
 
-	/**
-	 * Checks whether a domain is considered as trusted from the list
-	 * of trusted domains. If no trusted domains have been configured, returns
-	 * true.
-	 * This is used to prevent Host Header Poisoning.
-	 * @param string $domainWithPort
-	 * @return bool true if the given domain is trusted or if no trusted domains
-	 * have been configured
-	 */
-	public function isTrustedDomain($domainWithPort) {
-		$domain = $this->getDomainWithoutPort($domainWithPort);
+    /**
+     * Checks whether a domain is considered as trusted from the list
+     * of trusted domains. If no trusted domains have been configured, returns
+     * true.
+     * This is used to prevent Host Header Poisoning.
+     * @param string $domainWithPort
+     * @return bool true if the given domain is trusted or if no trusted domains
+     * have been configured
+     */
+    public function isTrustedDomain($domainWithPort) {
+        $domain = $this->getDomainWithoutPort($domainWithPort);
 
-		// Read trusted domains from config
-		$trustedList = $this->config->getSystemValue('trusted_domains', []);
-		if (!is_array($trustedList)) {
-			return false;
-		}
+        // Read trusted domains from config
+        $trustedList = $this->config->getSystemValue('trusted_domains', []);
+        if (!is_array($trustedList)) {
+            return false;
+        }
 
-		// Always allow access from localhost
-		if (preg_match(Request::REGEX_LOCALHOST, $domain) === 1) {
-			return true;
-		}
-		// Reject misformed domains in any case
-		if (strpos($domain,'-') === 0 || strpos($domain,'..') !== false) {
-			return false;
-		}
-		// Match, allowing for * wildcards
-		foreach ($trustedList as $trusted) {
-			if (gettype($trusted) !== 'string') {
-				break;
-			}
-			$regex = '/^' . join('[-\.a-zA-Z0-9]*', array_map(function($v) { return preg_quote($v, '/'); }, explode('*', $trusted))) . '$/';
-			if (preg_match($regex, $domain) || preg_match($regex, $domainWithPort)) {
- 				return true;
- 			}
- 		}
- 		return false;
-	}
+        // Always allow access from localhost
+        if (preg_match(Request::REGEX_LOCALHOST, $domain) === 1) {
+            return true;
+        }
+        // Reject misformed domains in any case
+        if (strpos($domain,'-') === 0 || strpos($domain,'..') !== false) {
+            return false;
+        }
+        // Match, allowing for * wildcards
+        foreach ($trustedList as $trusted) {
+            if (gettype($trusted) !== 'string') {
+                break;
+            }
+            $regex = '/^' . join('[-\.a-zA-Z0-9]*', array_map(function($v) { return preg_quote($v, '/'); }, explode('*', $trusted))) . '$/';
+            if (preg_match($regex, $domain) || preg_match($regex, $domainWithPort)) {
+                    return true;
+                }
+            }
+            return false;
+    }
 }

lib/private/Security/Hasher.php

Indentation +111 added lines, -111 removed lines

@@ -46,116 +46,116 @@
  * @package OC\Security
  */
 class Hasher implements IHasher {
-	/** @var IConfig */
-	private $config;
-	/** @var array Options passed to password_hash and password_needs_rehash */
-	private $options = array();
-	/** @var string Salt used for legacy passwords */
-	private $legacySalt = null;
-	/** @var int Current version of the generated hash */
-	private $currentVersion = 1;
-
-	/**
-	 * @param IConfig $config
-	 */
-	function __construct(IConfig $config) {
-		$this->config = $config;
-
-		$hashingCost = $this->config->getSystemValue('hashingCost', null);
-		if(!is_null($hashingCost)) {
-			$this->options['cost'] = $hashingCost;
-		}
-	}
-
-	/**
-	 * Hashes a message using PHP's `password_hash` functionality.
-	 * Please note that the size of the returned string is not guaranteed
-	 * and can be up to 255 characters.
-	 *
-	 * @param string $message Message to generate hash from
-	 * @return string Hash of the message with appended version parameter
-	 */
-	public function hash($message) {
-		return $this->currentVersion . '|' . password_hash($message, PASSWORD_DEFAULT, $this->options);
-	}
-
-	/**
-	 * Get the version and hash from a prefixedHash
-	 * @param string $prefixedHash
-	 * @return null|array Null if the hash is not prefixed, otherwise array('version' => 1, 'hash' => 'foo')
-	 */
-	protected function splitHash($prefixedHash) {
-		$explodedString = explode('|', $prefixedHash, 2);
-		if(sizeof($explodedString) === 2) {
-			if((int)$explodedString[0] > 0) {
-				return array('version' => (int)$explodedString[0], 'hash' => $explodedString[1]);
-			}
-		}
-
-		return null;
-	}
-
-	/**
-	 * Verify legacy hashes
-	 * @param string $message Message to verify
-	 * @param string $hash Assumed hash of the message
-	 * @param null|string &$newHash Reference will contain the updated hash
-	 * @return bool Whether $hash is a valid hash of $message
-	 */
-	protected function legacyHashVerify($message, $hash, &$newHash = null) {
-		if(empty($this->legacySalt)) {
-			$this->legacySalt = $this->config->getSystemValue('passwordsalt', '');
-		}
-
-		// Verify whether it matches a legacy PHPass or SHA1 string
-		$hashLength = strlen($hash);
-		if($hashLength === 60 && password_verify($message.$this->legacySalt, $hash) ||
-			$hashLength === 40 && hash_equals($hash, sha1($message))) {
-			$newHash = $this->hash($message);
-			return true;
-		}
-
-		return false;
-	}
-
-	/**
-	 * Verify V1 hashes
-	 * @param string $message Message to verify
-	 * @param string $hash Assumed hash of the message
-	 * @param null|string &$newHash Reference will contain the updated hash if necessary. Update the existing hash with this one.
-	 * @return bool Whether $hash is a valid hash of $message
-	 */
-	protected function verifyHashV1($message, $hash, &$newHash = null) {
-		if(password_verify($message, $hash)) {
-			if(password_needs_rehash($hash, PASSWORD_DEFAULT, $this->options)) {
-				$newHash = $this->hash($message);
-			}
-			return true;
-		}
-
-		return false;
-	}
-
-	/**
-	 * @param string $message Message to verify
-	 * @param string $hash Assumed hash of the message
-	 * @param null|string &$newHash Reference will contain the updated hash if necessary. Update the existing hash with this one.
-	 * @return bool Whether $hash is a valid hash of $message
-	 */
-	public function verify($message, $hash, &$newHash = null) {
-		$splittedHash = $this->splitHash($hash);
-
-		if(isset($splittedHash['version'])) {
-			switch ($splittedHash['version']) {
-				case 1:
-					return $this->verifyHashV1($message, $splittedHash['hash'], $newHash);
-			}
-		} else {
-			return $this->legacyHashVerify($message, $hash, $newHash);
-		}
-
-
-		return false;
-	}
+    /** @var IConfig */
+    private $config;
+    /** @var array Options passed to password_hash and password_needs_rehash */
+    private $options = array();
+    /** @var string Salt used for legacy passwords */
+    private $legacySalt = null;
+    /** @var int Current version of the generated hash */
+    private $currentVersion = 1;
+
+    /**
+     * @param IConfig $config
+     */
+    function __construct(IConfig $config) {
+        $this->config = $config;
+
+        $hashingCost = $this->config->getSystemValue('hashingCost', null);
+        if(!is_null($hashingCost)) {
+            $this->options['cost'] = $hashingCost;
+        }
+    }
+
+    /**
+     * Hashes a message using PHP's `password_hash` functionality.
+     * Please note that the size of the returned string is not guaranteed
+     * and can be up to 255 characters.
+     *
+     * @param string $message Message to generate hash from
+     * @return string Hash of the message with appended version parameter
+     */
+    public function hash($message) {
+        return $this->currentVersion . '|' . password_hash($message, PASSWORD_DEFAULT, $this->options);
+    }
+
+    /**
+     * Get the version and hash from a prefixedHash
+     * @param string $prefixedHash
+     * @return null|array Null if the hash is not prefixed, otherwise array('version' => 1, 'hash' => 'foo')
+     */
+    protected function splitHash($prefixedHash) {
+        $explodedString = explode('|', $prefixedHash, 2);
+        if(sizeof($explodedString) === 2) {
+            if((int)$explodedString[0] > 0) {
+                return array('version' => (int)$explodedString[0], 'hash' => $explodedString[1]);
+            }
+        }
+
+        return null;
+    }
+
+    /**
+     * Verify legacy hashes
+     * @param string $message Message to verify
+     * @param string $hash Assumed hash of the message
+     * @param null|string &$newHash Reference will contain the updated hash
+     * @return bool Whether $hash is a valid hash of $message
+     */
+    protected function legacyHashVerify($message, $hash, &$newHash = null) {
+        if(empty($this->legacySalt)) {
+            $this->legacySalt = $this->config->getSystemValue('passwordsalt', '');
+        }
+
+        // Verify whether it matches a legacy PHPass or SHA1 string
+        $hashLength = strlen($hash);
+        if($hashLength === 60 && password_verify($message.$this->legacySalt, $hash) ||
+            $hashLength === 40 && hash_equals($hash, sha1($message))) {
+            $newHash = $this->hash($message);
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * Verify V1 hashes
+     * @param string $message Message to verify
+     * @param string $hash Assumed hash of the message
+     * @param null|string &$newHash Reference will contain the updated hash if necessary. Update the existing hash with this one.
+     * @return bool Whether $hash is a valid hash of $message
+     */
+    protected function verifyHashV1($message, $hash, &$newHash = null) {
+        if(password_verify($message, $hash)) {
+            if(password_needs_rehash($hash, PASSWORD_DEFAULT, $this->options)) {
+                $newHash = $this->hash($message);
+            }
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * @param string $message Message to verify
+     * @param string $hash Assumed hash of the message
+     * @param null|string &$newHash Reference will contain the updated hash if necessary. Update the existing hash with this one.
+     * @return bool Whether $hash is a valid hash of $message
+     */
+    public function verify($message, $hash, &$newHash = null) {
+        $splittedHash = $this->splitHash($hash);
+
+        if(isset($splittedHash['version'])) {
+            switch ($splittedHash['version']) {
+                case 1:
+                    return $this->verifyHashV1($message, $splittedHash['hash'], $newHash);
+            }
+        } else {
+            return $this->legacyHashVerify($message, $hash, $newHash);
+        }
+
+
+        return false;
+    }
 
 }

lib/private/Security/CSRF/CsrfToken.php

Indentation +38 added lines, -38 removed lines

@@ -31,46 +31,46 @@
  * @package OC\Security\CSRF
  */
 class CsrfToken {
-	/** @var string */
-	private $value;
-	/** @var string */
-	private $encryptedValue = '';
+    /** @var string */
+    private $value;
+    /** @var string */
+    private $encryptedValue = '';
 
-	/**
-	 * @param string $value Value of the token. Can be encrypted or not encrypted.
-	 */
-	public function __construct($value) {
-		$this->value = $value;
-	}
+    /**
+     * @param string $value Value of the token. Can be encrypted or not encrypted.
+     */
+    public function __construct($value) {
+        $this->value = $value;
+    }
 
-	/**
-	 * Encrypted value of the token. This is used to mitigate BREACH alike
-	 * vulnerabilities. For display measures do use this functionality.
-	 *
-	 * @return string
-	 */
-	public function getEncryptedValue() {
-		if($this->encryptedValue === '') {
-			$sharedSecret = random_bytes(strlen($this->value));
-			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret) . ':' . base64_encode($sharedSecret);
-		}
+    /**
+     * Encrypted value of the token. This is used to mitigate BREACH alike
+     * vulnerabilities. For display measures do use this functionality.
+     *
+     * @return string
+     */
+    public function getEncryptedValue() {
+        if($this->encryptedValue === '') {
+            $sharedSecret = random_bytes(strlen($this->value));
+            $this->encryptedValue = base64_encode($this->value ^ $sharedSecret) . ':' . base64_encode($sharedSecret);
+        }
 
-		return $this->encryptedValue;
-	}
+        return $this->encryptedValue;
+    }
 
-	/**
-	 * The unencrypted value of the token. Used for decrypting an already
-	 * encrypted token.
-	 *
-	 * @return int
-	 */
-	public function getDecryptedValue() {
-		$token = explode(':', $this->value);
-		if (count($token) !== 2) {
-			return '';
-		}
-		$obfuscatedToken = $token[0];
-		$secret = $token[1];
-		return base64_decode($obfuscatedToken) ^ base64_decode($secret);
-	}
+    /**
+     * The unencrypted value of the token. Used for decrypting an already
+     * encrypted token.
+     *
+     * @return int
+     */
+    public function getDecryptedValue() {
+        $token = explode(':', $this->value);
+        if (count($token) !== 2) {
+            return '';
+        }
+        $obfuscatedToken = $token[0];
+        $secret = $token[1];
+        return base64_decode($obfuscatedToken) ^ base64_decode($secret);
+    }
 }

lib/private/Security/CSRF/TokenStorage/SessionStorage.php

Indentation +49 added lines, -49 removed lines

@@ -30,59 +30,59 @@
  * @package OC\Security\CSRF\TokenStorage
  */
 class SessionStorage {
-	/** @var ISession */
-	private $session;
+    /** @var ISession */
+    private $session;
 
-	/**
-	 * @param ISession $session
-	 */
-	public function __construct(ISession $session) {
-		$this->session = $session;
-	}
+    /**
+     * @param ISession $session
+     */
+    public function __construct(ISession $session) {
+        $this->session = $session;
+    }
 
-	/**
-	 * @param ISession $session
-	 */
-	public function setSession(ISession $session) {
-		$this->session = $session;
-	}
+    /**
+     * @param ISession $session
+     */
+    public function setSession(ISession $session) {
+        $this->session = $session;
+    }
 
-	/**
-	 * Returns the current token or throws an exception if none is found.
-	 *
-	 * @return string
-	 * @throws \Exception
-	 */
-	public function getToken() {
-		$token = $this->session->get('requesttoken');
-		if(empty($token)) {
-			throw new \Exception('Session does not contain a requesttoken');
-		}
+    /**
+     * Returns the current token or throws an exception if none is found.
+     *
+     * @return string
+     * @throws \Exception
+     */
+    public function getToken() {
+        $token = $this->session->get('requesttoken');
+        if(empty($token)) {
+            throw new \Exception('Session does not contain a requesttoken');
+        }
 
-		return $token;
-	}
+        return $token;
+    }
 
-	/**
-	 * Set the valid current token to $value.
-	 *
-	 * @param string $value
-	 */
-	public function setToken($value) {
-		$this->session->set('requesttoken', $value);
-	}
+    /**
+     * Set the valid current token to $value.
+     *
+     * @param string $value
+     */
+    public function setToken($value) {
+        $this->session->set('requesttoken', $value);
+    }
 
-	/**
-	 * Removes the current token.
-	 */
-	public function removeToken() {
-		$this->session->remove('requesttoken');
-	}
-	/**
-	 * Whether the storage has a storage.
-	 *
-	 * @return bool
-	 */
-	public function hasToken() {
-		return $this->session->exists('requesttoken');
-	}
+    /**
+     * Removes the current token.
+     */
+    public function removeToken() {
+        $this->session->remove('requesttoken');
+    }
+    /**
+     * Whether the storage has a storage.
+     *
+     * @return bool
+     */
+    public function hasToken() {
+        return $this->session->exists('requesttoken');
+    }
 }