nextcloud / server

apps/dav/tests/unit/CalDAV/CalendarHomeTest.php

Indentation +397 added lines, -397 removed lines

@@ -27,407 +27,407 @@
 use Test\TestCase;
 
 class CalendarHomeTest extends TestCase {
-	private CalDavBackend&MockObject $backend;
-	private array $principalInfo = [];
-	private PluginManager&MockObject $pluginManager;
-	private LoggerInterface&MockObject $logger;
-	private FederatedCalendarFactory&MockObject $federatedCalendarFactory;
-	private CalendarHome $calendarHome;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->backend = $this->createMock(CalDavBackend::class);
-		$this->principalInfo = [
-			'uri' => 'user-principal-123',
-		];
-		$this->pluginManager = $this->createMock(PluginManager::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->federatedCalendarFactory = $this->createMock(FederatedCalendarFactory::class);
-
-		$this->calendarHome = new CalendarHome(
-			$this->backend,
-			$this->principalInfo,
-			$this->logger,
-			$this->federatedCalendarFactory,
-			false
-		);
-
-		// Replace PluginManager with our mock
-		$reflection = new \ReflectionClass($this->calendarHome);
-		$reflectionProperty = $reflection->getProperty('pluginManager');
-		$reflectionProperty->setValue($this->calendarHome, $this->pluginManager);
-	}
-
-	public function testCreateCalendarValidName(): void {
-		/** @var MkCol&MockObject $mkCol */
-		$mkCol = $this->createMock(MkCol::class);
-
-		$mkCol->method('getResourceType')
-			->willReturn(['{DAV:}collection',
-				'{urn:ietf:params:xml:ns:caldav}calendar']);
-		$mkCol->method('getRemainingValues')
-			->willReturn(['... properties ...']);
-
-		$this->backend->expects(self::once())
-			->method('createCalendar')
-			->with('user-principal-123', 'name123', ['... properties ...']);
-
-		$this->calendarHome->createExtendedCollection('name123', $mkCol);
-	}
-
-	public function testCreateCalendarReservedName(): void {
-		$this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
-		$this->expectExceptionMessage('The resource you tried to create has a reserved name');
-
-		/** @var MkCol&MockObject $mkCol */
-		$mkCol = $this->createMock(MkCol::class);
-
-		$this->calendarHome->createExtendedCollection('contact_birthdays', $mkCol);
-	}
-
-	public function testCreateCalendarReservedNameAppGenerated(): void {
-		$this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
-		$this->expectExceptionMessage('The resource you tried to create has a reserved name');
-
-		/** @var MkCol&MockObject $mkCol */
-		$mkCol = $this->createMock(MkCol::class);
-
-		$this->calendarHome->createExtendedCollection('app-generated--example--foo-1', $mkCol);
-	}
-
-	public function testGetChildren():void {
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getFederatedCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$calendarPlugin1 = $this->createMock(ICalendarProvider::class);
-		$calendarPlugin1
-			->expects(self::once())
-			->method('fetchAllForCalendarHome')
-			->with('user-principal-123')
-			->willReturn(['plugin1calendar1', 'plugin1calendar2']);
-
-		$calendarPlugin2 = $this->createMock(ICalendarProvider::class);
-		$calendarPlugin2
-			->expects(self::once())
-			->method('fetchAllForCalendarHome')
-			->with('user-principal-123')
-			->willReturn(['plugin2calendar1', 'plugin2calendar2']);
-
-		$this->pluginManager
-			->expects(self::once())
-			->method('getCalendarPlugins')
-			->with()
-			->willReturn([$calendarPlugin1, $calendarPlugin2]);
-
-		$actual = $this->calendarHome->getChildren();
-
-		$this->assertCount(7, $actual);
-		$this->assertInstanceOf(Inbox::class, $actual[0]);
-		$this->assertInstanceOf(Outbox::class, $actual[1]);
-		$this->assertInstanceOf(TrashbinHome::class, $actual[2]);
-		$this->assertEquals('plugin1calendar1', $actual[3]);
-		$this->assertEquals('plugin1calendar2', $actual[4]);
-		$this->assertEquals('plugin2calendar1', $actual[5]);
-		$this->assertEquals('plugin2calendar2', $actual[6]);
-	}
-
-	public function testGetChildNonAppGenerated():void {
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarByUri')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::never())
-			->method('getFederatedCalendarsForUser');
-
-		$this->backend
-			->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->pluginManager
-			->expects(self::never())
-			->method('getCalendarPlugins');
-
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		$this->expectExceptionMessage('Node with name \'personal\' could not be found');
-
-		$this->calendarHome->getChild('personal');
-	}
-
-	public function testGetChildAppGenerated():void {
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarByUri')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::never())
-			->method('getFederatedCalendarsForUser');
-
-		$this->backend
-			->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$calendarPlugin1 = $this->createMock(ICalendarProvider::class);
-		$calendarPlugin1
-			->expects(self::once())
-			->method('getAppId')
-			->with()
-			->willReturn('calendar_plugin_1');
-		$calendarPlugin1
-			->expects(self::never())
-			->method('hasCalendarInCalendarHome');
-		$calendarPlugin1
-			->expects(self::never())
-			->method('getCalendarInCalendarHome');
-
-		$externalCalendarMock = $this->createMock(ExternalCalendar::class);
-
-		$calendarPlugin2 = $this->createMock(ICalendarProvider::class);
-		$calendarPlugin2
-			->expects(self::once())
-			->method('getAppId')
-			->with()
-			->willReturn('calendar_plugin_2');
-		$calendarPlugin2
-			->expects(self::once())
-			->method('hasCalendarInCalendarHome')
-			->with('user-principal-123', 'calendar-uri-from-backend')
-			->willReturn(true);
-		$calendarPlugin2
-			->expects(self::once())
-			->method('getCalendarInCalendarHome')
-			->with('user-principal-123', 'calendar-uri-from-backend')
-			->willReturn($externalCalendarMock);
-
-		$this->pluginManager
-			->expects(self::once())
-			->method('getCalendarPlugins')
-			->with()
-			->willReturn([$calendarPlugin1, $calendarPlugin2]);
-
-		$actual = $this->calendarHome->getChild('app-generated--calendar_plugin_2--calendar-uri-from-backend');
-		$this->assertEquals($externalCalendarMock, $actual);
-	}
-
-	public function testGetChildrenSubscriptions(): void {
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getFederatedCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('user-principal-123')
-			->willReturn([
-				[
-					'id' => 'subscription-1',
-					'uri' => 'subscription-1',
-					'principaluri' => 'user-principal-123',
-					'source' => 'https://localhost/subscription-1',
-					// A subscription array has actually more properties.
-				],
-				[
-					'id' => 'subscription-2',
-					'uri' => 'subscription-2',
-					'principaluri' => 'user-principal-123',
-					'source' => 'https://localhost/subscription-2',
-					// A subscription array has actually more properties.
-				]
-			]);
-
-		/*
+    private CalDavBackend&MockObject $backend;
+    private array $principalInfo = [];
+    private PluginManager&MockObject $pluginManager;
+    private LoggerInterface&MockObject $logger;
+    private FederatedCalendarFactory&MockObject $federatedCalendarFactory;
+    private CalendarHome $calendarHome;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->backend = $this->createMock(CalDavBackend::class);
+        $this->principalInfo = [
+            'uri' => 'user-principal-123',
+        ];
+        $this->pluginManager = $this->createMock(PluginManager::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->federatedCalendarFactory = $this->createMock(FederatedCalendarFactory::class);
+
+        $this->calendarHome = new CalendarHome(
+            $this->backend,
+            $this->principalInfo,
+            $this->logger,
+            $this->federatedCalendarFactory,
+            false
+        );
+
+        // Replace PluginManager with our mock
+        $reflection = new \ReflectionClass($this->calendarHome);
+        $reflectionProperty = $reflection->getProperty('pluginManager');
+        $reflectionProperty->setValue($this->calendarHome, $this->pluginManager);
+    }
+
+    public function testCreateCalendarValidName(): void {
+        /** @var MkCol&MockObject $mkCol */
+        $mkCol = $this->createMock(MkCol::class);
+
+        $mkCol->method('getResourceType')
+            ->willReturn(['{DAV:}collection',
+                '{urn:ietf:params:xml:ns:caldav}calendar']);
+        $mkCol->method('getRemainingValues')
+            ->willReturn(['... properties ...']);
+
+        $this->backend->expects(self::once())
+            ->method('createCalendar')
+            ->with('user-principal-123', 'name123', ['... properties ...']);
+
+        $this->calendarHome->createExtendedCollection('name123', $mkCol);
+    }
+
+    public function testCreateCalendarReservedName(): void {
+        $this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
+        $this->expectExceptionMessage('The resource you tried to create has a reserved name');
+
+        /** @var MkCol&MockObject $mkCol */
+        $mkCol = $this->createMock(MkCol::class);
+
+        $this->calendarHome->createExtendedCollection('contact_birthdays', $mkCol);
+    }
+
+    public function testCreateCalendarReservedNameAppGenerated(): void {
+        $this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
+        $this->expectExceptionMessage('The resource you tried to create has a reserved name');
+
+        /** @var MkCol&MockObject $mkCol */
+        $mkCol = $this->createMock(MkCol::class);
+
+        $this->calendarHome->createExtendedCollection('app-generated--example--foo-1', $mkCol);
+    }
+
+    public function testGetChildren():void {
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getFederatedCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $calendarPlugin1 = $this->createMock(ICalendarProvider::class);
+        $calendarPlugin1
+            ->expects(self::once())
+            ->method('fetchAllForCalendarHome')
+            ->with('user-principal-123')
+            ->willReturn(['plugin1calendar1', 'plugin1calendar2']);
+
+        $calendarPlugin2 = $this->createMock(ICalendarProvider::class);
+        $calendarPlugin2
+            ->expects(self::once())
+            ->method('fetchAllForCalendarHome')
+            ->with('user-principal-123')
+            ->willReturn(['plugin2calendar1', 'plugin2calendar2']);
+
+        $this->pluginManager
+            ->expects(self::once())
+            ->method('getCalendarPlugins')
+            ->with()
+            ->willReturn([$calendarPlugin1, $calendarPlugin2]);
+
+        $actual = $this->calendarHome->getChildren();
+
+        $this->assertCount(7, $actual);
+        $this->assertInstanceOf(Inbox::class, $actual[0]);
+        $this->assertInstanceOf(Outbox::class, $actual[1]);
+        $this->assertInstanceOf(TrashbinHome::class, $actual[2]);
+        $this->assertEquals('plugin1calendar1', $actual[3]);
+        $this->assertEquals('plugin1calendar2', $actual[4]);
+        $this->assertEquals('plugin2calendar1', $actual[5]);
+        $this->assertEquals('plugin2calendar2', $actual[6]);
+    }
+
+    public function testGetChildNonAppGenerated():void {
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarByUri')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::never())
+            ->method('getFederatedCalendarsForUser');
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->pluginManager
+            ->expects(self::never())
+            ->method('getCalendarPlugins');
+
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        $this->expectExceptionMessage('Node with name \'personal\' could not be found');
+
+        $this->calendarHome->getChild('personal');
+    }
+
+    public function testGetChildAppGenerated():void {
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarByUri')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::never())
+            ->method('getFederatedCalendarsForUser');
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $calendarPlugin1 = $this->createMock(ICalendarProvider::class);
+        $calendarPlugin1
+            ->expects(self::once())
+            ->method('getAppId')
+            ->with()
+            ->willReturn('calendar_plugin_1');
+        $calendarPlugin1
+            ->expects(self::never())
+            ->method('hasCalendarInCalendarHome');
+        $calendarPlugin1
+            ->expects(self::never())
+            ->method('getCalendarInCalendarHome');
+
+        $externalCalendarMock = $this->createMock(ExternalCalendar::class);
+
+        $calendarPlugin2 = $this->createMock(ICalendarProvider::class);
+        $calendarPlugin2
+            ->expects(self::once())
+            ->method('getAppId')
+            ->with()
+            ->willReturn('calendar_plugin_2');
+        $calendarPlugin2
+            ->expects(self::once())
+            ->method('hasCalendarInCalendarHome')
+            ->with('user-principal-123', 'calendar-uri-from-backend')
+            ->willReturn(true);
+        $calendarPlugin2
+            ->expects(self::once())
+            ->method('getCalendarInCalendarHome')
+            ->with('user-principal-123', 'calendar-uri-from-backend')
+            ->willReturn($externalCalendarMock);
+
+        $this->pluginManager
+            ->expects(self::once())
+            ->method('getCalendarPlugins')
+            ->with()
+            ->willReturn([$calendarPlugin1, $calendarPlugin2]);
+
+        $actual = $this->calendarHome->getChild('app-generated--calendar_plugin_2--calendar-uri-from-backend');
+        $this->assertEquals($externalCalendarMock, $actual);
+    }
+
+    public function testGetChildrenSubscriptions(): void {
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getFederatedCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('user-principal-123')
+            ->willReturn([
+                [
+                    'id' => 'subscription-1',
+                    'uri' => 'subscription-1',
+                    'principaluri' => 'user-principal-123',
+                    'source' => 'https://localhost/subscription-1',
+                    // A subscription array has actually more properties.
+                ],
+                [
+                    'id' => 'subscription-2',
+                    'uri' => 'subscription-2',
+                    'principaluri' => 'user-principal-123',
+                    'source' => 'https://localhost/subscription-2',
+                    // A subscription array has actually more properties.
+                ]
+            ]);
+
+        /*
 		 * @FIXME: PluginManager should be injected via constructor.
 		 */
 
-		$pluginManager = $this->createMock(PluginManager::class);
-		$pluginManager
-			->expects(self::once())
-			->method('getCalendarPlugins')
-			->with()
-			->willReturn([]);
-
-		$calendarHome = new CalendarHome(
-			$this->backend,
-			$this->principalInfo,
-			$this->logger,
-			$this->federatedCalendarFactory,
-			false
-		);
-
-		$reflection = new \ReflectionClass($calendarHome);
-		$reflectionProperty = $reflection->getProperty('pluginManager');
-		$reflectionProperty->setValue($calendarHome, $pluginManager);
-
-		$actual = $calendarHome->getChildren();
-
-		$this->assertCount(5, $actual);
-		$this->assertInstanceOf(Inbox::class, $actual[0]);
-		$this->assertInstanceOf(Outbox::class, $actual[1]);
-		$this->assertInstanceOf(TrashbinHome::class, $actual[2]);
-		$this->assertInstanceOf(Subscription::class, $actual[3]);
-		$this->assertInstanceOf(Subscription::class, $actual[4]);
-	}
-
-	public function testGetChildrenCachedSubscriptions(): void {
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getFederatedCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('user-principal-123')
-			->willReturn([
-				[
-					'id' => 'subscription-1',
-					'uri' => 'subscription-1',
-					'principaluris' => 'user-principal-123',
-					'source' => 'https://localhost/subscription-1',
-					// A subscription array has actually more properties.
-				],
-				[
-					'id' => 'subscription-2',
-					'uri' => 'subscription-2',
-					'principaluri' => 'user-principal-123',
-					'source' => 'https://localhost/subscription-2',
-					// A subscription array has actually more properties.
-				]
-			]);
-
-		/*
+        $pluginManager = $this->createMock(PluginManager::class);
+        $pluginManager
+            ->expects(self::once())
+            ->method('getCalendarPlugins')
+            ->with()
+            ->willReturn([]);
+
+        $calendarHome = new CalendarHome(
+            $this->backend,
+            $this->principalInfo,
+            $this->logger,
+            $this->federatedCalendarFactory,
+            false
+        );
+
+        $reflection = new \ReflectionClass($calendarHome);
+        $reflectionProperty = $reflection->getProperty('pluginManager');
+        $reflectionProperty->setValue($calendarHome, $pluginManager);
+
+        $actual = $calendarHome->getChildren();
+
+        $this->assertCount(5, $actual);
+        $this->assertInstanceOf(Inbox::class, $actual[0]);
+        $this->assertInstanceOf(Outbox::class, $actual[1]);
+        $this->assertInstanceOf(TrashbinHome::class, $actual[2]);
+        $this->assertInstanceOf(Subscription::class, $actual[3]);
+        $this->assertInstanceOf(Subscription::class, $actual[4]);
+    }
+
+    public function testGetChildrenCachedSubscriptions(): void {
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getFederatedCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('user-principal-123')
+            ->willReturn([
+                [
+                    'id' => 'subscription-1',
+                    'uri' => 'subscription-1',
+                    'principaluris' => 'user-principal-123',
+                    'source' => 'https://localhost/subscription-1',
+                    // A subscription array has actually more properties.
+                ],
+                [
+                    'id' => 'subscription-2',
+                    'uri' => 'subscription-2',
+                    'principaluri' => 'user-principal-123',
+                    'source' => 'https://localhost/subscription-2',
+                    // A subscription array has actually more properties.
+                ]
+            ]);
+
+        /*
 		 * @FIXME: PluginManager should be injected via constructor.
 		 */
 
-		$pluginManager = $this->createMock(PluginManager::class);
-		$pluginManager
-			->expects(self::once())
-			->method('getCalendarPlugins')
-			->with()
-			->willReturn([]);
-
-		$calendarHome = new CalendarHome(
-			$this->backend,
-			$this->principalInfo,
-			$this->logger,
-			$this->federatedCalendarFactory,
-			true
-		);
-
-		$reflection = new \ReflectionClass($calendarHome);
-		$reflectionProperty = $reflection->getProperty('pluginManager');
-		$reflectionProperty->setValue($calendarHome, $pluginManager);
-
-		$actual = $calendarHome->getChildren();
-
-		$this->assertCount(5, $actual);
-		$this->assertInstanceOf(Inbox::class, $actual[0]);
-		$this->assertInstanceOf(Outbox::class, $actual[1]);
-		$this->assertInstanceOf(TrashbinHome::class, $actual[2]);
-		$this->assertInstanceOf(CachedSubscription::class, $actual[3]);
-		$this->assertInstanceOf(CachedSubscription::class, $actual[4]);
-	}
-
-	public function testGetChildrenFederatedCalendars(): void {
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getFederatedCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([
-				[
-					'id' => 10,
-					'uri' => 'fed-cal-1',
-					'principaluri' => 'user-principal-123',
-					'{DAV:}displayname' => 'Federated calendar 1',
-					'{http://sabredav.org/ns}sync-token' => 3,
-					'{http://calendarserver.org/ns/}getctag' => 'http://sabre.io/ns/sync/3',
-					'{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => new SupportedCalendarComponentSet(['VEVENT']),
-					'{http://owncloud.org/ns}owner-principal' => 'principals/remote-users/c2hhcmVyQGhvc3QudGxkCg==',
-					'{http://owncloud.org/ns}read-only' => 1
-				],
-				[
-					'id' => 11,
-					'uri' => 'fed-cal-2',
-					'principaluri' => 'user-principal-123',
-					'{DAV:}displayname' => 'Federated calendar 2',
-					'{http://sabredav.org/ns}sync-token' => 5,
-					'{http://calendarserver.org/ns/}getctag' => 'http://sabre.io/ns/sync/5',
-					'{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => new SupportedCalendarComponentSet(['VEVENT']),
-					'{http://owncloud.org/ns}owner-principal' => 'principals/remote-users/c2hhcmVyQGhvc3QudGxkCg==',
-					'{http://owncloud.org/ns}read-only' => 1
-				],
-			]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$actual = $this->calendarHome->getChildren();
-
-		$this->assertCount(5, $actual);
-		$this->assertInstanceOf(Inbox::class, $actual[0]);
-		$this->assertInstanceOf(Outbox::class, $actual[1]);
-		$this->assertInstanceOf(TrashbinHome::class, $actual[2]);
-		$this->assertInstanceOf(FederatedCalendar::class, $actual[3]);
-		$this->assertInstanceOf(FederatedCalendar::class, $actual[4]);
-	}
+        $pluginManager = $this->createMock(PluginManager::class);
+        $pluginManager
+            ->expects(self::once())
+            ->method('getCalendarPlugins')
+            ->with()
+            ->willReturn([]);
+
+        $calendarHome = new CalendarHome(
+            $this->backend,
+            $this->principalInfo,
+            $this->logger,
+            $this->federatedCalendarFactory,
+            true
+        );
+
+        $reflection = new \ReflectionClass($calendarHome);
+        $reflectionProperty = $reflection->getProperty('pluginManager');
+        $reflectionProperty->setValue($calendarHome, $pluginManager);
+
+        $actual = $calendarHome->getChildren();
+
+        $this->assertCount(5, $actual);
+        $this->assertInstanceOf(Inbox::class, $actual[0]);
+        $this->assertInstanceOf(Outbox::class, $actual[1]);
+        $this->assertInstanceOf(TrashbinHome::class, $actual[2]);
+        $this->assertInstanceOf(CachedSubscription::class, $actual[3]);
+        $this->assertInstanceOf(CachedSubscription::class, $actual[4]);
+    }
+
+    public function testGetChildrenFederatedCalendars(): void {
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getFederatedCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([
+                [
+                    'id' => 10,
+                    'uri' => 'fed-cal-1',
+                    'principaluri' => 'user-principal-123',
+                    '{DAV:}displayname' => 'Federated calendar 1',
+                    '{http://sabredav.org/ns}sync-token' => 3,
+                    '{http://calendarserver.org/ns/}getctag' => 'http://sabre.io/ns/sync/3',
+                    '{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => new SupportedCalendarComponentSet(['VEVENT']),
+                    '{http://owncloud.org/ns}owner-principal' => 'principals/remote-users/c2hhcmVyQGhvc3QudGxkCg==',
+                    '{http://owncloud.org/ns}read-only' => 1
+                ],
+                [
+                    'id' => 11,
+                    'uri' => 'fed-cal-2',
+                    'principaluri' => 'user-principal-123',
+                    '{DAV:}displayname' => 'Federated calendar 2',
+                    '{http://sabredav.org/ns}sync-token' => 5,
+                    '{http://calendarserver.org/ns/}getctag' => 'http://sabre.io/ns/sync/5',
+                    '{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => new SupportedCalendarComponentSet(['VEVENT']),
+                    '{http://owncloud.org/ns}owner-principal' => 'principals/remote-users/c2hhcmVyQGhvc3QudGxkCg==',
+                    '{http://owncloud.org/ns}read-only' => 1
+                ],
+            ]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $actual = $this->calendarHome->getChildren();
+
+        $this->assertCount(5, $actual);
+        $this->assertInstanceOf(Inbox::class, $actual[0]);
+        $this->assertInstanceOf(Outbox::class, $actual[1]);
+        $this->assertInstanceOf(TrashbinHome::class, $actual[2]);
+        $this->assertInstanceOf(FederatedCalendar::class, $actual[3]);
+        $this->assertInstanceOf(FederatedCalendar::class, $actual[4]);
+    }
 }

apps/dav/tests/unit/DAV/Sharing/BackendTest.php

Indentation +380 added lines, -380 removed lines

@@ -26,384 +26,384 @@
 
 class BackendTest extends TestCase {
 
-	private IDBConnection&MockObject $db;
-	private IUserManager&MockObject $userManager;
-	private IGroupManager&MockObject $groupManager;
-	private Principal&MockObject $principalBackend;
-	private ICache&MockObject $shareCache;
-	private LoggerInterface&MockObject $logger;
-	private ICacheFactory&MockObject $cacheFactory;
-	private Service&MockObject $calendarService;
-	private RemoteUserPrincipalBackend&MockObject $remoteUserPrincipalBackend;
-	private FederationSharingService&MockObject $federationSharingService;
-	private CalendarSharingBackend $backend;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->db = $this->createMock(IDBConnection::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->principalBackend = $this->createMock(Principal::class);
-		$this->cacheFactory = $this->createMock(ICacheFactory::class);
-		$this->shareCache = $this->createMock(ICache::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->calendarService = $this->createMock(Service::class);
-		$this->cacheFactory->expects(self::any())
-			->method('createInMemory')
-			->willReturn($this->shareCache);
-		$this->remoteUserPrincipalBackend = $this->createMock(RemoteUserPrincipalBackend::class);
-		$this->federationSharingService = $this->createMock(FederationSharingService::class);
-
-		$this->backend = new CalendarSharingBackend(
-			$this->userManager,
-			$this->groupManager,
-			$this->principalBackend,
-			$this->remoteUserPrincipalBackend,
-			$this->cacheFactory,
-			$this->calendarService,
-			$this->federationSharingService,
-			$this->logger,
-		);
-	}
-
-	public function testUpdateShareCalendarBob(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$add = [
-			[
-				'href' => 'principal:principals/users/bob',
-				'readOnly' => true,
-			]
-		];
-		$principal = 'principals/users/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->userManager->expects(self::once())
-			->method('userExists')
-			->willReturn(true);
-		$this->groupManager->expects(self::never())
-			->method('groupExists');
-		$this->calendarService->expects(self::once())
-			->method('shareWith')
-			->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
-
-		$this->backend->updateShares($shareable, $add, []);
-	}
-
-	public function testUpdateShareCalendarGroup(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$add = [
-			[
-				'href' => 'principal:principals/groups/bob',
-				'readOnly' => true,
-			]
-		];
-		$principal = 'principals/groups/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->userManager->expects(self::never())
-			->method('userExists');
-		$this->groupManager->expects(self::once())
-			->method('groupExists')
-			->willReturn(true);
-		$this->calendarService->expects(self::once())
-			->method('shareWith')
-			->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
-
-		$this->backend->updateShares($shareable, $add, []);
-	}
-
-	public function testUpdateShareContactsBob(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$add = [
-			[
-				'href' => 'principal:principals/users/bob',
-				'readOnly' => true,
-			]
-		];
-		$principal = 'principals/users/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->userManager->expects(self::once())
-			->method('userExists')
-			->willReturn(true);
-		$this->groupManager->expects(self::never())
-			->method('groupExists');
-		$this->calendarService->expects(self::once())
-			->method('shareWith')
-			->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
-
-		$this->backend->updateShares($shareable, $add, []);
-	}
-
-	public function testUpdateShareContactsGroup(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$add = [
-			[
-				'href' => 'principal:principals/groups/bob',
-				'readOnly' => true,
-			]
-		];
-		$principal = 'principals/groups/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->userManager->expects(self::never())
-			->method('userExists');
-		$this->groupManager->expects(self::once())
-			->method('groupExists')
-			->willReturn(true);
-		$this->calendarService->expects(self::once())
-			->method('shareWith')
-			->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
-
-		$this->backend->updateShares($shareable, $add, []);
-	}
-
-	public function testUpdateShareCircle(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$add = [
-			[
-				'href' => 'principal:principals/circles/bob',
-				'readOnly' => true,
-			]
-		];
-		$principal = 'principals/groups/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->userManager->expects(self::never())
-			->method('userExists');
-		$this->groupManager->expects(self::once())
-			->method('groupExists')
-			->willReturn(true);
-		$this->calendarService->expects(self::once())
-			->method('shareWith')
-			->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
-
-		$this->backend->updateShares($shareable, $add, []);
-	}
-
-	public function testUnshareBob(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$remove = [
-			'principal:principals/users/bob',
-		];
-		$principal = 'principals/users/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->calendarService->expects(self::once())
-			->method('deleteShare')
-			->with($shareable->getResourceId(), $principal);
-		$this->calendarService->expects(self::never())
-			->method('unshare');
-
-		$this->backend->updateShares($shareable, [], $remove);
-	}
-
-	public function testUnshareWithBobGroup(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$remove = [
-			'principal:principals/users/bob',
-		];
-		$oldShares = [
-			[
-				'href' => 'principal:principals/groups/bob',
-				'commonName' => 'bob',
-				'status' => 1,
-				'readOnly' => true,
-				'{http://owncloud.org/ns}principal' => 'principals/groups/bob',
-				'{http://owncloud.org/ns}group-share' => true,
-			]
-		];
-
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn('principals/users/bob');
-		$this->calendarService->expects(self::once())
-			->method('deleteShare')
-			->with($shareable->getResourceId(), 'principals/users/bob');
-		$this->calendarService->expects(self::never())
-			->method('unshare');
-
-		$this->backend->updateShares($shareable, [], $remove, $oldShares);
-	}
-
-	public function testGetShares(): void {
-		$resourceId = 42;
-		$principal = 'principals/groups/bob';
-		$rows = [
-			[
-				'principaluri' => $principal,
-				'access' => Backend::ACCESS_READ,
-			]
-		];
-		$expected = [
-			[
-				'href' => 'principal:principals/groups/bob',
-				'commonName' => 'bob',
-				'status' => 1,
-				'readOnly' => true,
-				'{http://owncloud.org/ns}principal' => $principal,
-				'{http://owncloud.org/ns}group-share' => true,
-			]
-		];
-
-
-		$this->shareCache->expects(self::once())
-			->method('get')
-			->with((string)$resourceId)
-			->willReturn(null);
-		$this->calendarService->expects(self::once())
-			->method('getShares')
-			->with($resourceId)
-			->willReturn($rows);
-		$this->principalBackend->expects(self::once())
-			->method('getPrincipalByPath')
-			->with($principal)
-			->willReturn(['uri' => $principal, '{DAV:}displayname' => 'bob']);
-		$this->shareCache->expects(self::once())
-			->method('set')
-			->with((string)$resourceId, $expected);
-
-		$result = $this->backend->getShares($resourceId);
-		$this->assertEquals($expected, $result);
-	}
-
-	public function testGetSharesAddressbooks(): void {
-		$service = $this->createMock(\OCA\DAV\CardDAV\Sharing\Service::class);
-		$backend = new ContactsSharingBackend(
-			$this->userManager,
-			$this->groupManager,
-			$this->principalBackend,
-			$this->remoteUserPrincipalBackend,
-			$this->cacheFactory,
-			$service,
-			$this->federationSharingService,
-			$this->logger);
-		$resourceId = 42;
-		$principal = 'principals/groups/bob';
-		$rows = [
-			[
-				'principaluri' => $principal,
-				'access' => Backend::ACCESS_READ,
-			]
-		];
-		$expected = [
-			[
-				'href' => 'principal:principals/groups/bob',
-				'commonName' => 'bob',
-				'status' => 1,
-				'readOnly' => true,
-				'{http://owncloud.org/ns}principal' => $principal,
-				'{http://owncloud.org/ns}group-share' => true,
-			]
-		];
-
-		$this->shareCache->expects(self::once())
-			->method('get')
-			->with((string)$resourceId)
-			->willReturn(null);
-		$service->expects(self::once())
-			->method('getShares')
-			->with($resourceId)
-			->willReturn($rows);
-		$this->principalBackend->expects(self::once())
-			->method('getPrincipalByPath')
-			->with($principal)
-			->willReturn(['uri' => $principal, '{DAV:}displayname' => 'bob']);
-		$this->shareCache->expects(self::once())
-			->method('set')
-			->with((string)$resourceId, $expected);
-
-		$result = $backend->getShares($resourceId);
-		$this->assertEquals($expected, $result);
-	}
-
-	public function testPreloadShares(): void {
-		$resourceIds = [42, 99];
-		$rows = [
-			[
-				'resourceid' => 42,
-				'principaluri' => 'principals/groups/bob',
-				'access' => Backend::ACCESS_READ,
-			],
-			[
-				'resourceid' => 99,
-				'principaluri' => 'principals/users/carlos',
-				'access' => Backend::ACCESS_READ_WRITE,
-			]
-		];
-		$principalResults = [
-			['uri' => 'principals/groups/bob', '{DAV:}displayname' => 'bob'],
-			['uri' => 'principals/users/carlos', '{DAV:}displayname' => 'carlos'],
-		];
-
-		$this->shareCache->expects(self::exactly(2))
-			->method('get')
-			->willReturn(null);
-		$this->calendarService->expects(self::once())
-			->method('getSharesForIds')
-			->with($resourceIds)
-			->willReturn($rows);
-		$this->principalBackend->expects(self::exactly(2))
-			->method('getPrincipalByPath')
-			->willReturnCallback(function (string $principal) use ($principalResults) {
-				switch ($principal) {
-					case 'principals/groups/bob':
-						return $principalResults[0];
-					default:
-						return $principalResults[1];
-				}
-			});
-		$this->shareCache->expects(self::exactly(2))
-			->method('set');
-
-		$this->backend->preloadShares($resourceIds);
-	}
+    private IDBConnection&MockObject $db;
+    private IUserManager&MockObject $userManager;
+    private IGroupManager&MockObject $groupManager;
+    private Principal&MockObject $principalBackend;
+    private ICache&MockObject $shareCache;
+    private LoggerInterface&MockObject $logger;
+    private ICacheFactory&MockObject $cacheFactory;
+    private Service&MockObject $calendarService;
+    private RemoteUserPrincipalBackend&MockObject $remoteUserPrincipalBackend;
+    private FederationSharingService&MockObject $federationSharingService;
+    private CalendarSharingBackend $backend;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->db = $this->createMock(IDBConnection::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->principalBackend = $this->createMock(Principal::class);
+        $this->cacheFactory = $this->createMock(ICacheFactory::class);
+        $this->shareCache = $this->createMock(ICache::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->calendarService = $this->createMock(Service::class);
+        $this->cacheFactory->expects(self::any())
+            ->method('createInMemory')
+            ->willReturn($this->shareCache);
+        $this->remoteUserPrincipalBackend = $this->createMock(RemoteUserPrincipalBackend::class);
+        $this->federationSharingService = $this->createMock(FederationSharingService::class);
+
+        $this->backend = new CalendarSharingBackend(
+            $this->userManager,
+            $this->groupManager,
+            $this->principalBackend,
+            $this->remoteUserPrincipalBackend,
+            $this->cacheFactory,
+            $this->calendarService,
+            $this->federationSharingService,
+            $this->logger,
+        );
+    }
+
+    public function testUpdateShareCalendarBob(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $add = [
+            [
+                'href' => 'principal:principals/users/bob',
+                'readOnly' => true,
+            ]
+        ];
+        $principal = 'principals/users/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->userManager->expects(self::once())
+            ->method('userExists')
+            ->willReturn(true);
+        $this->groupManager->expects(self::never())
+            ->method('groupExists');
+        $this->calendarService->expects(self::once())
+            ->method('shareWith')
+            ->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
+
+        $this->backend->updateShares($shareable, $add, []);
+    }
+
+    public function testUpdateShareCalendarGroup(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $add = [
+            [
+                'href' => 'principal:principals/groups/bob',
+                'readOnly' => true,
+            ]
+        ];
+        $principal = 'principals/groups/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->userManager->expects(self::never())
+            ->method('userExists');
+        $this->groupManager->expects(self::once())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->calendarService->expects(self::once())
+            ->method('shareWith')
+            ->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
+
+        $this->backend->updateShares($shareable, $add, []);
+    }
+
+    public function testUpdateShareContactsBob(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $add = [
+            [
+                'href' => 'principal:principals/users/bob',
+                'readOnly' => true,
+            ]
+        ];
+        $principal = 'principals/users/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->userManager->expects(self::once())
+            ->method('userExists')
+            ->willReturn(true);
+        $this->groupManager->expects(self::never())
+            ->method('groupExists');
+        $this->calendarService->expects(self::once())
+            ->method('shareWith')
+            ->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
+
+        $this->backend->updateShares($shareable, $add, []);
+    }
+
+    public function testUpdateShareContactsGroup(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $add = [
+            [
+                'href' => 'principal:principals/groups/bob',
+                'readOnly' => true,
+            ]
+        ];
+        $principal = 'principals/groups/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->userManager->expects(self::never())
+            ->method('userExists');
+        $this->groupManager->expects(self::once())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->calendarService->expects(self::once())
+            ->method('shareWith')
+            ->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
+
+        $this->backend->updateShares($shareable, $add, []);
+    }
+
+    public function testUpdateShareCircle(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $add = [
+            [
+                'href' => 'principal:principals/circles/bob',
+                'readOnly' => true,
+            ]
+        ];
+        $principal = 'principals/groups/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->userManager->expects(self::never())
+            ->method('userExists');
+        $this->groupManager->expects(self::once())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->calendarService->expects(self::once())
+            ->method('shareWith')
+            ->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
+
+        $this->backend->updateShares($shareable, $add, []);
+    }
+
+    public function testUnshareBob(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $remove = [
+            'principal:principals/users/bob',
+        ];
+        $principal = 'principals/users/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->calendarService->expects(self::once())
+            ->method('deleteShare')
+            ->with($shareable->getResourceId(), $principal);
+        $this->calendarService->expects(self::never())
+            ->method('unshare');
+
+        $this->backend->updateShares($shareable, [], $remove);
+    }
+
+    public function testUnshareWithBobGroup(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $remove = [
+            'principal:principals/users/bob',
+        ];
+        $oldShares = [
+            [
+                'href' => 'principal:principals/groups/bob',
+                'commonName' => 'bob',
+                'status' => 1,
+                'readOnly' => true,
+                '{http://owncloud.org/ns}principal' => 'principals/groups/bob',
+                '{http://owncloud.org/ns}group-share' => true,
+            ]
+        ];
+
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn('principals/users/bob');
+        $this->calendarService->expects(self::once())
+            ->method('deleteShare')
+            ->with($shareable->getResourceId(), 'principals/users/bob');
+        $this->calendarService->expects(self::never())
+            ->method('unshare');
+
+        $this->backend->updateShares($shareable, [], $remove, $oldShares);
+    }
+
+    public function testGetShares(): void {
+        $resourceId = 42;
+        $principal = 'principals/groups/bob';
+        $rows = [
+            [
+                'principaluri' => $principal,
+                'access' => Backend::ACCESS_READ,
+            ]
+        ];
+        $expected = [
+            [
+                'href' => 'principal:principals/groups/bob',
+                'commonName' => 'bob',
+                'status' => 1,
+                'readOnly' => true,
+                '{http://owncloud.org/ns}principal' => $principal,
+                '{http://owncloud.org/ns}group-share' => true,
+            ]
+        ];
+
+
+        $this->shareCache->expects(self::once())
+            ->method('get')
+            ->with((string)$resourceId)
+            ->willReturn(null);
+        $this->calendarService->expects(self::once())
+            ->method('getShares')
+            ->with($resourceId)
+            ->willReturn($rows);
+        $this->principalBackend->expects(self::once())
+            ->method('getPrincipalByPath')
+            ->with($principal)
+            ->willReturn(['uri' => $principal, '{DAV:}displayname' => 'bob']);
+        $this->shareCache->expects(self::once())
+            ->method('set')
+            ->with((string)$resourceId, $expected);
+
+        $result = $this->backend->getShares($resourceId);
+        $this->assertEquals($expected, $result);
+    }
+
+    public function testGetSharesAddressbooks(): void {
+        $service = $this->createMock(\OCA\DAV\CardDAV\Sharing\Service::class);
+        $backend = new ContactsSharingBackend(
+            $this->userManager,
+            $this->groupManager,
+            $this->principalBackend,
+            $this->remoteUserPrincipalBackend,
+            $this->cacheFactory,
+            $service,
+            $this->federationSharingService,
+            $this->logger);
+        $resourceId = 42;
+        $principal = 'principals/groups/bob';
+        $rows = [
+            [
+                'principaluri' => $principal,
+                'access' => Backend::ACCESS_READ,
+            ]
+        ];
+        $expected = [
+            [
+                'href' => 'principal:principals/groups/bob',
+                'commonName' => 'bob',
+                'status' => 1,
+                'readOnly' => true,
+                '{http://owncloud.org/ns}principal' => $principal,
+                '{http://owncloud.org/ns}group-share' => true,
+            ]
+        ];
+
+        $this->shareCache->expects(self::once())
+            ->method('get')
+            ->with((string)$resourceId)
+            ->willReturn(null);
+        $service->expects(self::once())
+            ->method('getShares')
+            ->with($resourceId)
+            ->willReturn($rows);
+        $this->principalBackend->expects(self::once())
+            ->method('getPrincipalByPath')
+            ->with($principal)
+            ->willReturn(['uri' => $principal, '{DAV:}displayname' => 'bob']);
+        $this->shareCache->expects(self::once())
+            ->method('set')
+            ->with((string)$resourceId, $expected);
+
+        $result = $backend->getShares($resourceId);
+        $this->assertEquals($expected, $result);
+    }
+
+    public function testPreloadShares(): void {
+        $resourceIds = [42, 99];
+        $rows = [
+            [
+                'resourceid' => 42,
+                'principaluri' => 'principals/groups/bob',
+                'access' => Backend::ACCESS_READ,
+            ],
+            [
+                'resourceid' => 99,
+                'principaluri' => 'principals/users/carlos',
+                'access' => Backend::ACCESS_READ_WRITE,
+            ]
+        ];
+        $principalResults = [
+            ['uri' => 'principals/groups/bob', '{DAV:}displayname' => 'bob'],
+            ['uri' => 'principals/users/carlos', '{DAV:}displayname' => 'carlos'],
+        ];
+
+        $this->shareCache->expects(self::exactly(2))
+            ->method('get')
+            ->willReturn(null);
+        $this->calendarService->expects(self::once())
+            ->method('getSharesForIds')
+            ->with($resourceIds)
+            ->willReturn($rows);
+        $this->principalBackend->expects(self::exactly(2))
+            ->method('getPrincipalByPath')
+            ->willReturnCallback(function (string $principal) use ($principalResults) {
+                switch ($principal) {
+                    case 'principals/groups/bob':
+                        return $principalResults[0];
+                    default:
+                        return $principalResults[1];
+                }
+            });
+        $this->shareCache->expects(self::exactly(2))
+            ->method('set');
+
+        $this->backend->preloadShares($resourceIds);
+    }
 }

apps/dav/tests/unit/CardDAV/SyncServiceTest.php

Indentation +371 added lines, -371 removed lines

@@ -29,103 +29,103 @@ 
 
 class SyncServiceTest extends TestCase {
 
-	protected CardDavBackend&MockObject $backend;
-	protected IUserManager&MockObject $userManager;
-	protected IDBConnection&MockObject $dbConnection;
-	protected LoggerInterface $logger;
-	protected Converter&MockObject $converter;
-	protected IClient&MockObject $client;
-	protected IConfig&MockObject $config;
-	protected SyncService $service;
-
-	public function setUp(): void {
-		parent::setUp();
-
-		$addressBook = [
-			'id' => 1,
-			'uri' => 'system',
-			'principaluri' => 'principals/system/system',
-			'{DAV:}displayname' => 'system',
-			// watch out, incomplete address book mock.
-		];
-
-		$this->backend = $this->createMock(CardDavBackend::class);
-		$this->backend->method('getAddressBooksByUri')
-			->with('principals/system/system', 1)
-			->willReturn($addressBook);
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->dbConnection = $this->createMock(IDBConnection::class);
-		$this->logger = new NullLogger();
-		$this->converter = $this->createMock(Converter::class);
-		$this->client = $this->createMock(IClient::class);
-		$this->config = $this->createMock(IConfig::class);
-
-		$clientService = $this->createMock(IClientService::class);
-		$clientService->method('newClient')
-			->willReturn($this->client);
-
-		$this->service = new SyncService(
-			$clientService,
-			$this->config,
-			$this->backend,
-			$this->userManager,
-			$this->dbConnection,
-			$this->logger,
-			$this->converter,
-		);
-	}
-
-	public function testEmptySync(): void {
-		$this->backend->expects($this->exactly(0))
-			->method('createCard');
-		$this->backend->expects($this->exactly(0))
-			->method('updateCard');
-		$this->backend->expects($this->exactly(0))
-			->method('deleteCard');
-
-		$body = '<?xml version="1.0"?>
+    protected CardDavBackend&MockObject $backend;
+    protected IUserManager&MockObject $userManager;
+    protected IDBConnection&MockObject $dbConnection;
+    protected LoggerInterface $logger;
+    protected Converter&MockObject $converter;
+    protected IClient&MockObject $client;
+    protected IConfig&MockObject $config;
+    protected SyncService $service;
+
+    public function setUp(): void {
+        parent::setUp();
+
+        $addressBook = [
+            'id' => 1,
+            'uri' => 'system',
+            'principaluri' => 'principals/system/system',
+            '{DAV:}displayname' => 'system',
+            // watch out, incomplete address book mock.
+        ];
+
+        $this->backend = $this->createMock(CardDavBackend::class);
+        $this->backend->method('getAddressBooksByUri')
+            ->with('principals/system/system', 1)
+            ->willReturn($addressBook);
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->dbConnection = $this->createMock(IDBConnection::class);
+        $this->logger = new NullLogger();
+        $this->converter = $this->createMock(Converter::class);
+        $this->client = $this->createMock(IClient::class);
+        $this->config = $this->createMock(IConfig::class);
+
+        $clientService = $this->createMock(IClientService::class);
+        $clientService->method('newClient')
+            ->willReturn($this->client);
+
+        $this->service = new SyncService(
+            $clientService,
+            $this->config,
+            $this->backend,
+            $this->userManager,
+            $this->dbConnection,
+            $this->logger,
+            $this->converter,
+        );
+    }
+
+    public function testEmptySync(): void {
+        $this->backend->expects($this->exactly(0))
+            ->method('createCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('updateCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('deleteCard');
+
+        $body = '<?xml version="1.0"?>
 <d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
     <d:sync-token>http://sabre.io/ns/sync/1</d:sync-token>
 </d:multistatus>';
 
-		$requestResponse = new Response(new PsrResponse(
-			207,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		));
-
-		$this->client
-			->method('request')
-			->willReturn($requestResponse);
-
-		$token = $this->service->syncRemoteAddressBook(
-			'',
-			'system',
-			'system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		)[0];
-
-		$this->assertEquals('http://sabre.io/ns/sync/1', $token);
-	}
-
-	public function testSyncWithNewElement(): void {
-		$this->backend->expects($this->exactly(1))
-			->method('createCard');
-		$this->backend->expects($this->exactly(0))
-			->method('updateCard');
-		$this->backend->expects($this->exactly(0))
-			->method('deleteCard');
-
-		$this->backend->method('getCard')
-			->willReturn(false);
-
-
-		$body = '<?xml version="1.0"?>
+        $requestResponse = new Response(new PsrResponse(
+            207,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        ));
+
+        $this->client
+            ->method('request')
+            ->willReturn($requestResponse);
+
+        $token = $this->service->syncRemoteAddressBook(
+            '',
+            'system',
+            'system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        )[0];
+
+        $this->assertEquals('http://sabre.io/ns/sync/1', $token);
+    }
+
+    public function testSyncWithNewElement(): void {
+        $this->backend->expects($this->exactly(1))
+            ->method('createCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('updateCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('deleteCard');
+
+        $this->backend->method('getCard')
+            ->willReturn(false);
+
+
+        $body = '<?xml version="1.0"?>
 <d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
     <d:response>
         <d:href>/remote.php/dav/addressbooks/system/system/system/Database:alice.vcf</d:href>
@@ -140,17 +140,17 @@ 
     <d:sync-token>http://sabre.io/ns/sync/2</d:sync-token>
 </d:multistatus>';
 
-		$reportResponse = new Response(new PsrResponse(
-			207,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		));
+        $reportResponse = new Response(new PsrResponse(
+            207,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        ));
 
-		$this->client
-			->method('request')
-			->willReturn($reportResponse);
+        $this->client
+            ->method('request')
+            ->willReturn($reportResponse);
 
-		$vCard = 'BEGIN:VCARD
+        $vCard = 'BEGIN:VCARD
 VERSION:3.0
 PRODID:-//Sabre//Sabre VObject 4.5.4//EN
 UID:alice
@@ -160,43 +160,43 @@ 
 CLOUD:alice@server2.internal
 END:VCARD';
 
-		$getResponse = new Response(new PsrResponse(
-			200,
-			['Content-Type' => 'text/vcard; charset=utf-8', 'Content-Length' => strlen($vCard)],
-			$vCard,
-		));
-
-		$this->client
-			->method('get')
-			->willReturn($getResponse);
-
-		$token = $this->service->syncRemoteAddressBook(
-			'',
-			'system',
-			'system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		)[0];
-
-		$this->assertEquals('http://sabre.io/ns/sync/2', $token);
-	}
-
-	public function testSyncWithUpdatedElement(): void {
-		$this->backend->expects($this->exactly(0))
-			->method('createCard');
-		$this->backend->expects($this->exactly(1))
-			->method('updateCard');
-		$this->backend->expects($this->exactly(0))
-			->method('deleteCard');
-
-		$this->backend->method('getCard')
-			->willReturn(true);
-
-
-		$body = '<?xml version="1.0"?>
+        $getResponse = new Response(new PsrResponse(
+            200,
+            ['Content-Type' => 'text/vcard; charset=utf-8', 'Content-Length' => strlen($vCard)],
+            $vCard,
+        ));
+
+        $this->client
+            ->method('get')
+            ->willReturn($getResponse);
+
+        $token = $this->service->syncRemoteAddressBook(
+            '',
+            'system',
+            'system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        )[0];
+
+        $this->assertEquals('http://sabre.io/ns/sync/2', $token);
+    }
+
+    public function testSyncWithUpdatedElement(): void {
+        $this->backend->expects($this->exactly(0))
+            ->method('createCard');
+        $this->backend->expects($this->exactly(1))
+            ->method('updateCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('deleteCard');
+
+        $this->backend->method('getCard')
+            ->willReturn(true);
+
+
+        $body = '<?xml version="1.0"?>
 <d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
     <d:response>
         <d:href>/remote.php/dav/addressbooks/system/system/system/Database:alice.vcf</d:href>
@@ -211,17 +211,17 @@ 
     <d:sync-token>http://sabre.io/ns/sync/3</d:sync-token>
 </d:multistatus>';
 
-		$reportResponse = new Response(new PsrResponse(
-			207,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		));
+        $reportResponse = new Response(new PsrResponse(
+            207,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        ));
 
-		$this->client
-			->method('request')
-			->willReturn($reportResponse);
+        $this->client
+            ->method('request')
+            ->willReturn($reportResponse);
 
-		$vCard = 'BEGIN:VCARD
+        $vCard = 'BEGIN:VCARD
 VERSION:3.0
 PRODID:-//Sabre//Sabre VObject 4.5.4//EN
 UID:alice
@@ -231,39 +231,39 @@ 
 CLOUD:alice@server2.internal
 END:VCARD';
 
-		$getResponse = new Response(new PsrResponse(
-			200,
-			['Content-Type' => 'text/vcard; charset=utf-8', 'Content-Length' => strlen($vCard)],
-			$vCard,
-		));
-
-		$this->client
-			->method('get')
-			->willReturn($getResponse);
-
-		$token = $this->service->syncRemoteAddressBook(
-			'',
-			'system',
-			'system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		)[0];
-
-		$this->assertEquals('http://sabre.io/ns/sync/3', $token);
-	}
-
-	public function testSyncWithDeletedElement(): void {
-		$this->backend->expects($this->exactly(0))
-			->method('createCard');
-		$this->backend->expects($this->exactly(0))
-			->method('updateCard');
-		$this->backend->expects($this->exactly(1))
-			->method('deleteCard');
-
-		$body = '<?xml version="1.0"?>
+        $getResponse = new Response(new PsrResponse(
+            200,
+            ['Content-Type' => 'text/vcard; charset=utf-8', 'Content-Length' => strlen($vCard)],
+            $vCard,
+        ));
+
+        $this->client
+            ->method('get')
+            ->willReturn($getResponse);
+
+        $token = $this->service->syncRemoteAddressBook(
+            '',
+            'system',
+            'system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        )[0];
+
+        $this->assertEquals('http://sabre.io/ns/sync/3', $token);
+    }
+
+    public function testSyncWithDeletedElement(): void {
+        $this->backend->expects($this->exactly(0))
+            ->method('createCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('updateCard');
+        $this->backend->expects($this->exactly(1))
+            ->method('deleteCard');
+
+        $body = '<?xml version="1.0"?>
 <d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
 <d:response>
     <d:href>/remote.php/dav/addressbooks/system/system/system/Database:alice.vcf</d:href>
@@ -272,209 +272,209 @@ 
 <d:sync-token>http://sabre.io/ns/sync/4</d:sync-token>
 </d:multistatus>';
 
-		$reportResponse = new Response(new PsrResponse(
-			207,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		));
-
-		$this->client
-			->method('request')
-			->willReturn($reportResponse);
-
-		$token = $this->service->syncRemoteAddressBook(
-			'',
-			'system',
-			'system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		)[0];
-
-		$this->assertEquals('http://sabre.io/ns/sync/4', $token);
-	}
-
-	public function testEnsureSystemAddressBookExists(): void {
-		/** @var CardDavBackend&MockObject $backend */
-		$backend = $this->createMock(CardDavBackend::class);
-		$backend->expects($this->exactly(1))->method('createAddressBook');
-		$backend->expects($this->exactly(2))
-			->method('getAddressBooksByUri')
-			->willReturnOnConsecutiveCalls(
-				null,
-				[],
-			);
-
-		$userManager = $this->createMock(IUserManager::class);
-		$dbConnection = $this->createMock(IDBConnection::class);
-		$logger = $this->createMock(LoggerInterface::class);
-		$converter = $this->createMock(Converter::class);
-		$clientService = $this->createMock(IClientService::class);
-		$config = $this->createMock(IConfig::class);
-
-		$ss = new SyncService($clientService, $config, $backend, $userManager, $dbConnection, $logger, $converter);
-		$ss->ensureSystemAddressBookExists('principals/users/adam', 'contacts', []);
-	}
-
-	public static function dataActivatedUsers(): array {
-		return [
-			[true, 1, 1, 1],
-			[false, 0, 0, 3],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataActivatedUsers')]
-	public function testUpdateAndDeleteUser(bool $activated, int $createCalls, int $updateCalls, int $deleteCalls): void {
-		/** @var CardDavBackend | MockObject $backend */
-		$backend = $this->getMockBuilder(CardDavBackend::class)->disableOriginalConstructor()->getMock();
-		$logger = $this->getMockBuilder(LoggerInterface::class)->disableOriginalConstructor()->getMock();
-
-		$backend->expects($this->exactly($createCalls))->method('createCard');
-		$backend->expects($this->exactly($updateCalls))->method('updateCard');
-		$backend->expects($this->exactly($deleteCalls))->method('deleteCard');
-
-		$backend->method('getCard')->willReturnOnConsecutiveCalls(false, [
-			'carddata' => "BEGIN:VCARD\r\nVERSION:3.0\r\nPRODID:-//Sabre//Sabre VObject 3.4.8//EN\r\nUID:test-user\r\nFN:test-user\r\nN:test-user;;;;\r\nEND:VCARD\r\n\r\n"
-		]);
-
-		$backend->method('getAddressBooksByUri')
-			->with('principals/system/system', 'system')
-			->willReturn(['id' => -1]);
-
-		$userManager = $this->createMock(IUserManager::class);
-		$dbConnection = $this->createMock(IDBConnection::class);
-		$user = $this->createMock(IUser::class);
-		$user->method('getBackendClassName')->willReturn('unittest');
-		$user->method('getUID')->willReturn('test-user');
-		$user->method('getCloudId')->willReturn('cloudId');
-		$user->method('getDisplayName')->willReturn('test-user');
-		$user->method('isEnabled')->willReturn($activated);
-		$converter = $this->createMock(Converter::class);
-		$converter->expects($this->any())
-			->method('createCardFromUser')
-			->willReturn($this->createMock(VCard::class));
-
-		$clientService = $this->createMock(IClientService::class);
-		$config = $this->createMock(IConfig::class);
-
-		$ss = new SyncService($clientService, $config, $backend, $userManager, $dbConnection, $logger, $converter);
-		$ss->updateUser($user);
-
-		$ss->updateUser($user);
-
-		$ss->deleteUser($user);
-	}
-
-	public function testDeleteAddressbookWhenAccessRevoked(): void {
-		$this->expectException(ClientExceptionInterface::class);
-
-		$this->backend->expects($this->exactly(0))
-			->method('createCard');
-		$this->backend->expects($this->exactly(0))
-			->method('updateCard');
-		$this->backend->expects($this->exactly(0))
-			->method('deleteCard');
-		$this->backend->expects($this->exactly(1))
-			->method('deleteAddressBook');
-
-		$request = new PsrRequest(
-			'REPORT',
-			'https://server2.internal/remote.php/dav/addressbooks/system/system/system',
-			['Content-Type' => 'application/xml'],
-		);
-
-		$body = '<?xml version="1.0" encoding="utf-8"?>
+        $reportResponse = new Response(new PsrResponse(
+            207,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        ));
+
+        $this->client
+            ->method('request')
+            ->willReturn($reportResponse);
+
+        $token = $this->service->syncRemoteAddressBook(
+            '',
+            'system',
+            'system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        )[0];
+
+        $this->assertEquals('http://sabre.io/ns/sync/4', $token);
+    }
+
+    public function testEnsureSystemAddressBookExists(): void {
+        /** @var CardDavBackend&MockObject $backend */
+        $backend = $this->createMock(CardDavBackend::class);
+        $backend->expects($this->exactly(1))->method('createAddressBook');
+        $backend->expects($this->exactly(2))
+            ->method('getAddressBooksByUri')
+            ->willReturnOnConsecutiveCalls(
+                null,
+                [],
+            );
+
+        $userManager = $this->createMock(IUserManager::class);
+        $dbConnection = $this->createMock(IDBConnection::class);
+        $logger = $this->createMock(LoggerInterface::class);
+        $converter = $this->createMock(Converter::class);
+        $clientService = $this->createMock(IClientService::class);
+        $config = $this->createMock(IConfig::class);
+
+        $ss = new SyncService($clientService, $config, $backend, $userManager, $dbConnection, $logger, $converter);
+        $ss->ensureSystemAddressBookExists('principals/users/adam', 'contacts', []);
+    }
+
+    public static function dataActivatedUsers(): array {
+        return [
+            [true, 1, 1, 1],
+            [false, 0, 0, 3],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataActivatedUsers')]
+    public function testUpdateAndDeleteUser(bool $activated, int $createCalls, int $updateCalls, int $deleteCalls): void {
+        /** @var CardDavBackend | MockObject $backend */
+        $backend = $this->getMockBuilder(CardDavBackend::class)->disableOriginalConstructor()->getMock();
+        $logger = $this->getMockBuilder(LoggerInterface::class)->disableOriginalConstructor()->getMock();
+
+        $backend->expects($this->exactly($createCalls))->method('createCard');
+        $backend->expects($this->exactly($updateCalls))->method('updateCard');
+        $backend->expects($this->exactly($deleteCalls))->method('deleteCard');
+
+        $backend->method('getCard')->willReturnOnConsecutiveCalls(false, [
+            'carddata' => "BEGIN:VCARD\r\nVERSION:3.0\r\nPRODID:-//Sabre//Sabre VObject 3.4.8//EN\r\nUID:test-user\r\nFN:test-user\r\nN:test-user;;;;\r\nEND:VCARD\r\n\r\n"
+        ]);
+
+        $backend->method('getAddressBooksByUri')
+            ->with('principals/system/system', 'system')
+            ->willReturn(['id' => -1]);
+
+        $userManager = $this->createMock(IUserManager::class);
+        $dbConnection = $this->createMock(IDBConnection::class);
+        $user = $this->createMock(IUser::class);
+        $user->method('getBackendClassName')->willReturn('unittest');
+        $user->method('getUID')->willReturn('test-user');
+        $user->method('getCloudId')->willReturn('cloudId');
+        $user->method('getDisplayName')->willReturn('test-user');
+        $user->method('isEnabled')->willReturn($activated);
+        $converter = $this->createMock(Converter::class);
+        $converter->expects($this->any())
+            ->method('createCardFromUser')
+            ->willReturn($this->createMock(VCard::class));
+
+        $clientService = $this->createMock(IClientService::class);
+        $config = $this->createMock(IConfig::class);
+
+        $ss = new SyncService($clientService, $config, $backend, $userManager, $dbConnection, $logger, $converter);
+        $ss->updateUser($user);
+
+        $ss->updateUser($user);
+
+        $ss->deleteUser($user);
+    }
+
+    public function testDeleteAddressbookWhenAccessRevoked(): void {
+        $this->expectException(ClientExceptionInterface::class);
+
+        $this->backend->expects($this->exactly(0))
+            ->method('createCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('updateCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('deleteCard');
+        $this->backend->expects($this->exactly(1))
+            ->method('deleteAddressBook');
+
+        $request = new PsrRequest(
+            'REPORT',
+            'https://server2.internal/remote.php/dav/addressbooks/system/system/system',
+            ['Content-Type' => 'application/xml'],
+        );
+
+        $body = '<?xml version="1.0" encoding="utf-8"?>
 <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
   <s:exception>Sabre\DAV\Exception\NotAuthenticated</s:exception>
   <s:message>No public access to this resource., Username or password was incorrect, No \'Authorization: Bearer\' header found. Either the client didn\'t send one, or the server is mis-configured, Username or password was incorrect</s:message>
 </d:error>';
 
-		$response = new PsrResponse(
-			401,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		);
+        $response = new PsrResponse(
+            401,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        );
 
-		$message = 'Client error: `REPORT https://server2.internal/cloud/remote.php/dav/addressbooks/system/system/system` resulted in a `401 Unauthorized` response:
+        $message = 'Client error: `REPORT https://server2.internal/cloud/remote.php/dav/addressbooks/system/system/system` resulted in a `401 Unauthorized` response:
 <?xml version="1.0" encoding="utf-8"?>
 <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
   <s:exception>Sabre\DA (truncated...)
 ';
 
-		$reportException = new ClientException(
-			$message,
-			$request,
-			$response
-		);
-
-		$this->client
-			->method('request')
-			->willThrowException($reportException);
-
-		$this->service->syncRemoteAddressBook(
-			'',
-			'system',
-			'system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providerUseAbsoluteUriReport')]
-	public function testUseAbsoluteUriReport(string $host, string $expected): void {
-		$body = '<?xml version="1.0"?>
+        $reportException = new ClientException(
+            $message,
+            $request,
+            $response
+        );
+
+        $this->client
+            ->method('request')
+            ->willThrowException($reportException);
+
+        $this->service->syncRemoteAddressBook(
+            '',
+            'system',
+            'system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        );
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providerUseAbsoluteUriReport')]
+    public function testUseAbsoluteUriReport(string $host, string $expected): void {
+        $body = '<?xml version="1.0"?>
 <d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
     <d:sync-token>http://sabre.io/ns/sync/1</d:sync-token>
 </d:multistatus>';
 
-		$requestResponse = new Response(new PsrResponse(
-			207,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		));
-
-		$this->client
-			->method('request')
-			->with(
-				'REPORT',
-				$this->callback(function ($uri) use ($expected) {
-					$this->assertEquals($expected, $uri);
-					return true;
-				}),
-				$this->callback(function ($options) {
-					$this->assertIsArray($options);
-					return true;
-				}),
-			)
-			->willReturn($requestResponse);
-
-		$this->service->syncRemoteAddressBook(
-			$host,
-			'system',
-			'remote.php/dav/addressbooks/system/system/system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		);
-	}
-
-	public static function providerUseAbsoluteUriReport(): array {
-		return [
-			['https://server.internal', 'https://server.internal/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal/', 'https://server.internal/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal/nextcloud', 'https://server.internal/nextcloud/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal/nextcloud/', 'https://server.internal/nextcloud/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal:8080', 'https://server.internal:8080/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal:8080/', 'https://server.internal:8080/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal:8080/nextcloud', 'https://server.internal:8080/nextcloud/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal:8080/nextcloud/', 'https://server.internal:8080/nextcloud/remote.php/dav/addressbooks/system/system/system'],
-		];
-	}
+        $requestResponse = new Response(new PsrResponse(
+            207,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        ));
+
+        $this->client
+            ->method('request')
+            ->with(
+                'REPORT',
+                $this->callback(function ($uri) use ($expected) {
+                    $this->assertEquals($expected, $uri);
+                    return true;
+                }),
+                $this->callback(function ($options) {
+                    $this->assertIsArray($options);
+                    return true;
+                }),
+            )
+            ->willReturn($requestResponse);
+
+        $this->service->syncRemoteAddressBook(
+            $host,
+            'system',
+            'remote.php/dav/addressbooks/system/system/system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        );
+    }
+
+    public static function providerUseAbsoluteUriReport(): array {
+        return [
+            ['https://server.internal', 'https://server.internal/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal/', 'https://server.internal/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal/nextcloud', 'https://server.internal/nextcloud/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal/nextcloud/', 'https://server.internal/nextcloud/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal:8080', 'https://server.internal:8080/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal:8080/', 'https://server.internal:8080/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal:8080/nextcloud', 'https://server.internal:8080/nextcloud/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal:8080/nextcloud/', 'https://server.internal:8080/nextcloud/remote.php/dav/addressbooks/system/system/system'],
+        ];
+    }
 }

apps/dav/tests/unit/CardDAV/CardDavBackendTest.php

Indentation +875 added lines, -875 removed lines

@@ -48,879 +48,879 @@
  * @package OCA\DAV\Tests\unit\CardDAV
  */
 class CardDavBackendTest extends TestCase {
-	private Principal&MockObject $principal;
-	private IUserManager&MockObject $userManager;
-	private IGroupManager&MockObject $groupManager;
-	private IEventDispatcher&MockObject $dispatcher;
-	private IConfig&MockObject $config;
-	private RemoteUserPrincipalBackend&MockObject $remoteUserPrincipalBackend;
-	private FederationSharingService&MockObject $federationSharingService;
-	private Backend $sharingBackend;
-	private IDBConnection $db;
-	private CardDavBackend $backend;
-	private string $dbCardsTable = 'cards';
-	private string $dbCardsPropertiesTable = 'cards_properties';
-
-	public const UNIT_TEST_USER = 'principals/users/carddav-unit-test';
-	public const UNIT_TEST_USER1 = 'principals/users/carddav-unit-test1';
-	public const UNIT_TEST_GROUP = 'principals/groups/carddav-unit-test-group';
-
-	private $vcardTest0 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test' . PHP_EOL
-		. 'FN:Test' . PHP_EOL
-		. 'N:Test;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	private $vcardTest1 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test2' . PHP_EOL
-		. 'FN:Test2' . PHP_EOL
-		. 'N:Test2;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	private $vcardTest2 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test3' . PHP_EOL
-		. 'FN:Test3' . PHP_EOL
-		. 'N:Test3;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	private $vcardTestNoUID = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'FN:TestNoUID' . PHP_EOL
-		. 'N:TestNoUID;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->principal = $this->getMockBuilder(Principal::class)
-			->setConstructorArgs([
-				$this->userManager,
-				$this->groupManager,
-				$this->createMock(IAccountManager::class),
-				$this->createMock(ShareManager::class),
-				$this->createMock(IUserSession::class),
-				$this->createMock(IAppManager::class),
-				$this->createMock(ProxyMapper::class),
-				$this->createMock(KnownUserService::class),
-				$this->config,
-				$this->createMock(IFactory::class)
-			])
-			->onlyMethods(['getPrincipalByPath', 'getGroupMembership', 'findByUri'])
-			->getMock();
-		$this->principal->method('getPrincipalByPath')
-			->willReturn([
-				'uri' => 'principals/best-friend',
-				'{DAV:}displayname' => 'User\'s displayname',
-			]);
-		$this->principal->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP]);
-		$this->dispatcher = $this->createMock(IEventDispatcher::class);
-		$this->remoteUserPrincipalBackend = $this->createMock(RemoteUserPrincipalBackend::class);
-		$this->federationSharingService = $this->createMock(FederationSharingService::class);
-
-		$this->db = Server::get(IDBConnection::class);
-		$this->sharingBackend = new Backend($this->userManager,
-			$this->groupManager,
-			$this->principal,
-			$this->remoteUserPrincipalBackend,
-			$this->createMock(ICacheFactory::class),
-			new Service(new SharingMapper($this->db)),
-			$this->federationSharingService,
-			$this->createMock(LoggerInterface::class)
-		);
-
-		$this->backend = new CardDavBackend($this->db,
-			$this->principal,
-			$this->userManager,
-			$this->dispatcher,
-			$this->sharingBackend,
-			$this->config,
-		);
-		// start every test with a empty cards_properties and cards table
-		$query = $this->db->getQueryBuilder();
-		$query->delete('cards_properties')->executeStatement();
-		$query = $this->db->getQueryBuilder();
-		$query->delete('cards')->executeStatement();
-
-		$this->principal->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP]);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		foreach ($books as $book) {
-			$this->backend->deleteAddressBook($book['id']);
-		}
-	}
-
-	protected function tearDown(): void {
-		if (is_null($this->backend)) {
-			return;
-		}
-
-		$this->principal->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP]);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		foreach ($books as $book) {
-			$this->backend->deleteAddressBook($book['id']);
-		}
-
-		parent::tearDown();
-	}
-
-	public function testAddressBookOperations(): void {
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-
-		$this->assertEquals(1, $this->backend->getAddressBooksForUserCount(self::UNIT_TEST_USER));
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$this->assertEquals('Example', $books[0]['{DAV:}displayname']);
-		$this->assertEquals('User\'s displayname', $books[0]['{http://nextcloud.com/ns}owner-displayname']);
-
-		// update its display name
-		$patch = new PropPatch([
-			'{DAV:}displayname' => 'Unit test',
-			'{urn:ietf:params:xml:ns:carddav}addressbook-description' => 'Addressbook used for unit testing'
-		]);
-		$this->backend->updateAddressBook($books[0]['id'], $patch);
-		$patch->commit();
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$this->assertEquals('Unit test', $books[0]['{DAV:}displayname']);
-		$this->assertEquals('Addressbook used for unit testing', $books[0]['{urn:ietf:params:xml:ns:carddav}addressbook-description']);
-
-		// delete the address book
-		$this->backend->deleteAddressBook($books[0]['id']);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(0, count($books));
-	}
-
-	public function testAddressBookSharing(): void {
-		$this->userManager->expects($this->any())
-			->method('userExists')
-			->willReturn(true);
-		$this->groupManager->expects($this->any())
-			->method('groupExists')
-			->willReturn(true);
-		$this->principal->expects(self::atLeastOnce())
-			->method('findByUri')
-			->willReturnOnConsecutiveCalls(self::UNIT_TEST_USER1, self::UNIT_TEST_GROUP);
-
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$l = $this->createMock(IL10N::class);
-		$addressBook = new AddressBook($this->backend, $books[0], $l);
-		$this->backend->updateShares($addressBook, [
-			[
-				'href' => 'principal:' . self::UNIT_TEST_USER1,
-			],
-			[
-				'href' => 'principal:' . self::UNIT_TEST_GROUP,
-			]
-		], []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
-		$this->assertEquals(1, count($books));
-
-		// delete the address book
-		$this->backend->deleteAddressBook($books[0]['id']);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(0, count($books));
-	}
-
-	public function testCardOperations(): void {
-		/** @var CardDavBackend&MockObject $backend */
-		$backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
-			->onlyMethods(['updateProperties', 'purgeProperties'])
-			->getMock();
-
-		// create a new address book
-		$backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		$uri = $this->getUniqueID('card');
-		// updateProperties is expected twice, once for createCard and once for updateCard
-		$calls = [
-			[$bookId, $uri, $this->vcardTest0],
-			[$bookId, $uri, $this->vcardTest1],
-		];
-		$backend->expects($this->exactly(count($calls)))
-			->method('updateProperties')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-
-		// Expect event
-		$this->dispatcher
-			->expects($this->exactly(3))
-			->method('dispatchTyped');
-
-		// create a card
-		$backend->createCard($bookId, $uri, $this->vcardTest0);
-
-		// get all the cards
-		$cards = $backend->getCards($bookId);
-		$this->assertEquals(1, count($cards));
-		$this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
-
-		// get the cards
-		$card = $backend->getCard($bookId, $uri);
-		$this->assertNotNull($card);
-		$this->assertArrayHasKey('id', $card);
-		$this->assertArrayHasKey('uri', $card);
-		$this->assertArrayHasKey('lastmodified', $card);
-		$this->assertArrayHasKey('etag', $card);
-		$this->assertArrayHasKey('size', $card);
-		$this->assertEquals($this->vcardTest0, $card['carddata']);
-
-		// update the card
-		$backend->updateCard($bookId, $uri, $this->vcardTest1);
-		$card = $backend->getCard($bookId, $uri);
-		$this->assertEquals($this->vcardTest1, $card['carddata']);
-
-		// delete the card
-		$backend->expects($this->once())->method('purgeProperties')->with($bookId, $card['id']);
-		$backend->deleteCard($bookId, $uri);
-		$cards = $backend->getCards($bookId);
-		$this->assertEquals(0, count($cards));
-	}
-
-	public function testMultiCard(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// create a card
-		$uri0 = self::getUniqueID('card');
-		$this->backend->createCard($bookId, $uri0, $this->vcardTest0);
-		$uri1 = self::getUniqueID('card');
-		$this->backend->createCard($bookId, $uri1, $this->vcardTest1);
-		$uri2 = self::getUniqueID('card');
-		$this->backend->createCard($bookId, $uri2, $this->vcardTest2);
-
-		// get all the cards
-		$cards = $this->backend->getCards($bookId);
-		$this->assertEquals(3, count($cards));
-		usort($cards, function ($a, $b) {
-			return $a['id'] < $b['id'] ? -1 : 1;
-		});
-
-		$this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
-		$this->assertEquals($this->vcardTest1, $cards[1]['carddata']);
-		$this->assertEquals($this->vcardTest2, $cards[2]['carddata']);
-
-		// get the cards 1 & 2 (not 0)
-		$cards = $this->backend->getMultipleCards($bookId, [$uri1, $uri2]);
-		$this->assertEquals(2, count($cards));
-		usort($cards, function ($a, $b) {
-			return $a['id'] < $b['id'] ? -1 : 1;
-		});
-		foreach ($cards as $index => $card) {
-			$this->assertArrayHasKey('id', $card);
-			$this->assertArrayHasKey('uri', $card);
-			$this->assertArrayHasKey('lastmodified', $card);
-			$this->assertArrayHasKey('etag', $card);
-			$this->assertArrayHasKey('size', $card);
-			$this->assertEquals($this->{ 'vcardTest' . ($index + 1) }, $card['carddata']);
-		}
-
-		// delete the card
-		$this->backend->deleteCard($bookId, $uri0);
-		$this->backend->deleteCard($bookId, $uri1);
-		$this->backend->deleteCard($bookId, $uri2);
-		$cards = $this->backend->getCards($bookId);
-		$this->assertEquals(0, count($cards));
-	}
-
-	public function testMultipleUIDOnDifferentAddressbooks(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create 2 new address books
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example2', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(2, count($books));
-		$bookId0 = $books[0]['id'];
-		$bookId1 = $books[1]['id'];
-
-		// create a card
-		$uri0 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId0, $uri0, $this->vcardTest0);
-
-		// create another card with same uid but in second address book
-		$uri1 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId1, $uri1, $this->vcardTest0);
-	}
-
-	public function testMultipleUIDDenied(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// create a card
-		$uri0 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId, $uri0, $this->vcardTest0);
-
-		// create another card with same uid
-		$uri1 = $this->getUniqueID('card');
-		$this->expectException(BadRequest::class);
-		$test = $this->backend->createCard($bookId, $uri1, $this->vcardTest0);
-	}
-
-	public function testNoValidUID(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// create a card without uid
-		$uri1 = $this->getUniqueID('card');
-		$this->expectException(BadRequest::class);
-		$test = $this->backend->createCard($bookId, $uri1, $this->vcardTestNoUID);
-	}
-
-	public function testDeleteWithoutCard(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
-			->onlyMethods([
-				'getCardId',
-				'addChange',
-				'purgeProperties',
-				'updateProperties',
-			])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getUsersOwnAddressBooks(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-
-		$bookId = $books[0]['id'];
-		$uri = $this->getUniqueID('card');
-
-		// create a new address book
-		$this->backend->expects($this->once())
-			->method('getCardId')
-			->with($bookId, $uri)
-			->willThrowException(new \InvalidArgumentException());
-
-		$calls = [
-			[$bookId, $uri, 1],
-			[$bookId, $uri, 3],
-		];
-		$this->backend->expects($this->exactly(count($calls)))
-			->method('addChange')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-		$this->backend->expects($this->never())
-			->method('purgeProperties');
-
-		// create a card
-		$this->backend->createCard($bookId, $uri, $this->vcardTest0);
-
-		// delete the card
-		$this->assertTrue($this->backend->deleteCard($bookId, $uri));
-	}
-
-	public function testSyncSupport(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// fist call without synctoken
-		$changes = $this->backend->getChangesForAddressBook($bookId, '', 1);
-		$syncToken = $changes['syncToken'];
-
-		// add a change
-		$uri0 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId, $uri0, $this->vcardTest0);
-
-		// look for changes
-		$changes = $this->backend->getChangesForAddressBook($bookId, $syncToken, 1);
-		$this->assertEquals($uri0, $changes['added'][0]);
-	}
-
-	public function testSharing(): void {
-		$this->userManager->expects($this->any())
-			->method('userExists')
-			->willReturn(true);
-		$this->groupManager->expects($this->any())
-			->method('groupExists')
-			->willReturn(true);
-		$this->principal->expects(self::any())
-			->method('findByUri')
-			->willReturn(self::UNIT_TEST_USER1);
-
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-
-		$l = $this->createMock(IL10N::class);
-		$exampleBook = new AddressBook($this->backend, $books[0], $l);
-		$this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
-
-		$shares = $this->backend->getShares($exampleBook->getResourceId());
-		$this->assertEquals(1, count($shares));
-
-		// adding the same sharee again has no effect
-		$this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
-
-		$shares = $this->backend->getShares($exampleBook->getResourceId());
-		$this->assertEquals(1, count($shares));
-
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
-		$this->assertEquals(1, count($books));
-
-		$this->backend->updateShares($exampleBook, [], ['principal:' . self::UNIT_TEST_USER1]);
-
-		$shares = $this->backend->getShares($exampleBook->getResourceId());
-		$this->assertEquals(0, count($shares));
-
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
-		$this->assertEquals(0, count($books));
-	}
-
-	public function testUpdateProperties(): void {
-		$bookId = 42;
-		$cardUri = 'card-uri';
-		$cardId = 2;
-
-		$backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
-			->onlyMethods(['getCardId'])->getMock();
-
-		$backend->expects($this->any())->method('getCardId')->willReturn($cardId);
-
-		// add properties for new vCard
-		$vCard = new VCard();
-		$vCard->UID = $cardUri;
-		$vCard->FN = 'John Doe';
-		$this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
-
-		$query = $this->db->getQueryBuilder();
-		$query->select('*')
-			->from('cards_properties')
-			->orderBy('name');
-
-		$qResult = $query->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-
-		$this->assertSame(2, count($result));
-
-		$this->assertSame('FN', $result[0]['name']);
-		$this->assertSame('John Doe', $result[0]['value']);
-		$this->assertSame($bookId, (int)$result[0]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[0]['cardid']);
-
-		$this->assertSame('UID', $result[1]['name']);
-		$this->assertSame($cardUri, $result[1]['value']);
-		$this->assertSame($bookId, (int)$result[1]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[1]['cardid']);
-
-		// update properties for existing vCard
-		$vCard = new VCard();
-		$vCard->UID = $cardUri;
-		$this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
-
-		$query = $this->db->getQueryBuilder();
-		$query->select('*')
-			->from('cards_properties');
-
-		$qResult = $query->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-
-		$this->assertSame(1, count($result));
-
-		$this->assertSame('UID', $result[0]['name']);
-		$this->assertSame($cardUri, $result[0]['value']);
-		$this->assertSame($bookId, (int)$result[0]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[0]['cardid']);
-	}
-
-	public function testPurgeProperties(): void {
-		$query = $this->db->getQueryBuilder();
-		$query->insert('cards_properties')
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'cardid' => $query->createNamedParameter(1),
-					'name' => $query->createNamedParameter('name1'),
-					'value' => $query->createNamedParameter('value1'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-
-		$query = $this->db->getQueryBuilder();
-		$query->insert('cards_properties')
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'cardid' => $query->createNamedParameter(2),
-					'name' => $query->createNamedParameter('name2'),
-					'value' => $query->createNamedParameter('value2'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-
-		$this->invokePrivate($this->backend, 'purgeProperties', [1, 1]);
-
-		$query = $this->db->getQueryBuilder();
-		$query->select('*')
-			->from('cards_properties');
-
-		$qResult = $query->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-
-		$this->assertSame(1, count($result));
-		$this->assertSame(1, (int)$result[0]['addressbookid']);
-		$this->assertSame(2, (int)$result[0]['cardid']);
-	}
-
-	public function testGetCardId(): void {
-		$query = $this->db->getQueryBuilder();
-
-		$query->insert('cards')
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'carddata' => $query->createNamedParameter(''),
-					'uri' => $query->createNamedParameter('uri'),
-					'lastmodified' => $query->createNamedParameter(4738743),
-					'etag' => $query->createNamedParameter('etag'),
-					'size' => $query->createNamedParameter(120)
-				]
-			);
-		$query->execute();
-		$id = $query->getLastInsertId();
-
-		$this->assertSame($id,
-			$this->invokePrivate($this->backend, 'getCardId', [1, 'uri']));
-	}
-
-
-	public function testGetCardIdFailed(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->invokePrivate($this->backend, 'getCardId', [1, 'uri']);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestSearch')]
-	public function testSearch(string $pattern, array $properties, array $options, array $expected): void {
-		/** @var VCard $vCards */
-		$vCards = [];
-		$vCards[0] = new VCard();
-		$vCards[0]->add(new Text($vCards[0], 'UID', 'uid'));
-		$vCards[0]->add(new Text($vCards[0], 'FN', 'John Doe'));
-		$vCards[0]->add(new Text($vCards[0], 'CLOUD', 'john@nextcloud.com'));
-		$vCards[1] = new VCard();
-		$vCards[1]->add(new Text($vCards[1], 'UID', 'uid'));
-		$vCards[1]->add(new Text($vCards[1], 'FN', 'John M. Doe'));
-		$vCards[2] = new VCard();
-		$vCards[2]->add(new Text($vCards[2], 'UID', 'uid'));
-		$vCards[2]->add(new Text($vCards[2], 'FN', 'find without options'));
-		$vCards[2]->add(new Text($vCards[2], 'CLOUD', 'peter_pan@nextcloud.com'));
-
-		$vCardIds = [];
-		$query = $this->db->getQueryBuilder();
-		for ($i = 0; $i < 3; $i++) {
-			$query->insert($this->dbCardsTable)
-				->values(
-					[
-						'addressbookid' => $query->createNamedParameter(0),
-						'carddata' => $query->createNamedParameter($vCards[$i]->serialize(), IQueryBuilder::PARAM_LOB),
-						'uri' => $query->createNamedParameter('uri' . $i),
-						'lastmodified' => $query->createNamedParameter(time()),
-						'etag' => $query->createNamedParameter('etag' . $i),
-						'size' => $query->createNamedParameter(120),
-					]
-				);
-			$query->execute();
-			$vCardIds[] = $query->getLastInsertId();
-		}
-
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[0]),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('John Doe'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[0]),
-					'name' => $query->createNamedParameter('CLOUD'),
-					'value' => $query->createNamedParameter('John@nextcloud.com'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[1]),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('John M. Doe'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[2]),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('find without options'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[2]),
-					'name' => $query->createNamedParameter('CLOUD'),
-					'value' => $query->createNamedParameter('peter_pan@nextcloud.com'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-
-		$result = $this->backend->search(0, $pattern, $properties, $options);
-
-		// check result
-		$this->assertSame(count($expected), count($result));
-		$found = [];
-		foreach ($result as $r) {
-			foreach ($expected as $exp) {
-				if ($r['uri'] === $exp[0] && strpos($r['carddata'], $exp[1]) > 0) {
-					$found[$exp[1]] = true;
-					break;
-				}
-			}
-		}
-
-		$this->assertSame(count($expected), count($found));
-	}
-
-	public static function dataTestSearch(): array {
-		return [
-			['John', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			['M. Doe', ['FN'], [], [['uri1', 'John M. Doe']]],
-			['Do', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			'check if duplicates are handled correctly' => ['John', ['FN', 'CLOUD'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			'case insensitive' => ['john', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			'limit' => ['john', ['FN'], ['limit' => 1], [['uri0', 'John Doe']]],
-			'limit and offset' => ['john', ['FN'], ['limit' => 1, 'offset' => 1], [['uri1', 'John M. Doe']]],
-			'find "_" escaped' => ['_', ['CLOUD'], [], [['uri2', 'find without options']]],
-			'find not empty CLOUD' => ['%_%', ['CLOUD'], ['escape_like_param' => false], [['uri0', 'John Doe'], ['uri2', 'find without options']]],
-		];
-	}
-
-	public function testGetCardUri(): void {
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'carddata' => $query->createNamedParameter('carddata', IQueryBuilder::PARAM_LOB),
-					'uri' => $query->createNamedParameter('uri'),
-					'lastmodified' => $query->createNamedParameter(5489543),
-					'etag' => $query->createNamedParameter('etag'),
-					'size' => $query->createNamedParameter(120),
-				]
-			);
-		$query->execute();
-
-		$id = $query->getLastInsertId();
-
-		$this->assertSame('uri', $this->backend->getCardUri($id));
-	}
-
-
-	public function testGetCardUriFailed(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->backend->getCardUri(1);
-	}
-
-	public function testGetContact(): void {
-		$query = $this->db->getQueryBuilder();
-		for ($i = 0; $i < 2; $i++) {
-			$query->insert($this->dbCardsTable)
-				->values(
-					[
-						'addressbookid' => $query->createNamedParameter($i),
-						'carddata' => $query->createNamedParameter('carddata' . $i, IQueryBuilder::PARAM_LOB),
-						'uri' => $query->createNamedParameter('uri' . $i),
-						'lastmodified' => $query->createNamedParameter(5489543),
-						'etag' => $query->createNamedParameter('etag' . $i),
-						'size' => $query->createNamedParameter(120),
-					]
-				);
-			$query->execute();
-		}
-
-		$result = $this->backend->getContact(0, 'uri0');
-		$this->assertSame(8, count($result));
-		$this->assertSame(0, (int)$result['addressbookid']);
-		$this->assertSame('uri0', $result['uri']);
-		$this->assertSame(5489543, (int)$result['lastmodified']);
-		$this->assertSame('"etag0"', $result['etag']);
-		$this->assertSame(120, (int)$result['size']);
-
-		// this shouldn't return any result because 'uri1' is in address book 1
-		// see https://github.com/nextcloud/server/issues/229
-		$result = $this->backend->getContact(0, 'uri1');
-		$this->assertEmpty($result);
-	}
-
-	public function testGetContactFail(): void {
-		$this->assertEmpty($this->backend->getContact(0, 'uri'));
-	}
-
-	public function testCollectCardProperties(): void {
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(666),
-					'cardid' => $query->createNamedParameter(777),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('John Doe'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			)
-			->execute();
-
-		$result = $this->backend->collectCardProperties(666, 'FN');
-		$this->assertEquals(['John Doe'], $result);
-	}
-
-	/**
-	 * @throws \OCP\DB\Exception
-	 * @throws \Sabre\DAV\Exception\BadRequest
-	 */
-	public function testPruneOutdatedSyncTokens(): void {
-		$addressBookId = $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, '', 1);
-		$syncToken = $changes['syncToken'];
-
-		$uri = $this->getUniqueID('card');
-		$this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
-		$this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
-
-		// Do not delete anything if week data as old as ts=0
-		$deleted = $this->backend->pruneOutdatedSyncTokens(0, 0);
-		self::assertSame(0, $deleted);
-
-		$deleted = $this->backend->pruneOutdatedSyncTokens(0, time());
-		// At least one from the object creation and one from the object update
-		$this->assertGreaterThanOrEqual(2, $deleted);
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 1);
-		$this->assertEmpty($changes['added']);
-		$this->assertEmpty($changes['modified']);
-		$this->assertEmpty($changes['deleted']);
-
-		// Test that objects remain
-
-		// Currently changes are empty
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEquals(0, count($changes['added'] + $changes['modified'] + $changes['deleted']));
-
-		// Create card
-		$uri = $this->getUniqueID('card');
-		$this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
-		// We now have one add
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEquals(1, count($changes['added']));
-		$this->assertEmpty($changes['modified']);
-		$this->assertEmpty($changes['deleted']);
-
-		// Update card
-		$this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
-		// One add, one modify, but shortened to modify
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEmpty($changes['added']);
-		$this->assertEquals(1, count($changes['modified']));
-		$this->assertEmpty($changes['deleted']);
-
-		// Delete all but last change
-		$deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
-		$this->assertEquals(1, $deleted); // We had two changes before, now one
-
-		// Only update should remain
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEmpty($changes['added']);
-		$this->assertEquals(1, count($changes['modified']));
-		$this->assertEmpty($changes['deleted']);
-
-		// Check that no crash occurs when prune is called without current changes
-		$deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
-	}
+    private Principal&MockObject $principal;
+    private IUserManager&MockObject $userManager;
+    private IGroupManager&MockObject $groupManager;
+    private IEventDispatcher&MockObject $dispatcher;
+    private IConfig&MockObject $config;
+    private RemoteUserPrincipalBackend&MockObject $remoteUserPrincipalBackend;
+    private FederationSharingService&MockObject $federationSharingService;
+    private Backend $sharingBackend;
+    private IDBConnection $db;
+    private CardDavBackend $backend;
+    private string $dbCardsTable = 'cards';
+    private string $dbCardsPropertiesTable = 'cards_properties';
+
+    public const UNIT_TEST_USER = 'principals/users/carddav-unit-test';
+    public const UNIT_TEST_USER1 = 'principals/users/carddav-unit-test1';
+    public const UNIT_TEST_GROUP = 'principals/groups/carddav-unit-test-group';
+
+    private $vcardTest0 = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'UID:Test' . PHP_EOL
+        . 'FN:Test' . PHP_EOL
+        . 'N:Test;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    private $vcardTest1 = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'UID:Test2' . PHP_EOL
+        . 'FN:Test2' . PHP_EOL
+        . 'N:Test2;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    private $vcardTest2 = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'UID:Test3' . PHP_EOL
+        . 'FN:Test3' . PHP_EOL
+        . 'N:Test3;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    private $vcardTestNoUID = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'FN:TestNoUID' . PHP_EOL
+        . 'N:TestNoUID;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->principal = $this->getMockBuilder(Principal::class)
+            ->setConstructorArgs([
+                $this->userManager,
+                $this->groupManager,
+                $this->createMock(IAccountManager::class),
+                $this->createMock(ShareManager::class),
+                $this->createMock(IUserSession::class),
+                $this->createMock(IAppManager::class),
+                $this->createMock(ProxyMapper::class),
+                $this->createMock(KnownUserService::class),
+                $this->config,
+                $this->createMock(IFactory::class)
+            ])
+            ->onlyMethods(['getPrincipalByPath', 'getGroupMembership', 'findByUri'])
+            ->getMock();
+        $this->principal->method('getPrincipalByPath')
+            ->willReturn([
+                'uri' => 'principals/best-friend',
+                '{DAV:}displayname' => 'User\'s displayname',
+            ]);
+        $this->principal->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP]);
+        $this->dispatcher = $this->createMock(IEventDispatcher::class);
+        $this->remoteUserPrincipalBackend = $this->createMock(RemoteUserPrincipalBackend::class);
+        $this->federationSharingService = $this->createMock(FederationSharingService::class);
+
+        $this->db = Server::get(IDBConnection::class);
+        $this->sharingBackend = new Backend($this->userManager,
+            $this->groupManager,
+            $this->principal,
+            $this->remoteUserPrincipalBackend,
+            $this->createMock(ICacheFactory::class),
+            new Service(new SharingMapper($this->db)),
+            $this->federationSharingService,
+            $this->createMock(LoggerInterface::class)
+        );
+
+        $this->backend = new CardDavBackend($this->db,
+            $this->principal,
+            $this->userManager,
+            $this->dispatcher,
+            $this->sharingBackend,
+            $this->config,
+        );
+        // start every test with a empty cards_properties and cards table
+        $query = $this->db->getQueryBuilder();
+        $query->delete('cards_properties')->executeStatement();
+        $query = $this->db->getQueryBuilder();
+        $query->delete('cards')->executeStatement();
+
+        $this->principal->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP]);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        foreach ($books as $book) {
+            $this->backend->deleteAddressBook($book['id']);
+        }
+    }
+
+    protected function tearDown(): void {
+        if (is_null($this->backend)) {
+            return;
+        }
+
+        $this->principal->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP]);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        foreach ($books as $book) {
+            $this->backend->deleteAddressBook($book['id']);
+        }
+
+        parent::tearDown();
+    }
+
+    public function testAddressBookOperations(): void {
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+
+        $this->assertEquals(1, $this->backend->getAddressBooksForUserCount(self::UNIT_TEST_USER));
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $this->assertEquals('Example', $books[0]['{DAV:}displayname']);
+        $this->assertEquals('User\'s displayname', $books[0]['{http://nextcloud.com/ns}owner-displayname']);
+
+        // update its display name
+        $patch = new PropPatch([
+            '{DAV:}displayname' => 'Unit test',
+            '{urn:ietf:params:xml:ns:carddav}addressbook-description' => 'Addressbook used for unit testing'
+        ]);
+        $this->backend->updateAddressBook($books[0]['id'], $patch);
+        $patch->commit();
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $this->assertEquals('Unit test', $books[0]['{DAV:}displayname']);
+        $this->assertEquals('Addressbook used for unit testing', $books[0]['{urn:ietf:params:xml:ns:carddav}addressbook-description']);
+
+        // delete the address book
+        $this->backend->deleteAddressBook($books[0]['id']);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(0, count($books));
+    }
+
+    public function testAddressBookSharing(): void {
+        $this->userManager->expects($this->any())
+            ->method('userExists')
+            ->willReturn(true);
+        $this->groupManager->expects($this->any())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->principal->expects(self::atLeastOnce())
+            ->method('findByUri')
+            ->willReturnOnConsecutiveCalls(self::UNIT_TEST_USER1, self::UNIT_TEST_GROUP);
+
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $l = $this->createMock(IL10N::class);
+        $addressBook = new AddressBook($this->backend, $books[0], $l);
+        $this->backend->updateShares($addressBook, [
+            [
+                'href' => 'principal:' . self::UNIT_TEST_USER1,
+            ],
+            [
+                'href' => 'principal:' . self::UNIT_TEST_GROUP,
+            ]
+        ], []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
+        $this->assertEquals(1, count($books));
+
+        // delete the address book
+        $this->backend->deleteAddressBook($books[0]['id']);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(0, count($books));
+    }
+
+    public function testCardOperations(): void {
+        /** @var CardDavBackend&MockObject $backend */
+        $backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
+            ->onlyMethods(['updateProperties', 'purgeProperties'])
+            ->getMock();
+
+        // create a new address book
+        $backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        $uri = $this->getUniqueID('card');
+        // updateProperties is expected twice, once for createCard and once for updateCard
+        $calls = [
+            [$bookId, $uri, $this->vcardTest0],
+            [$bookId, $uri, $this->vcardTest1],
+        ];
+        $backend->expects($this->exactly(count($calls)))
+            ->method('updateProperties')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+
+        // Expect event
+        $this->dispatcher
+            ->expects($this->exactly(3))
+            ->method('dispatchTyped');
+
+        // create a card
+        $backend->createCard($bookId, $uri, $this->vcardTest0);
+
+        // get all the cards
+        $cards = $backend->getCards($bookId);
+        $this->assertEquals(1, count($cards));
+        $this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
+
+        // get the cards
+        $card = $backend->getCard($bookId, $uri);
+        $this->assertNotNull($card);
+        $this->assertArrayHasKey('id', $card);
+        $this->assertArrayHasKey('uri', $card);
+        $this->assertArrayHasKey('lastmodified', $card);
+        $this->assertArrayHasKey('etag', $card);
+        $this->assertArrayHasKey('size', $card);
+        $this->assertEquals($this->vcardTest0, $card['carddata']);
+
+        // update the card
+        $backend->updateCard($bookId, $uri, $this->vcardTest1);
+        $card = $backend->getCard($bookId, $uri);
+        $this->assertEquals($this->vcardTest1, $card['carddata']);
+
+        // delete the card
+        $backend->expects($this->once())->method('purgeProperties')->with($bookId, $card['id']);
+        $backend->deleteCard($bookId, $uri);
+        $cards = $backend->getCards($bookId);
+        $this->assertEquals(0, count($cards));
+    }
+
+    public function testMultiCard(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // create a card
+        $uri0 = self::getUniqueID('card');
+        $this->backend->createCard($bookId, $uri0, $this->vcardTest0);
+        $uri1 = self::getUniqueID('card');
+        $this->backend->createCard($bookId, $uri1, $this->vcardTest1);
+        $uri2 = self::getUniqueID('card');
+        $this->backend->createCard($bookId, $uri2, $this->vcardTest2);
+
+        // get all the cards
+        $cards = $this->backend->getCards($bookId);
+        $this->assertEquals(3, count($cards));
+        usort($cards, function ($a, $b) {
+            return $a['id'] < $b['id'] ? -1 : 1;
+        });
+
+        $this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
+        $this->assertEquals($this->vcardTest1, $cards[1]['carddata']);
+        $this->assertEquals($this->vcardTest2, $cards[2]['carddata']);
+
+        // get the cards 1 & 2 (not 0)
+        $cards = $this->backend->getMultipleCards($bookId, [$uri1, $uri2]);
+        $this->assertEquals(2, count($cards));
+        usort($cards, function ($a, $b) {
+            return $a['id'] < $b['id'] ? -1 : 1;
+        });
+        foreach ($cards as $index => $card) {
+            $this->assertArrayHasKey('id', $card);
+            $this->assertArrayHasKey('uri', $card);
+            $this->assertArrayHasKey('lastmodified', $card);
+            $this->assertArrayHasKey('etag', $card);
+            $this->assertArrayHasKey('size', $card);
+            $this->assertEquals($this->{ 'vcardTest' . ($index + 1) }, $card['carddata']);
+        }
+
+        // delete the card
+        $this->backend->deleteCard($bookId, $uri0);
+        $this->backend->deleteCard($bookId, $uri1);
+        $this->backend->deleteCard($bookId, $uri2);
+        $cards = $this->backend->getCards($bookId);
+        $this->assertEquals(0, count($cards));
+    }
+
+    public function testMultipleUIDOnDifferentAddressbooks(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create 2 new address books
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example2', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(2, count($books));
+        $bookId0 = $books[0]['id'];
+        $bookId1 = $books[1]['id'];
+
+        // create a card
+        $uri0 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId0, $uri0, $this->vcardTest0);
+
+        // create another card with same uid but in second address book
+        $uri1 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId1, $uri1, $this->vcardTest0);
+    }
+
+    public function testMultipleUIDDenied(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // create a card
+        $uri0 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId, $uri0, $this->vcardTest0);
+
+        // create another card with same uid
+        $uri1 = $this->getUniqueID('card');
+        $this->expectException(BadRequest::class);
+        $test = $this->backend->createCard($bookId, $uri1, $this->vcardTest0);
+    }
+
+    public function testNoValidUID(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // create a card without uid
+        $uri1 = $this->getUniqueID('card');
+        $this->expectException(BadRequest::class);
+        $test = $this->backend->createCard($bookId, $uri1, $this->vcardTestNoUID);
+    }
+
+    public function testDeleteWithoutCard(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
+            ->onlyMethods([
+                'getCardId',
+                'addChange',
+                'purgeProperties',
+                'updateProperties',
+            ])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getUsersOwnAddressBooks(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+
+        $bookId = $books[0]['id'];
+        $uri = $this->getUniqueID('card');
+
+        // create a new address book
+        $this->backend->expects($this->once())
+            ->method('getCardId')
+            ->with($bookId, $uri)
+            ->willThrowException(new \InvalidArgumentException());
+
+        $calls = [
+            [$bookId, $uri, 1],
+            [$bookId, $uri, 3],
+        ];
+        $this->backend->expects($this->exactly(count($calls)))
+            ->method('addChange')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+        $this->backend->expects($this->never())
+            ->method('purgeProperties');
+
+        // create a card
+        $this->backend->createCard($bookId, $uri, $this->vcardTest0);
+
+        // delete the card
+        $this->assertTrue($this->backend->deleteCard($bookId, $uri));
+    }
+
+    public function testSyncSupport(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // fist call without synctoken
+        $changes = $this->backend->getChangesForAddressBook($bookId, '', 1);
+        $syncToken = $changes['syncToken'];
+
+        // add a change
+        $uri0 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId, $uri0, $this->vcardTest0);
+
+        // look for changes
+        $changes = $this->backend->getChangesForAddressBook($bookId, $syncToken, 1);
+        $this->assertEquals($uri0, $changes['added'][0]);
+    }
+
+    public function testSharing(): void {
+        $this->userManager->expects($this->any())
+            ->method('userExists')
+            ->willReturn(true);
+        $this->groupManager->expects($this->any())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->principal->expects(self::any())
+            ->method('findByUri')
+            ->willReturn(self::UNIT_TEST_USER1);
+
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+
+        $l = $this->createMock(IL10N::class);
+        $exampleBook = new AddressBook($this->backend, $books[0], $l);
+        $this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
+
+        $shares = $this->backend->getShares($exampleBook->getResourceId());
+        $this->assertEquals(1, count($shares));
+
+        // adding the same sharee again has no effect
+        $this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
+
+        $shares = $this->backend->getShares($exampleBook->getResourceId());
+        $this->assertEquals(1, count($shares));
+
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
+        $this->assertEquals(1, count($books));
+
+        $this->backend->updateShares($exampleBook, [], ['principal:' . self::UNIT_TEST_USER1]);
+
+        $shares = $this->backend->getShares($exampleBook->getResourceId());
+        $this->assertEquals(0, count($shares));
+
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
+        $this->assertEquals(0, count($books));
+    }
+
+    public function testUpdateProperties(): void {
+        $bookId = 42;
+        $cardUri = 'card-uri';
+        $cardId = 2;
+
+        $backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
+            ->onlyMethods(['getCardId'])->getMock();
+
+        $backend->expects($this->any())->method('getCardId')->willReturn($cardId);
+
+        // add properties for new vCard
+        $vCard = new VCard();
+        $vCard->UID = $cardUri;
+        $vCard->FN = 'John Doe';
+        $this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
+
+        $query = $this->db->getQueryBuilder();
+        $query->select('*')
+            ->from('cards_properties')
+            ->orderBy('name');
+
+        $qResult = $query->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+
+        $this->assertSame(2, count($result));
+
+        $this->assertSame('FN', $result[0]['name']);
+        $this->assertSame('John Doe', $result[0]['value']);
+        $this->assertSame($bookId, (int)$result[0]['addressbookid']);
+        $this->assertSame($cardId, (int)$result[0]['cardid']);
+
+        $this->assertSame('UID', $result[1]['name']);
+        $this->assertSame($cardUri, $result[1]['value']);
+        $this->assertSame($bookId, (int)$result[1]['addressbookid']);
+        $this->assertSame($cardId, (int)$result[1]['cardid']);
+
+        // update properties for existing vCard
+        $vCard = new VCard();
+        $vCard->UID = $cardUri;
+        $this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
+
+        $query = $this->db->getQueryBuilder();
+        $query->select('*')
+            ->from('cards_properties');
+
+        $qResult = $query->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+
+        $this->assertSame(1, count($result));
+
+        $this->assertSame('UID', $result[0]['name']);
+        $this->assertSame($cardUri, $result[0]['value']);
+        $this->assertSame($bookId, (int)$result[0]['addressbookid']);
+        $this->assertSame($cardId, (int)$result[0]['cardid']);
+    }
+
+    public function testPurgeProperties(): void {
+        $query = $this->db->getQueryBuilder();
+        $query->insert('cards_properties')
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'cardid' => $query->createNamedParameter(1),
+                    'name' => $query->createNamedParameter('name1'),
+                    'value' => $query->createNamedParameter('value1'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+
+        $query = $this->db->getQueryBuilder();
+        $query->insert('cards_properties')
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'cardid' => $query->createNamedParameter(2),
+                    'name' => $query->createNamedParameter('name2'),
+                    'value' => $query->createNamedParameter('value2'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+
+        $this->invokePrivate($this->backend, 'purgeProperties', [1, 1]);
+
+        $query = $this->db->getQueryBuilder();
+        $query->select('*')
+            ->from('cards_properties');
+
+        $qResult = $query->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+
+        $this->assertSame(1, count($result));
+        $this->assertSame(1, (int)$result[0]['addressbookid']);
+        $this->assertSame(2, (int)$result[0]['cardid']);
+    }
+
+    public function testGetCardId(): void {
+        $query = $this->db->getQueryBuilder();
+
+        $query->insert('cards')
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'carddata' => $query->createNamedParameter(''),
+                    'uri' => $query->createNamedParameter('uri'),
+                    'lastmodified' => $query->createNamedParameter(4738743),
+                    'etag' => $query->createNamedParameter('etag'),
+                    'size' => $query->createNamedParameter(120)
+                ]
+            );
+        $query->execute();
+        $id = $query->getLastInsertId();
+
+        $this->assertSame($id,
+            $this->invokePrivate($this->backend, 'getCardId', [1, 'uri']));
+    }
+
+
+    public function testGetCardIdFailed(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->invokePrivate($this->backend, 'getCardId', [1, 'uri']);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestSearch')]
+    public function testSearch(string $pattern, array $properties, array $options, array $expected): void {
+        /** @var VCard $vCards */
+        $vCards = [];
+        $vCards[0] = new VCard();
+        $vCards[0]->add(new Text($vCards[0], 'UID', 'uid'));
+        $vCards[0]->add(new Text($vCards[0], 'FN', 'John Doe'));
+        $vCards[0]->add(new Text($vCards[0], 'CLOUD', 'john@nextcloud.com'));
+        $vCards[1] = new VCard();
+        $vCards[1]->add(new Text($vCards[1], 'UID', 'uid'));
+        $vCards[1]->add(new Text($vCards[1], 'FN', 'John M. Doe'));
+        $vCards[2] = new VCard();
+        $vCards[2]->add(new Text($vCards[2], 'UID', 'uid'));
+        $vCards[2]->add(new Text($vCards[2], 'FN', 'find without options'));
+        $vCards[2]->add(new Text($vCards[2], 'CLOUD', 'peter_pan@nextcloud.com'));
+
+        $vCardIds = [];
+        $query = $this->db->getQueryBuilder();
+        for ($i = 0; $i < 3; $i++) {
+            $query->insert($this->dbCardsTable)
+                ->values(
+                    [
+                        'addressbookid' => $query->createNamedParameter(0),
+                        'carddata' => $query->createNamedParameter($vCards[$i]->serialize(), IQueryBuilder::PARAM_LOB),
+                        'uri' => $query->createNamedParameter('uri' . $i),
+                        'lastmodified' => $query->createNamedParameter(time()),
+                        'etag' => $query->createNamedParameter('etag' . $i),
+                        'size' => $query->createNamedParameter(120),
+                    ]
+                );
+            $query->execute();
+            $vCardIds[] = $query->getLastInsertId();
+        }
+
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[0]),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('John Doe'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[0]),
+                    'name' => $query->createNamedParameter('CLOUD'),
+                    'value' => $query->createNamedParameter('John@nextcloud.com'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[1]),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('John M. Doe'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[2]),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('find without options'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[2]),
+                    'name' => $query->createNamedParameter('CLOUD'),
+                    'value' => $query->createNamedParameter('peter_pan@nextcloud.com'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+
+        $result = $this->backend->search(0, $pattern, $properties, $options);
+
+        // check result
+        $this->assertSame(count($expected), count($result));
+        $found = [];
+        foreach ($result as $r) {
+            foreach ($expected as $exp) {
+                if ($r['uri'] === $exp[0] && strpos($r['carddata'], $exp[1]) > 0) {
+                    $found[$exp[1]] = true;
+                    break;
+                }
+            }
+        }
+
+        $this->assertSame(count($expected), count($found));
+    }
+
+    public static function dataTestSearch(): array {
+        return [
+            ['John', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            ['M. Doe', ['FN'], [], [['uri1', 'John M. Doe']]],
+            ['Do', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            'check if duplicates are handled correctly' => ['John', ['FN', 'CLOUD'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            'case insensitive' => ['john', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            'limit' => ['john', ['FN'], ['limit' => 1], [['uri0', 'John Doe']]],
+            'limit and offset' => ['john', ['FN'], ['limit' => 1, 'offset' => 1], [['uri1', 'John M. Doe']]],
+            'find "_" escaped' => ['_', ['CLOUD'], [], [['uri2', 'find without options']]],
+            'find not empty CLOUD' => ['%_%', ['CLOUD'], ['escape_like_param' => false], [['uri0', 'John Doe'], ['uri2', 'find without options']]],
+        ];
+    }
+
+    public function testGetCardUri(): void {
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'carddata' => $query->createNamedParameter('carddata', IQueryBuilder::PARAM_LOB),
+                    'uri' => $query->createNamedParameter('uri'),
+                    'lastmodified' => $query->createNamedParameter(5489543),
+                    'etag' => $query->createNamedParameter('etag'),
+                    'size' => $query->createNamedParameter(120),
+                ]
+            );
+        $query->execute();
+
+        $id = $query->getLastInsertId();
+
+        $this->assertSame('uri', $this->backend->getCardUri($id));
+    }
+
+
+    public function testGetCardUriFailed(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->backend->getCardUri(1);
+    }
+
+    public function testGetContact(): void {
+        $query = $this->db->getQueryBuilder();
+        for ($i = 0; $i < 2; $i++) {
+            $query->insert($this->dbCardsTable)
+                ->values(
+                    [
+                        'addressbookid' => $query->createNamedParameter($i),
+                        'carddata' => $query->createNamedParameter('carddata' . $i, IQueryBuilder::PARAM_LOB),
+                        'uri' => $query->createNamedParameter('uri' . $i),
+                        'lastmodified' => $query->createNamedParameter(5489543),
+                        'etag' => $query->createNamedParameter('etag' . $i),
+                        'size' => $query->createNamedParameter(120),
+                    ]
+                );
+            $query->execute();
+        }
+
+        $result = $this->backend->getContact(0, 'uri0');
+        $this->assertSame(8, count($result));
+        $this->assertSame(0, (int)$result['addressbookid']);
+        $this->assertSame('uri0', $result['uri']);
+        $this->assertSame(5489543, (int)$result['lastmodified']);
+        $this->assertSame('"etag0"', $result['etag']);
+        $this->assertSame(120, (int)$result['size']);
+
+        // this shouldn't return any result because 'uri1' is in address book 1
+        // see https://github.com/nextcloud/server/issues/229
+        $result = $this->backend->getContact(0, 'uri1');
+        $this->assertEmpty($result);
+    }
+
+    public function testGetContactFail(): void {
+        $this->assertEmpty($this->backend->getContact(0, 'uri'));
+    }
+
+    public function testCollectCardProperties(): void {
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(666),
+                    'cardid' => $query->createNamedParameter(777),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('John Doe'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            )
+            ->execute();
+
+        $result = $this->backend->collectCardProperties(666, 'FN');
+        $this->assertEquals(['John Doe'], $result);
+    }
+
+    /**
+     * @throws \OCP\DB\Exception
+     * @throws \Sabre\DAV\Exception\BadRequest
+     */
+    public function testPruneOutdatedSyncTokens(): void {
+        $addressBookId = $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, '', 1);
+        $syncToken = $changes['syncToken'];
+
+        $uri = $this->getUniqueID('card');
+        $this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
+        $this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
+
+        // Do not delete anything if week data as old as ts=0
+        $deleted = $this->backend->pruneOutdatedSyncTokens(0, 0);
+        self::assertSame(0, $deleted);
+
+        $deleted = $this->backend->pruneOutdatedSyncTokens(0, time());
+        // At least one from the object creation and one from the object update
+        $this->assertGreaterThanOrEqual(2, $deleted);
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 1);
+        $this->assertEmpty($changes['added']);
+        $this->assertEmpty($changes['modified']);
+        $this->assertEmpty($changes['deleted']);
+
+        // Test that objects remain
+
+        // Currently changes are empty
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEquals(0, count($changes['added'] + $changes['modified'] + $changes['deleted']));
+
+        // Create card
+        $uri = $this->getUniqueID('card');
+        $this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
+        // We now have one add
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEquals(1, count($changes['added']));
+        $this->assertEmpty($changes['modified']);
+        $this->assertEmpty($changes['deleted']);
+
+        // Update card
+        $this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
+        // One add, one modify, but shortened to modify
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEmpty($changes['added']);
+        $this->assertEquals(1, count($changes['modified']));
+        $this->assertEmpty($changes['deleted']);
+
+        // Delete all but last change
+        $deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
+        $this->assertEquals(1, $deleted); // We had two changes before, now one
+
+        // Only update should remain
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEmpty($changes['added']);
+        $this->assertEquals(1, count($changes['modified']));
+        $this->assertEmpty($changes['deleted']);
+
+        // Check that no crash occurs when prune is called without current changes
+        $deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
+    }
 }

apps/dav/appinfo/v1/caldav.php

Indentation +31 added lines, -31 removed lines

@@ -38,25 +38,25 @@ 
 use Psr\Log\LoggerInterface;
 
 $authBackend = new Auth(
-	Server::get(ISession::class),
-	Server::get(IUserSession::class),
-	Server::get(IRequest::class),
-	Server::get(\OC\Authentication\TwoFactorAuth\Manager::class),
-	Server::get(IThrottler::class),
-	'principals/'
+    Server::get(ISession::class),
+    Server::get(IUserSession::class),
+    Server::get(IRequest::class),
+    Server::get(\OC\Authentication\TwoFactorAuth\Manager::class),
+    Server::get(IThrottler::class),
+    'principals/'
 );
 $principalBackend = new Principal(
-	Server::get(IUserManager::class),
-	Server::get(IGroupManager::class),
-	Server::get(IAccountManager::class),
-	Server::get(\OCP\Share\IManager::class),
-	Server::get(IUserSession::class),
-	Server::get(IAppManager::class),
-	Server::get(ProxyMapper::class),
-	Server::get(KnownUserService::class),
-	Server::get(IConfig::class),
-	\OC::$server->getL10NFactory(),
-	'principals/'
+    Server::get(IUserManager::class),
+    Server::get(IGroupManager::class),
+    Server::get(IAccountManager::class),
+    Server::get(\OCP\Share\IManager::class),
+    Server::get(IUserSession::class),
+    Server::get(IAppManager::class),
+    Server::get(ProxyMapper::class),
+    Server::get(KnownUserService::class),
+    Server::get(IConfig::class),
+    \OC::$server->getL10NFactory(),
+    'principals/'
 );
 $db = Server::get(IDBConnection::class);
 $userManager = Server::get(IUserManager::class);
@@ -69,16 +69,16 @@ 
 $federatedCalendarFactory = Server::get(FederatedCalendarFactory::class);
 
 $calDavBackend = new CalDavBackend(
-	$db,
-	$principalBackend,
-	$userManager,
-	$random,
-	$logger,
-	$dispatcher,
-	$config,
-	Server::get(\OCA\DAV\CalDAV\Sharing\Backend::class),
-	Server::get(FederatedCalendarMapper::class),
-	true
+    $db,
+    $principalBackend,
+    $userManager,
+    $random,
+    $logger,
+    $dispatcher,
+    $config,
+    Server::get(\OCA\DAV\CalDAV\Sharing\Backend::class),
+    Server::get(FederatedCalendarMapper::class),
+    true
 );
 
 $debugging = Server::get(IConfig::class)->getSystemValue('debug', false);
@@ -92,8 +92,8 @@ 
 $addressBookRoot->disableListing = !$debugging; // Disable listing
 
 $nodes = [
-	$principalCollection,
-	$addressBookRoot,
+    $principalCollection,
+    $addressBookRoot,
 ];
 
 // Fire up server
@@ -109,7 +109,7 @@ 
 
 $server->addPlugin(new LegacyDAVACL());
 if ($debugging) {
-	$server->addPlugin(new Sabre\DAV\Browser\Plugin());
+    $server->addPlugin(new Sabre\DAV\Browser\Plugin());
 }
 
 $server->addPlugin(new \Sabre\DAV\Sync\Plugin());
@@ -117,7 +117,7 @@ 
 $server->addPlugin(new \OCA\DAV\CalDAV\Schedule\Plugin(Server::get(IConfig::class), Server::get(LoggerInterface::class), Server::get(DefaultCalendarValidator::class)));
 
 if ($sendInvitations) {
-	$server->addPlugin(Server::get(IMipPlugin::class));
+    $server->addPlugin(Server::get(IMipPlugin::class));
 }
 $server->addPlugin(new ExceptionLoggerPlugin('caldav', $logger));
 $server->addPlugin(Server::get(RateLimitingPlugin::class));

apps/federation/lib/Command/SyncFederationCalendars.php

Indentation +41 added lines, -41 removed lines

@@ -15,45 +15,45 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class SyncFederationCalendars extends Command {
-	public function __construct(
-		private readonly FederatedCalendarSyncService $syncService,
-		private readonly FederatedCalendarMapper $federatedCalendarMapper,
-	) {
-		parent::__construct();
-	}
-
-	protected function configure() {
-		$this
-			->setName('federation:sync-calendars')
-			->setDescription('Synchronize all incoming federated calendar shares');
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$calendarCount = $this->federatedCalendarMapper->countAll();
-		if ($calendarCount === 0) {
-			$output->writeln('There are no federated calendars');
-			return 0;
-		}
-
-		$progress = new ProgressBar($output, $calendarCount);
-		$progress->start();
-
-		$calendars = $this->federatedCalendarMapper->findAll();
-		foreach ($calendars as $calendar) {
-			try {
-				$this->syncService->syncOne($calendar);
-			} catch (\Exception $e) {
-				$url = $calendar->getUri();
-				$msg = $e->getMessage();
-				$output->writeln("\n<error>Failed to sync calendar $url: $msg</error>");
-			}
-
-			$progress->advance();
-		}
-
-		$progress->finish();
-		$output->writeln('');
-
-		return 0;
-	}
+    public function __construct(
+        private readonly FederatedCalendarSyncService $syncService,
+        private readonly FederatedCalendarMapper $federatedCalendarMapper,
+    ) {
+        parent::__construct();
+    }
+
+    protected function configure() {
+        $this
+            ->setName('federation:sync-calendars')
+            ->setDescription('Synchronize all incoming federated calendar shares');
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $calendarCount = $this->federatedCalendarMapper->countAll();
+        if ($calendarCount === 0) {
+            $output->writeln('There are no federated calendars');
+            return 0;
+        }
+
+        $progress = new ProgressBar($output, $calendarCount);
+        $progress->start();
+
+        $calendars = $this->federatedCalendarMapper->findAll();
+        foreach ($calendars as $calendar) {
+            try {
+                $this->syncService->syncOne($calendar);
+            } catch (\Exception $e) {
+                $url = $calendar->getUri();
+                $msg = $e->getMessage();
+                $output->writeln("\n<error>Failed to sync calendar $url: $msg</error>");
+            }
+
+            $progress->advance();
+        }
+
+        $progress->finish();
+        $output->writeln('');
+
+        return 0;
+    }
 }