nextcloud / server

apps/dav/tests/unit/CalDAV/AbstractCalDavBackend.php

Indentation +173 added lines, -173 removed lines

@@ -46,153 +46,153 @@ 
 abstract class AbstractCalDavBackend extends TestCase {
 
 
-	protected CalDavBackend $backend;
-	protected Principal&MockObject $principal;
-	protected IUserManager&MockObject $userManager;
-	protected IGroupManager&MockObject $groupManager;
-	protected IEventDispatcher&MockObject $dispatcher;
-	private LoggerInterface&MockObject $logger;
-	private IConfig&MockObject $config;
-	private ISecureRandom $random;
-	protected SharingBackend $sharingBackend;
-	protected IDBConnection $db;
-	protected RemoteUserPrincipalBackend&MockObject $remoteUserPrincipalBackend;
-	protected FederationSharingService&MockObject $federationSharingService;
-	protected FederatedCalendarMapper&MockObject $federatedCalendarMapper;
-	public const UNIT_TEST_USER = 'principals/users/caldav-unit-test';
-	public const UNIT_TEST_USER1 = 'principals/users/caldav-unit-test1';
-	public const UNIT_TEST_GROUP = 'principals/groups/caldav-unit-test-group';
-	public const UNIT_TEST_GROUP2 = 'principals/groups/caldav-unit-test-group2';
+    protected CalDavBackend $backend;
+    protected Principal&MockObject $principal;
+    protected IUserManager&MockObject $userManager;
+    protected IGroupManager&MockObject $groupManager;
+    protected IEventDispatcher&MockObject $dispatcher;
+    private LoggerInterface&MockObject $logger;
+    private IConfig&MockObject $config;
+    private ISecureRandom $random;
+    protected SharingBackend $sharingBackend;
+    protected IDBConnection $db;
+    protected RemoteUserPrincipalBackend&MockObject $remoteUserPrincipalBackend;
+    protected FederationSharingService&MockObject $federationSharingService;
+    protected FederatedCalendarMapper&MockObject $federatedCalendarMapper;
+    public const UNIT_TEST_USER = 'principals/users/caldav-unit-test';
+    public const UNIT_TEST_USER1 = 'principals/users/caldav-unit-test1';
+    public const UNIT_TEST_GROUP = 'principals/groups/caldav-unit-test-group';
+    public const UNIT_TEST_GROUP2 = 'principals/groups/caldav-unit-test-group2';
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->dispatcher = $this->createMock(IEventDispatcher::class);
-		$this->principal = $this->getMockBuilder(Principal::class)
-			->setConstructorArgs([
-				$this->userManager,
-				$this->groupManager,
-				$this->createMock(IAccountManager::class),
-				$this->createMock(ShareManager::class),
-				$this->createMock(IUserSession::class),
-				$this->createMock(IAppManager::class),
-				$this->createMock(ProxyMapper::class),
-				$this->createMock(KnownUserService::class),
-				$this->createMock(IConfig::class),
-				$this->createMock(IFactory::class)
-			])
-			->onlyMethods(['getPrincipalByPath', 'getGroupMembership', 'findByUri'])
-			->getMock();
-		$this->principal->expects($this->any())->method('getPrincipalByPath')
-			->willReturn([
-				'uri' => 'principals/best-friend',
-				'{DAV:}displayname' => 'User\'s displayname',
-			]);
-		$this->principal->expects($this->any())->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP, self::UNIT_TEST_GROUP2]);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->dispatcher = $this->createMock(IEventDispatcher::class);
+        $this->principal = $this->getMockBuilder(Principal::class)
+            ->setConstructorArgs([
+                $this->userManager,
+                $this->groupManager,
+                $this->createMock(IAccountManager::class),
+                $this->createMock(ShareManager::class),
+                $this->createMock(IUserSession::class),
+                $this->createMock(IAppManager::class),
+                $this->createMock(ProxyMapper::class),
+                $this->createMock(KnownUserService::class),
+                $this->createMock(IConfig::class),
+                $this->createMock(IFactory::class)
+            ])
+            ->onlyMethods(['getPrincipalByPath', 'getGroupMembership', 'findByUri'])
+            ->getMock();
+        $this->principal->expects($this->any())->method('getPrincipalByPath')
+            ->willReturn([
+                'uri' => 'principals/best-friend',
+                '{DAV:}displayname' => 'User\'s displayname',
+            ]);
+        $this->principal->expects($this->any())->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP, self::UNIT_TEST_GROUP2]);
 
-		$this->db = Server::get(IDBConnection::class);
-		$this->random = Server::get(ISecureRandom::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->remoteUserPrincipalBackend = $this->createMock(RemoteUserPrincipalBackend::class);
-		$this->federationSharingService = $this->createMock(FederationSharingService::class);
-		$this->federatedCalendarMapper = $this->createMock(FederatedCalendarMapper::class);
-		$this->sharingBackend = new SharingBackend(
-			$this->userManager,
-			$this->groupManager,
-			$this->principal,
-			$this->remoteUserPrincipalBackend,
-			$this->createMock(ICacheFactory::class),
-			new Service(new SharingMapper($this->db)),
-			$this->federationSharingService,
-			$this->logger);
-		$this->backend = new CalDavBackend(
-			$this->db,
-			$this->principal,
-			$this->userManager,
-			$this->random,
-			$this->logger,
-			$this->dispatcher,
-			$this->config,
-			$this->sharingBackend,
-			$this->federatedCalendarMapper,
-			false,
-		);
+        $this->db = Server::get(IDBConnection::class);
+        $this->random = Server::get(ISecureRandom::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->remoteUserPrincipalBackend = $this->createMock(RemoteUserPrincipalBackend::class);
+        $this->federationSharingService = $this->createMock(FederationSharingService::class);
+        $this->federatedCalendarMapper = $this->createMock(FederatedCalendarMapper::class);
+        $this->sharingBackend = new SharingBackend(
+            $this->userManager,
+            $this->groupManager,
+            $this->principal,
+            $this->remoteUserPrincipalBackend,
+            $this->createMock(ICacheFactory::class),
+            new Service(new SharingMapper($this->db)),
+            $this->federationSharingService,
+            $this->logger);
+        $this->backend = new CalDavBackend(
+            $this->db,
+            $this->principal,
+            $this->userManager,
+            $this->random,
+            $this->logger,
+            $this->dispatcher,
+            $this->config,
+            $this->sharingBackend,
+            $this->federatedCalendarMapper,
+            false,
+        );
 
-		$this->cleanUpBackend();
-	}
+        $this->cleanUpBackend();
+    }
 
-	protected function tearDown(): void {
-		$this->cleanUpBackend();
-		parent::tearDown();
-	}
+    protected function tearDown(): void {
+        $this->cleanUpBackend();
+        parent::tearDown();
+    }
 
-	public function cleanUpBackend(): void {
-		if (is_null($this->backend)) {
-			return;
-		}
-		$this->principal->expects($this->any())->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP, self::UNIT_TEST_GROUP2]);
-		$this->cleanupForPrincipal(self::UNIT_TEST_USER);
-		$this->cleanupForPrincipal(self::UNIT_TEST_USER1);
-	}
+    public function cleanUpBackend(): void {
+        if (is_null($this->backend)) {
+            return;
+        }
+        $this->principal->expects($this->any())->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP, self::UNIT_TEST_GROUP2]);
+        $this->cleanupForPrincipal(self::UNIT_TEST_USER);
+        $this->cleanupForPrincipal(self::UNIT_TEST_USER1);
+    }
 
-	private function cleanupForPrincipal($principal): void {
-		$calendars = $this->backend->getCalendarsForUser($principal);
-		$this->dispatcher->expects(self::any())
-			->method('dispatchTyped');
-		foreach ($calendars as $calendar) {
-			$this->backend->deleteCalendar($calendar['id'], true);
-		}
-		$subscriptions = $this->backend->getSubscriptionsForUser($principal);
-		foreach ($subscriptions as $subscription) {
-			$this->backend->deleteSubscription($subscription['id']);
-		}
-	}
+    private function cleanupForPrincipal($principal): void {
+        $calendars = $this->backend->getCalendarsForUser($principal);
+        $this->dispatcher->expects(self::any())
+            ->method('dispatchTyped');
+        foreach ($calendars as $calendar) {
+            $this->backend->deleteCalendar($calendar['id'], true);
+        }
+        $subscriptions = $this->backend->getSubscriptionsForUser($principal);
+        foreach ($subscriptions as $subscription) {
+            $this->backend->deleteSubscription($subscription['id']);
+        }
+    }
 
-	protected function createTestCalendar(): int {
-		$this->dispatcher->expects(self::any())
-			->method('dispatchTyped');
+    protected function createTestCalendar(): int {
+        $this->dispatcher->expects(self::any())
+            ->method('dispatchTyped');
 
-		$this->backend->createCalendar(self::UNIT_TEST_USER, 'Example', [
-			'{http://apple.com/ns/ical/}calendar-color' => '#1C4587FF'
-		]);
-		$calendars = $this->backend->getCalendarsForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($calendars));
-		$this->assertEquals(self::UNIT_TEST_USER, $calendars[0]['principaluri']);
-		/** @var SupportedCalendarComponentSet $components */
-		$components = $calendars[0]['{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set'];
-		$this->assertEquals(['VEVENT','VTODO','VJOURNAL'], $components->getValue());
-		$color = $calendars[0]['{http://apple.com/ns/ical/}calendar-color'];
-		$this->assertEquals('#1C4587FF', $color);
-		$this->assertEquals('Example', $calendars[0]['uri']);
-		$this->assertEquals('Example', $calendars[0]['{DAV:}displayname']);
-		return (int)$calendars[0]['id'];
-	}
+        $this->backend->createCalendar(self::UNIT_TEST_USER, 'Example', [
+            '{http://apple.com/ns/ical/}calendar-color' => '#1C4587FF'
+        ]);
+        $calendars = $this->backend->getCalendarsForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($calendars));
+        $this->assertEquals(self::UNIT_TEST_USER, $calendars[0]['principaluri']);
+        /** @var SupportedCalendarComponentSet $components */
+        $components = $calendars[0]['{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set'];
+        $this->assertEquals(['VEVENT','VTODO','VJOURNAL'], $components->getValue());
+        $color = $calendars[0]['{http://apple.com/ns/ical/}calendar-color'];
+        $this->assertEquals('#1C4587FF', $color);
+        $this->assertEquals('Example', $calendars[0]['uri']);
+        $this->assertEquals('Example', $calendars[0]['{DAV:}displayname']);
+        return (int)$calendars[0]['id'];
+    }
 
-	protected function createTestSubscription() {
-		$this->backend->createSubscription(self::UNIT_TEST_USER, 'Example', [
-			'{http://apple.com/ns/ical/}calendar-color' => '#1C4587FF',
-			'{http://calendarserver.org/ns/}source' => new Href(['foo']),
-		]);
-		$calendars = $this->backend->getSubscriptionsForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($calendars));
-		$this->assertEquals(self::UNIT_TEST_USER, $calendars[0]['principaluri']);
-		$this->assertEquals('Example', $calendars[0]['uri']);
-		$calendarId = $calendars[0]['id'];
+    protected function createTestSubscription() {
+        $this->backend->createSubscription(self::UNIT_TEST_USER, 'Example', [
+            '{http://apple.com/ns/ical/}calendar-color' => '#1C4587FF',
+            '{http://calendarserver.org/ns/}source' => new Href(['foo']),
+        ]);
+        $calendars = $this->backend->getSubscriptionsForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($calendars));
+        $this->assertEquals(self::UNIT_TEST_USER, $calendars[0]['principaluri']);
+        $this->assertEquals('Example', $calendars[0]['uri']);
+        $calendarId = $calendars[0]['id'];
 
-		return $calendarId;
-	}
+        return $calendarId;
+    }
 
-	protected function createEvent($calendarId, $start = '20130912T130000Z', $end = '20130912T140000Z') {
-		$randomPart = self::getUniqueID();
+    protected function createEvent($calendarId, $start = '20130912T130000Z', $end = '20130912T140000Z') {
+        $randomPart = self::getUniqueID();
 
-		$calData = <<<EOD
+        $calData = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:ownCloud Calendar
@@ -208,20 +208,20 @@ 
 END:VEVENT
 END:VCALENDAR
 EOD;
-		$uri0 = $this->getUniqueID('event');
+        $uri0 = $this->getUniqueID('event');
 
-		$this->dispatcher->expects(self::atLeastOnce())
-			->method('dispatchTyped');
+        $this->dispatcher->expects(self::atLeastOnce())
+            ->method('dispatchTyped');
 
-		$this->backend->createCalendarObject($calendarId, $uri0, $calData);
+        $this->backend->createCalendarObject($calendarId, $uri0, $calData);
 
-		return $uri0;
-	}
+        return $uri0;
+    }
 
-	protected function modifyEvent($calendarId, $objectId, $start = '20130912T130000Z', $end = '20130912T140000Z') {
-		$randomPart = self::getUniqueID();
+    protected function modifyEvent($calendarId, $objectId, $start = '20130912T130000Z', $end = '20130912T140000Z') {
+        $randomPart = self::getUniqueID();
 
-		$calData = <<<EOD
+        $calData = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:ownCloud Calendar
@@ -238,38 +238,38 @@ 
 END:VCALENDAR
 EOD;
 
-		$this->backend->updateCalendarObject($calendarId, $objectId, $calData);
-	}
+        $this->backend->updateCalendarObject($calendarId, $objectId, $calData);
+    }
 
-	protected function deleteEvent($calendarId, $objectId) {
-		$this->backend->deleteCalendarObject($calendarId, $objectId);
-	}
+    protected function deleteEvent($calendarId, $objectId) {
+        $this->backend->deleteCalendarObject($calendarId, $objectId);
+    }
 
-	protected function assertAcl($principal, $privilege, $acl) {
-		foreach ($acl as $a) {
-			if ($a['principal'] === $principal && $a['privilege'] === $privilege) {
-				$this->addToAssertionCount(1);
-				return;
-			}
-		}
-		$this->fail("ACL does not contain $principal / $privilege");
-	}
+    protected function assertAcl($principal, $privilege, $acl) {
+        foreach ($acl as $a) {
+            if ($a['principal'] === $principal && $a['privilege'] === $privilege) {
+                $this->addToAssertionCount(1);
+                return;
+            }
+        }
+        $this->fail("ACL does not contain $principal / $privilege");
+    }
 
-	protected function assertNotAcl($principal, $privilege, $acl) {
-		foreach ($acl as $a) {
-			if ($a['principal'] === $principal && $a['privilege'] === $privilege) {
-				$this->fail("ACL contains $principal / $privilege");
-				return;
-			}
-		}
-		$this->addToAssertionCount(1);
-	}
+    protected function assertNotAcl($principal, $privilege, $acl) {
+        foreach ($acl as $a) {
+            if ($a['principal'] === $principal && $a['privilege'] === $privilege) {
+                $this->fail("ACL contains $principal / $privilege");
+                return;
+            }
+        }
+        $this->addToAssertionCount(1);
+    }
 
-	protected function assertAccess($shouldHaveAcl, $principal, $privilege, $acl) {
-		if ($shouldHaveAcl) {
-			$this->assertAcl($principal, $privilege, $acl);
-		} else {
-			$this->assertNotAcl($principal, $privilege, $acl);
-		}
-	}
+    protected function assertAccess($shouldHaveAcl, $principal, $privilege, $acl) {
+        if ($shouldHaveAcl) {
+            $this->assertAcl($principal, $privilege, $acl);
+        } else {
+            $this->assertNotAcl($principal, $privilege, $acl);
+        }
+    }
 }

apps/dav/tests/unit/CalDAV/PublicCalendarRootTest.php

Indentation +110 added lines, -110 removed lines

@@ -33,114 +33,114 @@
  * @package OCA\DAV\Tests\unit\CalDAV
  */
 class PublicCalendarRootTest extends TestCase {
-	public const UNIT_TEST_USER = '';
-	private CalDavBackend $backend;
-	private PublicCalendarRoot $publicCalendarRoot;
-	private IL10N&MockObject $l10n;
-	private Principal&MockObject $principal;
-	protected IUserManager&MockObject $userManager;
-	protected IGroupManager&MockObject $groupManager;
-	protected IConfig&MockObject $config;
-	private ISecureRandom $random;
-	private LoggerInterface&MockObject $logger;
-
-	protected FederatedCalendarMapper&MockObject $federatedCalendarMapper;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$db = Server::get(IDBConnection::class);
-		$this->principal = $this->createMock('OCA\DAV\Connector\Sabre\Principal');
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->random = Server::get(ISecureRandom::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->federatedCalendarMapper = $this->createMock(FederatedCalendarMapper::class);
-		$dispatcher = $this->createMock(IEventDispatcher::class);
-		$config = $this->createMock(IConfig::class);
-		$sharingBackend = $this->createMock(\OCA\DAV\CalDAV\Sharing\Backend::class);
-
-		$this->principal->expects($this->any())->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([]);
-
-		$this->principal->expects($this->any())->method('getCircleMembership')
-			->withAnyParameters()
-			->willReturn([]);
-
-		$this->backend = new CalDavBackend(
-			$db,
-			$this->principal,
-			$this->userManager,
-			$this->random,
-			$this->logger,
-			$dispatcher,
-			$config,
-			$sharingBackend,
-			$this->federatedCalendarMapper,
-			false,
-		);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->config = $this->createMock(IConfig::class);
-
-		$this->publicCalendarRoot = new PublicCalendarRoot($this->backend,
-			$this->l10n, $this->config, $this->logger);
-	}
-
-	protected function tearDown(): void {
-		parent::tearDown();
-
-		if (is_null($this->backend)) {
-			return;
-		}
-		$this->principal->expects($this->any())->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([]);
-
-		$this->principal->expects($this->any())->method('getCircleMembership')
-			->withAnyParameters()
-			->willReturn([]);
-
-		$books = $this->backend->getCalendarsForUser(self::UNIT_TEST_USER);
-		foreach ($books as $book) {
-			$this->backend->deleteCalendar($book['id'], true);
-		}
-	}
-
-	public function testGetName(): void {
-		$name = $this->publicCalendarRoot->getName();
-		$this->assertEquals('public-calendars', $name);
-	}
-
-	public function testGetChild(): void {
-		$calendar = $this->createPublicCalendar();
-
-		$publicCalendars = $this->backend->getPublicCalendars();
-		$this->assertEquals(1, count($publicCalendars));
-		$this->assertEquals(true, $publicCalendars[0]['{http://owncloud.org/ns}public']);
-
-		$publicCalendarURI = $publicCalendars[0]['uri'];
-
-		$calendarResult = $this->publicCalendarRoot->getChild($publicCalendarURI);
-		$this->assertEquals($calendar, $calendarResult);
-	}
-
-	public function testGetChildren(): void {
-		$this->createPublicCalendar();
-		$calendarResults = $this->publicCalendarRoot->getChildren();
-		$this->assertSame([], $calendarResults);
-	}
-
-	protected function createPublicCalendar(): Calendar {
-		$this->backend->createCalendar(self::UNIT_TEST_USER, 'Example', []);
-
-		$calendarInfo = $this->backend->getCalendarsForUser(self::UNIT_TEST_USER)[0];
-		$calendar = new PublicCalendar($this->backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$publicUri = $calendar->setPublishStatus(true);
-
-		$calendarInfo = $this->backend->getPublicCalendar($publicUri);
-		$calendar = new PublicCalendar($this->backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-
-		return $calendar;
-	}
+    public const UNIT_TEST_USER = '';
+    private CalDavBackend $backend;
+    private PublicCalendarRoot $publicCalendarRoot;
+    private IL10N&MockObject $l10n;
+    private Principal&MockObject $principal;
+    protected IUserManager&MockObject $userManager;
+    protected IGroupManager&MockObject $groupManager;
+    protected IConfig&MockObject $config;
+    private ISecureRandom $random;
+    private LoggerInterface&MockObject $logger;
+
+    protected FederatedCalendarMapper&MockObject $federatedCalendarMapper;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $db = Server::get(IDBConnection::class);
+        $this->principal = $this->createMock('OCA\DAV\Connector\Sabre\Principal');
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->random = Server::get(ISecureRandom::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->federatedCalendarMapper = $this->createMock(FederatedCalendarMapper::class);
+        $dispatcher = $this->createMock(IEventDispatcher::class);
+        $config = $this->createMock(IConfig::class);
+        $sharingBackend = $this->createMock(\OCA\DAV\CalDAV\Sharing\Backend::class);
+
+        $this->principal->expects($this->any())->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([]);
+
+        $this->principal->expects($this->any())->method('getCircleMembership')
+            ->withAnyParameters()
+            ->willReturn([]);
+
+        $this->backend = new CalDavBackend(
+            $db,
+            $this->principal,
+            $this->userManager,
+            $this->random,
+            $this->logger,
+            $dispatcher,
+            $config,
+            $sharingBackend,
+            $this->federatedCalendarMapper,
+            false,
+        );
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->config = $this->createMock(IConfig::class);
+
+        $this->publicCalendarRoot = new PublicCalendarRoot($this->backend,
+            $this->l10n, $this->config, $this->logger);
+    }
+
+    protected function tearDown(): void {
+        parent::tearDown();
+
+        if (is_null($this->backend)) {
+            return;
+        }
+        $this->principal->expects($this->any())->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([]);
+
+        $this->principal->expects($this->any())->method('getCircleMembership')
+            ->withAnyParameters()
+            ->willReturn([]);
+
+        $books = $this->backend->getCalendarsForUser(self::UNIT_TEST_USER);
+        foreach ($books as $book) {
+            $this->backend->deleteCalendar($book['id'], true);
+        }
+    }
+
+    public function testGetName(): void {
+        $name = $this->publicCalendarRoot->getName();
+        $this->assertEquals('public-calendars', $name);
+    }
+
+    public function testGetChild(): void {
+        $calendar = $this->createPublicCalendar();
+
+        $publicCalendars = $this->backend->getPublicCalendars();
+        $this->assertEquals(1, count($publicCalendars));
+        $this->assertEquals(true, $publicCalendars[0]['{http://owncloud.org/ns}public']);
+
+        $publicCalendarURI = $publicCalendars[0]['uri'];
+
+        $calendarResult = $this->publicCalendarRoot->getChild($publicCalendarURI);
+        $this->assertEquals($calendar, $calendarResult);
+    }
+
+    public function testGetChildren(): void {
+        $this->createPublicCalendar();
+        $calendarResults = $this->publicCalendarRoot->getChildren();
+        $this->assertSame([], $calendarResults);
+    }
+
+    protected function createPublicCalendar(): Calendar {
+        $this->backend->createCalendar(self::UNIT_TEST_USER, 'Example', []);
+
+        $calendarInfo = $this->backend->getCalendarsForUser(self::UNIT_TEST_USER)[0];
+        $calendar = new PublicCalendar($this->backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $publicUri = $calendar->setPublishStatus(true);
+
+        $calendarInfo = $this->backend->getPublicCalendar($publicUri);
+        $calendar = new PublicCalendar($this->backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+
+        return $calendar;
+    }
 }

apps/dav/tests/unit/CalDAV/Federation/CalendarFederationConfigTest.php

Indentation +23 added lines, -23 removed lines

@@ -16,34 +16,34 @@
 use Test\TestCase;
 
 class CalendarFederationConfigTest extends TestCase {
-	private CalendarFederationConfig $config;
+    private CalendarFederationConfig $config;
 
-	private IAppConfig&MockObject $appConfig;
+    private IAppConfig&MockObject $appConfig;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->appConfig = $this->createMock(IAppConfig::class);
+        $this->appConfig = $this->createMock(IAppConfig::class);
 
-		$this->config = new CalendarFederationConfig(
-			$this->appConfig,
-		);
-	}
+        $this->config = new CalendarFederationConfig(
+            $this->appConfig,
+        );
+    }
 
-	public static function provideIsFederationEnabledData(): array {
-		return [
-			[true],
-			[false],
-		];
-	}
+    public static function provideIsFederationEnabledData(): array {
+        return [
+            [true],
+            [false],
+        ];
+    }
 
-	#[DataProvider('provideIsFederationEnabledData')]
-	public function testIsFederationEnabled(bool $configValue): void {
-		$this->appConfig->expects(self::once())
-			->method('getAppValueBool')
-			->with('enableCalendarFederation', true)
-			->willReturn($configValue);
+    #[DataProvider('provideIsFederationEnabledData')]
+    public function testIsFederationEnabled(bool $configValue): void {
+        $this->appConfig->expects(self::once())
+            ->method('getAppValueBool')
+            ->with('enableCalendarFederation', true)
+            ->willReturn($configValue);
 
-		$this->assertEquals($configValue, $this->config->isFederationEnabled());
-	}
+        $this->assertEquals($configValue, $this->config->isFederationEnabled());
+    }
 }

apps/dav/tests/unit/CalDAV/Federation/CalendarFederationProviderTest.php

Indentation +453 added lines, -453 removed lines

@@ -28,457 +28,457 @@
 use Test\TestCase;
 
 class CalendarFederationProviderTest extends TestCase {
-	private CalendarFederationProvider $calendarFederationProvider;
-
-	private LoggerInterface&MockObject $logger;
-	private FederatedCalendarMapper&MockObject $federatedCalendarMapper;
-	private CalendarFederationConfig&MockObject $calendarFederationConfig;
-	private IJobList&MockObject $jobList;
-	private ICloudIdManager&MockObject $cloudIdManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->federatedCalendarMapper = $this->createMock(FederatedCalendarMapper::class);
-		$this->calendarFederationConfig = $this->createMock(CalendarFederationConfig::class);
-		$this->jobList = $this->createMock(JobList::class);
-		$this->cloudIdManager = $this->createMock(ICloudIdManager::class);
-
-		$this->calendarFederationProvider = new CalendarFederationProvider(
-			$this->logger,
-			$this->federatedCalendarMapper,
-			$this->calendarFederationConfig,
-			$this->jobList,
-			$this->cloudIdManager,
-		);
-	}
-
-	public function testGetShareType(): void {
-		$this->assertEquals('calendar', $this->calendarFederationProvider->getShareType());
-	}
-
-	public function testGetSupportedShareTypes(): void {
-		$this->assertEqualsCanonicalizing(
-			['user'],
-			$this->calendarFederationProvider->getSupportedShareTypes(),
-		);
-	}
-
-	public function testShareReceived(): void {
-		$share = $this->createMock(ICloudFederationShare::class);
-		$share->method('getShareType')
-			->willReturn('user');
-		$share->method('getProtocol')
-			->willReturn([
-				'version' => 'v1',
-				'url' => 'https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1',
-				'displayName' => 'Calendar 1',
-				'color' => '#ff0000',
-				'access' => 3,
-				'components' => 'VEVENT,VTODO',
-			]);
-		$share->method('getShareWith')
-			->willReturn('sharee1');
-		$share->method('getShareSecret')
-			->willReturn('token');
-		$share->method('getSharedBy')
-			->willReturn('user1@nextcloud.remote');
-		$share->method('getSharedByDisplayName')
-			->willReturn('User 1');
-
-		$this->calendarFederationConfig->expects(self::once())
-			->method('isFederationEnabled')
-			->willReturn(true);
-
-		$this->federatedCalendarMapper->expects(self::once())
-			->method('deleteByUri')
-			->with(
-				'principals/users/sharee1',
-				'ae4b8ab904076fff2b955ea21b1a0d92',
-			);
-
-		$this->federatedCalendarMapper->expects(self::once())
-			->method('insert')
-			->willReturnCallback(function (FederatedCalendarEntity $calendar) {
-				$this->assertEquals('principals/users/sharee1', $calendar->getPrincipaluri());
-				$this->assertEquals('ae4b8ab904076fff2b955ea21b1a0d92', $calendar->getUri());
-				$this->assertEquals('https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1', $calendar->getRemoteUrl());
-				$this->assertEquals('Calendar 1', $calendar->getDisplayName());
-				$this->assertEquals('#ff0000', $calendar->getColor());
-				$this->assertEquals('token', $calendar->getToken());
-				$this->assertEquals('user1@nextcloud.remote', $calendar->getSharedBy());
-				$this->assertEquals('User 1', $calendar->getSharedByDisplayName());
-				$this->assertEquals(1, $calendar->getPermissions());
-				$this->assertEquals('VEVENT,VTODO', $calendar->getComponents());
-
-				$calendar->setId(10);
-				return $calendar;
-			});
-
-		$this->jobList->expects(self::once())
-			->method('add')
-			->with(FederatedCalendarSyncJob::class, ['id' => 10]);
-
-		$this->assertEquals(10, $this->calendarFederationProvider->shareReceived($share));
-	}
-
-	public function testShareReceivedWithInvalidProtocolVersion(): void {
-		$share = $this->createMock(ICloudFederationShare::class);
-		$share->method('getShareType')
-			->willReturn('user');
-		$share->method('getProtocol')
-			->willReturn([
-				'version' => 'unknown',
-				'url' => 'https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1',
-				'displayName' => 'Calendar 1',
-				'color' => '#ff0000',
-				'access' => 3,
-				'components' => 'VEVENT,VTODO',
-			]);
-
-		$this->calendarFederationConfig->expects(self::once())
-			->method('isFederationEnabled')
-			->willReturn(true);
-
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('insert');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		$this->expectException(ProviderCouldNotAddShareException::class);
-		$this->expectExceptionMessage('Unknown protocol version');
-		$this->expectExceptionCode(400);
-		$this->assertEquals(10, $this->calendarFederationProvider->shareReceived($share));
-	}
-
-	public function testShareReceivedWithoutProtocolVersion(): void {
-		$share = $this->createMock(ICloudFederationShare::class);
-		$share->method('getShareType')
-			->willReturn('user');
-		$share->method('getProtocol')
-			->willReturn([
-				'url' => 'https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1',
-				'displayName' => 'Calendar 1',
-				'color' => '#ff0000',
-				'access' => 3,
-				'components' => 'VEVENT,VTODO',
-			]);
-
-		$this->calendarFederationConfig->expects(self::once())
-			->method('isFederationEnabled')
-			->willReturn(true);
-
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('insert');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		$this->expectException(ProviderCouldNotAddShareException::class);
-		$this->expectExceptionMessage('Unknown protocol version');
-		$this->expectExceptionCode(400);
-		$this->assertEquals(10, $this->calendarFederationProvider->shareReceived($share));
-	}
-
-	public function testShareReceivedWithDisabledConfig(): void {
-		$share = $this->createMock(ICloudFederationShare::class);
-
-		$this->calendarFederationConfig->expects(self::once())
-			->method('isFederationEnabled')
-			->willReturn(false);
-
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('insert');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		$this->expectException(ProviderCouldNotAddShareException::class);
-		$this->expectExceptionMessage('Server does not support calendar federation');
-		$this->expectExceptionCode(503);
-		$this->calendarFederationProvider->shareReceived($share);
-	}
-
-	public function testShareReceivedWithUnsupportedShareType(): void {
-		$share = $this->createMock(ICloudFederationShare::class);
-		$share->method('getShareType')
-			->willReturn('foobar');
-
-		$this->calendarFederationConfig->expects(self::once())
-			->method('isFederationEnabled')
-			->willReturn(true);
-
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('insert');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		$this->expectException(ProviderCouldNotAddShareException::class);
-		$this->expectExceptionMessage('Support for sharing with non-users not implemented yet');
-		$this->expectExceptionCode(501);
-		$this->calendarFederationProvider->shareReceived($share);
-	}
-
-	public static function provideIncompleteProtocolData(): array {
-		return [
-			[[
-				'version' => 'v1',
-				'url' => '',
-				'displayName' => 'Calendar 1',
-				'color' => '#ff0000',
-				'access' => 3,
-				'components' => 'VEVENT,VTODO',
-			]],
-			[[
-				'version' => 'v1',
-				'url' => 'https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1',
-				'displayName' => '',
-				'color' => '#ff0000',
-				'access' => 3,
-				'components' => 'VEVENT,VTODO',
-			]],
-		];
-	}
-
-	#[DataProvider('provideIncompleteProtocolData')]
-	public function testShareReceivedWithIncompleteProtocolData(array $protocol): void {
-		$share = $this->createMock(ICloudFederationShare::class);
-		$share->method('getShareType')
-			->willReturn('user');
-		$share->method('getProtocol')
-			->willReturn($protocol);
-		$share->method('getShareWith')
-			->willReturn('sharee1');
-		$share->method('getShareSecret')
-			->willReturn('token');
-		$share->method('getSharedBy')
-			->willReturn('user1@nextcloud.remote');
-		$share->method('getSharedByDisplayName')
-			->willReturn('User 1');
-
-		$this->calendarFederationConfig->expects(self::once())
-			->method('isFederationEnabled')
-			->willReturn(true);
-
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('insert');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		$this->expectException(ProviderCouldNotAddShareException::class);
-		$this->expectExceptionMessage('Incomplete protocol data');
-		$this->expectExceptionCode(400);
-		$this->calendarFederationProvider->shareReceived($share);
-	}
-
-	public function testShareReceivedWithUnsupportedAccess(): void {
-		$share = $this->createMock(ICloudFederationShare::class);
-		$share->method('getShareType')
-			->willReturn('user');
-		$share->method('getProtocol')
-			->willReturn([
-				'version' => 'v1',
-				'url' => 'https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1',
-				'displayName' => 'Calendar 1',
-				'color' => '#ff0000',
-				'access' => 2, // Backend::ACCESS_READ_WRITE
-				'components' => 'VEVENT,VTODO',
-			]);
-		$share->method('getShareWith')
-			->willReturn('sharee1');
-		$share->method('getShareSecret')
-			->willReturn('token');
-		$share->method('getSharedBy')
-			->willReturn('user1@nextcloud.remote');
-		$share->method('getSharedByDisplayName')
-			->willReturn('User 1');
-
-		$this->calendarFederationConfig->expects(self::once())
-			->method('isFederationEnabled')
-			->willReturn(true);
-
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('insert');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		$this->expectException(ProviderCouldNotAddShareException::class);
-		$this->expectExceptionMessageMatches('/Unsupported access value: [0-9]+/');
-		$this->expectExceptionCode(400);
-		$this->calendarFederationProvider->shareReceived($share);
-	}
-
-	public function testNotificationReceivedWithUnknownNotification(): void {
-		$actual = $this->calendarFederationProvider->notificationReceived('UNKNOWN', 'calendar', [
-			'sharedSecret' => 'token',
-			'foobar' => 'baz',
-		]);
-		$this->assertEquals([], $actual);
-	}
-
-	public function testNotificationReceivedWithInvalidProviderId(): void {
-		$this->expectException(BadRequestException::class);
-		$this->calendarFederationProvider->notificationReceived('SYNC_CALENDAR', 'foobar', [
-			'sharedSecret' => 'token',
-			'shareWith' => 'remote1@nextcloud.remote',
-			'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-		]);
-	}
-
-	public function testNotificationReceivedWithSyncCalendarNotification(): void {
-		$cloudId = $this->createMock(ICloudId::class);
-		$cloudId->method('getId')
-			->willReturn('remote1@nextcloud.remote');
-		$cloudId->method('getUser')
-			->willReturn('remote1');
-		$cloudId->method('getRemote')
-			->willReturn('nextcloud.remote');
-
-		$this->cloudIdManager->expects(self::once())
-			->method('resolveCloudId')
-			->with('remote1@nextcloud.remote')
-			->willReturn($cloudId);
-
-		$calendar1 = new FederatedCalendarEntity();
-		$calendar1->setId(10);
-		$calendar2 = new FederatedCalendarEntity();
-		$calendar2->setId(11);
-		$calendars = [
-			$calendar1,
-			$calendar2,
-		];
-		$this->federatedCalendarMapper->expects(self::once())
-			->method('findByRemoteUrl')
-			->with(
-				'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-				'principals/users/remote1',
-				'token',
-			)
-			->willReturn($calendars);
-
-		$this->jobList->expects(self::exactly(2))
-			->method('add')
-			->willReturnMap([
-				[FederatedCalendarSyncJob::class, ['id' => 10]],
-				[FederatedCalendarSyncJob::class, ['id' => 11]],
-			]);
-
-		$actual = $this->calendarFederationProvider->notificationReceived(
-			'SYNC_CALENDAR',
-			'calendar',
-			[
-				'sharedSecret' => 'token',
-				'shareWith' => 'remote1@nextcloud.remote',
-				'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-			],
-		);
-		$this->assertEquals([], $actual);
-	}
-
-	public static function provideIncompleteSyncCalendarNotificationData(): array {
-		return [
-			// Missing shareWith
-			[[
-				'sharedSecret' => 'token',
-				'shareWith' => '',
-				'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-			]],
-			[[
-				'sharedSecret' => 'token',
-				'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-			]],
-
-			// Missing calendarUrl
-			[[
-				'sharedSecret' => 'token',
-				'shareWith' => 'remote1@nextcloud.remote',
-				'calendarUrl' => '',
-			]],
-			[[
-				'sharedSecret' => 'token',
-				'shareWith' => 'remote1@nextcloud.remote',
-			]],
-		];
-	}
-
-	#[DataProvider('provideIncompleteSyncCalendarNotificationData')]
-	public function testNotificationReceivedWithSyncCalendarNotificationAndIncompleteData(
-		array $notification,
-	): void {
-		$this->cloudIdManager->expects(self::never())
-			->method('resolveCloudId');
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('findByRemoteUrl');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		$this->expectException(BadRequestException::class);
-		$this->calendarFederationProvider->notificationReceived(
-			'SYNC_CALENDAR',
-			'calendar',
-			$notification,
-		);
-	}
-
-	public function testNotificationReceivedWithSyncCalendarNotificationAndInvalidCloudId(): void {
-		$this->cloudIdManager->expects(self::once())
-			->method('resolveCloudId')
-			->with('invalid-cloud-id')
-			->willThrowException(new \InvalidArgumentException());
-
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('findByRemoteUrl');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		$this->expectException(ShareNotFound::class);
-		$this->expectExceptionMessage('Invalid sharee cloud id');
-		$this->calendarFederationProvider->notificationReceived(
-			'SYNC_CALENDAR',
-			'calendar',
-			[
-				'sharedSecret' => 'token',
-				'shareWith' => 'invalid-cloud-id',
-				'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-			],
-		);
-	}
-
-	public function testNotificationReceivedWithSyncCalendarNotificationAndNoCalendars(): void {
-		$cloudId = $this->createMock(ICloudId::class);
-		$cloudId->method('getId')
-			->willReturn('remote1@nextcloud.remote');
-		$cloudId->method('getUser')
-			->willReturn('remote1');
-		$cloudId->method('getRemote')
-			->willReturn('nextcloud.remote');
-
-		$this->cloudIdManager->expects(self::once())
-			->method('resolveCloudId')
-			->with('remote1@nextcloud.remote')
-			->willReturn($cloudId);
-
-		$this->federatedCalendarMapper->expects(self::once())
-			->method('findByRemoteUrl')
-			->with(
-				'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-				'principals/users/remote1',
-				'token',
-			)
-			->willReturn([]);
-
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		$this->expectException(ShareNotFound::class);
-		$this->expectExceptionMessage('Calendar is not shared with the sharee');
-		$this->calendarFederationProvider->notificationReceived(
-			'SYNC_CALENDAR',
-			'calendar',
-			[
-				'sharedSecret' => 'token',
-				'shareWith' => 'remote1@nextcloud.remote',
-				'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-			],
-		);
-	}
+    private CalendarFederationProvider $calendarFederationProvider;
+
+    private LoggerInterface&MockObject $logger;
+    private FederatedCalendarMapper&MockObject $federatedCalendarMapper;
+    private CalendarFederationConfig&MockObject $calendarFederationConfig;
+    private IJobList&MockObject $jobList;
+    private ICloudIdManager&MockObject $cloudIdManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->federatedCalendarMapper = $this->createMock(FederatedCalendarMapper::class);
+        $this->calendarFederationConfig = $this->createMock(CalendarFederationConfig::class);
+        $this->jobList = $this->createMock(JobList::class);
+        $this->cloudIdManager = $this->createMock(ICloudIdManager::class);
+
+        $this->calendarFederationProvider = new CalendarFederationProvider(
+            $this->logger,
+            $this->federatedCalendarMapper,
+            $this->calendarFederationConfig,
+            $this->jobList,
+            $this->cloudIdManager,
+        );
+    }
+
+    public function testGetShareType(): void {
+        $this->assertEquals('calendar', $this->calendarFederationProvider->getShareType());
+    }
+
+    public function testGetSupportedShareTypes(): void {
+        $this->assertEqualsCanonicalizing(
+            ['user'],
+            $this->calendarFederationProvider->getSupportedShareTypes(),
+        );
+    }
+
+    public function testShareReceived(): void {
+        $share = $this->createMock(ICloudFederationShare::class);
+        $share->method('getShareType')
+            ->willReturn('user');
+        $share->method('getProtocol')
+            ->willReturn([
+                'version' => 'v1',
+                'url' => 'https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1',
+                'displayName' => 'Calendar 1',
+                'color' => '#ff0000',
+                'access' => 3,
+                'components' => 'VEVENT,VTODO',
+            ]);
+        $share->method('getShareWith')
+            ->willReturn('sharee1');
+        $share->method('getShareSecret')
+            ->willReturn('token');
+        $share->method('getSharedBy')
+            ->willReturn('user1@nextcloud.remote');
+        $share->method('getSharedByDisplayName')
+            ->willReturn('User 1');
+
+        $this->calendarFederationConfig->expects(self::once())
+            ->method('isFederationEnabled')
+            ->willReturn(true);
+
+        $this->federatedCalendarMapper->expects(self::once())
+            ->method('deleteByUri')
+            ->with(
+                'principals/users/sharee1',
+                'ae4b8ab904076fff2b955ea21b1a0d92',
+            );
+
+        $this->federatedCalendarMapper->expects(self::once())
+            ->method('insert')
+            ->willReturnCallback(function (FederatedCalendarEntity $calendar) {
+                $this->assertEquals('principals/users/sharee1', $calendar->getPrincipaluri());
+                $this->assertEquals('ae4b8ab904076fff2b955ea21b1a0d92', $calendar->getUri());
+                $this->assertEquals('https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1', $calendar->getRemoteUrl());
+                $this->assertEquals('Calendar 1', $calendar->getDisplayName());
+                $this->assertEquals('#ff0000', $calendar->getColor());
+                $this->assertEquals('token', $calendar->getToken());
+                $this->assertEquals('user1@nextcloud.remote', $calendar->getSharedBy());
+                $this->assertEquals('User 1', $calendar->getSharedByDisplayName());
+                $this->assertEquals(1, $calendar->getPermissions());
+                $this->assertEquals('VEVENT,VTODO', $calendar->getComponents());
+
+                $calendar->setId(10);
+                return $calendar;
+            });
+
+        $this->jobList->expects(self::once())
+            ->method('add')
+            ->with(FederatedCalendarSyncJob::class, ['id' => 10]);
+
+        $this->assertEquals(10, $this->calendarFederationProvider->shareReceived($share));
+    }
+
+    public function testShareReceivedWithInvalidProtocolVersion(): void {
+        $share = $this->createMock(ICloudFederationShare::class);
+        $share->method('getShareType')
+            ->willReturn('user');
+        $share->method('getProtocol')
+            ->willReturn([
+                'version' => 'unknown',
+                'url' => 'https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1',
+                'displayName' => 'Calendar 1',
+                'color' => '#ff0000',
+                'access' => 3,
+                'components' => 'VEVENT,VTODO',
+            ]);
+
+        $this->calendarFederationConfig->expects(self::once())
+            ->method('isFederationEnabled')
+            ->willReturn(true);
+
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('insert');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        $this->expectException(ProviderCouldNotAddShareException::class);
+        $this->expectExceptionMessage('Unknown protocol version');
+        $this->expectExceptionCode(400);
+        $this->assertEquals(10, $this->calendarFederationProvider->shareReceived($share));
+    }
+
+    public function testShareReceivedWithoutProtocolVersion(): void {
+        $share = $this->createMock(ICloudFederationShare::class);
+        $share->method('getShareType')
+            ->willReturn('user');
+        $share->method('getProtocol')
+            ->willReturn([
+                'url' => 'https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1',
+                'displayName' => 'Calendar 1',
+                'color' => '#ff0000',
+                'access' => 3,
+                'components' => 'VEVENT,VTODO',
+            ]);
+
+        $this->calendarFederationConfig->expects(self::once())
+            ->method('isFederationEnabled')
+            ->willReturn(true);
+
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('insert');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        $this->expectException(ProviderCouldNotAddShareException::class);
+        $this->expectExceptionMessage('Unknown protocol version');
+        $this->expectExceptionCode(400);
+        $this->assertEquals(10, $this->calendarFederationProvider->shareReceived($share));
+    }
+
+    public function testShareReceivedWithDisabledConfig(): void {
+        $share = $this->createMock(ICloudFederationShare::class);
+
+        $this->calendarFederationConfig->expects(self::once())
+            ->method('isFederationEnabled')
+            ->willReturn(false);
+
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('insert');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        $this->expectException(ProviderCouldNotAddShareException::class);
+        $this->expectExceptionMessage('Server does not support calendar federation');
+        $this->expectExceptionCode(503);
+        $this->calendarFederationProvider->shareReceived($share);
+    }
+
+    public function testShareReceivedWithUnsupportedShareType(): void {
+        $share = $this->createMock(ICloudFederationShare::class);
+        $share->method('getShareType')
+            ->willReturn('foobar');
+
+        $this->calendarFederationConfig->expects(self::once())
+            ->method('isFederationEnabled')
+            ->willReturn(true);
+
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('insert');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        $this->expectException(ProviderCouldNotAddShareException::class);
+        $this->expectExceptionMessage('Support for sharing with non-users not implemented yet');
+        $this->expectExceptionCode(501);
+        $this->calendarFederationProvider->shareReceived($share);
+    }
+
+    public static function provideIncompleteProtocolData(): array {
+        return [
+            [[
+                'version' => 'v1',
+                'url' => '',
+                'displayName' => 'Calendar 1',
+                'color' => '#ff0000',
+                'access' => 3,
+                'components' => 'VEVENT,VTODO',
+            ]],
+            [[
+                'version' => 'v1',
+                'url' => 'https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1',
+                'displayName' => '',
+                'color' => '#ff0000',
+                'access' => 3,
+                'components' => 'VEVENT,VTODO',
+            ]],
+        ];
+    }
+
+    #[DataProvider('provideIncompleteProtocolData')]
+    public function testShareReceivedWithIncompleteProtocolData(array $protocol): void {
+        $share = $this->createMock(ICloudFederationShare::class);
+        $share->method('getShareType')
+            ->willReturn('user');
+        $share->method('getProtocol')
+            ->willReturn($protocol);
+        $share->method('getShareWith')
+            ->willReturn('sharee1');
+        $share->method('getShareSecret')
+            ->willReturn('token');
+        $share->method('getSharedBy')
+            ->willReturn('user1@nextcloud.remote');
+        $share->method('getSharedByDisplayName')
+            ->willReturn('User 1');
+
+        $this->calendarFederationConfig->expects(self::once())
+            ->method('isFederationEnabled')
+            ->willReturn(true);
+
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('insert');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        $this->expectException(ProviderCouldNotAddShareException::class);
+        $this->expectExceptionMessage('Incomplete protocol data');
+        $this->expectExceptionCode(400);
+        $this->calendarFederationProvider->shareReceived($share);
+    }
+
+    public function testShareReceivedWithUnsupportedAccess(): void {
+        $share = $this->createMock(ICloudFederationShare::class);
+        $share->method('getShareType')
+            ->willReturn('user');
+        $share->method('getProtocol')
+            ->willReturn([
+                'version' => 'v1',
+                'url' => 'https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1',
+                'displayName' => 'Calendar 1',
+                'color' => '#ff0000',
+                'access' => 2, // Backend::ACCESS_READ_WRITE
+                'components' => 'VEVENT,VTODO',
+            ]);
+        $share->method('getShareWith')
+            ->willReturn('sharee1');
+        $share->method('getShareSecret')
+            ->willReturn('token');
+        $share->method('getSharedBy')
+            ->willReturn('user1@nextcloud.remote');
+        $share->method('getSharedByDisplayName')
+            ->willReturn('User 1');
+
+        $this->calendarFederationConfig->expects(self::once())
+            ->method('isFederationEnabled')
+            ->willReturn(true);
+
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('insert');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        $this->expectException(ProviderCouldNotAddShareException::class);
+        $this->expectExceptionMessageMatches('/Unsupported access value: [0-9]+/');
+        $this->expectExceptionCode(400);
+        $this->calendarFederationProvider->shareReceived($share);
+    }
+
+    public function testNotificationReceivedWithUnknownNotification(): void {
+        $actual = $this->calendarFederationProvider->notificationReceived('UNKNOWN', 'calendar', [
+            'sharedSecret' => 'token',
+            'foobar' => 'baz',
+        ]);
+        $this->assertEquals([], $actual);
+    }
+
+    public function testNotificationReceivedWithInvalidProviderId(): void {
+        $this->expectException(BadRequestException::class);
+        $this->calendarFederationProvider->notificationReceived('SYNC_CALENDAR', 'foobar', [
+            'sharedSecret' => 'token',
+            'shareWith' => 'remote1@nextcloud.remote',
+            'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+        ]);
+    }
+
+    public function testNotificationReceivedWithSyncCalendarNotification(): void {
+        $cloudId = $this->createMock(ICloudId::class);
+        $cloudId->method('getId')
+            ->willReturn('remote1@nextcloud.remote');
+        $cloudId->method('getUser')
+            ->willReturn('remote1');
+        $cloudId->method('getRemote')
+            ->willReturn('nextcloud.remote');
+
+        $this->cloudIdManager->expects(self::once())
+            ->method('resolveCloudId')
+            ->with('remote1@nextcloud.remote')
+            ->willReturn($cloudId);
+
+        $calendar1 = new FederatedCalendarEntity();
+        $calendar1->setId(10);
+        $calendar2 = new FederatedCalendarEntity();
+        $calendar2->setId(11);
+        $calendars = [
+            $calendar1,
+            $calendar2,
+        ];
+        $this->federatedCalendarMapper->expects(self::once())
+            ->method('findByRemoteUrl')
+            ->with(
+                'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+                'principals/users/remote1',
+                'token',
+            )
+            ->willReturn($calendars);
+
+        $this->jobList->expects(self::exactly(2))
+            ->method('add')
+            ->willReturnMap([
+                [FederatedCalendarSyncJob::class, ['id' => 10]],
+                [FederatedCalendarSyncJob::class, ['id' => 11]],
+            ]);
+
+        $actual = $this->calendarFederationProvider->notificationReceived(
+            'SYNC_CALENDAR',
+            'calendar',
+            [
+                'sharedSecret' => 'token',
+                'shareWith' => 'remote1@nextcloud.remote',
+                'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+            ],
+        );
+        $this->assertEquals([], $actual);
+    }
+
+    public static function provideIncompleteSyncCalendarNotificationData(): array {
+        return [
+            // Missing shareWith
+            [[
+                'sharedSecret' => 'token',
+                'shareWith' => '',
+                'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+            ]],
+            [[
+                'sharedSecret' => 'token',
+                'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+            ]],
+
+            // Missing calendarUrl
+            [[
+                'sharedSecret' => 'token',
+                'shareWith' => 'remote1@nextcloud.remote',
+                'calendarUrl' => '',
+            ]],
+            [[
+                'sharedSecret' => 'token',
+                'shareWith' => 'remote1@nextcloud.remote',
+            ]],
+        ];
+    }
+
+    #[DataProvider('provideIncompleteSyncCalendarNotificationData')]
+    public function testNotificationReceivedWithSyncCalendarNotificationAndIncompleteData(
+        array $notification,
+    ): void {
+        $this->cloudIdManager->expects(self::never())
+            ->method('resolveCloudId');
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('findByRemoteUrl');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        $this->expectException(BadRequestException::class);
+        $this->calendarFederationProvider->notificationReceived(
+            'SYNC_CALENDAR',
+            'calendar',
+            $notification,
+        );
+    }
+
+    public function testNotificationReceivedWithSyncCalendarNotificationAndInvalidCloudId(): void {
+        $this->cloudIdManager->expects(self::once())
+            ->method('resolveCloudId')
+            ->with('invalid-cloud-id')
+            ->willThrowException(new \InvalidArgumentException());
+
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('findByRemoteUrl');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        $this->expectException(ShareNotFound::class);
+        $this->expectExceptionMessage('Invalid sharee cloud id');
+        $this->calendarFederationProvider->notificationReceived(
+            'SYNC_CALENDAR',
+            'calendar',
+            [
+                'sharedSecret' => 'token',
+                'shareWith' => 'invalid-cloud-id',
+                'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+            ],
+        );
+    }
+
+    public function testNotificationReceivedWithSyncCalendarNotificationAndNoCalendars(): void {
+        $cloudId = $this->createMock(ICloudId::class);
+        $cloudId->method('getId')
+            ->willReturn('remote1@nextcloud.remote');
+        $cloudId->method('getUser')
+            ->willReturn('remote1');
+        $cloudId->method('getRemote')
+            ->willReturn('nextcloud.remote');
+
+        $this->cloudIdManager->expects(self::once())
+            ->method('resolveCloudId')
+            ->with('remote1@nextcloud.remote')
+            ->willReturn($cloudId);
+
+        $this->federatedCalendarMapper->expects(self::once())
+            ->method('findByRemoteUrl')
+            ->with(
+                'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+                'principals/users/remote1',
+                'token',
+            )
+            ->willReturn([]);
+
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        $this->expectException(ShareNotFound::class);
+        $this->expectExceptionMessage('Calendar is not shared with the sharee');
+        $this->calendarFederationProvider->notificationReceived(
+            'SYNC_CALENDAR',
+            'calendar',
+            [
+                'sharedSecret' => 'token',
+                'shareWith' => 'remote1@nextcloud.remote',
+                'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+            ],
+        );
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
 
 		$this->federatedCalendarMapper->expects(self::once())
 			->method('insert')
-			->willReturnCallback(function (FederatedCalendarEntity $calendar) {
+			->willReturnCallback(function(FederatedCalendarEntity $calendar) {
 				$this->assertEquals('principals/users/sharee1', $calendar->getPrincipaluri());
 				$this->assertEquals('ae4b8ab904076fff2b955ea21b1a0d92', $calendar->getUri());
 				$this->assertEquals('https://nextcloud.remote/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user1', $calendar->getRemoteUrl());

apps/dav/tests/unit/CalDAV/Federation/RemoteUserCalendarHomeTest.php

Indentation +98 added lines, -98 removed lines

@@ -20,102 +20,102 @@
 use Test\TestCase;
 
 class RemoteUserCalendarHomeTest extends TestCase {
-	private RemoteUserCalendarHome $remoteUserCalendarHome;
-
-	private BackendInterface&MockObject $calDavBackend;
-	private IL10N&MockObject $l10n;
-	private IConfig&MockObject $config;
-	private LoggerInterface&MockObject $logger;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->calDavBackend = $this->createMock(BackendInterface::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-
-		$this->remoteUserCalendarHome = new RemoteUserCalendarHome(
-			$this->calDavBackend,
-			[
-				'uri' => 'principals/remote-users/abcdef123',
-			],
-			$this->l10n,
-			$this->config,
-			$this->logger,
-		);
-	}
-
-	public function testGetChild(): void {
-		$calendar1 = [
-			'id' => 10,
-			'uri' => 'cal1',
-		];
-		$calendar2 = [
-			'id' => 11,
-			'uri' => 'cal2',
-		];
-
-		$this->calDavBackend->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('principals/remote-users/abcdef123')
-			->willReturn([
-				$calendar1,
-				$calendar2,
-			]);
-
-		$actual = $this->remoteUserCalendarHome->getChild('cal2');
-		$this->assertInstanceOf(Calendar::class, $actual);
-		$this->assertEquals(11, $actual->getResourceId());
-		$this->assertEquals('cal2', $actual->getName());
-	}
-
-	public function testGetChildNotFound(): void {
-		$calendar1 = [
-			'id' => 10,
-			'uri' => 'cal1',
-		];
-		$calendar2 = [
-			'id' => 11,
-			'uri' => 'cal2',
-		];
-
-		$this->calDavBackend->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('principals/remote-users/abcdef123')
-			->willReturn([
-				$calendar1,
-				$calendar2,
-			]);
-
-		$this->expectException(NotFound::class);
-		$this->remoteUserCalendarHome->getChild('cal3');
-	}
-
-	public function testGetChildren(): void {
-		$calendar1 = [
-			'id' => 10,
-			'uri' => 'cal1',
-		];
-		$calendar2 = [
-			'id' => 11,
-			'uri' => 'cal2',
-		];
-
-		$this->calDavBackend->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('principals/remote-users/abcdef123')
-			->willReturn([
-				$calendar1,
-				$calendar2,
-			]);
-
-		$actual = $this->remoteUserCalendarHome->getChildren();
-		$this->assertInstanceOf(Calendar::class, $actual[0]);
-		$this->assertEquals(10, $actual[0]->getResourceId());
-		$this->assertEquals('cal1', $actual[0]->getName());
-		$this->assertInstanceOf(Calendar::class, $actual[1]);
-		$this->assertEquals(11, $actual[1]->getResourceId());
-		$this->assertEquals('cal2', $actual[1]->getName());
-	}
+    private RemoteUserCalendarHome $remoteUserCalendarHome;
+
+    private BackendInterface&MockObject $calDavBackend;
+    private IL10N&MockObject $l10n;
+    private IConfig&MockObject $config;
+    private LoggerInterface&MockObject $logger;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->calDavBackend = $this->createMock(BackendInterface::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+
+        $this->remoteUserCalendarHome = new RemoteUserCalendarHome(
+            $this->calDavBackend,
+            [
+                'uri' => 'principals/remote-users/abcdef123',
+            ],
+            $this->l10n,
+            $this->config,
+            $this->logger,
+        );
+    }
+
+    public function testGetChild(): void {
+        $calendar1 = [
+            'id' => 10,
+            'uri' => 'cal1',
+        ];
+        $calendar2 = [
+            'id' => 11,
+            'uri' => 'cal2',
+        ];
+
+        $this->calDavBackend->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('principals/remote-users/abcdef123')
+            ->willReturn([
+                $calendar1,
+                $calendar2,
+            ]);
+
+        $actual = $this->remoteUserCalendarHome->getChild('cal2');
+        $this->assertInstanceOf(Calendar::class, $actual);
+        $this->assertEquals(11, $actual->getResourceId());
+        $this->assertEquals('cal2', $actual->getName());
+    }
+
+    public function testGetChildNotFound(): void {
+        $calendar1 = [
+            'id' => 10,
+            'uri' => 'cal1',
+        ];
+        $calendar2 = [
+            'id' => 11,
+            'uri' => 'cal2',
+        ];
+
+        $this->calDavBackend->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('principals/remote-users/abcdef123')
+            ->willReturn([
+                $calendar1,
+                $calendar2,
+            ]);
+
+        $this->expectException(NotFound::class);
+        $this->remoteUserCalendarHome->getChild('cal3');
+    }
+
+    public function testGetChildren(): void {
+        $calendar1 = [
+            'id' => 10,
+            'uri' => 'cal1',
+        ];
+        $calendar2 = [
+            'id' => 11,
+            'uri' => 'cal2',
+        ];
+
+        $this->calDavBackend->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('principals/remote-users/abcdef123')
+            ->willReturn([
+                $calendar1,
+                $calendar2,
+            ]);
+
+        $actual = $this->remoteUserCalendarHome->getChildren();
+        $this->assertInstanceOf(Calendar::class, $actual[0]);
+        $this->assertEquals(10, $actual[0]->getResourceId());
+        $this->assertEquals('cal1', $actual[0]->getName());
+        $this->assertInstanceOf(Calendar::class, $actual[1]);
+        $this->assertEquals(11, $actual[1]->getResourceId());
+        $this->assertEquals('cal2', $actual[1]->getName());
+    }
 }

apps/dav/tests/unit/CalDAV/Federation/FederationSharingServiceTest.php

Indentation +431 added lines, -431 removed lines

@@ -29,435 +29,435 @@
 use Test\TestCase;
 
 class FederationSharingServiceTest extends TestCase {
-	private FederationSharingService $federationSharingService;
-
-	private readonly ICloudFederationProviderManager&MockObject $federationManager;
-	private readonly ICloudFederationFactory&MockObject $federationFactory;
-	private readonly IUserManager&MockObject $userManager;
-	private readonly IURLGenerator&MockObject $url;
-	private readonly LoggerInterface&MockObject $logger;
-	private readonly ISecureRandom&MockObject $random;
-	private readonly SharingMapper&MockObject $sharingMapper;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->federationManager = $this->createMock(ICloudFederationProviderManager::class);
-		$this->federationFactory = $this->createMock(ICloudFederationFactory::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->url = $this->createMock(IURLGenerator::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->random = $this->createMock(ISecureRandom::class);
-		$this->sharingMapper = $this->createMock(SharingMapper::class);
-
-		$this->federationSharingService = new FederationSharingService(
-			$this->federationManager,
-			$this->federationFactory,
-			$this->userManager,
-			$this->url,
-			$this->logger,
-			$this->random,
-			$this->sharingMapper,
-		);
-	}
-
-	public function testShareWith(): void {
-		$shareable = $this->createMock(Calendar::class);
-		$shareable->method('getOwner')
-			->willReturn('principals/users/host1');
-		$shareable->method('getName')
-			->willReturn('cal1');
-		$shareable->method('getResourceId')
-			->willReturn(10);
-		$shareable->method('getProperties')
-			->willReturnCallback(static fn (array $props) => match ($props[0]) {
-				'{DAV:}displayname' => ['{DAV:}displayname' => 'Calendar 1'],
-				'{http://apple.com/ns/ical/}calendar-color' => [
-					'{http://apple.com/ns/ical/}calendar-color' => '#ff0000',
-				],
-				'{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => [
-					'{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => new SupportedCalendarComponentSet([
-						'VEVENT',
-						'VTODO',
-					]),
-				]
-			});
-
-		$hostUser = $this->createMock(IUser::class);
-		$hostUser->method('getCloudId')
-			->willReturn('host1@nextcloud.host');
-		$hostUser->method('getDisplayName')
-			->willReturn('Host 1');
-		$hostUser->method('getUID')
-			->willReturn('host1');
-		$this->userManager->expects(self::once())
-			->method('get')
-			->with('host1')
-			->willReturn($hostUser);
-
-		$this->random->expects(self::once())
-			->method('generate')
-			->with(32)
-			->willReturn('token');
-
-		$share = $this->createMock(ICloudFederationShare::class);
-		$share->expects(self::once())
-			->method('getProtocol')
-			->willReturn([
-				'preservedValue1' => 'foobar',
-				'preservedValue2' => 'baz',
-			]);
-		$share->expects(self::once())
-			->method('setProtocol')
-			->with([
-				'preservedValue1' => 'foobar',
-				'preservedValue2' => 'baz',
-				'version' => 'v1',
-				'url' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-				'displayName' => 'Calendar 1',
-				'color' => '#ff0000',
-				'access' => 3,
-				'components' => 'VEVENT,VTODO',
-			]);
-		$this->federationFactory->expects(self::once())
-			->method('getCloudFederationShare')
-			->with(
-				'remote1@nextcloud.remote',
-				'cal1',
-				'Calendar 1',
-				'calendar',
-				'host1@nextcloud.host',
-				'Host 1',
-				'host1@nextcloud.host',
-				'Host 1',
-				'token',
-				'user',
-				'calendar',
-			)
-			->willReturn($share);
-
-		$this->url->expects(self::once())
-			->method('linkTo')
-			->with('', 'remote.php')
-			->willReturn('/remote.php');
-		$this->url->expects(self::once())
-			->method('getAbsoluteURL')
-			->with('/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1')
-			->willReturn('https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1');
-
-		$response = $this->createMock(IResponse::class);
-		$response->method('getStatusCode')
-			->willReturn(201);
-		$this->federationManager->expects(self::once())
-			->method('sendCloudShare')
-			->with($share)
-			->willReturn($response);
-
-		$this->sharingMapper->expects(self::once())
-			->method('deleteShare')
-			->with(10, 'calendar', 'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl');
-		$this->sharingMapper->expects(self::once())
-			->method('shareWithToken')
-			->with(
-				10,
-				'calendar',
-				3,
-				'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
-				'token',
-			);
-
-		$this->federationSharingService->shareWith(
-			$shareable,
-			'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
-			3, // Read-only
-		);
-	}
-
-	public function testShareWithWithFailingFederationManager(): void {
-		$shareable = $this->createMock(Calendar::class);
-		$shareable->method('getOwner')
-			->willReturn('principals/users/host1');
-		$shareable->method('getName')
-			->willReturn('cal1');
-		$shareable->method('getResourceId')
-			->willReturn(10);
-		$shareable->method('getProperties')
-			->willReturnCallback(static fn (array $props) => match ($props[0]) {
-				'{DAV:}displayname' => ['{DAV:}displayname' => 'Calendar 1'],
-				'{http://apple.com/ns/ical/}calendar-color' => [
-					'{http://apple.com/ns/ical/}calendar-color' => '#ff0000',
-				],
-				'{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => [
-					'{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => new SupportedCalendarComponentSet([
-						'VEVENT',
-						'VTODO',
-					]),
-				]
-			});
-
-		$hostUser = $this->createMock(IUser::class);
-		$hostUser->method('getCloudId')
-			->willReturn('host1@nextcloud.host');
-		$hostUser->method('getDisplayName')
-			->willReturn('Host 1');
-		$hostUser->method('getUID')
-			->willReturn('host1');
-		$this->userManager->expects(self::once())
-			->method('get')
-			->with('host1')
-			->willReturn($hostUser);
-
-		$this->random->expects(self::once())
-			->method('generate')
-			->with(32)
-			->willReturn('token');
-
-		$share = $this->createMock(ICloudFederationShare::class);
-		$share->expects(self::once())
-			->method('getProtocol')
-			->willReturn([
-				'preservedValue1' => 'foobar',
-				'preservedValue2' => 'baz',
-			]);
-		$share->expects(self::once())
-			->method('setProtocol')
-			->with([
-				'preservedValue1' => 'foobar',
-				'preservedValue2' => 'baz',
-				'version' => 'v1',
-				'url' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-				'displayName' => 'Calendar 1',
-				'color' => '#ff0000',
-				'access' => 3,
-				'components' => 'VEVENT,VTODO',
-			]);
-		$this->federationFactory->expects(self::once())
-			->method('getCloudFederationShare')
-			->with(
-				'remote1@nextcloud.remote',
-				'cal1',
-				'Calendar 1',
-				'calendar',
-				'host1@nextcloud.host',
-				'Host 1',
-				'host1@nextcloud.host',
-				'Host 1',
-				'token',
-				'user',
-				'calendar',
-			)
-			->willReturn($share);
-
-		$this->url->expects(self::once())
-			->method('linkTo')
-			->with('', 'remote.php')
-			->willReturn('/remote.php');
-		$this->url->expects(self::once())
-			->method('getAbsoluteURL')
-			->with('/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1')
-			->willReturn('https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1');
-
-		$response = $this->createMock(IResponse::class);
-		$response->method('getStatusCode')
-			->willReturn(201);
-		$this->federationManager->expects(self::once())
-			->method('sendCloudShare')
-			->with($share)
-			->willThrowException(new OCMProviderException());
-
-		$this->sharingMapper->expects(self::never())
-			->method('deleteShare');
-		$this->sharingMapper->expects(self::never())
-			->method('shareWithToken');
-
-		$this->federationSharingService->shareWith(
-			$shareable,
-			'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
-			3, // Read-only
-		);
-	}
-
-	public function testShareWithWithUnsuccessfulResponse(): void {
-		$shareable = $this->createMock(Calendar::class);
-		$shareable->method('getOwner')
-			->willReturn('principals/users/host1');
-		$shareable->method('getName')
-			->willReturn('cal1');
-		$shareable->method('getResourceId')
-			->willReturn(10);
-		$shareable->method('getProperties')
-			->willReturnCallback(static fn (array $props) => match ($props[0]) {
-				'{DAV:}displayname' => ['{DAV:}displayname' => 'Calendar 1'],
-				'{http://apple.com/ns/ical/}calendar-color' => [
-					'{http://apple.com/ns/ical/}calendar-color' => '#ff0000',
-				],
-				'{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => [
-					'{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => new SupportedCalendarComponentSet([
-						'VEVENT',
-						'VTODO',
-					]),
-				]
-			});
-
-		$hostUser = $this->createMock(IUser::class);
-		$hostUser->method('getCloudId')
-			->willReturn('host1@nextcloud.host');
-		$hostUser->method('getDisplayName')
-			->willReturn('Host 1');
-		$hostUser->method('getUID')
-			->willReturn('host1');
-		$this->userManager->expects(self::once())
-			->method('get')
-			->with('host1')
-			->willReturn($hostUser);
-
-		$this->random->expects(self::once())
-			->method('generate')
-			->with(32)
-			->willReturn('token');
-
-		$share = $this->createMock(ICloudFederationShare::class);
-		$share->expects(self::once())
-			->method('getProtocol')
-			->willReturn([
-				'preservedValue1' => 'foobar',
-				'preservedValue2' => 'baz',
-			]);
-		$share->expects(self::once())
-			->method('setProtocol')
-			->with([
-				'preservedValue1' => 'foobar',
-				'preservedValue2' => 'baz',
-				'version' => 'v1',
-				'url' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-				'displayName' => 'Calendar 1',
-				'color' => '#ff0000',
-				'access' => 3,
-				'components' => 'VEVENT,VTODO',
-			]);
-		$this->federationFactory->expects(self::once())
-			->method('getCloudFederationShare')
-			->with(
-				'remote1@nextcloud.remote',
-				'cal1',
-				'Calendar 1',
-				'calendar',
-				'host1@nextcloud.host',
-				'Host 1',
-				'host1@nextcloud.host',
-				'Host 1',
-				'token',
-				'user',
-				'calendar',
-			)
-			->willReturn($share);
-
-		$this->url->expects(self::once())
-			->method('linkTo')
-			->with('', 'remote.php')
-			->willReturn('/remote.php');
-		$this->url->expects(self::once())
-			->method('getAbsoluteURL')
-			->with('/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1')
-			->willReturn('https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1');
-
-		$response = $this->createMock(IResponse::class);
-		$response->method('getStatusCode')
-			->willReturn(400);
-		$this->federationManager->expects(self::once())
-			->method('sendCloudShare')
-			->with($share)
-			->willReturn($response);
-
-		$this->sharingMapper->expects(self::never())
-			->method('deleteShare');
-		$this->sharingMapper->expects(self::never())
-			->method('shareWithToken');
-
-		$this->federationSharingService->shareWith(
-			$shareable,
-			'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
-			3, // Read-only
-		);
-	}
-
-	public static function provideInvalidRemoteUserPrincipalData(): array {
-		return [
-			['principals/users/foobar'],
-			['remote-users/remote1'],
-			['foobar/remote-users/remote1'],
-			['principals/remote-groups/group1'],
-		];
-	}
-
-	#[DataProvider('provideInvalidRemoteUserPrincipalData')]
-	public function testShareWithWithInvalidRemoteUserPrincipal(string $remoteUserPrincipal): void {
-		$shareable = $this->createMock(Calendar::class);
-		$shareable->method('getOwner')
-			->willReturn('principals/users/host1');
-
-		$this->userManager->expects(self::never())
-			->method('get');
-
-		$this->federationManager->expects(self::never())
-			->method('sendCloudShare');
-		$this->sharingMapper->expects(self::never())
-			->method('deleteShare');
-		$this->sharingMapper->expects(self::never())
-			->method('shareWithToken');
-
-		$this->federationSharingService->shareWith(
-			$shareable,
-			$remoteUserPrincipal,
-			3, // Read-only
-		);
-	}
-
-	public function testShareWithWithUnknownUser(): void {
-		$shareable = $this->createMock(Calendar::class);
-		$shareable->method('getOwner')
-			->willReturn('principals/users/host1');
-
-		$this->userManager->expects(self::once())
-			->method('get')
-			->with('host1')
-			->willReturn(null);
-
-		$this->federationManager->expects(self::never())
-			->method('sendCloudShare');
-		$this->sharingMapper->expects(self::never())
-			->method('deleteShare');
-		$this->sharingMapper->expects(self::never())
-			->method('shareWithToken');
-
-		$this->federationSharingService->shareWith(
-			$shareable,
-			'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
-			3, // Read-only
-		);
-	}
-
-	public function testShareWithWithInvalidShareable(): void {
-		$shareable = $this->createMock(IShareable::class);
-		$shareable->method('getOwner')
-			->willReturn('principals/users/host1');
-
-		$this->userManager->expects(self::once())
-			->method('get')
-			->with('host1')
-			->willReturn(null);
-
-		$this->federationManager->expects(self::never())
-			->method('sendCloudShare');
-		$this->sharingMapper->expects(self::never())
-			->method('deleteShare');
-		$this->sharingMapper->expects(self::never())
-			->method('shareWithToken');
-
-		$this->federationSharingService->shareWith(
-			$shareable,
-			'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
-			3, // Read-only
-		);
-	}
+    private FederationSharingService $federationSharingService;
+
+    private readonly ICloudFederationProviderManager&MockObject $federationManager;
+    private readonly ICloudFederationFactory&MockObject $federationFactory;
+    private readonly IUserManager&MockObject $userManager;
+    private readonly IURLGenerator&MockObject $url;
+    private readonly LoggerInterface&MockObject $logger;
+    private readonly ISecureRandom&MockObject $random;
+    private readonly SharingMapper&MockObject $sharingMapper;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->federationManager = $this->createMock(ICloudFederationProviderManager::class);
+        $this->federationFactory = $this->createMock(ICloudFederationFactory::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->url = $this->createMock(IURLGenerator::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->random = $this->createMock(ISecureRandom::class);
+        $this->sharingMapper = $this->createMock(SharingMapper::class);
+
+        $this->federationSharingService = new FederationSharingService(
+            $this->federationManager,
+            $this->federationFactory,
+            $this->userManager,
+            $this->url,
+            $this->logger,
+            $this->random,
+            $this->sharingMapper,
+        );
+    }
+
+    public function testShareWith(): void {
+        $shareable = $this->createMock(Calendar::class);
+        $shareable->method('getOwner')
+            ->willReturn('principals/users/host1');
+        $shareable->method('getName')
+            ->willReturn('cal1');
+        $shareable->method('getResourceId')
+            ->willReturn(10);
+        $shareable->method('getProperties')
+            ->willReturnCallback(static fn (array $props) => match ($props[0]) {
+                '{DAV:}displayname' => ['{DAV:}displayname' => 'Calendar 1'],
+                '{http://apple.com/ns/ical/}calendar-color' => [
+                    '{http://apple.com/ns/ical/}calendar-color' => '#ff0000',
+                ],
+                '{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => [
+                    '{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => new SupportedCalendarComponentSet([
+                        'VEVENT',
+                        'VTODO',
+                    ]),
+                ]
+            });
+
+        $hostUser = $this->createMock(IUser::class);
+        $hostUser->method('getCloudId')
+            ->willReturn('host1@nextcloud.host');
+        $hostUser->method('getDisplayName')
+            ->willReturn('Host 1');
+        $hostUser->method('getUID')
+            ->willReturn('host1');
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->with('host1')
+            ->willReturn($hostUser);
+
+        $this->random->expects(self::once())
+            ->method('generate')
+            ->with(32)
+            ->willReturn('token');
+
+        $share = $this->createMock(ICloudFederationShare::class);
+        $share->expects(self::once())
+            ->method('getProtocol')
+            ->willReturn([
+                'preservedValue1' => 'foobar',
+                'preservedValue2' => 'baz',
+            ]);
+        $share->expects(self::once())
+            ->method('setProtocol')
+            ->with([
+                'preservedValue1' => 'foobar',
+                'preservedValue2' => 'baz',
+                'version' => 'v1',
+                'url' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+                'displayName' => 'Calendar 1',
+                'color' => '#ff0000',
+                'access' => 3,
+                'components' => 'VEVENT,VTODO',
+            ]);
+        $this->federationFactory->expects(self::once())
+            ->method('getCloudFederationShare')
+            ->with(
+                'remote1@nextcloud.remote',
+                'cal1',
+                'Calendar 1',
+                'calendar',
+                'host1@nextcloud.host',
+                'Host 1',
+                'host1@nextcloud.host',
+                'Host 1',
+                'token',
+                'user',
+                'calendar',
+            )
+            ->willReturn($share);
+
+        $this->url->expects(self::once())
+            ->method('linkTo')
+            ->with('', 'remote.php')
+            ->willReturn('/remote.php');
+        $this->url->expects(self::once())
+            ->method('getAbsoluteURL')
+            ->with('/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1')
+            ->willReturn('https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1');
+
+        $response = $this->createMock(IResponse::class);
+        $response->method('getStatusCode')
+            ->willReturn(201);
+        $this->federationManager->expects(self::once())
+            ->method('sendCloudShare')
+            ->with($share)
+            ->willReturn($response);
+
+        $this->sharingMapper->expects(self::once())
+            ->method('deleteShare')
+            ->with(10, 'calendar', 'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl');
+        $this->sharingMapper->expects(self::once())
+            ->method('shareWithToken')
+            ->with(
+                10,
+                'calendar',
+                3,
+                'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
+                'token',
+            );
+
+        $this->federationSharingService->shareWith(
+            $shareable,
+            'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
+            3, // Read-only
+        );
+    }
+
+    public function testShareWithWithFailingFederationManager(): void {
+        $shareable = $this->createMock(Calendar::class);
+        $shareable->method('getOwner')
+            ->willReturn('principals/users/host1');
+        $shareable->method('getName')
+            ->willReturn('cal1');
+        $shareable->method('getResourceId')
+            ->willReturn(10);
+        $shareable->method('getProperties')
+            ->willReturnCallback(static fn (array $props) => match ($props[0]) {
+                '{DAV:}displayname' => ['{DAV:}displayname' => 'Calendar 1'],
+                '{http://apple.com/ns/ical/}calendar-color' => [
+                    '{http://apple.com/ns/ical/}calendar-color' => '#ff0000',
+                ],
+                '{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => [
+                    '{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => new SupportedCalendarComponentSet([
+                        'VEVENT',
+                        'VTODO',
+                    ]),
+                ]
+            });
+
+        $hostUser = $this->createMock(IUser::class);
+        $hostUser->method('getCloudId')
+            ->willReturn('host1@nextcloud.host');
+        $hostUser->method('getDisplayName')
+            ->willReturn('Host 1');
+        $hostUser->method('getUID')
+            ->willReturn('host1');
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->with('host1')
+            ->willReturn($hostUser);
+
+        $this->random->expects(self::once())
+            ->method('generate')
+            ->with(32)
+            ->willReturn('token');
+
+        $share = $this->createMock(ICloudFederationShare::class);
+        $share->expects(self::once())
+            ->method('getProtocol')
+            ->willReturn([
+                'preservedValue1' => 'foobar',
+                'preservedValue2' => 'baz',
+            ]);
+        $share->expects(self::once())
+            ->method('setProtocol')
+            ->with([
+                'preservedValue1' => 'foobar',
+                'preservedValue2' => 'baz',
+                'version' => 'v1',
+                'url' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+                'displayName' => 'Calendar 1',
+                'color' => '#ff0000',
+                'access' => 3,
+                'components' => 'VEVENT,VTODO',
+            ]);
+        $this->federationFactory->expects(self::once())
+            ->method('getCloudFederationShare')
+            ->with(
+                'remote1@nextcloud.remote',
+                'cal1',
+                'Calendar 1',
+                'calendar',
+                'host1@nextcloud.host',
+                'Host 1',
+                'host1@nextcloud.host',
+                'Host 1',
+                'token',
+                'user',
+                'calendar',
+            )
+            ->willReturn($share);
+
+        $this->url->expects(self::once())
+            ->method('linkTo')
+            ->with('', 'remote.php')
+            ->willReturn('/remote.php');
+        $this->url->expects(self::once())
+            ->method('getAbsoluteURL')
+            ->with('/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1')
+            ->willReturn('https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1');
+
+        $response = $this->createMock(IResponse::class);
+        $response->method('getStatusCode')
+            ->willReturn(201);
+        $this->federationManager->expects(self::once())
+            ->method('sendCloudShare')
+            ->with($share)
+            ->willThrowException(new OCMProviderException());
+
+        $this->sharingMapper->expects(self::never())
+            ->method('deleteShare');
+        $this->sharingMapper->expects(self::never())
+            ->method('shareWithToken');
+
+        $this->federationSharingService->shareWith(
+            $shareable,
+            'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
+            3, // Read-only
+        );
+    }
+
+    public function testShareWithWithUnsuccessfulResponse(): void {
+        $shareable = $this->createMock(Calendar::class);
+        $shareable->method('getOwner')
+            ->willReturn('principals/users/host1');
+        $shareable->method('getName')
+            ->willReturn('cal1');
+        $shareable->method('getResourceId')
+            ->willReturn(10);
+        $shareable->method('getProperties')
+            ->willReturnCallback(static fn (array $props) => match ($props[0]) {
+                '{DAV:}displayname' => ['{DAV:}displayname' => 'Calendar 1'],
+                '{http://apple.com/ns/ical/}calendar-color' => [
+                    '{http://apple.com/ns/ical/}calendar-color' => '#ff0000',
+                ],
+                '{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => [
+                    '{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set' => new SupportedCalendarComponentSet([
+                        'VEVENT',
+                        'VTODO',
+                    ]),
+                ]
+            });
+
+        $hostUser = $this->createMock(IUser::class);
+        $hostUser->method('getCloudId')
+            ->willReturn('host1@nextcloud.host');
+        $hostUser->method('getDisplayName')
+            ->willReturn('Host 1');
+        $hostUser->method('getUID')
+            ->willReturn('host1');
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->with('host1')
+            ->willReturn($hostUser);
+
+        $this->random->expects(self::once())
+            ->method('generate')
+            ->with(32)
+            ->willReturn('token');
+
+        $share = $this->createMock(ICloudFederationShare::class);
+        $share->expects(self::once())
+            ->method('getProtocol')
+            ->willReturn([
+                'preservedValue1' => 'foobar',
+                'preservedValue2' => 'baz',
+            ]);
+        $share->expects(self::once())
+            ->method('setProtocol')
+            ->with([
+                'preservedValue1' => 'foobar',
+                'preservedValue2' => 'baz',
+                'version' => 'v1',
+                'url' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+                'displayName' => 'Calendar 1',
+                'color' => '#ff0000',
+                'access' => 3,
+                'components' => 'VEVENT,VTODO',
+            ]);
+        $this->federationFactory->expects(self::once())
+            ->method('getCloudFederationShare')
+            ->with(
+                'remote1@nextcloud.remote',
+                'cal1',
+                'Calendar 1',
+                'calendar',
+                'host1@nextcloud.host',
+                'Host 1',
+                'host1@nextcloud.host',
+                'Host 1',
+                'token',
+                'user',
+                'calendar',
+            )
+            ->willReturn($share);
+
+        $this->url->expects(self::once())
+            ->method('linkTo')
+            ->with('', 'remote.php')
+            ->willReturn('/remote.php');
+        $this->url->expects(self::once())
+            ->method('getAbsoluteURL')
+            ->with('/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1')
+            ->willReturn('https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1');
+
+        $response = $this->createMock(IResponse::class);
+        $response->method('getStatusCode')
+            ->willReturn(400);
+        $this->federationManager->expects(self::once())
+            ->method('sendCloudShare')
+            ->with($share)
+            ->willReturn($response);
+
+        $this->sharingMapper->expects(self::never())
+            ->method('deleteShare');
+        $this->sharingMapper->expects(self::never())
+            ->method('shareWithToken');
+
+        $this->federationSharingService->shareWith(
+            $shareable,
+            'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
+            3, // Read-only
+        );
+    }
+
+    public static function provideInvalidRemoteUserPrincipalData(): array {
+        return [
+            ['principals/users/foobar'],
+            ['remote-users/remote1'],
+            ['foobar/remote-users/remote1'],
+            ['principals/remote-groups/group1'],
+        ];
+    }
+
+    #[DataProvider('provideInvalidRemoteUserPrincipalData')]
+    public function testShareWithWithInvalidRemoteUserPrincipal(string $remoteUserPrincipal): void {
+        $shareable = $this->createMock(Calendar::class);
+        $shareable->method('getOwner')
+            ->willReturn('principals/users/host1');
+
+        $this->userManager->expects(self::never())
+            ->method('get');
+
+        $this->federationManager->expects(self::never())
+            ->method('sendCloudShare');
+        $this->sharingMapper->expects(self::never())
+            ->method('deleteShare');
+        $this->sharingMapper->expects(self::never())
+            ->method('shareWithToken');
+
+        $this->federationSharingService->shareWith(
+            $shareable,
+            $remoteUserPrincipal,
+            3, // Read-only
+        );
+    }
+
+    public function testShareWithWithUnknownUser(): void {
+        $shareable = $this->createMock(Calendar::class);
+        $shareable->method('getOwner')
+            ->willReturn('principals/users/host1');
+
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->with('host1')
+            ->willReturn(null);
+
+        $this->federationManager->expects(self::never())
+            ->method('sendCloudShare');
+        $this->sharingMapper->expects(self::never())
+            ->method('deleteShare');
+        $this->sharingMapper->expects(self::never())
+            ->method('shareWithToken');
+
+        $this->federationSharingService->shareWith(
+            $shareable,
+            'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
+            3, // Read-only
+        );
+    }
+
+    public function testShareWithWithInvalidShareable(): void {
+        $shareable = $this->createMock(IShareable::class);
+        $shareable->method('getOwner')
+            ->willReturn('principals/users/host1');
+
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->with('host1')
+            ->willReturn(null);
+
+        $this->federationManager->expects(self::never())
+            ->method('sendCloudShare');
+        $this->sharingMapper->expects(self::never())
+            ->method('deleteShare');
+        $this->sharingMapper->expects(self::never())
+            ->method('shareWithToken');
+
+        $this->federationSharingService->shareWith(
+            $shareable,
+            'principals/remote-users/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl',
+            3, // Read-only
+        );
+    }
 }

apps/dav/tests/unit/CalDAV/Federation/FederatedCalendarImplTest.php

Indentation +22 added lines, -22 removed lines

@@ -15,34 +15,34 @@
 use Test\TestCase;
 
 class FederatedCalendarImplTest extends TestCase {
-	private FederatedCalendarImpl $federatedCalendarImpl;
+    private FederatedCalendarImpl $federatedCalendarImpl;
 
-	private CalDavBackend&MockObject $calDavBackend;
+    private CalDavBackend&MockObject $calDavBackend;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->calDavBackend = $this->createMock(CalDavBackend::class);
+        $this->calDavBackend = $this->createMock(CalDavBackend::class);
 
-		$this->federatedCalendarImpl = new FederatedCalendarImpl(
-			[],
-			$this->calDavBackend,
-		);
-	}
+        $this->federatedCalendarImpl = new FederatedCalendarImpl(
+            [],
+            $this->calDavBackend,
+        );
+    }
 
-	public function testGetPermissions(): void {
-		$this->assertEquals(1, $this->federatedCalendarImpl->getPermissions());
-	}
+    public function testGetPermissions(): void {
+        $this->assertEquals(1, $this->federatedCalendarImpl->getPermissions());
+    }
 
-	public function testIsDeleted(): void {
-		$this->assertFalse($this->federatedCalendarImpl->isDeleted());
-	}
+    public function testIsDeleted(): void {
+        $this->assertFalse($this->federatedCalendarImpl->isDeleted());
+    }
 
-	public function testIsShared(): void {
-		$this->assertTrue($this->federatedCalendarImpl->isShared());
-	}
+    public function testIsShared(): void {
+        $this->assertTrue($this->federatedCalendarImpl->isShared());
+    }
 
-	public function testIsWritable(): void {
-		$this->assertFalse($this->federatedCalendarImpl->isWritable());
-	}
+    public function testIsWritable(): void {
+        $this->assertFalse($this->federatedCalendarImpl->isWritable());
+    }
 }

apps/dav/tests/unit/CalDAV/Federation/CalendarFederationNotifierTest.php

Indentation +104 added lines, -104 removed lines

@@ -21,108 +21,108 @@
 use Test\TestCase;
 
 class CalendarFederationNotifierTest extends TestCase {
-	private readonly CalendarFederationNotifier $calendarFederationNotifier;
-
-	private readonly ICloudFederationFactory&MockObject $federationFactory;
-	private readonly ICloudFederationProviderManager&MockObject $federationManager;
-	private readonly IURLGenerator&MockObject $url;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->federationFactory = $this->createMock(ICloudFederationFactory::class);
-		$this->federationManager = $this->createMock(ICloudFederationProviderManager::class);
-		$this->url = $this->createMock(IURLGenerator::class);
-
-		$this->calendarFederationNotifier = new CalendarFederationNotifier(
-			$this->federationFactory,
-			$this->federationManager,
-			$this->url,
-		);
-	}
-
-	public function testNotifySyncCalendar(): void {
-		$cloudId = $this->createMock(ICloudId::class);
-		$cloudId->method('getId')
-			->willReturn('remote1@nextcloud.remote');
-		$cloudId->method('getRemote')
-			->willReturn('nextcloud.remote');
-
-		$this->url->expects(self::once())
-			->method('linkTo')
-			->with('', 'remote.php')
-			->willReturn('/remote.php');
-		$this->url->expects(self::once())
-			->method('getAbsoluteURL')
-			->with('/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1')
-			->willReturn('https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1');
-
-		$notification = $this->createMock(ICloudFederationNotification::class);
-		$notification->expects(self::once())
-			->method('setMessage')
-			->with(
-				'SYNC_CALENDAR',
-				'calendar',
-				'calendar',
-				[
-					'sharedSecret' => 'token',
-					'shareWith' => 'remote1@nextcloud.remote',
-					'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-				],
-			);
-		$this->federationFactory->expects(self::once())
-			->method('getCloudFederationNotification')
-			->willReturn($notification);
-
-		$response = $this->createMock(IResponse::class);
-		$this->federationManager->expects(self::once())
-			->method('sendCloudNotification')
-			->with('nextcloud.remote', $notification)
-			->willReturn($response);
-
-		$this->calendarFederationNotifier->notifySyncCalendar($cloudId, 'host1', 'cal1', 'token');
-	}
-
-	public function testNotifySyncCalendarShouldRethrowOcmException(): void {
-		$cloudId = $this->createMock(ICloudId::class);
-		$cloudId->method('getId')
-			->willReturn('remote1@nextcloud.remote');
-		$cloudId->method('getRemote')
-			->willReturn('nextcloud.remote');
-
-		$this->url->expects(self::once())
-			->method('linkTo')
-			->with('', 'remote.php')
-			->willReturn('/remote.php');
-		$this->url->expects(self::once())
-			->method('getAbsoluteURL')
-			->with('/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1')
-			->willReturn('https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1');
-
-		$notification = $this->createMock(ICloudFederationNotification::class);
-		$notification->expects(self::once())
-			->method('setMessage')
-			->with(
-				'SYNC_CALENDAR',
-				'calendar',
-				'calendar',
-				[
-					'sharedSecret' => 'token',
-					'shareWith' => 'remote1@nextcloud.remote',
-					'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
-				],
-			);
-		$this->federationFactory->expects(self::once())
-			->method('getCloudFederationNotification')
-			->willReturn($notification);
-
-		$this->federationManager->expects(self::once())
-			->method('sendCloudNotification')
-			->with('nextcloud.remote', $notification)
-			->willThrowException(new OCMProviderException('I threw this'));
-
-		$this->expectException(OCMProviderException::class);
-		$this->expectExceptionMessage('I threw this');
-		$this->calendarFederationNotifier->notifySyncCalendar($cloudId, 'host1', 'cal1', 'token');
-	}
+    private readonly CalendarFederationNotifier $calendarFederationNotifier;
+
+    private readonly ICloudFederationFactory&MockObject $federationFactory;
+    private readonly ICloudFederationProviderManager&MockObject $federationManager;
+    private readonly IURLGenerator&MockObject $url;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->federationFactory = $this->createMock(ICloudFederationFactory::class);
+        $this->federationManager = $this->createMock(ICloudFederationProviderManager::class);
+        $this->url = $this->createMock(IURLGenerator::class);
+
+        $this->calendarFederationNotifier = new CalendarFederationNotifier(
+            $this->federationFactory,
+            $this->federationManager,
+            $this->url,
+        );
+    }
+
+    public function testNotifySyncCalendar(): void {
+        $cloudId = $this->createMock(ICloudId::class);
+        $cloudId->method('getId')
+            ->willReturn('remote1@nextcloud.remote');
+        $cloudId->method('getRemote')
+            ->willReturn('nextcloud.remote');
+
+        $this->url->expects(self::once())
+            ->method('linkTo')
+            ->with('', 'remote.php')
+            ->willReturn('/remote.php');
+        $this->url->expects(self::once())
+            ->method('getAbsoluteURL')
+            ->with('/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1')
+            ->willReturn('https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1');
+
+        $notification = $this->createMock(ICloudFederationNotification::class);
+        $notification->expects(self::once())
+            ->method('setMessage')
+            ->with(
+                'SYNC_CALENDAR',
+                'calendar',
+                'calendar',
+                [
+                    'sharedSecret' => 'token',
+                    'shareWith' => 'remote1@nextcloud.remote',
+                    'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+                ],
+            );
+        $this->federationFactory->expects(self::once())
+            ->method('getCloudFederationNotification')
+            ->willReturn($notification);
+
+        $response = $this->createMock(IResponse::class);
+        $this->federationManager->expects(self::once())
+            ->method('sendCloudNotification')
+            ->with('nextcloud.remote', $notification)
+            ->willReturn($response);
+
+        $this->calendarFederationNotifier->notifySyncCalendar($cloudId, 'host1', 'cal1', 'token');
+    }
+
+    public function testNotifySyncCalendarShouldRethrowOcmException(): void {
+        $cloudId = $this->createMock(ICloudId::class);
+        $cloudId->method('getId')
+            ->willReturn('remote1@nextcloud.remote');
+        $cloudId->method('getRemote')
+            ->willReturn('nextcloud.remote');
+
+        $this->url->expects(self::once())
+            ->method('linkTo')
+            ->with('', 'remote.php')
+            ->willReturn('/remote.php');
+        $this->url->expects(self::once())
+            ->method('getAbsoluteURL')
+            ->with('/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1')
+            ->willReturn('https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1');
+
+        $notification = $this->createMock(ICloudFederationNotification::class);
+        $notification->expects(self::once())
+            ->method('setMessage')
+            ->with(
+                'SYNC_CALENDAR',
+                'calendar',
+                'calendar',
+                [
+                    'sharedSecret' => 'token',
+                    'shareWith' => 'remote1@nextcloud.remote',
+                    'calendarUrl' => 'https://nextcloud.host/remote.php/dav/remote-calendars/cmVtb3RlMUBuZXh0Y2xvdWQucmVtb3Rl/cal1_shared_by_host1',
+                ],
+            );
+        $this->federationFactory->expects(self::once())
+            ->method('getCloudFederationNotification')
+            ->willReturn($notification);
+
+        $this->federationManager->expects(self::once())
+            ->method('sendCloudNotification')
+            ->with('nextcloud.remote', $notification)
+            ->willThrowException(new OCMProviderException('I threw this'));
+
+        $this->expectException(OCMProviderException::class);
+        $this->expectExceptionMessage('I threw this');
+        $this->calendarFederationNotifier->notifySyncCalendar($cloudId, 'host1', 'cal1', 'token');
+    }
 }

apps/dav/tests/unit/CalDAV/Federation/FederatedCalendarSyncServiceTest.php

Indentation +139 added lines, -139 removed lines

@@ -22,143 +22,143 @@
 use Test\TestCase;
 
 class FederatedCalendarSyncServiceTest extends TestCase {
-	private FederatedCalendarSyncService $federatedCalendarSyncService;
-
-	private FederatedCalendarMapper&MockObject $federatedCalendarMapper;
-	private LoggerInterface&MockObject $logger;
-	private CalDavSyncService&MockObject $calDavSyncService;
-	private ICloudIdManager&MockObject $cloudIdManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->federatedCalendarMapper = $this->createMock(FederatedCalendarMapper::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->calDavSyncService = $this->createMock(CalDavSyncService::class);
-		$this->cloudIdManager = $this->createMock(ICloudIdManager::class);
-
-		$this->federatedCalendarSyncService = new FederatedCalendarSyncService(
-			$this->federatedCalendarMapper,
-			$this->logger,
-			$this->calDavSyncService,
-			$this->cloudIdManager,
-		);
-	}
-
-	public function testSyncOne(): void {
-		$calendar = new FederatedCalendarEntity();
-		$calendar->setId(1);
-		$calendar->setPrincipaluri('principals/users/user1');
-		$calendar->setRemoteUrl('https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2');
-		$calendar->setSyncToken(100);
-		$calendar->setToken('token');
-
-		$cloudId = $this->createMock(ICloudId::class);
-		$cloudId->method('getId')
-			->willReturn('user1@nextcloud.testing');
-		$this->cloudIdManager->expects(self::once())
-			->method('getCloudId')
-			->with('user1')
-			->willReturn($cloudId);
-
-		$this->calDavSyncService->expects(self::once())
-			->method('syncRemoteCalendar')
-			->with(
-				'https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2',
-				'dXNlcjFAbmV4dGNsb3VkLnRlc3Rpbmc=',
-				'token',
-				'http://sabre.io/ns/sync/100',
-				$calendar,
-			)
-			->willReturn(new SyncServiceResult('http://sabre.io/ns/sync/101', 10));
-
-		$this->federatedCalendarMapper->expects(self::once())
-			->method('updateSyncTokenAndTime')
-			->with(1, 101);
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('updateSyncTime');
-
-		$this->assertEquals(10, $this->federatedCalendarSyncService->syncOne($calendar));
-	}
-
-	public function testSyncOneUnchanged(): void {
-		$calendar = new FederatedCalendarEntity();
-		$calendar->setId(1);
-		$calendar->setPrincipaluri('principals/users/user1');
-		$calendar->setRemoteUrl('https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2');
-		$calendar->setSyncToken(100);
-		$calendar->setToken('token');
-
-		$cloudId = $this->createMock(ICloudId::class);
-		$cloudId->method('getId')
-			->willReturn('user1@nextcloud.testing');
-		$this->cloudIdManager->expects(self::once())
-			->method('getCloudId')
-			->with('user1')
-			->willReturn($cloudId);
-
-		$this->calDavSyncService->expects(self::once())
-			->method('syncRemoteCalendar')
-			->with(
-				'https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2',
-				'dXNlcjFAbmV4dGNsb3VkLnRlc3Rpbmc=',
-				'token',
-				'http://sabre.io/ns/sync/100',
-				$calendar,
-			)
-			->willReturn(new SyncServiceResult('http://sabre.io/ns/sync/100', 0));
-
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('updateSyncTokenAndTime');
-		$this->federatedCalendarMapper->expects(self::once())
-			->method('updateSyncTime')
-			->with(1);
-
-		$this->assertEquals(0, $this->federatedCalendarSyncService->syncOne($calendar));
-	}
-
-	public static function provideUnexpectedSyncTokenData(): array {
-		return [
-			['http://sabre.io/ns/sync/'],
-			['http://sabre.io/ns/sync/foobar'],
-			['http://sabre.io/ns/sync/23abc'],
-			['http://nextcloud.com/ns/sync/33'],
-		];
-	}
-
-	#[DataProvider('provideUnexpectedSyncTokenData')]
-	public function testSyncOneWithUnexpectedSyncTokenFormat(string $syncToken): void {
-		$calendar = new FederatedCalendarEntity();
-		$calendar->setId(1);
-		$calendar->setPrincipaluri('principals/users/user1');
-		$calendar->setRemoteUrl('https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2');
-		$calendar->setSyncToken(100);
-		$calendar->setToken('token');
-
-		$cloudId = $this->createMock(ICloudId::class);
-		$cloudId->method('getId')
-			->willReturn('user1@nextcloud.testing');
-		$this->cloudIdManager->expects(self::once())
-			->method('getCloudId')
-			->with('user1')
-			->willReturn($cloudId);
-
-		$this->calDavSyncService->expects(self::once())
-			->method('syncRemoteCalendar')
-			->with(
-				'https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2',
-				'dXNlcjFAbmV4dGNsb3VkLnRlc3Rpbmc=',
-				'token',
-				'http://sabre.io/ns/sync/100',
-				$calendar,
-			)
-			->willReturn(new SyncServiceResult($syncToken, 10));
-
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('updateSyncTokenAndTime');
-		$this->federatedCalendarMapper->expects(self::never())
-			->method('updateSyncTime');
-
-		$this->assertEquals(0, $this->federatedCalendarSyncService->syncOne($calendar));
-	}
+    private FederatedCalendarSyncService $federatedCalendarSyncService;
+
+    private FederatedCalendarMapper&MockObject $federatedCalendarMapper;
+    private LoggerInterface&MockObject $logger;
+    private CalDavSyncService&MockObject $calDavSyncService;
+    private ICloudIdManager&MockObject $cloudIdManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->federatedCalendarMapper = $this->createMock(FederatedCalendarMapper::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->calDavSyncService = $this->createMock(CalDavSyncService::class);
+        $this->cloudIdManager = $this->createMock(ICloudIdManager::class);
+
+        $this->federatedCalendarSyncService = new FederatedCalendarSyncService(
+            $this->federatedCalendarMapper,
+            $this->logger,
+            $this->calDavSyncService,
+            $this->cloudIdManager,
+        );
+    }
+
+    public function testSyncOne(): void {
+        $calendar = new FederatedCalendarEntity();
+        $calendar->setId(1);
+        $calendar->setPrincipaluri('principals/users/user1');
+        $calendar->setRemoteUrl('https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2');
+        $calendar->setSyncToken(100);
+        $calendar->setToken('token');
+
+        $cloudId = $this->createMock(ICloudId::class);
+        $cloudId->method('getId')
+            ->willReturn('user1@nextcloud.testing');
+        $this->cloudIdManager->expects(self::once())
+            ->method('getCloudId')
+            ->with('user1')
+            ->willReturn($cloudId);
+
+        $this->calDavSyncService->expects(self::once())
+            ->method('syncRemoteCalendar')
+            ->with(
+                'https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2',
+                'dXNlcjFAbmV4dGNsb3VkLnRlc3Rpbmc=',
+                'token',
+                'http://sabre.io/ns/sync/100',
+                $calendar,
+            )
+            ->willReturn(new SyncServiceResult('http://sabre.io/ns/sync/101', 10));
+
+        $this->federatedCalendarMapper->expects(self::once())
+            ->method('updateSyncTokenAndTime')
+            ->with(1, 101);
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('updateSyncTime');
+
+        $this->assertEquals(10, $this->federatedCalendarSyncService->syncOne($calendar));
+    }
+
+    public function testSyncOneUnchanged(): void {
+        $calendar = new FederatedCalendarEntity();
+        $calendar->setId(1);
+        $calendar->setPrincipaluri('principals/users/user1');
+        $calendar->setRemoteUrl('https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2');
+        $calendar->setSyncToken(100);
+        $calendar->setToken('token');
+
+        $cloudId = $this->createMock(ICloudId::class);
+        $cloudId->method('getId')
+            ->willReturn('user1@nextcloud.testing');
+        $this->cloudIdManager->expects(self::once())
+            ->method('getCloudId')
+            ->with('user1')
+            ->willReturn($cloudId);
+
+        $this->calDavSyncService->expects(self::once())
+            ->method('syncRemoteCalendar')
+            ->with(
+                'https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2',
+                'dXNlcjFAbmV4dGNsb3VkLnRlc3Rpbmc=',
+                'token',
+                'http://sabre.io/ns/sync/100',
+                $calendar,
+            )
+            ->willReturn(new SyncServiceResult('http://sabre.io/ns/sync/100', 0));
+
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('updateSyncTokenAndTime');
+        $this->federatedCalendarMapper->expects(self::once())
+            ->method('updateSyncTime')
+            ->with(1);
+
+        $this->assertEquals(0, $this->federatedCalendarSyncService->syncOne($calendar));
+    }
+
+    public static function provideUnexpectedSyncTokenData(): array {
+        return [
+            ['http://sabre.io/ns/sync/'],
+            ['http://sabre.io/ns/sync/foobar'],
+            ['http://sabre.io/ns/sync/23abc'],
+            ['http://nextcloud.com/ns/sync/33'],
+        ];
+    }
+
+    #[DataProvider('provideUnexpectedSyncTokenData')]
+    public function testSyncOneWithUnexpectedSyncTokenFormat(string $syncToken): void {
+        $calendar = new FederatedCalendarEntity();
+        $calendar->setId(1);
+        $calendar->setPrincipaluri('principals/users/user1');
+        $calendar->setRemoteUrl('https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2');
+        $calendar->setSyncToken(100);
+        $calendar->setToken('token');
+
+        $cloudId = $this->createMock(ICloudId::class);
+        $cloudId->method('getId')
+            ->willReturn('user1@nextcloud.testing');
+        $this->cloudIdManager->expects(self::once())
+            ->method('getCloudId')
+            ->with('user1')
+            ->willReturn($cloudId);
+
+        $this->calDavSyncService->expects(self::once())
+            ->method('syncRemoteCalendar')
+            ->with(
+                'https://remote.tld/remote.php/dav/remote-calendars/abcdef123/cal1_shared_by_user2',
+                'dXNlcjFAbmV4dGNsb3VkLnRlc3Rpbmc=',
+                'token',
+                'http://sabre.io/ns/sync/100',
+                $calendar,
+            )
+            ->willReturn(new SyncServiceResult($syncToken, 10));
+
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('updateSyncTokenAndTime');
+        $this->federatedCalendarMapper->expects(self::never())
+            ->method('updateSyncTime');
+
+        $this->assertEquals(0, $this->federatedCalendarSyncService->syncOne($calendar));
+    }
 }