Application::__construct() - Code Metrics - Inspection of "Merge pull request #186 from nextcloud/master-sync..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b4df57...e6895c )

by Lukas

created 2016-06-21 09:43 UTC

Application::__construct() B

↳ Parent: Application

Complexity

Conditions	1
Paths	1

Size

Total Lines	81
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	46
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	81
rs	8.8076

How to fix Long Method

<?php
/**
 * @author Björn Schießle <[email protected]>
 * @author Joas Schilling <[email protected]>
 * @author Thomas Müller <[email protected]>
 *
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */
namespace OCA\DAV\AppInfo;

use OCA\DAV\CalDAV\BirthdayService;
use OCA\DAV\CalDAV\CalDavBackend;
use OCA\DAV\CardDAV\CardDavBackend;
use OCA\DAV\CardDAV\ContactsManager;
use OCA\DAV\CardDAV\SyncJob;
use OCA\DAV\CardDAV\SyncService;
use OCA\DAV\Connector\Sabre\Principal;
use OCA\DAV\DAV\GroupPrincipalBackend;
use OCA\DAV\HookManager;
use OCA\DAV\Migration\Classification;
use OCA\DAV\Migration\GenerateBirthdays;
use \OCP\AppFramework\App;
use OCP\AppFramework\IAppContainer;
use OCP\Contacts\IManager;
use OCP\IUser;
use Sabre\VObject\Reader;
use Symfony\Component\EventDispatcher\GenericEvent;

class Application extends App {

	/**
	 * Application constructor.
	 *
	 * @param array $urlParams
	 */
	public function __construct (array $urlParams=array()) {
		parent::__construct('dav', $urlParams);

		$container = $this->getContainer();
		$container->registerService('ContactsManager', function($c) {
			/** @var IAppContainer $c */
			return new ContactsManager(
				$c->query('CardDavBackend')
			);
		});

		$container->registerService('HookManager', function($c) {
			/** @var IAppContainer $c */
			return new HookManager(
				$c->getServer()->getUserManager(),
				$c->query('SyncService'),
				$c->query('CalDavBackend'),
				$c->query('CardDavBackend')
			);
		});

		$container->registerService('SyncService', function($c) {
			/** @var IAppContainer $c */
			return new SyncService(
				$c->query('CardDavBackend'),
				$c->getServer()->getUserManager(),
				$c->getServer()->getLogger()
			);
		});

		$container->registerService('CardDavBackend', function($c) {
			/** @var IAppContainer $c */
			$db = $c->getServer()->getDatabaseConnection();
			$dispatcher = $c->getServer()->getEventDispatcher();
			$principal = new Principal(
				$c->getServer()->getUserManager(),
				$c->getServer()->getGroupManager()
			);
			return new CardDavBackend($db, $principal, $dispatcher);
		});

		$container->registerService('CalDavBackend', function($c) {
			/** @var IAppContainer $c */
			$db = $c->getServer()->getDatabaseConnection();
			$principal = new Principal(
				$c->getServer()->getUserManager(),
				$c->getServer()->getGroupManager()
			);
			return new CalDavBackend($db, $principal);
		});

		$container->registerService('BirthdayService', function($c) {
			/** @var IAppContainer $c */
			$g = new GroupPrincipalBackend(
				$c->getServer()->getGroupManager()
			);
			return new BirthdayService(
				$c->query('CalDavBackend'),
				$c->query('CardDavBackend'),
				$g
			);
		});

		$container->registerService('OCA\DAV\Migration\Classification', function ($c) {
			/** @var IAppContainer $c */
			return new Classification(
				$c->query('CalDavBackend'),
				$c->getServer()->getUserManager()
			);
		});

		$container->registerService('OCA\DAV\Migration\GenerateBirthdays', function ($c) {
			/** @var IAppContainer $c */
			/** @var BirthdayService $b */
			$b = $c->query('BirthdayService');
			return new GenerateBirthdays(
				$b,
				$c->getServer()->getUserManager()
			);
		});
	}

	/**
	 * @param IManager $contactsManager
	 * @param string $userID
	 */
	public function setupContactsProvider(IManager $contactsManager, $userID) {
		/** @var ContactsManager $cm */
		$cm = $this->getContainer()->query('ContactsManager');
		$cm->setupContactsProvider($contactsManager, $userID);
	}

	public function registerHooks() {
		/** @var HookManager $hm */
		$hm = $this->getContainer()->query('HookManager');
		$hm->setup();

		$listener = function($event) {

			if ($event instanceof GenericEvent) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
				/** @var BirthdayService $b */
				$b = $this->getContainer()->query('BirthdayService');
				$b->onCardChanged(
					$event->getArgument('addressBookId'),
					$event->getArgument('cardUri'),
					$event->getArgument('cardData')
				);
			}
		};

		$dispatcher = $this->getContainer()->getServer()->getEventDispatcher();
		$dispatcher->addListener('\OCA\DAV\CardDAV\CardDavBackend::createCard', $listener);
		$dispatcher->addListener('\OCA\DAV\CardDAV\CardDavBackend::updateCard', $listener);
		$dispatcher->addListener('\OCA\DAV\CardDAV\CardDavBackend::deleteCard', function($event) {

			if ($event instanceof GenericEvent) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
				/** @var BirthdayService $b */
				$b = $this->getContainer()->query('BirthdayService');
				$b->onCardDeleted(
					$event->getArgument('addressBookId'),
					$event->getArgument('cardUri')
				);
			}
		});
	}

	public function getSyncService() {
		return $this->getContainer()->query('SyncService');
	}

}


Push — master ( b4df57...e6895c )

Application::__construct() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1		<?php
2		/**
3		* @author Björn Schießle <[email protected]>
4		* @author Joas Schilling <[email protected]>
5		* @author Thomas Müller <[email protected]>
6		*
7		* @copyright Copyright (c) 2016, ownCloud, Inc.
8		* @license AGPL-3.0
9		*
10		* This code is free software: you can redistribute it and/or modify
11		* it under the terms of the GNU Affero General Public License, version 3,
12		* as published by the Free Software Foundation.
13		*
14		* This program is distributed in the hope that it will be useful,
15		* but WITHOUT ANY WARRANTY; without even the implied warranty of
16		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17		* GNU Affero General Public License for more details.
18		*
19		* You should have received a copy of the GNU Affero General Public License, version 3,
20		* along with this program. If not, see <http://www.gnu.org/licenses/>
21		*
22		*/
23		namespace OCA\DAV\AppInfo;
24
25		use OCA\DAV\CalDAV\BirthdayService;
26		use OCA\DAV\CalDAV\CalDavBackend;
27		use OCA\DAV\CardDAV\CardDavBackend;
28		use OCA\DAV\CardDAV\ContactsManager;
29		use OCA\DAV\CardDAV\SyncJob;
30		use OCA\DAV\CardDAV\SyncService;
31		use OCA\DAV\Connector\Sabre\Principal;
32		use OCA\DAV\DAV\GroupPrincipalBackend;
33		use OCA\DAV\HookManager;
34		use OCA\DAV\Migration\Classification;
35		use OCA\DAV\Migration\GenerateBirthdays;
36		use \OCP\AppFramework\App;
37		use OCP\AppFramework\IAppContainer;
38		use OCP\Contacts\IManager;
39		use OCP\IUser;
40		use Sabre\VObject\Reader;
41		use Symfony\Component\EventDispatcher\GenericEvent;
42
43		class Application extends App {
44
45		/**
46		* Application constructor.
47		*
48		* @param array $urlParams
49		*/
50		public function __construct (array $urlParams=array()) {
51		parent::__construct('dav', $urlParams);
52
53		$container = $this->getContainer();
54		$container->registerService('ContactsManager', function($c) {
55		/** @var IAppContainer $c */
56		return new ContactsManager(
57		$c->query('CardDavBackend')
58		);
59		});
60
61		$container->registerService('HookManager', function($c) {
62		/** @var IAppContainer $c */
63		return new HookManager(
64		$c->getServer()->getUserManager(),
65		$c->query('SyncService'),
66		$c->query('CalDavBackend'),
67		$c->query('CardDavBackend')
68		);
69		});
70
71		$container->registerService('SyncService', function($c) {
72		/** @var IAppContainer $c */
73		return new SyncService(
74		$c->query('CardDavBackend'),
75		$c->getServer()->getUserManager(),
76		$c->getServer()->getLogger()
77		);
78		});
79
80		$container->registerService('CardDavBackend', function($c) {
81		/** @var IAppContainer $c */
82		$db = $c->getServer()->getDatabaseConnection();
83		$dispatcher = $c->getServer()->getEventDispatcher();
84		$principal = new Principal(
85		$c->getServer()->getUserManager(),
86		$c->getServer()->getGroupManager()
87		);
88		return new CardDavBackend($db, $principal, $dispatcher);
89		});
90
91		$container->registerService('CalDavBackend', function($c) {
92		/** @var IAppContainer $c */
93		$db = $c->getServer()->getDatabaseConnection();
94		$principal = new Principal(
95		$c->getServer()->getUserManager(),
96		$c->getServer()->getGroupManager()
97		);
98		return new CalDavBackend($db, $principal);
99		});
100
101		$container->registerService('BirthdayService', function($c) {
102		/** @var IAppContainer $c */
103		$g = new GroupPrincipalBackend(
104		$c->getServer()->getGroupManager()
105		);
106		return new BirthdayService(
107		$c->query('CalDavBackend'),
108		$c->query('CardDavBackend'),
109		$g
110		);
111		});
112
113		$container->registerService('OCA\DAV\Migration\Classification', function ($c) {
114		/** @var IAppContainer $c */
115		return new Classification(
116		$c->query('CalDavBackend'),
117		$c->getServer()->getUserManager()
118		);
119		});
120
121		$container->registerService('OCA\DAV\Migration\GenerateBirthdays', function ($c) {
122		/** @var IAppContainer $c */
123		/** @var BirthdayService $b */
124		$b = $c->query('BirthdayService');
125		return new GenerateBirthdays(
126		$b,
127		$c->getServer()->getUserManager()
128		);
129		});
130		}
131
132		/**
133		* @param IManager $contactsManager
134		* @param string $userID
135		*/
136		public function setupContactsProvider(IManager $contactsManager, $userID) {
137		/** @var ContactsManager $cm */
138		$cm = $this->getContainer()->query('ContactsManager');
139		$cm->setupContactsProvider($contactsManager, $userID);
140		}
141
142		public function registerHooks() {
143		/** @var HookManager $hm */
144		$hm = $this->getContainer()->query('HookManager');
145		$hm->setup();
146
147	View Code Duplication	$listener = function($event) {
		0 ignored issues – show Duplication introduced 2016-06-09 12:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
148		if ($event instanceof GenericEvent) {
		0 ignored issues – show Bug introduced 2016-06-09 12:21 UTC by Report Bug Copy Issue Report The class `Symfony\Component\EventDispatcher\GenericEvent` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
149		/** @var BirthdayService $b */
150		$b = $this->getContainer()->query('BirthdayService');
151		$b->onCardChanged(
152		$event->getArgument('addressBookId'),
153		$event->getArgument('cardUri'),
154		$event->getArgument('cardData')
155		);
156		}
157		};
158
159		$dispatcher = $this->getContainer()->getServer()->getEventDispatcher();
160		$dispatcher->addListener('\OCA\DAV\CardDAV\CardDavBackend::createCard', $listener);
161		$dispatcher->addListener('\OCA\DAV\CardDAV\CardDavBackend::updateCard', $listener);
162	View Code Duplication	$dispatcher->addListener('\OCA\DAV\CardDAV\CardDavBackend::deleteCard', function($event) {
		0 ignored issues – show Duplication introduced 2016-06-09 12:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
163		if ($event instanceof GenericEvent) {
		0 ignored issues – show Bug introduced 2016-06-09 12:21 UTC by Report Bug Copy Issue Report The class `Symfony\Component\EventDispatcher\GenericEvent` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
164		/** @var BirthdayService $b */
165		$b = $this->getContainer()->query('BirthdayService');
166		$b->onCardDeleted(
167		$event->getArgument('addressBookId'),
168		$event->getArgument('cardUri')
169		);
170		}
171		});
172		}
173
174		public function getSyncService() {
175		return $this->getContainer()->query('SyncService');
176		}
177
178		}
179

nextcloud / server

Push — master ( b4df57...e6895c )

Application::__construct() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like