Completed
Pull Request — master (#6805)
by Björn
41:55 queued 02:44
created
apps/user_ldap/lib/Helper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -126,6 +126,9 @@
 block discarded – undo
126 126
 		return 's' . str_pad($lastNumber + 1, 2, '0', STR_PAD_LEFT);
127 127
 	}
128 128
 
129
+	/**
130
+	 * @param string $value
131
+	 */
129 132
 	private function getServersConfig($value) {
130 133
 		$regex = '/' . $value . '$/S';
131 134
 
Please login to merge, or discard this patch.
apps/files/lib/Activity/Provider.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -112,6 +112,9 @@  discard block
 block discarded – undo
112 112
 		return $this->parseLongVersion($event, $previousEvent);
113 113
 	}
114 114
 
115
+	/**
116
+	 * @param string $icon
117
+	 */
115 118
 	protected function setIcon(IEvent $event, $icon) {
116 119
 		if ($this->activityManager->getRequirePNG()) {
117 120
 			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', $icon . '.png')));
@@ -252,6 +255,9 @@  discard block
 block discarded – undo
252 255
 		return $event;
253 256
 	}
254 257
 
258
+	/**
259
+	 * @param string $subject
260
+	 */
255 261
 	protected function setSubjects(IEvent $event, $subject, array $parameters) {
256 262
 		$placeholders = $replacements = [];
257 263
 		foreach ($parameters as $placeholder => $parameter) {
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/Swift.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
 	/**
85 85
 	 * @param string $path
86
-	 * @return mixed|string
86
+	 * @return string
87 87
 	 */
88 88
 	private function normalizePath(string $path) {
89 89
 		$path = trim($path, '/');
@@ -570,6 +570,9 @@  discard block
 block discarded – undo
570 570
 		return $this->container;
571 571
 	}
572 572
 
573
+	/**
574
+	 * @param string $path
575
+	 */
573 576
 	public function writeBack($tmpFile, $path) {
574 577
 		$fileData = fopen($tmpFile, 'r');
575 578
 		$this->objectStore->writeObject($path, $fileData);
Please login to merge, or discard this patch.
lib/public/Mail/IEMailTemplate.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -61,6 +61,7 @@  discard block
 block discarded – undo
61 61
 	 * @param string $subject
62 62
 	 *
63 63
 	 * @since 13.0.0
64
+	 * @return void
64 65
 	 */
65 66
 	public function setSubject($subject);
66 67
 
@@ -68,6 +69,7 @@  discard block
 block discarded – undo
68 69
 	 * Adds a header to the email
69 70
 	 *
70 71
 	 * @since 12.0.0
72
+	 * @return void
71 73
 	 */
72 74
 	public function addHeader();
73 75
 
@@ -79,6 +81,7 @@  discard block
 block discarded – undo
79 81
 	 *   if empty the $title is used, if false none will be used
80 82
 	 *
81 83
 	 * @since 12.0.0
84
+	 * @return void
82 85
 	 */
83 86
 	public function addHeading($title, $plainTitle = '');
84 87
 
@@ -88,8 +91,10 @@  discard block
 block discarded – undo
88 91
 	 * @param string $text; Note: When $plainText falls back to this, HTML is automatically escaped in the HTML email
89 92
 	 * @param string|bool $plainText Text that is used in the plain text email
90 93
 	 *   if empty the $text is used, if false none will be used
94
+	 * @param string $text
91 95
 	 *
92 96
 	 * @since 12.0.0
97
+	 * @return void
93 98
 	 */
94 99
 	public function addBodyText($text, $plainText = '');
95 100
 
@@ -103,7 +108,9 @@  discard block
 block discarded – undo
103 108
 	 *   if empty the $text is used, if false none will be used
104 109
 	 * @param string $plainMetaInfo Meta info that is used in the plain text email
105 110
 	 *   if empty the $metaInfo is used, if false none will be used
111
+	 * @param string $text
106 112
 	 * @since 12.0.0
113
+	 * @return void
107 114
 	 */
108 115
 	public function addBodyListItem($text, $metaInfo = '', $icon = '', $plainText = '', $plainMetaInfo = '');
109 116
 
@@ -118,6 +125,7 @@  discard block
 block discarded – undo
118 125
 	 * @param string $plainTextRight Text of right button that is used in the plain text version - if empty the $textRight is used
119 126
 	 *
120 127
 	 * @since 12.0.0
128
+	 * @return void
121 129
 	 */
122 130
 	public function addBodyButtonGroup($textLeft, $urlLeft, $textRight, $urlRight, $plainTextLeft = '', $plainTextRight = '');
123 131
 
@@ -130,6 +138,7 @@  discard block
 block discarded – undo
130 138
 	 * 		if empty the $text is used, if false none will be used
131 139
 	 *
132 140
 	 * @since 12.0.0
141
+	 * @return void
133 142
 	 */
134 143
 	public function addBodyButton($text, $url, $plainText = '');
135 144
 
@@ -139,6 +148,7 @@  discard block
 block discarded – undo
139 148
 	 * @param string $text If the text is empty the default "Name - Slogan<br>This is an automatically sent email" will be used
140 149
 	 *
141 150
 	 * @since 12.0.0
151
+	 * @return void
142 152
 	 */
143 153
 	public function addFooter($text = '');
144 154
 
Please login to merge, or discard this patch.
lib/private/legacy/app.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@
 block discarded – undo
269 269
 	 * check if an app is of a specific type
270 270
 	 *
271 271
 	 * @param string $app
272
-	 * @param array $types
272
+	 * @param string[] $types
273 273
 	 * @return bool
274 274
 	 */
275 275
 	public static function isType(string $app, array $types): bool {
Please login to merge, or discard this patch.
lib/private/AppFramework/Utility/ControllerMethodReflector.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 	private $parameters = [];
41 41
 
42 42
 	/**
43
-	 * @param object $object an object or classname
43
+	 * @param \OCP\AppFramework\Controller $object an object or classname
44 44
 	 * @param string $method the method which we want to inspect
45 45
 	 */
46 46
 	public function reflect($object, string $method){
Please login to merge, or discard this patch.
lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
 	 * @param bool $isLoggedIn
102 102
 	 * @param bool $isAdminUser
103 103
 	 * @param ContentSecurityPolicyManager $contentSecurityPolicyManager
104
-	 * @param CSRFTokenManager $csrfTokenManager
104
+	 * @param CsrfTokenManager $csrfTokenManager
105 105
 	 * @param ContentSecurityPolicyNonceManager $cspNonceManager
106 106
 	 * @param IAppManager $appManager
107 107
 	 * @param IL10N $l10n
Please login to merge, or discard this patch.
lib/private/Session/Internal.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -166,7 +166,7 @@
 block discarded – undo
166 166
 	 * @param array $parameters
167 167
 	 * @param bool $silence whether to suppress warnings
168 168
 	 * @throws \ErrorException via trapError
169
-	 * @return mixed
169
+	 * @return string
170 170
 	 */
171 171
 	private function invoke(string $functionName, array $parameters = [], bool $silence = false) {
172 172
 		try {
Please login to merge, or discard this patch.