Passed
Push — master ( b794fa...797527 )
by Christoph
82:28 queued 66:03
created
lib/private/Files/Config/CachedMountFileInfo.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,6 +43,6 @@
 block discarded – undo
43 43
 	}
44 44
 
45 45
 	public function getPath() {
46
-		return $this->getMountPoint() . $this->getInternalPath();
46
+		return $this->getMountPoint().$this->getInternalPath();
47 47
 	}
48 48
 }
Please login to merge, or discard this patch.
core/Command/Group/Add.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 		$gid = $input->getArgument('groupid');
66 66
 		$group = $this->groupManager->get($gid);
67 67
 		if ($group) {
68
-			$output->writeln('<error>Group "' . $gid . '" already exists.</error>');
68
+			$output->writeln('<error>Group "'.$gid.'" already exists.</error>');
69 69
 			return 1;
70 70
 		} else {
71 71
 			$group = $this->groupManager->createGroup($gid);
@@ -73,9 +73,9 @@  discard block
 block discarded – undo
73 73
 				$output->writeln('<error>Could not create group</error>');
74 74
 				return 2;
75 75
 			}
76
-			$output->writeln('Created group "' . $group->getGID() . '"');
76
+			$output->writeln('Created group "'.$group->getGID().'"');
77 77
 
78
-			$displayName = trim((string)$input->getOption('display-name'));
78
+			$displayName = trim((string) $input->getOption('display-name'));
79 79
 			if ($displayName !== '') {
80 80
 				$group->setDisplayName($displayName);
81 81
 			}
Please login to merge, or discard this patch.
apps/files/lib/BackgroundJob/TransferOwnership.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 		$destinationUserObject = $this->userManager->get($destinationUser);
99 99
 
100 100
 		if (!$sourceUserObject instanceof IUser) {
101
-			$this->logger->alert('Could not transfer ownership: Unknown source user ' . $sourceUser);
101
+			$this->logger->alert('Could not transfer ownership: Unknown source user '.$sourceUser);
102 102
 			$this->failedNotication($transfer);
103 103
 			return;
104 104
 		}
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 				'targetUser' => $transfer->getTargetUser(),
137 137
 				'nodeName' => $transfer->getNodeName(),
138 138
 			])
139
-			->setObject('transfer', (string)$transfer->getId());
139
+			->setObject('transfer', (string) $transfer->getId());
140 140
 		$this->notificationManager->notify($notification);
141 141
 
142 142
 		// Send notification to source user
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 				'targetUser' => $transfer->getTargetUser(),
150 150
 				'nodeName' => $transfer->getNodeName(),
151 151
 			])
152
-			->setObject('transfer', (string)$transfer->getId());
152
+			->setObject('transfer', (string) $transfer->getId());
153 153
 		$this->notificationManager->notify($notification);
154 154
 	}
155 155
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 				'targetUser' => $transfer->getTargetUser(),
165 165
 				'nodeName' => $transfer->getNodeName(),
166 166
 			])
167
-			->setObject('transfer', (string)$transfer->getId());
167
+			->setObject('transfer', (string) $transfer->getId());
168 168
 		$this->notificationManager->notify($notification);
169 169
 
170 170
 		// Send notification to source user
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 				'targetUser' => $transfer->getTargetUser(),
178 178
 				'nodeName' => $transfer->getNodeName(),
179 179
 			])
180
-			->setObject('transfer', (string)$transfer->getId());
180
+			->setObject('transfer', (string) $transfer->getId());
181 181
 		$this->notificationManager->notify($notification);
182 182
 	}
183 183
 }
Please login to merge, or discard this patch.
lib/private/Collaboration/Resources/ProviderManager.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 					$this->providerInstances[] = $this->serverContainer->query($provider);
55 55
 				} catch (QueryException $e) {
56 56
 					$this->logger->logException($e, [
57
-						'message' => "Could not query resource provider $provider: " . $e->getMessage()
57
+						'message' => "Could not query resource provider $provider: ".$e->getMessage()
58 58
 					]);
59 59
 				}
60 60
 			}
Please login to merge, or discard this patch.
apps/comments/lib/Search/Result.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
 			$suffix = '…';
106 106
 		}
107 107
 
108
-		return $prefix . mb_substr($message, $start, $end - $start) . $suffix;
108
+		return $prefix.mb_substr($message, $start, $end - $start).$suffix;
109 109
 	}
110 110
 
111 111
 }
Please login to merge, or discard this patch.
apps/files/lib/Notification/Notifier.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 				$this->urlGenerator->getAbsoluteURL(
121 121
 					$this->urlGenerator->linkTo(
122 122
 						'',
123
-						'ocs/v2.php/apps/files/api/v1/transferownership/' . $id
123
+						'ocs/v2.php/apps/files/api/v1/transferownership/'.$id
124 124
 					)
125 125
 				),
126 126
 				IAction::TYPE_POST
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 				$this->urlGenerator->getAbsoluteURL(
134 134
 					$this->urlGenerator->linkTo(
135 135
 						'',
136
-						'ocs/v2.php/apps/files/api/v1/transferownership/' . $id
136
+						'ocs/v2.php/apps/files/api/v1/transferownership/'.$id
137 137
 					)
138 138
 				),
139 139
 				IAction::TYPE_DELETE
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 				[
157 157
 					'path' => [
158 158
 						'type' => 'highlight',
159
-						'id' => $param['targetUser'] . '::' . $param['nodeName'],
159
+						'id' => $param['targetUser'].'::'.$param['nodeName'],
160 160
 						'name' => $param['nodeName'],
161 161
 					]
162 162
 				])
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 		return $notification;
166 166
 	}
167 167
 
168
-	public function handleTransferOwnershipFailedSource(INotification $notification,  string $languageCode): INotification {
168
+	public function handleTransferOwnershipFailedSource(INotification $notification, string $languageCode): INotification {
169 169
 		$l = $this->l10nFactory->get('files', $languageCode);
170 170
 		$param = $notification->getSubjectParameters();
171 171
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 				[
178 178
 					'path' => [
179 179
 						'type' => 'highlight',
180
-						'id' => $param['targetUser'] . '::' . $param['nodeName'],
180
+						'id' => $param['targetUser'].'::'.$param['nodeName'],
181 181
 						'name' => $param['nodeName'],
182 182
 					],
183 183
 					'user' => [
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 		return $notification;
191 191
 	}
192 192
 
193
-	public function handleTransferOwnershipFailedTarget(INotification $notification,  string $languageCode): INotification {
193
+	public function handleTransferOwnershipFailedTarget(INotification $notification, string $languageCode): INotification {
194 194
 		$l = $this->l10nFactory->get('files', $languageCode);
195 195
 		$param = $notification->getSubjectParameters();
196 196
 
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 				[
203 203
 					'path' => [
204 204
 						'type' => 'highlight',
205
-						'id' => $param['sourceUser'] . '::' . $param['nodeName'],
205
+						'id' => $param['sourceUser'].'::'.$param['nodeName'],
206 206
 						'name' => $param['nodeName'],
207 207
 					],
208 208
 					'user' => [
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 		return $notification;
217 217
 	}
218 218
 
219
-	public function handleTransferOwnershipDoneSource(INotification $notification,  string $languageCode): INotification {
219
+	public function handleTransferOwnershipDoneSource(INotification $notification, string $languageCode): INotification {
220 220
 		$l = $this->l10nFactory->get('files', $languageCode);
221 221
 		$param = $notification->getSubjectParameters();
222 222
 
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
 				[
229 229
 					'path' => [
230 230
 						'type' => 'highlight',
231
-						'id' => $param['targetUser'] . '::' . $param['nodeName'],
231
+						'id' => $param['targetUser'].'::'.$param['nodeName'],
232 232
 						'name' => $param['nodeName'],
233 233
 					],
234 234
 					'user' => [
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 		return $notification;
243 243
 	}
244 244
 
245
-	public function handleTransferOwnershipDoneTarget(INotification $notification,  string $languageCode): INotification {
245
+	public function handleTransferOwnershipDoneTarget(INotification $notification, string $languageCode): INotification {
246 246
 		$l = $this->l10nFactory->get('files', $languageCode);
247 247
 		$param = $notification->getSubjectParameters();
248 248
 
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 				[
255 255
 					'path' => [
256 256
 						'type' => 'highlight',
257
-						'id' => $param['sourceUser'] . '::' . $param['nodeName'],
257
+						'id' => $param['sourceUser'].'::'.$param['nodeName'],
258 258
 						'name' => $param['nodeName'],
259 259
 					],
260 260
 					'user' => [
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
 
276 276
 		// TODO: This should all be moved to a service that also the transferownershipContoller uses.
277 277
 		try {
278
-			$transferOwnership = $this->mapper->getById((int)$notification->getObjectId());
278
+			$transferOwnership = $this->mapper->getById((int) $notification->getObjectId());
279 279
 		} catch (DoesNotExistException $e) {
280 280
 			return;
281 281
 		}
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
289 289
 				'targetUser' => $transferOwnership->getTargetUser(),
290 290
 				'nodeName' => $transferOwnership->getNodeName()
291 291
 			])
292
-			->setObject('transfer', (string)$transferOwnership->getId());
292
+			->setObject('transfer', (string) $transferOwnership->getId());
293 293
 		$this->notificationManager->notify($notification);
294 294
 
295 295
 		$this->mapper->delete($transferOwnership);
Please login to merge, or discard this patch.
lib/private/Preview/Office.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -49,20 +49,20 @@
 block discarded – undo
49 49
 
50 50
 		$tmpDir = \OC::$server->getTempManager()->getTempBaseDir();
51 51
 
52
-		$defaultParameters = ' -env:UserInstallation=file://' . escapeshellarg($tmpDir . '/owncloud-' . \OC_Util::getInstanceId() . '/') . ' --headless --nologo --nofirststartwizard --invisible --norestore --convert-to png --outdir ';
52
+		$defaultParameters = ' -env:UserInstallation=file://'.escapeshellarg($tmpDir.'/owncloud-'.\OC_Util::getInstanceId().'/').' --headless --nologo --nofirststartwizard --invisible --norestore --convert-to png --outdir ';
53 53
 		$clParameters = \OC::$server->getConfig()->getSystemValue('preview_office_cl_parameters', $defaultParameters);
54 54
 
55
-		$exec = $this->cmd . $clParameters . escapeshellarg($tmpDir) . ' ' . escapeshellarg($absPath);
55
+		$exec = $this->cmd.$clParameters.escapeshellarg($tmpDir).' '.escapeshellarg($absPath);
56 56
 
57 57
 		shell_exec($exec);
58 58
 
59 59
 		//create imagick object from png
60 60
 		$pngPreview = null;
61 61
 		try {
62
-			list($dirname, , , $filename) = array_values(pathinfo($absPath));
63
-			$pngPreview = $tmpDir . '/' . $filename . '.png';
62
+			list($dirname,,, $filename) = array_values(pathinfo($absPath));
63
+			$pngPreview = $tmpDir.'/'.$filename.'.png';
64 64
 
65
-			$png = new \imagick($pngPreview . '[0]');
65
+			$png = new \imagick($pngPreview.'[0]');
66 66
 			$png->setImageFormat('jpg');
67 67
 		} catch (\Exception $e) {
68 68
 			$this->cleanTmpFiles();
Please login to merge, or discard this patch.
lib/public/AppFramework/Http/Template/ExternalShareMenuAction.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -66,16 +66,16 @@
 block discarded – undo
66 66
 	 * @since 14.0.0
67 67
 	 */
68 68
 	public function render(): string {
69
-		return '<li>' .
70
-			'    <button id="save-external-share" class="icon ' . Util::sanitizeHTML($this->getIcon()) . '" data-protected="false" data-owner-display-name="' . Util::sanitizeHTML($this->displayname) . '" data-owner="' . Util::sanitizeHTML($this->owner) . '" data-name="' . Util::sanitizeHTML($this->shareName) . '">' . Util::sanitizeHTML($this->getLabel()) . '</button>' .
71
-			'</li>' .
72
-			'<li id="external-share-menu-item" class="hidden">' .
73
-			'    <span class="menuitem">' .
74
-			'        <form class="save-form" action="#">' .
75
-			'            <input type="text" id="remote_address" placeholder="[email protected]">' .
76
-			'            <input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>' .
77
-			'        </form>' .
78
-			'    </span>' .
69
+		return '<li>'.
70
+			'    <button id="save-external-share" class="icon '.Util::sanitizeHTML($this->getIcon()).'" data-protected="false" data-owner-display-name="'.Util::sanitizeHTML($this->displayname).'" data-owner="'.Util::sanitizeHTML($this->owner).'" data-name="'.Util::sanitizeHTML($this->shareName).'">'.Util::sanitizeHTML($this->getLabel()).'</button>'.
71
+			'</li>'.
72
+			'<li id="external-share-menu-item" class="hidden">'.
73
+			'    <span class="menuitem">'.
74
+			'        <form class="save-form" action="#">'.
75
+			'            <input type="text" id="remote_address" placeholder="[email protected]">'.
76
+			'            <input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>'.
77
+			'        </form>'.
78
+			'    </span>'.
79 79
 			'</li>';
80 80
 	}
81 81
 }
Please login to merge, or discard this patch.
apps/workflowengine/lib/Check/FileMimeType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@
 block discarded – undo
155 155
 	}
156 156
 
157 157
 	public function supportedEntities(): array {
158
-		return [ File::class ];
158
+		return [File::class];
159 159
 	}
160 160
 
161 161
 	public function isAvailableForScope(int $scope): bool {
Please login to merge, or discard this patch.