Passed
Push — master ( 581704...2efa00 )
by Roeland
11:12 queued 11s
created
apps/settings/templates/settings/admin/sharing.php 1 patch
Braces   +120 added lines, -30 removed lines patch added patch discarded remove patch
@@ -34,97 +34,181 @@  discard block
 block discarded – undo
34 34
         <p class="settings-hint"><?php p($l->t('As admin you can fine-tune the sharing behavior. Please see the documentation for more information.'));?></p>
35 35
 	<p id="enable">
36 36
 		<input type="checkbox" name="shareapi_enabled" id="shareAPIEnabled" class="checkbox"
37
-			   value="1" <?php if ($_['shareAPIEnabled'] === 'yes') print_unescaped('checked="checked"'); ?> />
37
+			   value="1" <?php if ($_['shareAPIEnabled'] === 'yes') {
38
+    print_unescaped('checked="checked"');
39
+}
40
+?> />
38 41
 		<label for="shareAPIEnabled"><?php p($l->t('Allow apps to use the Share API'));?></label><br/>
39 42
 	</p>
40 43
 
41
-	<p id="internalShareSettings" class="indent <?php if ($_['shareAPIEnabled'] === 'no') p('hidden'); ?>">
44
+	<p id="internalShareSettings" class="indent <?php if ($_['shareAPIEnabled'] === 'no') {
45
+    p('hidden');
46
+}
47
+?>">
42 48
 		<input type="checkbox" name="shareapi_default_internal_expire_date" id="shareapiDefaultInternalExpireDate" class="checkbox"
43
-			   value="1" <?php if ($_['shareDefaultInternalExpireDateSet'] === 'yes') print_unescaped('checked="checked"'); ?> />
49
+			   value="1" <?php if ($_['shareDefaultInternalExpireDateSet'] === 'yes') {
50
+    print_unescaped('checked="checked"');
51
+}
52
+?> />
44 53
 		<label for="shareapiDefaultInternalExpireDate"><?php p($l->t('Set default expiration date for shares'));?></label><br/>
45 54
 	</p>
46
-	<p id="setDefaultInternalExpireDate" class="double-indent <?php if ($_['shareDefaultInternalExpireDateSet'] === 'no' || $_['shareAPIEnabled'] === 'no') p('hidden');?>">
55
+	<p id="setDefaultInternalExpireDate" class="double-indent <?php if ($_['shareDefaultInternalExpireDateSet'] === 'no' || $_['shareAPIEnabled'] === 'no') {
56
+    p('hidden');
57
+}
58
+?>">
47 59
 		<?php p($l->t( 'Expire after ' )); ?>
48 60
 		<input type="text" name='shareapi_internal_expire_after_n_days' id="shareapiInternalExpireAfterNDays" placeholder="<?php p('7')?>"
49 61
 			   value='<?php p($_['shareInternalExpireAfterNDays']) ?>' />
50 62
 		<?php p($l->t( 'days' )); ?>
51 63
 		<input type="checkbox" name="shareapi_internal_enforce_expire_date" id="shareapiInternalEnforceExpireDate" class="checkbox"
52
-			   value="1" <?php if ($_['shareInternalEnforceExpireDate'] === 'yes') print_unescaped('checked="checked"'); ?> />
64
+			   value="1" <?php if ($_['shareInternalEnforceExpireDate'] === 'yes') {
65
+    print_unescaped('checked="checked"');
66
+}
67
+?> />
53 68
 		<label for="shareapiInternalEnforceExpireDate"><?php p($l->t('Enforce expiration date'));?></label><br/>
54 69
 	</p>
55 70
 
56
-	<p class="<?php if ($_['shareAPIEnabled'] === 'no') p('hidden');?>">
71
+	<p class="<?php if ($_['shareAPIEnabled'] === 'no') {
72
+    p('hidden');
73
+}
74
+?>">
57 75
 		<input type="checkbox" name="shareapi_allow_links" id="allowLinks" class="checkbox"
58
-			   value="1" <?php if ($_['allowLinks'] === 'yes') print_unescaped('checked="checked"'); ?> />
76
+			   value="1" <?php if ($_['allowLinks'] === 'yes') {
77
+    print_unescaped('checked="checked"');
78
+}
79
+?> />
59 80
 		<label for="allowLinks"><?php p($l->t('Allow users to share via link'));?></label><br/>
60 81
 	</p>
61 82
 
62
-	<p id="publicLinkSettings" class="indent <?php if ($_['allowLinks'] !== 'yes' || $_['shareAPIEnabled'] === 'no') p('hidden'); ?>">
83
+	<p id="publicLinkSettings" class="indent <?php if ($_['allowLinks'] !== 'yes' || $_['shareAPIEnabled'] === 'no') {
84
+    p('hidden');
85
+}
86
+?>">
63 87
 		<input type="checkbox" name="shareapi_allow_public_upload" id="allowPublicUpload" class="checkbox"
64
-			   value="1" <?php if ($_['allowPublicUpload'] == 'yes') print_unescaped('checked="checked"'); ?> />
88
+			   value="1" <?php if ($_['allowPublicUpload'] == 'yes') {
89
+    print_unescaped('checked="checked"');
90
+}
91
+?> />
65 92
 		<label for="allowPublicUpload"><?php p($l->t('Allow public uploads'));?></label><br/>
66 93
 		<input type="checkbox" name="shareapi_enable_link_password_by_default" id="enableLinkPasswordByDefault" class="checkbox"
67
-			   value="1" <?php if ($_['enableLinkPasswordByDefault'] === 'yes') print_unescaped('checked="checked"'); ?> />
94
+			   value="1" <?php if ($_['enableLinkPasswordByDefault'] === 'yes') {
95
+    print_unescaped('checked="checked"');
96
+}
97
+?> />
68 98
 		<label for="enableLinkPasswordByDefault"><?php p($l->t('Always ask for a password'));?></label><br/>
69 99
 		<input type="checkbox" name="shareapi_enforce_links_password" id="enforceLinkPassword" class="checkbox"
70
-			   value="1" <?php if ($_['enforceLinkPassword']) print_unescaped('checked="checked"'); ?> />
100
+			   value="1" <?php if ($_['enforceLinkPassword']) {
101
+    print_unescaped('checked="checked"');
102
+}
103
+?> />
71 104
 		<label for="enforceLinkPassword"><?php p($l->t('Enforce password protection'));?></label><br/>
72 105
 
73 106
 		<input type="checkbox" name="shareapi_default_expire_date" id="shareapiDefaultExpireDate" class="checkbox"
74
-			   value="1" <?php if ($_['shareDefaultExpireDateSet'] === 'yes') print_unescaped('checked="checked"'); ?> />
107
+			   value="1" <?php if ($_['shareDefaultExpireDateSet'] === 'yes') {
108
+    print_unescaped('checked="checked"');
109
+}
110
+?> />
75 111
 		<label for="shareapiDefaultExpireDate"><?php p($l->t('Set default expiration date for link shares'));?></label><br/>
76 112
 
77 113
 	</p>
78
-	<p id="setDefaultExpireDate" class="double-indent <?php if ($_['allowLinks'] !== 'yes' || $_['shareDefaultExpireDateSet'] === 'no' || $_['shareAPIEnabled'] === 'no') p('hidden');?>">
114
+	<p id="setDefaultExpireDate" class="double-indent <?php if ($_['allowLinks'] !== 'yes' || $_['shareDefaultExpireDateSet'] === 'no' || $_['shareAPIEnabled'] === 'no') {
115
+    p('hidden');
116
+}
117
+?>">
79 118
 		<?php p($l->t( 'Expire after ' )); ?>
80 119
 		<input type="text" name='shareapi_expire_after_n_days' id="shareapiExpireAfterNDays" placeholder="<?php p('7')?>"
81 120
 			   value='<?php p($_['shareExpireAfterNDays']) ?>' />
82 121
 		<?php p($l->t( 'days' )); ?>
83 122
 		<input type="checkbox" name="shareapi_enforce_expire_date" id="shareapiEnforceExpireDate" class="checkbox"
84
-			   value="1" <?php if ($_['shareEnforceExpireDate'] === 'yes') print_unescaped('checked="checked"'); ?> />
123
+			   value="1" <?php if ($_['shareEnforceExpireDate'] === 'yes') {
124
+    print_unescaped('checked="checked"');
125
+}
126
+?> />
85 127
 		<label for="shareapiEnforceExpireDate"><?php p($l->t('Enforce expiration date'));?></label><br/>
86 128
 	</p>
87
-	<p class="<?php if ($_['shareAPIEnabled'] === 'no') p('hidden');?>">
129
+	<p class="<?php if ($_['shareAPIEnabled'] === 'no') {
130
+    p('hidden');
131
+}
132
+?>">
88 133
 		<input type="checkbox" name="shareapi_allow_resharing" id="allowResharing" class="checkbox"
89
-			   value="1" <?php if ($_['allowResharing'] === 'yes') print_unescaped('checked="checked"'); ?> />
134
+			   value="1" <?php if ($_['allowResharing'] === 'yes') {
135
+    print_unescaped('checked="checked"');
136
+}
137
+?> />
90 138
 		<label for="allowResharing"><?php p($l->t('Allow resharing'));?></label><br/>
91 139
 	</p>
92
-	<p class="<?php if ($_['shareAPIEnabled'] === 'no') p('hidden');?>">
140
+	<p class="<?php if ($_['shareAPIEnabled'] === 'no') {
141
+    p('hidden');
142
+}
143
+?>">
93 144
 		<input type="checkbox" name="shareapi_allow_group_sharing" id="allowGroupSharing" class="checkbox"
94
-			   value="1" <?php if ($_['allowGroupSharing'] === 'yes') print_unescaped('checked="checked"'); ?> />
145
+			   value="1" <?php if ($_['allowGroupSharing'] === 'yes') {
146
+    print_unescaped('checked="checked"');
147
+}
148
+?> />
95 149
 		<label for="allowGroupSharing"><?php p($l->t('Allow sharing with groups'));?></label><br />
96 150
 	</p>
97
-	<p class="<?php if ($_['shareAPIEnabled'] === 'no') p('hidden');?>">
151
+	<p class="<?php if ($_['shareAPIEnabled'] === 'no') {
152
+    p('hidden');
153
+}
154
+?>">
98 155
 		<input type="checkbox" name="shareapi_only_share_with_group_members" id="onlyShareWithGroupMembers" class="checkbox"
99
-			   value="1" <?php if ($_['onlyShareWithGroupMembers']) print_unescaped('checked="checked"'); ?> />
156
+			   value="1" <?php if ($_['onlyShareWithGroupMembers']) {
157
+    print_unescaped('checked="checked"');
158
+}
159
+?> />
100 160
 		<label for="onlyShareWithGroupMembers"><?php p($l->t('Restrict users to only share with users in their groups'));?></label><br/>
101 161
 	</p>
102
-	<p class="<?php if ($_['shareAPIEnabled'] === 'no') p('hidden');?>">
162
+	<p class="<?php if ($_['shareAPIEnabled'] === 'no') {
163
+    p('hidden');
164
+}
165
+?>">
103 166
 		<input type="checkbox" name="shareapi_exclude_groups" id="shareapiExcludeGroups" class="checkbox"
104
-			   value="1" <?php if ($_['shareExcludeGroups']) print_unescaped('checked="checked"'); ?> />
167
+			   value="1" <?php if ($_['shareExcludeGroups']) {
168
+    print_unescaped('checked="checked"');
169
+}
170
+?> />
105 171
 		<label for="shareapiExcludeGroups"><?php p($l->t('Exclude groups from sharing'));?></label><br/>
106 172
 	</p>
107
-	<p id="selectExcludedGroups" class="indent <?php if (!$_['shareExcludeGroups'] || $_['shareAPIEnabled'] === 'no') p('hidden'); ?>">
173
+	<p id="selectExcludedGroups" class="indent <?php if (!$_['shareExcludeGroups'] || $_['shareAPIEnabled'] === 'no') {
174
+    p('hidden');
175
+}
176
+?>">
108 177
 		<input name="shareapi_exclude_groups_list" type="hidden" id="excludedGroups" value="<?php p($_['shareExcludedGroupsList']) ?>" style="width: 400px" class="noJSAutoUpdate"/>
109 178
 		<br />
110 179
 		<em><?php p($l->t('These groups will still be able to receive shares, but not to initiate them.')); ?></em>
111 180
 	</p>
112 181
 
113
-	<p class="<?php if ($_['shareAPIEnabled'] === 'no') p('hidden');?>">
182
+	<p class="<?php if ($_['shareAPIEnabled'] === 'no') {
183
+    p('hidden');
184
+}
185
+?>">
114 186
 		<input type="checkbox" name="shareapi_allow_share_dialog_user_enumeration" value="1" id="shareapi_allow_share_dialog_user_enumeration" class="checkbox"
115
-			<?php if ($_['allowShareDialogUserEnumeration'] === 'yes') print_unescaped('checked="checked"'); ?> />
187
+			<?php if ($_['allowShareDialogUserEnumeration'] === 'yes') {
188
+    print_unescaped('checked="checked"');
189
+}
190
+?> />
116 191
 		<label for="shareapi_allow_share_dialog_user_enumeration"><?php p($l->t('Allow username autocompletion in share dialog. If this is disabled the full username or email address needs to be entered.'));?></label><br />
117 192
 	</p>
118 193
 
119
-	<p id="shareapi_restrict_user_enumeration_to_group_setting" class="indent <?php if ($_['shareAPIEnabled'] === 'no' || $_['allowShareDialogUserEnumeration'] === 'no') p('hidden');?>">
194
+	<p id="shareapi_restrict_user_enumeration_to_group_setting" class="indent <?php if ($_['shareAPIEnabled'] === 'no' || $_['allowShareDialogUserEnumeration'] === 'no') {
195
+    p('hidden');
196
+}
197
+?>">
120 198
 		<input type="checkbox" name="shareapi_restrict_user_enumeration_to_group" value="1" id="shareapi_restrict_user_enumeration_to_group" class="checkbox"
121
-			<?php if ($_['restrictUserEnumerationToGroup'] === 'yes') print_unescaped('checked="checked"'); ?> />
199
+			<?php if ($_['restrictUserEnumerationToGroup'] === 'yes') {
200
+    print_unescaped('checked="checked"');
201
+}
202
+?> />
122 203
 		<label for="shareapi_restrict_user_enumeration_to_group"><?php p($l->t('Restrict username autocompletion to users within the same groups'));?></label><br />
123 204
 	</p>
124 205
 
125 206
 	<p>
126 207
 		<input type="checkbox" id="publicShareDisclaimer" class="checkbox noJSAutoUpdate"
127
-			<?php if ($_['publicShareDisclaimerText'] !== null) print_unescaped('checked="checked"'); ?> />
208
+			<?php if ($_['publicShareDisclaimerText'] !== null) {
209
+    print_unescaped('checked="checked"');
210
+}
211
+?> />
128 212
 		<label for="publicShareDisclaimer"><?php p($l->t('Show disclaimer text on the public link upload page. (Only shown when the file list is hidden.)'));?></label>
129 213
 		<span id="publicShareDisclaimerStatus" class="msg" style="display:none"></span>
130 214
 		<br/>
@@ -134,10 +218,16 @@  discard block
 block discarded – undo
134 218
 	<h3><?php p($l->t('Default share permissions'));?></h3>
135 219
 	<input type="hidden" name="shareapi_default_permissions" id="shareApiDefaultPermissions" class="checkbox"
136 220
 		   value="<?php p($_['shareApiDefaultPermissions']) ?>" />
137
-	<p id="shareApiDefaultPermissionsSection" class="indent <?php if ($_['shareAPIEnabled'] === 'no') p('hidden'); ?>">
221
+	<p id="shareApiDefaultPermissionsSection" class="indent <?php if ($_['shareAPIEnabled'] === 'no') {
222
+    p('hidden');
223
+}
224
+?>">
138 225
 		<?php foreach ($_['shareApiDefaultPermissionsCheckboxes'] as $perm): ?>
139 226
 			<input type="checkbox" name="shareapi_default_permission_<?php p($perm['id']) ?>" id="shareapi_default_permission_<?php p($perm['id']) ?>"
140
-				   class="noautosave checkbox" value="<?php p($perm['value']) ?>" <?php if (($_['shareApiDefaultPermissions'] & $perm['value']) !== 0) print_unescaped('checked="checked"'); ?> />
227
+				   class="noautosave checkbox" value="<?php p($perm['value']) ?>" <?php if (($_['shareApiDefaultPermissions'] & $perm['value']) !== 0) {
228
+    print_unescaped('checked="checked"');
229
+}
230
+?> />
141 231
 			<label for="shareapi_default_permission_<?php p($perm['id']) ?>"><?php p($perm['label']);?></label>
142 232
 		<?php endforeach ?>
143 233
 	</p>
Please login to merge, or discard this patch.