Install::configure() - Code Metrics - Inspection of "Merge pull request #5644 from nextcloud/add-occ-ap..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 63aa12...c7757b )

by Morris

created 2017-07-27 13:37 UTC

Install::configure() A

↳ Parent: Install

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	8
nc	1
nop	0
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 *
 * @author Klaus Herberth <[email protected]>
 *
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OC\Core\Command\App;

use OC\Installer;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class Install extends Command {

	protected function configure() {
		$this
			->setName('app:install')
			->setDescription('install an app')
			->addArgument(
				'app-id',
				InputArgument::REQUIRED,
				'install the specified app'
			)
		;
	}

	protected function execute(InputInterface $input, OutputInterface $output) {
		$appId = $input->getArgument('app-id');

		if (\OC_App::getAppPath($appId)) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			$output->writeln($appId . ' already installed');
			return 1;
		}

		try {
			$installer = new Installer(
				\OC::$server->getAppFetcher(),
				\OC::$server->getHTTPClientService(),
				\OC::$server->getTempManager(),
				\OC::$server->getLogger(),
				\OC::$server->getConfig()
			);
			$installer->downloadApp($appId);
			$result = $installer->installApp($appId);
		} catch(\Exception $e) {
			$output->writeln('Error: ' . $e->getMessage());
			return 1;
		}

		if($result === false) {
			$output->writeln($appId . ' couldn\'t be installed');
			return 1;
		}

		$output->writeln($appId . ' installed');

		return 0;
	}
}


1			<?php
2			/**
3			* @copyright Copyright (c) 2016, ownCloud, Inc.
4			*
5			* @author Klaus Herberth <[email protected]>
6			*
7			* @license AGPL-3.0
8			*
9			* This code is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License, version 3,
11			* as published by the Free Software Foundation.
12			*
13			* This program is distributed in the hope that it will be useful,
14			* but WITHOUT ANY WARRANTY; without even the implied warranty of
15			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16			* GNU Affero General Public License for more details.
17			*
18			* You should have received a copy of the GNU Affero General Public License, version 3,
19			* along with this program. If not, see <http://www.gnu.org/licenses/>
20			*
21			*/
22
23			namespace OC\Core\Command\App;
24
25			use OC\Installer;
26			use Symfony\Component\Console\Command\Command;
27			use Symfony\Component\Console\Input\InputArgument;
28			use Symfony\Component\Console\Input\InputInterface;
29			use Symfony\Component\Console\Output\OutputInterface;
30
31			class Install extends Command {
32
33			protected function configure() {
34			$this
35			->setName('app:install')
36			->setDescription('install an app')
37			->addArgument(
38			'app-id',
39			InputArgument::REQUIRED,
40			'install the specified app'
41			)
42			;
43			}
44
45			protected function execute(InputInterface $input, OutputInterface $output) {
46			$appId = $input->getArgument('app-id');
47
48			if (\OC_App::getAppPath($appId)) {
			0 ignored issues – show Bug Best Practice introduced 2017-07-07 07:13 UTC by Report Bug Copy Issue Report The expression `\OC_App::getAppPath($appId)` of type `false\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
49			$output->writeln($appId . ' already installed');
50			return 1;
51			}
52
53			try {
54			$installer = new Installer(
55			\OC::$server->getAppFetcher(),
56			\OC::$server->getHTTPClientService(),
57			\OC::$server->getTempManager(),
58			\OC::$server->getLogger(),
59			\OC::$server->getConfig()
60			);
61			$installer->downloadApp($appId);
62			$result = $installer->installApp($appId);
63			} catch(\Exception $e) {
64			$output->writeln('Error: ' . $e->getMessage());
65			return 1;
66			}
67
68			if($result === false) {
69			$output->writeln($appId . ' couldn\'t be installed');
70			return 1;
71			}
72
73			$output->writeln($appId . ' installed');
74
75			return 0;
76			}
77			}
78

nextcloud / server

Push — master ( 63aa12...c7757b )

Install::configure() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like