Completed
Pull Request — master (#6637)
by Tobia
11:29
created
core/Middleware/TwoFactorMiddleware.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -104,6 +104,9 @@
 block discarded – undo
104 104
 		// TODO: dont check/enforce 2FA if a auth token is used
105 105
 	}
106 106
 
107
+	/**
108
+	 * @param string $methodName
109
+	 */
107 110
 	private function checkTwoFactor(Controller $controller, $methodName, IUser $user) {
108 111
 		// If two-factor auth is in progress disallow access to any controllers
109 112
 		// defined within "LoginController".
Please login to merge, or discard this patch.
lib/private/Contacts/ContactsMenu/ContactsStore.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
 	/**
64 64
 	 * @param IUser $user
65 65
 	 * @param string|null $filter
66
-	 * @return IEntry[]
66
+	 * @return Entry[]
67 67
 	 */
68 68
 	public function getContacts(IUser $user, $filter) {
69 69
 		$allContacts = $this->contactsManager->search($filter ?: '', [
Please login to merge, or discard this patch.
apps/files_sharing/lib/Controller/ShareesAPIController.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
 	 * split user and remote from federated cloud id
392 392
 	 *
393 393
 	 * @param string $address federated share address
394
-	 * @return array [user, remoteURL]
394
+	 * @return string[] [user, remoteURL]
395 395
 	 * @throws \InvalidArgumentException
396 396
 	 */
397 397
 	public function splitUserRemote($address) {
@@ -697,6 +697,9 @@  discard block
 block discarded – undo
697 697
 		return $result;
698 698
 	}
699 699
 
700
+	/**
701
+	 * @param string $search
702
+	 */
700 703
 	protected function getLookup($search) {
701 704
 		$isEnabled = $this->config->getAppValue('files_sharing', 'lookupServerEnabled', 'no');
702 705
 		$lookupServerUrl = $this->config->getSystemValue('lookup_server', 'https://lookup.nextcloud.com');
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -450,6 +450,10 @@
 block discarded – undo
450 450
 		return $url;
451 451
 	}
452 452
 
453
+	/**
454
+	 * @param string $feature
455
+	 * @param string $oldValue
456
+	 */
453 457
 	public function triggerChange($feature, $value = null, $oldValue = null) {
454 458
 		if ($this->emitter) {
455 459
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value, $oldValue));
Please login to merge, or discard this patch.
apps/theming/lib/ThemingDefaults.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,6 @@  discard block
 block discarded – undo
64 64
 	 * @param IConfig $config
65 65
 	 * @param IL10N $l
66 66
 	 * @param IURLGenerator $urlGenerator
67
-	 * @param \OC_Defaults $defaults
68 67
 	 * @param IAppData $appData
69 68
 	 * @param ICacheFactory $cacheFactory
70 69
 	 * @param Util $util
@@ -254,7 +253,7 @@  discard block
 block discarded – undo
254 253
 	 *
255 254
 	 * @param string $app name of the app
256 255
 	 * @param string $image filename of the image
257
-	 * @return bool|string false if image should not replaced, otherwise the location of the image
256
+	 * @return string|false false if image should not replaced, otherwise the location of the image
258 257
 	 */
259 258
 	public function replaceImagePath($app, $image) {
260 259
 		if($app==='') {
Please login to merge, or discard this patch.
lib/private/OCS/DiscoveryService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
 	 * get requested end-points from the requested service
92 92
 	 *
93 93
 	 * @param $decodedServices
94
-	 * @param $service
94
+	 * @param string $service
95 95
 	 * @return array
96 96
 	 */
97 97
 	protected function getEndpoints($decodedServices, $service) {
Please login to merge, or discard this patch.