Completed
Pull Request — master (#6637)
by Tobia
12:24
created
apps/user_ldap/lib/Access.php 1 patch
Doc Comments   +7 added lines, -5 removed lines patch added patch discarded remove patch
@@ -500,7 +500,7 @@  discard block
 block discarded – undo
500 500
 
501 501
 	/**
502 502
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
503
-	 * @param string $dn the dn of the user object
503
+	 * @param string $fdn the dn of the user object
504 504
 	 * @param string $ldapName optional, the display name of the object
505 505
 	 * @return string|false with with the name to use in Nextcloud
506 506
 	 */
@@ -786,7 +786,7 @@  discard block
 block discarded – undo
786 786
 	 * the login filter.
787 787
 	 *
788 788
 	 * @param string $loginName
789
-	 * @param array $attributes optional, list of attributes to read
789
+	 * @param string[] $attributes optional, list of attributes to read
790 790
 	 * @return array
791 791
 	 */
792 792
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -870,7 +870,7 @@  discard block
 block discarded – undo
870 870
 
871 871
 	/**
872 872
 	 * @param string $filter
873
-	 * @param string|string[] $attr
873
+	 * @param string[] $attr
874 874
 	 * @param int $limit
875 875
 	 * @param int $offset
876 876
 	 * @return array
@@ -918,7 +918,7 @@  discard block
 block discarded – undo
918 918
 
919 919
 	/**
920 920
 	 * @param string $filter
921
-	 * @param string|string[] $attr
921
+	 * @param string[] $attr
922 922
 	 * @param int $limit
923 923
 	 * @param int $offset
924 924
 	 * @return false|int
@@ -1018,6 +1018,7 @@  discard block
 block discarded – undo
1018 1018
 	 * retrieved. Results will according to the order in the array.
1019 1019
 	 * @param int $limit optional, maximum results to be counted
1020 1020
 	 * @param int $offset optional, a starting point
1021
+	 * @param string $filter
1021 1022
 	 * @return array|false array with the search result as first value and pagedSearchOK as
1022 1023
 	 * second | false if not successful
1023 1024
 	 * @throws \OC\ServerNotAvailableException
@@ -1274,7 +1275,7 @@  discard block
 block discarded – undo
1274 1275
 
1275 1276
 	/**
1276 1277
 	 * @param string $name
1277
-	 * @return bool|mixed|string
1278
+	 * @return string
1278 1279
 	 */
1279 1280
 	public function sanitizeUsername($name) {
1280 1281
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1298,6 +1299,7 @@  discard block
 block discarded – undo
1298 1299
 	* escapes (user provided) parts for LDAP filter
1299 1300
 	* @param string $input, the provided value
1300 1301
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
1302
+	* @param string $input
1301 1303
 	* @return string the escaped string
1302 1304
 	*/
1303 1305
 	public function escapeFilterPart($input, $allowAsterisk = false) {
Please login to merge, or discard this patch.
lib/private/legacy/files.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -338,7 +338,7 @@
 block discarded – undo
338 338
 	 *
339 339
 	 * @param int $size file size in bytes
340 340
 	 * @param array $files override '.htaccess' and '.user.ini' locations
341
-	 * @return bool|int false on failure, size on success
341
+	 * @return integer false on failure, size on success
342 342
 	 */
343 343
 	public static function setUploadLimit($size, $files = []) {
344 344
 		//don't allow user to break his config
Please login to merge, or discard this patch.
lib/private/Avatar.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 	 * @param int $r
269 269
 	 * @param int $g
270 270
 	 * @param int $b
271
-	 * @return double[] Array containing h s l in [0, 1] range
271
+	 * @return double Array containing h s l in [0, 1] range
272 272
 	 */
273 273
 	private function rgbToHsl($r, $g, $b) {
274 274
 		$r /= 255.0;
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
 
307 307
 	/**
308 308
 	 * @param string $text
309
-	 * @return int[] Array containting r g b in the range [0, 255]
309
+	 * @return double[] Array containting r g b in the range [0, 255]
310 310
 	 */
311 311
 	private function avatarBackgroundColor($text) {
312 312
 		$hash = preg_replace('/[^0-9a-f]+/', '', $text);
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
 	 * @param double $h Hue in range [0, 1]
356 356
 	 * @param double $s Saturation in range [0, 1]
357 357
 	 * @param double $l Lightness in range [0, 1]
358
-	 * @return int[] Array containing r g b in the range [0, 255]
358
+	 * @return double[] Array containing r g b in the range [0, 255]
359 359
 	 */
360 360
 	private function hslToRgb($h, $s, $l){
361 361
 		$hue2rgb = function ($p, $q, $t){
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 	 * @param ILogger $logger
96 96
 	 * @param ITimeFactory $timeFactory
97 97
 	 * @param L10NFactory $l10nFactory
98
-	 * @param IUrlGenerator $urlGenerator
98
+	 * @param IURLGenerator $urlGenerator
99 99
 	 * @param Defaults $defaults
100 100
 	 * @param string $userId
101 101
 	 */
Please login to merge, or discard this patch.
apps/files_sharing/lib/Cache.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -135,6 +135,10 @@
 block discarded – undo
135 135
 		return parent::moveFromCache($sourceCache, $sourcePath, $targetPath);
136 136
 	}
137 137
 
138
+	/**
139
+	 * @param ICacheEntry $entry
140
+	 * @param string $path
141
+	 */
138 142
 	protected function formatCacheEntry($entry, $path = null) {
139 143
 		if (is_null($path)) {
140 144
 			$path = isset($entry['path']) ? $entry['path'] : '';
Please login to merge, or discard this patch.
apps/dav/lib/AppInfo/Application.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
 	}
77 77
 
78 78
 	/**
79
-	 * @param IManager $contactsManager
79
+	 * @param IContactsManager $contactsManager
80 80
 	 */
81 81
 	public function setupSystemContactsProvider(IContactsManager $contactsManager) {
82 82
 		/** @var ContactsManager $cm */
Please login to merge, or discard this patch.