Passed
Push — master ( 7d851f...e6959b )
by Robin
15:52 queued 12s
created
lib/private/Encryption/DecryptAll.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 		$this->output = $output;
88 88
 
89 89
 		if ($user !== '' && $this->userManager->userExists($user) === false) {
90
-			$this->output->writeln('User "' . $user . '" does not exist. Please check the username and try again');
90
+			$this->output->writeln('User "'.$user.'" does not exist. Please check the username and try again');
91 91
 			return false;
92 92
 		}
93 93
 
@@ -105,9 +105,9 @@  discard block
 block discarded – undo
105 105
 			$this->output->writeln('Files for following users couldn\'t be decrypted, ');
106 106
 			$this->output->writeln('maybe the user is not set up in a way that supports this operation: ');
107 107
 			foreach ($this->failed as $uid => $paths) {
108
-				$this->output->writeln('    ' . $uid);
108
+				$this->output->writeln('    '.$uid);
109 109
 				foreach ($paths as $path) {
110
-					$this->output->writeln('        ' . $path);
110
+					$this->output->writeln('        '.$path);
111 111
 				}
112 112
 			}
113 113
 			$this->output->writeln('');
@@ -129,10 +129,10 @@  discard block
 block discarded – undo
129 129
 			/** @var IEncryptionModule $module */
130 130
 			$module = call_user_func($moduleDesc['callback']);
131 131
 			$this->output->writeln('');
132
-			$this->output->writeln('Prepare "' . $module->getDisplayName() . '"');
132
+			$this->output->writeln('Prepare "'.$module->getDisplayName().'"');
133 133
 			$this->output->writeln('');
134 134
 			if ($module->prepareDecryptAll($this->input, $this->output, $user) === false) {
135
-				$this->output->writeln('Module "' . $moduleDesc['displayName'] . '" does not support the functionality to decrypt all files again or the initialization of the module failed!');
135
+				$this->output->writeln('Module "'.$moduleDesc['displayName'].'" does not support the functionality to decrypt all files again or the initialization of the module failed!');
136 136
 				return false;
137 137
 			}
138 138
 		}
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	protected function decryptUsersFiles($uid, ProgressBar $progress, $userCount) {
207 207
 		$this->setupUserFS($uid);
208 208
 		$directories = [];
209
-		$directories[] = '/' . $uid . '/files';
209
+		$directories[] = '/'.$uid.'/files';
210 210
 
211 211
 		while ($root = array_pop($directories)) {
212 212
 			$content = $this->rootView->getDirectoryContent($root);
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 				if ($file->getStorage()->instanceOfStorage('OCA\Files_Sharing\SharedStorage')) {
216 216
 					continue;
217 217
 				}
218
-				$path = $root . '/' . $file['name'];
218
+				$path = $root.'/'.$file['name'];
219 219
 				if ($this->rootView->is_dir($path)) {
220 220
 					$directories[] = $path;
221 221
 					continue;
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 		}
260 260
 
261 261
 		$source = $path;
262
-		$target = $path . '.decrypted.' . $this->getTimestamp();
262
+		$target = $path.'.decrypted.'.$this->getTimestamp();
263 263
 
264 264
 		try {
265 265
 			$this->rootView->copy($source, $target);
Please login to merge, or discard this patch.
lib/private/Security/IdentityProof/Manager.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 */
145 145
 	public function getKey(IUser $user): Key {
146 146
 		$uid = $user->getUID();
147
-		return $this->retrieveKey('user-' . $uid);
147
+		return $this->retrieveKey('user-'.$uid);
148 148
 	}
149 149
 
150 150
 	/**
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 		if ($instanceId === null) {
159 159
 			throw new \RuntimeException('no instance id!');
160 160
 		}
161
-		return $this->retrieveKey('system-' . $instanceId);
161
+		return $this->retrieveKey('system-'.$instanceId);
162 162
 	}
163 163
 
164 164
 	private function logOpensslError(): void {
@@ -166,6 +166,6 @@  discard block
 block discarded – undo
166 166
 		while ($error = openssl_error_string()) {
167 167
 			$errors[] = $error;
168 168
 		}
169
-		$this->logger->critical('Something is wrong with your openssl setup: ' . implode(', ', $errors));
169
+		$this->logger->critical('Something is wrong with your openssl setup: '.implode(', ', $errors));
170 170
 	}
171 171
 }
Please login to merge, or discard this patch.
lib/private/Security/CSRF/CsrfToken.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 	public function getEncryptedValue(): string {
58 58
 		if ($this->encryptedValue === '') {
59 59
 			$sharedSecret = random_bytes(\strlen($this->value));
60
-			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret) . ':' . base64_encode($sharedSecret);
60
+			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret).':'.base64_encode($sharedSecret);
61 61
 		}
62 62
 
63 63
 		return $this->encryptedValue;
Please login to merge, or discard this patch.
lib/private/Security/CSP/ContentSecurityPolicyManager.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
 	 */
75 75
 	public function mergePolicies(ContentSecurityPolicy $defaultPolicy,
76 76
 								  EmptyContentSecurityPolicy $originalPolicy): ContentSecurityPolicy {
77
-		foreach ((object)(array)$originalPolicy as $name => $value) {
77
+		foreach ((object) (array) $originalPolicy as $name => $value) {
78 78
 			$setter = 'set'.ucfirst($name);
79 79
 			if (\is_array($value)) {
80 80
 				$getter = 'get'.ucfirst($name);
Please login to merge, or discard this patch.
lib/private/Security/Hasher.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -96,14 +96,14 @@  discard block
 block discarded – undo
96 96
 		$alg = $this->getPrefferedAlgorithm();
97 97
 
98 98
 		if (\defined('PASSWORD_ARGON2ID') && $alg === PASSWORD_ARGON2ID) {
99
-			return 3 . '|' . password_hash($message, PASSWORD_ARGON2ID, $this->options);
99
+			return 3.'|'.password_hash($message, PASSWORD_ARGON2ID, $this->options);
100 100
 		}
101 101
 
102 102
 		if (\defined('PASSWORD_ARGON2I') && $alg === PASSWORD_ARGON2I) {
103
-			return 2 . '|' . password_hash($message, PASSWORD_ARGON2I, $this->options);
103
+			return 2.'|'.password_hash($message, PASSWORD_ARGON2I, $this->options);
104 104
 		}
105 105
 
106
-		return 1 . '|' . password_hash($message, PASSWORD_BCRYPT, $this->options);
106
+		return 1.'|'.password_hash($message, PASSWORD_BCRYPT, $this->options);
107 107
 	}
108 108
 
109 109
 	/**
@@ -114,8 +114,8 @@  discard block
 block discarded – undo
114 114
 	protected function splitHash(string $prefixedHash) {
115 115
 		$explodedString = explode('|', $prefixedHash, 2);
116 116
 		if (\count($explodedString) === 2) {
117
-			if ((int)$explodedString[0] > 0) {
118
-				return ['version' => (int)$explodedString[0], 'hash' => $explodedString[1]];
117
+			if ((int) $explodedString[0] > 0) {
118
+				return ['version' => (int) $explodedString[0], 'hash' => $explodedString[1]];
119 119
 			}
120 120
 		}
121 121
 
Please login to merge, or discard this patch.
lib/private/Collaboration/Collaborators/MailPlugin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 						$emailAddressType = $emailAddressData['type'];
100 100
 					}
101 101
 					if (isset($contact['FN'])) {
102
-						$displayName = $contact['FN'] . ' (' . $emailAddress . ')';
102
+						$displayName = $contact['FN'].' ('.$emailAddress.')';
103 103
 					}
104 104
 					$exactEmailMatch = strtolower($emailAddress) === $lowerSearch;
105 105
 
Please login to merge, or discard this patch.
lib/private/Group/Group.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 			return;
174 174
 		}
175 175
 
176
-		$this->dispatcher->dispatch(IGroup::class . '::preAddUser', new GenericEvent($this, [
176
+		$this->dispatcher->dispatch(IGroup::class.'::preAddUser', new GenericEvent($this, [
177 177
 			'user' => $user,
178 178
 		]));
179 179
 
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 					$this->users[$user->getUID()] = $user;
188 188
 				}
189 189
 
190
-				$this->dispatcher->dispatch(IGroup::class . '::postAddUser', new GenericEvent($this, [
190
+				$this->dispatcher->dispatch(IGroup::class.'::postAddUser', new GenericEvent($this, [
191 191
 					'user' => $user,
192 192
 				]));
193 193
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	 */
207 207
 	public function removeUser($user) {
208 208
 		$result = false;
209
-		$this->dispatcher->dispatch(IGroup::class . '::preRemoveUser', new GenericEvent($this, [
209
+		$this->dispatcher->dispatch(IGroup::class.'::preRemoveUser', new GenericEvent($this, [
210 210
 			'user' => $user,
211 211
 		]));
212 212
 		if ($this->emitter) {
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 			}
220 220
 		}
221 221
 		if ($result) {
222
-			$this->dispatcher->dispatch(IGroup::class . '::postRemoveUser', new GenericEvent($this, [
222
+			$this->dispatcher->dispatch(IGroup::class.'::postRemoveUser', new GenericEvent($this, [
223 223
 				'user' => $user,
224 224
 			]));
225 225
 			if ($this->emitter) {
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 		}
330 330
 
331 331
 		$result = false;
332
-		$this->dispatcher->dispatch(IGroup::class . '::preDelete', new GenericEvent($this));
332
+		$this->dispatcher->dispatch(IGroup::class.'::preDelete', new GenericEvent($this));
333 333
 		if ($this->emitter) {
334 334
 			$this->emitter->emit('\OC\Group', 'preDelete', [$this]);
335 335
 		}
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 			}
341 341
 		}
342 342
 		if ($result) {
343
-			$this->dispatcher->dispatch(IGroup::class . '::postDelete', new GenericEvent($this));
343
+			$this->dispatcher->dispatch(IGroup::class.'::postDelete', new GenericEvent($this));
344 344
 			if ($this->emitter) {
345 345
 				$this->emitter->emit('\OC\Group', 'postDelete', [$this]);
346 346
 			}
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
 	 * @since 16.0.0
399 399
 	 */
400 400
 	public function hideFromCollaboration(): bool {
401
-		return array_reduce($this->backends, function (bool $hide, GroupInterface $backend) {
401
+		return array_reduce($this->backends, function(bool $hide, GroupInterface $backend) {
402 402
 			return $hide | ($backend instanceof IHideFromCollaborationBackend && $backend->hideGroup($this->gid));
403 403
 		}, false);
404 404
 	}
Please login to merge, or discard this patch.
lib/private/legacy/OC_Response.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,10 +40,10 @@  discard block
 block discarded – undo
40 40
 				\OC\AppFramework\Http\Request::USER_AGENT_ANDROID_MOBILE_CHROME,
41 41
 				\OC\AppFramework\Http\Request::USER_AGENT_FREEBOX,
42 42
 			])) {
43
-			header('Content-Disposition: ' . rawurlencode($type) . '; filename="' . rawurlencode($filename) . '"');
43
+			header('Content-Disposition: '.rawurlencode($type).'; filename="'.rawurlencode($filename).'"');
44 44
 		} else {
45
-			header('Content-Disposition: ' . rawurlencode($type) . '; filename*=UTF-8\'\'' . rawurlencode($filename)
46
-												 . '; filename="' . rawurlencode($filename) . '"');
45
+			header('Content-Disposition: '.rawurlencode($type).'; filename*=UTF-8\'\''.rawurlencode($filename)
46
+												 . '; filename="'.rawurlencode($filename).'"');
47 47
 		}
48 48
 	}
49 49
 
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 			. 'connect-src *; '
91 91
 			. 'object-src \'none\'; '
92 92
 			. 'base-uri \'self\'; ';
93
-		header('Content-Security-Policy:' . $policy);
93
+		header('Content-Security-Policy:'.$policy);
94 94
 
95 95
 		// Send fallback headers for installations that don't have the possibility to send
96 96
 		// custom headers on the webserver side
Please login to merge, or discard this patch.
lib/private/legacy/OC_EventSource.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 		header('X-Accel-Buffering: no');
61 61
 		$this->fallback = isset($_GET['fallback']) and $_GET['fallback'] == 'true';
62 62
 		if ($this->fallback) {
63
-			$this->fallBackId = (int)$_GET['fallback_id'];
63
+			$this->fallBackId = (int) $_GET['fallback_id'];
64 64
 			/**
65 65
 			 * FIXME: The default content-security-policy of ownCloud forbids inline
66 66
 			 * JavaScript for security reasons. IE starting on Windows 10 will
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 			 */
74 74
 			header("Content-Security-Policy: default-src 'none'; script-src 'unsafe-inline'");
75 75
 			header("Content-Type: text/html");
76
-			echo str_repeat('<span></span>' . PHP_EOL, 10); //dummy data to keep IE happy
76
+			echo str_repeat('<span></span>'.PHP_EOL, 10); //dummy data to keep IE happy
77 77
 		} else {
78 78
 			header("Content-Type: text/event-stream");
79 79
 		}
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 	 */
102 102
 	public function send($type, $data = null) {
103 103
 		if ($data and !preg_match('/^[A-Za-z0-9_]+$/', $type)) {
104
-			throw new BadMethodCallException('Type needs to be alphanumeric ('. $type .')');
104
+			throw new BadMethodCallException('Type needs to be alphanumeric ('.$type.')');
105 105
 		}
106 106
 		$this->init();
107 107
 		if (is_null($data)) {
@@ -110,13 +110,13 @@  discard block
 block discarded – undo
110 110
 		}
111 111
 		if ($this->fallback) {
112 112
 			$response = '<script type="text/javascript">window.parent.OC.EventSource.fallBackCallBack('
113
-				. $this->fallBackId . ',"' . $type . '",' . OC_JSON::encode($data) . ')</script>' . PHP_EOL;
113
+				. $this->fallBackId.',"'.$type.'",'.OC_JSON::encode($data).')</script>'.PHP_EOL;
114 114
 			echo $response;
115 115
 		} else {
116 116
 			if ($type) {
117
-				echo 'event: ' . $type . PHP_EOL;
117
+				echo 'event: '.$type.PHP_EOL;
118 118
 			}
119
-			echo 'data: ' . OC_JSON::encode($data) . PHP_EOL;
119
+			echo 'data: '.OC_JSON::encode($data).PHP_EOL;
120 120
 		}
121 121
 		echo PHP_EOL;
122 122
 		flush();
Please login to merge, or discard this patch.