nextcloud /
server
| Conditions | 23 |
| Paths | 70 |
| Total Lines | 64 |
| Code Lines | 49 |
| Lines | 24 |
| Ratio | 37.5 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 75 | public function parse(IEvent $event, IEvent $previousEvent = null) { |
||
| 76 | if ($event->getApp() !== 'dav' || $event->getType() !== 'calendar') { |
||
| 77 | throw new \InvalidArgumentException(); |
||
| 78 | } |
||
| 79 | |||
| 80 | $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'places/calendar-dark.svg'))); |
||
| 81 | |||
| 82 | if ($event->getSubject() === self::SUBJECT_ADD) { |
||
| 83 | $subject = $this->l->t('{actor} created calendar {calendar}'); |
||
| 84 | } else if ($event->getSubject() === self::SUBJECT_ADD . '_self') { |
||
| 85 | $subject = $this->l->t('You created calendar {calendar}'); |
||
| 86 | } else if ($event->getSubject() === self::SUBJECT_DELETE) { |
||
| 87 | $subject = $this->l->t('{actor} deleted calendar {calendar}'); |
||
| 88 | } else if ($event->getSubject() === self::SUBJECT_DELETE . '_self') { |
||
| 89 | $subject = $this->l->t('You deleted calendar {calendar}'); |
||
| 90 | } else if ($event->getSubject() === self::SUBJECT_UPDATE) { |
||
| 91 | $subject = $this->l->t('{actor} updated calendar {calendar}'); |
||
| 92 | } else if ($event->getSubject() === self::SUBJECT_UPDATE . '_self') { |
||
| 93 | $subject = $this->l->t('You updated calendar {calendar}'); |
||
| 94 | |||
| 95 | } else if ($event->getSubject() === self::SUBJECT_SHARE_USER) { |
||
| 96 | $subject = $this->l->t('{actor} shared calendar {calendar} with you'); |
||
| 97 | View Code Duplication | } else if ($event->getSubject() === self::SUBJECT_SHARE_USER . '_you') { |
|
| 98 | $subject = $this->l->t('You shared calendar {calendar} with {user}'); |
||
| 99 | } else if ($event->getSubject() === self::SUBJECT_SHARE_USER . '_by') { |
||
| 100 | $subject = $this->l->t('{actor} shared calendar {calendar} with {user}'); |
||
| 101 | } else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER) { |
||
| 102 | $subject = $this->l->t('{actor} unshared calendar {calendar} from you'); |
||
| 103 | } else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_you') { |
||
| 104 | $subject = $this->l->t('You unshared calendar {calendar} from {user}'); |
||
| 105 | } else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_by') { |
||
| 106 | $subject = $this->l->t('{actor} unshared calendar {calendar} from {user}'); |
||
| 107 | } else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_self') { |
||
| 108 | $subject = $this->l->t('{actor} unshared calendar {calendar} from themselves'); |
||
| 109 | |||
| 110 | } else if ($event->getSubject() === self::SUBJECT_SHARE_GROUP . '_you') { |
||
| 111 | $subject = $this->l->t('You shared calendar {calendar} with group {group}'); |
||
| 112 | } else if ($event->getSubject() === self::SUBJECT_SHARE_GROUP . '_by') { |
||
| 113 | $subject = $this->l->t('{actor} shared calendar {calendar} with group {group}'); |
||
| 114 | } else if ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP . '_you') { |
||
| 115 | $subject = $this->l->t('You unshared calendar {calendar} from group {group}'); |
||
| 116 | } else if ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP . '_by') { |
||
| 117 | $subject = $this->l->t('{actor} unshared calendar {calendar} from group {group}'); |
||
| 118 | } else { |
||
| 119 | throw new \InvalidArgumentException(); |
||
| 120 | } |
||
| 121 | |||
| 122 | $parsedParameters = $this->getParameters($event); |
||
| 123 | $this->setSubjects($event, $subject, $parsedParameters); |
||
| 124 | |||
| 125 | $event = $this->eventMerger->mergeEvents('calendar', $event, $previousEvent); |
||
| 126 | |||
| 127 | if ($event->getChildEvent() === null) { |
||
| 128 | if (isset($parsedParameters['user'])) { |
||
| 129 | // Couldn't group by calendar, maybe we can group by users |
||
| 130 | $event = $this->eventMerger->mergeEvents('user', $event, $previousEvent); |
||
| 131 | } else if (isset($parsedParameters['group'])) { |
||
| 132 | // Couldn't group by calendar, maybe we can group by groups |
||
| 133 | $event = $this->eventMerger->mergeEvents('group', $event, $previousEvent); |
||
| 134 | } |
||
| 135 | } |
||
| 136 | |||
| 137 | return $event; |
||
| 138 | } |
||
| 139 | |||
| 193 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.