Inspection of "Merge pull request #24501 from nextcloud/personal-..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4deff3...82cc9c )

by Roeland

created 2020-12-02 18:48 UTC

Status

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -127,7 +127,7 @@  discard block
 block discarded – undo
 
 		$storageConfigs = $this->userGlobalStoragesService->getAllStoragesForUser();
 
-		$storages = array_map(function (StorageConfig $storageConfig) use ($user) {
+		$storages = array_map(function(StorageConfig $storageConfig) use ($user) {
 			try {
 				$this->prepareStorageConfig($storageConfig, $user);
 				return $this->constructStorage($storageConfig);
@@ -138,16 +138,16 @@  discard block
 block discarded – undo
 		}, $storageConfigs);
 
 
-		\OC\Files\Cache\Storage::getGlobalCache()->loadForStorageIds(array_map(function (Storage\IStorage $storage) {
+		\OC\Files\Cache\Storage::getGlobalCache()->loadForStorageIds(array_map(function(Storage\IStorage $storage) {
 			return $storage->getId();
 		}, $storages));
 
-		$availableStorages = array_map(function (Storage\IStorage $storage, StorageConfig $storageConfig) {
+		$availableStorages = array_map(function(Storage\IStorage $storage, StorageConfig $storageConfig) {
 			try {
 				$availability = $storage->getAvailability();
 				if (!$availability['available'] && !Availability::shouldRecheck($availability)) {
 					$storage = new FailedStorage([
-						'exception' => new StorageNotAvailableException('Storage with mount id ' . $storageConfig->getId() . ' is not available')
+						'exception' => new StorageNotAvailableException('Storage with mount id '.$storageConfig->getId().' is not available')
 					]);
 				}
 			} catch (\Exception $e) {
@@ -157,13 +157,13 @@  discard block
 block discarded – undo
 			return $storage;
 		}, $storages, $storageConfigs);
 
-		$mounts = array_map(function (StorageConfig $storageConfig, Storage\IStorage $storage) use ($user, $loader) {
+		$mounts = array_map(function(StorageConfig $storageConfig, Storage\IStorage $storage) use ($user, $loader) {
 			if ($storageConfig->getType() === StorageConfig::MOUNT_TYPE_PERSONAl) {
 				return new PersonalMount(
 					$this->userStoragesService,
 					$storageConfig->getId(),
 					$storage,
-					'/' . $user->getUID() . '/files' . $storageConfig->getMountPoint(),
+					'/'.$user->getUID().'/files'.$storageConfig->getMountPoint(),
 					null,
 					$loader,
 					$storageConfig->getMountOptions(),
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
 			} else {
 				return new ExternalMountPoint(
 					$storage,
-					'/' . $user->getUID() . '/files' . $storageConfig->getMountPoint(),
+					'/'.$user->getUID().'/files'.$storageConfig->getMountPoint(),
 					null,
 					$loader,
 					$storageConfig->getMountOptions(),

Please login to merge, or discard this patch.

		@@ -127,7 +127,7 @@ discard block
		block discarded – undo
127	127
128	128	$storageConfigs = $this->userGlobalStoragesService->getAllStoragesForUser();
129	129
130		- $storages = array_map(function (StorageConfig $storageConfig) use ($user) {
	130	+ $storages = array_map(function(StorageConfig $storageConfig) use ($user) {
131	131	try {
132	132	$this->prepareStorageConfig($storageConfig, $user);
133	133	return $this->constructStorage($storageConfig);
		@@ -138,16 +138,16 @@ discard block
		block discarded – undo
138	138	}, $storageConfigs);
139	139
140	140
141		- \OC\Files\Cache\Storage::getGlobalCache()->loadForStorageIds(array_map(function (Storage\IStorage $storage) {
	141	+ \OC\Files\Cache\Storage::getGlobalCache()->loadForStorageIds(array_map(function(Storage\IStorage $storage) {
142	142	return $storage->getId();
143	143	}, $storages));
144	144
145		- $availableStorages = array_map(function (Storage\IStorage $storage, StorageConfig $storageConfig) {
	145	+ $availableStorages = array_map(function(Storage\IStorage $storage, StorageConfig $storageConfig) {
146	146	try {
147	147	$availability = $storage->getAvailability();
148	148	if (!$availability['available'] && !Availability::shouldRecheck($availability)) {
149	149	$storage = new FailedStorage([
150		- 'exception' => new StorageNotAvailableException('Storage with mount id ' . $storageConfig->getId() . ' is not available')
	150	+ 'exception' => new StorageNotAvailableException('Storage with mount id '.$storageConfig->getId().' is not available')
151	151	]);
152	152	}
153	153	} catch (\Exception $e) {
		@@ -157,13 +157,13 @@ discard block
		block discarded – undo
157	157	return $storage;
158	158	}, $storages, $storageConfigs);
159	159
160		- $mounts = array_map(function (StorageConfig $storageConfig, Storage\IStorage $storage) use ($user, $loader) {
	160	+ $mounts = array_map(function(StorageConfig $storageConfig, Storage\IStorage $storage) use ($user, $loader) {
161	161	if ($storageConfig->getType() === StorageConfig::MOUNT_TYPE_PERSONAl) {
162	162	return new PersonalMount(
163	163	$this->userStoragesService,
164	164	$storageConfig->getId(),
165	165	$storage,
166		- '/' . $user->getUID() . '/files' . $storageConfig->getMountPoint(),
	166	+ '/'.$user->getUID().'/files'.$storageConfig->getMountPoint(),
167	167	null,
168	168	$loader,
169	169	$storageConfig->getMountOptions(),
		@@ -172,7 +172,7 @@ discard block
		block discarded – undo
172	172	} else {
173	173	return new ExternalMountPoint(
174	174	$storage,
175		- '/' . $user->getUID() . '/files' . $storageConfig->getMountPoint(),
	175	+ '/'.$user->getUID().'/files'.$storageConfig->getMountPoint(),
176	176	null,
177	177	$loader,
178	178	$storageConfig->getMountOptions(),

nextcloud / server

Push — master ( 4deff3...82cc9c )

Status

Category

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch