UserStatus::getStatus() - Code Metrics - Inspection of "Merge pull request #22106 from nextcloud/feature/n..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a4d511...6fbf8f )

by Morris

created 2020-08-05 13:30 UTC

UserStatus::getStatus() A

↳ Parent: UserStatus

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	2
rs	10
c	1
b	0
f	0

<?php

declare(strict_types=1);

/**
 * @copyright Copyright (c) 2020, Georg Ehrke
 *
 * @author Georg Ehrke <[email protected]>
 *
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program. If not, see <http://www.gnu.org/licenses/>
 *
 */
namespace OCA\UserStatus\Connector;

use DateTimeImmutable;
use OCP\UserStatus\IUserStatus;
use OCA\UserStatus\Db;

class UserStatus implements IUserStatus {

	/** @var string */
	private $userId;

	/** @var string */
	private $status;

	/** @var string|null */
	private $message;

	/** @var string|null */
	private $icon;

	/** @var DateTimeImmutable|null */
	private $clearAt;

	/**
	 * UserStatus constructor.
	 *
	 * @param Db\UserStatus $status
	 */
	public function __construct(Db\UserStatus $status) {
		$this->userId = $status->getUserId();
		$this->status = $status->getStatus();
		$this->message = $status->getCustomMessage();
		$this->icon = $status->getCustomIcon();

		if ($status->getStatus() === 'invisible') {
			$this->status = 'offline';
		}
		if ($status->getClearAt() !== null) {

			$this->clearAt = DateTimeImmutable::createFromFormat('U', (string)$status->getClearAt());
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
		}
	}

	/**
	 * @inheritDoc
	 */
	public function getUserId(): string {
		return $this->userId;
	}

	/**
	 * @inheritDoc
	 */
	public function getStatus(): string {
		return $this->status;
	}

	/**
	 * @inheritDoc
	 */
	public function getMessage(): ?string {
		return $this->message;
	}

	/**
	 * @inheritDoc
	 */
	public function getIcon(): ?string {
		return $this->icon;
	}

	/**
	 * @inheritDoc
	 */
	public function getClearAt(): ?DateTimeImmutable {
		return $this->clearAt;
	}
}


1			<?php
2
3			declare(strict_types=1);
4
5			/**
6			* @copyright Copyright (c) 2020, Georg Ehrke
7			*
8			* @author Georg Ehrke <[email protected]>
9			*
10			* @license AGPL-3.0
11			*
12			* This code is free software: you can redistribute it and/or modify
13			* it under the terms of the GNU Affero General Public License, version 3,
14			* as published by the Free Software Foundation.
15			*
16			* This program is distributed in the hope that it will be useful,
17			* but WITHOUT ANY WARRANTY; without even the implied warranty of
18			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19			* GNU Affero General Public License for more details.
20			*
21			* You should have received a copy of the GNU Affero General Public License, version 3,
22			* along with this program. If not, see <http://www.gnu.org/licenses/>
23			*
24			*/
25			namespace OCA\UserStatus\Connector;
26
27			use DateTimeImmutable;
28			use OCP\UserStatus\IUserStatus;
29			use OCA\UserStatus\Db;
30
31			class UserStatus implements IUserStatus {
32
33			/** @var string */
34			private $userId;
35
36			/** @var string */
37			private $status;
38
39			/** @var string\|null */
40			private $message;
41
42			/** @var string\|null */
43			private $icon;
44
45			/** @var DateTimeImmutable\|null */
46			private $clearAt;
47
48			/**
49			* UserStatus constructor.
50			*
51			* @param Db\UserStatus $status
52			*/
53			public function __construct(Db\UserStatus $status) {
54			$this->userId = $status->getUserId();
55			$this->status = $status->getStatus();
56			$this->message = $status->getCustomMessage();
57			$this->icon = $status->getCustomIcon();
58
59			if ($status->getStatus() === 'invisible') {
60			$this->status = 'offline';
61			}
62			if ($status->getClearAt() !== null) {
			0 ignored issues – show introduced 2020-08-05 13:50 UTC by Report Bug Copy Issue Report The condition `$status->getClearAt() !== null` is always `true`. Loading history...
63			$this->clearAt = DateTimeImmutable::createFromFormat('U', (string)$status->getClearAt());
			0 ignored issues – show Documentation Bug introduced 2020-08-05 13:50 UTC by Report Bug Copy Issue Report It seems like `DateTimeImmutable::creat...)$status->getClearAt())` can also be of type `false`. However, the property `$clearAt` is declared as type `DateTimeImmutable\|null`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
64			}
65			}
66
67			/**
68			* @inheritDoc
69			*/
70			public function getUserId(): string {
71			return $this->userId;
72			}
73
74			/**
75			* @inheritDoc
76			*/
77			public function getStatus(): string {
78			return $this->status;
79			}
80
81			/**
82			* @inheritDoc
83			*/
84			public function getMessage(): ?string {
85			return $this->message;
86			}
87
88			/**
89			* @inheritDoc
90			*/
91			public function getIcon(): ?string {
92			return $this->icon;
93			}
94
95			/**
96			* @inheritDoc
97			*/
98			public function getClearAt(): ?DateTimeImmutable {
99			return $this->clearAt;
100			}
101			}
102

nextcloud / server

Push — master ( a4d511...6fbf8f )

UserStatus::getStatus() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like