nextcloud / server

apps/dav/tests/unit/Search/TasksSearchProviderTest.php

Indentation +290 added lines, -290 removed lines

@@ -22,294 +22,294 @@
 use Test\TestCase;
 
 class TasksSearchProviderTest extends TestCase {
-	private IAppManager&MockObject $appManager;
-	private IL10N&MockObject $l10n;
-	private IURLGenerator&MockObject $urlGenerator;
-	private CalDavBackend&MockObject $backend;
-	private TasksSearchProvider $provider;
-
-	// NO DUE NOR COMPLETED NOR SUMMARY
-	private static string $vTodo0 = 'BEGIN:VCALENDAR' . PHP_EOL .
-		'PRODID:TEST' . PHP_EOL .
-		'VERSION:2.0' . PHP_EOL .
-		'BEGIN:VTODO' . PHP_EOL .
-		'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
-		'DTSTAMP:20070313T123432Z' . PHP_EOL .
-		'STATUS:NEEDS-ACTION' . PHP_EOL .
-		'END:VTODO' . PHP_EOL .
-		'END:VCALENDAR';
-
-	// DUE AND COMPLETED
-	private static string $vTodo1 = 'BEGIN:VCALENDAR' . PHP_EOL .
-		'PRODID:TEST' . PHP_EOL .
-		'VERSION:2.0' . PHP_EOL .
-		'BEGIN:VTODO' . PHP_EOL .
-		'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
-		'DTSTAMP:20070313T123432Z' . PHP_EOL .
-		'COMPLETED:20070707T100000Z' . PHP_EOL .
-		'DUE;VALUE=DATE:20070501' . PHP_EOL .
-		'SUMMARY:Task title' . PHP_EOL .
-		'STATUS:NEEDS-ACTION' . PHP_EOL .
-		'END:VTODO' . PHP_EOL .
-		'END:VCALENDAR';
-
-	// COMPLETED ONLY
-	private static string $vTodo2 = 'BEGIN:VCALENDAR' . PHP_EOL .
-		'PRODID:TEST' . PHP_EOL .
-		'VERSION:2.0' . PHP_EOL .
-		'BEGIN:VTODO' . PHP_EOL .
-		'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
-		'DTSTAMP:20070313T123432Z' . PHP_EOL .
-		'COMPLETED:20070707T100000Z' . PHP_EOL .
-		'SUMMARY:Task title' . PHP_EOL .
-		'STATUS:NEEDS-ACTION' . PHP_EOL .
-		'END:VTODO' . PHP_EOL .
-		'END:VCALENDAR';
-
-	// DUE DATE
-	private static string $vTodo3 = 'BEGIN:VCALENDAR' . PHP_EOL .
-		'PRODID:TEST' . PHP_EOL .
-		'VERSION:2.0' . PHP_EOL .
-		'BEGIN:VTODO' . PHP_EOL .
-		'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
-		'DTSTAMP:20070313T123432Z' . PHP_EOL .
-		'DUE;VALUE=DATE:20070501' . PHP_EOL .
-		'SUMMARY:Task title' . PHP_EOL .
-		'STATUS:NEEDS-ACTION' . PHP_EOL .
-		'END:VTODO' . PHP_EOL .
-		'END:VCALENDAR';
-
-	// DUE DATETIME
-	private static string $vTodo4 = 'BEGIN:VCALENDAR' . PHP_EOL .
-		'PRODID:TEST' . PHP_EOL .
-		'VERSION:2.0' . PHP_EOL .
-		'BEGIN:VTODO' . PHP_EOL .
-		'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
-		'DTSTAMP:20070313T123432Z' . PHP_EOL .
-		'DUE:20070709T130000Z' . PHP_EOL .
-		'SUMMARY:Task title' . PHP_EOL .
-		'STATUS:NEEDS-ACTION' . PHP_EOL .
-		'END:VTODO' . PHP_EOL .
-		'END:VCALENDAR';
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->backend = $this->createMock(CalDavBackend::class);
-
-		$this->provider = new TasksSearchProvider(
-			$this->appManager,
-			$this->l10n,
-			$this->urlGenerator,
-			$this->backend
-		);
-	}
-
-	public function testGetId(): void {
-		$this->assertEquals('tasks', $this->provider->getId());
-	}
-
-	public function testGetName(): void {
-		$this->l10n->expects($this->exactly(1))
-			->method('t')
-			->with('Tasks')
-			->willReturnArgument(0);
-
-		$this->assertEquals('Tasks', $this->provider->getName());
-	}
-
-	public function testSearchAppDisabled(): void {
-		$user = $this->createMock(IUser::class);
-		$query = $this->createMock(ISearchQuery::class);
-		$this->appManager->expects($this->once())
-			->method('isEnabledForUser')
-			->with('tasks', $user)
-			->willReturn(false);
-		$this->l10n->expects($this->exactly(1))
-			->method('t')
-			->willReturnArgument(0);
-		$this->backend->expects($this->never())
-			->method('getCalendarsForUser');
-		$this->backend->expects($this->never())
-			->method('getSubscriptionsForUser');
-		$this->backend->expects($this->never())
-			->method('searchPrincipalUri');
-
-		$actual = $this->provider->search($user, $query);
-		$data = $actual->jsonSerialize();
-		$this->assertInstanceOf(SearchResult::class, $actual);
-		$this->assertEquals('Tasks', $data['name']);
-		$this->assertEmpty($data['entries']);
-		$this->assertFalse($data['isPaginated']);
-		$this->assertNull($data['cursor']);
-	}
-
-	public function testSearch(): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')->willReturn('john.doe');
-		$query = $this->createMock(ISearchQuery::class);
-		$query->method('getTerm')->willReturn('search term');
-		$query->method('getLimit')->willReturn(5);
-		$query->method('getCursor')->willReturn(20);
-		$this->appManager->expects($this->once())
-			->method('isEnabledForUser')
-			->with('tasks', $user)
-			->willReturn(true);
-		$this->l10n->method('t')->willReturnArgument(0);
-
-		$this->backend->expects($this->once())
-			->method('getCalendarsForUser')
-			->with('principals/users/john.doe')
-			->willReturn([
-				[
-					'id' => 99,
-					'principaluri' => 'principals/users/john.doe',
-					'uri' => 'calendar-uri-99',
-				], [
-					'id' => 123,
-					'principaluri' => 'principals/users/john.doe',
-					'uri' => 'calendar-uri-123',
-				]
-			]);
-		$this->backend->expects($this->once())
-			->method('getSubscriptionsForUser')
-			->with('principals/users/john.doe')
-			->willReturn([
-				[
-					'id' => 1337,
-					'principaluri' => 'principals/users/john.doe',
-					'uri' => 'subscription-uri-1337',
-				]
-			]);
-		$this->backend->expects($this->once())
-			->method('searchPrincipalUri')
-			->with('principals/users/john.doe', '', ['VTODO'],
-				['SUMMARY', 'DESCRIPTION', 'CATEGORIES'],
-				[],
-				['limit' => 5, 'offset' => 20, 'since' => null, 'until' => null])
-			->willReturn([
-				[
-					'calendarid' => 99,
-					'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
-					'uri' => 'todo0.ics',
-					'calendardata' => self::$vTodo0,
-				],
-				[
-					'calendarid' => 123,
-					'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
-					'uri' => 'todo1.ics',
-					'calendardata' => self::$vTodo1,
-				],
-				[
-					'calendarid' => 1337,
-					'calendartype' => CalDavBackend::CALENDAR_TYPE_SUBSCRIPTION,
-					'uri' => 'todo2.ics',
-					'calendardata' => self::$vTodo2,
-				]
-			]);
-
-		$provider = $this->getMockBuilder(TasksSearchProvider::class)
-			->setConstructorArgs([
-				$this->appManager,
-				$this->l10n,
-				$this->urlGenerator,
-				$this->backend,
-			])
-			->onlyMethods([
-				'getDeepLinkToTasksApp',
-				'generateSubline',
-			])
-			->getMock();
-
-		$provider->expects($this->exactly(3))
-			->method('generateSubline')
-			->willReturn('subline');
-		$provider->expects($this->exactly(3))
-			->method('getDeepLinkToTasksApp')
-			->willReturnMap([
-				['calendar-uri-99', 'todo0.ics', 'deep-link-to-tasks'],
-				['calendar-uri-123', 'todo1.ics', 'deep-link-to-tasks'],
-				['subscription-uri-1337', 'todo2.ics', 'deep-link-to-tasks']
-			]);
-
-		$actual = $provider->search($user, $query);
-		$data = $actual->jsonSerialize();
-		$this->assertInstanceOf(SearchResult::class, $actual);
-		$this->assertEquals('Tasks', $data['name']);
-		$this->assertCount(3, $data['entries']);
-		$this->assertTrue($data['isPaginated']);
-		$this->assertEquals(23, $data['cursor']);
-
-		$result0 = $data['entries'][0];
-		$result0Data = $result0->jsonSerialize();
-		$result1 = $data['entries'][1];
-		$result1Data = $result1->jsonSerialize();
-		$result2 = $data['entries'][2];
-		$result2Data = $result2->jsonSerialize();
-
-		$this->assertInstanceOf(SearchResultEntry::class, $result0);
-		$this->assertEmpty($result0Data['thumbnailUrl']);
-		$this->assertEquals('Untitled task', $result0Data['title']);
-		$this->assertEquals('subline', $result0Data['subline']);
-		$this->assertEquals('deep-link-to-tasks', $result0Data['resourceUrl']);
-		$this->assertEquals('icon-checkmark', $result0Data['icon']);
-		$this->assertFalse($result0Data['rounded']);
-
-		$this->assertInstanceOf(SearchResultEntry::class, $result1);
-		$this->assertEmpty($result1Data['thumbnailUrl']);
-		$this->assertEquals('Task title', $result1Data['title']);
-		$this->assertEquals('subline', $result1Data['subline']);
-		$this->assertEquals('deep-link-to-tasks', $result1Data['resourceUrl']);
-		$this->assertEquals('icon-checkmark', $result1Data['icon']);
-		$this->assertFalse($result1Data['rounded']);
-
-		$this->assertInstanceOf(SearchResultEntry::class, $result2);
-		$this->assertEmpty($result2Data['thumbnailUrl']);
-		$this->assertEquals('Task title', $result2Data['title']);
-		$this->assertEquals('subline', $result2Data['subline']);
-		$this->assertEquals('deep-link-to-tasks', $result2Data['resourceUrl']);
-		$this->assertEquals('icon-checkmark', $result2Data['icon']);
-		$this->assertFalse($result2Data['rounded']);
-	}
-
-	public function testGetDeepLinkToTasksApp(): void {
-		$this->urlGenerator->expects($this->once())
-			->method('linkToRoute')
-			->with('tasks.page.index')
-			->willReturn('link-to-route-tasks.index');
-		$this->urlGenerator->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics')
-			->willReturn('absolute-url-link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics');
-
-		$actual = self::invokePrivate($this->provider, 'getDeepLinkToTasksApp', ['uri-john.doe', 'task-uri.ics']);
-		$this->assertEquals('absolute-url-link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics', $actual);
-	}
-
-	/**
-	 * @dataProvider generateSublineDataProvider
-	 */
-	public function testGenerateSubline(string $ics, string $expectedSubline): void {
-		$vCalendar = Reader::read($ics, Reader::OPTION_FORGIVING);
-		$taskComponent = $vCalendar->VTODO;
-
-		$this->l10n->method('t')->willReturnArgument(0);
-		$this->l10n->method('l')->willReturnArgument(0);
-
-		$actual = self::invokePrivate($this->provider, 'generateSubline', [$taskComponent]);
-		$this->assertEquals($expectedSubline, $actual);
-	}
-
-	public static function generateSublineDataProvider(): array {
-		return [
-			[self::$vTodo0, ''],
-			[self::$vTodo1, 'Completed on %s'],
-			[self::$vTodo2, 'Completed on %s'],
-			[self::$vTodo3, 'Due on %s'],
-			[self::$vTodo4, 'Due on %s by %s'],
-		];
-	}
+    private IAppManager&MockObject $appManager;
+    private IL10N&MockObject $l10n;
+    private IURLGenerator&MockObject $urlGenerator;
+    private CalDavBackend&MockObject $backend;
+    private TasksSearchProvider $provider;
+
+    // NO DUE NOR COMPLETED NOR SUMMARY
+    private static string $vTodo0 = 'BEGIN:VCALENDAR' . PHP_EOL .
+        'PRODID:TEST' . PHP_EOL .
+        'VERSION:2.0' . PHP_EOL .
+        'BEGIN:VTODO' . PHP_EOL .
+        'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
+        'DTSTAMP:20070313T123432Z' . PHP_EOL .
+        'STATUS:NEEDS-ACTION' . PHP_EOL .
+        'END:VTODO' . PHP_EOL .
+        'END:VCALENDAR';
+
+    // DUE AND COMPLETED
+    private static string $vTodo1 = 'BEGIN:VCALENDAR' . PHP_EOL .
+        'PRODID:TEST' . PHP_EOL .
+        'VERSION:2.0' . PHP_EOL .
+        'BEGIN:VTODO' . PHP_EOL .
+        'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
+        'DTSTAMP:20070313T123432Z' . PHP_EOL .
+        'COMPLETED:20070707T100000Z' . PHP_EOL .
+        'DUE;VALUE=DATE:20070501' . PHP_EOL .
+        'SUMMARY:Task title' . PHP_EOL .
+        'STATUS:NEEDS-ACTION' . PHP_EOL .
+        'END:VTODO' . PHP_EOL .
+        'END:VCALENDAR';
+
+    // COMPLETED ONLY
+    private static string $vTodo2 = 'BEGIN:VCALENDAR' . PHP_EOL .
+        'PRODID:TEST' . PHP_EOL .
+        'VERSION:2.0' . PHP_EOL .
+        'BEGIN:VTODO' . PHP_EOL .
+        'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
+        'DTSTAMP:20070313T123432Z' . PHP_EOL .
+        'COMPLETED:20070707T100000Z' . PHP_EOL .
+        'SUMMARY:Task title' . PHP_EOL .
+        'STATUS:NEEDS-ACTION' . PHP_EOL .
+        'END:VTODO' . PHP_EOL .
+        'END:VCALENDAR';
+
+    // DUE DATE
+    private static string $vTodo3 = 'BEGIN:VCALENDAR' . PHP_EOL .
+        'PRODID:TEST' . PHP_EOL .
+        'VERSION:2.0' . PHP_EOL .
+        'BEGIN:VTODO' . PHP_EOL .
+        'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
+        'DTSTAMP:20070313T123432Z' . PHP_EOL .
+        'DUE;VALUE=DATE:20070501' . PHP_EOL .
+        'SUMMARY:Task title' . PHP_EOL .
+        'STATUS:NEEDS-ACTION' . PHP_EOL .
+        'END:VTODO' . PHP_EOL .
+        'END:VCALENDAR';
+
+    // DUE DATETIME
+    private static string $vTodo4 = 'BEGIN:VCALENDAR' . PHP_EOL .
+        'PRODID:TEST' . PHP_EOL .
+        'VERSION:2.0' . PHP_EOL .
+        'BEGIN:VTODO' . PHP_EOL .
+        'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
+        'DTSTAMP:20070313T123432Z' . PHP_EOL .
+        'DUE:20070709T130000Z' . PHP_EOL .
+        'SUMMARY:Task title' . PHP_EOL .
+        'STATUS:NEEDS-ACTION' . PHP_EOL .
+        'END:VTODO' . PHP_EOL .
+        'END:VCALENDAR';
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->backend = $this->createMock(CalDavBackend::class);
+
+        $this->provider = new TasksSearchProvider(
+            $this->appManager,
+            $this->l10n,
+            $this->urlGenerator,
+            $this->backend
+        );
+    }
+
+    public function testGetId(): void {
+        $this->assertEquals('tasks', $this->provider->getId());
+    }
+
+    public function testGetName(): void {
+        $this->l10n->expects($this->exactly(1))
+            ->method('t')
+            ->with('Tasks')
+            ->willReturnArgument(0);
+
+        $this->assertEquals('Tasks', $this->provider->getName());
+    }
+
+    public function testSearchAppDisabled(): void {
+        $user = $this->createMock(IUser::class);
+        $query = $this->createMock(ISearchQuery::class);
+        $this->appManager->expects($this->once())
+            ->method('isEnabledForUser')
+            ->with('tasks', $user)
+            ->willReturn(false);
+        $this->l10n->expects($this->exactly(1))
+            ->method('t')
+            ->willReturnArgument(0);
+        $this->backend->expects($this->never())
+            ->method('getCalendarsForUser');
+        $this->backend->expects($this->never())
+            ->method('getSubscriptionsForUser');
+        $this->backend->expects($this->never())
+            ->method('searchPrincipalUri');
+
+        $actual = $this->provider->search($user, $query);
+        $data = $actual->jsonSerialize();
+        $this->assertInstanceOf(SearchResult::class, $actual);
+        $this->assertEquals('Tasks', $data['name']);
+        $this->assertEmpty($data['entries']);
+        $this->assertFalse($data['isPaginated']);
+        $this->assertNull($data['cursor']);
+    }
+
+    public function testSearch(): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')->willReturn('john.doe');
+        $query = $this->createMock(ISearchQuery::class);
+        $query->method('getTerm')->willReturn('search term');
+        $query->method('getLimit')->willReturn(5);
+        $query->method('getCursor')->willReturn(20);
+        $this->appManager->expects($this->once())
+            ->method('isEnabledForUser')
+            ->with('tasks', $user)
+            ->willReturn(true);
+        $this->l10n->method('t')->willReturnArgument(0);
+
+        $this->backend->expects($this->once())
+            ->method('getCalendarsForUser')
+            ->with('principals/users/john.doe')
+            ->willReturn([
+                [
+                    'id' => 99,
+                    'principaluri' => 'principals/users/john.doe',
+                    'uri' => 'calendar-uri-99',
+                ], [
+                    'id' => 123,
+                    'principaluri' => 'principals/users/john.doe',
+                    'uri' => 'calendar-uri-123',
+                ]
+            ]);
+        $this->backend->expects($this->once())
+            ->method('getSubscriptionsForUser')
+            ->with('principals/users/john.doe')
+            ->willReturn([
+                [
+                    'id' => 1337,
+                    'principaluri' => 'principals/users/john.doe',
+                    'uri' => 'subscription-uri-1337',
+                ]
+            ]);
+        $this->backend->expects($this->once())
+            ->method('searchPrincipalUri')
+            ->with('principals/users/john.doe', '', ['VTODO'],
+                ['SUMMARY', 'DESCRIPTION', 'CATEGORIES'],
+                [],
+                ['limit' => 5, 'offset' => 20, 'since' => null, 'until' => null])
+            ->willReturn([
+                [
+                    'calendarid' => 99,
+                    'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
+                    'uri' => 'todo0.ics',
+                    'calendardata' => self::$vTodo0,
+                ],
+                [
+                    'calendarid' => 123,
+                    'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
+                    'uri' => 'todo1.ics',
+                    'calendardata' => self::$vTodo1,
+                ],
+                [
+                    'calendarid' => 1337,
+                    'calendartype' => CalDavBackend::CALENDAR_TYPE_SUBSCRIPTION,
+                    'uri' => 'todo2.ics',
+                    'calendardata' => self::$vTodo2,
+                ]
+            ]);
+
+        $provider = $this->getMockBuilder(TasksSearchProvider::class)
+            ->setConstructorArgs([
+                $this->appManager,
+                $this->l10n,
+                $this->urlGenerator,
+                $this->backend,
+            ])
+            ->onlyMethods([
+                'getDeepLinkToTasksApp',
+                'generateSubline',
+            ])
+            ->getMock();
+
+        $provider->expects($this->exactly(3))
+            ->method('generateSubline')
+            ->willReturn('subline');
+        $provider->expects($this->exactly(3))
+            ->method('getDeepLinkToTasksApp')
+            ->willReturnMap([
+                ['calendar-uri-99', 'todo0.ics', 'deep-link-to-tasks'],
+                ['calendar-uri-123', 'todo1.ics', 'deep-link-to-tasks'],
+                ['subscription-uri-1337', 'todo2.ics', 'deep-link-to-tasks']
+            ]);
+
+        $actual = $provider->search($user, $query);
+        $data = $actual->jsonSerialize();
+        $this->assertInstanceOf(SearchResult::class, $actual);
+        $this->assertEquals('Tasks', $data['name']);
+        $this->assertCount(3, $data['entries']);
+        $this->assertTrue($data['isPaginated']);
+        $this->assertEquals(23, $data['cursor']);
+
+        $result0 = $data['entries'][0];
+        $result0Data = $result0->jsonSerialize();
+        $result1 = $data['entries'][1];
+        $result1Data = $result1->jsonSerialize();
+        $result2 = $data['entries'][2];
+        $result2Data = $result2->jsonSerialize();
+
+        $this->assertInstanceOf(SearchResultEntry::class, $result0);
+        $this->assertEmpty($result0Data['thumbnailUrl']);
+        $this->assertEquals('Untitled task', $result0Data['title']);
+        $this->assertEquals('subline', $result0Data['subline']);
+        $this->assertEquals('deep-link-to-tasks', $result0Data['resourceUrl']);
+        $this->assertEquals('icon-checkmark', $result0Data['icon']);
+        $this->assertFalse($result0Data['rounded']);
+
+        $this->assertInstanceOf(SearchResultEntry::class, $result1);
+        $this->assertEmpty($result1Data['thumbnailUrl']);
+        $this->assertEquals('Task title', $result1Data['title']);
+        $this->assertEquals('subline', $result1Data['subline']);
+        $this->assertEquals('deep-link-to-tasks', $result1Data['resourceUrl']);
+        $this->assertEquals('icon-checkmark', $result1Data['icon']);
+        $this->assertFalse($result1Data['rounded']);
+
+        $this->assertInstanceOf(SearchResultEntry::class, $result2);
+        $this->assertEmpty($result2Data['thumbnailUrl']);
+        $this->assertEquals('Task title', $result2Data['title']);
+        $this->assertEquals('subline', $result2Data['subline']);
+        $this->assertEquals('deep-link-to-tasks', $result2Data['resourceUrl']);
+        $this->assertEquals('icon-checkmark', $result2Data['icon']);
+        $this->assertFalse($result2Data['rounded']);
+    }
+
+    public function testGetDeepLinkToTasksApp(): void {
+        $this->urlGenerator->expects($this->once())
+            ->method('linkToRoute')
+            ->with('tasks.page.index')
+            ->willReturn('link-to-route-tasks.index');
+        $this->urlGenerator->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics')
+            ->willReturn('absolute-url-link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics');
+
+        $actual = self::invokePrivate($this->provider, 'getDeepLinkToTasksApp', ['uri-john.doe', 'task-uri.ics']);
+        $this->assertEquals('absolute-url-link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics', $actual);
+    }
+
+    /**
+     * @dataProvider generateSublineDataProvider
+     */
+    public function testGenerateSubline(string $ics, string $expectedSubline): void {
+        $vCalendar = Reader::read($ics, Reader::OPTION_FORGIVING);
+        $taskComponent = $vCalendar->VTODO;
+
+        $this->l10n->method('t')->willReturnArgument(0);
+        $this->l10n->method('l')->willReturnArgument(0);
+
+        $actual = self::invokePrivate($this->provider, 'generateSubline', [$taskComponent]);
+        $this->assertEquals($expectedSubline, $actual);
+    }
+
+    public static function generateSublineDataProvider(): array {
+        return [
+            [self::$vTodo0, ''],
+            [self::$vTodo1, 'Completed on %s'],
+            [self::$vTodo2, 'Completed on %s'],
+            [self::$vTodo3, 'Due on %s'],
+            [self::$vTodo4, 'Due on %s by %s'],
+        ];
+    }
 }

Spacing +49 added lines, -49 removed lines

@@ -29,67 +29,67 @@
 	private TasksSearchProvider $provider;
 
 	// NO DUE NOR COMPLETED NOR SUMMARY
-	private static string $vTodo0 = 'BEGIN:VCALENDAR' . PHP_EOL .
-		'PRODID:TEST' . PHP_EOL .
-		'VERSION:2.0' . PHP_EOL .
-		'BEGIN:VTODO' . PHP_EOL .
-		'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
-		'DTSTAMP:20070313T123432Z' . PHP_EOL .
-		'STATUS:NEEDS-ACTION' . PHP_EOL .
-		'END:VTODO' . PHP_EOL .
+	private static string $vTodo0 = 'BEGIN:VCALENDAR'.PHP_EOL.
+		'PRODID:TEST'.PHP_EOL.
+		'VERSION:2.0'.PHP_EOL.
+		'BEGIN:VTODO'.PHP_EOL.
+		'UID:20070313T123432Z-456553@example.com'.PHP_EOL.
+		'DTSTAMP:20070313T123432Z'.PHP_EOL.
+		'STATUS:NEEDS-ACTION'.PHP_EOL.
+		'END:VTODO'.PHP_EOL.
 		'END:VCALENDAR';
 
 	// DUE AND COMPLETED
-	private static string $vTodo1 = 'BEGIN:VCALENDAR' . PHP_EOL .
-		'PRODID:TEST' . PHP_EOL .
-		'VERSION:2.0' . PHP_EOL .
-		'BEGIN:VTODO' . PHP_EOL .
-		'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
-		'DTSTAMP:20070313T123432Z' . PHP_EOL .
-		'COMPLETED:20070707T100000Z' . PHP_EOL .
-		'DUE;VALUE=DATE:20070501' . PHP_EOL .
-		'SUMMARY:Task title' . PHP_EOL .
-		'STATUS:NEEDS-ACTION' . PHP_EOL .
-		'END:VTODO' . PHP_EOL .
+	private static string $vTodo1 = 'BEGIN:VCALENDAR'.PHP_EOL.
+		'PRODID:TEST'.PHP_EOL.
+		'VERSION:2.0'.PHP_EOL.
+		'BEGIN:VTODO'.PHP_EOL.
+		'UID:20070313T123432Z-456553@example.com'.PHP_EOL.
+		'DTSTAMP:20070313T123432Z'.PHP_EOL.
+		'COMPLETED:20070707T100000Z'.PHP_EOL.
+		'DUE;VALUE=DATE:20070501'.PHP_EOL.
+		'SUMMARY:Task title'.PHP_EOL.
+		'STATUS:NEEDS-ACTION'.PHP_EOL.
+		'END:VTODO'.PHP_EOL.
 		'END:VCALENDAR';
 
 	// COMPLETED ONLY
-	private static string $vTodo2 = 'BEGIN:VCALENDAR' . PHP_EOL .
-		'PRODID:TEST' . PHP_EOL .
-		'VERSION:2.0' . PHP_EOL .
-		'BEGIN:VTODO' . PHP_EOL .
-		'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
-		'DTSTAMP:20070313T123432Z' . PHP_EOL .
-		'COMPLETED:20070707T100000Z' . PHP_EOL .
-		'SUMMARY:Task title' . PHP_EOL .
-		'STATUS:NEEDS-ACTION' . PHP_EOL .
-		'END:VTODO' . PHP_EOL .
+	private static string $vTodo2 = 'BEGIN:VCALENDAR'.PHP_EOL.
+		'PRODID:TEST'.PHP_EOL.
+		'VERSION:2.0'.PHP_EOL.
+		'BEGIN:VTODO'.PHP_EOL.
+		'UID:20070313T123432Z-456553@example.com'.PHP_EOL.
+		'DTSTAMP:20070313T123432Z'.PHP_EOL.
+		'COMPLETED:20070707T100000Z'.PHP_EOL.
+		'SUMMARY:Task title'.PHP_EOL.
+		'STATUS:NEEDS-ACTION'.PHP_EOL.
+		'END:VTODO'.PHP_EOL.
 		'END:VCALENDAR';
 
 	// DUE DATE
-	private static string $vTodo3 = 'BEGIN:VCALENDAR' . PHP_EOL .
-		'PRODID:TEST' . PHP_EOL .
-		'VERSION:2.0' . PHP_EOL .
-		'BEGIN:VTODO' . PHP_EOL .
-		'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
-		'DTSTAMP:20070313T123432Z' . PHP_EOL .
-		'DUE;VALUE=DATE:20070501' . PHP_EOL .
-		'SUMMARY:Task title' . PHP_EOL .
-		'STATUS:NEEDS-ACTION' . PHP_EOL .
-		'END:VTODO' . PHP_EOL .
+	private static string $vTodo3 = 'BEGIN:VCALENDAR'.PHP_EOL.
+		'PRODID:TEST'.PHP_EOL.
+		'VERSION:2.0'.PHP_EOL.
+		'BEGIN:VTODO'.PHP_EOL.
+		'UID:20070313T123432Z-456553@example.com'.PHP_EOL.
+		'DTSTAMP:20070313T123432Z'.PHP_EOL.
+		'DUE;VALUE=DATE:20070501'.PHP_EOL.
+		'SUMMARY:Task title'.PHP_EOL.
+		'STATUS:NEEDS-ACTION'.PHP_EOL.
+		'END:VTODO'.PHP_EOL.
 		'END:VCALENDAR';
 
 	// DUE DATETIME
-	private static string $vTodo4 = 'BEGIN:VCALENDAR' . PHP_EOL .
-		'PRODID:TEST' . PHP_EOL .
-		'VERSION:2.0' . PHP_EOL .
-		'BEGIN:VTODO' . PHP_EOL .
-		'UID:20070313T123432Z-456553@example.com' . PHP_EOL .
-		'DTSTAMP:20070313T123432Z' . PHP_EOL .
-		'DUE:20070709T130000Z' . PHP_EOL .
-		'SUMMARY:Task title' . PHP_EOL .
-		'STATUS:NEEDS-ACTION' . PHP_EOL .
-		'END:VTODO' . PHP_EOL .
+	private static string $vTodo4 = 'BEGIN:VCALENDAR'.PHP_EOL.
+		'PRODID:TEST'.PHP_EOL.
+		'VERSION:2.0'.PHP_EOL.
+		'BEGIN:VTODO'.PHP_EOL.
+		'UID:20070313T123432Z-456553@example.com'.PHP_EOL.
+		'DTSTAMP:20070313T123432Z'.PHP_EOL.
+		'DUE:20070709T130000Z'.PHP_EOL.
+		'SUMMARY:Task title'.PHP_EOL.
+		'STATUS:NEEDS-ACTION'.PHP_EOL.
+		'END:VTODO'.PHP_EOL.
 		'END:VCALENDAR';
 
 	protected function setUp(): void {

apps/dav/tests/unit/Search/ContactsSearchProviderTest.php

Indentation +207 added lines, -207 removed lines

@@ -22,238 +22,238 @@
 use Test\TestCase;
 
 class ContactsSearchProviderTest extends TestCase {
-	private IAppManager&MockObject $appManager;
-	private IL10N&MockObject $l10n;
-	private IURLGenerator&MockObject $urlGenerator;
-	private CardDavBackend&MockObject $backend;
-	private ContactsSearchProvider $provider;
+    private IAppManager&MockObject $appManager;
+    private IL10N&MockObject $l10n;
+    private IURLGenerator&MockObject $urlGenerator;
+    private CardDavBackend&MockObject $backend;
+    private ContactsSearchProvider $provider;
 
-	private string $vcardTest0 = 'BEGIN:VCARD' . PHP_EOL .
-		'VERSION:3.0' . PHP_EOL .
-		'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL .
-		'UID:Test' . PHP_EOL .
-		'FN:FN of Test' . PHP_EOL .
-		'N:Test;;;;' . PHP_EOL .
-		'EMAIL:forrestgump@example.com' . PHP_EOL .
-		'END:VCARD';
+    private string $vcardTest0 = 'BEGIN:VCARD' . PHP_EOL .
+        'VERSION:3.0' . PHP_EOL .
+        'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL .
+        'UID:Test' . PHP_EOL .
+        'FN:FN of Test' . PHP_EOL .
+        'N:Test;;;;' . PHP_EOL .
+        'EMAIL:forrestgump@example.com' . PHP_EOL .
+        'END:VCARD';
 
-	private string $vcardTest1 = 'BEGIN:VCARD' . PHP_EOL .
-		'VERSION:3.0' . PHP_EOL .
-		'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL .
-		'PHOTO;ENCODING=b;TYPE=image/jpeg:' . PHP_EOL .
-		'UID:Test2' . PHP_EOL .
-		'FN:FN of Test2' . PHP_EOL .
-		'N:Test2;;;;' . PHP_EOL .
-		'END:VCARD';
+    private string $vcardTest1 = 'BEGIN:VCARD' . PHP_EOL .
+        'VERSION:3.0' . PHP_EOL .
+        'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL .
+        'PHOTO;ENCODING=b;TYPE=image/jpeg:' . PHP_EOL .
+        'UID:Test2' . PHP_EOL .
+        'FN:FN of Test2' . PHP_EOL .
+        'N:Test2;;;;' . PHP_EOL .
+        'END:VCARD';
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->backend = $this->createMock(CardDavBackend::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->backend = $this->createMock(CardDavBackend::class);
 
-		$this->provider = new ContactsSearchProvider(
-			$this->appManager,
-			$this->l10n,
-			$this->urlGenerator,
-			$this->backend
-		);
-	}
+        $this->provider = new ContactsSearchProvider(
+            $this->appManager,
+            $this->l10n,
+            $this->urlGenerator,
+            $this->backend
+        );
+    }
 
-	public function testGetId(): void {
-		$this->assertEquals('contacts', $this->provider->getId());
-	}
+    public function testGetId(): void {
+        $this->assertEquals('contacts', $this->provider->getId());
+    }
 
-	public function testGetName(): void {
-		$this->l10n->expects($this->exactly(1))
-			->method('t')
-			->with('Contacts')
-			->willReturnArgument(0);
+    public function testGetName(): void {
+        $this->l10n->expects($this->exactly(1))
+            ->method('t')
+            ->with('Contacts')
+            ->willReturnArgument(0);
 
-		$this->assertEquals('Contacts', $this->provider->getName());
-	}
+        $this->assertEquals('Contacts', $this->provider->getName());
+    }
 
-	public function testSearchAppDisabled(): void {
-		$user = $this->createMock(IUser::class);
-		$query = $this->createMock(ISearchQuery::class);
-		$this->appManager->expects($this->once())
-			->method('isEnabledForUser')
-			->with('contacts', $user)
-			->willReturn(false);
-		$this->l10n->expects($this->exactly(1))
-			->method('t')
-			->with('Contacts')
-			->willReturnArgument(0);
-		$this->backend->expects($this->never())
-			->method('getAddressBooksForUser');
-		$this->backend->expects($this->never())
-			->method('searchPrincipalUri');
+    public function testSearchAppDisabled(): void {
+        $user = $this->createMock(IUser::class);
+        $query = $this->createMock(ISearchQuery::class);
+        $this->appManager->expects($this->once())
+            ->method('isEnabledForUser')
+            ->with('contacts', $user)
+            ->willReturn(false);
+        $this->l10n->expects($this->exactly(1))
+            ->method('t')
+            ->with('Contacts')
+            ->willReturnArgument(0);
+        $this->backend->expects($this->never())
+            ->method('getAddressBooksForUser');
+        $this->backend->expects($this->never())
+            ->method('searchPrincipalUri');
 
-		$actual = $this->provider->search($user, $query);
-		$data = $actual->jsonSerialize();
-		$this->assertInstanceOf(SearchResult::class, $actual);
-		$this->assertEquals('Contacts', $data['name']);
-		$this->assertEmpty($data['entries']);
-		$this->assertFalse($data['isPaginated']);
-		$this->assertNull($data['cursor']);
-	}
+        $actual = $this->provider->search($user, $query);
+        $data = $actual->jsonSerialize();
+        $this->assertInstanceOf(SearchResult::class, $actual);
+        $this->assertEquals('Contacts', $data['name']);
+        $this->assertEmpty($data['entries']);
+        $this->assertFalse($data['isPaginated']);
+        $this->assertNull($data['cursor']);
+    }
 
-	public function testSearch(): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')->willReturn('john.doe');
-		$query = $this->createMock(ISearchQuery::class);
-		$query->method('getTerm')->willReturn('search term');
-		$query->method('getLimit')->willReturn(5);
-		$query->method('getCursor')->willReturn(20);
-		$this->appManager->expects($this->once())
-			->method('isEnabledForUser')
-			->with('contacts', $user)
-			->willReturn(true);
-		$this->l10n->expects($this->exactly(1))
-			->method('t')
-			->with('Contacts')
-			->willReturnArgument(0);
+    public function testSearch(): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')->willReturn('john.doe');
+        $query = $this->createMock(ISearchQuery::class);
+        $query->method('getTerm')->willReturn('search term');
+        $query->method('getLimit')->willReturn(5);
+        $query->method('getCursor')->willReturn(20);
+        $this->appManager->expects($this->once())
+            ->method('isEnabledForUser')
+            ->with('contacts', $user)
+            ->willReturn(true);
+        $this->l10n->expects($this->exactly(1))
+            ->method('t')
+            ->with('Contacts')
+            ->willReturnArgument(0);
 
-		$this->backend->expects($this->once())
-			->method('getAddressBooksForUser')
-			->with('principals/users/john.doe')
-			->willReturn([
-				[
-					'id' => 99,
-					'principaluri' => 'principals/users/john.doe',
-					'uri' => 'addressbook-uri-99',
-				], [
-					'id' => 123,
-					'principaluri' => 'principals/users/john.doe',
-					'uri' => 'addressbook-uri-123',
-				]
-			]);
-		$this->backend->expects($this->once())
-			->method('searchPrincipalUri')
-			->with('principals/users/john.doe', '',
-				[
-					'N',
-					'FN',
-					'NICKNAME',
-					'EMAIL',
-					'TEL',
-					'ADR',
-					'TITLE',
-					'ORG',
-					'NOTE',
-				],
-				['limit' => 5, 'offset' => 20, 'since' => null, 'until' => null,  'person' => null, 'company' => null])
-			->willReturn([
-				[
-					'addressbookid' => 99,
-					'uri' => 'vcard0.vcf',
-					'carddata' => $this->vcardTest0,
-				],
-				[
-					'addressbookid' => 123,
-					'uri' => 'vcard1.vcf',
-					'carddata' => $this->vcardTest1,
-				],
-			]);
+        $this->backend->expects($this->once())
+            ->method('getAddressBooksForUser')
+            ->with('principals/users/john.doe')
+            ->willReturn([
+                [
+                    'id' => 99,
+                    'principaluri' => 'principals/users/john.doe',
+                    'uri' => 'addressbook-uri-99',
+                ], [
+                    'id' => 123,
+                    'principaluri' => 'principals/users/john.doe',
+                    'uri' => 'addressbook-uri-123',
+                ]
+            ]);
+        $this->backend->expects($this->once())
+            ->method('searchPrincipalUri')
+            ->with('principals/users/john.doe', '',
+                [
+                    'N',
+                    'FN',
+                    'NICKNAME',
+                    'EMAIL',
+                    'TEL',
+                    'ADR',
+                    'TITLE',
+                    'ORG',
+                    'NOTE',
+                ],
+                ['limit' => 5, 'offset' => 20, 'since' => null, 'until' => null,  'person' => null, 'company' => null])
+            ->willReturn([
+                [
+                    'addressbookid' => 99,
+                    'uri' => 'vcard0.vcf',
+                    'carddata' => $this->vcardTest0,
+                ],
+                [
+                    'addressbookid' => 123,
+                    'uri' => 'vcard1.vcf',
+                    'carddata' => $this->vcardTest1,
+                ],
+            ]);
 
-		$provider = $this->getMockBuilder(ContactsSearchProvider::class)
-			->setConstructorArgs([
-				$this->appManager,
-				$this->l10n,
-				$this->urlGenerator,
-				$this->backend,
-			])
-			->onlyMethods([
-				'getDavUrlForContact',
-				'getDeepLinkToContactsApp',
-				'generateSubline',
-			])
-			->getMock();
+        $provider = $this->getMockBuilder(ContactsSearchProvider::class)
+            ->setConstructorArgs([
+                $this->appManager,
+                $this->l10n,
+                $this->urlGenerator,
+                $this->backend,
+            ])
+            ->onlyMethods([
+                'getDavUrlForContact',
+                'getDeepLinkToContactsApp',
+                'generateSubline',
+            ])
+            ->getMock();
 
-		$provider->expects($this->once())
-			->method('getDavUrlForContact')
-			->with('principals/users/john.doe', 'addressbook-uri-123', 'vcard1.vcf')
-			->willReturn('absolute-thumbnail-url');
+        $provider->expects($this->once())
+            ->method('getDavUrlForContact')
+            ->with('principals/users/john.doe', 'addressbook-uri-123', 'vcard1.vcf')
+            ->willReturn('absolute-thumbnail-url');
 
-		$provider->expects($this->exactly(2))
-			->method('generateSubline')
-			->willReturn('subline');
-		$provider->expects($this->exactly(2))
-			->method('getDeepLinkToContactsApp')
-			->willReturnMap([
-				['addressbook-uri-99', 'Test', 'deep-link-to-contacts'],
-				['addressbook-uri-123', 'Test2', 'deep-link-to-contacts'],
-			]);
+        $provider->expects($this->exactly(2))
+            ->method('generateSubline')
+            ->willReturn('subline');
+        $provider->expects($this->exactly(2))
+            ->method('getDeepLinkToContactsApp')
+            ->willReturnMap([
+                ['addressbook-uri-99', 'Test', 'deep-link-to-contacts'],
+                ['addressbook-uri-123', 'Test2', 'deep-link-to-contacts'],
+            ]);
 
-		$actual = $provider->search($user, $query);
-		$data = $actual->jsonSerialize();
-		$this->assertInstanceOf(SearchResult::class, $actual);
-		$this->assertEquals('Contacts', $data['name']);
-		$this->assertCount(2, $data['entries']);
-		$this->assertTrue($data['isPaginated']);
-		$this->assertEquals(22, $data['cursor']);
+        $actual = $provider->search($user, $query);
+        $data = $actual->jsonSerialize();
+        $this->assertInstanceOf(SearchResult::class, $actual);
+        $this->assertEquals('Contacts', $data['name']);
+        $this->assertCount(2, $data['entries']);
+        $this->assertTrue($data['isPaginated']);
+        $this->assertEquals(22, $data['cursor']);
 
-		$result0 = $data['entries'][0];
-		$result0Data = $result0->jsonSerialize();
-		$result1 = $data['entries'][1];
-		$result1Data = $result1->jsonSerialize();
+        $result0 = $data['entries'][0];
+        $result0Data = $result0->jsonSerialize();
+        $result1 = $data['entries'][1];
+        $result1Data = $result1->jsonSerialize();
 
-		$this->assertInstanceOf(SearchResultEntry::class, $result0);
-		$this->assertEquals('', $result0Data['thumbnailUrl']);
-		$this->assertEquals('FN of Test', $result0Data['title']);
-		$this->assertEquals('subline', $result0Data['subline']);
-		$this->assertEquals('deep-link-to-contacts', $result0Data['resourceUrl']);
-		$this->assertEquals('icon-contacts-dark', $result0Data['icon']);
-		$this->assertTrue($result0Data['rounded']);
+        $this->assertInstanceOf(SearchResultEntry::class, $result0);
+        $this->assertEquals('', $result0Data['thumbnailUrl']);
+        $this->assertEquals('FN of Test', $result0Data['title']);
+        $this->assertEquals('subline', $result0Data['subline']);
+        $this->assertEquals('deep-link-to-contacts', $result0Data['resourceUrl']);
+        $this->assertEquals('icon-contacts-dark', $result0Data['icon']);
+        $this->assertTrue($result0Data['rounded']);
 
-		$this->assertInstanceOf(SearchResultEntry::class, $result1);
-		$this->assertEquals('absolute-thumbnail-url?photo', $result1Data['thumbnailUrl']);
-		$this->assertEquals('FN of Test2', $result1Data['title']);
-		$this->assertEquals('subline', $result1Data['subline']);
-		$this->assertEquals('deep-link-to-contacts', $result1Data['resourceUrl']);
-		$this->assertEquals('icon-contacts-dark', $result1Data['icon']);
-		$this->assertTrue($result1Data['rounded']);
-	}
+        $this->assertInstanceOf(SearchResultEntry::class, $result1);
+        $this->assertEquals('absolute-thumbnail-url?photo', $result1Data['thumbnailUrl']);
+        $this->assertEquals('FN of Test2', $result1Data['title']);
+        $this->assertEquals('subline', $result1Data['subline']);
+        $this->assertEquals('deep-link-to-contacts', $result1Data['resourceUrl']);
+        $this->assertEquals('icon-contacts-dark', $result1Data['icon']);
+        $this->assertTrue($result1Data['rounded']);
+    }
 
-	public function testGetDavUrlForContact(): void {
-		$this->urlGenerator->expects($this->once())
-			->method('linkTo')
-			->with('', 'remote.php')
-			->willReturn('link-to-remote.php');
-		$this->urlGenerator->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('link-to-remote.php/dav/addressbooks/users/john.doe/foo/bar.vcf')
-			->willReturn('absolute-url-link-to-remote.php/dav/addressbooks/users/john.doe/foo/bar.vcf');
+    public function testGetDavUrlForContact(): void {
+        $this->urlGenerator->expects($this->once())
+            ->method('linkTo')
+            ->with('', 'remote.php')
+            ->willReturn('link-to-remote.php');
+        $this->urlGenerator->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('link-to-remote.php/dav/addressbooks/users/john.doe/foo/bar.vcf')
+            ->willReturn('absolute-url-link-to-remote.php/dav/addressbooks/users/john.doe/foo/bar.vcf');
 
-		$actual = self::invokePrivate($this->provider, 'getDavUrlForContact', ['principals/users/john.doe', 'foo', 'bar.vcf']);
+        $actual = self::invokePrivate($this->provider, 'getDavUrlForContact', ['principals/users/john.doe', 'foo', 'bar.vcf']);
 
-		$this->assertEquals('absolute-url-link-to-remote.php/dav/addressbooks/users/john.doe/foo/bar.vcf', $actual);
-	}
+        $this->assertEquals('absolute-url-link-to-remote.php/dav/addressbooks/users/john.doe/foo/bar.vcf', $actual);
+    }
 
-	public function testGetDeepLinkToContactsApp(): void {
-		$this->urlGenerator->expects($this->once())
-			->method('linkToRoute')
-			->with('contacts.contacts.direct', ['contact' => 'uid123~uri-john.doe'])
-			->willReturn('link-to-route-contacts.contacts.direct/direct/uid123~uri-john.doe');
-		$this->urlGenerator->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('link-to-route-contacts.contacts.direct/direct/uid123~uri-john.doe')
-			->willReturn('absolute-url-link-to-route-contacts.contacts.direct/direct/uid123~uri-john.doe');
+    public function testGetDeepLinkToContactsApp(): void {
+        $this->urlGenerator->expects($this->once())
+            ->method('linkToRoute')
+            ->with('contacts.contacts.direct', ['contact' => 'uid123~uri-john.doe'])
+            ->willReturn('link-to-route-contacts.contacts.direct/direct/uid123~uri-john.doe');
+        $this->urlGenerator->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('link-to-route-contacts.contacts.direct/direct/uid123~uri-john.doe')
+            ->willReturn('absolute-url-link-to-route-contacts.contacts.direct/direct/uid123~uri-john.doe');
 
-		$actual = self::invokePrivate($this->provider, 'getDeepLinkToContactsApp', ['uri-john.doe', 'uid123']);
-		$this->assertEquals('absolute-url-link-to-route-contacts.contacts.direct/direct/uid123~uri-john.doe', $actual);
-	}
+        $actual = self::invokePrivate($this->provider, 'getDeepLinkToContactsApp', ['uri-john.doe', 'uid123']);
+        $this->assertEquals('absolute-url-link-to-route-contacts.contacts.direct/direct/uid123~uri-john.doe', $actual);
+    }
 
-	public function testGenerateSubline(): void {
-		$vCard0 = Reader::read($this->vcardTest0);
-		$vCard1 = Reader::read($this->vcardTest1);
+    public function testGenerateSubline(): void {
+        $vCard0 = Reader::read($this->vcardTest0);
+        $vCard1 = Reader::read($this->vcardTest1);
 
-		$actual1 = self::invokePrivate($this->provider, 'generateSubline', [$vCard0]);
-		$actual2 = self::invokePrivate($this->provider, 'generateSubline', [$vCard1]);
+        $actual1 = self::invokePrivate($this->provider, 'generateSubline', [$vCard0]);
+        $actual2 = self::invokePrivate($this->provider, 'generateSubline', [$vCard1]);
 
-		$this->assertEquals('forrestgump@example.com', $actual1);
-		$this->assertEquals('', $actual2);
-	}
+        $this->assertEquals('forrestgump@example.com', $actual1);
+        $this->assertEquals('', $actual2);
+    }
 }

Spacing +15 added lines, -15 removed lines

@@ -28,22 +28,22 @@ 
 	private CardDavBackend&MockObject $backend;
 	private ContactsSearchProvider $provider;
 
-	private string $vcardTest0 = 'BEGIN:VCARD' . PHP_EOL .
-		'VERSION:3.0' . PHP_EOL .
-		'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL .
-		'UID:Test' . PHP_EOL .
-		'FN:FN of Test' . PHP_EOL .
-		'N:Test;;;;' . PHP_EOL .
-		'EMAIL:forrestgump@example.com' . PHP_EOL .
+	private string $vcardTest0 = 'BEGIN:VCARD'.PHP_EOL.
+		'VERSION:3.0'.PHP_EOL.
+		'PRODID:-//Sabre//Sabre VObject 4.1.2//EN'.PHP_EOL.
+		'UID:Test'.PHP_EOL.
+		'FN:FN of Test'.PHP_EOL.
+		'N:Test;;;;'.PHP_EOL.
+		'EMAIL:forrestgump@example.com'.PHP_EOL.
 		'END:VCARD';
 
-	private string $vcardTest1 = 'BEGIN:VCARD' . PHP_EOL .
-		'VERSION:3.0' . PHP_EOL .
-		'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL .
-		'PHOTO;ENCODING=b;TYPE=image/jpeg:' . PHP_EOL .
-		'UID:Test2' . PHP_EOL .
-		'FN:FN of Test2' . PHP_EOL .
-		'N:Test2;;;;' . PHP_EOL .
+	private string $vcardTest1 = 'BEGIN:VCARD'.PHP_EOL.
+		'VERSION:3.0'.PHP_EOL.
+		'PRODID:-//Sabre//Sabre VObject 4.1.2//EN'.PHP_EOL.
+		'PHOTO;ENCODING=b;TYPE=image/jpeg:'.PHP_EOL.
+		'UID:Test2'.PHP_EOL.
+		'FN:FN of Test2'.PHP_EOL.
+		'N:Test2;;;;'.PHP_EOL.
 		'END:VCARD';
 
 	protected function setUp(): void {
@@ -144,7 +144,7 @@ 
 					'ORG',
 					'NOTE',
 				],
-				['limit' => 5, 'offset' => 20, 'since' => null, 'until' => null,  'person' => null, 'company' => null])
+				['limit' => 5, 'offset' => 20, 'since' => null, 'until' => null, 'person' => null, 'company' => null])
 			->willReturn([
 				[
 					'addressbookid' => 99,

apps/dav/tests/unit/Controller/InvitationResponseControllerTest.php

Indentation +369 added lines, -369 removed lines

@@ -23,52 +23,52 @@ 
 use Test\TestCase;
 
 class InvitationResponseControllerTest extends TestCase {
-	private IDBConnection&MockObject $dbConnection;
-	private IRequest&MockObject $request;
-	private ITimeFactory&MockObject $timeFactory;
-	private InvitationResponseServer&MockObject $responseServer;
-	private InvitationResponseController $controller;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->dbConnection = $this->createMock(IDBConnection::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->responseServer = $this->createMock(InvitationResponseServer::class);
-
-		$this->controller = new InvitationResponseController(
-			'appName',
-			$this->request,
-			$this->dbConnection,
-			$this->timeFactory,
-			$this->responseServer
-		);
-	}
-
-	public static function attendeeProvider(): array {
-		return [
-			'local attendee' => [false],
-			'external attendee' => [true]
-		];
-	}
-
-	/**
-	 * @dataProvider attendeeProvider
-	 */
-	public function testAccept(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+    private IDBConnection&MockObject $dbConnection;
+    private IRequest&MockObject $request;
+    private ITimeFactory&MockObject $timeFactory;
+    private InvitationResponseServer&MockObject $responseServer;
+    private InvitationResponseController $controller;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->dbConnection = $this->createMock(IDBConnection::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->responseServer = $this->createMock(InvitationResponseServer::class);
+
+        $this->controller = new InvitationResponseController(
+            'appName',
+            $this->request,
+            $this->dbConnection,
+            $this->timeFactory,
+            $this->responseServer
+        );
+    }
+
+    public static function attendeeProvider(): array {
+        return [
+            'local attendee' => [false],
+            'external attendee' => [true]
+        ];
+    }
+
+    /**
+     * @dataProvider attendeeProvider
+     */
+    public function testAccept(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -84,55 +84,55 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(null, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	/**
-	 * @dataProvider attendeeProvider
-	 */
-	public function testAcceptSequence(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => 1337,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(null, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    /**
+     * @dataProvider attendeeProvider
+     */
+    public function testAcceptSequence(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => 1337,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -148,55 +148,55 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(1337, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	/**
-	 * @dataProvider attendeeProvider
-	 */
-	public function testAcceptRecurrenceId(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => "RECURRENCE-ID;TZID=Europe/Berlin:20180726T150000\n",
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(1337, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    /**
+     * @dataProvider attendeeProvider
+     */
+    public function testAcceptRecurrenceId(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => "RECURRENCE-ID;TZID=Europe/Berlin:20180726T150000\n",
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -213,82 +213,82 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(0, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	public function testAcceptTokenNotFound(): void {
-		$this->buildQueryExpects('TOKEN123', null, 1337);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-error', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-	}
-
-	public function testAcceptExpiredToken(): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 42,
-		], 1337);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-error', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-	}
-
-	/**
-	 * @dataProvider attendeeProvider
-	 */
-	public function testDecline(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(0, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    public function testAcceptTokenNotFound(): void {
+        $this->buildQueryExpects('TOKEN123', null, 1337);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-error', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+    }
+
+    public function testAcceptExpiredToken(): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 42,
+        ], 1337);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-error', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+    }
+
+    /**
+     * @dataProvider attendeeProvider
+     */
+    public function testDecline(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -304,67 +304,67 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(null, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->decline('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	public function testOptions(): void {
-		$response = $this->controller->options('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-options', $response->getTemplateName());
-		$this->assertEquals(['token' => 'TOKEN123'], $response->getParams());
-	}
-
-	/**
-	 * @dataProvider attendeeProvider
-	 */
-	public function testProcessMoreOptionsResult(bool $isExternalAttendee): void {
-		$this->request->expects($this->once())
-			->method('getParam')
-			->with('partStat')
-			->willReturn('TENTATIVE');
-
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(null, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->decline('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    public function testOptions(): void {
+        $response = $this->controller->options('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-options', $response->getTemplateName());
+        $this->assertEquals(['token' => 'TOKEN123'], $response->getParams());
+    }
+
+    /**
+     * @dataProvider attendeeProvider
+     */
+    public function testProcessMoreOptionsResult(bool $isExternalAttendee): void {
+        $this->request->expects($this->once())
+            ->method('getParam')
+            ->with('partStat')
+            ->willReturn('TENTATIVE');
+
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -380,92 +380,92 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(null, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-
-		$response = $this->controller->processMoreOptionsResult('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	private function buildQueryExpects(string $token, ?array $return, int $time): void {
-		$queryBuilder = $this->createMock(IQueryBuilder::class);
-		$stmt = $this->createMock(IResult::class);
-		$expr = $this->createMock(IExpressionBuilder::class);
-
-		$this->dbConnection->expects($this->once())
-			->method('getQueryBuilder')
-			->with()
-			->willReturn($queryBuilder);
-		$queryBuilder->method('expr')
-			->willReturn($expr);
-		$queryBuilder->method('createNamedParameter')
-			->willReturnMap([
-				[$token, \PDO::PARAM_STR, null, 'namedParameterToken']
-			]);
-
-		$stmt->expects($this->once())
-			->method('fetch')
-			->with(\PDO::FETCH_ASSOC)
-			->willReturn($return);
-		$stmt->expects($this->once())
-			->method('closeCursor');
-
-		$function = 'functionToken';
-		$expr->expects($this->once())
-			->method('eq')
-			->with('token', 'namedParameterToken')
-			->willReturn((string)$function);
-
-		$this->dbConnection->expects($this->once())
-			->method('getQueryBuilder')
-			->with()
-			->willReturn($queryBuilder);
-
-		$queryBuilder->expects($this->once())
-			->method('select')
-			->with('*')
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('from')
-			->with('calendar_invitations')
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('where')
-			->with($function)
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('executeQuery')
-			->with()
-			->willReturn($stmt);
-
-		$this->timeFactory->method('getTime')
-			->willReturn($time);
-	}
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(null, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+
+        $response = $this->controller->processMoreOptionsResult('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    private function buildQueryExpects(string $token, ?array $return, int $time): void {
+        $queryBuilder = $this->createMock(IQueryBuilder::class);
+        $stmt = $this->createMock(IResult::class);
+        $expr = $this->createMock(IExpressionBuilder::class);
+
+        $this->dbConnection->expects($this->once())
+            ->method('getQueryBuilder')
+            ->with()
+            ->willReturn($queryBuilder);
+        $queryBuilder->method('expr')
+            ->willReturn($expr);
+        $queryBuilder->method('createNamedParameter')
+            ->willReturnMap([
+                [$token, \PDO::PARAM_STR, null, 'namedParameterToken']
+            ]);
+
+        $stmt->expects($this->once())
+            ->method('fetch')
+            ->with(\PDO::FETCH_ASSOC)
+            ->willReturn($return);
+        $stmt->expects($this->once())
+            ->method('closeCursor');
+
+        $function = 'functionToken';
+        $expr->expects($this->once())
+            ->method('eq')
+            ->with('token', 'namedParameterToken')
+            ->willReturn((string)$function);
+
+        $this->dbConnection->expects($this->once())
+            ->method('getQueryBuilder')
+            ->with()
+            ->willReturn($queryBuilder);
+
+        $queryBuilder->expects($this->once())
+            ->method('select')
+            ->with('*')
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('from')
+            ->with('calendar_invitations')
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('where')
+            ->with($function)
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('executeQuery')
+            ->with()
+            ->willReturn($stmt);
+
+        $this->timeFactory->method('getTime')
+            ->willReturn($time);
+    }
 }

apps/dav/tests/unit/Controller/DirectControllerTest.php

Indentation +109 added lines, -109 removed lines

@@ -26,113 +26,113 @@
 use Test\TestCase;
 
 class DirectControllerTest extends TestCase {
-	private IRootFolder&MockObject $rootFolder;
-	private DirectMapper&MockObject $directMapper;
-	private ISecureRandom&MockObject $random;
-	private ITimeFactory&MockObject $timeFactory;
-	private IURLGenerator&MockObject $urlGenerator;
-	private IEventDispatcher&MockObject $eventDispatcher;
-
-	private DirectController $controller;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$this->directMapper = $this->createMock(DirectMapper::class);
-		$this->random = $this->createMock(ISecureRandom::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
-
-		$this->controller = new DirectController(
-			'dav',
-			$this->createMock(IRequest::class),
-			$this->rootFolder,
-			'awesomeUser',
-			$this->directMapper,
-			$this->random,
-			$this->timeFactory,
-			$this->urlGenerator,
-			$this->eventDispatcher
-		);
-	}
-
-	public function testGetUrlNonExistingFileId(): void {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with('awesomeUser')
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(101)
-			->willReturn([]);
-
-		$this->expectException(OCSNotFoundException::class);
-		$this->controller->getUrl(101);
-	}
-
-	public function testGetUrlForFolder(): void {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with('awesomeUser')
-			->willReturn($userFolder);
-
-		$folder = $this->createMock(Folder::class);
-
-		$userFolder->method('getFirstNodeById')
-			->with(101)
-			->willReturn($folder);
-
-		$this->expectException(OCSBadRequestException::class);
-		$this->controller->getUrl(101);
-	}
-
-	public function testGetUrlValid(): void {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with('awesomeUser')
-			->willReturn($userFolder);
-
-		$file = $this->createMock(File::class);
-
-		$this->timeFactory->method('getTime')
-			->willReturn(42);
-
-		$userFolder->method('getFirstNodeById')
-			->with(101)
-			->willReturn($file);
-
-		$userFolder->method('getRelativePath')
-			->willReturn('/path');
-
-		$this->random->method('generate')
-			->with(
-				60,
-				ISecureRandom::CHAR_ALPHANUMERIC
-			)->willReturn('superduperlongtoken');
-
-		$this->directMapper->expects($this->once())
-			->method('insert')
-			->willReturnCallback(function (Direct $direct) {
-				$this->assertSame('awesomeUser', $direct->getUserId());
-				$this->assertSame(101, $direct->getFileId());
-				$this->assertSame('superduperlongtoken', $direct->getToken());
-				$this->assertSame(42 + 60 * 60 * 8, $direct->getExpiration());
-
-				return $direct;
-			});
-
-		$this->urlGenerator->method('getAbsoluteURL')
-			->willReturnCallback(function (string $url) {
-				return 'https://my.nextcloud/' . $url;
-			});
-
-		$result = $this->controller->getUrl(101);
-
-		$this->assertInstanceOf(DataResponse::class, $result);
-		$this->assertSame([
-			'url' => 'https://my.nextcloud/remote.php/direct/superduperlongtoken',
-		], $result->getData());
-	}
+    private IRootFolder&MockObject $rootFolder;
+    private DirectMapper&MockObject $directMapper;
+    private ISecureRandom&MockObject $random;
+    private ITimeFactory&MockObject $timeFactory;
+    private IURLGenerator&MockObject $urlGenerator;
+    private IEventDispatcher&MockObject $eventDispatcher;
+
+    private DirectController $controller;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $this->directMapper = $this->createMock(DirectMapper::class);
+        $this->random = $this->createMock(ISecureRandom::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->eventDispatcher = $this->createMock(IEventDispatcher::class);
+
+        $this->controller = new DirectController(
+            'dav',
+            $this->createMock(IRequest::class),
+            $this->rootFolder,
+            'awesomeUser',
+            $this->directMapper,
+            $this->random,
+            $this->timeFactory,
+            $this->urlGenerator,
+            $this->eventDispatcher
+        );
+    }
+
+    public function testGetUrlNonExistingFileId(): void {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with('awesomeUser')
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(101)
+            ->willReturn([]);
+
+        $this->expectException(OCSNotFoundException::class);
+        $this->controller->getUrl(101);
+    }
+
+    public function testGetUrlForFolder(): void {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with('awesomeUser')
+            ->willReturn($userFolder);
+
+        $folder = $this->createMock(Folder::class);
+
+        $userFolder->method('getFirstNodeById')
+            ->with(101)
+            ->willReturn($folder);
+
+        $this->expectException(OCSBadRequestException::class);
+        $this->controller->getUrl(101);
+    }
+
+    public function testGetUrlValid(): void {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with('awesomeUser')
+            ->willReturn($userFolder);
+
+        $file = $this->createMock(File::class);
+
+        $this->timeFactory->method('getTime')
+            ->willReturn(42);
+
+        $userFolder->method('getFirstNodeById')
+            ->with(101)
+            ->willReturn($file);
+
+        $userFolder->method('getRelativePath')
+            ->willReturn('/path');
+
+        $this->random->method('generate')
+            ->with(
+                60,
+                ISecureRandom::CHAR_ALPHANUMERIC
+            )->willReturn('superduperlongtoken');
+
+        $this->directMapper->expects($this->once())
+            ->method('insert')
+            ->willReturnCallback(function (Direct $direct) {
+                $this->assertSame('awesomeUser', $direct->getUserId());
+                $this->assertSame(101, $direct->getFileId());
+                $this->assertSame('superduperlongtoken', $direct->getToken());
+                $this->assertSame(42 + 60 * 60 * 8, $direct->getExpiration());
+
+                return $direct;
+            });
+
+        $this->urlGenerator->method('getAbsoluteURL')
+            ->willReturnCallback(function (string $url) {
+                return 'https://my.nextcloud/' . $url;
+            });
+
+        $result = $this->controller->getUrl(101);
+
+        $this->assertInstanceOf(DataResponse::class, $result);
+        $this->assertSame([
+            'url' => 'https://my.nextcloud/remote.php/direct/superduperlongtoken',
+        ], $result->getData());
+    }
 }

apps/dav/tests/unit/Controller/BirthdayCalendarControllerTest.php

Indentation +62 added lines, -62 removed lines

@@ -21,76 +21,76 @@
 use Test\TestCase;
 
 class BirthdayCalendarControllerTest extends TestCase {
-	private IConfig&MockObject $config;
-	private IRequest&MockObject $request;
-	private IDBConnection&MockObject $db;
-	private IJobList&MockObject $jobList;
-	private IUserManager&MockObject $userManager;
-	private CalDavBackend&MockObject $caldav;
-	private BirthdayCalendarController $controller;
+    private IConfig&MockObject $config;
+    private IRequest&MockObject $request;
+    private IDBConnection&MockObject $db;
+    private IJobList&MockObject $jobList;
+    private IUserManager&MockObject $userManager;
+    private CalDavBackend&MockObject $caldav;
+    private BirthdayCalendarController $controller;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->config = $this->createMock(IConfig::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->db = $this->createMock(IDBConnection::class);
-		$this->jobList = $this->createMock(IJobList::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->caldav = $this->createMock(CalDavBackend::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->db = $this->createMock(IDBConnection::class);
+        $this->jobList = $this->createMock(IJobList::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->caldav = $this->createMock(CalDavBackend::class);
 
-		$this->controller = new BirthdayCalendarController('dav',
-			$this->request, $this->db, $this->config, $this->jobList,
-			$this->userManager, $this->caldav);
-	}
+        $this->controller = new BirthdayCalendarController('dav',
+            $this->request, $this->db, $this->config, $this->jobList,
+            $this->userManager, $this->caldav);
+    }
 
-	public function testEnable(): void {
-		$this->config->expects($this->once())
-			->method('setAppValue')
-			->with('dav', 'generateBirthdayCalendar', 'yes');
+    public function testEnable(): void {
+        $this->config->expects($this->once())
+            ->method('setAppValue')
+            ->with('dav', 'generateBirthdayCalendar', 'yes');
 
-		$this->userManager->expects($this->once())
-			->method('callForSeenUsers')
-			->willReturnCallback(function ($closure): void {
-				$user1 = $this->createMock(IUser::class);
-				$user1->method('getUID')->willReturn('uid1');
-				$user2 = $this->createMock(IUser::class);
-				$user2->method('getUID')->willReturn('uid2');
-				$user3 = $this->createMock(IUser::class);
-				$user3->method('getUID')->willReturn('uid3');
+        $this->userManager->expects($this->once())
+            ->method('callForSeenUsers')
+            ->willReturnCallback(function ($closure): void {
+                $user1 = $this->createMock(IUser::class);
+                $user1->method('getUID')->willReturn('uid1');
+                $user2 = $this->createMock(IUser::class);
+                $user2->method('getUID')->willReturn('uid2');
+                $user3 = $this->createMock(IUser::class);
+                $user3->method('getUID')->willReturn('uid3');
 
-				$closure($user1);
-				$closure($user2);
-				$closure($user3);
-			});
+                $closure($user1);
+                $closure($user2);
+                $closure($user3);
+            });
 
-		$calls = [
-			[GenerateBirthdayCalendarBackgroundJob::class, ['userId' => 'uid1']],
-			[GenerateBirthdayCalendarBackgroundJob::class, ['userId' => 'uid2']],
-			[GenerateBirthdayCalendarBackgroundJob::class, ['userId' => 'uid3']],
-		];
-		$this->jobList->expects($this->exactly(3))
-			->method('add')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
+        $calls = [
+            [GenerateBirthdayCalendarBackgroundJob::class, ['userId' => 'uid1']],
+            [GenerateBirthdayCalendarBackgroundJob::class, ['userId' => 'uid2']],
+            [GenerateBirthdayCalendarBackgroundJob::class, ['userId' => 'uid3']],
+        ];
+        $this->jobList->expects($this->exactly(3))
+            ->method('add')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
 
-		$response = $this->controller->enable();
-		$this->assertInstanceOf(JSONResponse::class, $response);
-	}
+        $response = $this->controller->enable();
+        $this->assertInstanceOf(JSONResponse::class, $response);
+    }
 
-	public function testDisable(): void {
-		$this->config->expects($this->once())
-			->method('setAppValue')
-			->with('dav', 'generateBirthdayCalendar', 'no');
-		$this->jobList->expects($this->once())
-			->method('remove')
-			->with(GenerateBirthdayCalendarBackgroundJob::class);
-		$this->caldav->expects($this->once())
-			->method('deleteAllBirthdayCalendars');
+    public function testDisable(): void {
+        $this->config->expects($this->once())
+            ->method('setAppValue')
+            ->with('dav', 'generateBirthdayCalendar', 'no');
+        $this->jobList->expects($this->once())
+            ->method('remove')
+            ->with(GenerateBirthdayCalendarBackgroundJob::class);
+        $this->caldav->expects($this->once())
+            ->method('deleteAllBirthdayCalendars');
 
-		$response = $this->controller->disable();
-		$this->assertInstanceOf(JSONResponse::class, $response);
-	}
+        $response = $this->controller->disable();
+        $this->assertInstanceOf(JSONResponse::class, $response);
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
 
 		$this->userManager->expects($this->once())
 			->method('callForSeenUsers')
-			->willReturnCallback(function ($closure): void {
+			->willReturnCallback(function($closure): void {
 				$user1 = $this->createMock(IUser::class);
 				$user1->method('getUID')->willReturn('uid1');
 				$user2 = $this->createMock(IUser::class);
@@ -71,7 +71,7 @@ 
 		];
 		$this->jobList->expects($this->exactly(3))
 			->method('add')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});

apps/dav/tests/unit/Controller/UpcomingEventsControllerTest.php

Indentation +45 added lines, -45 removed lines

@@ -17,57 +17,57 @@
 use PHPUnit\Framework\TestCase;
 
 class UpcomingEventsControllerTest extends TestCase {
-	private IRequest&MockObject $request;
-	private UpcomingEventsService&MockObject $service;
+    private IRequest&MockObject $request;
+    private UpcomingEventsService&MockObject $service;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->request = $this->createMock(IRequest::class);
-		$this->service = $this->createMock(UpcomingEventsService::class);
-	}
+        $this->request = $this->createMock(IRequest::class);
+        $this->service = $this->createMock(UpcomingEventsService::class);
+    }
 
-	public function testGetEventsAnonymously(): void {
-		$controller = new UpcomingEventsController(
-			$this->request,
-			null,
-			$this->service,
-		);
+    public function testGetEventsAnonymously(): void {
+        $controller = new UpcomingEventsController(
+            $this->request,
+            null,
+            $this->service,
+        );
 
-		$response = $controller->getEvents('https://cloud.example.com/call/123');
+        $response = $controller->getEvents('https://cloud.example.com/call/123');
 
-		self::assertNull($response->getData());
-		self::assertSame(401, $response->getStatus());
-	}
+        self::assertNull($response->getData());
+        self::assertSame(401, $response->getStatus());
+    }
 
-	public function testGetEventsByLocation(): void {
-		$controller = new UpcomingEventsController(
-			$this->request,
-			'u1',
-			$this->service,
-		);
-		$this->service->expects(self::once())
-			->method('getEvents')
-			->with('u1', 'https://cloud.example.com/call/123')
-			->willReturn([
-				new UpcomingEvent(
-					'abc-123',
-					null,
-					'personal',
-					123,
-					'Test',
-					'https://cloud.example.com/call/123',
-					null,
-				),
-			]);
+    public function testGetEventsByLocation(): void {
+        $controller = new UpcomingEventsController(
+            $this->request,
+            'u1',
+            $this->service,
+        );
+        $this->service->expects(self::once())
+            ->method('getEvents')
+            ->with('u1', 'https://cloud.example.com/call/123')
+            ->willReturn([
+                new UpcomingEvent(
+                    'abc-123',
+                    null,
+                    'personal',
+                    123,
+                    'Test',
+                    'https://cloud.example.com/call/123',
+                    null,
+                ),
+            ]);
 
-		$response = $controller->getEvents('https://cloud.example.com/call/123');
+        $response = $controller->getEvents('https://cloud.example.com/call/123');
 
-		self::assertNotNull($response->getData());
-		self::assertIsArray($response->getData());
-		self::assertCount(1, $response->getData()['events']);
-		self::assertSame(200, $response->getStatus());
-		$event1 = $response->getData()['events'][0];
-		self::assertEquals('abc-123', $event1['uri']);
-	}
+        self::assertNotNull($response->getData());
+        self::assertIsArray($response->getData());
+        self::assertCount(1, $response->getData()['events']);
+        self::assertSame(200, $response->getStatus());
+        $event1 = $response->getData()['events'][0];
+        self::assertEquals('abc-123', $event1['uri']);
+    }
 }

apps/dav/tests/unit/Service/DefaultContactServiceTest.php

Indentation +138 added lines, -138 removed lines

@@ -24,142 +24,142 @@
 use Test\TestCase;
 
 class DefaultContactServiceTest extends TestCase {
-	protected DefaultContactService $service;
-	protected CardDavBackend&MockObject $cardDav;
-	protected IAppManager&MockObject $appManager;
-	protected IAppDataFactory&MockObject $appDataFactory;
-	protected LoggerInterface&MockObject $logger;
-	protected IAppConfig&MockObject $config;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->cardDav = $this->createMock(CardDavBackend::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->appDataFactory = $this->createMock(IAppDataFactory::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->config = $this->createMock(IAppConfig::class);
-
-		$this->service = new DefaultContactService(
-			$this->cardDav,
-			$this->appManager,
-			$this->appDataFactory,
-			$this->config,
-			$this->logger,
-		);
-	}
-
-	public function testCreateDefaultContactWithInvalidCard(): void {
-		// Invalid vCard missing required FN property
-		$vcardContent = "BEGIN:VCARD\nVERSION:3.0\nEND:VCARD";
-		$this->config->method('getValueString')->willReturn('yes');
-		$appData = $this->createMock(IAppData::class);
-		$folder = $this->createMock(ISimpleFolder::class);
-		$file = $this->createMock(ISimpleFile::class);
-		$file->method('getContent')->willReturn($vcardContent);
-		$folder->method('getFile')->willReturn($file);
-		$appData->method('getFolder')->willReturn($folder);
-		$this->appDataFactory->method('get')->willReturn($appData);
-
-		$this->logger->expects($this->once())
-			->method('error')
-			->with('Default contact is invalid', $this->anything());
-
-		$this->cardDav->expects($this->never())
-			->method('createCard');
-
-		$this->service->createDefaultContact(123);
-	}
-
-	public function testUidAndRevAreUpdated(): void {
-		$originalUid = 'original-uid';
-		$originalRev = '20200101T000000Z';
-		$vcardContent = "BEGIN:VCARD\nVERSION:3.0\nFN:Test User\nUID:$originalUid\nREV:$originalRev\nEND:VCARD";
-
-		$this->config->method('getValueString')->willReturn('yes');
-		$appData = $this->createMock(IAppData::class);
-		$folder = $this->createMock(ISimpleFolder::class);
-		$file = $this->createMock(ISimpleFile::class);
-		$file->method('getContent')->willReturn($vcardContent);
-		$folder->method('getFile')->willReturn($file);
-		$appData->method('getFolder')->willReturn($folder);
-		$this->appDataFactory->method('get')->willReturn($appData);
-
-		$capturedCardData = null;
-		$this->cardDav->expects($this->once())
-			->method('createCard')
-			->with(
-				$this->anything(),
-				$this->anything(),
-				$this->callback(function ($cardData) use (&$capturedCardData) {
-					$capturedCardData = $cardData;
-					return true;
-				}),
-				$this->anything()
-			)->willReturn(null);
-
-		$this->service->createDefaultContact(123);
-
-		$vcard = \Sabre\VObject\Reader::read($capturedCardData);
-		$this->assertNotEquals($originalUid, $vcard->UID->getValue());
-		$this->assertTrue(Uuid::isValid($vcard->UID->getValue()));
-		$this->assertNotEquals($originalRev, $vcard->REV->getValue());
-	}
-
-	public function testDefaultContactFileDoesNotExist(): void {
-		$appData = $this->createMock(IAppData::class);
-		$this->config->method('getValueString')->willReturn('yes');
-		$appData->method('getFolder')->willThrowException(new NotFoundException());
-		$this->appDataFactory->method('get')->willReturn($appData);
-
-		$this->cardDav->expects($this->never())
-			->method('createCard');
-
-		$this->service->createDefaultContact(123);
-	}
-
-	public function testUidAndRevAreAddedIfMissing(): void {
-		$vcardContent = "BEGIN:VCARD\nVERSION:3.0\nFN:Test User\nEND:VCARD";
-
-		$this->config->method('getValueString')->willReturn('yes');
-		$appData = $this->createMock(IAppData::class);
-		$folder = $this->createMock(ISimpleFolder::class);
-		$file = $this->createMock(ISimpleFile::class);
-		$file->method('getContent')->willReturn($vcardContent);
-		$folder->method('getFile')->willReturn($file);
-		$appData->method('getFolder')->willReturn($folder);
-		$this->appDataFactory->method('get')->willReturn($appData);
-
-		$capturedCardData = 'new-card-data';
-
-		$this->cardDav
-			->expects($this->once())
-			->method('createCard')
-			->with(
-				$this->anything(),
-				$this->anything(),
-				$this->callback(function ($cardData) use (&$capturedCardData) {
-					$capturedCardData = $cardData;
-					return true;
-				}),
-				$this->anything()
-			);
-
-		$this->service->createDefaultContact(123);
-		$vcard = \Sabre\VObject\Reader::read($capturedCardData);
-
-		$this->assertNotNull($vcard->REV);
-		$this->assertNotNull($vcard->UID);
-		$this->assertTrue(Uuid::isValid($vcard->UID->getValue()));
-	}
-
-	public function testDefaultContactIsNotCreatedIfEnabled(): void {
-		$this->config->method('getValueString')->willReturn('no');
-		$this->logger->expects($this->never())
-			->method('error');
-		$this->cardDav->expects($this->never())
-			->method('createCard');
-
-		$this->service->createDefaultContact(123);
-	}
+    protected DefaultContactService $service;
+    protected CardDavBackend&MockObject $cardDav;
+    protected IAppManager&MockObject $appManager;
+    protected IAppDataFactory&MockObject $appDataFactory;
+    protected LoggerInterface&MockObject $logger;
+    protected IAppConfig&MockObject $config;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->cardDav = $this->createMock(CardDavBackend::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->appDataFactory = $this->createMock(IAppDataFactory::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->config = $this->createMock(IAppConfig::class);
+
+        $this->service = new DefaultContactService(
+            $this->cardDav,
+            $this->appManager,
+            $this->appDataFactory,
+            $this->config,
+            $this->logger,
+        );
+    }
+
+    public function testCreateDefaultContactWithInvalidCard(): void {
+        // Invalid vCard missing required FN property
+        $vcardContent = "BEGIN:VCARD\nVERSION:3.0\nEND:VCARD";
+        $this->config->method('getValueString')->willReturn('yes');
+        $appData = $this->createMock(IAppData::class);
+        $folder = $this->createMock(ISimpleFolder::class);
+        $file = $this->createMock(ISimpleFile::class);
+        $file->method('getContent')->willReturn($vcardContent);
+        $folder->method('getFile')->willReturn($file);
+        $appData->method('getFolder')->willReturn($folder);
+        $this->appDataFactory->method('get')->willReturn($appData);
+
+        $this->logger->expects($this->once())
+            ->method('error')
+            ->with('Default contact is invalid', $this->anything());
+
+        $this->cardDav->expects($this->never())
+            ->method('createCard');
+
+        $this->service->createDefaultContact(123);
+    }
+
+    public function testUidAndRevAreUpdated(): void {
+        $originalUid = 'original-uid';
+        $originalRev = '20200101T000000Z';
+        $vcardContent = "BEGIN:VCARD\nVERSION:3.0\nFN:Test User\nUID:$originalUid\nREV:$originalRev\nEND:VCARD";
+
+        $this->config->method('getValueString')->willReturn('yes');
+        $appData = $this->createMock(IAppData::class);
+        $folder = $this->createMock(ISimpleFolder::class);
+        $file = $this->createMock(ISimpleFile::class);
+        $file->method('getContent')->willReturn($vcardContent);
+        $folder->method('getFile')->willReturn($file);
+        $appData->method('getFolder')->willReturn($folder);
+        $this->appDataFactory->method('get')->willReturn($appData);
+
+        $capturedCardData = null;
+        $this->cardDav->expects($this->once())
+            ->method('createCard')
+            ->with(
+                $this->anything(),
+                $this->anything(),
+                $this->callback(function ($cardData) use (&$capturedCardData) {
+                    $capturedCardData = $cardData;
+                    return true;
+                }),
+                $this->anything()
+            )->willReturn(null);
+
+        $this->service->createDefaultContact(123);
+
+        $vcard = \Sabre\VObject\Reader::read($capturedCardData);
+        $this->assertNotEquals($originalUid, $vcard->UID->getValue());
+        $this->assertTrue(Uuid::isValid($vcard->UID->getValue()));
+        $this->assertNotEquals($originalRev, $vcard->REV->getValue());
+    }
+
+    public function testDefaultContactFileDoesNotExist(): void {
+        $appData = $this->createMock(IAppData::class);
+        $this->config->method('getValueString')->willReturn('yes');
+        $appData->method('getFolder')->willThrowException(new NotFoundException());
+        $this->appDataFactory->method('get')->willReturn($appData);
+
+        $this->cardDav->expects($this->never())
+            ->method('createCard');
+
+        $this->service->createDefaultContact(123);
+    }
+
+    public function testUidAndRevAreAddedIfMissing(): void {
+        $vcardContent = "BEGIN:VCARD\nVERSION:3.0\nFN:Test User\nEND:VCARD";
+
+        $this->config->method('getValueString')->willReturn('yes');
+        $appData = $this->createMock(IAppData::class);
+        $folder = $this->createMock(ISimpleFolder::class);
+        $file = $this->createMock(ISimpleFile::class);
+        $file->method('getContent')->willReturn($vcardContent);
+        $folder->method('getFile')->willReturn($file);
+        $appData->method('getFolder')->willReturn($folder);
+        $this->appDataFactory->method('get')->willReturn($appData);
+
+        $capturedCardData = 'new-card-data';
+
+        $this->cardDav
+            ->expects($this->once())
+            ->method('createCard')
+            ->with(
+                $this->anything(),
+                $this->anything(),
+                $this->callback(function ($cardData) use (&$capturedCardData) {
+                    $capturedCardData = $cardData;
+                    return true;
+                }),
+                $this->anything()
+            );
+
+        $this->service->createDefaultContact(123);
+        $vcard = \Sabre\VObject\Reader::read($capturedCardData);
+
+        $this->assertNotNull($vcard->REV);
+        $this->assertNotNull($vcard->UID);
+        $this->assertTrue(Uuid::isValid($vcard->UID->getValue()));
+    }
+
+    public function testDefaultContactIsNotCreatedIfEnabled(): void {
+        $this->config->method('getValueString')->willReturn('no');
+        $this->logger->expects($this->never())
+            ->method('error');
+        $this->cardDav->expects($this->never())
+            ->method('createCard');
+
+        $this->service->createDefaultContact(123);
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -91,7 +91,7 @@ 
 			->with(
 				$this->anything(),
 				$this->anything(),
-				$this->callback(function ($cardData) use (&$capturedCardData) {
+				$this->callback(function($cardData) use (&$capturedCardData) {
 					$capturedCardData = $cardData;
 					return true;
 				}),
@@ -138,7 +138,7 @@ 
 			->with(
 				$this->anything(),
 				$this->anything(),
-				$this->callback(function ($cardData) use (&$capturedCardData) {
+				$this->callback(function($cardData) use (&$capturedCardData) {
 					$capturedCardData = $cardData;
 					return true;
 				}),

apps/dav/tests/unit/Service/UpcomingEventsServiceTest.php

Indentation +58 added lines, -58 removed lines

@@ -22,68 +22,68 @@
 
 class UpcomingEventsServiceTest extends TestCase {
 
-	private IManager&MockObject $calendarManager;
-	private ITimeFactory&MockObject $timeFactory;
-	private IUserManager&MockObject $userManager;
-	private IAppManager&MockObject $appManager;
-	private IURLGenerator&MockObject $urlGenerator;
-	private UpcomingEventsService $service;
+    private IManager&MockObject $calendarManager;
+    private ITimeFactory&MockObject $timeFactory;
+    private IUserManager&MockObject $userManager;
+    private IAppManager&MockObject $appManager;
+    private IURLGenerator&MockObject $urlGenerator;
+    private UpcomingEventsService $service;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->calendarManager = $this->createMock(IManager::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->calendarManager = $this->createMock(IManager::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
 
-		$this->service = new UpcomingEventsService(
-			$this->calendarManager,
-			$this->timeFactory,
-			$this->userManager,
-			$this->appManager,
-			$this->urlGenerator,
-		);
-	}
+        $this->service = new UpcomingEventsService(
+            $this->calendarManager,
+            $this->timeFactory,
+            $this->userManager,
+            $this->appManager,
+            $this->urlGenerator,
+        );
+    }
 
-	public function testGetEventsByLocation(): void {
-		$now = new DateTimeImmutable('2024-07-08T18:20:20Z');
-		$this->timeFactory->method('now')
-			->willReturn($now);
-		$query = $this->createMock(ICalendarQuery::class);
-		$this->appManager->method('isEnabledForUser')->willReturn(false);
-		$this->calendarManager->method('newQuery')
-			->with('principals/users/user1')
-			->willReturn($query);
-		$query->expects(self::once())
-			->method('addSearchProperty')
-			->with('LOCATION');
-		$query->expects(self::once())
-			->method('setSearchPattern')
-			->with('https://cloud.example.com/call/123');
-		$this->calendarManager->expects(self::once())
-			->method('searchForPrincipal')
-			->with($query)
-			->willReturn([
-				[
-					'uri' => 'ev1',
-					'calendar-key' => '1',
-					'calendar-uri' => 'personal',
-					'objects' => [
-						0 => [
-							'DTSTART' => [
-								new DateTimeImmutable('now'),
-							],
-						],
-					],
-				],
-			]);
+    public function testGetEventsByLocation(): void {
+        $now = new DateTimeImmutable('2024-07-08T18:20:20Z');
+        $this->timeFactory->method('now')
+            ->willReturn($now);
+        $query = $this->createMock(ICalendarQuery::class);
+        $this->appManager->method('isEnabledForUser')->willReturn(false);
+        $this->calendarManager->method('newQuery')
+            ->with('principals/users/user1')
+            ->willReturn($query);
+        $query->expects(self::once())
+            ->method('addSearchProperty')
+            ->with('LOCATION');
+        $query->expects(self::once())
+            ->method('setSearchPattern')
+            ->with('https://cloud.example.com/call/123');
+        $this->calendarManager->expects(self::once())
+            ->method('searchForPrincipal')
+            ->with($query)
+            ->willReturn([
+                [
+                    'uri' => 'ev1',
+                    'calendar-key' => '1',
+                    'calendar-uri' => 'personal',
+                    'objects' => [
+                        0 => [
+                            'DTSTART' => [
+                                new DateTimeImmutable('now'),
+                            ],
+                        ],
+                    ],
+                ],
+            ]);
 
-		$events = $this->service->getEvents('user1', 'https://cloud.example.com/call/123');
+        $events = $this->service->getEvents('user1', 'https://cloud.example.com/call/123');
 
-		self::assertCount(1, $events);
-		$event1 = $events[0];
-		self::assertEquals('ev1', $event1->getUri());
-	}
+        self::assertCount(1, $events);
+        $event1 = $events[0];
+        self::assertEquals('ev1', $event1->getUri());
+    }
 }

apps/dav/tests/unit/Service/AbsenceServiceTest.php

Indentation +414 added lines, -414 removed lines

@@ -28,418 +28,418 @@
 use PHPUnit\Framework\TestCase;
 
 class AbsenceServiceTest extends TestCase {
-	private AbsenceService $absenceService;
-	private AbsenceMapper&MockObject $absenceMapper;
-	private IEventDispatcher&MockObject $eventDispatcher;
-	private IJobList&MockObject $jobList;
-	private TimezoneService&MockObject $timezoneService;
-	private ITimeFactory&MockObject $timeFactory;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->absenceMapper = $this->createMock(AbsenceMapper::class);
-		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
-		$this->jobList = $this->createMock(IJobList::class);
-		$this->timezoneService = $this->createMock(TimezoneService::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-
-		$this->absenceService = new AbsenceService(
-			$this->absenceMapper,
-			$this->eventDispatcher,
-			$this->jobList,
-			$this->timezoneService,
-			$this->timeFactory,
-		);
-	}
-
-	public function testCreateAbsenceEmitsScheduledEvent(): void {
-		$tz = new DateTimeZone('Europe/Berlin');
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-
-		$this->absenceMapper->expects(self::once())
-			->method('findByUserId')
-			->with('user')
-			->willThrowException(new DoesNotExistException('foo bar'));
-		$this->absenceMapper->expects(self::once())
-			->method('insert')
-			->willReturnCallback(function (Absence $absence): Absence {
-				$absence->setId(1);
-				return $absence;
-			});
-		$this->timezoneService->expects(self::once())
-			->method('getUserTimezone')
-			->with('user')
-			->willReturn('Europe/Berlin');
-		$this->eventDispatcher->expects(self::once())
-			->method('dispatchTyped')
-			->with(self::callback(static function (Event $event) use ($user, $tz): bool {
-				self::assertInstanceOf(OutOfOfficeScheduledEvent::class, $event);
-				/** @var OutOfOfficeScheduledEvent $event */
-				$data = $event->getData();
-				self::assertEquals('1', $data->getId());
-				self::assertEquals($user, $data->getUser());
-				self::assertEquals(
-					(new DateTimeImmutable('2023-01-05', $tz))->getTimeStamp(),
-					$data->getStartDate(),
-				);
-				self::assertEquals(
-					(new DateTimeImmutable('2023-01-10', $tz))->getTimeStamp() + 3600 * 23 + 59 * 60,
-					$data->getEndDate(),
-				);
-				self::assertEquals('status', $data->getShortMessage());
-				self::assertEquals('message', $data->getMessage());
-				return true;
-			}));
-		$this->timeFactory->expects(self::once())
-			->method('getTime')
-			->willReturn(PHP_INT_MAX);
-		$this->jobList->expects(self::never())
-			->method('scheduleAfter');
-
-		$this->absenceService->createOrUpdateAbsence(
-			$user,
-			'2023-01-05',
-			'2023-01-10',
-			'status',
-			'message',
-		);
-	}
-
-	public function testUpdateAbsenceEmitsChangedEvent(): void {
-		$tz = new DateTimeZone('Europe/Berlin');
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-		$absence = new Absence();
-		$absence->setId(1);
-		$absence->setFirstDay('1970-01-01');
-		$absence->setLastDay('1970-01-10');
-		$absence->setStatus('old status');
-		$absence->setMessage('old message');
-
-		$this->absenceMapper->expects(self::once())
-			->method('findByUserId')
-			->with('user')
-			->willReturn($absence);
-		$this->absenceMapper->expects(self::once())
-			->method('update')
-			->willReturnCallback(static function (Absence $absence): Absence {
-				self::assertEquals('2023-01-05', $absence->getFirstDay());
-				self::assertEquals('2023-01-10', $absence->getLastDay());
-				self::assertEquals('status', $absence->getStatus());
-				self::assertEquals('message', $absence->getMessage());
-				return $absence;
-			});
-		$this->timezoneService->expects(self::once())
-			->method('getUserTimezone')
-			->with('user')
-			->willReturn('Europe/Berlin');
-		$this->eventDispatcher->expects(self::once())
-			->method('dispatchTyped')
-			->with(self::callback(static function (Event $event) use ($user, $tz): bool {
-				self::assertInstanceOf(OutOfOfficeChangedEvent::class, $event);
-				/** @var OutOfOfficeChangedEvent $event */
-				$data = $event->getData();
-				self::assertEquals('1', $data->getId());
-				self::assertEquals($user, $data->getUser());
-				self::assertEquals(
-					(new DateTimeImmutable('2023-01-05', $tz))->getTimeStamp(),
-					$data->getStartDate(),
-				);
-				self::assertEquals(
-					(new DateTimeImmutable('2023-01-10', $tz))->getTimeStamp() + 3600 * 23 + 59 * 60,
-					$data->getEndDate(),
-				);
-				self::assertEquals('status', $data->getShortMessage());
-				self::assertEquals('message', $data->getMessage());
-				return true;
-			}));
-		$this->timeFactory->expects(self::once())
-			->method('getTime')
-			->willReturn(PHP_INT_MAX);
-		$this->jobList->expects(self::never())
-			->method('scheduleAfter');
-
-		$this->absenceService->createOrUpdateAbsence(
-			$user,
-			'2023-01-05',
-			'2023-01-10',
-			'status',
-			'message',
-		);
-	}
-
-	public function testCreateAbsenceSchedulesBothJobs(): void {
-		$tz = new DateTimeZone('Europe/Berlin');
-		$startDateString = '2023-01-05';
-		$startDate = new DateTimeImmutable($startDateString, $tz);
-		$endDateString = '2023-01-10';
-		$endDate = new DateTimeImmutable($endDateString, $tz);
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-
-		$this->absenceMapper->expects(self::once())
-			->method('findByUserId')
-			->with('user')
-			->willThrowException(new DoesNotExistException('foo bar'));
-		$this->absenceMapper->expects(self::once())
-			->method('insert')
-			->willReturnCallback(function (Absence $absence): Absence {
-				$absence->setId(1);
-				return $absence;
-			});
-		$this->timezoneService->expects(self::once())
-			->method('getUserTimezone')
-			->with('user')
-			->willReturn($tz->getName());
-		$this->timeFactory->expects(self::once())
-			->method('getTime')
-			->willReturn((new DateTimeImmutable('2023-01-01', $tz))->getTimestamp());
-		$this->jobList->expects(self::exactly(2))
-			->method('scheduleAfter')
-			->willReturnMap([
-				[OutOfOfficeEventDispatcherJob::class, $startDate->getTimestamp(), [
-					'id' => '1',
-					'event' => OutOfOfficeEventDispatcherJob::EVENT_START,
-				]],
-				[OutOfOfficeEventDispatcherJob::class, $endDate->getTimestamp() + 3600 * 23 + 59 * 60, [
-					'id' => '1',
-					'event' => OutOfOfficeEventDispatcherJob::EVENT_END,
-				]],
-			]);
-
-		$this->absenceService->createOrUpdateAbsence(
-			$user,
-			$startDateString,
-			$endDateString,
-			'',
-			'',
-		);
-	}
-
-	public function testCreateAbsenceSchedulesOnlyEndJob(): void {
-		$tz = new DateTimeZone('Europe/Berlin');
-		$endDateString = '2023-01-10';
-		$endDate = new DateTimeImmutable($endDateString, $tz);
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-
-		$this->absenceMapper->expects(self::once())
-			->method('findByUserId')
-			->with('user')
-			->willThrowException(new DoesNotExistException('foo bar'));
-		$this->absenceMapper->expects(self::once())
-			->method('insert')
-			->willReturnCallback(function (Absence $absence): Absence {
-				$absence->setId(1);
-				return $absence;
-			});
-		$this->timezoneService->expects(self::once())
-			->method('getUserTimezone')
-			->with('user')
-			->willReturn($tz->getName());
-		$this->timeFactory->expects(self::once())
-			->method('getTime')
-			->willReturn((new DateTimeImmutable('2023-01-07', $tz))->getTimestamp());
-		$this->jobList->expects(self::once())
-			->method('scheduleAfter')
-			->with(OutOfOfficeEventDispatcherJob::class, $endDate->getTimestamp() + 3600 * 23 + 59 * 60, [
-				'id' => '1',
-				'event' => OutOfOfficeEventDispatcherJob::EVENT_END,
-			]);
-
-		$this->absenceService->createOrUpdateAbsence(
-			$user,
-			'2023-01-05',
-			$endDateString,
-			'',
-			'',
-		);
-	}
-
-	public function testCreateAbsenceSchedulesNoJob(): void {
-		$tz = new DateTimeZone('Europe/Berlin');
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-
-		$this->absenceMapper->expects(self::once())
-			->method('findByUserId')
-			->with('user')
-			->willThrowException(new DoesNotExistException('foo bar'));
-		$this->absenceMapper->expects(self::once())
-			->method('insert')
-			->willReturnCallback(function (Absence $absence): Absence {
-				$absence->setId(1);
-				return $absence;
-			});
-		$this->timezoneService->expects(self::once())
-			->method('getUserTimezone')
-			->with('user')
-			->willReturn($tz->getName());
-		$this->timeFactory->expects(self::once())
-			->method('getTime')
-			->willReturn((new DateTimeImmutable('2023-01-12', $tz))->getTimestamp());
-		$this->jobList->expects(self::never())
-			->method('scheduleAfter');
-
-		$this->absenceService->createOrUpdateAbsence(
-			$user,
-			'2023-01-05',
-			'2023-01-10',
-			'',
-			'',
-		);
-	}
-
-	public function testUpdateAbsenceSchedulesBothJobs(): void {
-		$tz = new DateTimeZone('Europe/Berlin');
-		$startDateString = '2023-01-05';
-		$startDate = new DateTimeImmutable($startDateString, $tz);
-		$endDateString = '2023-01-10';
-		$endDate = new DateTimeImmutable($endDateString, $tz);
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-		$absence = new Absence();
-		$absence->setId(1);
-		$absence->setFirstDay('1970-01-01');
-		$absence->setLastDay('1970-01-10');
-		$absence->setStatus('old status');
-		$absence->setMessage('old message');
-
-		$this->absenceMapper->expects(self::once())
-			->method('findByUserId')
-			->with('user')
-			->willReturn($absence);
-		$this->absenceMapper->expects(self::once())
-			->method('update')
-			->willReturnCallback(static function (Absence $absence) use ($startDateString, $endDateString): Absence {
-				self::assertEquals($startDateString, $absence->getFirstDay());
-				self::assertEquals($endDateString, $absence->getLastDay());
-				return $absence;
-			});
-		$this->timezoneService->expects(self::once())
-			->method('getUserTimezone')
-			->with('user')
-			->willReturn($tz->getName());
-		$this->timeFactory->expects(self::once())
-			->method('getTime')
-			->willReturn((new DateTimeImmutable('2023-01-01', $tz))->getTimestamp());
-		$this->jobList->expects(self::exactly(2))
-			->method('scheduleAfter')
-			->willReturnMap([
-				[OutOfOfficeEventDispatcherJob::class, $startDate->getTimestamp(), [
-					'id' => '1',
-					'event' => OutOfOfficeEventDispatcherJob::EVENT_START,
-				]],
-				[OutOfOfficeEventDispatcherJob::class, $endDate->getTimestamp() + 3600 * 23 + 59 * 60, [
-					'id' => '1',
-					'event' => OutOfOfficeEventDispatcherJob::EVENT_END,
-				]],
-			]);
-
-		$this->absenceService->createOrUpdateAbsence(
-			$user,
-			$startDateString,
-			$endDateString,
-			'',
-			'',
-		);
-	}
-
-	public function testUpdateSchedulesOnlyEndJob(): void {
-		$tz = new DateTimeZone('Europe/Berlin');
-		$endDateString = '2023-01-10';
-		$endDate = new DateTimeImmutable($endDateString, $tz);
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-		$absence = new Absence();
-		$absence->setId(1);
-		$absence->setFirstDay('1970-01-01');
-		$absence->setLastDay('1970-01-10');
-		$absence->setStatus('old status');
-		$absence->setMessage('old message');
-
-		$this->absenceMapper->expects(self::once())
-			->method('findByUserId')
-			->with('user')
-			->willReturn($absence);
-		$this->absenceMapper->expects(self::once())
-			->method('update')
-			->willReturnCallback(static function (Absence $absence) use ($endDateString): Absence {
-				self::assertEquals('2023-01-05', $absence->getFirstDay());
-				self::assertEquals($endDateString, $absence->getLastDay());
-				return $absence;
-			});
-		$this->timezoneService->expects(self::once())
-			->method('getUserTimezone')
-			->with('user')
-			->willReturn($tz->getName());
-		$this->timeFactory->expects(self::once())
-			->method('getTime')
-			->willReturn((new DateTimeImmutable('2023-01-07', $tz))->getTimestamp());
-		$this->jobList->expects(self::once())
-			->method('scheduleAfter')
-			->with(OutOfOfficeEventDispatcherJob::class, $endDate->getTimestamp() + 23 * 3600 + 59 * 60, [
-				'id' => '1',
-				'event' => OutOfOfficeEventDispatcherJob::EVENT_END,
-			]);
-
-		$this->absenceService->createOrUpdateAbsence(
-			$user,
-			'2023-01-05',
-			$endDateString,
-			'',
-			'',
-		);
-	}
-
-	public function testUpdateAbsenceSchedulesNoJob(): void {
-		$tz = new DateTimeZone('Europe/Berlin');
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-		$absence = new Absence();
-		$absence->setId(1);
-		$absence->setFirstDay('1970-01-01');
-		$absence->setLastDay('1970-01-10');
-		$absence->setStatus('old status');
-		$absence->setMessage('old message');
-
-		$this->absenceMapper->expects(self::once())
-			->method('findByUserId')
-			->with('user')
-			->willReturn($absence);
-		$this->absenceMapper->expects(self::once())
-			->method('update')
-			->willReturnCallback(static function (Absence $absence): Absence {
-				self::assertEquals('2023-01-05', $absence->getFirstDay());
-				self::assertEquals('2023-01-10', $absence->getLastDay());
-				return $absence;
-			});
-		$this->timezoneService->expects(self::once())
-			->method('getUserTimezone')
-			->with('user')
-			->willReturn($tz->getName());
-		$this->timeFactory->expects(self::once())
-			->method('getTime')
-			->willReturn((new DateTimeImmutable('2023-01-12', $tz))->getTimestamp());
-		$this->jobList->expects(self::never())
-			->method('scheduleAfter');
-
-		$this->absenceService->createOrUpdateAbsence(
-			$user,
-			'2023-01-05',
-			'2023-01-10',
-			'',
-			'',
-		);
-	}
+    private AbsenceService $absenceService;
+    private AbsenceMapper&MockObject $absenceMapper;
+    private IEventDispatcher&MockObject $eventDispatcher;
+    private IJobList&MockObject $jobList;
+    private TimezoneService&MockObject $timezoneService;
+    private ITimeFactory&MockObject $timeFactory;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->absenceMapper = $this->createMock(AbsenceMapper::class);
+        $this->eventDispatcher = $this->createMock(IEventDispatcher::class);
+        $this->jobList = $this->createMock(IJobList::class);
+        $this->timezoneService = $this->createMock(TimezoneService::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+
+        $this->absenceService = new AbsenceService(
+            $this->absenceMapper,
+            $this->eventDispatcher,
+            $this->jobList,
+            $this->timezoneService,
+            $this->timeFactory,
+        );
+    }
+
+    public function testCreateAbsenceEmitsScheduledEvent(): void {
+        $tz = new DateTimeZone('Europe/Berlin');
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+
+        $this->absenceMapper->expects(self::once())
+            ->method('findByUserId')
+            ->with('user')
+            ->willThrowException(new DoesNotExistException('foo bar'));
+        $this->absenceMapper->expects(self::once())
+            ->method('insert')
+            ->willReturnCallback(function (Absence $absence): Absence {
+                $absence->setId(1);
+                return $absence;
+            });
+        $this->timezoneService->expects(self::once())
+            ->method('getUserTimezone')
+            ->with('user')
+            ->willReturn('Europe/Berlin');
+        $this->eventDispatcher->expects(self::once())
+            ->method('dispatchTyped')
+            ->with(self::callback(static function (Event $event) use ($user, $tz): bool {
+                self::assertInstanceOf(OutOfOfficeScheduledEvent::class, $event);
+                /** @var OutOfOfficeScheduledEvent $event */
+                $data = $event->getData();
+                self::assertEquals('1', $data->getId());
+                self::assertEquals($user, $data->getUser());
+                self::assertEquals(
+                    (new DateTimeImmutable('2023-01-05', $tz))->getTimeStamp(),
+                    $data->getStartDate(),
+                );
+                self::assertEquals(
+                    (new DateTimeImmutable('2023-01-10', $tz))->getTimeStamp() + 3600 * 23 + 59 * 60,
+                    $data->getEndDate(),
+                );
+                self::assertEquals('status', $data->getShortMessage());
+                self::assertEquals('message', $data->getMessage());
+                return true;
+            }));
+        $this->timeFactory->expects(self::once())
+            ->method('getTime')
+            ->willReturn(PHP_INT_MAX);
+        $this->jobList->expects(self::never())
+            ->method('scheduleAfter');
+
+        $this->absenceService->createOrUpdateAbsence(
+            $user,
+            '2023-01-05',
+            '2023-01-10',
+            'status',
+            'message',
+        );
+    }
+
+    public function testUpdateAbsenceEmitsChangedEvent(): void {
+        $tz = new DateTimeZone('Europe/Berlin');
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+        $absence = new Absence();
+        $absence->setId(1);
+        $absence->setFirstDay('1970-01-01');
+        $absence->setLastDay('1970-01-10');
+        $absence->setStatus('old status');
+        $absence->setMessage('old message');
+
+        $this->absenceMapper->expects(self::once())
+            ->method('findByUserId')
+            ->with('user')
+            ->willReturn($absence);
+        $this->absenceMapper->expects(self::once())
+            ->method('update')
+            ->willReturnCallback(static function (Absence $absence): Absence {
+                self::assertEquals('2023-01-05', $absence->getFirstDay());
+                self::assertEquals('2023-01-10', $absence->getLastDay());
+                self::assertEquals('status', $absence->getStatus());
+                self::assertEquals('message', $absence->getMessage());
+                return $absence;
+            });
+        $this->timezoneService->expects(self::once())
+            ->method('getUserTimezone')
+            ->with('user')
+            ->willReturn('Europe/Berlin');
+        $this->eventDispatcher->expects(self::once())
+            ->method('dispatchTyped')
+            ->with(self::callback(static function (Event $event) use ($user, $tz): bool {
+                self::assertInstanceOf(OutOfOfficeChangedEvent::class, $event);
+                /** @var OutOfOfficeChangedEvent $event */
+                $data = $event->getData();
+                self::assertEquals('1', $data->getId());
+                self::assertEquals($user, $data->getUser());
+                self::assertEquals(
+                    (new DateTimeImmutable('2023-01-05', $tz))->getTimeStamp(),
+                    $data->getStartDate(),
+                );
+                self::assertEquals(
+                    (new DateTimeImmutable('2023-01-10', $tz))->getTimeStamp() + 3600 * 23 + 59 * 60,
+                    $data->getEndDate(),
+                );
+                self::assertEquals('status', $data->getShortMessage());
+                self::assertEquals('message', $data->getMessage());
+                return true;
+            }));
+        $this->timeFactory->expects(self::once())
+            ->method('getTime')
+            ->willReturn(PHP_INT_MAX);
+        $this->jobList->expects(self::never())
+            ->method('scheduleAfter');
+
+        $this->absenceService->createOrUpdateAbsence(
+            $user,
+            '2023-01-05',
+            '2023-01-10',
+            'status',
+            'message',
+        );
+    }
+
+    public function testCreateAbsenceSchedulesBothJobs(): void {
+        $tz = new DateTimeZone('Europe/Berlin');
+        $startDateString = '2023-01-05';
+        $startDate = new DateTimeImmutable($startDateString, $tz);
+        $endDateString = '2023-01-10';
+        $endDate = new DateTimeImmutable($endDateString, $tz);
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+
+        $this->absenceMapper->expects(self::once())
+            ->method('findByUserId')
+            ->with('user')
+            ->willThrowException(new DoesNotExistException('foo bar'));
+        $this->absenceMapper->expects(self::once())
+            ->method('insert')
+            ->willReturnCallback(function (Absence $absence): Absence {
+                $absence->setId(1);
+                return $absence;
+            });
+        $this->timezoneService->expects(self::once())
+            ->method('getUserTimezone')
+            ->with('user')
+            ->willReturn($tz->getName());
+        $this->timeFactory->expects(self::once())
+            ->method('getTime')
+            ->willReturn((new DateTimeImmutable('2023-01-01', $tz))->getTimestamp());
+        $this->jobList->expects(self::exactly(2))
+            ->method('scheduleAfter')
+            ->willReturnMap([
+                [OutOfOfficeEventDispatcherJob::class, $startDate->getTimestamp(), [
+                    'id' => '1',
+                    'event' => OutOfOfficeEventDispatcherJob::EVENT_START,
+                ]],
+                [OutOfOfficeEventDispatcherJob::class, $endDate->getTimestamp() + 3600 * 23 + 59 * 60, [
+                    'id' => '1',
+                    'event' => OutOfOfficeEventDispatcherJob::EVENT_END,
+                ]],
+            ]);
+
+        $this->absenceService->createOrUpdateAbsence(
+            $user,
+            $startDateString,
+            $endDateString,
+            '',
+            '',
+        );
+    }
+
+    public function testCreateAbsenceSchedulesOnlyEndJob(): void {
+        $tz = new DateTimeZone('Europe/Berlin');
+        $endDateString = '2023-01-10';
+        $endDate = new DateTimeImmutable($endDateString, $tz);
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+
+        $this->absenceMapper->expects(self::once())
+            ->method('findByUserId')
+            ->with('user')
+            ->willThrowException(new DoesNotExistException('foo bar'));
+        $this->absenceMapper->expects(self::once())
+            ->method('insert')
+            ->willReturnCallback(function (Absence $absence): Absence {
+                $absence->setId(1);
+                return $absence;
+            });
+        $this->timezoneService->expects(self::once())
+            ->method('getUserTimezone')
+            ->with('user')
+            ->willReturn($tz->getName());
+        $this->timeFactory->expects(self::once())
+            ->method('getTime')
+            ->willReturn((new DateTimeImmutable('2023-01-07', $tz))->getTimestamp());
+        $this->jobList->expects(self::once())
+            ->method('scheduleAfter')
+            ->with(OutOfOfficeEventDispatcherJob::class, $endDate->getTimestamp() + 3600 * 23 + 59 * 60, [
+                'id' => '1',
+                'event' => OutOfOfficeEventDispatcherJob::EVENT_END,
+            ]);
+
+        $this->absenceService->createOrUpdateAbsence(
+            $user,
+            '2023-01-05',
+            $endDateString,
+            '',
+            '',
+        );
+    }
+
+    public function testCreateAbsenceSchedulesNoJob(): void {
+        $tz = new DateTimeZone('Europe/Berlin');
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+
+        $this->absenceMapper->expects(self::once())
+            ->method('findByUserId')
+            ->with('user')
+            ->willThrowException(new DoesNotExistException('foo bar'));
+        $this->absenceMapper->expects(self::once())
+            ->method('insert')
+            ->willReturnCallback(function (Absence $absence): Absence {
+                $absence->setId(1);
+                return $absence;
+            });
+        $this->timezoneService->expects(self::once())
+            ->method('getUserTimezone')
+            ->with('user')
+            ->willReturn($tz->getName());
+        $this->timeFactory->expects(self::once())
+            ->method('getTime')
+            ->willReturn((new DateTimeImmutable('2023-01-12', $tz))->getTimestamp());
+        $this->jobList->expects(self::never())
+            ->method('scheduleAfter');
+
+        $this->absenceService->createOrUpdateAbsence(
+            $user,
+            '2023-01-05',
+            '2023-01-10',
+            '',
+            '',
+        );
+    }
+
+    public function testUpdateAbsenceSchedulesBothJobs(): void {
+        $tz = new DateTimeZone('Europe/Berlin');
+        $startDateString = '2023-01-05';
+        $startDate = new DateTimeImmutable($startDateString, $tz);
+        $endDateString = '2023-01-10';
+        $endDate = new DateTimeImmutable($endDateString, $tz);
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+        $absence = new Absence();
+        $absence->setId(1);
+        $absence->setFirstDay('1970-01-01');
+        $absence->setLastDay('1970-01-10');
+        $absence->setStatus('old status');
+        $absence->setMessage('old message');
+
+        $this->absenceMapper->expects(self::once())
+            ->method('findByUserId')
+            ->with('user')
+            ->willReturn($absence);
+        $this->absenceMapper->expects(self::once())
+            ->method('update')
+            ->willReturnCallback(static function (Absence $absence) use ($startDateString, $endDateString): Absence {
+                self::assertEquals($startDateString, $absence->getFirstDay());
+                self::assertEquals($endDateString, $absence->getLastDay());
+                return $absence;
+            });
+        $this->timezoneService->expects(self::once())
+            ->method('getUserTimezone')
+            ->with('user')
+            ->willReturn($tz->getName());
+        $this->timeFactory->expects(self::once())
+            ->method('getTime')
+            ->willReturn((new DateTimeImmutable('2023-01-01', $tz))->getTimestamp());
+        $this->jobList->expects(self::exactly(2))
+            ->method('scheduleAfter')
+            ->willReturnMap([
+                [OutOfOfficeEventDispatcherJob::class, $startDate->getTimestamp(), [
+                    'id' => '1',
+                    'event' => OutOfOfficeEventDispatcherJob::EVENT_START,
+                ]],
+                [OutOfOfficeEventDispatcherJob::class, $endDate->getTimestamp() + 3600 * 23 + 59 * 60, [
+                    'id' => '1',
+                    'event' => OutOfOfficeEventDispatcherJob::EVENT_END,
+                ]],
+            ]);
+
+        $this->absenceService->createOrUpdateAbsence(
+            $user,
+            $startDateString,
+            $endDateString,
+            '',
+            '',
+        );
+    }
+
+    public function testUpdateSchedulesOnlyEndJob(): void {
+        $tz = new DateTimeZone('Europe/Berlin');
+        $endDateString = '2023-01-10';
+        $endDate = new DateTimeImmutable($endDateString, $tz);
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+        $absence = new Absence();
+        $absence->setId(1);
+        $absence->setFirstDay('1970-01-01');
+        $absence->setLastDay('1970-01-10');
+        $absence->setStatus('old status');
+        $absence->setMessage('old message');
+
+        $this->absenceMapper->expects(self::once())
+            ->method('findByUserId')
+            ->with('user')
+            ->willReturn($absence);
+        $this->absenceMapper->expects(self::once())
+            ->method('update')
+            ->willReturnCallback(static function (Absence $absence) use ($endDateString): Absence {
+                self::assertEquals('2023-01-05', $absence->getFirstDay());
+                self::assertEquals($endDateString, $absence->getLastDay());
+                return $absence;
+            });
+        $this->timezoneService->expects(self::once())
+            ->method('getUserTimezone')
+            ->with('user')
+            ->willReturn($tz->getName());
+        $this->timeFactory->expects(self::once())
+            ->method('getTime')
+            ->willReturn((new DateTimeImmutable('2023-01-07', $tz))->getTimestamp());
+        $this->jobList->expects(self::once())
+            ->method('scheduleAfter')
+            ->with(OutOfOfficeEventDispatcherJob::class, $endDate->getTimestamp() + 23 * 3600 + 59 * 60, [
+                'id' => '1',
+                'event' => OutOfOfficeEventDispatcherJob::EVENT_END,
+            ]);
+
+        $this->absenceService->createOrUpdateAbsence(
+            $user,
+            '2023-01-05',
+            $endDateString,
+            '',
+            '',
+        );
+    }
+
+    public function testUpdateAbsenceSchedulesNoJob(): void {
+        $tz = new DateTimeZone('Europe/Berlin');
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+        $absence = new Absence();
+        $absence->setId(1);
+        $absence->setFirstDay('1970-01-01');
+        $absence->setLastDay('1970-01-10');
+        $absence->setStatus('old status');
+        $absence->setMessage('old message');
+
+        $this->absenceMapper->expects(self::once())
+            ->method('findByUserId')
+            ->with('user')
+            ->willReturn($absence);
+        $this->absenceMapper->expects(self::once())
+            ->method('update')
+            ->willReturnCallback(static function (Absence $absence): Absence {
+                self::assertEquals('2023-01-05', $absence->getFirstDay());
+                self::assertEquals('2023-01-10', $absence->getLastDay());
+                return $absence;
+            });
+        $this->timezoneService->expects(self::once())
+            ->method('getUserTimezone')
+            ->with('user')
+            ->willReturn($tz->getName());
+        $this->timeFactory->expects(self::once())
+            ->method('getTime')
+            ->willReturn((new DateTimeImmutable('2023-01-12', $tz))->getTimestamp());
+        $this->jobList->expects(self::never())
+            ->method('scheduleAfter');
+
+        $this->absenceService->createOrUpdateAbsence(
+            $user,
+            '2023-01-05',
+            '2023-01-10',
+            '',
+            '',
+        );
+    }
 }