nextcloud / server

apps/dav/tests/unit/DAV/AnonymousOptionsTest.php

Indentation +52 added lines, -52 removed lines

@@ -16,77 +16,77 @@
 use Test\TestCase;
 
 class AnonymousOptionsTest extends TestCase {
-	private function sendRequest(string $method, string $path, string $userAgent = '') {
-		$server = new Server();
-		$server->addPlugin(new AnonymousOptionsPlugin());
-		$server->addPlugin(new Plugin(new BasicCallBack(function () {
-			return false;
-		})));
+    private function sendRequest(string $method, string $path, string $userAgent = '') {
+        $server = new Server();
+        $server->addPlugin(new AnonymousOptionsPlugin());
+        $server->addPlugin(new Plugin(new BasicCallBack(function () {
+            return false;
+        })));
 
-		$server->httpRequest->setMethod($method);
-		$server->httpRequest->setUrl($path);
-		$server->httpRequest->setHeader('User-Agent', $userAgent);
+        $server->httpRequest->setMethod($method);
+        $server->httpRequest->setUrl($path);
+        $server->httpRequest->setHeader('User-Agent', $userAgent);
 
-		$server->sapi = new SapiMock();
-		$server->exec();
-		return $server->httpResponse;
-	}
+        $server->sapi = new SapiMock();
+        $server->exec();
+        return $server->httpResponse;
+    }
 
-	public function testAnonymousOptionsRoot(): void {
-		$response = $this->sendRequest('OPTIONS', '');
+    public function testAnonymousOptionsRoot(): void {
+        $response = $this->sendRequest('OPTIONS', '');
 
-		$this->assertEquals(401, $response->getStatus());
-	}
+        $this->assertEquals(401, $response->getStatus());
+    }
 
-	public function testAnonymousOptionsNonRoot(): void {
-		$response = $this->sendRequest('OPTIONS', 'foo');
+    public function testAnonymousOptionsNonRoot(): void {
+        $response = $this->sendRequest('OPTIONS', 'foo');
 
-		$this->assertEquals(401, $response->getStatus());
-	}
+        $this->assertEquals(401, $response->getStatus());
+    }
 
-	public function testAnonymousOptionsNonRootSubDir(): void {
-		$response = $this->sendRequest('OPTIONS', 'foo/bar');
+    public function testAnonymousOptionsNonRootSubDir(): void {
+        $response = $this->sendRequest('OPTIONS', 'foo/bar');
 
-		$this->assertEquals(401, $response->getStatus());
-	}
+        $this->assertEquals(401, $response->getStatus());
+    }
 
-	public function testAnonymousOptionsRootOffice(): void {
-		$response = $this->sendRequest('OPTIONS', '', 'Microsoft Office does strange things');
+    public function testAnonymousOptionsRootOffice(): void {
+        $response = $this->sendRequest('OPTIONS', '', 'Microsoft Office does strange things');
 
-		$this->assertEquals(200, $response->getStatus());
-	}
+        $this->assertEquals(200, $response->getStatus());
+    }
 
-	public function testAnonymousOptionsNonRootOffice(): void {
-		$response = $this->sendRequest('OPTIONS', 'foo', 'Microsoft Office does strange things');
+    public function testAnonymousOptionsNonRootOffice(): void {
+        $response = $this->sendRequest('OPTIONS', 'foo', 'Microsoft Office does strange things');
 
-		$this->assertEquals(200, $response->getStatus());
-	}
+        $this->assertEquals(200, $response->getStatus());
+    }
 
-	public function testAnonymousOptionsNonRootSubDirOffice(): void {
-		$response = $this->sendRequest('OPTIONS', 'foo/bar', 'Microsoft Office does strange things');
+    public function testAnonymousOptionsNonRootSubDirOffice(): void {
+        $response = $this->sendRequest('OPTIONS', 'foo/bar', 'Microsoft Office does strange things');
 
-		$this->assertEquals(200, $response->getStatus());
-	}
+        $this->assertEquals(200, $response->getStatus());
+    }
 
-	public function testAnonymousHead(): void {
-		$response = $this->sendRequest('HEAD', '', 'Microsoft Office does strange things');
+    public function testAnonymousHead(): void {
+        $response = $this->sendRequest('HEAD', '', 'Microsoft Office does strange things');
 
-		$this->assertEquals(200, $response->getStatus());
-	}
+        $this->assertEquals(200, $response->getStatus());
+    }
 
-	public function testAnonymousHeadNoOffice(): void {
-		$response = $this->sendRequest('HEAD', '');
+    public function testAnonymousHeadNoOffice(): void {
+        $response = $this->sendRequest('HEAD', '');
 
-		$this->assertEquals(401, $response->getStatus(), 'curl');
-	}
+        $this->assertEquals(401, $response->getStatus(), 'curl');
+    }
 }
 
 class SapiMock extends Sapi {
-	/**
-	 * Overriding this so nothing is ever echo'd.
-	 *
-	 * @return void
-	 */
-	public static function sendResponse(ResponseInterface $response): void {
-	}
+    /**
+     * Overriding this so nothing is ever echo'd.
+     *
+     * @return void
+     */
+    public static function sendResponse(ResponseInterface $response): void {
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
 	private function sendRequest(string $method, string $path, string $userAgent = '') {
 		$server = new Server();
 		$server->addPlugin(new AnonymousOptionsPlugin());
-		$server->addPlugin(new Plugin(new BasicCallBack(function () {
+		$server->addPlugin(new Plugin(new BasicCallBack(function() {
 			return false;
 		})));
 

apps/dav/tests/unit/DAV/GroupPrincipalTest.php

Indentation +312 added lines, -312 removed lines

@@ -20,316 +20,316 @@
 use Sabre\DAV\PropPatch;
 
 class GroupPrincipalTest extends \Test\TestCase {
-	private IConfig&MockObject $config;
-	private IGroupManager&MockObject $groupManager;
-	private IUserSession&MockObject $userSession;
-	private IManager&MockObject $shareManager;
-	private GroupPrincipalBackend $connector;
-
-	protected function setUp(): void {
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->shareManager = $this->createMock(IManager::class);
-		$this->config = $this->createMock(IConfig::class);
-
-		$this->connector = new GroupPrincipalBackend(
-			$this->groupManager,
-			$this->userSession,
-			$this->shareManager,
-			$this->config
-		);
-		parent::setUp();
-	}
-
-	public function testGetPrincipalsByPrefixWithoutPrefix(): void {
-		$response = $this->connector->getPrincipalsByPrefix('');
-		$this->assertSame([], $response);
-	}
-
-	public function testGetPrincipalsByPrefixWithUsers(): void {
-		$group1 = $this->mockGroup('foo');
-		$group2 = $this->mockGroup('bar');
-		$this->groupManager
-			->expects($this->once())
-			->method('search')
-			->with('')
-			->willReturn([$group1, $group2]);
-
-		$expectedResponse = [
-			0 => [
-				'uri' => 'principals/groups/foo',
-				'{DAV:}displayname' => 'Group foo',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-			],
-			1 => [
-				'uri' => 'principals/groups/bar',
-				'{DAV:}displayname' => 'Group bar',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-			]
-		];
-		$response = $this->connector->getPrincipalsByPrefix('principals/groups');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetPrincipalsByPrefixEmpty(): void {
-		$this->groupManager
-			->expects($this->once())
-			->method('search')
-			->with('')
-			->willReturn([]);
-
-		$response = $this->connector->getPrincipalsByPrefix('principals/groups');
-		$this->assertSame([], $response);
-	}
-
-	public function testGetPrincipalsByPathWithoutMail(): void {
-		$group1 = $this->mockGroup('foo');
-		$this->groupManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn($group1);
-
-		$expectedResponse = [
-			'uri' => 'principals/groups/foo',
-			'{DAV:}displayname' => 'Group foo',
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-		];
-		$response = $this->connector->getPrincipalByPath('principals/groups/foo');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetPrincipalsByPathWithMail(): void {
-		$fooUser = $this->mockGroup('foo');
-		$this->groupManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn($fooUser);
-
-		$expectedResponse = [
-			'uri' => 'principals/groups/foo',
-			'{DAV:}displayname' => 'Group foo',
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-		];
-		$response = $this->connector->getPrincipalByPath('principals/groups/foo');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetPrincipalsByPathEmpty(): void {
-		$this->groupManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn(null);
-
-		$response = $this->connector->getPrincipalByPath('principals/groups/foo');
-		$this->assertSame(null, $response);
-	}
-
-	public function testGetPrincipalsByPathGroupWithSlash(): void {
-		$group1 = $this->mockGroup('foo/bar');
-		$this->groupManager
-			->expects($this->once())
-			->method('get')
-			->with('foo/bar')
-			->willReturn($group1);
-
-		$expectedResponse = [
-			'uri' => 'principals/groups/foo%2Fbar',
-			'{DAV:}displayname' => 'Group foo/bar',
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-		];
-		$response = $this->connector->getPrincipalByPath('principals/groups/foo/bar');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetPrincipalsByPathGroupWithHash(): void {
-		$group1 = $this->mockGroup('foo#bar');
-		$this->groupManager
-			->expects($this->once())
-			->method('get')
-			->with('foo#bar')
-			->willReturn($group1);
-
-		$expectedResponse = [
-			'uri' => 'principals/groups/foo%23bar',
-			'{DAV:}displayname' => 'Group foo#bar',
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-		];
-		$response = $this->connector->getPrincipalByPath('principals/groups/foo#bar');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetGroupMemberSet(): void {
-		$response = $this->connector->getGroupMemberSet('principals/groups/foo');
-		$this->assertSame([], $response);
-	}
-
-	public function testGetGroupMembership(): void {
-		$response = $this->connector->getGroupMembership('principals/groups/foo');
-		$this->assertSame([], $response);
-	}
-
-
-	public function testSetGroupMembership(): void {
-		$this->expectException(\Sabre\DAV\Exception::class);
-		$this->expectExceptionMessage('Setting members of the group is not supported yet');
-
-		$this->connector->setGroupMemberSet('principals/groups/foo', ['foo']);
-	}
-
-	public function testUpdatePrincipal(): void {
-		$this->assertSame(0, $this->connector->updatePrincipal('foo', new PropPatch([])));
-	}
-
-	public function testSearchPrincipalsWithEmptySearchProperties(): void {
-		$this->assertSame([], $this->connector->searchPrincipals('principals/groups', []));
-	}
-
-	public function testSearchPrincipalsWithWrongPrefixPath(): void {
-		$this->assertSame([], $this->connector->searchPrincipals('principals/users',
-			['{DAV:}displayname' => 'Foo']));
-	}
-
-	/**
-	 * @dataProvider searchPrincipalsDataProvider
-	 */
-	public function testSearchPrincipals(bool $sharingEnabled, bool $groupSharingEnabled, bool $groupsOnly, string $test, array $result): void {
-		$this->shareManager->expects($this->once())
-			->method('shareAPIEnabled')
-			->willReturn($sharingEnabled);
-
-		$this->shareManager->expects($sharingEnabled ? $this->once() : $this->never())
-			->method('allowGroupSharing')
-			->willReturn($groupSharingEnabled);
-
-		if ($sharingEnabled && $groupSharingEnabled) {
-			$this->shareManager->expects($this->once())
-				->method('shareWithGroupMembersOnly')
-				->willReturn($groupsOnly);
-
-			if ($groupsOnly) {
-				$user = $this->createMock(IUser::class);
-				$this->userSession->expects($this->once())
-					->method('getUser')
-					->willReturn($user);
-
-				$this->groupManager->expects($this->once())
-					->method('getUserGroupIds')
-					->with($user)
-					->willReturn(['group1', 'group2', 'group5']);
-			}
-		} else {
-			$this->shareManager->expects($this->never())
-				->method('shareWithGroupMembersOnly');
-			$this->groupManager->expects($this->never())
-				->method($this->anything());
-		}
-
-		$group1 = $this->createMock(IGroup::class);
-		$group1->method('getGID')->willReturn('group1');
-		$group2 = $this->createMock(IGroup::class);
-		$group2->method('getGID')->willReturn('group2');
-		$group3 = $this->createMock(IGroup::class);
-		$group3->method('getGID')->willReturn('group3');
-		$group4 = $this->createMock(IGroup::class);
-		$group4->method('getGID')->willReturn('group4');
-		$group5 = $this->createMock(IGroup::class);
-		$group5->method('getGID')->willReturn('group5');
-
-		if ($sharingEnabled && $groupSharingEnabled) {
-			$this->groupManager->expects($this->once())
-				->method('search')
-				->with('Foo')
-				->willReturn([$group1, $group2, $group3, $group4, $group5]);
-		} else {
-			$this->groupManager->expects($this->never())
-				->method('search');
-		}
-
-		$this->assertSame($result, $this->connector->searchPrincipals('principals/groups',
-			['{DAV:}displayname' => 'Foo'], $test));
-	}
-
-	public static function searchPrincipalsDataProvider(): array {
-		return [
-			[true, true, false, 'allof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group3', 'principals/groups/group4', 'principals/groups/group5']],
-			[true, true, false, 'anyof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group3', 'principals/groups/group4', 'principals/groups/group5']],
-			[true, true, true, 'allof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group5']],
-			[true, true, true, 'anyof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group5']],
-			[true, false, false, 'allof', []],
-			[false, true, false, 'anyof', []],
-			[false, false, false, 'allof', []],
-			[false, false, false, 'anyof', []],
-		];
-	}
-
-	/**
-	 * @dataProvider findByUriDataProvider
-	 */
-	public function testFindByUri(bool $sharingEnabled, bool $groupSharingEnabled, bool $groupsOnly, string $findUri, ?string $result): void {
-		$this->shareManager->expects($this->once())
-			->method('shareAPIEnabled')
-			->willReturn($sharingEnabled);
-
-		$this->shareManager->expects($sharingEnabled ? $this->once() : $this->never())
-			->method('allowGroupSharing')
-			->willReturn($groupSharingEnabled);
-
-		if ($sharingEnabled && $groupSharingEnabled) {
-			$this->shareManager->expects($this->once())
-				->method('shareWithGroupMembersOnly')
-				->willReturn($groupsOnly);
-
-			if ($groupsOnly) {
-				$user = $this->createMock(IUser::class);
-				$this->userSession->expects($this->once())
-					->method('getUser')
-					->willReturn($user);
-
-				$this->groupManager->expects($this->once())
-					->method('getUserGroupIds')
-					->with($user)
-					->willReturn(['group1', 'group2', 'group5']);
-			}
-		} else {
-			$this->shareManager->expects($this->never())
-				->method('shareWithGroupMembersOnly');
-			$this->groupManager->expects($this->never())
-				->method($this->anything());
-		}
-
-		$this->assertEquals($result, $this->connector->findByUri($findUri, 'principals/groups'));
-	}
-
-	public static function findByUriDataProvider(): array {
-		return [
-			[false, false, false, 'principal:principals/groups/group1', null],
-			[false, false, false, 'principal:principals/groups/group3', null],
-			[false, true, false, 'principal:principals/groups/group1', null],
-			[false, true, false, 'principal:principals/groups/group3', null],
-			[false, false, true, 'principal:principals/groups/group1', null],
-			[false, false, true, 'principal:principals/groups/group3', null],
-			[true, false, true, 'principal:principals/groups/group1', null],
-			[true, false, true, 'principal:principals/groups/group3', null],
-			[true, true, true, 'principal:principals/groups/group1', 'principals/groups/group1'],
-			[true, true, true, 'principal:principals/groups/group3', null],
-			[true, true, false, 'principal:principals/groups/group1', 'principals/groups/group1'],
-			[true, true, false, 'principal:principals/groups/group3', 'principals/groups/group3'],
-		];
-	}
-
-	private function mockGroup(string $gid): Group&MockObject {
-		$fooGroup = $this->createMock(Group::class);
-		$fooGroup
-			->expects($this->exactly(1))
-			->method('getGID')
-			->willReturn($gid);
-		$fooGroup
-			->expects($this->exactly(1))
-			->method('getDisplayName')
-			->willReturn('Group ' . $gid);
-		return $fooGroup;
-	}
+    private IConfig&MockObject $config;
+    private IGroupManager&MockObject $groupManager;
+    private IUserSession&MockObject $userSession;
+    private IManager&MockObject $shareManager;
+    private GroupPrincipalBackend $connector;
+
+    protected function setUp(): void {
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->shareManager = $this->createMock(IManager::class);
+        $this->config = $this->createMock(IConfig::class);
+
+        $this->connector = new GroupPrincipalBackend(
+            $this->groupManager,
+            $this->userSession,
+            $this->shareManager,
+            $this->config
+        );
+        parent::setUp();
+    }
+
+    public function testGetPrincipalsByPrefixWithoutPrefix(): void {
+        $response = $this->connector->getPrincipalsByPrefix('');
+        $this->assertSame([], $response);
+    }
+
+    public function testGetPrincipalsByPrefixWithUsers(): void {
+        $group1 = $this->mockGroup('foo');
+        $group2 = $this->mockGroup('bar');
+        $this->groupManager
+            ->expects($this->once())
+            ->method('search')
+            ->with('')
+            ->willReturn([$group1, $group2]);
+
+        $expectedResponse = [
+            0 => [
+                'uri' => 'principals/groups/foo',
+                '{DAV:}displayname' => 'Group foo',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+            ],
+            1 => [
+                'uri' => 'principals/groups/bar',
+                '{DAV:}displayname' => 'Group bar',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+            ]
+        ];
+        $response = $this->connector->getPrincipalsByPrefix('principals/groups');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetPrincipalsByPrefixEmpty(): void {
+        $this->groupManager
+            ->expects($this->once())
+            ->method('search')
+            ->with('')
+            ->willReturn([]);
+
+        $response = $this->connector->getPrincipalsByPrefix('principals/groups');
+        $this->assertSame([], $response);
+    }
+
+    public function testGetPrincipalsByPathWithoutMail(): void {
+        $group1 = $this->mockGroup('foo');
+        $this->groupManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn($group1);
+
+        $expectedResponse = [
+            'uri' => 'principals/groups/foo',
+            '{DAV:}displayname' => 'Group foo',
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+        ];
+        $response = $this->connector->getPrincipalByPath('principals/groups/foo');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetPrincipalsByPathWithMail(): void {
+        $fooUser = $this->mockGroup('foo');
+        $this->groupManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn($fooUser);
+
+        $expectedResponse = [
+            'uri' => 'principals/groups/foo',
+            '{DAV:}displayname' => 'Group foo',
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+        ];
+        $response = $this->connector->getPrincipalByPath('principals/groups/foo');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetPrincipalsByPathEmpty(): void {
+        $this->groupManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn(null);
+
+        $response = $this->connector->getPrincipalByPath('principals/groups/foo');
+        $this->assertSame(null, $response);
+    }
+
+    public function testGetPrincipalsByPathGroupWithSlash(): void {
+        $group1 = $this->mockGroup('foo/bar');
+        $this->groupManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo/bar')
+            ->willReturn($group1);
+
+        $expectedResponse = [
+            'uri' => 'principals/groups/foo%2Fbar',
+            '{DAV:}displayname' => 'Group foo/bar',
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+        ];
+        $response = $this->connector->getPrincipalByPath('principals/groups/foo/bar');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetPrincipalsByPathGroupWithHash(): void {
+        $group1 = $this->mockGroup('foo#bar');
+        $this->groupManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo#bar')
+            ->willReturn($group1);
+
+        $expectedResponse = [
+            'uri' => 'principals/groups/foo%23bar',
+            '{DAV:}displayname' => 'Group foo#bar',
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+        ];
+        $response = $this->connector->getPrincipalByPath('principals/groups/foo#bar');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetGroupMemberSet(): void {
+        $response = $this->connector->getGroupMemberSet('principals/groups/foo');
+        $this->assertSame([], $response);
+    }
+
+    public function testGetGroupMembership(): void {
+        $response = $this->connector->getGroupMembership('principals/groups/foo');
+        $this->assertSame([], $response);
+    }
+
+
+    public function testSetGroupMembership(): void {
+        $this->expectException(\Sabre\DAV\Exception::class);
+        $this->expectExceptionMessage('Setting members of the group is not supported yet');
+
+        $this->connector->setGroupMemberSet('principals/groups/foo', ['foo']);
+    }
+
+    public function testUpdatePrincipal(): void {
+        $this->assertSame(0, $this->connector->updatePrincipal('foo', new PropPatch([])));
+    }
+
+    public function testSearchPrincipalsWithEmptySearchProperties(): void {
+        $this->assertSame([], $this->connector->searchPrincipals('principals/groups', []));
+    }
+
+    public function testSearchPrincipalsWithWrongPrefixPath(): void {
+        $this->assertSame([], $this->connector->searchPrincipals('principals/users',
+            ['{DAV:}displayname' => 'Foo']));
+    }
+
+    /**
+     * @dataProvider searchPrincipalsDataProvider
+     */
+    public function testSearchPrincipals(bool $sharingEnabled, bool $groupSharingEnabled, bool $groupsOnly, string $test, array $result): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareAPIEnabled')
+            ->willReturn($sharingEnabled);
+
+        $this->shareManager->expects($sharingEnabled ? $this->once() : $this->never())
+            ->method('allowGroupSharing')
+            ->willReturn($groupSharingEnabled);
+
+        if ($sharingEnabled && $groupSharingEnabled) {
+            $this->shareManager->expects($this->once())
+                ->method('shareWithGroupMembersOnly')
+                ->willReturn($groupsOnly);
+
+            if ($groupsOnly) {
+                $user = $this->createMock(IUser::class);
+                $this->userSession->expects($this->once())
+                    ->method('getUser')
+                    ->willReturn($user);
+
+                $this->groupManager->expects($this->once())
+                    ->method('getUserGroupIds')
+                    ->with($user)
+                    ->willReturn(['group1', 'group2', 'group5']);
+            }
+        } else {
+            $this->shareManager->expects($this->never())
+                ->method('shareWithGroupMembersOnly');
+            $this->groupManager->expects($this->never())
+                ->method($this->anything());
+        }
+
+        $group1 = $this->createMock(IGroup::class);
+        $group1->method('getGID')->willReturn('group1');
+        $group2 = $this->createMock(IGroup::class);
+        $group2->method('getGID')->willReturn('group2');
+        $group3 = $this->createMock(IGroup::class);
+        $group3->method('getGID')->willReturn('group3');
+        $group4 = $this->createMock(IGroup::class);
+        $group4->method('getGID')->willReturn('group4');
+        $group5 = $this->createMock(IGroup::class);
+        $group5->method('getGID')->willReturn('group5');
+
+        if ($sharingEnabled && $groupSharingEnabled) {
+            $this->groupManager->expects($this->once())
+                ->method('search')
+                ->with('Foo')
+                ->willReturn([$group1, $group2, $group3, $group4, $group5]);
+        } else {
+            $this->groupManager->expects($this->never())
+                ->method('search');
+        }
+
+        $this->assertSame($result, $this->connector->searchPrincipals('principals/groups',
+            ['{DAV:}displayname' => 'Foo'], $test));
+    }
+
+    public static function searchPrincipalsDataProvider(): array {
+        return [
+            [true, true, false, 'allof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group3', 'principals/groups/group4', 'principals/groups/group5']],
+            [true, true, false, 'anyof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group3', 'principals/groups/group4', 'principals/groups/group5']],
+            [true, true, true, 'allof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group5']],
+            [true, true, true, 'anyof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group5']],
+            [true, false, false, 'allof', []],
+            [false, true, false, 'anyof', []],
+            [false, false, false, 'allof', []],
+            [false, false, false, 'anyof', []],
+        ];
+    }
+
+    /**
+     * @dataProvider findByUriDataProvider
+     */
+    public function testFindByUri(bool $sharingEnabled, bool $groupSharingEnabled, bool $groupsOnly, string $findUri, ?string $result): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareAPIEnabled')
+            ->willReturn($sharingEnabled);
+
+        $this->shareManager->expects($sharingEnabled ? $this->once() : $this->never())
+            ->method('allowGroupSharing')
+            ->willReturn($groupSharingEnabled);
+
+        if ($sharingEnabled && $groupSharingEnabled) {
+            $this->shareManager->expects($this->once())
+                ->method('shareWithGroupMembersOnly')
+                ->willReturn($groupsOnly);
+
+            if ($groupsOnly) {
+                $user = $this->createMock(IUser::class);
+                $this->userSession->expects($this->once())
+                    ->method('getUser')
+                    ->willReturn($user);
+
+                $this->groupManager->expects($this->once())
+                    ->method('getUserGroupIds')
+                    ->with($user)
+                    ->willReturn(['group1', 'group2', 'group5']);
+            }
+        } else {
+            $this->shareManager->expects($this->never())
+                ->method('shareWithGroupMembersOnly');
+            $this->groupManager->expects($this->never())
+                ->method($this->anything());
+        }
+
+        $this->assertEquals($result, $this->connector->findByUri($findUri, 'principals/groups'));
+    }
+
+    public static function findByUriDataProvider(): array {
+        return [
+            [false, false, false, 'principal:principals/groups/group1', null],
+            [false, false, false, 'principal:principals/groups/group3', null],
+            [false, true, false, 'principal:principals/groups/group1', null],
+            [false, true, false, 'principal:principals/groups/group3', null],
+            [false, false, true, 'principal:principals/groups/group1', null],
+            [false, false, true, 'principal:principals/groups/group3', null],
+            [true, false, true, 'principal:principals/groups/group1', null],
+            [true, false, true, 'principal:principals/groups/group3', null],
+            [true, true, true, 'principal:principals/groups/group1', 'principals/groups/group1'],
+            [true, true, true, 'principal:principals/groups/group3', null],
+            [true, true, false, 'principal:principals/groups/group1', 'principals/groups/group1'],
+            [true, true, false, 'principal:principals/groups/group3', 'principals/groups/group3'],
+        ];
+    }
+
+    private function mockGroup(string $gid): Group&MockObject {
+        $fooGroup = $this->createMock(Group::class);
+        $fooGroup
+            ->expects($this->exactly(1))
+            ->method('getGID')
+            ->willReturn($gid);
+        $fooGroup
+            ->expects($this->exactly(1))
+            ->method('getDisplayName')
+            ->willReturn('Group ' . $gid);
+        return $fooGroup;
+    }
 }

apps/dav/tests/unit/DAV/Listener/UserEventsListenerTest.php

Indentation +112 added lines, -112 removed lines

@@ -22,116 +22,116 @@
 use Test\TestCase;
 
 class UserEventsListenerTest extends TestCase {
-	private IUserManager&MockObject $userManager;
-	private SyncService&MockObject $syncService;
-	private CalDavBackend&MockObject $calDavBackend;
-	private CardDavBackend&MockObject $cardDavBackend;
-	private Defaults&MockObject $defaults;
-
-	private DefaultContactService&MockObject $defaultContactService;
-
-	private UserEventsListener $userEventsListener;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->syncService = $this->createMock(SyncService::class);
-		$this->calDavBackend = $this->createMock(CalDavBackend::class);
-		$this->cardDavBackend = $this->createMock(CardDavBackend::class);
-		$this->defaults = $this->createMock(Defaults::class);
-		$this->defaultContactService = $this->createMock(DefaultContactService::class);
-		$this->userEventsListener = new UserEventsListener(
-			$this->userManager,
-			$this->syncService,
-			$this->calDavBackend,
-			$this->cardDavBackend,
-			$this->defaults,
-			$this->defaultContactService,
-		);
-	}
-
-	public function test(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())->method('getUID')->willReturn('newUser');
-
-		$this->defaults->expects($this->once())->method('getColorPrimary')->willReturn('#745bca');
-
-		$this->calDavBackend->expects($this->once())->method('getCalendarsForUserCount')->willReturn(0);
-		$this->calDavBackend->expects($this->once())->method('createCalendar')->with(
-			'principals/users/newUser',
-			'personal', [
-				'{DAV:}displayname' => 'Personal',
-				'{http://apple.com/ns/ical/}calendar-color' => '#745bca',
-				'components' => 'VEVENT'
-			]);
-
-		$this->cardDavBackend->expects($this->once())->method('getAddressBooksForUserCount')->willReturn(0);
-		$this->cardDavBackend->expects($this->once())->method('createAddressBook')->with(
-			'principals/users/newUser',
-			'contacts', ['{DAV:}displayname' => 'Contacts']);
-
-		$this->userEventsListener->firstLogin($user);
-	}
-
-	public function testWithExisting(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())->method('getUID')->willReturn('newUser');
-
-		$this->calDavBackend->expects($this->once())->method('getCalendarsForUserCount')->willReturn(1);
-		$this->calDavBackend->expects($this->never())->method('createCalendar');
-
-		$this->cardDavBackend->expects($this->once())->method('getAddressBooksForUserCount')->willReturn(1);
-		$this->cardDavBackend->expects($this->never())->method('createAddressBook');
-
-		$this->userEventsListener->firstLogin($user);
-	}
-
-	public function testWithBirthdayCalendar(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())->method('getUID')->willReturn('newUser');
-
-		$this->defaults->expects($this->once())->method('getColorPrimary')->willReturn('#745bca');
-
-		$this->calDavBackend->expects($this->once())->method('getCalendarsForUserCount')->willReturn(0);
-		$this->calDavBackend->expects($this->once())->method('createCalendar')->with(
-			'principals/users/newUser',
-			'personal', [
-				'{DAV:}displayname' => 'Personal',
-				'{http://apple.com/ns/ical/}calendar-color' => '#745bca',
-				'components' => 'VEVENT'
-			]);
-
-		$this->cardDavBackend->expects($this->once())->method('getAddressBooksForUserCount')->willReturn(0);
-		$this->cardDavBackend->expects($this->once())->method('createAddressBook')->with(
-			'principals/users/newUser',
-			'contacts', ['{DAV:}displayname' => 'Contacts']);
-
-		$this->userEventsListener->firstLogin($user);
-	}
-
-	public function testDeleteCalendar(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())->method('getUID')->willReturn('newUser');
-
-		$this->syncService->expects($this->once())
-			->method('deleteUser');
-
-		$this->calDavBackend->expects($this->once())->method('getUsersOwnCalendars')->willReturn([
-			['id' => 'personal']
-		]);
-		$this->calDavBackend->expects($this->once())->method('getSubscriptionsForUser')->willReturn([
-			['id' => 'some-subscription']
-		]);
-		$this->calDavBackend->expects($this->once())->method('deleteCalendar')->with('personal');
-		$this->calDavBackend->expects($this->once())->method('deleteSubscription')->with('some-subscription');
-		$this->calDavBackend->expects($this->once())->method('deleteAllSharesByUser');
-
-		$this->cardDavBackend->expects($this->once())->method('getUsersOwnAddressBooks')->willReturn([
-			['id' => 'personal']
-		]);
-		$this->cardDavBackend->expects($this->once())->method('deleteAddressBook');
-
-		$this->userEventsListener->preDeleteUser($user);
-		$this->userEventsListener->postDeleteUser('newUser');
-	}
+    private IUserManager&MockObject $userManager;
+    private SyncService&MockObject $syncService;
+    private CalDavBackend&MockObject $calDavBackend;
+    private CardDavBackend&MockObject $cardDavBackend;
+    private Defaults&MockObject $defaults;
+
+    private DefaultContactService&MockObject $defaultContactService;
+
+    private UserEventsListener $userEventsListener;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->syncService = $this->createMock(SyncService::class);
+        $this->calDavBackend = $this->createMock(CalDavBackend::class);
+        $this->cardDavBackend = $this->createMock(CardDavBackend::class);
+        $this->defaults = $this->createMock(Defaults::class);
+        $this->defaultContactService = $this->createMock(DefaultContactService::class);
+        $this->userEventsListener = new UserEventsListener(
+            $this->userManager,
+            $this->syncService,
+            $this->calDavBackend,
+            $this->cardDavBackend,
+            $this->defaults,
+            $this->defaultContactService,
+        );
+    }
+
+    public function test(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())->method('getUID')->willReturn('newUser');
+
+        $this->defaults->expects($this->once())->method('getColorPrimary')->willReturn('#745bca');
+
+        $this->calDavBackend->expects($this->once())->method('getCalendarsForUserCount')->willReturn(0);
+        $this->calDavBackend->expects($this->once())->method('createCalendar')->with(
+            'principals/users/newUser',
+            'personal', [
+                '{DAV:}displayname' => 'Personal',
+                '{http://apple.com/ns/ical/}calendar-color' => '#745bca',
+                'components' => 'VEVENT'
+            ]);
+
+        $this->cardDavBackend->expects($this->once())->method('getAddressBooksForUserCount')->willReturn(0);
+        $this->cardDavBackend->expects($this->once())->method('createAddressBook')->with(
+            'principals/users/newUser',
+            'contacts', ['{DAV:}displayname' => 'Contacts']);
+
+        $this->userEventsListener->firstLogin($user);
+    }
+
+    public function testWithExisting(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())->method('getUID')->willReturn('newUser');
+
+        $this->calDavBackend->expects($this->once())->method('getCalendarsForUserCount')->willReturn(1);
+        $this->calDavBackend->expects($this->never())->method('createCalendar');
+
+        $this->cardDavBackend->expects($this->once())->method('getAddressBooksForUserCount')->willReturn(1);
+        $this->cardDavBackend->expects($this->never())->method('createAddressBook');
+
+        $this->userEventsListener->firstLogin($user);
+    }
+
+    public function testWithBirthdayCalendar(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())->method('getUID')->willReturn('newUser');
+
+        $this->defaults->expects($this->once())->method('getColorPrimary')->willReturn('#745bca');
+
+        $this->calDavBackend->expects($this->once())->method('getCalendarsForUserCount')->willReturn(0);
+        $this->calDavBackend->expects($this->once())->method('createCalendar')->with(
+            'principals/users/newUser',
+            'personal', [
+                '{DAV:}displayname' => 'Personal',
+                '{http://apple.com/ns/ical/}calendar-color' => '#745bca',
+                'components' => 'VEVENT'
+            ]);
+
+        $this->cardDavBackend->expects($this->once())->method('getAddressBooksForUserCount')->willReturn(0);
+        $this->cardDavBackend->expects($this->once())->method('createAddressBook')->with(
+            'principals/users/newUser',
+            'contacts', ['{DAV:}displayname' => 'Contacts']);
+
+        $this->userEventsListener->firstLogin($user);
+    }
+
+    public function testDeleteCalendar(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())->method('getUID')->willReturn('newUser');
+
+        $this->syncService->expects($this->once())
+            ->method('deleteUser');
+
+        $this->calDavBackend->expects($this->once())->method('getUsersOwnCalendars')->willReturn([
+            ['id' => 'personal']
+        ]);
+        $this->calDavBackend->expects($this->once())->method('getSubscriptionsForUser')->willReturn([
+            ['id' => 'some-subscription']
+        ]);
+        $this->calDavBackend->expects($this->once())->method('deleteCalendar')->with('personal');
+        $this->calDavBackend->expects($this->once())->method('deleteSubscription')->with('some-subscription');
+        $this->calDavBackend->expects($this->once())->method('deleteAllSharesByUser');
+
+        $this->cardDavBackend->expects($this->once())->method('getUsersOwnAddressBooks')->willReturn([
+            ['id' => 'personal']
+        ]);
+        $this->cardDavBackend->expects($this->once())->method('deleteAddressBook');
+
+        $this->userEventsListener->preDeleteUser($user);
+        $this->userEventsListener->postDeleteUser('newUser');
+    }
 }

apps/dav/tests/unit/DAV/CustomPropertiesBackendTest.php

Indentation +438 added lines, -438 removed lines

@@ -28,442 +28,442 @@
  * @group DB
  */
 class CustomPropertiesBackendTest extends TestCase {
-	private const BASE_URI = '/remote.php/dav/';
-
-	private Server&MockObject $server;
-	private Tree&MockObject $tree;
-	private IDBConnection $dbConnection;
-	private IUser&MockObject $user;
-	private DefaultCalendarValidator&MockObject $defaultCalendarValidator;
-	private CustomPropertiesBackend $backend;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->server = $this->createMock(Server::class);
-		$this->server->method('getBaseUri')
-			->willReturn(self::BASE_URI);
-		$this->tree = $this->createMock(Tree::class);
-		$this->user = $this->createMock(IUser::class);
-		$this->user->method('getUID')
-			->with()
-			->willReturn('dummy_user_42');
-		$this->dbConnection = \OCP\Server::get(IDBConnection::class);
-		$this->defaultCalendarValidator = $this->createMock(DefaultCalendarValidator::class);
-
-		$this->backend = new CustomPropertiesBackend(
-			$this->server,
-			$this->tree,
-			$this->dbConnection,
-			$this->user,
-			$this->defaultCalendarValidator,
-		);
-	}
-
-	protected function tearDown(): void {
-		$query = $this->dbConnection->getQueryBuilder();
-		$query->delete('properties');
-		$query->execute();
-
-		parent::tearDown();
-	}
-
-	private function formatPath(string $path): string {
-		if (strlen($path) > 250) {
-			return sha1($path);
-		} else {
-			return $path;
-		}
-	}
-
-	protected function insertProps(string $user, string $path, array $props): void {
-		foreach ($props as $name => $value) {
-			$this->insertProp($user, $path, $name, $value);
-		}
-	}
-
-	protected function insertProp(string $user, string $path, string $name, mixed $value): void {
-		$type = CustomPropertiesBackend::PROPERTY_TYPE_STRING;
-		if ($value instanceof Href) {
-			$value = $value->getHref();
-			$type = CustomPropertiesBackend::PROPERTY_TYPE_HREF;
-		}
-
-		$query = $this->dbConnection->getQueryBuilder();
-		$query->insert('properties')
-			->values([
-				'userid' => $query->createNamedParameter($user),
-				'propertypath' => $query->createNamedParameter($this->formatPath($path)),
-				'propertyname' => $query->createNamedParameter($name),
-				'propertyvalue' => $query->createNamedParameter($value),
-				'valuetype' => $query->createNamedParameter($type, IQueryBuilder::PARAM_INT)
-			]);
-		$query->execute();
-	}
-
-	protected function getProps(string $user, string $path): array {
-		$query = $this->dbConnection->getQueryBuilder();
-		$query->select('propertyname', 'propertyvalue', 'valuetype')
-			->from('properties')
-			->where($query->expr()->eq('userid', $query->createNamedParameter($user)))
-			->andWhere($query->expr()->eq('propertypath', $query->createNamedParameter($this->formatPath($path))));
-
-		$result = $query->execute();
-		$data = [];
-		while ($row = $result->fetch()) {
-			$value = $row['propertyvalue'];
-			if ((int)$row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
-				$value = new Href($value);
-			}
-			$data[$row['propertyname']] = $value;
-		}
-		$result->closeCursor();
-
-		return $data;
-	}
-
-	public function testPropFindNoDbCalls(): void {
-		$db = $this->createMock(IDBConnection::class);
-		$backend = new CustomPropertiesBackend(
-			$this->server,
-			$this->tree,
-			$db,
-			$this->user,
-			$this->defaultCalendarValidator,
-		);
-
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->expects($this->once())
-			->method('get404Properties')
-			->with()
-			->willReturn([
-				'{http://owncloud.org/ns}permissions',
-				'{http://owncloud.org/ns}downloadURL',
-				'{http://owncloud.org/ns}dDC',
-				'{http://owncloud.org/ns}size',
-			]);
-
-		$db->expects($this->never())
-			->method($this->anything());
-
-		$backend->propFind('foo_bar_path_1337_0', $propFind);
-	}
-
-	public function testPropFindCalendarCall(): void {
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->method('get404Properties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-			]);
-
-		$propFind->method('getRequestedProperties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{DAV:}displayname',
-				'{urn:ietf:params:xml:ns:caldav}calendar-description',
-				'{urn:ietf:params:xml:ns:caldav}calendar-timezone',
-				'{abc}def',
-			]);
-
-		$props = [
-			'{abc}def' => 'a',
-			'{DAV:}displayname' => 'b',
-			'{urn:ietf:params:xml:ns:caldav}calendar-description' => 'c',
-			'{urn:ietf:params:xml:ns:caldav}calendar-timezone' => 'd',
-		];
-
-		$this->insertProps('dummy_user_42', 'calendars/foo/bar_path_1337_0', $props);
-
-		$setProps = [];
-		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
-				$setProps[$name] = $value;
-			});
-
-		$this->backend->propFind('calendars/foo/bar_path_1337_0', $propFind);
-		$this->assertEquals($props, $setProps);
-	}
-
-	public function testPropFindPrincipalCall(): void {
-		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
-				$node = $this->createMock(Calendar::class);
-				$node->method('getOwner')
-					->willReturn('principals/users/dummy_user_42');
-				return $node;
-			});
-
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->method('get404Properties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-			]);
-
-		$propFind->method('getRequestedProperties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-				'{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL',
-			]);
-
-		$props = [
-			'{abc}def' => 'a',
-			'{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/admin/personal'),
-		];
-		$this->insertProps('dummy_user_42', 'principals/users/dummy_user_42', $props);
-
-		$setProps = [];
-		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
-				$setProps[$name] = $value;
-			});
-
-		$this->backend->propFind('principals/users/dummy_user_42', $propFind);
-		$this->assertEquals($props, $setProps);
-	}
-
-	public static function propFindPrincipalScheduleDefaultCalendarProviderUrlProvider(): array {
-		// [ user, nodes, existingProps, requestedProps, returnedProps ]
-		return [
-			[ // Exists
-				'dummy_user_42',
-				['calendars/dummy_user_42/foo/' => Calendar::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
-			],
-			[ // Doesn't exist
-				'dummy_user_42',
-				['calendars/dummy_user_42/foo/' => Calendar::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/bar/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				[],
-			],
-			[ // No privilege
-				'dummy_user_42',
-				['calendars/user2/baz/' => Calendar::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/user2/baz/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				[],
-			],
-			[ // Not a calendar
-				'dummy_user_42',
-				['foo/dummy_user_42/bar/' => IACL::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/dummy_user_42/bar/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				[],
-			],
-		];
-
-	}
-
-	/**
-	 * @dataProvider propFindPrincipalScheduleDefaultCalendarProviderUrlProvider
-	 */
-	public function testPropFindPrincipalScheduleDefaultCalendarUrl(
-		string $user,
-		array $nodes,
-		array $existingProps,
-		array $requestedProps,
-		array $returnedProps,
-	): void {
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->method('get404Properties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-			]);
-
-		$propFind->method('getRequestedProperties')
-			->with()
-			->willReturn(array_merge([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-			],
-				$requestedProps,
-			));
-
-		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
-				if (!str_starts_with($uri, self::BASE_URI)) {
-					return trim(substr($uri, strlen(self::BASE_URI)), '/');
-				}
-				return null;
-			});
-		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) use ($nodes) {
-				if (str_starts_with($uri, 'principals/')) {
-					return $this->createMock(IPrincipal::class);
-				}
-				if (array_key_exists($uri, $nodes)) {
-					$owner = explode('/', $uri)[1];
-					$node = $this->createMock($nodes[$uri]);
-					$node->method('getOwner')
-						->willReturn("principals/users/$owner");
-					return $node;
-				}
-				throw new NotFound('Node not found');
-			});
-
-		$this->insertProps($user, "principals/users/$user", $existingProps);
-
-		$setProps = [];
-		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
-				$setProps[$name] = $value;
-			});
-
-		$this->backend->propFind("principals/users/$user", $propFind);
-		$this->assertEquals($returnedProps, $setProps);
-	}
-
-	/**
-	 * @dataProvider propPatchProvider
-	 */
-	public function testPropPatch(string $path, array $existing, array $props, array $result): void {
-		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
-				if (str_starts_with($uri, self::BASE_URI)) {
-					return trim(substr($uri, strlen(self::BASE_URI)), '/');
-				}
-				return null;
-			});
-		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
-				$node = $this->createMock(Calendar::class);
-				$node->method('getOwner')
-					->willReturn('principals/users/' . $this->user->getUID());
-				return $node;
-			});
-
-		$this->insertProps($this->user->getUID(), $path, $existing);
-		$propPatch = new PropPatch($props);
-
-		$this->backend->propPatch($path, $propPatch);
-		$propPatch->commit();
-
-		$storedProps = $this->getProps($this->user->getUID(), $path);
-		$this->assertEquals($result, $storedProps);
-	}
-
-	public static function propPatchProvider(): array {
-		$longPath = str_repeat('long_path', 100);
-		return [
-			['foo_bar_path_1337', [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
-			['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
-			['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => null], []],
-			[$longPath, [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
-			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
-			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI . 'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
-		];
-	}
-
-	public function testPropPatchWithUnsuitableCalendar(): void {
-		$path = 'principals/users/' . $this->user->getUID();
-
-		$node = $this->createMock(Calendar::class);
-		$node->expects(self::once())
-			->method('getOwner')
-			->willReturn($path);
-
-		$this->defaultCalendarValidator->expects(self::once())
-			->method('validateScheduleDefaultCalendar')
-			->with($node)
-			->willThrowException(new \Sabre\DAV\Exception('Invalid calendar'));
-
-		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
-				if (str_starts_with($uri, self::BASE_URI)) {
-					return trim(substr($uri, strlen(self::BASE_URI)), '/');
-				}
-				return null;
-			});
-		$this->tree->expects(self::once())
-			->method('getNodeForPath')
-			->with('foo/bar/')
-			->willReturn($node);
-
-		$storedProps = $this->getProps($this->user->getUID(), $path);
-		$this->assertEquals([], $storedProps);
-
-		$propPatch = new PropPatch([
-			'{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/'),
-		]);
-		$this->backend->propPatch($path, $propPatch);
-		try {
-			$propPatch->commit();
-		} catch (\Throwable $e) {
-			$this->assertInstanceOf(\Sabre\DAV\Exception::class, $e);
-		}
-
-		$storedProps = $this->getProps($this->user->getUID(), $path);
-		$this->assertEquals([], $storedProps);
-	}
-
-	/**
-	 * @dataProvider deleteProvider
-	 */
-	public function testDelete(string $path): void {
-		$this->insertProps('dummy_user_42', $path, ['foo' => 'bar']);
-		$this->backend->delete($path);
-		$this->assertEquals([], $this->getProps('dummy_user_42', $path));
-	}
-
-	public static function deleteProvider(): array {
-		return [
-			['foo_bar_path_1337'],
-			[str_repeat('long_path', 100)]
-		];
-	}
-
-	/**
-	 * @dataProvider moveProvider
-	 */
-	public function testMove(string $source, string $target): void {
-		$this->insertProps('dummy_user_42', $source, ['foo' => 'bar']);
-		$this->backend->move($source, $target);
-		$this->assertEquals([], $this->getProps('dummy_user_42', $source));
-		$this->assertEquals(['foo' => 'bar'], $this->getProps('dummy_user_42', $target));
-	}
-
-	public static function moveProvider(): array {
-		return [
-			['foo_bar_path_1337', 'foo_bar_path_7333'],
-			[str_repeat('long_path1', 100), str_repeat('long_path2', 100)]
-		];
-	}
-
-	public function testDecodeValueFromDatabaseObjectCurrent(): void {
-		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"\x00*\x00value";s:6:"opaque";}';
-		$propertyType = 3;
-		$decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
-		$this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
-		$this->assertEquals('opaque', $decodeValue->getValue());
-	}
-
-	public function testDecodeValueFromDatabaseObjectLegacy(): void {
-		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"' . chr(0) . '*' . chr(0) . 'value";s:6:"opaque";}';
-		$propertyType = 3;
-		$decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
-		$this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
-		$this->assertEquals('opaque', $decodeValue->getValue());
-	}
+    private const BASE_URI = '/remote.php/dav/';
+
+    private Server&MockObject $server;
+    private Tree&MockObject $tree;
+    private IDBConnection $dbConnection;
+    private IUser&MockObject $user;
+    private DefaultCalendarValidator&MockObject $defaultCalendarValidator;
+    private CustomPropertiesBackend $backend;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->server = $this->createMock(Server::class);
+        $this->server->method('getBaseUri')
+            ->willReturn(self::BASE_URI);
+        $this->tree = $this->createMock(Tree::class);
+        $this->user = $this->createMock(IUser::class);
+        $this->user->method('getUID')
+            ->with()
+            ->willReturn('dummy_user_42');
+        $this->dbConnection = \OCP\Server::get(IDBConnection::class);
+        $this->defaultCalendarValidator = $this->createMock(DefaultCalendarValidator::class);
+
+        $this->backend = new CustomPropertiesBackend(
+            $this->server,
+            $this->tree,
+            $this->dbConnection,
+            $this->user,
+            $this->defaultCalendarValidator,
+        );
+    }
+
+    protected function tearDown(): void {
+        $query = $this->dbConnection->getQueryBuilder();
+        $query->delete('properties');
+        $query->execute();
+
+        parent::tearDown();
+    }
+
+    private function formatPath(string $path): string {
+        if (strlen($path) > 250) {
+            return sha1($path);
+        } else {
+            return $path;
+        }
+    }
+
+    protected function insertProps(string $user, string $path, array $props): void {
+        foreach ($props as $name => $value) {
+            $this->insertProp($user, $path, $name, $value);
+        }
+    }
+
+    protected function insertProp(string $user, string $path, string $name, mixed $value): void {
+        $type = CustomPropertiesBackend::PROPERTY_TYPE_STRING;
+        if ($value instanceof Href) {
+            $value = $value->getHref();
+            $type = CustomPropertiesBackend::PROPERTY_TYPE_HREF;
+        }
+
+        $query = $this->dbConnection->getQueryBuilder();
+        $query->insert('properties')
+            ->values([
+                'userid' => $query->createNamedParameter($user),
+                'propertypath' => $query->createNamedParameter($this->formatPath($path)),
+                'propertyname' => $query->createNamedParameter($name),
+                'propertyvalue' => $query->createNamedParameter($value),
+                'valuetype' => $query->createNamedParameter($type, IQueryBuilder::PARAM_INT)
+            ]);
+        $query->execute();
+    }
+
+    protected function getProps(string $user, string $path): array {
+        $query = $this->dbConnection->getQueryBuilder();
+        $query->select('propertyname', 'propertyvalue', 'valuetype')
+            ->from('properties')
+            ->where($query->expr()->eq('userid', $query->createNamedParameter($user)))
+            ->andWhere($query->expr()->eq('propertypath', $query->createNamedParameter($this->formatPath($path))));
+
+        $result = $query->execute();
+        $data = [];
+        while ($row = $result->fetch()) {
+            $value = $row['propertyvalue'];
+            if ((int)$row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
+                $value = new Href($value);
+            }
+            $data[$row['propertyname']] = $value;
+        }
+        $result->closeCursor();
+
+        return $data;
+    }
+
+    public function testPropFindNoDbCalls(): void {
+        $db = $this->createMock(IDBConnection::class);
+        $backend = new CustomPropertiesBackend(
+            $this->server,
+            $this->tree,
+            $db,
+            $this->user,
+            $this->defaultCalendarValidator,
+        );
+
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->expects($this->once())
+            ->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{http://owncloud.org/ns}permissions',
+                '{http://owncloud.org/ns}downloadURL',
+                '{http://owncloud.org/ns}dDC',
+                '{http://owncloud.org/ns}size',
+            ]);
+
+        $db->expects($this->never())
+            ->method($this->anything());
+
+        $backend->propFind('foo_bar_path_1337_0', $propFind);
+    }
+
+    public function testPropFindCalendarCall(): void {
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+            ]);
+
+        $propFind->method('getRequestedProperties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{DAV:}displayname',
+                '{urn:ietf:params:xml:ns:caldav}calendar-description',
+                '{urn:ietf:params:xml:ns:caldav}calendar-timezone',
+                '{abc}def',
+            ]);
+
+        $props = [
+            '{abc}def' => 'a',
+            '{DAV:}displayname' => 'b',
+            '{urn:ietf:params:xml:ns:caldav}calendar-description' => 'c',
+            '{urn:ietf:params:xml:ns:caldav}calendar-timezone' => 'd',
+        ];
+
+        $this->insertProps('dummy_user_42', 'calendars/foo/bar_path_1337_0', $props);
+
+        $setProps = [];
+        $propFind->method('set')
+            ->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+                $setProps[$name] = $value;
+            });
+
+        $this->backend->propFind('calendars/foo/bar_path_1337_0', $propFind);
+        $this->assertEquals($props, $setProps);
+    }
+
+    public function testPropFindPrincipalCall(): void {
+        $this->tree->method('getNodeForPath')
+            ->willReturnCallback(function ($uri) {
+                $node = $this->createMock(Calendar::class);
+                $node->method('getOwner')
+                    ->willReturn('principals/users/dummy_user_42');
+                return $node;
+            });
+
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+            ]);
+
+        $propFind->method('getRequestedProperties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+                '{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL',
+            ]);
+
+        $props = [
+            '{abc}def' => 'a',
+            '{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/admin/personal'),
+        ];
+        $this->insertProps('dummy_user_42', 'principals/users/dummy_user_42', $props);
+
+        $setProps = [];
+        $propFind->method('set')
+            ->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+                $setProps[$name] = $value;
+            });
+
+        $this->backend->propFind('principals/users/dummy_user_42', $propFind);
+        $this->assertEquals($props, $setProps);
+    }
+
+    public static function propFindPrincipalScheduleDefaultCalendarProviderUrlProvider(): array {
+        // [ user, nodes, existingProps, requestedProps, returnedProps ]
+        return [
+            [ // Exists
+                'dummy_user_42',
+                ['calendars/dummy_user_42/foo/' => Calendar::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
+            ],
+            [ // Doesn't exist
+                'dummy_user_42',
+                ['calendars/dummy_user_42/foo/' => Calendar::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/bar/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                [],
+            ],
+            [ // No privilege
+                'dummy_user_42',
+                ['calendars/user2/baz/' => Calendar::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/user2/baz/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                [],
+            ],
+            [ // Not a calendar
+                'dummy_user_42',
+                ['foo/dummy_user_42/bar/' => IACL::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/dummy_user_42/bar/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                [],
+            ],
+        ];
+
+    }
+
+    /**
+     * @dataProvider propFindPrincipalScheduleDefaultCalendarProviderUrlProvider
+     */
+    public function testPropFindPrincipalScheduleDefaultCalendarUrl(
+        string $user,
+        array $nodes,
+        array $existingProps,
+        array $requestedProps,
+        array $returnedProps,
+    ): void {
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+            ]);
+
+        $propFind->method('getRequestedProperties')
+            ->with()
+            ->willReturn(array_merge([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+            ],
+                $requestedProps,
+            ));
+
+        $this->server->method('calculateUri')
+            ->willReturnCallback(function ($uri) {
+                if (!str_starts_with($uri, self::BASE_URI)) {
+                    return trim(substr($uri, strlen(self::BASE_URI)), '/');
+                }
+                return null;
+            });
+        $this->tree->method('getNodeForPath')
+            ->willReturnCallback(function ($uri) use ($nodes) {
+                if (str_starts_with($uri, 'principals/')) {
+                    return $this->createMock(IPrincipal::class);
+                }
+                if (array_key_exists($uri, $nodes)) {
+                    $owner = explode('/', $uri)[1];
+                    $node = $this->createMock($nodes[$uri]);
+                    $node->method('getOwner')
+                        ->willReturn("principals/users/$owner");
+                    return $node;
+                }
+                throw new NotFound('Node not found');
+            });
+
+        $this->insertProps($user, "principals/users/$user", $existingProps);
+
+        $setProps = [];
+        $propFind->method('set')
+            ->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+                $setProps[$name] = $value;
+            });
+
+        $this->backend->propFind("principals/users/$user", $propFind);
+        $this->assertEquals($returnedProps, $setProps);
+    }
+
+    /**
+     * @dataProvider propPatchProvider
+     */
+    public function testPropPatch(string $path, array $existing, array $props, array $result): void {
+        $this->server->method('calculateUri')
+            ->willReturnCallback(function ($uri) {
+                if (str_starts_with($uri, self::BASE_URI)) {
+                    return trim(substr($uri, strlen(self::BASE_URI)), '/');
+                }
+                return null;
+            });
+        $this->tree->method('getNodeForPath')
+            ->willReturnCallback(function ($uri) {
+                $node = $this->createMock(Calendar::class);
+                $node->method('getOwner')
+                    ->willReturn('principals/users/' . $this->user->getUID());
+                return $node;
+            });
+
+        $this->insertProps($this->user->getUID(), $path, $existing);
+        $propPatch = new PropPatch($props);
+
+        $this->backend->propPatch($path, $propPatch);
+        $propPatch->commit();
+
+        $storedProps = $this->getProps($this->user->getUID(), $path);
+        $this->assertEquals($result, $storedProps);
+    }
+
+    public static function propPatchProvider(): array {
+        $longPath = str_repeat('long_path', 100);
+        return [
+            ['foo_bar_path_1337', [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
+            ['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
+            ['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => null], []],
+            [$longPath, [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
+            ['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
+            ['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI . 'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
+        ];
+    }
+
+    public function testPropPatchWithUnsuitableCalendar(): void {
+        $path = 'principals/users/' . $this->user->getUID();
+
+        $node = $this->createMock(Calendar::class);
+        $node->expects(self::once())
+            ->method('getOwner')
+            ->willReturn($path);
+
+        $this->defaultCalendarValidator->expects(self::once())
+            ->method('validateScheduleDefaultCalendar')
+            ->with($node)
+            ->willThrowException(new \Sabre\DAV\Exception('Invalid calendar'));
+
+        $this->server->method('calculateUri')
+            ->willReturnCallback(function ($uri) {
+                if (str_starts_with($uri, self::BASE_URI)) {
+                    return trim(substr($uri, strlen(self::BASE_URI)), '/');
+                }
+                return null;
+            });
+        $this->tree->expects(self::once())
+            ->method('getNodeForPath')
+            ->with('foo/bar/')
+            ->willReturn($node);
+
+        $storedProps = $this->getProps($this->user->getUID(), $path);
+        $this->assertEquals([], $storedProps);
+
+        $propPatch = new PropPatch([
+            '{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/'),
+        ]);
+        $this->backend->propPatch($path, $propPatch);
+        try {
+            $propPatch->commit();
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(\Sabre\DAV\Exception::class, $e);
+        }
+
+        $storedProps = $this->getProps($this->user->getUID(), $path);
+        $this->assertEquals([], $storedProps);
+    }
+
+    /**
+     * @dataProvider deleteProvider
+     */
+    public function testDelete(string $path): void {
+        $this->insertProps('dummy_user_42', $path, ['foo' => 'bar']);
+        $this->backend->delete($path);
+        $this->assertEquals([], $this->getProps('dummy_user_42', $path));
+    }
+
+    public static function deleteProvider(): array {
+        return [
+            ['foo_bar_path_1337'],
+            [str_repeat('long_path', 100)]
+        ];
+    }
+
+    /**
+     * @dataProvider moveProvider
+     */
+    public function testMove(string $source, string $target): void {
+        $this->insertProps('dummy_user_42', $source, ['foo' => 'bar']);
+        $this->backend->move($source, $target);
+        $this->assertEquals([], $this->getProps('dummy_user_42', $source));
+        $this->assertEquals(['foo' => 'bar'], $this->getProps('dummy_user_42', $target));
+    }
+
+    public static function moveProvider(): array {
+        return [
+            ['foo_bar_path_1337', 'foo_bar_path_7333'],
+            [str_repeat('long_path1', 100), str_repeat('long_path2', 100)]
+        ];
+    }
+
+    public function testDecodeValueFromDatabaseObjectCurrent(): void {
+        $propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"\x00*\x00value";s:6:"opaque";}';
+        $propertyType = 3;
+        $decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
+        $this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
+        $this->assertEquals('opaque', $decodeValue->getValue());
+    }
+
+    public function testDecodeValueFromDatabaseObjectLegacy(): void {
+        $propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"' . chr(0) . '*' . chr(0) . 'value";s:6:"opaque";}';
+        $propertyType = 3;
+        $decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
+        $this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
+        $this->assertEquals('opaque', $decodeValue->getValue());
+    }
 }

Spacing +18 added lines, -18 removed lines

@@ -112,7 +112,7 @@ 
 		$data = [];
 		while ($row = $result->fetch()) {
 			$value = $row['propertyvalue'];
-			if ((int)$row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
+			if ((int) $row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
 				$value = new Href($value);
 			}
 			$data[$row['propertyname']] = $value;
@@ -183,7 +183,7 @@ 
 
 		$setProps = [];
 		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+			->willReturnCallback(function($name, $value, $status) use (&$setProps): void {
 				$setProps[$name] = $value;
 			});
 
@@ -193,7 +193,7 @@ 
 
 	public function testPropFindPrincipalCall(): void {
 		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				$node = $this->createMock(Calendar::class);
 				$node->method('getOwner')
 					->willReturn('principals/users/dummy_user_42');
@@ -228,7 +228,7 @@ 
 
 		$setProps = [];
 		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+			->willReturnCallback(function($name, $value, $status) use (&$setProps): void {
 				$setProps[$name] = $value;
 			});
 
@@ -239,28 +239,28 @@ 
 	public static function propFindPrincipalScheduleDefaultCalendarProviderUrlProvider(): array {
 		// [ user, nodes, existingProps, requestedProps, returnedProps ]
 		return [
-			[ // Exists
+			[// Exists
 				'dummy_user_42',
 				['calendars/dummy_user_42/foo/' => Calendar::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
 			],
-			[ // Doesn't exist
+			[// Doesn't exist
 				'dummy_user_42',
 				['calendars/dummy_user_42/foo/' => Calendar::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/bar/')],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
 				[],
 			],
-			[ // No privilege
+			[// No privilege
 				'dummy_user_42',
 				['calendars/user2/baz/' => Calendar::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/user2/baz/')],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
 				[],
 			],
-			[ // Not a calendar
+			[// Not a calendar
 				'dummy_user_42',
 				['foo/dummy_user_42/bar/' => IACL::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/dummy_user_42/bar/')],
@@ -302,14 +302,14 @@ 
 			));
 
 		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				if (!str_starts_with($uri, self::BASE_URI)) {
 					return trim(substr($uri, strlen(self::BASE_URI)), '/');
 				}
 				return null;
 			});
 		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) use ($nodes) {
+			->willReturnCallback(function($uri) use ($nodes) {
 				if (str_starts_with($uri, 'principals/')) {
 					return $this->createMock(IPrincipal::class);
 				}
@@ -327,7 +327,7 @@ 
 
 		$setProps = [];
 		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+			->willReturnCallback(function($name, $value, $status) use (&$setProps): void {
 				$setProps[$name] = $value;
 			});
 
@@ -340,17 +340,17 @@ 
 	 */
 	public function testPropPatch(string $path, array $existing, array $props, array $result): void {
 		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				if (str_starts_with($uri, self::BASE_URI)) {
 					return trim(substr($uri, strlen(self::BASE_URI)), '/');
 				}
 				return null;
 			});
 		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				$node = $this->createMock(Calendar::class);
 				$node->method('getOwner')
-					->willReturn('principals/users/' . $this->user->getUID());
+					->willReturn('principals/users/'.$this->user->getUID());
 				return $node;
 			});
 
@@ -372,12 +372,12 @@ 
 			['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => null], []],
 			[$longPath, [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
 			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
-			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI . 'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
+			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI.'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
 		];
 	}
 
 	public function testPropPatchWithUnsuitableCalendar(): void {
-		$path = 'principals/users/' . $this->user->getUID();
+		$path = 'principals/users/'.$this->user->getUID();
 
 		$node = $this->createMock(Calendar::class);
 		$node->expects(self::once())
@@ -390,7 +390,7 @@ 
 			->willThrowException(new \Sabre\DAV\Exception('Invalid calendar'));
 
 		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				if (str_starts_with($uri, self::BASE_URI)) {
 					return trim(substr($uri, strlen(self::BASE_URI)), '/');
 				}
@@ -460,7 +460,7 @@ 
 	}
 
 	public function testDecodeValueFromDatabaseObjectLegacy(): void {
-		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"' . chr(0) . '*' . chr(0) . 'value";s:6:"opaque";}';
+		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"'.chr(0).'*'.chr(0).'value";s:6:"opaque";}';
 		$propertyType = 3;
 		$decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
 		$this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);

apps/dav/tests/unit/DAV/ViewOnlyPluginTest.php

Indentation +128 added lines, -128 removed lines

@@ -28,132 +28,132 @@
 use Test\TestCase;
 
 class ViewOnlyPluginTest extends TestCase {
-	private Tree&MockObject $tree;
-	private RequestInterface&MockObject $request;
-	private Folder&MockObject $userFolder;
-	private ViewOnlyPlugin $plugin;
-
-	public function setUp(): void {
-		parent::setUp();
-
-		$this->userFolder = $this->createMock(Folder::class);
-		$this->request = $this->createMock(RequestInterface::class);
-		$this->tree = $this->createMock(Tree::class);
-		$server = $this->createMock(Server::class);
-
-		$this->plugin = new ViewOnlyPlugin(
-			$this->userFolder,
-		);
-		$server->tree = $this->tree;
-
-		$this->plugin->initialize($server);
-	}
-
-	public function testCanGetNonDav(): void {
-		$this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
-		$this->tree->method('getNodeForPath')->willReturn(null);
-
-		$this->assertTrue($this->plugin->checkViewOnly($this->request));
-	}
-
-	public function testCanGetNonShared(): void {
-		$this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
-		$davNode = $this->createMock(DavFile::class);
-		$this->tree->method('getNodeForPath')->willReturn($davNode);
-
-		$file = $this->createMock(File::class);
-		$davNode->method('getNode')->willReturn($file);
-
-		$storage = $this->createMock(IStorage::class);
-		$file->method('getStorage')->willReturn($storage);
-		$storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(false);
-
-		$this->assertTrue($this->plugin->checkViewOnly($this->request));
-	}
-
-	public static function providesDataForCanGet(): array {
-		return [
-			// has attribute permissions-download enabled - can get file
-			[false, true, true],
-			// has no attribute permissions-download - can get file
-			[false, null, true],
-			// has attribute permissions-download disabled- cannot get the file
-			[false, false, false],
-			// has attribute permissions-download enabled - can get file version
-			[true, true, true],
-			// has no attribute permissions-download - can get file version
-			[true, null, true],
-			// has attribute permissions-download disabled- cannot get the file version
-			[true, false, false],
-		];
-	}
-
-	/**
-	 * @dataProvider providesDataForCanGet
-	 */
-	public function testCanGet(bool $isVersion, ?bool $attrEnabled, bool $expectCanDownloadFile): void {
-		$nodeInfo = $this->createMock(File::class);
-		if ($isVersion) {
-			$davPath = 'versions/alice/versions/117/123456';
-			$version = $this->createMock(IVersion::class);
-			$version->expects($this->once())
-				->method('getSourceFile')
-				->willReturn($nodeInfo);
-			$davNode = $this->createMock(VersionFile::class);
-			$davNode->expects($this->once())
-				->method('getVersion')
-				->willReturn($version);
-
-			$currentUser = $this->createMock(IUser::class);
-			$currentUser->expects($this->once())
-				->method('getUID')
-				->willReturn('alice');
-			$nodeInfo->expects($this->once())
-				->method('getOwner')
-				->willReturn($currentUser);
-
-			$nodeInfo = $this->createMock(File::class);
-			$owner = $this->createMock(IUser::class);
-			$owner->expects($this->once())
-				->method('getUID')
-				->willReturn('bob');
-			$this->userFolder->expects($this->once())
-				->method('getById')
-				->willReturn([$nodeInfo]);
-			$this->userFolder->expects($this->once())
-				->method('getOwner')
-				->willReturn($owner);
-		} else {
-			$davPath = 'files/path/to/file.odt';
-			$davNode = $this->createMock(DavFile::class);
-			$davNode->method('getNode')->willReturn($nodeInfo);
-		}
-
-		$this->request->expects($this->once())->method('getPath')->willReturn($davPath);
-
-		$this->tree->expects($this->once())
-			->method('getNodeForPath')
-			->with($davPath)
-			->willReturn($davNode);
-
-		$storage = $this->createMock(SharedStorage::class);
-		$share = $this->createMock(IShare::class);
-		$nodeInfo->expects($this->once())
-			->method('getStorage')
-			->willReturn($storage);
-		$storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(true);
-		$storage->method('getShare')->willReturn($share);
-
-		$extAttr = $this->createMock(IAttributes::class);
-		$share->method('getAttributes')->willReturn($extAttr);
-		$extAttr->expects($this->once())
-			->method('getAttribute')
-			->with('permissions', 'download')
-			->willReturn($attrEnabled);
-
-		if (!$expectCanDownloadFile) {
-			$this->expectException(Forbidden::class);
-		}
-		$this->plugin->checkViewOnly($this->request);
-	}
+    private Tree&MockObject $tree;
+    private RequestInterface&MockObject $request;
+    private Folder&MockObject $userFolder;
+    private ViewOnlyPlugin $plugin;
+
+    public function setUp(): void {
+        parent::setUp();
+
+        $this->userFolder = $this->createMock(Folder::class);
+        $this->request = $this->createMock(RequestInterface::class);
+        $this->tree = $this->createMock(Tree::class);
+        $server = $this->createMock(Server::class);
+
+        $this->plugin = new ViewOnlyPlugin(
+            $this->userFolder,
+        );
+        $server->tree = $this->tree;
+
+        $this->plugin->initialize($server);
+    }
+
+    public function testCanGetNonDav(): void {
+        $this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
+        $this->tree->method('getNodeForPath')->willReturn(null);
+
+        $this->assertTrue($this->plugin->checkViewOnly($this->request));
+    }
+
+    public function testCanGetNonShared(): void {
+        $this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
+        $davNode = $this->createMock(DavFile::class);
+        $this->tree->method('getNodeForPath')->willReturn($davNode);
+
+        $file = $this->createMock(File::class);
+        $davNode->method('getNode')->willReturn($file);
+
+        $storage = $this->createMock(IStorage::class);
+        $file->method('getStorage')->willReturn($storage);
+        $storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(false);
+
+        $this->assertTrue($this->plugin->checkViewOnly($this->request));
+    }
+
+    public static function providesDataForCanGet(): array {
+        return [
+            // has attribute permissions-download enabled - can get file
+            [false, true, true],
+            // has no attribute permissions-download - can get file
+            [false, null, true],
+            // has attribute permissions-download disabled- cannot get the file
+            [false, false, false],
+            // has attribute permissions-download enabled - can get file version
+            [true, true, true],
+            // has no attribute permissions-download - can get file version
+            [true, null, true],
+            // has attribute permissions-download disabled- cannot get the file version
+            [true, false, false],
+        ];
+    }
+
+    /**
+     * @dataProvider providesDataForCanGet
+     */
+    public function testCanGet(bool $isVersion, ?bool $attrEnabled, bool $expectCanDownloadFile): void {
+        $nodeInfo = $this->createMock(File::class);
+        if ($isVersion) {
+            $davPath = 'versions/alice/versions/117/123456';
+            $version = $this->createMock(IVersion::class);
+            $version->expects($this->once())
+                ->method('getSourceFile')
+                ->willReturn($nodeInfo);
+            $davNode = $this->createMock(VersionFile::class);
+            $davNode->expects($this->once())
+                ->method('getVersion')
+                ->willReturn($version);
+
+            $currentUser = $this->createMock(IUser::class);
+            $currentUser->expects($this->once())
+                ->method('getUID')
+                ->willReturn('alice');
+            $nodeInfo->expects($this->once())
+                ->method('getOwner')
+                ->willReturn($currentUser);
+
+            $nodeInfo = $this->createMock(File::class);
+            $owner = $this->createMock(IUser::class);
+            $owner->expects($this->once())
+                ->method('getUID')
+                ->willReturn('bob');
+            $this->userFolder->expects($this->once())
+                ->method('getById')
+                ->willReturn([$nodeInfo]);
+            $this->userFolder->expects($this->once())
+                ->method('getOwner')
+                ->willReturn($owner);
+        } else {
+            $davPath = 'files/path/to/file.odt';
+            $davNode = $this->createMock(DavFile::class);
+            $davNode->method('getNode')->willReturn($nodeInfo);
+        }
+
+        $this->request->expects($this->once())->method('getPath')->willReturn($davPath);
+
+        $this->tree->expects($this->once())
+            ->method('getNodeForPath')
+            ->with($davPath)
+            ->willReturn($davNode);
+
+        $storage = $this->createMock(SharedStorage::class);
+        $share = $this->createMock(IShare::class);
+        $nodeInfo->expects($this->once())
+            ->method('getStorage')
+            ->willReturn($storage);
+        $storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(true);
+        $storage->method('getShare')->willReturn($share);
+
+        $extAttr = $this->createMock(IAttributes::class);
+        $share->method('getAttributes')->willReturn($extAttr);
+        $extAttr->expects($this->once())
+            ->method('getAttribute')
+            ->with('permissions', 'download')
+            ->willReturn($attrEnabled);
+
+        if (!$expectCanDownloadFile) {
+            $this->expectException(Forbidden::class);
+        }
+        $this->plugin->checkViewOnly($this->request);
+    }
 }

apps/dav/tests/unit/DAV/SystemPrincipalBackendTest.php

Indentation +80 added lines, -80 removed lines

@@ -14,95 +14,95 @@
 
 class SystemPrincipalBackendTest extends TestCase {
 
-	/**
-	 * @dataProvider providesPrefix
-	 */
-	public function testGetPrincipalsByPrefix(array $expected, string $prefix): void {
-		$backend = new SystemPrincipalBackend();
-		$result = $backend->getPrincipalsByPrefix($prefix);
-		$this->assertEquals($expected, $result);
-	}
+    /**
+     * @dataProvider providesPrefix
+     */
+    public function testGetPrincipalsByPrefix(array $expected, string $prefix): void {
+        $backend = new SystemPrincipalBackend();
+        $result = $backend->getPrincipalsByPrefix($prefix);
+        $this->assertEquals($expected, $result);
+    }
 
-	public static function providesPrefix(): array {
-		return [
-			[[], ''],
-			[[[
-				'uri' => 'principals/system/system',
-				'{DAV:}displayname' => 'system',
-			],
-				[
-					'uri' => 'principals/system/public',
-					'{DAV:}displayname' => 'public',
-				]
-			], 'principals/system'],
-		];
-	}
+    public static function providesPrefix(): array {
+        return [
+            [[], ''],
+            [[[
+                'uri' => 'principals/system/system',
+                '{DAV:}displayname' => 'system',
+            ],
+                [
+                    'uri' => 'principals/system/public',
+                    '{DAV:}displayname' => 'public',
+                ]
+            ], 'principals/system'],
+        ];
+    }
 
-	/**
-	 * @dataProvider providesPath
-	 */
-	public function testGetPrincipalByPath(?array $expected, string $path): void {
-		$backend = new SystemPrincipalBackend();
-		$result = $backend->getPrincipalByPath($path);
-		$this->assertEquals($expected, $result);
-	}
+    /**
+     * @dataProvider providesPath
+     */
+    public function testGetPrincipalByPath(?array $expected, string $path): void {
+        $backend = new SystemPrincipalBackend();
+        $result = $backend->getPrincipalByPath($path);
+        $this->assertEquals($expected, $result);
+    }
 
-	public static function providesPath(): array {
-		return [
-			[null, ''],
-			[null, 'principals'],
-			[null, 'principals/system'],
-			[[
-				'uri' => 'principals/system/system',
-				'{DAV:}displayname' => 'system',
-			], 'principals/system/system'],
-		];
-	}
+    public static function providesPath(): array {
+        return [
+            [null, ''],
+            [null, 'principals'],
+            [null, 'principals/system'],
+            [[
+                'uri' => 'principals/system/system',
+                '{DAV:}displayname' => 'system',
+            ], 'principals/system/system'],
+        ];
+    }
 
-	/**
-	 * @dataProvider providesPrincipalForGetGroupMemberSet
-	 */
-	public function testGetGroupMemberSetExceptional(?string $principal): void {
-		$this->expectException(Exception::class);
-		$this->expectExceptionMessage('Principal not found');
+    /**
+     * @dataProvider providesPrincipalForGetGroupMemberSet
+     */
+    public function testGetGroupMemberSetExceptional(?string $principal): void {
+        $this->expectException(Exception::class);
+        $this->expectExceptionMessage('Principal not found');
 
-		$backend = new SystemPrincipalBackend();
-		$backend->getGroupMemberSet($principal);
-	}
+        $backend = new SystemPrincipalBackend();
+        $backend->getGroupMemberSet($principal);
+    }
 
-	public static function providesPrincipalForGetGroupMemberSet(): array {
-		return [
-			[null],
-			['principals/system'],
-		];
-	}
+    public static function providesPrincipalForGetGroupMemberSet(): array {
+        return [
+            [null],
+            ['principals/system'],
+        ];
+    }
 
-	public function testGetGroupMemberSet(): void {
-		$backend = new SystemPrincipalBackend();
-		$result = $backend->getGroupMemberSet('principals/system/system');
-		$this->assertEquals(['principals/system/system'], $result);
-	}
+    public function testGetGroupMemberSet(): void {
+        $backend = new SystemPrincipalBackend();
+        $result = $backend->getGroupMemberSet('principals/system/system');
+        $this->assertEquals(['principals/system/system'], $result);
+    }
 
-	/**
-	 * @dataProvider providesPrincipalForGetGroupMembership
-	 */
-	public function testGetGroupMembershipExceptional(string $principal): void {
-		$this->expectException(Exception::class);
-		$this->expectExceptionMessage('Principal not found');
+    /**
+     * @dataProvider providesPrincipalForGetGroupMembership
+     */
+    public function testGetGroupMembershipExceptional(string $principal): void {
+        $this->expectException(Exception::class);
+        $this->expectExceptionMessage('Principal not found');
 
-		$backend = new SystemPrincipalBackend();
-		$backend->getGroupMembership($principal);
-	}
+        $backend = new SystemPrincipalBackend();
+        $backend->getGroupMembership($principal);
+    }
 
-	public static function providesPrincipalForGetGroupMembership(): array {
-		return [
-			['principals/system/a'],
-		];
-	}
+    public static function providesPrincipalForGetGroupMembership(): array {
+        return [
+            ['principals/system/a'],
+        ];
+    }
 
-	public function testGetGroupMembership(): void {
-		$backend = new SystemPrincipalBackend();
-		$result = $backend->getGroupMembership('principals/system/system');
-		$this->assertEquals([], $result);
-	}
+    public function testGetGroupMembership(): void {
+        $backend = new SystemPrincipalBackend();
+        $result = $backend->getGroupMembership('principals/system/system');
+        $this->assertEquals([], $result);
+    }
 }

apps/dav/tests/unit/Files/Sharing/FilesDropPluginTest.php

Indentation +220 added lines, -220 removed lines

@@ -21,238 +21,238 @@
 
 class FilesDropPluginTest extends TestCase {
 
-	private FilesDropPlugin $plugin;
+    private FilesDropPlugin $plugin;
 
-	private Folder&MockObject $node;
-	private IShare&MockObject $share;
-	private Server&MockObject $server;
-	private RequestInterface&MockObject $request;
-	private ResponseInterface&MockObject $response;
+    private Folder&MockObject $node;
+    private IShare&MockObject $share;
+    private Server&MockObject $server;
+    private RequestInterface&MockObject $request;
+    private ResponseInterface&MockObject $response;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->node = $this->createMock(Folder::class);
-		$this->node->method('getPath')
-			->willReturn('/files/token');
+        $this->node = $this->createMock(Folder::class);
+        $this->node->method('getPath')
+            ->willReturn('/files/token');
 
-		$this->share = $this->createMock(IShare::class);
-		$this->share->expects(self::any())
-			->method('getNode')
-			->willReturn($this->node);
-		$this->server = $this->createMock(Server::class);
-		$this->plugin = new FilesDropPlugin();
+        $this->share = $this->createMock(IShare::class);
+        $this->share->expects(self::any())
+            ->method('getNode')
+            ->willReturn($this->node);
+        $this->server = $this->createMock(Server::class);
+        $this->plugin = new FilesDropPlugin();
 
-		$this->request = $this->createMock(RequestInterface::class);
-		$this->response = $this->createMock(ResponseInterface::class);
+        $this->request = $this->createMock(RequestInterface::class);
+        $this->response = $this->createMock(ResponseInterface::class);
 
-		$attributes = $this->createMock(IAttributes::class);
-		$this->share->expects($this->any())
-			->method('getAttributes')
-			->willReturn($attributes);
+        $attributes = $this->createMock(IAttributes::class);
+        $this->share->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn($attributes);
 
-		$this->share
-			->method('getToken')
-			->willReturn('token');
-	}
+        $this->share
+            ->method('getToken')
+            ->willReturn('token');
+    }
 
-	public function testNotEnabled(): void {
-		$this->request->expects($this->never())
-			->method($this->anything());
+    public function testNotEnabled(): void {
+        $this->request->expects($this->never())
+            ->method($this->anything());
 
-		$this->plugin->beforeMethod($this->request, $this->response);
-	}
+        $this->plugin->beforeMethod($this->request, $this->response);
+    }
 
-	public function testValid(): void {
-		$this->plugin->enable();
-		$this->plugin->setShare($this->share);
+    public function testValid(): void {
+        $this->plugin->enable();
+        $this->plugin->setShare($this->share);
 
-		$this->request->method('getMethod')
-			->willReturn('PUT');
+        $this->request->method('getMethod')
+            ->willReturn('PUT');
 
-		$this->request->method('getPath')
-			->willReturn('/files/token/file.txt');
+        $this->request->method('getPath')
+            ->willReturn('/files/token/file.txt');
 
-		$this->request->method('getBaseUrl')
-			->willReturn('https://example.com');
+        $this->request->method('getBaseUrl')
+            ->willReturn('https://example.com');
 
-		$this->node->expects(self::once())
-			->method('getNonExistingName')
-			->with('file.txt')
-			->willReturn('file.txt');
-
-		$this->request->expects($this->once())
-			->method('setUrl')
-			->with('https://example.com/files/token/file.txt');
-
-		$this->plugin->beforeMethod($this->request, $this->response);
-	}
-
-	public function testFileAlreadyExistsValid(): void {
-		$this->plugin->enable();
-		$this->plugin->setShare($this->share);
-
-		$this->request->method('getMethod')
-			->willReturn('PUT');
-
-		$this->request->method('getPath')
-			->willReturn('/files/token/file.txt');
-
-		$this->request->method('getBaseUrl')
-			->willReturn('https://example.com');
-
-		$this->node->method('getNonExistingName')
-			->with('file.txt')
-			->willReturn('file (2).txt');
-
-		$this->request->expects($this->once())
-			->method('setUrl')
-			->with($this->equalTo('https://example.com/files/token/file (2).txt'));
-
-		$this->plugin->beforeMethod($this->request, $this->response);
-	}
-
-	public function testNoMKCOLWithoutNickname(): void {
-		$this->plugin->enable();
-		$this->plugin->setShare($this->share);
-
-		$this->request->method('getMethod')
-			->willReturn('MKCOL');
-
-		$this->expectException(MethodNotAllowed::class);
-
-		$this->plugin->beforeMethod($this->request, $this->response);
-	}
-
-	public function testMKCOLWithNickname(): void {
-		$this->plugin->enable();
-		$this->plugin->setShare($this->share);
-
-		$this->request->method('getMethod')
-			->willReturn('MKCOL');
-
-		$this->request->method('hasHeader')
-			->with('X-NC-Nickname')
-			->willReturn(true);
-		$this->request->method('getHeader')
-			->with('X-NC-Nickname')
-			->willReturn('nickname');
-
-		$this->expectNotToPerformAssertions();
-
-		$this->plugin->beforeMethod($this->request, $this->response);
-	}
-
-	public function testSubdirPut(): void {
-		$this->plugin->enable();
-		$this->plugin->setShare($this->share);
-
-		$this->request->method('getMethod')
-			->willReturn('PUT');
-
-		$this->request->method('hasHeader')
-			->with('X-NC-Nickname')
-			->willReturn(true);
-		$this->request->method('getHeader')
-			->with('X-NC-Nickname')
-			->willReturn('nickname');
-
-		$this->request->method('getPath')
-			->willReturn('/files/token/folder/file.txt');
-
-		$this->request->method('getBaseUrl')
-			->willReturn('https://example.com');
-
-		$nodeName = $this->createMock(Folder::class);
-		$nodeFolder = $this->createMock(Folder::class);
-		$nodeFolder->expects(self::once())
-			->method('getPath')
-			->willReturn('/files/token/nickname/folder');
-		$nodeFolder->method('getNonExistingName')
-			->with('file.txt')
-			->willReturn('file.txt');
-		$nodeName->expects(self::once())
-			->method('get')
-			->with('folder')
-			->willThrowException(new NotFoundException());
-		$nodeName->expects(self::once())
-			->method('newFolder')
-			->with('folder')
-			->willReturn($nodeFolder);
-
-		$this->node->expects(self::once())
-			->method('get')
-			->willThrowException(new NotFoundException());
-		$this->node->expects(self::once())
-			->method('newFolder')
-			->with('nickname')
-			->willReturn($nodeName);
-
-		$this->request->expects($this->once())
-			->method('setUrl')
-			->with($this->equalTo('https://example.com/files/token/nickname/folder/file.txt'));
-
-		$this->plugin->beforeMethod($this->request, $this->response);
-	}
-
-	public function testRecursiveFolderCreation(): void {
-		$this->plugin->enable();
-		$this->plugin->setShare($this->share);
-
-		$this->request->method('getMethod')
-			->willReturn('PUT');
-		$this->request->method('hasHeader')
-			->with('X-NC-Nickname')
-			->willReturn(true);
-		$this->request->method('getHeader')
-			->with('X-NC-Nickname')
-			->willReturn('nickname');
-
-		$this->request->method('getPath')
-			->willReturn('/files/token/folder/subfolder/file.txt');
-		$this->request->method('getBaseUrl')
-			->willReturn('https://example.com');
-
-		$this->request->expects($this->once())
-			->method('setUrl')
-			->with($this->equalTo('https://example.com/files/token/nickname/folder/subfolder/file.txt'));
-
-		$subfolder = $this->createMock(Folder::class);
-		$subfolder->expects(self::once())
-			->method('getNonExistingName')
-			->with('file.txt')
-			->willReturn('file.txt');
-		$subfolder->expects(self::once())
-			->method('getPath')
-			->willReturn('/files/token/nickname/folder/subfolder');
-
-		$folder = $this->createMock(Folder::class);
-		$folder->expects(self::once())
-			->method('get')
-			->with('subfolder')
-			->willReturn($subfolder);
-
-		$nickname = $this->createMock(Folder::class);
-		$nickname->expects(self::once())
-			->method('get')
-			->with('folder')
-			->willReturn($folder);
-
-		$this->node->method('get')
-			->with('nickname')
-			->willReturn($nickname);
-		$this->plugin->beforeMethod($this->request, $this->response);
-	}
-
-	public function testOnMkcol(): void {
-		$this->plugin->enable();
-		$this->plugin->setShare($this->share);
-
-		$this->response->expects($this->once())
-			->method('setStatus')
-			->with(201);
-
-		$response = $this->plugin->onMkcol($this->request, $this->response);
-		$this->assertFalse($response);
-	}
+        $this->node->expects(self::once())
+            ->method('getNonExistingName')
+            ->with('file.txt')
+            ->willReturn('file.txt');
+
+        $this->request->expects($this->once())
+            ->method('setUrl')
+            ->with('https://example.com/files/token/file.txt');
+
+        $this->plugin->beforeMethod($this->request, $this->response);
+    }
+
+    public function testFileAlreadyExistsValid(): void {
+        $this->plugin->enable();
+        $this->plugin->setShare($this->share);
+
+        $this->request->method('getMethod')
+            ->willReturn('PUT');
+
+        $this->request->method('getPath')
+            ->willReturn('/files/token/file.txt');
+
+        $this->request->method('getBaseUrl')
+            ->willReturn('https://example.com');
+
+        $this->node->method('getNonExistingName')
+            ->with('file.txt')
+            ->willReturn('file (2).txt');
+
+        $this->request->expects($this->once())
+            ->method('setUrl')
+            ->with($this->equalTo('https://example.com/files/token/file (2).txt'));
+
+        $this->plugin->beforeMethod($this->request, $this->response);
+    }
+
+    public function testNoMKCOLWithoutNickname(): void {
+        $this->plugin->enable();
+        $this->plugin->setShare($this->share);
+
+        $this->request->method('getMethod')
+            ->willReturn('MKCOL');
+
+        $this->expectException(MethodNotAllowed::class);
+
+        $this->plugin->beforeMethod($this->request, $this->response);
+    }
+
+    public function testMKCOLWithNickname(): void {
+        $this->plugin->enable();
+        $this->plugin->setShare($this->share);
+
+        $this->request->method('getMethod')
+            ->willReturn('MKCOL');
+
+        $this->request->method('hasHeader')
+            ->with('X-NC-Nickname')
+            ->willReturn(true);
+        $this->request->method('getHeader')
+            ->with('X-NC-Nickname')
+            ->willReturn('nickname');
+
+        $this->expectNotToPerformAssertions();
+
+        $this->plugin->beforeMethod($this->request, $this->response);
+    }
+
+    public function testSubdirPut(): void {
+        $this->plugin->enable();
+        $this->plugin->setShare($this->share);
+
+        $this->request->method('getMethod')
+            ->willReturn('PUT');
+
+        $this->request->method('hasHeader')
+            ->with('X-NC-Nickname')
+            ->willReturn(true);
+        $this->request->method('getHeader')
+            ->with('X-NC-Nickname')
+            ->willReturn('nickname');
+
+        $this->request->method('getPath')
+            ->willReturn('/files/token/folder/file.txt');
+
+        $this->request->method('getBaseUrl')
+            ->willReturn('https://example.com');
+
+        $nodeName = $this->createMock(Folder::class);
+        $nodeFolder = $this->createMock(Folder::class);
+        $nodeFolder->expects(self::once())
+            ->method('getPath')
+            ->willReturn('/files/token/nickname/folder');
+        $nodeFolder->method('getNonExistingName')
+            ->with('file.txt')
+            ->willReturn('file.txt');
+        $nodeName->expects(self::once())
+            ->method('get')
+            ->with('folder')
+            ->willThrowException(new NotFoundException());
+        $nodeName->expects(self::once())
+            ->method('newFolder')
+            ->with('folder')
+            ->willReturn($nodeFolder);
+
+        $this->node->expects(self::once())
+            ->method('get')
+            ->willThrowException(new NotFoundException());
+        $this->node->expects(self::once())
+            ->method('newFolder')
+            ->with('nickname')
+            ->willReturn($nodeName);
+
+        $this->request->expects($this->once())
+            ->method('setUrl')
+            ->with($this->equalTo('https://example.com/files/token/nickname/folder/file.txt'));
+
+        $this->plugin->beforeMethod($this->request, $this->response);
+    }
+
+    public function testRecursiveFolderCreation(): void {
+        $this->plugin->enable();
+        $this->plugin->setShare($this->share);
+
+        $this->request->method('getMethod')
+            ->willReturn('PUT');
+        $this->request->method('hasHeader')
+            ->with('X-NC-Nickname')
+            ->willReturn(true);
+        $this->request->method('getHeader')
+            ->with('X-NC-Nickname')
+            ->willReturn('nickname');
+
+        $this->request->method('getPath')
+            ->willReturn('/files/token/folder/subfolder/file.txt');
+        $this->request->method('getBaseUrl')
+            ->willReturn('https://example.com');
+
+        $this->request->expects($this->once())
+            ->method('setUrl')
+            ->with($this->equalTo('https://example.com/files/token/nickname/folder/subfolder/file.txt'));
+
+        $subfolder = $this->createMock(Folder::class);
+        $subfolder->expects(self::once())
+            ->method('getNonExistingName')
+            ->with('file.txt')
+            ->willReturn('file.txt');
+        $subfolder->expects(self::once())
+            ->method('getPath')
+            ->willReturn('/files/token/nickname/folder/subfolder');
+
+        $folder = $this->createMock(Folder::class);
+        $folder->expects(self::once())
+            ->method('get')
+            ->with('subfolder')
+            ->willReturn($subfolder);
+
+        $nickname = $this->createMock(Folder::class);
+        $nickname->expects(self::once())
+            ->method('get')
+            ->with('folder')
+            ->willReturn($folder);
+
+        $this->node->method('get')
+            ->with('nickname')
+            ->willReturn($nickname);
+        $this->plugin->beforeMethod($this->request, $this->response);
+    }
+
+    public function testOnMkcol(): void {
+        $this->plugin->enable();
+        $this->plugin->setShare($this->share);
+
+        $this->response->expects($this->once())
+            ->method('setStatus')
+            ->with(201);
+
+        $response = $this->plugin->onMkcol($this->request, $this->response);
+        $this->assertFalse($response);
+    }
 }

apps/dav/tests/unit/Files/MultipartRequestParserTest.php

Indentation +303 added lines, -303 removed lines

@@ -16,307 +16,307 @@
 
 class MultipartRequestParserTest extends TestCase {
 
-	protected LoggerInterface&MockObject $logger;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->logger = $this->createMock(LoggerInterface::class);
-	}
-
-	private static function getValidBodyObject(): array {
-		return [
-			[
-				'headers' => [
-					'Content-Length' => 7,
-					'X-File-MD5' => '4f2377b4d911f7ec46325fe603c3af03',
-					'OC-Checksum' => 'md5:4f2377b4d911f7ec46325fe603c3af03',
-					'X-File-Path' => '/coucou.txt'
-				],
-				'content' => "Coucou\n"
-			]
-		];
-	}
-
-	private function getMultipartParser(array $parts, array $headers = [], string $boundary = 'boundary_azertyuiop'): MultipartRequestParser {
-		/** @var RequestInterface&MockObject $request */
-		$request = $this->getMockBuilder(RequestInterface::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$headers = array_merge(['Content-Type' => 'multipart/related; boundary=' . $boundary], $headers);
-		$request->expects($this->any())
-			->method('getHeader')
-			->willReturnCallback(function (string $key) use (&$headers) {
-				return $headers[$key];
-			});
-
-		$body = '';
-		foreach ($parts as $part) {
-			$body .= '--' . $boundary . "\r\n";
-
-			foreach ($part['headers'] as $headerKey => $headerPart) {
-				$body .= $headerKey . ': ' . $headerPart . "\r\n";
-			}
-
-			$body .= "\r\n";
-			$body .= $part['content'] . "\r\n";
-		}
-
-		$body .= '--' . $boundary . '--';
-
-		$stream = fopen('php://temp', 'r+');
-		fwrite($stream, $body);
-		rewind($stream);
-
-		$request->expects($this->any())
-			->method('getBody')
-			->willReturn($stream);
-
-		return new MultipartRequestParser($request, $this->logger);
-	}
-
-
-	/**
-	 * Test validation of the request's body type
-	 */
-	public function testBodyTypeValidation(): void {
-		$bodyStream = 'I am not a stream, but pretend to be';
-		/** @var RequestInterface&MockObject $request */
-		$request = $this->getMockBuilder(RequestInterface::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$request->expects($this->any())
-			->method('getBody')
-			->willReturn($bodyStream);
-
-		$this->expectExceptionMessage('Body should be of type resource');
-		new MultipartRequestParser($request, $this->logger);
-	}
-
-	/**
-	 * Test with valid request.
-	 * - valid boundary
-	 * - valid hash
-	 * - valid content-length
-	 * - valid file content
-	 * - valid file path
-	 */
-	public function testValidRequest(): void {
-		$bodyObject = self::getValidBodyObject();
-		unset($bodyObject['0']['headers']['X-File-MD5']);
-
-		$multipartParser = $this->getMultipartParser($bodyObject);
-
-		[$headers, $content] = $multipartParser->parseNextPart();
-
-		$this->assertSame((int)$headers['content-length'], 7, 'Content-Length header should be the same as provided.');
-		$this->assertSame($headers['oc-checksum'], 'md5:4f2377b4d911f7ec46325fe603c3af03', 'OC-Checksum header should be the same as provided.');
-		$this->assertSame($headers['x-file-path'], '/coucou.txt', 'X-File-Path header should be the same as provided.');
-
-		$this->assertSame($content, "Coucou\n", 'Content should be the same');
-	}
-
-	/**
-	 * Test with valid request.
-	 * - valid boundary
-	 * - valid md5 hash
-	 * - valid content-length
-	 * - valid file content
-	 * - valid file path
-	 */
-	public function testValidRequestWithMd5(): void {
-		$bodyObject = self::getValidBodyObject();
-		unset($bodyObject['0']['headers']['OC-Checksum']);
-
-		$multipartParser = $this->getMultipartParser($bodyObject);
-
-		[$headers, $content] = $multipartParser->parseNextPart();
-
-		$this->assertSame((int)$headers['content-length'], 7, 'Content-Length header should be the same as provided.');
-		$this->assertSame($headers['x-file-md5'], '4f2377b4d911f7ec46325fe603c3af03', 'X-File-MD5 header should be the same as provided.');
-		$this->assertSame($headers['x-file-path'], '/coucou.txt', 'X-File-Path header should be the same as provided.');
-
-		$this->assertSame($content, "Coucou\n", 'Content should be the same');
-	}
-
-	/**
-	 * Test with invalid hash.
-	 */
-	public function testInvalidHash(): void {
-		$bodyObject = self::getValidBodyObject();
-		$bodyObject['0']['headers']['OC-Checksum'] = 'md5:f2377b4d911f7ec46325fe603c3af03';
-		unset($bodyObject['0']['headers']['X-File-MD5']);
-		$multipartParser = $this->getMultipartParser(
-			$bodyObject
-		);
-
-		$this->expectExceptionMessage('Computed md5 hash is incorrect (4f2377b4d911f7ec46325fe603c3af03).');
-		$multipartParser->parseNextPart();
-	}
-
-	/**
-	 * Test with invalid md5 hash.
-	 */
-	public function testInvalidMd5Hash(): void {
-		$bodyObject = self::getValidBodyObject();
-		unset($bodyObject['0']['headers']['OC-Checksum']);
-		$bodyObject['0']['headers']['X-File-MD5'] = 'f2377b4d911f7ec46325fe603c3af03';
-		$multipartParser = $this->getMultipartParser(
-			$bodyObject
-		);
-
-		$this->expectExceptionMessage('Computed md5 hash is incorrect (4f2377b4d911f7ec46325fe603c3af03).');
-		$multipartParser->parseNextPart();
-	}
-
-	/**
-	 * Test with a null hash headers.
-	 */
-	public function testNullHash(): void {
-		$bodyObject = self::getValidBodyObject();
-		unset($bodyObject['0']['headers']['OC-Checksum']);
-		unset($bodyObject['0']['headers']['X-File-MD5']);
-		$multipartParser = $this->getMultipartParser(
-			$bodyObject
-		);
-
-		$this->expectExceptionMessage('The hash headers must not be null.');
-		$multipartParser->parseNextPart();
-	}
-
-	/**
-	 * Test with a null Content-Length.
-	 */
-	public function testNullContentLength(): void {
-		$bodyObject = self::getValidBodyObject();
-		unset($bodyObject['0']['headers']['Content-Length']);
-		$multipartParser = $this->getMultipartParser(
-			$bodyObject
-		);
-
-		$this->expectExceptionMessage('The Content-Length header must not be null.');
-		$multipartParser->parseNextPart();
-	}
-
-	/**
-	 * Test with a lower Content-Length.
-	 */
-	public function testLowerContentLength(): void {
-		$bodyObject = self::getValidBodyObject();
-		$bodyObject['0']['headers']['Content-Length'] = 6;
-		$multipartParser = $this->getMultipartParser(
-			$bodyObject
-		);
-
-		$this->expectExceptionMessage('Computed md5 hash is incorrect (41060d3ddfdf63e68fc2bf196f652ee9).');
-		$multipartParser->parseNextPart();
-	}
-
-	/**
-	 * Test with a higher Content-Length.
-	 */
-	public function testHigherContentLength(): void {
-		$bodyObject = self::getValidBodyObject();
-		$bodyObject['0']['headers']['Content-Length'] = 8;
-		$multipartParser = $this->getMultipartParser(
-			$bodyObject
-		);
-
-		$this->expectExceptionMessage('Computed md5 hash is incorrect (0161002bbee6a744f18741b8a914e413).');
-		$multipartParser->parseNextPart();
-	}
-
-	/**
-	 * Test with wrong boundary in body.
-	 */
-	public function testWrongBoundary(): void {
-		$bodyObject = self::getValidBodyObject();
-		$multipartParser = $this->getMultipartParser(
-			$bodyObject,
-			['Content-Type' => 'multipart/related; boundary=boundary_poiuytreza']
-		);
-
-		$this->expectExceptionMessage('Boundary not found where it should be.');
-		$multipartParser->parseNextPart();
-	}
-
-	/**
-	 * Test with no boundary in request headers.
-	 */
-	public function testNoBoundaryInHeader(): void {
-		$bodyObject = self::getValidBodyObject();
-		$this->expectExceptionMessage('Error while parsing boundary in Content-Type header.');
-		$this->getMultipartParser(
-			$bodyObject,
-			['Content-Type' => 'multipart/related']
-		);
-	}
-
-	/**
-	 * Test with no boundary in the request's headers.
-	 */
-	public function testNoBoundaryInBody(): void {
-		$bodyObject = self::getValidBodyObject();
-		$multipartParser = $this->getMultipartParser(
-			$bodyObject,
-			['Content-Type' => 'multipart/related; boundary=boundary_azertyuiop'],
-			''
-		);
-
-		$this->expectExceptionMessage('Boundary not found where it should be.');
-		$multipartParser->parseNextPart();
-	}
-
-	/**
-	 * Test with a boundary with quotes in the request's headers.
-	 */
-	public function testBoundaryWithQuotes(): void {
-		$bodyObject = self::getValidBodyObject();
-		$multipartParser = $this->getMultipartParser(
-			$bodyObject,
-			['Content-Type' => 'multipart/related; boundary="boundary_azertyuiop"'],
-		);
-
-		$multipartParser->parseNextPart();
-
-		// Dummy assertion, we just want to test that the parsing works.
-		$this->assertTrue(true);
-	}
-
-	/**
-	 * Test with a wrong Content-Type in the request's headers.
-	 */
-	public function testWrongContentType(): void {
-		$bodyObject = self::getValidBodyObject();
-		$this->expectExceptionMessage('Content-Type must be multipart/related');
-		$this->getMultipartParser(
-			$bodyObject,
-			['Content-Type' => 'multipart/form-data; boundary="boundary_azertyuiop"'],
-		);
-	}
-
-	/**
-	 * Test with a wrong key after the content type in the request's headers.
-	 */
-	public function testWrongKeyInContentType(): void {
-		$bodyObject = self::getValidBodyObject();
-		$this->expectExceptionMessage('Boundary is invalid');
-		$this->getMultipartParser(
-			$bodyObject,
-			['Content-Type' => 'multipart/related; wrongkey="boundary_azertyuiop"'],
-		);
-	}
-
-	/**
-	 * Test with a null Content-Type in the request's headers.
-	 */
-	public function testNullContentType(): void {
-		$bodyObject = self::getValidBodyObject();
-		$this->expectExceptionMessage('Content-Type can not be null');
-		$this->getMultipartParser(
-			$bodyObject,
-			['Content-Type' => null],
-
-		);
-	}
+    protected LoggerInterface&MockObject $logger;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->logger = $this->createMock(LoggerInterface::class);
+    }
+
+    private static function getValidBodyObject(): array {
+        return [
+            [
+                'headers' => [
+                    'Content-Length' => 7,
+                    'X-File-MD5' => '4f2377b4d911f7ec46325fe603c3af03',
+                    'OC-Checksum' => 'md5:4f2377b4d911f7ec46325fe603c3af03',
+                    'X-File-Path' => '/coucou.txt'
+                ],
+                'content' => "Coucou\n"
+            ]
+        ];
+    }
+
+    private function getMultipartParser(array $parts, array $headers = [], string $boundary = 'boundary_azertyuiop'): MultipartRequestParser {
+        /** @var RequestInterface&MockObject $request */
+        $request = $this->getMockBuilder(RequestInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $headers = array_merge(['Content-Type' => 'multipart/related; boundary=' . $boundary], $headers);
+        $request->expects($this->any())
+            ->method('getHeader')
+            ->willReturnCallback(function (string $key) use (&$headers) {
+                return $headers[$key];
+            });
+
+        $body = '';
+        foreach ($parts as $part) {
+            $body .= '--' . $boundary . "\r\n";
+
+            foreach ($part['headers'] as $headerKey => $headerPart) {
+                $body .= $headerKey . ': ' . $headerPart . "\r\n";
+            }
+
+            $body .= "\r\n";
+            $body .= $part['content'] . "\r\n";
+        }
+
+        $body .= '--' . $boundary . '--';
+
+        $stream = fopen('php://temp', 'r+');
+        fwrite($stream, $body);
+        rewind($stream);
+
+        $request->expects($this->any())
+            ->method('getBody')
+            ->willReturn($stream);
+
+        return new MultipartRequestParser($request, $this->logger);
+    }
+
+
+    /**
+     * Test validation of the request's body type
+     */
+    public function testBodyTypeValidation(): void {
+        $bodyStream = 'I am not a stream, but pretend to be';
+        /** @var RequestInterface&MockObject $request */
+        $request = $this->getMockBuilder(RequestInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $request->expects($this->any())
+            ->method('getBody')
+            ->willReturn($bodyStream);
+
+        $this->expectExceptionMessage('Body should be of type resource');
+        new MultipartRequestParser($request, $this->logger);
+    }
+
+    /**
+     * Test with valid request.
+     * - valid boundary
+     * - valid hash
+     * - valid content-length
+     * - valid file content
+     * - valid file path
+     */
+    public function testValidRequest(): void {
+        $bodyObject = self::getValidBodyObject();
+        unset($bodyObject['0']['headers']['X-File-MD5']);
+
+        $multipartParser = $this->getMultipartParser($bodyObject);
+
+        [$headers, $content] = $multipartParser->parseNextPart();
+
+        $this->assertSame((int)$headers['content-length'], 7, 'Content-Length header should be the same as provided.');
+        $this->assertSame($headers['oc-checksum'], 'md5:4f2377b4d911f7ec46325fe603c3af03', 'OC-Checksum header should be the same as provided.');
+        $this->assertSame($headers['x-file-path'], '/coucou.txt', 'X-File-Path header should be the same as provided.');
+
+        $this->assertSame($content, "Coucou\n", 'Content should be the same');
+    }
+
+    /**
+     * Test with valid request.
+     * - valid boundary
+     * - valid md5 hash
+     * - valid content-length
+     * - valid file content
+     * - valid file path
+     */
+    public function testValidRequestWithMd5(): void {
+        $bodyObject = self::getValidBodyObject();
+        unset($bodyObject['0']['headers']['OC-Checksum']);
+
+        $multipartParser = $this->getMultipartParser($bodyObject);
+
+        [$headers, $content] = $multipartParser->parseNextPart();
+
+        $this->assertSame((int)$headers['content-length'], 7, 'Content-Length header should be the same as provided.');
+        $this->assertSame($headers['x-file-md5'], '4f2377b4d911f7ec46325fe603c3af03', 'X-File-MD5 header should be the same as provided.');
+        $this->assertSame($headers['x-file-path'], '/coucou.txt', 'X-File-Path header should be the same as provided.');
+
+        $this->assertSame($content, "Coucou\n", 'Content should be the same');
+    }
+
+    /**
+     * Test with invalid hash.
+     */
+    public function testInvalidHash(): void {
+        $bodyObject = self::getValidBodyObject();
+        $bodyObject['0']['headers']['OC-Checksum'] = 'md5:f2377b4d911f7ec46325fe603c3af03';
+        unset($bodyObject['0']['headers']['X-File-MD5']);
+        $multipartParser = $this->getMultipartParser(
+            $bodyObject
+        );
+
+        $this->expectExceptionMessage('Computed md5 hash is incorrect (4f2377b4d911f7ec46325fe603c3af03).');
+        $multipartParser->parseNextPart();
+    }
+
+    /**
+     * Test with invalid md5 hash.
+     */
+    public function testInvalidMd5Hash(): void {
+        $bodyObject = self::getValidBodyObject();
+        unset($bodyObject['0']['headers']['OC-Checksum']);
+        $bodyObject['0']['headers']['X-File-MD5'] = 'f2377b4d911f7ec46325fe603c3af03';
+        $multipartParser = $this->getMultipartParser(
+            $bodyObject
+        );
+
+        $this->expectExceptionMessage('Computed md5 hash is incorrect (4f2377b4d911f7ec46325fe603c3af03).');
+        $multipartParser->parseNextPart();
+    }
+
+    /**
+     * Test with a null hash headers.
+     */
+    public function testNullHash(): void {
+        $bodyObject = self::getValidBodyObject();
+        unset($bodyObject['0']['headers']['OC-Checksum']);
+        unset($bodyObject['0']['headers']['X-File-MD5']);
+        $multipartParser = $this->getMultipartParser(
+            $bodyObject
+        );
+
+        $this->expectExceptionMessage('The hash headers must not be null.');
+        $multipartParser->parseNextPart();
+    }
+
+    /**
+     * Test with a null Content-Length.
+     */
+    public function testNullContentLength(): void {
+        $bodyObject = self::getValidBodyObject();
+        unset($bodyObject['0']['headers']['Content-Length']);
+        $multipartParser = $this->getMultipartParser(
+            $bodyObject
+        );
+
+        $this->expectExceptionMessage('The Content-Length header must not be null.');
+        $multipartParser->parseNextPart();
+    }
+
+    /**
+     * Test with a lower Content-Length.
+     */
+    public function testLowerContentLength(): void {
+        $bodyObject = self::getValidBodyObject();
+        $bodyObject['0']['headers']['Content-Length'] = 6;
+        $multipartParser = $this->getMultipartParser(
+            $bodyObject
+        );
+
+        $this->expectExceptionMessage('Computed md5 hash is incorrect (41060d3ddfdf63e68fc2bf196f652ee9).');
+        $multipartParser->parseNextPart();
+    }
+
+    /**
+     * Test with a higher Content-Length.
+     */
+    public function testHigherContentLength(): void {
+        $bodyObject = self::getValidBodyObject();
+        $bodyObject['0']['headers']['Content-Length'] = 8;
+        $multipartParser = $this->getMultipartParser(
+            $bodyObject
+        );
+
+        $this->expectExceptionMessage('Computed md5 hash is incorrect (0161002bbee6a744f18741b8a914e413).');
+        $multipartParser->parseNextPart();
+    }
+
+    /**
+     * Test with wrong boundary in body.
+     */
+    public function testWrongBoundary(): void {
+        $bodyObject = self::getValidBodyObject();
+        $multipartParser = $this->getMultipartParser(
+            $bodyObject,
+            ['Content-Type' => 'multipart/related; boundary=boundary_poiuytreza']
+        );
+
+        $this->expectExceptionMessage('Boundary not found where it should be.');
+        $multipartParser->parseNextPart();
+    }
+
+    /**
+     * Test with no boundary in request headers.
+     */
+    public function testNoBoundaryInHeader(): void {
+        $bodyObject = self::getValidBodyObject();
+        $this->expectExceptionMessage('Error while parsing boundary in Content-Type header.');
+        $this->getMultipartParser(
+            $bodyObject,
+            ['Content-Type' => 'multipart/related']
+        );
+    }
+
+    /**
+     * Test with no boundary in the request's headers.
+     */
+    public function testNoBoundaryInBody(): void {
+        $bodyObject = self::getValidBodyObject();
+        $multipartParser = $this->getMultipartParser(
+            $bodyObject,
+            ['Content-Type' => 'multipart/related; boundary=boundary_azertyuiop'],
+            ''
+        );
+
+        $this->expectExceptionMessage('Boundary not found where it should be.');
+        $multipartParser->parseNextPart();
+    }
+
+    /**
+     * Test with a boundary with quotes in the request's headers.
+     */
+    public function testBoundaryWithQuotes(): void {
+        $bodyObject = self::getValidBodyObject();
+        $multipartParser = $this->getMultipartParser(
+            $bodyObject,
+            ['Content-Type' => 'multipart/related; boundary="boundary_azertyuiop"'],
+        );
+
+        $multipartParser->parseNextPart();
+
+        // Dummy assertion, we just want to test that the parsing works.
+        $this->assertTrue(true);
+    }
+
+    /**
+     * Test with a wrong Content-Type in the request's headers.
+     */
+    public function testWrongContentType(): void {
+        $bodyObject = self::getValidBodyObject();
+        $this->expectExceptionMessage('Content-Type must be multipart/related');
+        $this->getMultipartParser(
+            $bodyObject,
+            ['Content-Type' => 'multipart/form-data; boundary="boundary_azertyuiop"'],
+        );
+    }
+
+    /**
+     * Test with a wrong key after the content type in the request's headers.
+     */
+    public function testWrongKeyInContentType(): void {
+        $bodyObject = self::getValidBodyObject();
+        $this->expectExceptionMessage('Boundary is invalid');
+        $this->getMultipartParser(
+            $bodyObject,
+            ['Content-Type' => 'multipart/related; wrongkey="boundary_azertyuiop"'],
+        );
+    }
+
+    /**
+     * Test with a null Content-Type in the request's headers.
+     */
+    public function testNullContentType(): void {
+        $bodyObject = self::getValidBodyObject();
+        $this->expectExceptionMessage('Content-Type can not be null');
+        $this->getMultipartParser(
+            $bodyObject,
+            ['Content-Type' => null],
+
+        );
+    }
 }

apps/dav/tests/unit/Files/FileSearchBackendTest.php

Indentation +367 added lines, -367 removed lines

@@ -35,371 +35,371 @@
 use Test\TestCase;
 
 class FileSearchBackendTest extends TestCase {
-	private ObjectTree&MockObject $tree;
-	private IUser&MockObject $user;
-	private IRootFolder&MockObject $rootFolder;
-	private IManager&MockObject $shareManager;
-	private View&MockObject $view;
-	private Folder&MockObject $searchFolder;
-	private Directory&MockObject $davFolder;
-	private FileSearchBackend $search;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->user = $this->createMock(IUser::class);
-		$this->user->expects($this->any())
-			->method('getUID')
-			->willReturn('test');
-
-		$this->tree = $this->createMock(ObjectTree::class);
-		$this->view = $this->createMock(View::class);
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$this->shareManager = $this->createMock(IManager::class);
-		$this->searchFolder = $this->createMock(Folder::class);
-		$fileInfo = $this->createMock(FileInfo::class);
-		$this->davFolder = $this->createMock(Directory::class);
-
-		$this->view->expects($this->any())
-			->method('getRoot')
-			->willReturn('');
-
-		$this->view->expects($this->any())
-			->method('getRelativePath')
-			->willReturnArgument(0);
-
-		$this->davFolder->expects($this->any())
-			->method('getFileInfo')
-			->willReturn($fileInfo);
-
-		$this->rootFolder->expects($this->any())
-			->method('get')
-			->willReturn($this->searchFolder);
-
-		$filesMetadataManager = $this->createMock(IFilesMetadataManager::class);
-
-		$this->search = new FileSearchBackend($this->tree, $this->user, $this->rootFolder, $this->shareManager, $this->view, $filesMetadataManager);
-	}
-
-	public function testSearchFilename(): void {
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->willReturn($this->davFolder);
-
-		$this->searchFolder->expects($this->once())
-			->method('search')
-			->with(new SearchQuery(
-				new SearchComparison(
-					ISearchComparison::COMPARE_EQUAL,
-					'name',
-					'foo'
-				),
-				0,
-				0,
-				[],
-				$this->user
-			))
-			->willReturn([
-				new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
-			]);
-
-		$query = $this->getBasicQuery(Operator::OPERATION_EQUAL, '{DAV:}displayname', 'foo');
-		$result = $this->search->search($query);
-
-		$this->assertCount(1, $result);
-		$this->assertEquals('/files/test/test/path', $result[0]->href);
-	}
-
-	public function testSearchMimetype(): void {
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->willReturn($this->davFolder);
-
-		$this->searchFolder->expects($this->once())
-			->method('search')
-			->with(new SearchQuery(
-				new SearchComparison(
-					ISearchComparison::COMPARE_EQUAL,
-					'mimetype',
-					'foo'
-				),
-				0,
-				0,
-				[],
-				$this->user
-			))
-			->willReturn([
-				new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
-			]);
-
-		$query = $this->getBasicQuery(Operator::OPERATION_EQUAL, '{DAV:}getcontenttype', 'foo');
-		$result = $this->search->search($query);
-
-		$this->assertCount(1, $result);
-		$this->assertEquals('/files/test/test/path', $result[0]->href);
-	}
-
-	public function testSearchSize(): void {
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->willReturn($this->davFolder);
-
-		$this->searchFolder->expects($this->once())
-			->method('search')
-			->with(new SearchQuery(
-				new SearchComparison(
-					ISearchComparison::COMPARE_GREATER_THAN,
-					'size',
-					10
-				),
-				0,
-				0,
-				[],
-				$this->user
-			))
-			->willReturn([
-				new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
-			]);
-
-		$query = $this->getBasicQuery(Operator::OPERATION_GREATER_THAN, FilesPlugin::SIZE_PROPERTYNAME, 10);
-		$result = $this->search->search($query);
-
-		$this->assertCount(1, $result);
-		$this->assertEquals('/files/test/test/path', $result[0]->href);
-	}
-
-	public function testSearchMtime(): void {
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->willReturn($this->davFolder);
-
-		$this->searchFolder->expects($this->once())
-			->method('search')
-			->with(new SearchQuery(
-				new SearchComparison(
-					ISearchComparison::COMPARE_GREATER_THAN,
-					'mtime',
-					10
-				),
-				0,
-				0,
-				[],
-				$this->user
-			))
-			->willReturn([
-				new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
-			]);
-
-		$query = $this->getBasicQuery(Operator::OPERATION_GREATER_THAN, '{DAV:}getlastmodified', 10);
-		$result = $this->search->search($query);
-
-		$this->assertCount(1, $result);
-		$this->assertEquals('/files/test/test/path', $result[0]->href);
-	}
-
-	public function testSearchIsCollection(): void {
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->willReturn($this->davFolder);
-
-		$this->searchFolder->expects($this->once())
-			->method('search')
-			->with(new SearchQuery(
-				new SearchComparison(
-					ISearchComparison::COMPARE_EQUAL,
-					'mimetype',
-					FileInfo::MIMETYPE_FOLDER
-				),
-				0,
-				0,
-				[],
-				$this->user
-			))
-			->willReturn([
-				new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
-			]);
-
-		$query = $this->getBasicQuery(Operator::OPERATION_IS_COLLECTION, 'yes');
-		$result = $this->search->search($query);
-
-		$this->assertCount(1, $result);
-		$this->assertEquals('/files/test/test/path', $result[0]->href);
-	}
-
-
-	public function testSearchInvalidProp(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->willReturn($this->davFolder);
-
-		$this->searchFolder->expects($this->never())
-			->method('search');
-
-		$query = $this->getBasicQuery(Operator::OPERATION_EQUAL, '{DAV:}getetag', 'foo');
-		$this->search->search($query);
-	}
-
-	private function getBasicQuery(string $type, string $property, int|string|null $value = null) {
-		$scope = new Scope('/', 'infinite');
-		$scope->path = '/';
-		$from = [$scope];
-		$orderBy = [];
-		$select = [];
-		if (is_null($value)) {
-			$where = new Operator(
-				$type,
-				[new Literal($property)]
-			);
-		} else {
-			$where = new Operator(
-				$type,
-				[new SearchPropertyDefinition($property, true, true, true), new Literal($value)]
-			);
-		}
-		$limit = new Limit();
-
-		return new Query($select, $from, $where, $orderBy, $limit);
-	}
-
-
-	public function testSearchNonFolder(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$davNode = $this->createMock(File::class);
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->willReturn($davNode);
-
-		$query = $this->getBasicQuery(Operator::OPERATION_EQUAL, '{DAV:}displayname', 'foo');
-		$this->search->search($query);
-	}
-
-	public function testSearchLimitOwnerBasic(): void {
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->willReturn($this->davFolder);
-
-		/** @var ISearchQuery|null $receivedQuery */
-		$receivedQuery = null;
-		$this->searchFolder
-			->method('search')
-			->willReturnCallback(function ($query) use (&$receivedQuery) {
-				$receivedQuery = $query;
-				return [
-					new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
-				];
-			});
-
-		$query = $this->getBasicQuery(Operator::OPERATION_EQUAL, FilesPlugin::OWNER_ID_PROPERTYNAME, $this->user->getUID());
-		$this->search->search($query);
-
-		$this->assertNotNull($receivedQuery);
-		$this->assertTrue($receivedQuery->limitToHome());
-
-		/** @var ISearchBinaryOperator $operator */
-		$operator = $receivedQuery->getSearchOperation();
-		$this->assertInstanceOf(ISearchBinaryOperator::class, $operator);
-		$this->assertEquals(ISearchBinaryOperator::OPERATOR_AND, $operator->getType());
-		$this->assertEmpty($operator->getArguments());
-	}
-
-	public function testSearchLimitOwnerNested(): void {
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->willReturn($this->davFolder);
-
-		/** @var ISearchQuery|null $receivedQuery */
-		$receivedQuery = null;
-		$this->searchFolder
-			->method('search')
-			->willReturnCallback(function ($query) use (&$receivedQuery) {
-				$receivedQuery = $query;
-				return [
-					new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
-				];
-			});
-
-		$query = $this->getBasicQuery(Operator::OPERATION_EQUAL, FilesPlugin::OWNER_ID_PROPERTYNAME, $this->user->getUID());
-		$query->where = new Operator(
-			Operator::OPERATION_AND,
-			[
-				new Operator(
-					Operator::OPERATION_EQUAL,
-					[new SearchPropertyDefinition('{DAV:}getcontenttype', true, true, true), new Literal('image/png')]
-				),
-				new Operator(
-					Operator::OPERATION_EQUAL,
-					[new SearchPropertyDefinition(FilesPlugin::OWNER_ID_PROPERTYNAME, true, true, true), new Literal($this->user->getUID())]
-				),
-			]
-		);
-		$this->search->search($query);
-
-		$this->assertNotNull($receivedQuery);
-		$this->assertTrue($receivedQuery->limitToHome());
-
-		/** @var ISearchBinaryOperator $operator */
-		$operator = $receivedQuery->getSearchOperation();
-		$this->assertInstanceOf(ISearchBinaryOperator::class, $operator);
-		$this->assertEquals(ISearchBinaryOperator::OPERATOR_AND, $operator->getType());
-		$this->assertCount(2, $operator->getArguments());
-
-		/** @var ISearchBinaryOperator $operator */
-		$operator = $operator->getArguments()[1];
-		$this->assertInstanceOf(ISearchBinaryOperator::class, $operator);
-		$this->assertEquals(ISearchBinaryOperator::OPERATOR_AND, $operator->getType());
-		$this->assertEmpty($operator->getArguments());
-	}
-
-	public function testSearchOperatorLimit(): void {
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->willReturn($this->davFolder);
-
-		$innerOperator = new Operator(
-			Operator::OPERATION_EQUAL,
-			[new SearchPropertyDefinition('{DAV:}getcontenttype', true, true, true), new Literal('image/png')]
-		);
-		// 5 child operators
-		$level1Operator = new Operator(
-			Operator::OPERATION_AND,
-			[
-				$innerOperator,
-				$innerOperator,
-				$innerOperator,
-				$innerOperator,
-				$innerOperator,
-			]
-		);
-		// 5^2 = 25 child operators
-		$level2Operator = new Operator(
-			Operator::OPERATION_AND,
-			[
-				$level1Operator,
-				$level1Operator,
-				$level1Operator,
-				$level1Operator,
-				$level1Operator,
-			]
-		);
-		// 5^3 = 125 child operators
-		$level3Operator = new Operator(
-			Operator::OPERATION_AND,
-			[
-				$level2Operator,
-				$level2Operator,
-				$level2Operator,
-				$level2Operator,
-				$level2Operator,
-			]
-		);
-
-		$query = $this->getBasicQuery(Operator::OPERATION_EQUAL, FilesPlugin::OWNER_ID_PROPERTYNAME, $this->user->getUID());
-		$query->where = $level3Operator;
-		$this->expectException(\InvalidArgumentException::class);
-		$this->search->search($query);
-	}
+    private ObjectTree&MockObject $tree;
+    private IUser&MockObject $user;
+    private IRootFolder&MockObject $rootFolder;
+    private IManager&MockObject $shareManager;
+    private View&MockObject $view;
+    private Folder&MockObject $searchFolder;
+    private Directory&MockObject $davFolder;
+    private FileSearchBackend $search;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->user = $this->createMock(IUser::class);
+        $this->user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('test');
+
+        $this->tree = $this->createMock(ObjectTree::class);
+        $this->view = $this->createMock(View::class);
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $this->shareManager = $this->createMock(IManager::class);
+        $this->searchFolder = $this->createMock(Folder::class);
+        $fileInfo = $this->createMock(FileInfo::class);
+        $this->davFolder = $this->createMock(Directory::class);
+
+        $this->view->expects($this->any())
+            ->method('getRoot')
+            ->willReturn('');
+
+        $this->view->expects($this->any())
+            ->method('getRelativePath')
+            ->willReturnArgument(0);
+
+        $this->davFolder->expects($this->any())
+            ->method('getFileInfo')
+            ->willReturn($fileInfo);
+
+        $this->rootFolder->expects($this->any())
+            ->method('get')
+            ->willReturn($this->searchFolder);
+
+        $filesMetadataManager = $this->createMock(IFilesMetadataManager::class);
+
+        $this->search = new FileSearchBackend($this->tree, $this->user, $this->rootFolder, $this->shareManager, $this->view, $filesMetadataManager);
+    }
+
+    public function testSearchFilename(): void {
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->willReturn($this->davFolder);
+
+        $this->searchFolder->expects($this->once())
+            ->method('search')
+            ->with(new SearchQuery(
+                new SearchComparison(
+                    ISearchComparison::COMPARE_EQUAL,
+                    'name',
+                    'foo'
+                ),
+                0,
+                0,
+                [],
+                $this->user
+            ))
+            ->willReturn([
+                new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
+            ]);
+
+        $query = $this->getBasicQuery(Operator::OPERATION_EQUAL, '{DAV:}displayname', 'foo');
+        $result = $this->search->search($query);
+
+        $this->assertCount(1, $result);
+        $this->assertEquals('/files/test/test/path', $result[0]->href);
+    }
+
+    public function testSearchMimetype(): void {
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->willReturn($this->davFolder);
+
+        $this->searchFolder->expects($this->once())
+            ->method('search')
+            ->with(new SearchQuery(
+                new SearchComparison(
+                    ISearchComparison::COMPARE_EQUAL,
+                    'mimetype',
+                    'foo'
+                ),
+                0,
+                0,
+                [],
+                $this->user
+            ))
+            ->willReturn([
+                new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
+            ]);
+
+        $query = $this->getBasicQuery(Operator::OPERATION_EQUAL, '{DAV:}getcontenttype', 'foo');
+        $result = $this->search->search($query);
+
+        $this->assertCount(1, $result);
+        $this->assertEquals('/files/test/test/path', $result[0]->href);
+    }
+
+    public function testSearchSize(): void {
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->willReturn($this->davFolder);
+
+        $this->searchFolder->expects($this->once())
+            ->method('search')
+            ->with(new SearchQuery(
+                new SearchComparison(
+                    ISearchComparison::COMPARE_GREATER_THAN,
+                    'size',
+                    10
+                ),
+                0,
+                0,
+                [],
+                $this->user
+            ))
+            ->willReturn([
+                new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
+            ]);
+
+        $query = $this->getBasicQuery(Operator::OPERATION_GREATER_THAN, FilesPlugin::SIZE_PROPERTYNAME, 10);
+        $result = $this->search->search($query);
+
+        $this->assertCount(1, $result);
+        $this->assertEquals('/files/test/test/path', $result[0]->href);
+    }
+
+    public function testSearchMtime(): void {
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->willReturn($this->davFolder);
+
+        $this->searchFolder->expects($this->once())
+            ->method('search')
+            ->with(new SearchQuery(
+                new SearchComparison(
+                    ISearchComparison::COMPARE_GREATER_THAN,
+                    'mtime',
+                    10
+                ),
+                0,
+                0,
+                [],
+                $this->user
+            ))
+            ->willReturn([
+                new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
+            ]);
+
+        $query = $this->getBasicQuery(Operator::OPERATION_GREATER_THAN, '{DAV:}getlastmodified', 10);
+        $result = $this->search->search($query);
+
+        $this->assertCount(1, $result);
+        $this->assertEquals('/files/test/test/path', $result[0]->href);
+    }
+
+    public function testSearchIsCollection(): void {
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->willReturn($this->davFolder);
+
+        $this->searchFolder->expects($this->once())
+            ->method('search')
+            ->with(new SearchQuery(
+                new SearchComparison(
+                    ISearchComparison::COMPARE_EQUAL,
+                    'mimetype',
+                    FileInfo::MIMETYPE_FOLDER
+                ),
+                0,
+                0,
+                [],
+                $this->user
+            ))
+            ->willReturn([
+                new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
+            ]);
+
+        $query = $this->getBasicQuery(Operator::OPERATION_IS_COLLECTION, 'yes');
+        $result = $this->search->search($query);
+
+        $this->assertCount(1, $result);
+        $this->assertEquals('/files/test/test/path', $result[0]->href);
+    }
+
+
+    public function testSearchInvalidProp(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->willReturn($this->davFolder);
+
+        $this->searchFolder->expects($this->never())
+            ->method('search');
+
+        $query = $this->getBasicQuery(Operator::OPERATION_EQUAL, '{DAV:}getetag', 'foo');
+        $this->search->search($query);
+    }
+
+    private function getBasicQuery(string $type, string $property, int|string|null $value = null) {
+        $scope = new Scope('/', 'infinite');
+        $scope->path = '/';
+        $from = [$scope];
+        $orderBy = [];
+        $select = [];
+        if (is_null($value)) {
+            $where = new Operator(
+                $type,
+                [new Literal($property)]
+            );
+        } else {
+            $where = new Operator(
+                $type,
+                [new SearchPropertyDefinition($property, true, true, true), new Literal($value)]
+            );
+        }
+        $limit = new Limit();
+
+        return new Query($select, $from, $where, $orderBy, $limit);
+    }
+
+
+    public function testSearchNonFolder(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $davNode = $this->createMock(File::class);
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->willReturn($davNode);
+
+        $query = $this->getBasicQuery(Operator::OPERATION_EQUAL, '{DAV:}displayname', 'foo');
+        $this->search->search($query);
+    }
+
+    public function testSearchLimitOwnerBasic(): void {
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->willReturn($this->davFolder);
+
+        /** @var ISearchQuery|null $receivedQuery */
+        $receivedQuery = null;
+        $this->searchFolder
+            ->method('search')
+            ->willReturnCallback(function ($query) use (&$receivedQuery) {
+                $receivedQuery = $query;
+                return [
+                    new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
+                ];
+            });
+
+        $query = $this->getBasicQuery(Operator::OPERATION_EQUAL, FilesPlugin::OWNER_ID_PROPERTYNAME, $this->user->getUID());
+        $this->search->search($query);
+
+        $this->assertNotNull($receivedQuery);
+        $this->assertTrue($receivedQuery->limitToHome());
+
+        /** @var ISearchBinaryOperator $operator */
+        $operator = $receivedQuery->getSearchOperation();
+        $this->assertInstanceOf(ISearchBinaryOperator::class, $operator);
+        $this->assertEquals(ISearchBinaryOperator::OPERATOR_AND, $operator->getType());
+        $this->assertEmpty($operator->getArguments());
+    }
+
+    public function testSearchLimitOwnerNested(): void {
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->willReturn($this->davFolder);
+
+        /** @var ISearchQuery|null $receivedQuery */
+        $receivedQuery = null;
+        $this->searchFolder
+            ->method('search')
+            ->willReturnCallback(function ($query) use (&$receivedQuery) {
+                $receivedQuery = $query;
+                return [
+                    new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
+                ];
+            });
+
+        $query = $this->getBasicQuery(Operator::OPERATION_EQUAL, FilesPlugin::OWNER_ID_PROPERTYNAME, $this->user->getUID());
+        $query->where = new Operator(
+            Operator::OPERATION_AND,
+            [
+                new Operator(
+                    Operator::OPERATION_EQUAL,
+                    [new SearchPropertyDefinition('{DAV:}getcontenttype', true, true, true), new Literal('image/png')]
+                ),
+                new Operator(
+                    Operator::OPERATION_EQUAL,
+                    [new SearchPropertyDefinition(FilesPlugin::OWNER_ID_PROPERTYNAME, true, true, true), new Literal($this->user->getUID())]
+                ),
+            ]
+        );
+        $this->search->search($query);
+
+        $this->assertNotNull($receivedQuery);
+        $this->assertTrue($receivedQuery->limitToHome());
+
+        /** @var ISearchBinaryOperator $operator */
+        $operator = $receivedQuery->getSearchOperation();
+        $this->assertInstanceOf(ISearchBinaryOperator::class, $operator);
+        $this->assertEquals(ISearchBinaryOperator::OPERATOR_AND, $operator->getType());
+        $this->assertCount(2, $operator->getArguments());
+
+        /** @var ISearchBinaryOperator $operator */
+        $operator = $operator->getArguments()[1];
+        $this->assertInstanceOf(ISearchBinaryOperator::class, $operator);
+        $this->assertEquals(ISearchBinaryOperator::OPERATOR_AND, $operator->getType());
+        $this->assertEmpty($operator->getArguments());
+    }
+
+    public function testSearchOperatorLimit(): void {
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->willReturn($this->davFolder);
+
+        $innerOperator = new Operator(
+            Operator::OPERATION_EQUAL,
+            [new SearchPropertyDefinition('{DAV:}getcontenttype', true, true, true), new Literal('image/png')]
+        );
+        // 5 child operators
+        $level1Operator = new Operator(
+            Operator::OPERATION_AND,
+            [
+                $innerOperator,
+                $innerOperator,
+                $innerOperator,
+                $innerOperator,
+                $innerOperator,
+            ]
+        );
+        // 5^2 = 25 child operators
+        $level2Operator = new Operator(
+            Operator::OPERATION_AND,
+            [
+                $level1Operator,
+                $level1Operator,
+                $level1Operator,
+                $level1Operator,
+                $level1Operator,
+            ]
+        );
+        // 5^3 = 125 child operators
+        $level3Operator = new Operator(
+            Operator::OPERATION_AND,
+            [
+                $level2Operator,
+                $level2Operator,
+                $level2Operator,
+                $level2Operator,
+                $level2Operator,
+            ]
+        );
+
+        $query = $this->getBasicQuery(Operator::OPERATION_EQUAL, FilesPlugin::OWNER_ID_PROPERTYNAME, $this->user->getUID());
+        $query->where = $level3Operator;
+        $this->expectException(\InvalidArgumentException::class);
+        $this->search->search($query);
+    }
 }

Spacing +3 added lines, -3 removed lines

@@ -241,7 +241,7 @@ 
 		$this->search->search($query);
 	}
 
-	private function getBasicQuery(string $type, string $property, int|string|null $value = null) {
+	private function getBasicQuery(string $type, string $property, int | string | null $value = null) {
 		$scope = new Scope('/', 'infinite');
 		$scope->path = '/';
 		$from = [$scope];
@@ -286,7 +286,7 @@ 
 		$receivedQuery = null;
 		$this->searchFolder
 			->method('search')
-			->willReturnCallback(function ($query) use (&$receivedQuery) {
+			->willReturnCallback(function($query) use (&$receivedQuery) {
 				$receivedQuery = $query;
 				return [
 					new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),
@@ -315,7 +315,7 @@ 
 		$receivedQuery = null;
 		$this->searchFolder
 			->method('search')
-			->willReturnCallback(function ($query) use (&$receivedQuery) {
+			->willReturnCallback(function($query) use (&$receivedQuery) {
 				$receivedQuery = $query;
 				return [
 					new \OC\Files\Node\Folder($this->rootFolder, $this->view, '/test/path'),