nextcloud / server

apps/dav/tests/unit/Connector/Sabre/FilesPluginTest.php

Indentation +679 added lines, -679 removed lines

@@ -40,683 +40,683 @@
  */
 class FilesPluginTest extends TestCase {
 
-	private Tree&MockObject $tree;
-	private Server&MockObject $server;
-	private IConfig&MockObject $config;
-	private IRequest&MockObject $request;
-	private IPreview&MockObject $previewManager;
-	private IUserSession&MockObject $userSession;
-	private IFilenameValidator&MockObject $filenameValidator;
-	private IAccountManager&MockObject $accountManager;
-	private FilesPlugin $plugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->server = $this->createMock(Server::class);
-		$this->tree = $this->createMock(Tree::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->config->expects($this->any())->method('getSystemValue')
-			->with($this->equalTo('data-fingerprint'), $this->equalTo(''))
-			->willReturn('my_fingerprint');
-		$this->request = $this->createMock(IRequest::class);
-		$this->previewManager = $this->createMock(IPreview::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->filenameValidator = $this->createMock(IFilenameValidator::class);
-		$this->accountManager = $this->createMock(IAccountManager::class);
-
-		$this->plugin = new FilesPlugin(
-			$this->tree,
-			$this->config,
-			$this->request,
-			$this->previewManager,
-			$this->userSession,
-			$this->filenameValidator,
-			$this->accountManager,
-		);
-
-		$response = $this->createMock(ResponseInterface::class);
-		$this->server->httpResponse = $response;
-		$this->server->xml = new Service();
-
-		$this->plugin->initialize($this->server);
-	}
-
-	private function createTestNode(string $class, string $path = '/dummypath'): MockObject {
-		$node = $this->createMock($class);
-
-		$node->expects($this->any())
-			->method('getId')
-			->willReturn(123);
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with($path)
-			->willReturn($node);
-
-		$node->expects($this->any())
-			->method('getFileId')
-			->willReturn('00000123instanceid');
-		$node->expects($this->any())
-			->method('getInternalFileId')
-			->willReturn('123');
-		$node->expects($this->any())
-			->method('getEtag')
-			->willReturn('"abc"');
-		$node->expects($this->any())
-			->method('getDavPermissions')
-			->willReturn('DWCKMSR');
-
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->expects($this->any())
-			->method('isReadable')
-			->willReturn(true);
-		$fileInfo->expects($this->any())
-			->method('getCreationTime')
-			->willReturn(123456789);
-
-		$node->expects($this->any())
-			->method('getFileInfo')
-			->willReturn($fileInfo);
-
-		return $node;
-	}
-
-	public function testGetPropertiesForFile(): void {
-		/** @var File&MockObject $node */
-		$node = $this->createTestNode(File::class);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::GETETAG_PROPERTYNAME,
-				FilesPlugin::FILEID_PROPERTYNAME,
-				FilesPlugin::INTERNAL_FILEID_PROPERTYNAME,
-				FilesPlugin::SIZE_PROPERTYNAME,
-				FilesPlugin::PERMISSIONS_PROPERTYNAME,
-				FilesPlugin::DOWNLOADURL_PROPERTYNAME,
-				FilesPlugin::OWNER_ID_PROPERTYNAME,
-				FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-				FilesPlugin::CREATIONDATE_PROPERTYNAME,
-			],
-			0
-		);
-
-		$user = $this->createMock(User::class);
-		$user
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('foo');
-		$user
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('M. Foo');
-
-		$owner = $this->createMock(Account::class);
-		$this->accountManager->expects($this->once())
-			->method('getAccount')
-			->with($user)
-			->willReturn($owner);
-
-		$node->expects($this->once())
-			->method('getDirectDownload')
-			->willReturn(['url' => 'http://example.com/']);
-		$node->expects($this->exactly(2))
-			->method('getOwner')
-			->willReturn($user);
-
-		$displayNameProp = $this->createMock(AccountProperty::class);
-		$owner
-			->expects($this->once())
-			->method('getProperty')
-			->with(IAccountManager::PROPERTY_DISPLAYNAME)
-			->willReturn($displayNameProp);
-		$displayNameProp
-			->expects($this->once())
-			->method('getScope')
-			->willReturn(IAccountManager::SCOPE_PUBLISHED);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
-		$this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
-		$this->assertEquals('123', $propFind->get(FilesPlugin::INTERNAL_FILEID_PROPERTYNAME));
-		$this->assertEquals('1973-11-29T21:33:09+00:00', $propFind->get(FilesPlugin::CREATIONDATE_PROPERTYNAME));
-		$this->assertEquals(0, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
-		$this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
-		$this->assertEquals('http://example.com/', $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
-		$this->assertEquals('foo', $propFind->get(FilesPlugin::OWNER_ID_PROPERTYNAME));
-		$this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
-		$this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
-		$this->assertEquals([], $propFind->get404Properties());
-	}
-
-	public function testGetDisplayNamePropertyWhenNotPublished(): void {
-		$node = $this->createTestNode(File::class);
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
-			],
-			0
-		);
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn(null);
-
-		$user = $this->createMock(User::class);
-
-		$user->expects($this->never())
-			->method('getDisplayName');
-
-		$owner = $this->createMock(Account::class);
-		$this->accountManager->expects($this->once())
-			->method('getAccount')
-			->with($user)
-			->willReturn($owner);
-
-		$node->expects($this->once())
-			->method('getOwner')
-			->willReturn($user);
-
-		$displayNameProp = $this->createMock(AccountProperty::class);
-		$owner
-			->expects($this->once())
-			->method('getProperty')
-			->with(IAccountManager::PROPERTY_DISPLAYNAME)
-			->willReturn($displayNameProp);
-		$displayNameProp
-			->expects($this->once())
-			->method('getScope')
-			->willReturn(IAccountManager::SCOPE_PRIVATE);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals(null, $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
-	}
-
-	public function testGetDisplayNamePropertyWhenNotPublishedButLoggedIn(): void {
-		$node = $this->createTestNode(File::class);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
-			],
-			0
-		);
-
-		$user = $this->createMock(User::class);
-
-		$node->expects($this->once())
-			->method('getOwner')
-			->willReturn($user);
-
-		$loggedInUser = $this->createMock(User::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($loggedInUser);
-
-		$user
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('M. Foo');
-
-		$this->accountManager->expects($this->never())
-			->method('getAccount');
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
-	}
-
-	public function testGetPropertiesStorageNotAvailable(): void {
-		/** @var File&MockObject $node */
-		$node = $this->createTestNode(File::class);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::DOWNLOADURL_PROPERTYNAME,
-			],
-			0
-		);
-
-		$node->expects($this->once())
-			->method('getDirectDownload')
-			->will($this->throwException(new StorageNotAvailableException()));
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
-	}
-
-	public function testGetPublicPermissions(): void {
-		/** @var IRequest&MockObject */
-		$request = $this->createMock(IRequest::class);
-		$this->plugin = new FilesPlugin(
-			$this->tree,
-			$this->config,
-			$request,
-			$this->previewManager,
-			$this->userSession,
-			$this->filenameValidator,
-			$this->accountManager,
-			true,
-		);
-		$this->plugin->initialize($this->server);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::PERMISSIONS_PROPERTYNAME,
-			],
-			0
-		);
-
-		/** @var File&MockObject $node */
-		$node = $this->createTestNode(File::class);
-		$node->expects($this->any())
-			->method('getDavPermissions')
-			->willReturn('DWCKMSR');
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('DWCKR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
-	}
-
-	public function testGetPropertiesForDirectory(): void {
-		/** @var Directory&MockObject $node */
-		$node = $this->createTestNode(Directory::class);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::GETETAG_PROPERTYNAME,
-				FilesPlugin::FILEID_PROPERTYNAME,
-				FilesPlugin::SIZE_PROPERTYNAME,
-				FilesPlugin::PERMISSIONS_PROPERTYNAME,
-				FilesPlugin::DOWNLOADURL_PROPERTYNAME,
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-			],
-			0
-		);
-
-		$node->expects($this->once())
-			->method('getSize')
-			->willReturn(1025);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
-		$this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
-		$this->assertEquals(1025, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
-		$this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
-		$this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
-		$this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
-		$this->assertEquals([FilesPlugin::DOWNLOADURL_PROPERTYNAME], $propFind->get404Properties());
-	}
-
-	public function testGetPropertiesForRootDirectory(): void {
-		/** @var Directory&MockObject $node */
-		$node = $this->createMock(Directory::class);
-		$node->expects($this->any())->method('getPath')->willReturn('/');
-
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->expects($this->any())
-			->method('isReadable')
-			->willReturn(true);
-
-		$node->expects($this->any())
-			->method('getFileInfo')
-			->willReturn($fileInfo);
-
-		$propFind = new PropFind(
-			'/',
-			[
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-			],
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
-	}
-
-	public function testGetPropertiesWhenNoPermission(): void {
-		// No read permissions can be caused by files access control.
-		// But we still want to load the directory list, so this is okay for us.
-		// $this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		/** @var Directory&MockObject $node */
-		$node = $this->createMock(Directory::class);
-		$node->expects($this->any())->method('getPath')->willReturn('/');
-
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->expects($this->any())
-			->method('isReadable')
-			->willReturn(false);
-
-		$node->expects($this->any())
-			->method('getFileInfo')
-			->willReturn($fileInfo);
-
-		$propFind = new PropFind(
-			'/test',
-			[
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-			],
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->addToAssertionCount(1);
-	}
-
-	public function testUpdateProps(): void {
-		$node = $this->createTestNode(File::class);
-
-		$testDate = 'Fri, 13 Feb 2015 00:01:02 GMT';
-		$testCreationDate = '2007-08-31T16:47+00:00';
-
-		$node->expects($this->once())
-			->method('touch')
-			->with($testDate);
-
-		$node->expects($this->once())
-			->method('setEtag')
-			->with('newetag')
-			->willReturn(true);
-
-		$node->expects($this->once())
-			->method('setCreationTime')
-			->with('1188578820');
-
-		// properties to set
-		$propPatch = new PropPatch([
-			FilesPlugin::GETETAG_PROPERTYNAME => 'newetag',
-			FilesPlugin::LASTMODIFIED_PROPERTYNAME => $testDate,
-			FilesPlugin::CREATIONDATE_PROPERTYNAME => $testCreationDate,
-		]);
-
-
-		$this->plugin->handleUpdateProperties(
-			'/dummypath',
-			$propPatch
-		);
-
-		$propPatch->commit();
-
-		$this->assertEmpty($propPatch->getRemainingMutations());
-
-		$result = $propPatch->getResult();
-		$this->assertEquals(200, $result[FilesPlugin::LASTMODIFIED_PROPERTYNAME]);
-		$this->assertEquals(200, $result[FilesPlugin::GETETAG_PROPERTYNAME]);
-		$this->assertEquals(200, $result[FilesPlugin::CREATIONDATE_PROPERTYNAME]);
-	}
-
-	public function testUpdatePropsForbidden(): void {
-		$propPatch = new PropPatch([
-			FilesPlugin::OWNER_ID_PROPERTYNAME => 'user2',
-			FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME => 'User Two',
-			FilesPlugin::FILEID_PROPERTYNAME => 12345,
-			FilesPlugin::PERMISSIONS_PROPERTYNAME => 'C',
-			FilesPlugin::SIZE_PROPERTYNAME => 123,
-			FilesPlugin::DOWNLOADURL_PROPERTYNAME => 'http://example.com/',
-		]);
-
-		$this->plugin->handleUpdateProperties(
-			'/dummypath',
-			$propPatch
-		);
-
-		$propPatch->commit();
-
-		$this->assertEmpty($propPatch->getRemainingMutations());
-
-		$result = $propPatch->getResult();
-		$this->assertEquals(403, $result[FilesPlugin::OWNER_ID_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::FILEID_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::PERMISSIONS_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::SIZE_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::DOWNLOADURL_PROPERTYNAME]);
-	}
-
-	/**
-	 * Test case from https://github.com/owncloud/core/issues/5251
-	 *
-	 * |-FolderA
-	 *  |-text.txt
-	 * |-test.txt
-	 *
-	 * FolderA is an incoming shared folder and there are no delete permissions.
-	 * Thus moving /FolderA/test.txt to /test.txt should fail already on that check
-	 *
-	 */
-	public function testMoveSrcNotDeletable(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$this->expectExceptionMessage('FolderA/test.txt cannot be deleted');
-
-		$fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
-		$fileInfoFolderATestTXT->expects($this->once())
-			->method('isDeletable')
-			->willReturn(false);
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkMove('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testMoveSrcDeletable(): void {
-		$fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
-		$fileInfoFolderATestTXT->expects($this->once())
-			->method('isDeletable')
-			->willReturn(true);
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkMove('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testMoveSrcNotExist(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		$this->expectExceptionMessage('FolderA/test.txt does not exist');
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn(null);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkMove('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testMoveDestinationInvalid(): void {
-		$this->expectException(InvalidPath::class);
-		$this->expectExceptionMessage('Mocked exception');
-
-		$fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
-		$fileInfoFolderATestTXT->expects(self::any())
-			->method('isDeletable')
-			->willReturn(true);
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->filenameValidator->expects(self::once())
-			->method('validateFilename')
-			->with('invalid\\path.txt')
-			->willThrowException(new InvalidPathException('Mocked exception'));
-
-		$this->plugin->checkMove('FolderA/test.txt', 'invalid\\path.txt');
-	}
-
-	public function testCopySrcNotExist(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		$this->expectExceptionMessage('FolderA/test.txt does not exist');
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn(null);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkCopy('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testCopyDestinationInvalid(): void {
-		$this->expectException(InvalidPath::class);
-		$this->expectExceptionMessage('Mocked exception');
-
-		$fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->filenameValidator->expects(self::once())
-			->method('validateFilename')
-			->with('invalid\\path.txt')
-			->willThrowException(new InvalidPathException('Mocked exception'));
-
-		$this->plugin->checkCopy('FolderA/test.txt', 'invalid\\path.txt');
-	}
-
-	public static function downloadHeadersProvider(): array {
-		return [
-			[
-				false,
-				'attachment; filename*=UTF-8\'\'somefile.xml; filename="somefile.xml"'
-			],
-			[
-				true,
-				'attachment; filename="somefile.xml"'
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider downloadHeadersProvider
-	 */
-	public function testDownloadHeaders(bool $isClumsyAgent, string $contentDispositionHeader): void {
-		$request = $this->createMock(RequestInterface::class);
-		$response = $this->createMock(ResponseInterface::class);
-
-		$request
-			->expects($this->once())
-			->method('getPath')
-			->willReturn('test/somefile.xml');
-
-		$node = $this->createMock(File::class);
-		$node
-			->expects($this->once())
-			->method('getName')
-			->willReturn('somefile.xml');
-
-		$this->tree
-			->expects($this->once())
-			->method('getNodeForPath')
-			->with('test/somefile.xml')
-			->willReturn($node);
-
-		$this->request
-			->expects($this->once())
-			->method('isUserAgent')
-			->willReturn($isClumsyAgent);
-
-		$calls = [
-			['Content-Disposition', $contentDispositionHeader],
-			['X-Accel-Buffering', 'no'],
-		];
-		$response
-			->expects($this->exactly(count($calls)))
-			->method('addHeader')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertSame($expected, func_get_args());
-			});
-
-		$this->plugin->httpGet($request, $response);
-	}
-
-	public function testHasPreview(): void {
-		/** @var Directory&MockObject $node */
-		$node = $this->createTestNode(Directory::class);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::HAS_PREVIEW_PROPERTYNAME
-			],
-			0
-		);
-
-		$this->previewManager->expects($this->once())
-			->method('isAvailable')
-			->willReturn(false);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('false', $propFind->get(FilesPlugin::HAS_PREVIEW_PROPERTYNAME));
-	}
+    private Tree&MockObject $tree;
+    private Server&MockObject $server;
+    private IConfig&MockObject $config;
+    private IRequest&MockObject $request;
+    private IPreview&MockObject $previewManager;
+    private IUserSession&MockObject $userSession;
+    private IFilenameValidator&MockObject $filenameValidator;
+    private IAccountManager&MockObject $accountManager;
+    private FilesPlugin $plugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->server = $this->createMock(Server::class);
+        $this->tree = $this->createMock(Tree::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->config->expects($this->any())->method('getSystemValue')
+            ->with($this->equalTo('data-fingerprint'), $this->equalTo(''))
+            ->willReturn('my_fingerprint');
+        $this->request = $this->createMock(IRequest::class);
+        $this->previewManager = $this->createMock(IPreview::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->filenameValidator = $this->createMock(IFilenameValidator::class);
+        $this->accountManager = $this->createMock(IAccountManager::class);
+
+        $this->plugin = new FilesPlugin(
+            $this->tree,
+            $this->config,
+            $this->request,
+            $this->previewManager,
+            $this->userSession,
+            $this->filenameValidator,
+            $this->accountManager,
+        );
+
+        $response = $this->createMock(ResponseInterface::class);
+        $this->server->httpResponse = $response;
+        $this->server->xml = new Service();
+
+        $this->plugin->initialize($this->server);
+    }
+
+    private function createTestNode(string $class, string $path = '/dummypath'): MockObject {
+        $node = $this->createMock($class);
+
+        $node->expects($this->any())
+            ->method('getId')
+            ->willReturn(123);
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with($path)
+            ->willReturn($node);
+
+        $node->expects($this->any())
+            ->method('getFileId')
+            ->willReturn('00000123instanceid');
+        $node->expects($this->any())
+            ->method('getInternalFileId')
+            ->willReturn('123');
+        $node->expects($this->any())
+            ->method('getEtag')
+            ->willReturn('"abc"');
+        $node->expects($this->any())
+            ->method('getDavPermissions')
+            ->willReturn('DWCKMSR');
+
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->expects($this->any())
+            ->method('isReadable')
+            ->willReturn(true);
+        $fileInfo->expects($this->any())
+            ->method('getCreationTime')
+            ->willReturn(123456789);
+
+        $node->expects($this->any())
+            ->method('getFileInfo')
+            ->willReturn($fileInfo);
+
+        return $node;
+    }
+
+    public function testGetPropertiesForFile(): void {
+        /** @var File&MockObject $node */
+        $node = $this->createTestNode(File::class);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::GETETAG_PROPERTYNAME,
+                FilesPlugin::FILEID_PROPERTYNAME,
+                FilesPlugin::INTERNAL_FILEID_PROPERTYNAME,
+                FilesPlugin::SIZE_PROPERTYNAME,
+                FilesPlugin::PERMISSIONS_PROPERTYNAME,
+                FilesPlugin::DOWNLOADURL_PROPERTYNAME,
+                FilesPlugin::OWNER_ID_PROPERTYNAME,
+                FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+                FilesPlugin::CREATIONDATE_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $user = $this->createMock(User::class);
+        $user
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('foo');
+        $user
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('M. Foo');
+
+        $owner = $this->createMock(Account::class);
+        $this->accountManager->expects($this->once())
+            ->method('getAccount')
+            ->with($user)
+            ->willReturn($owner);
+
+        $node->expects($this->once())
+            ->method('getDirectDownload')
+            ->willReturn(['url' => 'http://example.com/']);
+        $node->expects($this->exactly(2))
+            ->method('getOwner')
+            ->willReturn($user);
+
+        $displayNameProp = $this->createMock(AccountProperty::class);
+        $owner
+            ->expects($this->once())
+            ->method('getProperty')
+            ->with(IAccountManager::PROPERTY_DISPLAYNAME)
+            ->willReturn($displayNameProp);
+        $displayNameProp
+            ->expects($this->once())
+            ->method('getScope')
+            ->willReturn(IAccountManager::SCOPE_PUBLISHED);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
+        $this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
+        $this->assertEquals('123', $propFind->get(FilesPlugin::INTERNAL_FILEID_PROPERTYNAME));
+        $this->assertEquals('1973-11-29T21:33:09+00:00', $propFind->get(FilesPlugin::CREATIONDATE_PROPERTYNAME));
+        $this->assertEquals(0, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
+        $this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
+        $this->assertEquals('http://example.com/', $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
+        $this->assertEquals('foo', $propFind->get(FilesPlugin::OWNER_ID_PROPERTYNAME));
+        $this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
+        $this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
+        $this->assertEquals([], $propFind->get404Properties());
+    }
+
+    public function testGetDisplayNamePropertyWhenNotPublished(): void {
+        $node = $this->createTestNode(File::class);
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn(null);
+
+        $user = $this->createMock(User::class);
+
+        $user->expects($this->never())
+            ->method('getDisplayName');
+
+        $owner = $this->createMock(Account::class);
+        $this->accountManager->expects($this->once())
+            ->method('getAccount')
+            ->with($user)
+            ->willReturn($owner);
+
+        $node->expects($this->once())
+            ->method('getOwner')
+            ->willReturn($user);
+
+        $displayNameProp = $this->createMock(AccountProperty::class);
+        $owner
+            ->expects($this->once())
+            ->method('getProperty')
+            ->with(IAccountManager::PROPERTY_DISPLAYNAME)
+            ->willReturn($displayNameProp);
+        $displayNameProp
+            ->expects($this->once())
+            ->method('getScope')
+            ->willReturn(IAccountManager::SCOPE_PRIVATE);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals(null, $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
+    }
+
+    public function testGetDisplayNamePropertyWhenNotPublishedButLoggedIn(): void {
+        $node = $this->createTestNode(File::class);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $user = $this->createMock(User::class);
+
+        $node->expects($this->once())
+            ->method('getOwner')
+            ->willReturn($user);
+
+        $loggedInUser = $this->createMock(User::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($loggedInUser);
+
+        $user
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('M. Foo');
+
+        $this->accountManager->expects($this->never())
+            ->method('getAccount');
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
+    }
+
+    public function testGetPropertiesStorageNotAvailable(): void {
+        /** @var File&MockObject $node */
+        $node = $this->createTestNode(File::class);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::DOWNLOADURL_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $node->expects($this->once())
+            ->method('getDirectDownload')
+            ->will($this->throwException(new StorageNotAvailableException()));
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
+    }
+
+    public function testGetPublicPermissions(): void {
+        /** @var IRequest&MockObject */
+        $request = $this->createMock(IRequest::class);
+        $this->plugin = new FilesPlugin(
+            $this->tree,
+            $this->config,
+            $request,
+            $this->previewManager,
+            $this->userSession,
+            $this->filenameValidator,
+            $this->accountManager,
+            true,
+        );
+        $this->plugin->initialize($this->server);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::PERMISSIONS_PROPERTYNAME,
+            ],
+            0
+        );
+
+        /** @var File&MockObject $node */
+        $node = $this->createTestNode(File::class);
+        $node->expects($this->any())
+            ->method('getDavPermissions')
+            ->willReturn('DWCKMSR');
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('DWCKR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
+    }
+
+    public function testGetPropertiesForDirectory(): void {
+        /** @var Directory&MockObject $node */
+        $node = $this->createTestNode(Directory::class);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::GETETAG_PROPERTYNAME,
+                FilesPlugin::FILEID_PROPERTYNAME,
+                FilesPlugin::SIZE_PROPERTYNAME,
+                FilesPlugin::PERMISSIONS_PROPERTYNAME,
+                FilesPlugin::DOWNLOADURL_PROPERTYNAME,
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $node->expects($this->once())
+            ->method('getSize')
+            ->willReturn(1025);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
+        $this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
+        $this->assertEquals(1025, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
+        $this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
+        $this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
+        $this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
+        $this->assertEquals([FilesPlugin::DOWNLOADURL_PROPERTYNAME], $propFind->get404Properties());
+    }
+
+    public function testGetPropertiesForRootDirectory(): void {
+        /** @var Directory&MockObject $node */
+        $node = $this->createMock(Directory::class);
+        $node->expects($this->any())->method('getPath')->willReturn('/');
+
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->expects($this->any())
+            ->method('isReadable')
+            ->willReturn(true);
+
+        $node->expects($this->any())
+            ->method('getFileInfo')
+            ->willReturn($fileInfo);
+
+        $propFind = new PropFind(
+            '/',
+            [
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
+    }
+
+    public function testGetPropertiesWhenNoPermission(): void {
+        // No read permissions can be caused by files access control.
+        // But we still want to load the directory list, so this is okay for us.
+        // $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        /** @var Directory&MockObject $node */
+        $node = $this->createMock(Directory::class);
+        $node->expects($this->any())->method('getPath')->willReturn('/');
+
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->expects($this->any())
+            ->method('isReadable')
+            ->willReturn(false);
+
+        $node->expects($this->any())
+            ->method('getFileInfo')
+            ->willReturn($fileInfo);
+
+        $propFind = new PropFind(
+            '/test',
+            [
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->addToAssertionCount(1);
+    }
+
+    public function testUpdateProps(): void {
+        $node = $this->createTestNode(File::class);
+
+        $testDate = 'Fri, 13 Feb 2015 00:01:02 GMT';
+        $testCreationDate = '2007-08-31T16:47+00:00';
+
+        $node->expects($this->once())
+            ->method('touch')
+            ->with($testDate);
+
+        $node->expects($this->once())
+            ->method('setEtag')
+            ->with('newetag')
+            ->willReturn(true);
+
+        $node->expects($this->once())
+            ->method('setCreationTime')
+            ->with('1188578820');
+
+        // properties to set
+        $propPatch = new PropPatch([
+            FilesPlugin::GETETAG_PROPERTYNAME => 'newetag',
+            FilesPlugin::LASTMODIFIED_PROPERTYNAME => $testDate,
+            FilesPlugin::CREATIONDATE_PROPERTYNAME => $testCreationDate,
+        ]);
+
+
+        $this->plugin->handleUpdateProperties(
+            '/dummypath',
+            $propPatch
+        );
+
+        $propPatch->commit();
+
+        $this->assertEmpty($propPatch->getRemainingMutations());
+
+        $result = $propPatch->getResult();
+        $this->assertEquals(200, $result[FilesPlugin::LASTMODIFIED_PROPERTYNAME]);
+        $this->assertEquals(200, $result[FilesPlugin::GETETAG_PROPERTYNAME]);
+        $this->assertEquals(200, $result[FilesPlugin::CREATIONDATE_PROPERTYNAME]);
+    }
+
+    public function testUpdatePropsForbidden(): void {
+        $propPatch = new PropPatch([
+            FilesPlugin::OWNER_ID_PROPERTYNAME => 'user2',
+            FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME => 'User Two',
+            FilesPlugin::FILEID_PROPERTYNAME => 12345,
+            FilesPlugin::PERMISSIONS_PROPERTYNAME => 'C',
+            FilesPlugin::SIZE_PROPERTYNAME => 123,
+            FilesPlugin::DOWNLOADURL_PROPERTYNAME => 'http://example.com/',
+        ]);
+
+        $this->plugin->handleUpdateProperties(
+            '/dummypath',
+            $propPatch
+        );
+
+        $propPatch->commit();
+
+        $this->assertEmpty($propPatch->getRemainingMutations());
+
+        $result = $propPatch->getResult();
+        $this->assertEquals(403, $result[FilesPlugin::OWNER_ID_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::FILEID_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::PERMISSIONS_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::SIZE_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::DOWNLOADURL_PROPERTYNAME]);
+    }
+
+    /**
+     * Test case from https://github.com/owncloud/core/issues/5251
+     *
+     * |-FolderA
+     *  |-text.txt
+     * |-test.txt
+     *
+     * FolderA is an incoming shared folder and there are no delete permissions.
+     * Thus moving /FolderA/test.txt to /test.txt should fail already on that check
+     *
+     */
+    public function testMoveSrcNotDeletable(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $this->expectExceptionMessage('FolderA/test.txt cannot be deleted');
+
+        $fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
+        $fileInfoFolderATestTXT->expects($this->once())
+            ->method('isDeletable')
+            ->willReturn(false);
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkMove('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testMoveSrcDeletable(): void {
+        $fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
+        $fileInfoFolderATestTXT->expects($this->once())
+            ->method('isDeletable')
+            ->willReturn(true);
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkMove('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testMoveSrcNotExist(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        $this->expectExceptionMessage('FolderA/test.txt does not exist');
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn(null);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkMove('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testMoveDestinationInvalid(): void {
+        $this->expectException(InvalidPath::class);
+        $this->expectExceptionMessage('Mocked exception');
+
+        $fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
+        $fileInfoFolderATestTXT->expects(self::any())
+            ->method('isDeletable')
+            ->willReturn(true);
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->filenameValidator->expects(self::once())
+            ->method('validateFilename')
+            ->with('invalid\\path.txt')
+            ->willThrowException(new InvalidPathException('Mocked exception'));
+
+        $this->plugin->checkMove('FolderA/test.txt', 'invalid\\path.txt');
+    }
+
+    public function testCopySrcNotExist(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        $this->expectExceptionMessage('FolderA/test.txt does not exist');
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn(null);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkCopy('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testCopyDestinationInvalid(): void {
+        $this->expectException(InvalidPath::class);
+        $this->expectExceptionMessage('Mocked exception');
+
+        $fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->filenameValidator->expects(self::once())
+            ->method('validateFilename')
+            ->with('invalid\\path.txt')
+            ->willThrowException(new InvalidPathException('Mocked exception'));
+
+        $this->plugin->checkCopy('FolderA/test.txt', 'invalid\\path.txt');
+    }
+
+    public static function downloadHeadersProvider(): array {
+        return [
+            [
+                false,
+                'attachment; filename*=UTF-8\'\'somefile.xml; filename="somefile.xml"'
+            ],
+            [
+                true,
+                'attachment; filename="somefile.xml"'
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider downloadHeadersProvider
+     */
+    public function testDownloadHeaders(bool $isClumsyAgent, string $contentDispositionHeader): void {
+        $request = $this->createMock(RequestInterface::class);
+        $response = $this->createMock(ResponseInterface::class);
+
+        $request
+            ->expects($this->once())
+            ->method('getPath')
+            ->willReturn('test/somefile.xml');
+
+        $node = $this->createMock(File::class);
+        $node
+            ->expects($this->once())
+            ->method('getName')
+            ->willReturn('somefile.xml');
+
+        $this->tree
+            ->expects($this->once())
+            ->method('getNodeForPath')
+            ->with('test/somefile.xml')
+            ->willReturn($node);
+
+        $this->request
+            ->expects($this->once())
+            ->method('isUserAgent')
+            ->willReturn($isClumsyAgent);
+
+        $calls = [
+            ['Content-Disposition', $contentDispositionHeader],
+            ['X-Accel-Buffering', 'no'],
+        ];
+        $response
+            ->expects($this->exactly(count($calls)))
+            ->method('addHeader')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertSame($expected, func_get_args());
+            });
+
+        $this->plugin->httpGet($request, $response);
+    }
+
+    public function testHasPreview(): void {
+        /** @var Directory&MockObject $node */
+        $node = $this->createTestNode(Directory::class);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::HAS_PREVIEW_PROPERTYNAME
+            ],
+            0
+        );
+
+        $this->previewManager->expects($this->once())
+            ->method('isAvailable')
+            ->willReturn(false);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('false', $propFind->get(FilesPlugin::HAS_PREVIEW_PROPERTYNAME));
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -688,7 +688,7 @@
 		$response
 			->expects($this->exactly(count($calls)))
 			->method('addHeader')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertSame($expected, func_get_args());
 			});

apps/dav/tests/unit/Connector/Sabre/PropfindCompressionPluginTest.php

Indentation +61 added lines, -61 removed lines

@@ -14,85 +14,85 @@
 use Test\TestCase;
 
 class PropfindCompressionPluginTest extends TestCase {
-	private PropfindCompressionPlugin $plugin;
+    private PropfindCompressionPlugin $plugin;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->plugin = new PropfindCompressionPlugin();
-	}
+        $this->plugin = new PropfindCompressionPlugin();
+    }
 
-	public function testNoHeader(): void {
-		$request = $this->createMock(Request::class);
-		$response = $this->createMock(Response::class);
+    public function testNoHeader(): void {
+        $request = $this->createMock(Request::class);
+        $response = $this->createMock(Response::class);
 
-		$request->method('getHeader')
-			->with('Accept-Encoding')
-			->willReturn(null);
+        $request->method('getHeader')
+            ->with('Accept-Encoding')
+            ->willReturn(null);
 
-		$response->expects($this->never())
-			->method($this->anything());
+        $response->expects($this->never())
+            ->method($this->anything());
 
-		$result = $this->plugin->compressResponse($request, $response);
-		$this->assertSame($response, $result);
-	}
+        $result = $this->plugin->compressResponse($request, $response);
+        $this->assertSame($response, $result);
+    }
 
-	public function testHeaderButNoGzip(): void {
-		$request = $this->createMock(Request::class);
-		$response = $this->createMock(Response::class);
+    public function testHeaderButNoGzip(): void {
+        $request = $this->createMock(Request::class);
+        $response = $this->createMock(Response::class);
 
-		$request->method('getHeader')
-			->with('Accept-Encoding')
-			->willReturn('deflate');
+        $request->method('getHeader')
+            ->with('Accept-Encoding')
+            ->willReturn('deflate');
 
-		$response->expects($this->never())
-			->method($this->anything());
+        $response->expects($this->never())
+            ->method($this->anything());
 
-		$result = $this->plugin->compressResponse($request, $response);
-		$this->assertSame($response, $result);
-	}
+        $result = $this->plugin->compressResponse($request, $response);
+        $this->assertSame($response, $result);
+    }
 
-	public function testHeaderGzipButNoStringBody(): void {
-		$request = $this->createMock(Request::class);
-		$response = $this->createMock(Response::class);
+    public function testHeaderGzipButNoStringBody(): void {
+        $request = $this->createMock(Request::class);
+        $response = $this->createMock(Response::class);
 
-		$request->method('getHeader')
-			->with('Accept-Encoding')
-			->willReturn('deflate');
+        $request->method('getHeader')
+            ->with('Accept-Encoding')
+            ->willReturn('deflate');
 
-		$response->method('getBody')
-			->willReturn(5);
+        $response->method('getBody')
+            ->willReturn(5);
 
-		$result = $this->plugin->compressResponse($request, $response);
-		$this->assertSame($response, $result);
-	}
+        $result = $this->plugin->compressResponse($request, $response);
+        $this->assertSame($response, $result);
+    }
 
 
-	public function testProperGzip(): void {
-		$request = $this->createMock(Request::class);
-		$response = $this->createMock(Response::class);
+    public function testProperGzip(): void {
+        $request = $this->createMock(Request::class);
+        $response = $this->createMock(Response::class);
 
-		$request->method('getHeader')
-			->with('Accept-Encoding')
-			->willReturn('gzip, deflate');
+        $request->method('getHeader')
+            ->with('Accept-Encoding')
+            ->willReturn('gzip, deflate');
 
-		$response->method('getBody')
-			->willReturn('my gzip test');
+        $response->method('getBody')
+            ->willReturn('my gzip test');
 
-		$response->expects($this->once())
-			->method('setHeader')
-			->with(
-				$this->equalTo('Content-Encoding'),
-				$this->equalTo('gzip')
-			);
-		$response->expects($this->once())
-			->method('setBody')
-			->with($this->callback(function ($data) {
-				$orig = gzdecode($data);
-				return $orig === 'my gzip test';
-			}));
+        $response->expects($this->once())
+            ->method('setHeader')
+            ->with(
+                $this->equalTo('Content-Encoding'),
+                $this->equalTo('gzip')
+            );
+        $response->expects($this->once())
+            ->method('setBody')
+            ->with($this->callback(function ($data) {
+                $orig = gzdecode($data);
+                return $orig === 'my gzip test';
+            }));
 
-		$result = $this->plugin->compressResponse($request, $response);
-		$this->assertSame($response, $result);
-	}
+        $result = $this->plugin->compressResponse($request, $response);
+        $this->assertSame($response, $result);
+    }
 }

apps/dav/tests/unit/Connector/LegacyPublicAuthTest.php

Indentation +150 added lines, -150 removed lines

@@ -25,206 +25,206 @@
  * @package OCA\DAV\Tests\unit\Connector
  */
 class LegacyPublicAuthTest extends \Test\TestCase {
-	private ISession&MockObject $session;
-	private IRequest&MockObject $request;
-	private IManager&MockObject $shareManager;
-	private IThrottler&MockObject $throttler;
-	private LegacyPublicAuth $auth;
-	private string|false $oldUser;
+    private ISession&MockObject $session;
+    private IRequest&MockObject $request;
+    private IManager&MockObject $shareManager;
+    private IThrottler&MockObject $throttler;
+    private LegacyPublicAuth $auth;
+    private string|false $oldUser;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->session = $this->createMock(ISession::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->shareManager = $this->createMock(IManager::class);
-		$this->throttler = $this->createMock(IThrottler::class);
+        $this->session = $this->createMock(ISession::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->shareManager = $this->createMock(IManager::class);
+        $this->throttler = $this->createMock(IThrottler::class);
 
-		$this->auth = new LegacyPublicAuth(
-			$this->request,
-			$this->shareManager,
-			$this->session,
-			$this->throttler
-		);
+        $this->auth = new LegacyPublicAuth(
+            $this->request,
+            $this->shareManager,
+            $this->session,
+            $this->throttler
+        );
 
-		// Store current user
-		$this->oldUser = \OC_User::getUser();
-	}
+        // Store current user
+        $this->oldUser = \OC_User::getUser();
+    }
 
-	protected function tearDown(): void {
-		\OC_User::setIncognitoMode(false);
+    protected function tearDown(): void {
+        \OC_User::setIncognitoMode(false);
 
-		// Set old user
-		\OC_User::setUserId($this->oldUser);
-		if ($this->oldUser !== false) {
-			\OC_Util::setupFS($this->oldUser);
-		}
+        // Set old user
+        \OC_User::setUserId($this->oldUser);
+        if ($this->oldUser !== false) {
+            \OC_Util::setupFS($this->oldUser);
+        }
 
-		parent::tearDown();
-	}
+        parent::tearDown();
+    }
 
-	public function testNoShare(): void {
-		$this->shareManager->expects($this->once())
-			->method('getShareByToken')
-			->willThrowException(new ShareNotFound());
+    public function testNoShare(): void {
+        $this->shareManager->expects($this->once())
+            ->method('getShareByToken')
+            ->willThrowException(new ShareNotFound());
 
-		$result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
+        $result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
 
-		$this->assertFalse($result);
-	}
+        $this->assertFalse($result);
+    }
 
-	public function testShareNoPassword(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')->willReturn(null);
+    public function testShareNoPassword(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')->willReturn(null);
 
-		$this->shareManager->expects($this->once())
-			->method('getShareByToken')
-			->willReturn($share);
+        $this->shareManager->expects($this->once())
+            ->method('getShareByToken')
+            ->willReturn($share);
 
-		$result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
+        $result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
 
-		$this->assertTrue($result);
-	}
+        $this->assertTrue($result);
+    }
 
-	public function testSharePasswordFancyShareType(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')->willReturn('password');
-		$share->method('getShareType')->willReturn(42);
+    public function testSharePasswordFancyShareType(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')->willReturn('password');
+        $share->method('getShareType')->willReturn(42);
 
-		$this->shareManager->expects($this->once())
-			->method('getShareByToken')
-			->willReturn($share);
+        $this->shareManager->expects($this->once())
+            ->method('getShareByToken')
+            ->willReturn($share);
 
-		$result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
+        $result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
 
-		$this->assertFalse($result);
-	}
+        $this->assertFalse($result);
+    }
 
 
-	public function testSharePasswordRemote(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')->willReturn('password');
-		$share->method('getShareType')->willReturn(IShare::TYPE_REMOTE);
+    public function testSharePasswordRemote(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')->willReturn('password');
+        $share->method('getShareType')->willReturn(IShare::TYPE_REMOTE);
 
-		$this->shareManager->expects($this->once())
-			->method('getShareByToken')
-			->willReturn($share);
+        $this->shareManager->expects($this->once())
+            ->method('getShareByToken')
+            ->willReturn($share);
 
-		$result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
+        $result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
 
-		$this->assertTrue($result);
-	}
+        $this->assertTrue($result);
+    }
 
-	public function testSharePasswordLinkValidPassword(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')->willReturn('password');
-		$share->method('getShareType')->willReturn(IShare::TYPE_LINK);
+    public function testSharePasswordLinkValidPassword(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')->willReturn('password');
+        $share->method('getShareType')->willReturn(IShare::TYPE_LINK);
 
-		$this->shareManager->expects($this->once())
-			->method('getShareByToken')
-			->willReturn($share);
+        $this->shareManager->expects($this->once())
+            ->method('getShareByToken')
+            ->willReturn($share);
 
-		$this->shareManager->expects($this->once())
-			->method('checkPassword')->with(
-				$this->equalTo($share),
-				$this->equalTo('password')
-			)->willReturn(true);
+        $this->shareManager->expects($this->once())
+            ->method('checkPassword')->with(
+                $this->equalTo($share),
+                $this->equalTo('password')
+            )->willReturn(true);
 
-		$result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
+        $result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
 
-		$this->assertTrue($result);
-	}
+        $this->assertTrue($result);
+    }
 
-	public function testSharePasswordMailValidPassword(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')->willReturn('password');
-		$share->method('getShareType')->willReturn(IShare::TYPE_EMAIL);
+    public function testSharePasswordMailValidPassword(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')->willReturn('password');
+        $share->method('getShareType')->willReturn(IShare::TYPE_EMAIL);
 
-		$this->shareManager->expects($this->once())
-			->method('getShareByToken')
-			->willReturn($share);
+        $this->shareManager->expects($this->once())
+            ->method('getShareByToken')
+            ->willReturn($share);
 
-		$this->shareManager->expects($this->once())
-			->method('checkPassword')->with(
-				$this->equalTo($share),
-				$this->equalTo('password')
-			)->willReturn(true);
+        $this->shareManager->expects($this->once())
+            ->method('checkPassword')->with(
+                $this->equalTo($share),
+                $this->equalTo('password')
+            )->willReturn(true);
 
-		$result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
+        $result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
 
-		$this->assertTrue($result);
-	}
+        $this->assertTrue($result);
+    }
 
-	public function testInvalidSharePasswordLinkValidSession(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')->willReturn('password');
-		$share->method('getShareType')->willReturn(IShare::TYPE_LINK);
-		$share->method('getId')->willReturn('42');
+    public function testInvalidSharePasswordLinkValidSession(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')->willReturn('password');
+        $share->method('getShareType')->willReturn(IShare::TYPE_LINK);
+        $share->method('getId')->willReturn('42');
 
-		$this->shareManager->expects($this->once())
-			->method('getShareByToken')
-			->willReturn($share);
+        $this->shareManager->expects($this->once())
+            ->method('getShareByToken')
+            ->willReturn($share);
 
-		$this->shareManager->method('checkPassword')
-			->with(
-				$this->equalTo($share),
-				$this->equalTo('password')
-			)->willReturn(false);
+        $this->shareManager->method('checkPassword')
+            ->with(
+                $this->equalTo($share),
+                $this->equalTo('password')
+            )->willReturn(false);
 
-		$this->session->method('exists')->with('public_link_authenticated')->willReturn(true);
-		$this->session->method('get')->with('public_link_authenticated')->willReturn('42');
+        $this->session->method('exists')->with('public_link_authenticated')->willReturn(true);
+        $this->session->method('get')->with('public_link_authenticated')->willReturn('42');
 
-		$result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
+        $result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
 
-		$this->assertTrue($result);
-	}
+        $this->assertTrue($result);
+    }
 
-	public function testSharePasswordLinkInvalidSession(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')->willReturn('password');
-		$share->method('getShareType')->willReturn(IShare::TYPE_LINK);
-		$share->method('getId')->willReturn('42');
+    public function testSharePasswordLinkInvalidSession(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')->willReturn('password');
+        $share->method('getShareType')->willReturn(IShare::TYPE_LINK);
+        $share->method('getId')->willReturn('42');
 
-		$this->shareManager->expects($this->once())
-			->method('getShareByToken')
-			->willReturn($share);
+        $this->shareManager->expects($this->once())
+            ->method('getShareByToken')
+            ->willReturn($share);
 
-		$this->shareManager->method('checkPassword')
-			->with(
-				$this->equalTo($share),
-				$this->equalTo('password')
-			)->willReturn(false);
+        $this->shareManager->method('checkPassword')
+            ->with(
+                $this->equalTo($share),
+                $this->equalTo('password')
+            )->willReturn(false);
 
-		$this->session->method('exists')->with('public_link_authenticated')->willReturn(true);
-		$this->session->method('get')->with('public_link_authenticated')->willReturn('43');
+        $this->session->method('exists')->with('public_link_authenticated')->willReturn(true);
+        $this->session->method('get')->with('public_link_authenticated')->willReturn('43');
 
-		$result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
+        $result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
 
-		$this->assertFalse($result);
-	}
+        $this->assertFalse($result);
+    }
 
 
-	public function testSharePasswordMailInvalidSession(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')->willReturn('password');
-		$share->method('getShareType')->willReturn(IShare::TYPE_EMAIL);
-		$share->method('getId')->willReturn('42');
+    public function testSharePasswordMailInvalidSession(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')->willReturn('password');
+        $share->method('getShareType')->willReturn(IShare::TYPE_EMAIL);
+        $share->method('getId')->willReturn('42');
 
-		$this->shareManager->expects($this->once())
-			->method('getShareByToken')
-			->willReturn($share);
+        $this->shareManager->expects($this->once())
+            ->method('getShareByToken')
+            ->willReturn($share);
 
-		$this->shareManager->method('checkPassword')
-			->with(
-				$this->equalTo($share),
-				$this->equalTo('password')
-			)->willReturn(false);
+        $this->shareManager->method('checkPassword')
+            ->with(
+                $this->equalTo($share),
+                $this->equalTo('password')
+            )->willReturn(false);
 
-		$this->session->method('exists')->with('public_link_authenticated')->willReturn(true);
-		$this->session->method('get')->with('public_link_authenticated')->willReturn('43');
+        $this->session->method('exists')->with('public_link_authenticated')->willReturn(true);
+        $this->session->method('get')->with('public_link_authenticated')->willReturn('43');
 
-		$result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
+        $result = $this->invokePrivate($this->auth, 'validateUserPass', ['username', 'password']);
 
-		$this->assertFalse($result);
-	}
+        $this->assertFalse($result);
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
 	private IManager&MockObject $shareManager;
 	private IThrottler&MockObject $throttler;
 	private LegacyPublicAuth $auth;
-	private string|false $oldUser;
+	private string | false $oldUser;
 
 	protected function setUp(): void {
 		parent::setUp();

apps/dav/tests/unit/Direct/DirectHomeTest.php

Indentation +121 added lines, -121 removed lines

@@ -25,136 +25,136 @@
 use Test\TestCase;
 
 class DirectHomeTest extends TestCase {
-	private DirectMapper&MockObject $directMapper;
-	private IRootFolder&MockObject $rootFolder;
-	private ITimeFactory&MockObject $timeFactory;
-	private IThrottler&MockObject $throttler;
-	private IRequest&MockObject $request;
-	private IEventDispatcher&MockObject $eventDispatcher;
-	private DirectHome $directHome;
+    private DirectMapper&MockObject $directMapper;
+    private IRootFolder&MockObject $rootFolder;
+    private ITimeFactory&MockObject $timeFactory;
+    private IThrottler&MockObject $throttler;
+    private IRequest&MockObject $request;
+    private IEventDispatcher&MockObject $eventDispatcher;
+    private DirectHome $directHome;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->directMapper = $this->createMock(DirectMapper::class);
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->throttler = $this->createMock(IThrottler::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
+        $this->directMapper = $this->createMock(DirectMapper::class);
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->throttler = $this->createMock(IThrottler::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->eventDispatcher = $this->createMock(IEventDispatcher::class);
 
-		$this->timeFactory->method('getTime')
-			->willReturn(42);
+        $this->timeFactory->method('getTime')
+            ->willReturn(42);
 
-		$this->request->method('getRemoteAddress')
-			->willReturn('1.2.3.4');
-
-
-		$this->directHome = new DirectHome(
-			$this->rootFolder,
-			$this->directMapper,
-			$this->timeFactory,
-			$this->throttler,
-			$this->request,
-			$this->eventDispatcher
-		);
-	}
-
-	public function testCreateFile(): void {
-		$this->expectException(Forbidden::class);
-
-		$this->directHome->createFile('foo', 'bar');
-	}
-
-	public function testCreateDirectory(): void {
-		$this->expectException(Forbidden::class);
-
-		$this->directHome->createDirectory('foo');
-	}
-
-	public function testGetChildren(): void {
-		$this->expectException(MethodNotAllowed::class);
-
-		$this->directHome->getChildren();
-	}
-
-	public function testChildExists(): void {
-		$this->assertFalse($this->directHome->childExists('foo'));
-	}
-
-	public function testDelete(): void {
-		$this->expectException(Forbidden::class);
-
-		$this->directHome->delete();
-	}
-
-	public function testGetName(): void {
-		$this->assertSame('direct', $this->directHome->getName());
-	}
-
-	public function testSetName(): void {
-		$this->expectException(Forbidden::class);
-
-		$this->directHome->setName('foo');
-	}
-
-	public function testGetLastModified(): void {
-		$this->assertSame(0, $this->directHome->getLastModified());
-	}
-
-	public function testGetChildValid(): void {
-		$direct = Direct::fromParams([
-			'expiration' => 100,
-		]);
-
-		$this->directMapper->method('getByToken')
-			->with('longtoken')
-			->willReturn($direct);
-
-		$this->throttler->expects($this->never())
-			->method($this->anything());
-
-		$result = $this->directHome->getChild('longtoken');
-		$this->assertInstanceOf(DirectFile::class, $result);
-	}
-
-	public function testGetChildExpired(): void {
-		$direct = Direct::fromParams([
-			'expiration' => 41,
-		]);
-
-		$this->directMapper->method('getByToken')
-			->with('longtoken')
-			->willReturn($direct);
+        $this->request->method('getRemoteAddress')
+            ->willReturn('1.2.3.4');
+
+
+        $this->directHome = new DirectHome(
+            $this->rootFolder,
+            $this->directMapper,
+            $this->timeFactory,
+            $this->throttler,
+            $this->request,
+            $this->eventDispatcher
+        );
+    }
+
+    public function testCreateFile(): void {
+        $this->expectException(Forbidden::class);
+
+        $this->directHome->createFile('foo', 'bar');
+    }
+
+    public function testCreateDirectory(): void {
+        $this->expectException(Forbidden::class);
+
+        $this->directHome->createDirectory('foo');
+    }
+
+    public function testGetChildren(): void {
+        $this->expectException(MethodNotAllowed::class);
+
+        $this->directHome->getChildren();
+    }
+
+    public function testChildExists(): void {
+        $this->assertFalse($this->directHome->childExists('foo'));
+    }
+
+    public function testDelete(): void {
+        $this->expectException(Forbidden::class);
+
+        $this->directHome->delete();
+    }
+
+    public function testGetName(): void {
+        $this->assertSame('direct', $this->directHome->getName());
+    }
+
+    public function testSetName(): void {
+        $this->expectException(Forbidden::class);
+
+        $this->directHome->setName('foo');
+    }
+
+    public function testGetLastModified(): void {
+        $this->assertSame(0, $this->directHome->getLastModified());
+    }
+
+    public function testGetChildValid(): void {
+        $direct = Direct::fromParams([
+            'expiration' => 100,
+        ]);
+
+        $this->directMapper->method('getByToken')
+            ->with('longtoken')
+            ->willReturn($direct);
+
+        $this->throttler->expects($this->never())
+            ->method($this->anything());
+
+        $result = $this->directHome->getChild('longtoken');
+        $this->assertInstanceOf(DirectFile::class, $result);
+    }
+
+    public function testGetChildExpired(): void {
+        $direct = Direct::fromParams([
+            'expiration' => 41,
+        ]);
+
+        $this->directMapper->method('getByToken')
+            ->with('longtoken')
+            ->willReturn($direct);
 
-		$this->throttler->expects($this->never())
-			->method($this->anything());
+        $this->throttler->expects($this->never())
+            ->method($this->anything());
 
-		$this->expectException(NotFound::class);
+        $this->expectException(NotFound::class);
 
-		$this->directHome->getChild('longtoken');
-	}
+        $this->directHome->getChild('longtoken');
+    }
 
-	public function testGetChildInvalid(): void {
-		$this->directMapper->method('getByToken')
-			->with('longtoken')
-			->willThrowException(new DoesNotExistException('not found'));
+    public function testGetChildInvalid(): void {
+        $this->directMapper->method('getByToken')
+            ->with('longtoken')
+            ->willThrowException(new DoesNotExistException('not found'));
 
-		$this->throttler->expects($this->once())
-			->method('registerAttempt')
-			->with(
-				'directlink',
-				'1.2.3.4'
-			);
-		$this->throttler->expects($this->once())
-			->method('sleepDelayOrThrowOnMax')
-			->with(
-				'1.2.3.4',
-				'directlink'
-			);
+        $this->throttler->expects($this->once())
+            ->method('registerAttempt')
+            ->with(
+                'directlink',
+                '1.2.3.4'
+            );
+        $this->throttler->expects($this->once())
+            ->method('sleepDelayOrThrowOnMax')
+            ->with(
+                '1.2.3.4',
+                'directlink'
+            );
 
-		$this->expectException(NotFound::class);
+        $this->expectException(NotFound::class);
 
-		$this->directHome->getChild('longtoken');
-	}
+        $this->directHome->getChild('longtoken');
+    }
 }

apps/dav/tests/unit/Direct/DirectFileTest.php

Indentation +66 added lines, -66 removed lines

@@ -19,93 +19,93 @@
 use Test\TestCase;
 
 class DirectFileTest extends TestCase {
-	private Direct $direct;
-	private IRootFolder&MockObject $rootFolder;
-	private Folder&MockObject $userFolder;
-	private File&MockObject $file;
-	private IEventDispatcher&MockObject $eventDispatcher;
-	private DirectFile $directFile;
+    private Direct $direct;
+    private IRootFolder&MockObject $rootFolder;
+    private Folder&MockObject $userFolder;
+    private File&MockObject $file;
+    private IEventDispatcher&MockObject $eventDispatcher;
+    private DirectFile $directFile;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->direct = Direct::fromParams([
-			'userId' => 'directUser',
-			'token' => 'directToken',
-			'fileId' => 42,
-		]);
+        $this->direct = Direct::fromParams([
+            'userId' => 'directUser',
+            'token' => 'directToken',
+            'fileId' => 42,
+        ]);
 
-		$this->rootFolder = $this->createMock(IRootFolder::class);
+        $this->rootFolder = $this->createMock(IRootFolder::class);
 
-		$this->userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with('directUser')
-			->willReturn($this->userFolder);
+        $this->userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with('directUser')
+            ->willReturn($this->userFolder);
 
-		$this->file = $this->createMock(File::class);
-		$this->userFolder->method('getFirstNodeById')
-			->with(42)
-			->willReturn($this->file);
+        $this->file = $this->createMock(File::class);
+        $this->userFolder->method('getFirstNodeById')
+            ->with(42)
+            ->willReturn($this->file);
 
-		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
+        $this->eventDispatcher = $this->createMock(IEventDispatcher::class);
 
-		$this->directFile = new DirectFile($this->direct, $this->rootFolder, $this->eventDispatcher);
-	}
+        $this->directFile = new DirectFile($this->direct, $this->rootFolder, $this->eventDispatcher);
+    }
 
-	public function testPut(): void {
-		$this->expectException(Forbidden::class);
+    public function testPut(): void {
+        $this->expectException(Forbidden::class);
 
-		$this->directFile->put('foo');
-	}
+        $this->directFile->put('foo');
+    }
 
-	public function testGet(): void {
-		$this->file->expects($this->once())
-			->method('fopen')
-			->with('rb');
-		$this->directFile->get();
-	}
+    public function testGet(): void {
+        $this->file->expects($this->once())
+            ->method('fopen')
+            ->with('rb');
+        $this->directFile->get();
+    }
 
-	public function testGetContentType(): void {
-		$this->file->method('getMimeType')
-			->willReturn('direct/type');
+    public function testGetContentType(): void {
+        $this->file->method('getMimeType')
+            ->willReturn('direct/type');
 
-		$this->assertSame('direct/type', $this->directFile->getContentType());
-	}
+        $this->assertSame('direct/type', $this->directFile->getContentType());
+    }
 
-	public function testGetETag(): void {
-		$this->file->method('getEtag')
-			->willReturn('directEtag');
+    public function testGetETag(): void {
+        $this->file->method('getEtag')
+            ->willReturn('directEtag');
 
-		$this->assertSame('directEtag', $this->directFile->getETag());
-	}
+        $this->assertSame('directEtag', $this->directFile->getETag());
+    }
 
-	public function testGetSize(): void {
-		$this->file->method('getSize')
-			->willReturn(42);
+    public function testGetSize(): void {
+        $this->file->method('getSize')
+            ->willReturn(42);
 
-		$this->assertSame(42, $this->directFile->getSize());
-	}
+        $this->assertSame(42, $this->directFile->getSize());
+    }
 
-	public function testDelete(): void {
-		$this->expectException(Forbidden::class);
+    public function testDelete(): void {
+        $this->expectException(Forbidden::class);
 
-		$this->directFile->delete();
-	}
+        $this->directFile->delete();
+    }
 
-	public function testGetName(): void {
-		$this->assertSame('directToken', $this->directFile->getName());
-	}
+    public function testGetName(): void {
+        $this->assertSame('directToken', $this->directFile->getName());
+    }
 
-	public function testSetName(): void {
-		$this->expectException(Forbidden::class);
+    public function testSetName(): void {
+        $this->expectException(Forbidden::class);
 
-		$this->directFile->setName('foobar');
-	}
+        $this->directFile->setName('foobar');
+    }
 
-	public function testGetLastModified(): void {
-		$this->file->method('getMTime')
-			->willReturn(42);
+    public function testGetLastModified(): void {
+        $this->file->method('getMTime')
+            ->willReturn(42);
 
-		$this->assertSame(42, $this->directFile->getLastModified());
-	}
+        $this->assertSame(42, $this->directFile->getLastModified());
+    }
 }

apps/dav/tests/unit/Provisioning/Apple/AppleProvisioningNodeTest.php

Indentation +38 added lines, -38 removed lines

@@ -14,57 +14,57 @@
 use Test\TestCase;
 
 class AppleProvisioningNodeTest extends TestCase {
-	private ITimeFactory&MockObject $timeFactory;
-	private AppleProvisioningNode $node;
+    private ITimeFactory&MockObject $timeFactory;
+    private AppleProvisioningNode $node;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->node = new AppleProvisioningNode($this->timeFactory);
-	}
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->node = new AppleProvisioningNode($this->timeFactory);
+    }
 
-	public function testGetName(): void {
-		$this->assertEquals('apple-provisioning.mobileconfig', $this->node->getName());
-	}
+    public function testGetName(): void {
+        $this->assertEquals('apple-provisioning.mobileconfig', $this->node->getName());
+    }
 
-	public function testSetName(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$this->expectExceptionMessage('Renaming apple-provisioning.mobileconfig is forbidden');
+    public function testSetName(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $this->expectExceptionMessage('Renaming apple-provisioning.mobileconfig is forbidden');
 
-		$this->node->setName('foo');
-	}
+        $this->node->setName('foo');
+    }
 
-	public function testGetLastModified(): void {
-		$this->assertEquals(null, $this->node->getLastModified());
-	}
+    public function testGetLastModified(): void {
+        $this->assertEquals(null, $this->node->getLastModified());
+    }
 
 
-	public function testDelete(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$this->expectExceptionMessage('apple-provisioning.mobileconfig may not be deleted');
+    public function testDelete(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $this->expectExceptionMessage('apple-provisioning.mobileconfig may not be deleted');
 
-		$this->node->delete();
-	}
+        $this->node->delete();
+    }
 
-	public function testGetProperties(): void {
-		$this->timeFactory->expects($this->once())
-			->method('getDateTime')
-			->willReturn(new \DateTime('2000-01-01'));
+    public function testGetProperties(): void {
+        $this->timeFactory->expects($this->once())
+            ->method('getDateTime')
+            ->willReturn(new \DateTime('2000-01-01'));
 
-		$this->assertEquals([
-			'{DAV:}getcontentlength' => 42,
-			'{DAV:}getlastmodified' => 'Sat, 01 Jan 2000 00:00:00 +0000',
-		], $this->node->getProperties([]));
-	}
+        $this->assertEquals([
+            '{DAV:}getcontentlength' => 42,
+            '{DAV:}getlastmodified' => 'Sat, 01 Jan 2000 00:00:00 +0000',
+        ], $this->node->getProperties([]));
+    }
 
 
-	public function testGetPropPatch(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$this->expectExceptionMessage('apple-provisioning.mobileconfig\'s properties may not be altered.');
+    public function testGetPropPatch(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $this->expectExceptionMessage('apple-provisioning.mobileconfig\'s properties may not be altered.');
 
-		$propPatch = $this->createMock(PropPatch::class);
+        $propPatch = $this->createMock(PropPatch::class);
 
-		$this->node->propPatch($propPatch);
-	}
+        $this->node->propPatch($propPatch);
+    }
 }

apps/dav/tests/unit/Provisioning/Apple/AppleProvisioningPluginTest.php

Indentation +143 added lines, -143 removed lines

@@ -21,145 +21,145 @@ 
 use Test\TestCase;
 
 class AppleProvisioningPluginTest extends TestCase {
-	protected Server&MockObject $server;
-	protected IUserSession&MockObject $userSession;
-	protected IURLGenerator&MockObject $urlGenerator;
-	protected ThemingDefaults&MockObject $themingDefaults;
-	protected IRequest&MockObject $request;
-	protected IL10N&MockObject $l10n;
-	protected RequestInterface&MockObject $sabreRequest;
-	protected ResponseInterface&MockObject $sabreResponse;
-	protected AppleProvisioningPlugin $plugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->server = $this->createMock(Server::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->themingDefaults = $this->createMock(ThemingDefaults::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->l10n = $this->createMock(IL10N::class);
-
-		$this->plugin = new AppleProvisioningPlugin($this->userSession,
-			$this->urlGenerator,
-			$this->themingDefaults,
-			$this->request,
-			$this->l10n,
-			function () {
-				return 'generated-uuid';
-			}
-		);
-
-		$this->sabreRequest = $this->createMock(RequestInterface::class);
-		$this->sabreResponse = $this->createMock(ResponseInterface::class);
-	}
-
-	public function testInitialize(): void {
-		$server = $this->createMock(Server::class);
-
-		$plugin = new AppleProvisioningPlugin($this->userSession,
-			$this->urlGenerator, $this->themingDefaults, $this->request, $this->l10n,
-			function (): void {
-			});
-
-		$server->expects($this->once())
-			->method('on')
-			->with('method:GET', [$plugin, 'httpGet'], 90);
-
-		$plugin->initialize($server);
-	}
-
-	public function testHttpGetOnHttp(): void {
-		$this->sabreRequest->expects($this->once())
-			->method('getPath')
-			->with()
-			->willReturn('provisioning/apple-provisioning.mobileconfig');
-
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-
-		$this->request->expects($this->once())
-			->method('getServerProtocol')
-			->wilLReturn('http');
-
-		$this->themingDefaults->expects($this->once())
-			->method('getName')
-			->willReturn('InstanceName');
-
-		$this->l10n->expects($this->once())
-			->method('t')
-			->with('Your %s needs to be configured to use HTTPS in order to use CalDAV and CardDAV with iOS/macOS.', ['InstanceName'])
-			->willReturn('LocalizedErrorMessage');
-
-		$this->sabreResponse->expects($this->once())
-			->method('setStatus')
-			->with(200);
-		$this->sabreResponse->expects($this->once())
-			->method('setHeader')
-			->with('Content-Type', 'text/plain; charset=utf-8');
-		$this->sabreResponse->expects($this->once())
-			->method('setBody')
-			->with('LocalizedErrorMessage');
-
-		$returnValue = $this->plugin->httpGet($this->sabreRequest, $this->sabreResponse);
-
-		$this->assertFalse($returnValue);
-	}
-
-	public function testHttpGetOnHttps(): void {
-		$this->sabreRequest->expects($this->once())
-			->method('getPath')
-			->with()
-			->willReturn('provisioning/apple-provisioning.mobileconfig');
-
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('getUID')
-			->willReturn('userName');
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-
-		$this->request->expects($this->once())
-			->method('getServerProtocol')
-			->wilLReturn('https');
-
-		$this->urlGenerator->expects($this->once())
-			->method('getBaseUrl')
-			->willReturn('https://nextcloud.tld/nextcloud');
-
-		$this->themingDefaults->expects($this->once())
-			->method('getName')
-			->willReturn('InstanceName');
-
-		$this->l10n->expects($this->exactly(2))
-			->method('t')
-			->willReturnMap([
-				['Configures a CalDAV account', [], 'LocalizedConfiguresCalDAV'],
-				['Configures a CardDAV account', [], 'LocalizedConfiguresCardDAV'],
-			]);
-
-		$this->sabreResponse->expects($this->once())
-			->method('setStatus')
-			->with(200);
-
-		$calls = [
-			['Content-Disposition', 'attachment; filename="userName-apple-provisioning.mobileconfig"'],
-			['Content-Type', 'application/xml; charset=utf-8'],
-		];
-		$this->sabreResponse->expects($this->exactly(2))
-			->method('setHeader')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-		$this->sabreResponse->expects($this->once())
-			->method('setBody')
-			->with(<<<EOF
+    protected Server&MockObject $server;
+    protected IUserSession&MockObject $userSession;
+    protected IURLGenerator&MockObject $urlGenerator;
+    protected ThemingDefaults&MockObject $themingDefaults;
+    protected IRequest&MockObject $request;
+    protected IL10N&MockObject $l10n;
+    protected RequestInterface&MockObject $sabreRequest;
+    protected ResponseInterface&MockObject $sabreResponse;
+    protected AppleProvisioningPlugin $plugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->server = $this->createMock(Server::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->themingDefaults = $this->createMock(ThemingDefaults::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->l10n = $this->createMock(IL10N::class);
+
+        $this->plugin = new AppleProvisioningPlugin($this->userSession,
+            $this->urlGenerator,
+            $this->themingDefaults,
+            $this->request,
+            $this->l10n,
+            function () {
+                return 'generated-uuid';
+            }
+        );
+
+        $this->sabreRequest = $this->createMock(RequestInterface::class);
+        $this->sabreResponse = $this->createMock(ResponseInterface::class);
+    }
+
+    public function testInitialize(): void {
+        $server = $this->createMock(Server::class);
+
+        $plugin = new AppleProvisioningPlugin($this->userSession,
+            $this->urlGenerator, $this->themingDefaults, $this->request, $this->l10n,
+            function (): void {
+            });
+
+        $server->expects($this->once())
+            ->method('on')
+            ->with('method:GET', [$plugin, 'httpGet'], 90);
+
+        $plugin->initialize($server);
+    }
+
+    public function testHttpGetOnHttp(): void {
+        $this->sabreRequest->expects($this->once())
+            ->method('getPath')
+            ->with()
+            ->willReturn('provisioning/apple-provisioning.mobileconfig');
+
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+
+        $this->request->expects($this->once())
+            ->method('getServerProtocol')
+            ->wilLReturn('http');
+
+        $this->themingDefaults->expects($this->once())
+            ->method('getName')
+            ->willReturn('InstanceName');
+
+        $this->l10n->expects($this->once())
+            ->method('t')
+            ->with('Your %s needs to be configured to use HTTPS in order to use CalDAV and CardDAV with iOS/macOS.', ['InstanceName'])
+            ->willReturn('LocalizedErrorMessage');
+
+        $this->sabreResponse->expects($this->once())
+            ->method('setStatus')
+            ->with(200);
+        $this->sabreResponse->expects($this->once())
+            ->method('setHeader')
+            ->with('Content-Type', 'text/plain; charset=utf-8');
+        $this->sabreResponse->expects($this->once())
+            ->method('setBody')
+            ->with('LocalizedErrorMessage');
+
+        $returnValue = $this->plugin->httpGet($this->sabreRequest, $this->sabreResponse);
+
+        $this->assertFalse($returnValue);
+    }
+
+    public function testHttpGetOnHttps(): void {
+        $this->sabreRequest->expects($this->once())
+            ->method('getPath')
+            ->with()
+            ->willReturn('provisioning/apple-provisioning.mobileconfig');
+
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('getUID')
+            ->willReturn('userName');
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+
+        $this->request->expects($this->once())
+            ->method('getServerProtocol')
+            ->wilLReturn('https');
+
+        $this->urlGenerator->expects($this->once())
+            ->method('getBaseUrl')
+            ->willReturn('https://nextcloud.tld/nextcloud');
+
+        $this->themingDefaults->expects($this->once())
+            ->method('getName')
+            ->willReturn('InstanceName');
+
+        $this->l10n->expects($this->exactly(2))
+            ->method('t')
+            ->willReturnMap([
+                ['Configures a CalDAV account', [], 'LocalizedConfiguresCalDAV'],
+                ['Configures a CardDAV account', [], 'LocalizedConfiguresCardDAV'],
+            ]);
+
+        $this->sabreResponse->expects($this->once())
+            ->method('setStatus')
+            ->with(200);
+
+        $calls = [
+            ['Content-Disposition', 'attachment; filename="userName-apple-provisioning.mobileconfig"'],
+            ['Content-Type', 'application/xml; charset=utf-8'],
+        ];
+        $this->sabreResponse->expects($this->exactly(2))
+            ->method('setHeader')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+        $this->sabreResponse->expects($this->once())
+            ->method('setBody')
+            ->with(<<<EOF
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
@@ -231,10 +231,10 @@ 
 </plist>
 
 EOF
-			);
+            );
 
-		$returnValue = $this->plugin->httpGet($this->sabreRequest, $this->sabreResponse);
+        $returnValue = $this->plugin->httpGet($this->sabreRequest, $this->sabreResponse);
 
-		$this->assertFalse($returnValue);
-	}
+        $this->assertFalse($returnValue);
+    }
 }

Spacing +3 added lines, -3 removed lines

@@ -46,7 +46,7 @@ 
 			$this->themingDefaults,
 			$this->request,
 			$this->l10n,
-			function () {
+			function() {
 				return 'generated-uuid';
 			}
 		);
@@ -60,7 +60,7 @@ 
 
 		$plugin = new AppleProvisioningPlugin($this->userSession,
 			$this->urlGenerator, $this->themingDefaults, $this->request, $this->l10n,
-			function (): void {
+			function(): void {
 			});
 
 		$server->expects($this->once())
@@ -153,7 +153,7 @@ 
 		];
 		$this->sabreResponse->expects($this->exactly(2))
 			->method('setHeader')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});

apps/dav/tests/unit/DAV/BrowserErrorPagePluginTest.php

Indentation +25 added lines, -25 removed lines

@@ -15,30 +15,30 @@
 
 class BrowserErrorPagePluginTest extends \Test\TestCase {
 
-	/**
-	 * @dataProvider providesExceptions
-	 */
-	public function test(int $expectedCode, \Throwable $exception): void {
-		/** @var BrowserErrorPagePlugin&MockObject $plugin */
-		$plugin = $this->getMockBuilder(BrowserErrorPagePlugin::class)->onlyMethods(['sendResponse', 'generateBody'])->getMock();
-		$plugin->expects($this->once())->method('generateBody')->willReturn(':boom:');
-		$plugin->expects($this->once())->method('sendResponse');
-		/** @var \Sabre\DAV\Server&MockObject $server */
-		$server = $this->createMock('Sabre\DAV\Server');
-		$server->expects($this->once())->method('on');
-		$httpResponse = $this->createMock(Response::class);
-		$httpResponse->expects($this->once())->method('addHeaders');
-		$httpResponse->expects($this->once())->method('setStatus')->with($expectedCode);
-		$httpResponse->expects($this->once())->method('setBody')->with(':boom:');
-		$server->httpResponse = $httpResponse;
-		$plugin->initialize($server);
-		$plugin->logException($exception);
-	}
+    /**
+     * @dataProvider providesExceptions
+     */
+    public function test(int $expectedCode, \Throwable $exception): void {
+        /** @var BrowserErrorPagePlugin&MockObject $plugin */
+        $plugin = $this->getMockBuilder(BrowserErrorPagePlugin::class)->onlyMethods(['sendResponse', 'generateBody'])->getMock();
+        $plugin->expects($this->once())->method('generateBody')->willReturn(':boom:');
+        $plugin->expects($this->once())->method('sendResponse');
+        /** @var \Sabre\DAV\Server&MockObject $server */
+        $server = $this->createMock('Sabre\DAV\Server');
+        $server->expects($this->once())->method('on');
+        $httpResponse = $this->createMock(Response::class);
+        $httpResponse->expects($this->once())->method('addHeaders');
+        $httpResponse->expects($this->once())->method('setStatus')->with($expectedCode);
+        $httpResponse->expects($this->once())->method('setBody')->with(':boom:');
+        $server->httpResponse = $httpResponse;
+        $plugin->initialize($server);
+        $plugin->logException($exception);
+    }
 
-	public static function providesExceptions(): array {
-		return [
-			[ 404, new NotFound()],
-			[ 500, new \RuntimeException()],
-		];
-	}
+    public static function providesExceptions(): array {
+        return [
+            [ 404, new NotFound()],
+            [ 500, new \RuntimeException()],
+        ];
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -37,8 +37,8 @@
 
 	public static function providesExceptions(): array {
 		return [
-			[ 404, new NotFound()],
-			[ 500, new \RuntimeException()],
+			[404, new NotFound()],
+			[500, new \RuntimeException()],
 		];
 	}
 }

apps/dav/tests/unit/DAV/Sharing/BackendTest.php

Indentation +372 added lines, -372 removed lines

@@ -24,376 +24,376 @@
 
 class BackendTest extends TestCase {
 
-	private IDBConnection&MockObject $db;
-	private IUserManager&MockObject $userManager;
-	private IGroupManager&MockObject $groupManager;
-	private Principal&MockObject $principalBackend;
-	private ICache&MockObject $shareCache;
-	private LoggerInterface&MockObject $logger;
-	private ICacheFactory&MockObject $cacheFactory;
-	private Service&MockObject $calendarService;
-	private CalendarSharingBackend $backend;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->db = $this->createMock(IDBConnection::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->principalBackend = $this->createMock(Principal::class);
-		$this->cacheFactory = $this->createMock(ICacheFactory::class);
-		$this->shareCache = $this->createMock(ICache::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->calendarService = $this->createMock(Service::class);
-		$this->cacheFactory->expects(self::any())
-			->method('createInMemory')
-			->willReturn($this->shareCache);
-
-		$this->backend = new CalendarSharingBackend(
-			$this->userManager,
-			$this->groupManager,
-			$this->principalBackend,
-			$this->cacheFactory,
-			$this->calendarService,
-			$this->logger,
-		);
-	}
-
-	public function testUpdateShareCalendarBob(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$add = [
-			[
-				'href' => 'principal:principals/users/bob',
-				'readOnly' => true,
-			]
-		];
-		$principal = 'principals/users/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->userManager->expects(self::once())
-			->method('userExists')
-			->willReturn(true);
-		$this->groupManager->expects(self::never())
-			->method('groupExists');
-		$this->calendarService->expects(self::once())
-			->method('shareWith')
-			->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
-
-		$this->backend->updateShares($shareable, $add, []);
-	}
-
-	public function testUpdateShareCalendarGroup(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$add = [
-			[
-				'href' => 'principal:principals/groups/bob',
-				'readOnly' => true,
-			]
-		];
-		$principal = 'principals/groups/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->userManager->expects(self::never())
-			->method('userExists');
-		$this->groupManager->expects(self::once())
-			->method('groupExists')
-			->willReturn(true);
-		$this->calendarService->expects(self::once())
-			->method('shareWith')
-			->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
-
-		$this->backend->updateShares($shareable, $add, []);
-	}
-
-	public function testUpdateShareContactsBob(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$add = [
-			[
-				'href' => 'principal:principals/users/bob',
-				'readOnly' => true,
-			]
-		];
-		$principal = 'principals/users/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->userManager->expects(self::once())
-			->method('userExists')
-			->willReturn(true);
-		$this->groupManager->expects(self::never())
-			->method('groupExists');
-		$this->calendarService->expects(self::once())
-			->method('shareWith')
-			->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
-
-		$this->backend->updateShares($shareable, $add, []);
-	}
-
-	public function testUpdateShareContactsGroup(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$add = [
-			[
-				'href' => 'principal:principals/groups/bob',
-				'readOnly' => true,
-			]
-		];
-		$principal = 'principals/groups/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->userManager->expects(self::never())
-			->method('userExists');
-		$this->groupManager->expects(self::once())
-			->method('groupExists')
-			->willReturn(true);
-		$this->calendarService->expects(self::once())
-			->method('shareWith')
-			->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
-
-		$this->backend->updateShares($shareable, $add, []);
-	}
-
-	public function testUpdateShareCircle(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$add = [
-			[
-				'href' => 'principal:principals/circles/bob',
-				'readOnly' => true,
-			]
-		];
-		$principal = 'principals/groups/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->userManager->expects(self::never())
-			->method('userExists');
-		$this->groupManager->expects(self::once())
-			->method('groupExists')
-			->willReturn(true);
-		$this->calendarService->expects(self::once())
-			->method('shareWith')
-			->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
-
-		$this->backend->updateShares($shareable, $add, []);
-	}
-
-	public function testUnshareBob(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$remove = [
-			'principal:principals/users/bob',
-		];
-		$principal = 'principals/users/bob';
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn($principal);
-		$this->calendarService->expects(self::once())
-			->method('deleteShare')
-			->with($shareable->getResourceId(), $principal);
-		$this->calendarService->expects(self::never())
-			->method('unshare');
-
-		$this->backend->updateShares($shareable, [], $remove);
-	}
-
-	public function testUnshareWithBobGroup(): void {
-		$shareable = $this->createConfiguredMock(IShareable::class, [
-			'getOwner' => 'principals/users/alice',
-			'getResourceId' => 42,
-		]);
-		$remove = [
-			'principal:principals/users/bob',
-		];
-		$oldShares = [
-			[
-				'href' => 'principal:principals/groups/bob',
-				'commonName' => 'bob',
-				'status' => 1,
-				'readOnly' => true,
-				'{http://owncloud.org/ns}principal' => 'principals/groups/bob',
-				'{http://owncloud.org/ns}group-share' => true,
-			]
-		];
-
-
-		$this->shareCache->expects(self::once())
-			->method('clear');
-		$this->principalBackend->expects(self::once())
-			->method('findByUri')
-			->willReturn('principals/users/bob');
-		$this->calendarService->expects(self::once())
-			->method('deleteShare')
-			->with($shareable->getResourceId(), 'principals/users/bob');
-		$this->calendarService->expects(self::never())
-			->method('unshare');
-
-		$this->backend->updateShares($shareable, [], $remove, $oldShares);
-	}
-
-	public function testGetShares(): void {
-		$resourceId = 42;
-		$principal = 'principals/groups/bob';
-		$rows = [
-			[
-				'principaluri' => $principal,
-				'access' => Backend::ACCESS_READ,
-			]
-		];
-		$expected = [
-			[
-				'href' => 'principal:principals/groups/bob',
-				'commonName' => 'bob',
-				'status' => 1,
-				'readOnly' => true,
-				'{http://owncloud.org/ns}principal' => $principal,
-				'{http://owncloud.org/ns}group-share' => true,
-			]
-		];
-
-
-		$this->shareCache->expects(self::once())
-			->method('get')
-			->with((string)$resourceId)
-			->willReturn(null);
-		$this->calendarService->expects(self::once())
-			->method('getShares')
-			->with($resourceId)
-			->willReturn($rows);
-		$this->principalBackend->expects(self::once())
-			->method('getPrincipalByPath')
-			->with($principal)
-			->willReturn(['uri' => $principal, '{DAV:}displayname' => 'bob']);
-		$this->shareCache->expects(self::once())
-			->method('set')
-			->with((string)$resourceId, $expected);
-
-		$result = $this->backend->getShares($resourceId);
-		$this->assertEquals($expected, $result);
-	}
-
-	public function testGetSharesAddressbooks(): void {
-		$service = $this->createMock(\OCA\DAV\CardDAV\Sharing\Service::class);
-		$backend = new ContactsSharingBackend(
-			$this->userManager,
-			$this->groupManager,
-			$this->principalBackend,
-			$this->cacheFactory,
-			$service,
-			$this->logger);
-		$resourceId = 42;
-		$principal = 'principals/groups/bob';
-		$rows = [
-			[
-				'principaluri' => $principal,
-				'access' => Backend::ACCESS_READ,
-			]
-		];
-		$expected = [
-			[
-				'href' => 'principal:principals/groups/bob',
-				'commonName' => 'bob',
-				'status' => 1,
-				'readOnly' => true,
-				'{http://owncloud.org/ns}principal' => $principal,
-				'{http://owncloud.org/ns}group-share' => true,
-			]
-		];
-
-		$this->shareCache->expects(self::once())
-			->method('get')
-			->with((string)$resourceId)
-			->willReturn(null);
-		$service->expects(self::once())
-			->method('getShares')
-			->with($resourceId)
-			->willReturn($rows);
-		$this->principalBackend->expects(self::once())
-			->method('getPrincipalByPath')
-			->with($principal)
-			->willReturn(['uri' => $principal, '{DAV:}displayname' => 'bob']);
-		$this->shareCache->expects(self::once())
-			->method('set')
-			->with((string)$resourceId, $expected);
-
-		$result = $backend->getShares($resourceId);
-		$this->assertEquals($expected, $result);
-	}
-
-	public function testPreloadShares(): void {
-		$resourceIds = [42, 99];
-		$rows = [
-			[
-				'resourceid' => 42,
-				'principaluri' => 'principals/groups/bob',
-				'access' => Backend::ACCESS_READ,
-			],
-			[
-				'resourceid' => 99,
-				'principaluri' => 'principals/users/carlos',
-				'access' => Backend::ACCESS_READ_WRITE,
-			]
-		];
-		$principalResults = [
-			['uri' => 'principals/groups/bob', '{DAV:}displayname' => 'bob'],
-			['uri' => 'principals/users/carlos', '{DAV:}displayname' => 'carlos'],
-		];
-
-		$this->shareCache->expects(self::exactly(2))
-			->method('get')
-			->willReturn(null);
-		$this->calendarService->expects(self::once())
-			->method('getSharesForIds')
-			->with($resourceIds)
-			->willReturn($rows);
-		$this->principalBackend->expects(self::exactly(2))
-			->method('getPrincipalByPath')
-			->willReturnCallback(function (string $principal) use ($principalResults) {
-				switch ($principal) {
-					case 'principals/groups/bob':
-						return $principalResults[0];
-					default:
-						return $principalResults[1];
-				}
-			});
-		$this->shareCache->expects(self::exactly(2))
-			->method('set');
-
-		$this->backend->preloadShares($resourceIds);
-	}
+    private IDBConnection&MockObject $db;
+    private IUserManager&MockObject $userManager;
+    private IGroupManager&MockObject $groupManager;
+    private Principal&MockObject $principalBackend;
+    private ICache&MockObject $shareCache;
+    private LoggerInterface&MockObject $logger;
+    private ICacheFactory&MockObject $cacheFactory;
+    private Service&MockObject $calendarService;
+    private CalendarSharingBackend $backend;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->db = $this->createMock(IDBConnection::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->principalBackend = $this->createMock(Principal::class);
+        $this->cacheFactory = $this->createMock(ICacheFactory::class);
+        $this->shareCache = $this->createMock(ICache::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->calendarService = $this->createMock(Service::class);
+        $this->cacheFactory->expects(self::any())
+            ->method('createInMemory')
+            ->willReturn($this->shareCache);
+
+        $this->backend = new CalendarSharingBackend(
+            $this->userManager,
+            $this->groupManager,
+            $this->principalBackend,
+            $this->cacheFactory,
+            $this->calendarService,
+            $this->logger,
+        );
+    }
+
+    public function testUpdateShareCalendarBob(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $add = [
+            [
+                'href' => 'principal:principals/users/bob',
+                'readOnly' => true,
+            ]
+        ];
+        $principal = 'principals/users/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->userManager->expects(self::once())
+            ->method('userExists')
+            ->willReturn(true);
+        $this->groupManager->expects(self::never())
+            ->method('groupExists');
+        $this->calendarService->expects(self::once())
+            ->method('shareWith')
+            ->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
+
+        $this->backend->updateShares($shareable, $add, []);
+    }
+
+    public function testUpdateShareCalendarGroup(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $add = [
+            [
+                'href' => 'principal:principals/groups/bob',
+                'readOnly' => true,
+            ]
+        ];
+        $principal = 'principals/groups/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->userManager->expects(self::never())
+            ->method('userExists');
+        $this->groupManager->expects(self::once())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->calendarService->expects(self::once())
+            ->method('shareWith')
+            ->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
+
+        $this->backend->updateShares($shareable, $add, []);
+    }
+
+    public function testUpdateShareContactsBob(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $add = [
+            [
+                'href' => 'principal:principals/users/bob',
+                'readOnly' => true,
+            ]
+        ];
+        $principal = 'principals/users/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->userManager->expects(self::once())
+            ->method('userExists')
+            ->willReturn(true);
+        $this->groupManager->expects(self::never())
+            ->method('groupExists');
+        $this->calendarService->expects(self::once())
+            ->method('shareWith')
+            ->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
+
+        $this->backend->updateShares($shareable, $add, []);
+    }
+
+    public function testUpdateShareContactsGroup(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $add = [
+            [
+                'href' => 'principal:principals/groups/bob',
+                'readOnly' => true,
+            ]
+        ];
+        $principal = 'principals/groups/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->userManager->expects(self::never())
+            ->method('userExists');
+        $this->groupManager->expects(self::once())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->calendarService->expects(self::once())
+            ->method('shareWith')
+            ->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
+
+        $this->backend->updateShares($shareable, $add, []);
+    }
+
+    public function testUpdateShareCircle(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $add = [
+            [
+                'href' => 'principal:principals/circles/bob',
+                'readOnly' => true,
+            ]
+        ];
+        $principal = 'principals/groups/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->userManager->expects(self::never())
+            ->method('userExists');
+        $this->groupManager->expects(self::once())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->calendarService->expects(self::once())
+            ->method('shareWith')
+            ->with($shareable->getResourceId(), $principal, Backend::ACCESS_READ);
+
+        $this->backend->updateShares($shareable, $add, []);
+    }
+
+    public function testUnshareBob(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $remove = [
+            'principal:principals/users/bob',
+        ];
+        $principal = 'principals/users/bob';
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn($principal);
+        $this->calendarService->expects(self::once())
+            ->method('deleteShare')
+            ->with($shareable->getResourceId(), $principal);
+        $this->calendarService->expects(self::never())
+            ->method('unshare');
+
+        $this->backend->updateShares($shareable, [], $remove);
+    }
+
+    public function testUnshareWithBobGroup(): void {
+        $shareable = $this->createConfiguredMock(IShareable::class, [
+            'getOwner' => 'principals/users/alice',
+            'getResourceId' => 42,
+        ]);
+        $remove = [
+            'principal:principals/users/bob',
+        ];
+        $oldShares = [
+            [
+                'href' => 'principal:principals/groups/bob',
+                'commonName' => 'bob',
+                'status' => 1,
+                'readOnly' => true,
+                '{http://owncloud.org/ns}principal' => 'principals/groups/bob',
+                '{http://owncloud.org/ns}group-share' => true,
+            ]
+        ];
+
+
+        $this->shareCache->expects(self::once())
+            ->method('clear');
+        $this->principalBackend->expects(self::once())
+            ->method('findByUri')
+            ->willReturn('principals/users/bob');
+        $this->calendarService->expects(self::once())
+            ->method('deleteShare')
+            ->with($shareable->getResourceId(), 'principals/users/bob');
+        $this->calendarService->expects(self::never())
+            ->method('unshare');
+
+        $this->backend->updateShares($shareable, [], $remove, $oldShares);
+    }
+
+    public function testGetShares(): void {
+        $resourceId = 42;
+        $principal = 'principals/groups/bob';
+        $rows = [
+            [
+                'principaluri' => $principal,
+                'access' => Backend::ACCESS_READ,
+            ]
+        ];
+        $expected = [
+            [
+                'href' => 'principal:principals/groups/bob',
+                'commonName' => 'bob',
+                'status' => 1,
+                'readOnly' => true,
+                '{http://owncloud.org/ns}principal' => $principal,
+                '{http://owncloud.org/ns}group-share' => true,
+            ]
+        ];
+
+
+        $this->shareCache->expects(self::once())
+            ->method('get')
+            ->with((string)$resourceId)
+            ->willReturn(null);
+        $this->calendarService->expects(self::once())
+            ->method('getShares')
+            ->with($resourceId)
+            ->willReturn($rows);
+        $this->principalBackend->expects(self::once())
+            ->method('getPrincipalByPath')
+            ->with($principal)
+            ->willReturn(['uri' => $principal, '{DAV:}displayname' => 'bob']);
+        $this->shareCache->expects(self::once())
+            ->method('set')
+            ->with((string)$resourceId, $expected);
+
+        $result = $this->backend->getShares($resourceId);
+        $this->assertEquals($expected, $result);
+    }
+
+    public function testGetSharesAddressbooks(): void {
+        $service = $this->createMock(\OCA\DAV\CardDAV\Sharing\Service::class);
+        $backend = new ContactsSharingBackend(
+            $this->userManager,
+            $this->groupManager,
+            $this->principalBackend,
+            $this->cacheFactory,
+            $service,
+            $this->logger);
+        $resourceId = 42;
+        $principal = 'principals/groups/bob';
+        $rows = [
+            [
+                'principaluri' => $principal,
+                'access' => Backend::ACCESS_READ,
+            ]
+        ];
+        $expected = [
+            [
+                'href' => 'principal:principals/groups/bob',
+                'commonName' => 'bob',
+                'status' => 1,
+                'readOnly' => true,
+                '{http://owncloud.org/ns}principal' => $principal,
+                '{http://owncloud.org/ns}group-share' => true,
+            ]
+        ];
+
+        $this->shareCache->expects(self::once())
+            ->method('get')
+            ->with((string)$resourceId)
+            ->willReturn(null);
+        $service->expects(self::once())
+            ->method('getShares')
+            ->with($resourceId)
+            ->willReturn($rows);
+        $this->principalBackend->expects(self::once())
+            ->method('getPrincipalByPath')
+            ->with($principal)
+            ->willReturn(['uri' => $principal, '{DAV:}displayname' => 'bob']);
+        $this->shareCache->expects(self::once())
+            ->method('set')
+            ->with((string)$resourceId, $expected);
+
+        $result = $backend->getShares($resourceId);
+        $this->assertEquals($expected, $result);
+    }
+
+    public function testPreloadShares(): void {
+        $resourceIds = [42, 99];
+        $rows = [
+            [
+                'resourceid' => 42,
+                'principaluri' => 'principals/groups/bob',
+                'access' => Backend::ACCESS_READ,
+            ],
+            [
+                'resourceid' => 99,
+                'principaluri' => 'principals/users/carlos',
+                'access' => Backend::ACCESS_READ_WRITE,
+            ]
+        ];
+        $principalResults = [
+            ['uri' => 'principals/groups/bob', '{DAV:}displayname' => 'bob'],
+            ['uri' => 'principals/users/carlos', '{DAV:}displayname' => 'carlos'],
+        ];
+
+        $this->shareCache->expects(self::exactly(2))
+            ->method('get')
+            ->willReturn(null);
+        $this->calendarService->expects(self::once())
+            ->method('getSharesForIds')
+            ->with($resourceIds)
+            ->willReturn($rows);
+        $this->principalBackend->expects(self::exactly(2))
+            ->method('getPrincipalByPath')
+            ->willReturnCallback(function (string $principal) use ($principalResults) {
+                switch ($principal) {
+                    case 'principals/groups/bob':
+                        return $principalResults[0];
+                    default:
+                        return $principalResults[1];
+                }
+            });
+        $this->shareCache->expects(self::exactly(2))
+            ->method('set');
+
+        $this->backend->preloadShares($resourceIds);
+    }
 }

Spacing +5 added lines, -5 removed lines

@@ -289,7 +289,7 @@ 
 
 		$this->shareCache->expects(self::once())
 			->method('get')
-			->with((string)$resourceId)
+			->with((string) $resourceId)
 			->willReturn(null);
 		$this->calendarService->expects(self::once())
 			->method('getShares')
@@ -301,7 +301,7 @@ 
 			->willReturn(['uri' => $principal, '{DAV:}displayname' => 'bob']);
 		$this->shareCache->expects(self::once())
 			->method('set')
-			->with((string)$resourceId, $expected);
+			->with((string) $resourceId, $expected);
 
 		$result = $this->backend->getShares($resourceId);
 		$this->assertEquals($expected, $result);
@@ -337,7 +337,7 @@ 
 
 		$this->shareCache->expects(self::once())
 			->method('get')
-			->with((string)$resourceId)
+			->with((string) $resourceId)
 			->willReturn(null);
 		$service->expects(self::once())
 			->method('getShares')
@@ -349,7 +349,7 @@ 
 			->willReturn(['uri' => $principal, '{DAV:}displayname' => 'bob']);
 		$this->shareCache->expects(self::once())
 			->method('set')
-			->with((string)$resourceId, $expected);
+			->with((string) $resourceId, $expected);
 
 		$result = $backend->getShares($resourceId);
 		$this->assertEquals($expected, $result);
@@ -383,7 +383,7 @@ 
 			->willReturn($rows);
 		$this->principalBackend->expects(self::exactly(2))
 			->method('getPrincipalByPath')
-			->willReturnCallback(function (string $principal) use ($principalResults) {
+			->willReturnCallback(function(string $principal) use ($principalResults) {
 				switch ($principal) {
 					case 'principals/groups/bob':
 						return $principalResults[0];