nextcloud / server

apps/dav/tests/unit/Connector/Sabre/BlockLegacyClientPluginTest.php

Indentation +152 added lines, -152 removed lines

@@ -17,9 +17,9 @@ 
 use Test\TestCase;
 
 enum ERROR_TYPE {
-	case MIN_ERROR;
-	case MAX_ERROR;
-	case NONE;
+    case MIN_ERROR;
+    case MAX_ERROR;
+    case NONE;
 }
 
 /**
@@ -29,153 +29,153 @@ 
  */
 class BlockLegacyClientPluginTest extends TestCase {
 
-	private IConfig&MockObject $config;
-	private ThemingDefaults&MockObject $themingDefaults;
-	private BlockLegacyClientPlugin $blockLegacyClientVersionPlugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->createMock(IConfig::class);
-		$this->themingDefaults = $this->createMock(ThemingDefaults::class);
-		$this->blockLegacyClientVersionPlugin = new BlockLegacyClientPlugin(
-			$this->config,
-			$this->themingDefaults,
-		);
-	}
-
-	public static function oldDesktopClientProvider(): array {
-		return [
-			['Mozilla/5.0 (Windows) mirall/1.5.0', ERROR_TYPE::MIN_ERROR],
-			['Mozilla/5.0 (Bogus Text) mirall/1.6.9', ERROR_TYPE::MIN_ERROR],
-			['Mozilla/5.0 (Windows) mirall/2.5.0', ERROR_TYPE::MAX_ERROR],
-			['Mozilla/5.0 (Bogus Text) mirall/2.0.1', ERROR_TYPE::MAX_ERROR],
-			['Mozilla/5.0 (Windows) mirall/2.0.0', ERROR_TYPE::NONE],
-			['Mozilla/5.0 (Bogus Text) mirall/2.0.0', ERROR_TYPE::NONE],
-		];
-	}
-
-	/**
-	 * @dataProvider oldDesktopClientProvider
-	 */
-	public function testBeforeHandlerException(string $userAgent, ERROR_TYPE $errorType): void {
-		$this->themingDefaults
-			->expects($this->atMost(1))
-			->method('getSyncClientUrl')
-			->willReturn('https://nextcloud.com/install/#install-clients');
-
-		$this->config
-			->expects($this->exactly(2))
-			->method('getSystemValueString')
-			->willReturnCallback(function (string $key) {
-				if ($key === 'minimum.supported.desktop.version') {
-					return '1.7.0';
-				}
-				return '2.0.0';
-			});
-
-		if ($errorType !== ERROR_TYPE::NONE) {
-			$errorString = $errorType === ERROR_TYPE::MIN_ERROR
-			? 'This version of the client is unsupported. Upgrade to <a href="https://nextcloud.com/install/#install-clients">version 1.7.0 or later</a>.'
-			: 'This version of the client is unsupported. Downgrade to <a href="https://nextcloud.com/install/#install-clients">version 2.0.0 or earlier</a>.';
-			$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-			$this->expectExceptionMessage($errorString);
-		}
-
-		/** @var RequestInterface|MockObject $request */
-		$request = $this->createMock(RequestInterface::class);
-		$request
-			->expects($this->once())
-			->method('getHeader')
-			->with('User-Agent')
-			->willReturn($userAgent);
-
-		$this->blockLegacyClientVersionPlugin->beforeHandler($request);
-	}
-
-	/**
-	 * Ensure that there is no room for XSS attack through configured URL / version
-	 * @dataProvider oldDesktopClientProvider
-	 */
-	public function testBeforeHandlerExceptionPreventXSSAttack(string $userAgent, ERROR_TYPE $errorType): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-
-		$this->themingDefaults
-			->expects($this->atMost(1))
-			->method('getSyncClientUrl')
-			->willReturn('https://example.com"><script>alter("hacked");</script>');
-
-		$this->config
-			->expects($this->exactly(2))
-			->method('getSystemValueString')
-			->willReturnCallback(function (string $key) {
-				if ($key === 'minimum.supported.desktop.version') {
-					return '1.7.0 <script>alert("unsafe")</script>';
-				}
-				return '2.0.0 <script>alert("unsafe")</script>';
-			});
-
-		$errorString = $errorType === ERROR_TYPE::MIN_ERROR
-			? 'This version of the client is unsupported. Upgrade to <a href="https://example.com&quot;&gt;&lt;script&gt;alter(&quot;hacked&quot;);&lt;/script&gt;">version 1.7.0 &lt;script&gt;alert(&quot;unsafe&quot;)&lt;/script&gt; or later</a>.'
-			: 'This version of the client is unsupported. Downgrade to <a href="https://example.com&quot;&gt;&lt;script&gt;alter(&quot;hacked&quot;);&lt;/script&gt;">version 2.0.0 &lt;script&gt;alert(&quot;unsafe&quot;)&lt;/script&gt; or earlier</a>.';
-		$this->expectExceptionMessage($errorString);
-
-		/** @var RequestInterface|MockObject $request */
-		$request = $this->createMock('\Sabre\HTTP\RequestInterface');
-		$request
-			->expects($this->once())
-			->method('getHeader')
-			->with('User-Agent')
-			->willReturn($userAgent);
-
-		$this->blockLegacyClientVersionPlugin->beforeHandler($request);
-	}
-
-	public static function newAndAlternateDesktopClientProvider(): array {
-		return [
-			['Mozilla/5.0 (Windows) mirall/1.7.0'],
-			['Mozilla/5.0 (Bogus Text) mirall/1.9.3'],
-			['Mozilla/5.0 (Not Our Client But Old Version) LegacySync/1.1.0'],
-			['Mozilla/5.0 (Windows) mirall/4.7.0'],
-			['Mozilla/5.0 (Bogus Text) mirall/3.9.3'],
-			['Mozilla/5.0 (Not Our Client But Old Version) LegacySync/45.0.0'],
-		];
-	}
-
-	/**
-	 * @dataProvider newAndAlternateDesktopClientProvider
-	 */
-	public function testBeforeHandlerSuccess(string $userAgent): void {
-		/** @var RequestInterface|MockObject $request */
-		$request = $this->createMock(RequestInterface::class);
-		$request
-			->expects($this->once())
-			->method('getHeader')
-			->with('User-Agent')
-			->willReturn($userAgent);
-
-		$this->config
-			->expects($this->exactly(2))
-			->method('getSystemValueString')
-			->willReturnCallback(function (string $key) {
-				if ($key === 'minimum.supported.desktop.version') {
-					return '1.7.0';
-				}
-				return '10.0.0';
-			});
-
-		$this->blockLegacyClientVersionPlugin->beforeHandler($request);
-	}
-
-	public function testBeforeHandlerNoUserAgent(): void {
-		/** @var RequestInterface|MockObject $request */
-		$request = $this->createMock(RequestInterface::class);
-		$request
-			->expects($this->once())
-			->method('getHeader')
-			->with('User-Agent')
-			->willReturn(null);
-
-		$this->blockLegacyClientVersionPlugin->beforeHandler($request);
-	}
+    private IConfig&MockObject $config;
+    private ThemingDefaults&MockObject $themingDefaults;
+    private BlockLegacyClientPlugin $blockLegacyClientVersionPlugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->createMock(IConfig::class);
+        $this->themingDefaults = $this->createMock(ThemingDefaults::class);
+        $this->blockLegacyClientVersionPlugin = new BlockLegacyClientPlugin(
+            $this->config,
+            $this->themingDefaults,
+        );
+    }
+
+    public static function oldDesktopClientProvider(): array {
+        return [
+            ['Mozilla/5.0 (Windows) mirall/1.5.0', ERROR_TYPE::MIN_ERROR],
+            ['Mozilla/5.0 (Bogus Text) mirall/1.6.9', ERROR_TYPE::MIN_ERROR],
+            ['Mozilla/5.0 (Windows) mirall/2.5.0', ERROR_TYPE::MAX_ERROR],
+            ['Mozilla/5.0 (Bogus Text) mirall/2.0.1', ERROR_TYPE::MAX_ERROR],
+            ['Mozilla/5.0 (Windows) mirall/2.0.0', ERROR_TYPE::NONE],
+            ['Mozilla/5.0 (Bogus Text) mirall/2.0.0', ERROR_TYPE::NONE],
+        ];
+    }
+
+    /**
+     * @dataProvider oldDesktopClientProvider
+     */
+    public function testBeforeHandlerException(string $userAgent, ERROR_TYPE $errorType): void {
+        $this->themingDefaults
+            ->expects($this->atMost(1))
+            ->method('getSyncClientUrl')
+            ->willReturn('https://nextcloud.com/install/#install-clients');
+
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getSystemValueString')
+            ->willReturnCallback(function (string $key) {
+                if ($key === 'minimum.supported.desktop.version') {
+                    return '1.7.0';
+                }
+                return '2.0.0';
+            });
+
+        if ($errorType !== ERROR_TYPE::NONE) {
+            $errorString = $errorType === ERROR_TYPE::MIN_ERROR
+            ? 'This version of the client is unsupported. Upgrade to <a href="https://nextcloud.com/install/#install-clients">version 1.7.0 or later</a>.'
+            : 'This version of the client is unsupported. Downgrade to <a href="https://nextcloud.com/install/#install-clients">version 2.0.0 or earlier</a>.';
+            $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+            $this->expectExceptionMessage($errorString);
+        }
+
+        /** @var RequestInterface|MockObject $request */
+        $request = $this->createMock(RequestInterface::class);
+        $request
+            ->expects($this->once())
+            ->method('getHeader')
+            ->with('User-Agent')
+            ->willReturn($userAgent);
+
+        $this->blockLegacyClientVersionPlugin->beforeHandler($request);
+    }
+
+    /**
+     * Ensure that there is no room for XSS attack through configured URL / version
+     * @dataProvider oldDesktopClientProvider
+     */
+    public function testBeforeHandlerExceptionPreventXSSAttack(string $userAgent, ERROR_TYPE $errorType): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+
+        $this->themingDefaults
+            ->expects($this->atMost(1))
+            ->method('getSyncClientUrl')
+            ->willReturn('https://example.com"><script>alter("hacked");</script>');
+
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getSystemValueString')
+            ->willReturnCallback(function (string $key) {
+                if ($key === 'minimum.supported.desktop.version') {
+                    return '1.7.0 <script>alert("unsafe")</script>';
+                }
+                return '2.0.0 <script>alert("unsafe")</script>';
+            });
+
+        $errorString = $errorType === ERROR_TYPE::MIN_ERROR
+            ? 'This version of the client is unsupported. Upgrade to <a href="https://example.com&quot;&gt;&lt;script&gt;alter(&quot;hacked&quot;);&lt;/script&gt;">version 1.7.0 &lt;script&gt;alert(&quot;unsafe&quot;)&lt;/script&gt; or later</a>.'
+            : 'This version of the client is unsupported. Downgrade to <a href="https://example.com&quot;&gt;&lt;script&gt;alter(&quot;hacked&quot;);&lt;/script&gt;">version 2.0.0 &lt;script&gt;alert(&quot;unsafe&quot;)&lt;/script&gt; or earlier</a>.';
+        $this->expectExceptionMessage($errorString);
+
+        /** @var RequestInterface|MockObject $request */
+        $request = $this->createMock('\Sabre\HTTP\RequestInterface');
+        $request
+            ->expects($this->once())
+            ->method('getHeader')
+            ->with('User-Agent')
+            ->willReturn($userAgent);
+
+        $this->blockLegacyClientVersionPlugin->beforeHandler($request);
+    }
+
+    public static function newAndAlternateDesktopClientProvider(): array {
+        return [
+            ['Mozilla/5.0 (Windows) mirall/1.7.0'],
+            ['Mozilla/5.0 (Bogus Text) mirall/1.9.3'],
+            ['Mozilla/5.0 (Not Our Client But Old Version) LegacySync/1.1.0'],
+            ['Mozilla/5.0 (Windows) mirall/4.7.0'],
+            ['Mozilla/5.0 (Bogus Text) mirall/3.9.3'],
+            ['Mozilla/5.0 (Not Our Client But Old Version) LegacySync/45.0.0'],
+        ];
+    }
+
+    /**
+     * @dataProvider newAndAlternateDesktopClientProvider
+     */
+    public function testBeforeHandlerSuccess(string $userAgent): void {
+        /** @var RequestInterface|MockObject $request */
+        $request = $this->createMock(RequestInterface::class);
+        $request
+            ->expects($this->once())
+            ->method('getHeader')
+            ->with('User-Agent')
+            ->willReturn($userAgent);
+
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getSystemValueString')
+            ->willReturnCallback(function (string $key) {
+                if ($key === 'minimum.supported.desktop.version') {
+                    return '1.7.0';
+                }
+                return '10.0.0';
+            });
+
+        $this->blockLegacyClientVersionPlugin->beforeHandler($request);
+    }
+
+    public function testBeforeHandlerNoUserAgent(): void {
+        /** @var RequestInterface|MockObject $request */
+        $request = $this->createMock(RequestInterface::class);
+        $request
+            ->expects($this->once())
+            ->method('getHeader')
+            ->with('User-Agent')
+            ->willReturn(null);
+
+        $this->blockLegacyClientVersionPlugin->beforeHandler($request);
+    }
 }

apps/dav/tests/unit/Connector/Sabre/PrincipalTest.php

Indentation +908 added lines, -908 removed lines

@@ -32,912 +32,912 @@
 use Test\TestCase;
 
 class PrincipalTest extends TestCase {
-	private IUserManager&MockObject $userManager;
-	private IGroupManager&MockObject $groupManager;
-	private IAccountManager&MockObject $accountManager;
-	private IManager&MockObject $shareManager;
-	private IUserSession&MockObject $userSession;
-	private IAppManager&MockObject $appManager;
-	private ProxyMapper&MockObject $proxyMapper;
-	private KnownUserService&MockObject $knownUserService;
-	private IConfig&MockObject $config;
-	private IFactory&MockObject $languageFactory;
-	private Principal $connector;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->accountManager = $this->createMock(IAccountManager::class);
-		$this->shareManager = $this->createMock(IManager::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->proxyMapper = $this->createMock(ProxyMapper::class);
-		$this->knownUserService = $this->createMock(KnownUserService::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->languageFactory = $this->createMock(IFactory::class);
-
-		$this->connector = new Principal(
-			$this->userManager,
-			$this->groupManager,
-			$this->accountManager,
-			$this->shareManager,
-			$this->userSession,
-			$this->appManager,
-			$this->proxyMapper,
-			$this->knownUserService,
-			$this->config,
-			$this->languageFactory
-		);
-	}
-
-	public function testGetPrincipalsByPrefixWithoutPrefix(): void {
-		$response = $this->connector->getPrincipalsByPrefix('');
-		$this->assertSame([], $response);
-	}
-
-	public function testGetPrincipalsByPrefixWithUsers(): void {
-		$fooUser = $this->createMock(User::class);
-		$fooUser
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('foo');
-		$fooUser
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('Dr. Foo-Bar');
-		$fooUser
-			->expects($this->once())
-			->method('getSystemEMailAddress')
-			->willReturn('');
-		$barUser = $this->createMock(User::class);
-		$barUser
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('bar');
-		$barUser
-			->expects($this->once())
-			->method('getSystemEMailAddress')
-			->willReturn('bar@nextcloud.com');
-		$this->userManager
-			->expects($this->once())
-			->method('search')
-			->with('')
-			->willReturn([$fooUser, $barUser]);
-
-		$this->languageFactory
-			->expects($this->exactly(2))
-			->method('getUserLanguage')
-			->willReturnMap([
-				[$fooUser, 'de'],
-				[$barUser, 'en'],
-			]);
-
-		$fooAccountPropertyCollection = $this->createMock(IAccountPropertyCollection::class);
-		$fooAccountPropertyCollection->expects($this->once())
-			->method('getProperties')
-			->willReturn([]);
-		$fooAccount = $this->createMock(IAccount::class);
-		$fooAccount->expects($this->once())
-			->method('getPropertyCollection')
-			->with(IAccountManager::COLLECTION_EMAIL)
-			->willReturn($fooAccountPropertyCollection);
-
-		$emailPropertyOne = $this->createMock(IAccountProperty::class);
-		$emailPropertyOne->expects($this->once())
-			->method('getValue')
-			->willReturn('alias@nextcloud.com');
-		$emailPropertyTwo = $this->createMock(IAccountProperty::class);
-		$emailPropertyTwo->expects($this->once())
-			->method('getValue')
-			->willReturn('alias2@nextcloud.com');
-
-		$barAccountPropertyCollection = $this->createMock(IAccountPropertyCollection::class);
-		$barAccountPropertyCollection->expects($this->once())
-			->method('getProperties')
-			->willReturn([$emailPropertyOne, $emailPropertyTwo]);
-		$barAccount = $this->createMock(IAccount::class);
-		$barAccount->expects($this->once())
-			->method('getPropertyCollection')
-			->with(IAccountManager::COLLECTION_EMAIL)
-			->willReturn($barAccountPropertyCollection);
-
-		$this->accountManager
-			->expects($this->exactly(2))
-			->method('getAccount')
-			->willReturnMap([
-				[$fooUser, $fooAccount],
-				[$barUser, $barAccount],
-			]);
-
-		$expectedResponse = [
-			0 => [
-				'uri' => 'principals/users/foo',
-				'{DAV:}displayname' => 'Dr. Foo-Bar',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'INDIVIDUAL',
-				'{http://nextcloud.com/ns}language' => 'de',
-			],
-			1 => [
-				'uri' => 'principals/users/bar',
-				'{DAV:}displayname' => 'bar',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'INDIVIDUAL',
-				'{http://nextcloud.com/ns}language' => 'en',
-				'{http://sabredav.org/ns}email-address' => 'bar@nextcloud.com',
-				'{DAV:}alternate-URI-set' => ['mailto:alias@nextcloud.com', 'mailto:alias2@nextcloud.com']
-			]
-		];
-		$response = $this->connector->getPrincipalsByPrefix('principals/users');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetPrincipalsByPrefixEmpty(): void {
-		$this->userManager
-			->expects($this->once())
-			->method('search')
-			->with('')
-			->willReturn([]);
-
-		$response = $this->connector->getPrincipalsByPrefix('principals/users');
-		$this->assertSame([], $response);
-	}
-
-	public function testGetPrincipalsByPathWithoutMail(): void {
-		$fooUser = $this->createMock(User::class);
-		$fooUser
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('foo');
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn($fooUser);
-
-		$this->languageFactory
-			->expects($this->once())
-			->method('getUserLanguage')
-			->with($fooUser)
-			->willReturn('de');
-
-		$expectedResponse = [
-			'uri' => 'principals/users/foo',
-			'{DAV:}displayname' => 'foo',
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'INDIVIDUAL',
-			'{http://nextcloud.com/ns}language' => 'de'
-		];
-		$response = $this->connector->getPrincipalByPath('principals/users/foo');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetPrincipalsByPathWithMail(): void {
-		$fooUser = $this->createMock(User::class);
-		$fooUser
-			->expects($this->once())
-			->method('getSystemEMailAddress')
-			->willReturn('foo@nextcloud.com');
-		$fooUser
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('foo');
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn($fooUser);
-
-		$this->languageFactory
-			->expects($this->once())
-			->method('getUserLanguage')
-			->with($fooUser)
-			->willReturn('de');
-
-		$expectedResponse = [
-			'uri' => 'principals/users/foo',
-			'{DAV:}displayname' => 'foo',
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'INDIVIDUAL',
-			'{http://nextcloud.com/ns}language' => 'de',
-			'{http://sabredav.org/ns}email-address' => 'foo@nextcloud.com',
-		];
-		$response = $this->connector->getPrincipalByPath('principals/users/foo');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetPrincipalsByPathEmpty(): void {
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn(null);
-
-		$response = $this->connector->getPrincipalByPath('principals/users/foo');
-		$this->assertNull($response);
-	}
-
-	public function testGetGroupMemberSet(): void {
-		$response = $this->connector->getGroupMemberSet('principals/users/foo');
-		$this->assertSame([], $response);
-	}
-
-
-	public function testGetGroupMemberSetEmpty(): void {
-		$this->expectException(Exception::class);
-		$this->expectExceptionMessage('Principal not found');
-
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn(null);
-
-		$this->connector->getGroupMemberSet('principals/users/foo/calendar-proxy-read');
-	}
-
-	public function testGetGroupMemberSetProxyRead(): void {
-		$fooUser = $this->createMock(User::class);
-		$fooUser
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('foo');
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn($fooUser);
-
-		$proxy1 = new Proxy();
-		$proxy1->setProxyId('proxyId1');
-		$proxy1->setPermissions(1);
-
-		$proxy2 = new Proxy();
-		$proxy2->setProxyId('proxyId2');
-		$proxy2->setPermissions(3);
-
-		$proxy3 = new Proxy();
-		$proxy3->setProxyId('proxyId3');
-		$proxy3->setPermissions(3);
-
-		$this->proxyMapper->expects($this->once())
-			->method('getProxiesOf')
-			->with('principals/users/foo')
-			->willReturn([$proxy1, $proxy2, $proxy3]);
-
-		$this->assertEquals(['proxyId1'], $this->connector->getGroupMemberSet('principals/users/foo/calendar-proxy-read'));
-	}
-
-	public function testGetGroupMemberSetProxyWrite(): void {
-		$fooUser = $this->createMock(User::class);
-		$fooUser
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('foo');
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn($fooUser);
-
-		$proxy1 = new Proxy();
-		$proxy1->setProxyId('proxyId1');
-		$proxy1->setPermissions(1);
-
-		$proxy2 = new Proxy();
-		$proxy2->setProxyId('proxyId2');
-		$proxy2->setPermissions(3);
-
-		$proxy3 = new Proxy();
-		$proxy3->setProxyId('proxyId3');
-		$proxy3->setPermissions(3);
-
-		$this->proxyMapper->expects($this->once())
-			->method('getProxiesOf')
-			->with('principals/users/foo')
-			->willReturn([$proxy1, $proxy2, $proxy3]);
-
-		$this->assertEquals(['proxyId2', 'proxyId3'], $this->connector->getGroupMemberSet('principals/users/foo/calendar-proxy-write'));
-	}
-
-	public function testGetGroupMembership(): void {
-		$fooUser = $this->createMock(User::class);
-		$group1 = $this->createMock(IGroup::class);
-		$group1->expects($this->once())
-			->method('getGID')
-			->willReturn('group1');
-		$group2 = $this->createMock(IGroup::class);
-		$group2->expects($this->once())
-			->method('getGID')
-			->willReturn('foo/bar');
-		$this->userManager
-			->expects($this->exactly(2))
-			->method('get')
-			->with('foo')
-			->willReturn($fooUser);
-		$this->groupManager
-			->expects($this->once())
-			->method('getUserGroups')
-			->with($fooUser)
-			->willReturn([
-				$group1,
-				$group2,
-			]);
-
-		$proxy1 = new Proxy();
-		$proxy1->setOwnerId('proxyId1');
-		$proxy1->setPermissions(1);
-
-		$proxy2 = new Proxy();
-		$proxy2->setOwnerId('proxyId2');
-		$proxy2->setPermissions(3);
-
-		$this->proxyMapper->expects($this->once())
-			->method('getProxiesFor')
-			->with('principals/users/foo')
-			->willReturn([$proxy1, $proxy2]);
-
-		$expectedResponse = [
-			'principals/groups/group1',
-			'principals/groups/foo%2Fbar',
-			'proxyId1/calendar-proxy-read',
-			'proxyId2/calendar-proxy-write',
-		];
-		$response = $this->connector->getGroupMembership('principals/users/foo');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-
-	public function testGetGroupMembershipEmpty(): void {
-		$this->expectException(Exception::class);
-		$this->expectExceptionMessage('Principal not found');
-
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn(null);
-
-		$this->connector->getGroupMembership('principals/users/foo');
-	}
-
-
-	public function testSetGroupMembership(): void {
-		$this->expectException(Exception::class);
-		$this->expectExceptionMessage('Setting members of the group is not supported yet');
-
-		$this->connector->setGroupMemberSet('principals/users/foo', ['foo']);
-	}
-
-	public function testSetGroupMembershipProxy(): void {
-		$fooUser = $this->createMock(User::class);
-		$fooUser
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('foo');
-		$barUser = $this->createMock(User::class);
-		$barUser
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('bar');
-		$this->userManager
-			->expects($this->exactly(2))
-			->method('get')
-			->willReturnMap([
-				['foo', $fooUser],
-				['bar', $barUser],
-			]);
-
-		$this->proxyMapper->expects($this->once())
-			->method('getProxiesOf')
-			->with('principals/users/foo')
-			->willReturn([]);
-
-		$this->proxyMapper->expects($this->once())
-			->method('insert')
-			->with($this->callback(function ($proxy) {
-				/** @var Proxy $proxy */
-				if ($proxy->getOwnerId() !== 'principals/users/foo') {
-					return false;
-				}
-				if ($proxy->getProxyId() !== 'principals/users/bar') {
-					return false;
-				}
-				if ($proxy->getPermissions() !== 3) {
-					return false;
-				}
-
-				return true;
-			}));
-
-		$this->connector->setGroupMemberSet('principals/users/foo/calendar-proxy-write', ['principals/users/bar']);
-	}
-
-	public function testUpdatePrincipal(): void {
-		$this->assertSame(0, $this->connector->updatePrincipal('foo', new PropPatch([])));
-	}
-
-	public function testSearchPrincipalsWithEmptySearchProperties(): void {
-		$this->assertSame([], $this->connector->searchPrincipals('principals/users', []));
-	}
-
-	public function testSearchPrincipalsWithWrongPrefixPath(): void {
-		$this->assertSame([], $this->connector->searchPrincipals('principals/groups',
-			['{http://sabredav.org/ns}email-address' => 'foo']));
-	}
-
-	/**
-	 * @dataProvider searchPrincipalsDataProvider
-	 */
-	public function testSearchPrincipals(bool $sharingEnabled, bool $groupsOnly, string $test, array $result): void {
-		$this->shareManager->expects($this->once())
-			->method('shareAPIEnabled')
-			->willReturn($sharingEnabled);
-
-		$getUserGroupIdsReturnMap = [];
-
-		if ($sharingEnabled) {
-			$this->shareManager->expects($this->once())
-				->method('allowEnumeration')
-				->willReturn(true);
-
-			$this->shareManager->expects($this->once())
-				->method('shareWithGroupMembersOnly')
-				->willReturn($groupsOnly);
-
-			if ($groupsOnly) {
-				$user = $this->createMock(IUser::class);
-				$this->userSession->expects($this->atLeastOnce())
-					->method('getUser')
-					->willReturn($user);
-
-				$getUserGroupIdsReturnMap[] = [$user, ['group1', 'group2', 'group5']];
-			}
-		} else {
-			$this->config->expects($this->never())
-				->method('getAppValue');
-			$this->shareManager->expects($this->never())
-				->method('shareWithGroupMembersOnly');
-			$this->groupManager->expects($this->never())
-				->method($this->anything());
-		}
-
-		$user2 = $this->createMock(IUser::class);
-		$user2->method('getUID')->willReturn('user2');
-		$user3 = $this->createMock(IUser::class);
-		$user3->method('getUID')->willReturn('user3');
-		$user4 = $this->createMock(IUser::class);
-		$user4->method('getUID')->willReturn('user4');
-
-		if ($sharingEnabled) {
-			$this->userManager->expects($this->once())
-				->method('getByEmail')
-				->with('user@example.com')
-				->willReturn([$user2, $user3]);
-
-			$this->userManager->expects($this->once())
-				->method('searchDisplayName')
-				->with('User 12')
-				->willReturn([$user3, $user4]);
-		} else {
-			$this->userManager->expects($this->never())
-				->method('getByEmail');
-
-			$this->userManager->expects($this->never())
-				->method('searchDisplayName');
-		}
-
-		if ($sharingEnabled && $groupsOnly) {
-			$getUserGroupIdsReturnMap[] = [$user2, ['group1', 'group3']];
-			$getUserGroupIdsReturnMap[] = [$user3, ['group3', 'group4']];
-			$getUserGroupIdsReturnMap[] = [$user4, ['group4', 'group5']];
-		}
-
-		$this->groupManager->expects($this->any())
-			->method('getUserGroupIds')
-			->willReturnMap($getUserGroupIdsReturnMap);
-
-
-		$this->assertEquals($result, $this->connector->searchPrincipals('principals/users',
-			['{http://sabredav.org/ns}email-address' => 'user@example.com',
-				'{DAV:}displayname' => 'User 12'], $test));
-	}
-
-	public static function searchPrincipalsDataProvider(): array {
-		return [
-			[true, false, 'allof', ['principals/users/user3']],
-			[true, false, 'anyof', ['principals/users/user2', 'principals/users/user3', 'principals/users/user4']],
-			[true, true, 'allof', []],
-			[true, true, 'anyof', ['principals/users/user2', 'principals/users/user4']],
-			[false, false, 'allof', []],
-			[false, false, 'anyof', []],
-		];
-	}
-
-	public function testSearchPrincipalByCalendarUserAddressSet(): void {
-		$this->shareManager->expects($this->exactly(2))
-			->method('shareAPIEnabled')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->exactly(2))
-			->method('allowEnumeration')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->exactly(2))
-			->method('shareWithGroupMembersOnly')
-			->willReturn(false);
-
-		$user2 = $this->createMock(IUser::class);
-		$user2->method('getUID')->willReturn('user2');
-		$user3 = $this->createMock(IUser::class);
-		$user3->method('getUID')->willReturn('user3');
-
-		$this->userManager->expects($this->once())
-			->method('getByEmail')
-			->with('user@example.com')
-			->willReturn([$user2, $user3]);
-
-		$this->assertEquals([
-			'principals/users/user2',
-			'principals/users/user3',
-		], $this->connector->searchPrincipals('principals/users',
-			['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => 'user@example.com']));
-	}
-
-	public function testSearchPrincipalWithEnumerationDisabledDisplayname(): void {
-		$this->shareManager->expects($this->once())
-			->method('shareAPIEnabled')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('allowEnumeration')
-			->willReturn(false);
-
-		$this->shareManager->expects($this->once())
-			->method('shareWithGroupMembersOnly')
-			->willReturn(false);
-
-		$this->shareManager->expects($this->once())
-			->method('allowEnumerationFullMatch')
-			->willReturn(true);
-
-		$user2 = $this->createMock(IUser::class);
-		$user2->method('getUID')->willReturn('user2');
-		$user2->method('getDisplayName')->willReturn('User 2');
-		$user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar');
-		$user3 = $this->createMock(IUser::class);
-		$user3->method('getUID')->willReturn('user3');
-		$user3->method('getDisplayName')->willReturn('User 22');
-		$user3->method('getSystemEMailAddress')->willReturn('user2@foo.bar123');
-		$user4 = $this->createMock(IUser::class);
-		$user4->method('getUID')->willReturn('user4');
-		$user4->method('getDisplayName')->willReturn('User 222');
-		$user4->method('getSystemEMailAddress')->willReturn('user2@foo.bar456');
-
-		$this->userManager->expects($this->once())
-			->method('searchDisplayName')
-			->with('User 2')
-			->willReturn([$user2, $user3, $user4]);
-
-		$this->assertEquals(['principals/users/user2'], $this->connector->searchPrincipals('principals/users',
-			['{DAV:}displayname' => 'User 2']));
-	}
-
-	public function testSearchPrincipalWithEnumerationDisabledDisplaynameOnFullMatch(): void {
-		$this->shareManager->expects($this->once())
-			->method('shareAPIEnabled')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('allowEnumeration')
-			->willReturn(false);
-
-		$this->shareManager->expects($this->once())
-			->method('shareWithGroupMembersOnly')
-			->willReturn(false);
-
-		$this->shareManager->expects($this->once())
-			->method('allowEnumerationFullMatch')
-			->willReturn(false);
-
-		$this->assertEquals([], $this->connector->searchPrincipals('principals/users',
-			['{DAV:}displayname' => 'User 2']));
-	}
-
-	public function testSearchPrincipalWithEnumerationDisabledEmail(): void {
-		$this->shareManager->expects($this->once())
-			->method('shareAPIEnabled')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('allowEnumeration')
-			->willReturn(false);
-
-		$this->shareManager->expects($this->once())
-			->method('shareWithGroupMembersOnly')
-			->willReturn(false);
-
-		$this->shareManager->expects($this->once())
-			->method('allowEnumerationFullMatch')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('matchEmail')
-			->willReturn(true);
-
-		$user2 = $this->createMock(IUser::class);
-		$user2->method('getUID')->willReturn('user2');
-		$user2->method('getDisplayName')->willReturn('User 2');
-		$user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar');
-		$user3 = $this->createMock(IUser::class);
-		$user3->method('getUID')->willReturn('user3');
-		$user2->method('getDisplayName')->willReturn('User 22');
-		$user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar123');
-		$user4 = $this->createMock(IUser::class);
-		$user4->method('getUID')->willReturn('user4');
-		$user2->method('getDisplayName')->willReturn('User 222');
-		$user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar456');
-
-		$this->userManager->expects($this->once())
-			->method('getByEmail')
-			->with('user2@foo.bar')
-			->willReturn([$user2]);
-
-		$this->assertEquals(['principals/users/user2'], $this->connector->searchPrincipals('principals/users',
-			['{http://sabredav.org/ns}email-address' => 'user2@foo.bar']));
-	}
-
-	public function testSearchPrincipalWithEnumerationDisabledEmailOnFullMatch(): void {
-		$this->shareManager->expects($this->once())
-			->method('shareAPIEnabled')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('allowEnumeration')
-			->willReturn(false);
-
-		$this->shareManager->expects($this->once())
-			->method('shareWithGroupMembersOnly')
-			->willReturn(false);
-
-		$this->shareManager->expects($this->once())
-			->method('allowEnumerationFullMatch')
-			->willReturn(false);
-
-
-		$this->assertEquals([], $this->connector->searchPrincipals('principals/users',
-			['{http://sabredav.org/ns}email-address' => 'user2@foo.bar']));
-	}
-
-	public function testSearchPrincipalWithEnumerationLimitedDisplayname(): void {
-		$this->shareManager->expects($this->once())
-			->method('shareAPIEnabled')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('allowEnumeration')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('limitEnumerationToGroups')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('shareWithGroupMembersOnly')
-			->willReturn(false);
-
-		$user2 = $this->createMock(IUser::class);
-		$user2->method('getUID')->willReturn('user2');
-		$user2->method('getDisplayName')->willReturn('User 2');
-		$user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar');
-		$user3 = $this->createMock(IUser::class);
-		$user3->method('getUID')->willReturn('user3');
-		$user3->method('getDisplayName')->willReturn('User 22');
-		$user3->method('getSystemEMailAddress')->willReturn('user2@foo.bar123');
-		$user4 = $this->createMock(IUser::class);
-		$user4->method('getUID')->willReturn('user4');
-		$user4->method('getDisplayName')->willReturn('User 222');
-		$user4->method('getSystemEMailAddress')->willReturn('user2@foo.bar456');
-
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user2);
-
-		$this->groupManager->expects($this->exactly(4))
-			->method('getUserGroupIds')
-			->willReturnMap([
-				[$user2, ['group1']],
-				[$user3, ['group1']],
-				[$user4, ['group2']],
-			]);
-
-		$this->userManager->expects($this->once())
-			->method('searchDisplayName')
-			->with('User')
-			->willReturn([$user2, $user3, $user4]);
-
-
-		$this->assertEquals([
-			'principals/users/user2',
-			'principals/users/user3',
-		], $this->connector->searchPrincipals('principals/users',
-			['{DAV:}displayname' => 'User']));
-	}
-
-	public function testSearchPrincipalWithEnumerationLimitedMail(): void {
-		$this->shareManager->expects($this->once())
-			->method('shareAPIEnabled')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('allowEnumeration')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('limitEnumerationToGroups')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('shareWithGroupMembersOnly')
-			->willReturn(false);
-
-		$user2 = $this->createMock(IUser::class);
-		$user2->method('getUID')->willReturn('user2');
-		$user2->method('getDisplayName')->willReturn('User 2');
-		$user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar');
-		$user3 = $this->createMock(IUser::class);
-		$user3->method('getUID')->willReturn('user3');
-		$user3->method('getDisplayName')->willReturn('User 22');
-		$user3->method('getSystemEMailAddress')->willReturn('user2@foo.bar123');
-		$user4 = $this->createMock(IUser::class);
-		$user4->method('getUID')->willReturn('user4');
-		$user4->method('getDisplayName')->willReturn('User 222');
-		$user4->method('getSystemEMailAddress')->willReturn('user2@foo.bar456');
-
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user2);
-
-		$this->groupManager->expects($this->exactly(4))
-			->method('getUserGroupIds')
-			->willReturnMap([
-				[$user2, ['group1']],
-				[$user3, ['group1']],
-				[$user4, ['group2']],
-			]);
-
-		$this->userManager->expects($this->once())
-			->method('getByEmail')
-			->with('user')
-			->willReturn([$user2, $user3, $user4]);
-
-
-		$this->assertEquals([
-			'principals/users/user2',
-			'principals/users/user3'
-		], $this->connector->searchPrincipals('principals/users',
-			['{http://sabredav.org/ns}email-address' => 'user']));
-	}
-
-	public function testFindByUriSharingApiDisabled(): void {
-		$this->shareManager->expects($this->once())
-			->method('shareApiEnabled')
-			->willReturn(false);
-
-		$this->assertEquals(null, $this->connector->findByUri('mailto:user@foo.com', 'principals/users'));
-	}
-
-	/**
-	 * @dataProvider findByUriWithGroupRestrictionDataProvider
-	 */
-	public function testFindByUriWithGroupRestriction(string $uri, string $email, ?string $expects): void {
-		$this->shareManager->expects($this->once())
-			->method('shareApiEnabled')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('shareWithGroupMembersOnly')
-			->willReturn(true);
-
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-
-		$user2 = $this->createMock(IUser::class);
-		$user2->method('getUID')->willReturn('user2');
-		$user3 = $this->createMock(IUser::class);
-		$user3->method('getUID')->willReturn('user3');
-
-		$this->userManager->expects($this->once())
-			->method('getByEmail')
-			->with($email)
-			->willReturn([$email === 'user2@foo.bar' ? $user2 : $user3]);
-
-		if ($email === 'user2@foo.bar') {
-			$this->groupManager->expects($this->exactly(2))
-				->method('getUserGroupIds')
-				->willReturnMap([
-					[$user, ['group1', 'group2']],
-					[$user2, ['group1', 'group3']],
-				]);
-		} else {
-			$this->groupManager->expects($this->exactly(2))
-				->method('getUserGroupIds')
-				->willReturnMap([
-					[$user, ['group1', 'group2']],
-					[$user3, ['group3', 'group3']],
-				]);
-		}
-
-		$this->assertEquals($expects, $this->connector->findByUri($uri, 'principals/users'));
-	}
-
-	public static function findByUriWithGroupRestrictionDataProvider(): array {
-		return [
-			['mailto:user2@foo.bar', 'user2@foo.bar', 'principals/users/user2'],
-			['mailto:user3@foo.bar', 'user3@foo.bar', null],
-		];
-	}
-
-	/**
-	 * @dataProvider findByUriWithoutGroupRestrictionDataProvider
-	 */
-	public function testFindByUriWithoutGroupRestriction(string $uri, string $email, string $expects): void {
-		$this->shareManager->expects($this->once())
-			->method('shareApiEnabled')
-			->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('shareWithGroupMembersOnly')
-			->willReturn(false);
-
-		$user2 = $this->createMock(IUser::class);
-		$user2->method('getUID')->willReturn('user2');
-		$user3 = $this->createMock(IUser::class);
-		$user3->method('getUID')->willReturn('user3');
-
-		$this->userManager->expects($this->once())
-			->method('getByEmail')
-			->with($email)
-			->willReturn([$email === 'user2@foo.bar' ? $user2 : $user3]);
-
-		$this->assertEquals($expects, $this->connector->findByUri($uri, 'principals/users'));
-	}
-
-	public static function findByUriWithoutGroupRestrictionDataProvider(): array {
-		return [
-			['mailto:user2@foo.bar', 'user2@foo.bar', 'principals/users/user2'],
-			['mailto:user3@foo.bar', 'user3@foo.bar', 'principals/users/user3'],
-		];
-	}
-
-	public function testGetEmailAddressesOfPrincipal(): void {
-		$principal = [
-			'{http://sabredav.org/ns}email-address' => 'bar@company.org',
-			'{DAV:}alternate-URI-set' => [
-				'/some/url',
-				'mailto:foo@bar.com',
-				'mailto:duplicate@example.com',
-			],
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => [
-				'mailto:bernard@example.com',
-				'mailto:bernard.desruisseaux@example.com',
-			],
-			'{http://calendarserver.org/ns/}email-address-set' => [
-				'mailto:duplicate@example.com',
-				'mailto:user@some.org',
-			],
-		];
-
-		$expected = [
-			'bar@company.org',
-			'foo@bar.com',
-			'duplicate@example.com',
-			'bernard@example.com',
-			'bernard.desruisseaux@example.com',
-			'user@some.org',
-		];
-		$actual = $this->connector->getEmailAddressesOfPrincipal($principal);
-		$this->assertEquals($expected, $actual);
-	}
+    private IUserManager&MockObject $userManager;
+    private IGroupManager&MockObject $groupManager;
+    private IAccountManager&MockObject $accountManager;
+    private IManager&MockObject $shareManager;
+    private IUserSession&MockObject $userSession;
+    private IAppManager&MockObject $appManager;
+    private ProxyMapper&MockObject $proxyMapper;
+    private KnownUserService&MockObject $knownUserService;
+    private IConfig&MockObject $config;
+    private IFactory&MockObject $languageFactory;
+    private Principal $connector;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->accountManager = $this->createMock(IAccountManager::class);
+        $this->shareManager = $this->createMock(IManager::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->proxyMapper = $this->createMock(ProxyMapper::class);
+        $this->knownUserService = $this->createMock(KnownUserService::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->languageFactory = $this->createMock(IFactory::class);
+
+        $this->connector = new Principal(
+            $this->userManager,
+            $this->groupManager,
+            $this->accountManager,
+            $this->shareManager,
+            $this->userSession,
+            $this->appManager,
+            $this->proxyMapper,
+            $this->knownUserService,
+            $this->config,
+            $this->languageFactory
+        );
+    }
+
+    public function testGetPrincipalsByPrefixWithoutPrefix(): void {
+        $response = $this->connector->getPrincipalsByPrefix('');
+        $this->assertSame([], $response);
+    }
+
+    public function testGetPrincipalsByPrefixWithUsers(): void {
+        $fooUser = $this->createMock(User::class);
+        $fooUser
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('foo');
+        $fooUser
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('Dr. Foo-Bar');
+        $fooUser
+            ->expects($this->once())
+            ->method('getSystemEMailAddress')
+            ->willReturn('');
+        $barUser = $this->createMock(User::class);
+        $barUser
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('bar');
+        $barUser
+            ->expects($this->once())
+            ->method('getSystemEMailAddress')
+            ->willReturn('bar@nextcloud.com');
+        $this->userManager
+            ->expects($this->once())
+            ->method('search')
+            ->with('')
+            ->willReturn([$fooUser, $barUser]);
+
+        $this->languageFactory
+            ->expects($this->exactly(2))
+            ->method('getUserLanguage')
+            ->willReturnMap([
+                [$fooUser, 'de'],
+                [$barUser, 'en'],
+            ]);
+
+        $fooAccountPropertyCollection = $this->createMock(IAccountPropertyCollection::class);
+        $fooAccountPropertyCollection->expects($this->once())
+            ->method('getProperties')
+            ->willReturn([]);
+        $fooAccount = $this->createMock(IAccount::class);
+        $fooAccount->expects($this->once())
+            ->method('getPropertyCollection')
+            ->with(IAccountManager::COLLECTION_EMAIL)
+            ->willReturn($fooAccountPropertyCollection);
+
+        $emailPropertyOne = $this->createMock(IAccountProperty::class);
+        $emailPropertyOne->expects($this->once())
+            ->method('getValue')
+            ->willReturn('alias@nextcloud.com');
+        $emailPropertyTwo = $this->createMock(IAccountProperty::class);
+        $emailPropertyTwo->expects($this->once())
+            ->method('getValue')
+            ->willReturn('alias2@nextcloud.com');
+
+        $barAccountPropertyCollection = $this->createMock(IAccountPropertyCollection::class);
+        $barAccountPropertyCollection->expects($this->once())
+            ->method('getProperties')
+            ->willReturn([$emailPropertyOne, $emailPropertyTwo]);
+        $barAccount = $this->createMock(IAccount::class);
+        $barAccount->expects($this->once())
+            ->method('getPropertyCollection')
+            ->with(IAccountManager::COLLECTION_EMAIL)
+            ->willReturn($barAccountPropertyCollection);
+
+        $this->accountManager
+            ->expects($this->exactly(2))
+            ->method('getAccount')
+            ->willReturnMap([
+                [$fooUser, $fooAccount],
+                [$barUser, $barAccount],
+            ]);
+
+        $expectedResponse = [
+            0 => [
+                'uri' => 'principals/users/foo',
+                '{DAV:}displayname' => 'Dr. Foo-Bar',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'INDIVIDUAL',
+                '{http://nextcloud.com/ns}language' => 'de',
+            ],
+            1 => [
+                'uri' => 'principals/users/bar',
+                '{DAV:}displayname' => 'bar',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'INDIVIDUAL',
+                '{http://nextcloud.com/ns}language' => 'en',
+                '{http://sabredav.org/ns}email-address' => 'bar@nextcloud.com',
+                '{DAV:}alternate-URI-set' => ['mailto:alias@nextcloud.com', 'mailto:alias2@nextcloud.com']
+            ]
+        ];
+        $response = $this->connector->getPrincipalsByPrefix('principals/users');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetPrincipalsByPrefixEmpty(): void {
+        $this->userManager
+            ->expects($this->once())
+            ->method('search')
+            ->with('')
+            ->willReturn([]);
+
+        $response = $this->connector->getPrincipalsByPrefix('principals/users');
+        $this->assertSame([], $response);
+    }
+
+    public function testGetPrincipalsByPathWithoutMail(): void {
+        $fooUser = $this->createMock(User::class);
+        $fooUser
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('foo');
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn($fooUser);
+
+        $this->languageFactory
+            ->expects($this->once())
+            ->method('getUserLanguage')
+            ->with($fooUser)
+            ->willReturn('de');
+
+        $expectedResponse = [
+            'uri' => 'principals/users/foo',
+            '{DAV:}displayname' => 'foo',
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'INDIVIDUAL',
+            '{http://nextcloud.com/ns}language' => 'de'
+        ];
+        $response = $this->connector->getPrincipalByPath('principals/users/foo');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetPrincipalsByPathWithMail(): void {
+        $fooUser = $this->createMock(User::class);
+        $fooUser
+            ->expects($this->once())
+            ->method('getSystemEMailAddress')
+            ->willReturn('foo@nextcloud.com');
+        $fooUser
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('foo');
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn($fooUser);
+
+        $this->languageFactory
+            ->expects($this->once())
+            ->method('getUserLanguage')
+            ->with($fooUser)
+            ->willReturn('de');
+
+        $expectedResponse = [
+            'uri' => 'principals/users/foo',
+            '{DAV:}displayname' => 'foo',
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'INDIVIDUAL',
+            '{http://nextcloud.com/ns}language' => 'de',
+            '{http://sabredav.org/ns}email-address' => 'foo@nextcloud.com',
+        ];
+        $response = $this->connector->getPrincipalByPath('principals/users/foo');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetPrincipalsByPathEmpty(): void {
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn(null);
+
+        $response = $this->connector->getPrincipalByPath('principals/users/foo');
+        $this->assertNull($response);
+    }
+
+    public function testGetGroupMemberSet(): void {
+        $response = $this->connector->getGroupMemberSet('principals/users/foo');
+        $this->assertSame([], $response);
+    }
+
+
+    public function testGetGroupMemberSetEmpty(): void {
+        $this->expectException(Exception::class);
+        $this->expectExceptionMessage('Principal not found');
+
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn(null);
+
+        $this->connector->getGroupMemberSet('principals/users/foo/calendar-proxy-read');
+    }
+
+    public function testGetGroupMemberSetProxyRead(): void {
+        $fooUser = $this->createMock(User::class);
+        $fooUser
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('foo');
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn($fooUser);
+
+        $proxy1 = new Proxy();
+        $proxy1->setProxyId('proxyId1');
+        $proxy1->setPermissions(1);
+
+        $proxy2 = new Proxy();
+        $proxy2->setProxyId('proxyId2');
+        $proxy2->setPermissions(3);
+
+        $proxy3 = new Proxy();
+        $proxy3->setProxyId('proxyId3');
+        $proxy3->setPermissions(3);
+
+        $this->proxyMapper->expects($this->once())
+            ->method('getProxiesOf')
+            ->with('principals/users/foo')
+            ->willReturn([$proxy1, $proxy2, $proxy3]);
+
+        $this->assertEquals(['proxyId1'], $this->connector->getGroupMemberSet('principals/users/foo/calendar-proxy-read'));
+    }
+
+    public function testGetGroupMemberSetProxyWrite(): void {
+        $fooUser = $this->createMock(User::class);
+        $fooUser
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('foo');
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn($fooUser);
+
+        $proxy1 = new Proxy();
+        $proxy1->setProxyId('proxyId1');
+        $proxy1->setPermissions(1);
+
+        $proxy2 = new Proxy();
+        $proxy2->setProxyId('proxyId2');
+        $proxy2->setPermissions(3);
+
+        $proxy3 = new Proxy();
+        $proxy3->setProxyId('proxyId3');
+        $proxy3->setPermissions(3);
+
+        $this->proxyMapper->expects($this->once())
+            ->method('getProxiesOf')
+            ->with('principals/users/foo')
+            ->willReturn([$proxy1, $proxy2, $proxy3]);
+
+        $this->assertEquals(['proxyId2', 'proxyId3'], $this->connector->getGroupMemberSet('principals/users/foo/calendar-proxy-write'));
+    }
+
+    public function testGetGroupMembership(): void {
+        $fooUser = $this->createMock(User::class);
+        $group1 = $this->createMock(IGroup::class);
+        $group1->expects($this->once())
+            ->method('getGID')
+            ->willReturn('group1');
+        $group2 = $this->createMock(IGroup::class);
+        $group2->expects($this->once())
+            ->method('getGID')
+            ->willReturn('foo/bar');
+        $this->userManager
+            ->expects($this->exactly(2))
+            ->method('get')
+            ->with('foo')
+            ->willReturn($fooUser);
+        $this->groupManager
+            ->expects($this->once())
+            ->method('getUserGroups')
+            ->with($fooUser)
+            ->willReturn([
+                $group1,
+                $group2,
+            ]);
+
+        $proxy1 = new Proxy();
+        $proxy1->setOwnerId('proxyId1');
+        $proxy1->setPermissions(1);
+
+        $proxy2 = new Proxy();
+        $proxy2->setOwnerId('proxyId2');
+        $proxy2->setPermissions(3);
+
+        $this->proxyMapper->expects($this->once())
+            ->method('getProxiesFor')
+            ->with('principals/users/foo')
+            ->willReturn([$proxy1, $proxy2]);
+
+        $expectedResponse = [
+            'principals/groups/group1',
+            'principals/groups/foo%2Fbar',
+            'proxyId1/calendar-proxy-read',
+            'proxyId2/calendar-proxy-write',
+        ];
+        $response = $this->connector->getGroupMembership('principals/users/foo');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+
+    public function testGetGroupMembershipEmpty(): void {
+        $this->expectException(Exception::class);
+        $this->expectExceptionMessage('Principal not found');
+
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn(null);
+
+        $this->connector->getGroupMembership('principals/users/foo');
+    }
+
+
+    public function testSetGroupMembership(): void {
+        $this->expectException(Exception::class);
+        $this->expectExceptionMessage('Setting members of the group is not supported yet');
+
+        $this->connector->setGroupMemberSet('principals/users/foo', ['foo']);
+    }
+
+    public function testSetGroupMembershipProxy(): void {
+        $fooUser = $this->createMock(User::class);
+        $fooUser
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('foo');
+        $barUser = $this->createMock(User::class);
+        $barUser
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('bar');
+        $this->userManager
+            ->expects($this->exactly(2))
+            ->method('get')
+            ->willReturnMap([
+                ['foo', $fooUser],
+                ['bar', $barUser],
+            ]);
+
+        $this->proxyMapper->expects($this->once())
+            ->method('getProxiesOf')
+            ->with('principals/users/foo')
+            ->willReturn([]);
+
+        $this->proxyMapper->expects($this->once())
+            ->method('insert')
+            ->with($this->callback(function ($proxy) {
+                /** @var Proxy $proxy */
+                if ($proxy->getOwnerId() !== 'principals/users/foo') {
+                    return false;
+                }
+                if ($proxy->getProxyId() !== 'principals/users/bar') {
+                    return false;
+                }
+                if ($proxy->getPermissions() !== 3) {
+                    return false;
+                }
+
+                return true;
+            }));
+
+        $this->connector->setGroupMemberSet('principals/users/foo/calendar-proxy-write', ['principals/users/bar']);
+    }
+
+    public function testUpdatePrincipal(): void {
+        $this->assertSame(0, $this->connector->updatePrincipal('foo', new PropPatch([])));
+    }
+
+    public function testSearchPrincipalsWithEmptySearchProperties(): void {
+        $this->assertSame([], $this->connector->searchPrincipals('principals/users', []));
+    }
+
+    public function testSearchPrincipalsWithWrongPrefixPath(): void {
+        $this->assertSame([], $this->connector->searchPrincipals('principals/groups',
+            ['{http://sabredav.org/ns}email-address' => 'foo']));
+    }
+
+    /**
+     * @dataProvider searchPrincipalsDataProvider
+     */
+    public function testSearchPrincipals(bool $sharingEnabled, bool $groupsOnly, string $test, array $result): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareAPIEnabled')
+            ->willReturn($sharingEnabled);
+
+        $getUserGroupIdsReturnMap = [];
+
+        if ($sharingEnabled) {
+            $this->shareManager->expects($this->once())
+                ->method('allowEnumeration')
+                ->willReturn(true);
+
+            $this->shareManager->expects($this->once())
+                ->method('shareWithGroupMembersOnly')
+                ->willReturn($groupsOnly);
+
+            if ($groupsOnly) {
+                $user = $this->createMock(IUser::class);
+                $this->userSession->expects($this->atLeastOnce())
+                    ->method('getUser')
+                    ->willReturn($user);
+
+                $getUserGroupIdsReturnMap[] = [$user, ['group1', 'group2', 'group5']];
+            }
+        } else {
+            $this->config->expects($this->never())
+                ->method('getAppValue');
+            $this->shareManager->expects($this->never())
+                ->method('shareWithGroupMembersOnly');
+            $this->groupManager->expects($this->never())
+                ->method($this->anything());
+        }
+
+        $user2 = $this->createMock(IUser::class);
+        $user2->method('getUID')->willReturn('user2');
+        $user3 = $this->createMock(IUser::class);
+        $user3->method('getUID')->willReturn('user3');
+        $user4 = $this->createMock(IUser::class);
+        $user4->method('getUID')->willReturn('user4');
+
+        if ($sharingEnabled) {
+            $this->userManager->expects($this->once())
+                ->method('getByEmail')
+                ->with('user@example.com')
+                ->willReturn([$user2, $user3]);
+
+            $this->userManager->expects($this->once())
+                ->method('searchDisplayName')
+                ->with('User 12')
+                ->willReturn([$user3, $user4]);
+        } else {
+            $this->userManager->expects($this->never())
+                ->method('getByEmail');
+
+            $this->userManager->expects($this->never())
+                ->method('searchDisplayName');
+        }
+
+        if ($sharingEnabled && $groupsOnly) {
+            $getUserGroupIdsReturnMap[] = [$user2, ['group1', 'group3']];
+            $getUserGroupIdsReturnMap[] = [$user3, ['group3', 'group4']];
+            $getUserGroupIdsReturnMap[] = [$user4, ['group4', 'group5']];
+        }
+
+        $this->groupManager->expects($this->any())
+            ->method('getUserGroupIds')
+            ->willReturnMap($getUserGroupIdsReturnMap);
+
+
+        $this->assertEquals($result, $this->connector->searchPrincipals('principals/users',
+            ['{http://sabredav.org/ns}email-address' => 'user@example.com',
+                '{DAV:}displayname' => 'User 12'], $test));
+    }
+
+    public static function searchPrincipalsDataProvider(): array {
+        return [
+            [true, false, 'allof', ['principals/users/user3']],
+            [true, false, 'anyof', ['principals/users/user2', 'principals/users/user3', 'principals/users/user4']],
+            [true, true, 'allof', []],
+            [true, true, 'anyof', ['principals/users/user2', 'principals/users/user4']],
+            [false, false, 'allof', []],
+            [false, false, 'anyof', []],
+        ];
+    }
+
+    public function testSearchPrincipalByCalendarUserAddressSet(): void {
+        $this->shareManager->expects($this->exactly(2))
+            ->method('shareAPIEnabled')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->exactly(2))
+            ->method('allowEnumeration')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->exactly(2))
+            ->method('shareWithGroupMembersOnly')
+            ->willReturn(false);
+
+        $user2 = $this->createMock(IUser::class);
+        $user2->method('getUID')->willReturn('user2');
+        $user3 = $this->createMock(IUser::class);
+        $user3->method('getUID')->willReturn('user3');
+
+        $this->userManager->expects($this->once())
+            ->method('getByEmail')
+            ->with('user@example.com')
+            ->willReturn([$user2, $user3]);
+
+        $this->assertEquals([
+            'principals/users/user2',
+            'principals/users/user3',
+        ], $this->connector->searchPrincipals('principals/users',
+            ['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => 'user@example.com']));
+    }
+
+    public function testSearchPrincipalWithEnumerationDisabledDisplayname(): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareAPIEnabled')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowEnumeration')
+            ->willReturn(false);
+
+        $this->shareManager->expects($this->once())
+            ->method('shareWithGroupMembersOnly')
+            ->willReturn(false);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowEnumerationFullMatch')
+            ->willReturn(true);
+
+        $user2 = $this->createMock(IUser::class);
+        $user2->method('getUID')->willReturn('user2');
+        $user2->method('getDisplayName')->willReturn('User 2');
+        $user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar');
+        $user3 = $this->createMock(IUser::class);
+        $user3->method('getUID')->willReturn('user3');
+        $user3->method('getDisplayName')->willReturn('User 22');
+        $user3->method('getSystemEMailAddress')->willReturn('user2@foo.bar123');
+        $user4 = $this->createMock(IUser::class);
+        $user4->method('getUID')->willReturn('user4');
+        $user4->method('getDisplayName')->willReturn('User 222');
+        $user4->method('getSystemEMailAddress')->willReturn('user2@foo.bar456');
+
+        $this->userManager->expects($this->once())
+            ->method('searchDisplayName')
+            ->with('User 2')
+            ->willReturn([$user2, $user3, $user4]);
+
+        $this->assertEquals(['principals/users/user2'], $this->connector->searchPrincipals('principals/users',
+            ['{DAV:}displayname' => 'User 2']));
+    }
+
+    public function testSearchPrincipalWithEnumerationDisabledDisplaynameOnFullMatch(): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareAPIEnabled')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowEnumeration')
+            ->willReturn(false);
+
+        $this->shareManager->expects($this->once())
+            ->method('shareWithGroupMembersOnly')
+            ->willReturn(false);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowEnumerationFullMatch')
+            ->willReturn(false);
+
+        $this->assertEquals([], $this->connector->searchPrincipals('principals/users',
+            ['{DAV:}displayname' => 'User 2']));
+    }
+
+    public function testSearchPrincipalWithEnumerationDisabledEmail(): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareAPIEnabled')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowEnumeration')
+            ->willReturn(false);
+
+        $this->shareManager->expects($this->once())
+            ->method('shareWithGroupMembersOnly')
+            ->willReturn(false);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowEnumerationFullMatch')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('matchEmail')
+            ->willReturn(true);
+
+        $user2 = $this->createMock(IUser::class);
+        $user2->method('getUID')->willReturn('user2');
+        $user2->method('getDisplayName')->willReturn('User 2');
+        $user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar');
+        $user3 = $this->createMock(IUser::class);
+        $user3->method('getUID')->willReturn('user3');
+        $user2->method('getDisplayName')->willReturn('User 22');
+        $user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar123');
+        $user4 = $this->createMock(IUser::class);
+        $user4->method('getUID')->willReturn('user4');
+        $user2->method('getDisplayName')->willReturn('User 222');
+        $user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar456');
+
+        $this->userManager->expects($this->once())
+            ->method('getByEmail')
+            ->with('user2@foo.bar')
+            ->willReturn([$user2]);
+
+        $this->assertEquals(['principals/users/user2'], $this->connector->searchPrincipals('principals/users',
+            ['{http://sabredav.org/ns}email-address' => 'user2@foo.bar']));
+    }
+
+    public function testSearchPrincipalWithEnumerationDisabledEmailOnFullMatch(): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareAPIEnabled')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowEnumeration')
+            ->willReturn(false);
+
+        $this->shareManager->expects($this->once())
+            ->method('shareWithGroupMembersOnly')
+            ->willReturn(false);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowEnumerationFullMatch')
+            ->willReturn(false);
+
+
+        $this->assertEquals([], $this->connector->searchPrincipals('principals/users',
+            ['{http://sabredav.org/ns}email-address' => 'user2@foo.bar']));
+    }
+
+    public function testSearchPrincipalWithEnumerationLimitedDisplayname(): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareAPIEnabled')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowEnumeration')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('limitEnumerationToGroups')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('shareWithGroupMembersOnly')
+            ->willReturn(false);
+
+        $user2 = $this->createMock(IUser::class);
+        $user2->method('getUID')->willReturn('user2');
+        $user2->method('getDisplayName')->willReturn('User 2');
+        $user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar');
+        $user3 = $this->createMock(IUser::class);
+        $user3->method('getUID')->willReturn('user3');
+        $user3->method('getDisplayName')->willReturn('User 22');
+        $user3->method('getSystemEMailAddress')->willReturn('user2@foo.bar123');
+        $user4 = $this->createMock(IUser::class);
+        $user4->method('getUID')->willReturn('user4');
+        $user4->method('getDisplayName')->willReturn('User 222');
+        $user4->method('getSystemEMailAddress')->willReturn('user2@foo.bar456');
+
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user2);
+
+        $this->groupManager->expects($this->exactly(4))
+            ->method('getUserGroupIds')
+            ->willReturnMap([
+                [$user2, ['group1']],
+                [$user3, ['group1']],
+                [$user4, ['group2']],
+            ]);
+
+        $this->userManager->expects($this->once())
+            ->method('searchDisplayName')
+            ->with('User')
+            ->willReturn([$user2, $user3, $user4]);
+
+
+        $this->assertEquals([
+            'principals/users/user2',
+            'principals/users/user3',
+        ], $this->connector->searchPrincipals('principals/users',
+            ['{DAV:}displayname' => 'User']));
+    }
+
+    public function testSearchPrincipalWithEnumerationLimitedMail(): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareAPIEnabled')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowEnumeration')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('limitEnumerationToGroups')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('shareWithGroupMembersOnly')
+            ->willReturn(false);
+
+        $user2 = $this->createMock(IUser::class);
+        $user2->method('getUID')->willReturn('user2');
+        $user2->method('getDisplayName')->willReturn('User 2');
+        $user2->method('getSystemEMailAddress')->willReturn('user2@foo.bar');
+        $user3 = $this->createMock(IUser::class);
+        $user3->method('getUID')->willReturn('user3');
+        $user3->method('getDisplayName')->willReturn('User 22');
+        $user3->method('getSystemEMailAddress')->willReturn('user2@foo.bar123');
+        $user4 = $this->createMock(IUser::class);
+        $user4->method('getUID')->willReturn('user4');
+        $user4->method('getDisplayName')->willReturn('User 222');
+        $user4->method('getSystemEMailAddress')->willReturn('user2@foo.bar456');
+
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user2);
+
+        $this->groupManager->expects($this->exactly(4))
+            ->method('getUserGroupIds')
+            ->willReturnMap([
+                [$user2, ['group1']],
+                [$user3, ['group1']],
+                [$user4, ['group2']],
+            ]);
+
+        $this->userManager->expects($this->once())
+            ->method('getByEmail')
+            ->with('user')
+            ->willReturn([$user2, $user3, $user4]);
+
+
+        $this->assertEquals([
+            'principals/users/user2',
+            'principals/users/user3'
+        ], $this->connector->searchPrincipals('principals/users',
+            ['{http://sabredav.org/ns}email-address' => 'user']));
+    }
+
+    public function testFindByUriSharingApiDisabled(): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareApiEnabled')
+            ->willReturn(false);
+
+        $this->assertEquals(null, $this->connector->findByUri('mailto:user@foo.com', 'principals/users'));
+    }
+
+    /**
+     * @dataProvider findByUriWithGroupRestrictionDataProvider
+     */
+    public function testFindByUriWithGroupRestriction(string $uri, string $email, ?string $expects): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareApiEnabled')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('shareWithGroupMembersOnly')
+            ->willReturn(true);
+
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+
+        $user2 = $this->createMock(IUser::class);
+        $user2->method('getUID')->willReturn('user2');
+        $user3 = $this->createMock(IUser::class);
+        $user3->method('getUID')->willReturn('user3');
+
+        $this->userManager->expects($this->once())
+            ->method('getByEmail')
+            ->with($email)
+            ->willReturn([$email === 'user2@foo.bar' ? $user2 : $user3]);
+
+        if ($email === 'user2@foo.bar') {
+            $this->groupManager->expects($this->exactly(2))
+                ->method('getUserGroupIds')
+                ->willReturnMap([
+                    [$user, ['group1', 'group2']],
+                    [$user2, ['group1', 'group3']],
+                ]);
+        } else {
+            $this->groupManager->expects($this->exactly(2))
+                ->method('getUserGroupIds')
+                ->willReturnMap([
+                    [$user, ['group1', 'group2']],
+                    [$user3, ['group3', 'group3']],
+                ]);
+        }
+
+        $this->assertEquals($expects, $this->connector->findByUri($uri, 'principals/users'));
+    }
+
+    public static function findByUriWithGroupRestrictionDataProvider(): array {
+        return [
+            ['mailto:user2@foo.bar', 'user2@foo.bar', 'principals/users/user2'],
+            ['mailto:user3@foo.bar', 'user3@foo.bar', null],
+        ];
+    }
+
+    /**
+     * @dataProvider findByUriWithoutGroupRestrictionDataProvider
+     */
+    public function testFindByUriWithoutGroupRestriction(string $uri, string $email, string $expects): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareApiEnabled')
+            ->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('shareWithGroupMembersOnly')
+            ->willReturn(false);
+
+        $user2 = $this->createMock(IUser::class);
+        $user2->method('getUID')->willReturn('user2');
+        $user3 = $this->createMock(IUser::class);
+        $user3->method('getUID')->willReturn('user3');
+
+        $this->userManager->expects($this->once())
+            ->method('getByEmail')
+            ->with($email)
+            ->willReturn([$email === 'user2@foo.bar' ? $user2 : $user3]);
+
+        $this->assertEquals($expects, $this->connector->findByUri($uri, 'principals/users'));
+    }
+
+    public static function findByUriWithoutGroupRestrictionDataProvider(): array {
+        return [
+            ['mailto:user2@foo.bar', 'user2@foo.bar', 'principals/users/user2'],
+            ['mailto:user3@foo.bar', 'user3@foo.bar', 'principals/users/user3'],
+        ];
+    }
+
+    public function testGetEmailAddressesOfPrincipal(): void {
+        $principal = [
+            '{http://sabredav.org/ns}email-address' => 'bar@company.org',
+            '{DAV:}alternate-URI-set' => [
+                '/some/url',
+                'mailto:foo@bar.com',
+                'mailto:duplicate@example.com',
+            ],
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => [
+                'mailto:bernard@example.com',
+                'mailto:bernard.desruisseaux@example.com',
+            ],
+            '{http://calendarserver.org/ns/}email-address-set' => [
+                'mailto:duplicate@example.com',
+                'mailto:user@some.org',
+            ],
+        ];
+
+        $expected = [
+            'bar@company.org',
+            'foo@bar.com',
+            'duplicate@example.com',
+            'bernard@example.com',
+            'bernard.desruisseaux@example.com',
+            'user@some.org',
+        ];
+        $actual = $this->connector->getEmailAddressesOfPrincipal($principal);
+        $this->assertEquals($expected, $actual);
+    }
 }

apps/dav/tests/unit/Connector/Sabre/Exception/InvalidPathTest.php

Indentation +20 added lines, -20 removed lines

@@ -12,19 +12,19 @@ 
 use Sabre\DAV\Server;
 
 class InvalidPathTest extends \Test\TestCase {
-	public function testSerialization(): void {
-
-		// create xml doc
-		$DOM = new \DOMDocument('1.0', 'utf-8');
-		$DOM->formatOutput = true;
-		$error = $DOM->createElementNS('DAV:', 'd:error');
-		$error->setAttribute('xmlns:s', \Sabre\DAV\Server::NS_SABREDAV);
-		$DOM->appendChild($error);
-
-		// serialize the exception
-		$message = '1234567890';
-		$retry = false;
-		$expectedXml = <<<EOD
+    public function testSerialization(): void {
+
+        // create xml doc
+        $DOM = new \DOMDocument('1.0', 'utf-8');
+        $DOM->formatOutput = true;
+        $error = $DOM->createElementNS('DAV:', 'd:error');
+        $error->setAttribute('xmlns:s', \Sabre\DAV\Server::NS_SABREDAV);
+        $DOM->appendChild($error);
+
+        // serialize the exception
+        $message = '1234567890';
+        $retry = false;
+        $expectedXml = <<<EOD
 <?xml version="1.0" encoding="utf-8"?>
 <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:o="http://owncloud.org/ns">
   <o:retry xmlns:o="o:">false</o:retry>
@@ -33,12 +33,12 @@ 
 
 EOD;
 
-		$ex = new InvalidPath($message, $retry);
-		$server = $this->createMock(Server::class);
-		$ex->serialize($server, $error);
+        $ex = new InvalidPath($message, $retry);
+        $server = $this->createMock(Server::class);
+        $ex->serialize($server, $error);
 
-		// assert
-		$xml = $DOM->saveXML();
-		$this->assertEquals($expectedXml, $xml);
-	}
+        // assert
+        $xml = $DOM->saveXML();
+        $this->assertEquals($expectedXml, $xml);
+    }
 }

apps/dav/tests/unit/Connector/Sabre/Exception/ForbiddenTest.php

Indentation +20 added lines, -20 removed lines

@@ -12,19 +12,19 @@ 
 use Sabre\DAV\Server;
 
 class ForbiddenTest extends \Test\TestCase {
-	public function testSerialization(): void {
-
-		// create xml doc
-		$DOM = new \DOMDocument('1.0', 'utf-8');
-		$DOM->formatOutput = true;
-		$error = $DOM->createElementNS('DAV:', 'd:error');
-		$error->setAttribute('xmlns:s', \Sabre\DAV\Server::NS_SABREDAV);
-		$DOM->appendChild($error);
-
-		// serialize the exception
-		$message = '1234567890';
-		$retry = false;
-		$expectedXml = <<<EOD
+    public function testSerialization(): void {
+
+        // create xml doc
+        $DOM = new \DOMDocument('1.0', 'utf-8');
+        $DOM->formatOutput = true;
+        $error = $DOM->createElementNS('DAV:', 'd:error');
+        $error->setAttribute('xmlns:s', \Sabre\DAV\Server::NS_SABREDAV);
+        $DOM->appendChild($error);
+
+        // serialize the exception
+        $message = '1234567890';
+        $retry = false;
+        $expectedXml = <<<EOD
 <?xml version="1.0" encoding="utf-8"?>
 <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:o="http://owncloud.org/ns">
   <o:retry xmlns:o="o:">false</o:retry>
@@ -33,12 +33,12 @@ 
 
 EOD;
 
-		$ex = new Forbidden($message, $retry);
-		$server = $this->createMock(Server::class);
-		$ex->serialize($server, $error);
+        $ex = new Forbidden($message, $retry);
+        $server = $this->createMock(Server::class);
+        $ex->serialize($server, $error);
 
-		// assert
-		$xml = $DOM->saveXML();
-		$this->assertEquals($expectedXml, $xml);
-	}
+        // assert
+        $xml = $DOM->saveXML();
+        $this->assertEquals($expectedXml, $xml);
+    }
 }

apps/dav/tests/unit/Connector/Sabre/CopyEtagHeaderPluginTest.php

Indentation +59 added lines, -59 removed lines

@@ -16,63 +16,63 @@
 use Test\TestCase;
 
 class CopyEtagHeaderPluginTest extends TestCase {
-	private CopyEtagHeaderPlugin $plugin;
-	private Server $server;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->server = new \Sabre\DAV\Server();
-		$this->plugin = new CopyEtagHeaderPlugin();
-		$this->plugin->initialize($this->server);
-	}
-
-	public function testCopyEtag(): void {
-		$request = new \Sabre\Http\Request('GET', 'dummy.file');
-		$response = new \Sabre\Http\Response();
-		$response->setHeader('Etag', 'abcd');
-
-		$this->plugin->afterMethod($request, $response);
-
-		$this->assertEquals('abcd', $response->getHeader('OC-Etag'));
-	}
-
-	public function testNoopWhenEmpty(): void {
-		$request = new \Sabre\Http\Request('GET', 'dummy.file');
-		$response = new \Sabre\Http\Response();
-
-		$this->plugin->afterMethod($request, $response);
-
-		$this->assertNull($response->getHeader('OC-Etag'));
-	}
-
-	public function testAfterMoveNodeNotFound(): void {
-		$tree = $this->createMock(Tree::class);
-		$tree->expects(self::once())
-			->method('getNodeForPath')
-			->with('test.txt')
-			->willThrowException(new NotFound());
-
-		$this->server->tree = $tree;
-		$this->plugin->afterMove('', 'test.txt');
-
-		// Nothing to assert, we are just testing if the exception is handled
-	}
-
-	public function testAfterMove(): void {
-		$node = $this->createMock(File::class);
-		$node->expects($this->once())
-			->method('getETag')
-			->willReturn('123456');
-		$tree = $this->createMock(Tree::class);
-		$tree->expects($this->once())
-			->method('getNodeForPath')
-			->with('test.txt')
-			->willReturn($node);
-
-		$this->server->tree = $tree;
-		$this->plugin->afterMove('', 'test.txt');
-
-		$this->assertEquals('123456', $this->server->httpResponse->getHeader('OC-Etag'));
-		$this->assertEquals('123456', $this->server->httpResponse->getHeader('Etag'));
-	}
+    private CopyEtagHeaderPlugin $plugin;
+    private Server $server;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->server = new \Sabre\DAV\Server();
+        $this->plugin = new CopyEtagHeaderPlugin();
+        $this->plugin->initialize($this->server);
+    }
+
+    public function testCopyEtag(): void {
+        $request = new \Sabre\Http\Request('GET', 'dummy.file');
+        $response = new \Sabre\Http\Response();
+        $response->setHeader('Etag', 'abcd');
+
+        $this->plugin->afterMethod($request, $response);
+
+        $this->assertEquals('abcd', $response->getHeader('OC-Etag'));
+    }
+
+    public function testNoopWhenEmpty(): void {
+        $request = new \Sabre\Http\Request('GET', 'dummy.file');
+        $response = new \Sabre\Http\Response();
+
+        $this->plugin->afterMethod($request, $response);
+
+        $this->assertNull($response->getHeader('OC-Etag'));
+    }
+
+    public function testAfterMoveNodeNotFound(): void {
+        $tree = $this->createMock(Tree::class);
+        $tree->expects(self::once())
+            ->method('getNodeForPath')
+            ->with('test.txt')
+            ->willThrowException(new NotFound());
+
+        $this->server->tree = $tree;
+        $this->plugin->afterMove('', 'test.txt');
+
+        // Nothing to assert, we are just testing if the exception is handled
+    }
+
+    public function testAfterMove(): void {
+        $node = $this->createMock(File::class);
+        $node->expects($this->once())
+            ->method('getETag')
+            ->willReturn('123456');
+        $tree = $this->createMock(Tree::class);
+        $tree->expects($this->once())
+            ->method('getNodeForPath')
+            ->with('test.txt')
+            ->willReturn($node);
+
+        $this->server->tree = $tree;
+        $this->plugin->afterMove('', 'test.txt');
+
+        $this->assertEquals('123456', $this->server->httpResponse->getHeader('OC-Etag'));
+        $this->assertEquals('123456', $this->server->httpResponse->getHeader('Etag'));
+    }
 }

apps/dav/tests/unit/Connector/Sabre/BearerAuthTest.php

Indentation +48 added lines, -48 removed lines

@@ -23,60 +23,60 @@
  * @group DB
  */
 class BearerAuthTest extends TestCase {
-	private IUserSession&MockObject $userSession;
-	private ISession&MockObject $session;
-	private IRequest&MockObject $request;
-	private BearerAuth $bearerAuth;
+    private IUserSession&MockObject $userSession;
+    private ISession&MockObject $session;
+    private IRequest&MockObject $request;
+    private BearerAuth $bearerAuth;
 
-	private IConfig&MockObject $config;
+    private IConfig&MockObject $config;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->userSession = $this->createMock(Session::class);
-		$this->session = $this->createMock(ISession::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->config = $this->createMock(IConfig::class);
+        $this->userSession = $this->createMock(Session::class);
+        $this->session = $this->createMock(ISession::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->config = $this->createMock(IConfig::class);
 
-		$this->bearerAuth = new BearerAuth(
-			$this->userSession,
-			$this->session,
-			$this->request,
-			$this->config,
-		);
-	}
+        $this->bearerAuth = new BearerAuth(
+            $this->userSession,
+            $this->session,
+            $this->request,
+            $this->config,
+        );
+    }
 
-	public function testValidateBearerTokenNotLoggedIn(): void {
-		$this->assertFalse($this->bearerAuth->validateBearerToken('Token'));
-	}
+    public function testValidateBearerTokenNotLoggedIn(): void {
+        $this->assertFalse($this->bearerAuth->validateBearerToken('Token'));
+    }
 
-	public function testValidateBearerToken(): void {
-		$this->userSession
-			->expects($this->exactly(2))
-			->method('isLoggedIn')
-			->willReturnOnConsecutiveCalls(
-				false,
-				true,
-			);
-		$user = $this->createMock(IUser::class);
-		$user
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('admin');
-		$this->userSession
-			->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
+    public function testValidateBearerToken(): void {
+        $this->userSession
+            ->expects($this->exactly(2))
+            ->method('isLoggedIn')
+            ->willReturnOnConsecutiveCalls(
+                false,
+                true,
+            );
+        $user = $this->createMock(IUser::class);
+        $user
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('admin');
+        $this->userSession
+            ->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
 
-		$this->assertSame('principals/users/admin', $this->bearerAuth->validateBearerToken('Token'));
-	}
+        $this->assertSame('principals/users/admin', $this->bearerAuth->validateBearerToken('Token'));
+    }
 
-	public function testChallenge(): void {
-		/** @var RequestInterface&MockObject $request */
-		$request = $this->createMock(RequestInterface::class);
-		/** @var ResponseInterface&MockObject $response */
-		$response = $this->createMock(ResponseInterface::class);
-		$result = $this->bearerAuth->challenge($request, $response);
-		$this->assertEmpty($result);
-	}
+    public function testChallenge(): void {
+        /** @var RequestInterface&MockObject $request */
+        $request = $this->createMock(RequestInterface::class);
+        /** @var ResponseInterface&MockObject $response */
+        $response = $this->createMock(ResponseInterface::class);
+        $result = $this->bearerAuth->challenge($request, $response);
+        $this->assertEmpty($result);
+    }
 }

apps/dav/tests/unit/Connector/Sabre/QuotaPluginTest.php

Indentation +143 added lines, -143 removed lines

@@ -14,147 +14,147 @@
 use Test\TestCase;
 
 class QuotaPluginTest extends TestCase {
-	private \Sabre\DAV\Server $server;
-
-	private QuotaPlugin $plugin;
-
-	private function init(int $quota, string $checkedPath = ''): void {
-		$view = $this->buildFileViewMock((string)$quota, $checkedPath);
-		$this->server = new \Sabre\DAV\Server();
-		$this->plugin = new QuotaPlugin($view);
-		$this->plugin->initialize($this->server);
-	}
-
-	/**
-	 * @dataProvider lengthProvider
-	 */
-	public function testLength(?int $expected, array $headers): void {
-		$this->init(0);
-
-		$this->server->httpRequest = new \Sabre\HTTP\Request('POST', 'dummy.file', $headers);
-		$length = $this->plugin->getLength();
-		$this->assertEquals($expected, $length);
-	}
-
-	/**
-	 * @dataProvider quotaOkayProvider
-	 */
-	public function testCheckQuota(int $quota, array $headers): void {
-		$this->init($quota);
-
-		$this->server->httpRequest = new \Sabre\HTTP\Request('POST', 'dummy.file', $headers);
-		$result = $this->plugin->checkQuota('');
-		$this->assertTrue($result);
-	}
-
-	/**
-	 * @dataProvider quotaExceededProvider
-	 */
-	public function testCheckExceededQuota(int $quota, array $headers): void {
-		$this->expectException(\Sabre\DAV\Exception\InsufficientStorage::class);
-
-		$this->init($quota);
-
-		$this->server->httpRequest = new \Sabre\HTTP\Request('POST', 'dummy.file', $headers);
-		$this->plugin->checkQuota('');
-	}
-
-	/**
-	 * @dataProvider quotaOkayProvider
-	 */
-	public function testCheckQuotaOnPath(int $quota, array $headers): void {
-		$this->init($quota, 'sub/test.txt');
-
-		$this->server->httpRequest = new \Sabre\HTTP\Request('POST', 'dummy.file', $headers);
-		$result = $this->plugin->checkQuota('/sub/test.txt');
-		$this->assertTrue($result);
-	}
-
-	public static function quotaOkayProvider(): array {
-		return [
-			[1024, []],
-			[1024, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
-			[1024, ['CONTENT-LENGTH' => '512']],
-			[1024, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
-
-			[FileInfo::SPACE_UNKNOWN, []],
-			[FileInfo::SPACE_UNKNOWN, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
-			[FileInfo::SPACE_UNKNOWN, ['CONTENT-LENGTH' => '512']],
-			[FileInfo::SPACE_UNKNOWN, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
-
-			[FileInfo::SPACE_UNLIMITED, []],
-			[FileInfo::SPACE_UNLIMITED, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
-			[FileInfo::SPACE_UNLIMITED, ['CONTENT-LENGTH' => '512']],
-			[FileInfo::SPACE_UNLIMITED, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
-		];
-	}
-
-	public static function quotaExceededProvider(): array {
-		return [
-			[1023, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
-			[511, ['CONTENT-LENGTH' => '512']],
-			[2047, ['OC-TOTAL-LENGTH' => '2048', 'CONTENT-LENGTH' => '1024']],
-		];
-	}
-
-	public static function lengthProvider(): array {
-		return [
-			[null, []],
-			[1024, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
-			[512, ['CONTENT-LENGTH' => '512']],
-			[2048, ['OC-TOTAL-LENGTH' => '2048', 'CONTENT-LENGTH' => '1024']],
-			[4096, ['OC-TOTAL-LENGTH' => '2048', 'X-EXPECTED-ENTITY-LENGTH' => '4096']],
-			[null, ['X-EXPECTED-ENTITY-LENGTH' => 'A']],
-			[null, ['CONTENT-LENGTH' => 'A']],
-			[1024, ['OC-TOTAL-LENGTH' => 'A', 'CONTENT-LENGTH' => '1024']],
-			[1024, ['OC-TOTAL-LENGTH' => 'A', 'X-EXPECTED-ENTITY-LENGTH' => '1024']],
-			[2048, ['OC-TOTAL-LENGTH' => '2048', 'X-EXPECTED-ENTITY-LENGTH' => 'A']],
-			[2048, ['OC-TOTAL-LENGTH' => '2048', 'CONTENT-LENGTH' => 'A']],
-		];
-	}
-
-	public static function quotaChunkedOkProvider(): array {
-		return [
-			[1024, 0, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
-			[1024, 0, ['CONTENT-LENGTH' => '512']],
-			[1024, 0, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
-			// with existing chunks (allowed size = total length - chunk total size)
-			[400, 128, ['X-EXPECTED-ENTITY-LENGTH' => '512']],
-			[400, 128, ['CONTENT-LENGTH' => '512']],
-			[400, 128, ['OC-TOTAL-LENGTH' => '512', 'CONTENT-LENGTH' => '500']],
-			// \OCP\Files\FileInfo::SPACE-UNKNOWN = -2
-			[-2, 0, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
-			[-2, 0, ['CONTENT-LENGTH' => '512']],
-			[-2, 0, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
-			[-2, 128, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
-			[-2, 128, ['CONTENT-LENGTH' => '512']],
-			[-2, 128, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
-		];
-	}
-
-	public static function quotaChunkedFailProvider(): array {
-		return [
-			[400, 0, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
-			[400, 0, ['CONTENT-LENGTH' => '512']],
-			[400, 0, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
-			// with existing chunks (allowed size = total length - chunk total size)
-			[380, 128, ['X-EXPECTED-ENTITY-LENGTH' => '512']],
-			[380, 128, ['CONTENT-LENGTH' => '512']],
-			[380, 128, ['OC-TOTAL-LENGTH' => '512', 'CONTENT-LENGTH' => '500']],
-		];
-	}
-
-	private function buildFileViewMock(string $quota, string $checkedPath): View {
-		// mock filesystem
-		$view = $this->getMockBuilder(View::class)
-			->onlyMethods(['free_space'])
-			->disableOriginalConstructor()
-			->getMock();
-		$view->expects($this->any())
-			->method('free_space')
-			->with($checkedPath)
-			->willReturn($quota);
-
-		return $view;
-	}
+    private \Sabre\DAV\Server $server;
+
+    private QuotaPlugin $plugin;
+
+    private function init(int $quota, string $checkedPath = ''): void {
+        $view = $this->buildFileViewMock((string)$quota, $checkedPath);
+        $this->server = new \Sabre\DAV\Server();
+        $this->plugin = new QuotaPlugin($view);
+        $this->plugin->initialize($this->server);
+    }
+
+    /**
+     * @dataProvider lengthProvider
+     */
+    public function testLength(?int $expected, array $headers): void {
+        $this->init(0);
+
+        $this->server->httpRequest = new \Sabre\HTTP\Request('POST', 'dummy.file', $headers);
+        $length = $this->plugin->getLength();
+        $this->assertEquals($expected, $length);
+    }
+
+    /**
+     * @dataProvider quotaOkayProvider
+     */
+    public function testCheckQuota(int $quota, array $headers): void {
+        $this->init($quota);
+
+        $this->server->httpRequest = new \Sabre\HTTP\Request('POST', 'dummy.file', $headers);
+        $result = $this->plugin->checkQuota('');
+        $this->assertTrue($result);
+    }
+
+    /**
+     * @dataProvider quotaExceededProvider
+     */
+    public function testCheckExceededQuota(int $quota, array $headers): void {
+        $this->expectException(\Sabre\DAV\Exception\InsufficientStorage::class);
+
+        $this->init($quota);
+
+        $this->server->httpRequest = new \Sabre\HTTP\Request('POST', 'dummy.file', $headers);
+        $this->plugin->checkQuota('');
+    }
+
+    /**
+     * @dataProvider quotaOkayProvider
+     */
+    public function testCheckQuotaOnPath(int $quota, array $headers): void {
+        $this->init($quota, 'sub/test.txt');
+
+        $this->server->httpRequest = new \Sabre\HTTP\Request('POST', 'dummy.file', $headers);
+        $result = $this->plugin->checkQuota('/sub/test.txt');
+        $this->assertTrue($result);
+    }
+
+    public static function quotaOkayProvider(): array {
+        return [
+            [1024, []],
+            [1024, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
+            [1024, ['CONTENT-LENGTH' => '512']],
+            [1024, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
+
+            [FileInfo::SPACE_UNKNOWN, []],
+            [FileInfo::SPACE_UNKNOWN, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
+            [FileInfo::SPACE_UNKNOWN, ['CONTENT-LENGTH' => '512']],
+            [FileInfo::SPACE_UNKNOWN, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
+
+            [FileInfo::SPACE_UNLIMITED, []],
+            [FileInfo::SPACE_UNLIMITED, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
+            [FileInfo::SPACE_UNLIMITED, ['CONTENT-LENGTH' => '512']],
+            [FileInfo::SPACE_UNLIMITED, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
+        ];
+    }
+
+    public static function quotaExceededProvider(): array {
+        return [
+            [1023, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
+            [511, ['CONTENT-LENGTH' => '512']],
+            [2047, ['OC-TOTAL-LENGTH' => '2048', 'CONTENT-LENGTH' => '1024']],
+        ];
+    }
+
+    public static function lengthProvider(): array {
+        return [
+            [null, []],
+            [1024, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
+            [512, ['CONTENT-LENGTH' => '512']],
+            [2048, ['OC-TOTAL-LENGTH' => '2048', 'CONTENT-LENGTH' => '1024']],
+            [4096, ['OC-TOTAL-LENGTH' => '2048', 'X-EXPECTED-ENTITY-LENGTH' => '4096']],
+            [null, ['X-EXPECTED-ENTITY-LENGTH' => 'A']],
+            [null, ['CONTENT-LENGTH' => 'A']],
+            [1024, ['OC-TOTAL-LENGTH' => 'A', 'CONTENT-LENGTH' => '1024']],
+            [1024, ['OC-TOTAL-LENGTH' => 'A', 'X-EXPECTED-ENTITY-LENGTH' => '1024']],
+            [2048, ['OC-TOTAL-LENGTH' => '2048', 'X-EXPECTED-ENTITY-LENGTH' => 'A']],
+            [2048, ['OC-TOTAL-LENGTH' => '2048', 'CONTENT-LENGTH' => 'A']],
+        ];
+    }
+
+    public static function quotaChunkedOkProvider(): array {
+        return [
+            [1024, 0, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
+            [1024, 0, ['CONTENT-LENGTH' => '512']],
+            [1024, 0, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
+            // with existing chunks (allowed size = total length - chunk total size)
+            [400, 128, ['X-EXPECTED-ENTITY-LENGTH' => '512']],
+            [400, 128, ['CONTENT-LENGTH' => '512']],
+            [400, 128, ['OC-TOTAL-LENGTH' => '512', 'CONTENT-LENGTH' => '500']],
+            // \OCP\Files\FileInfo::SPACE-UNKNOWN = -2
+            [-2, 0, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
+            [-2, 0, ['CONTENT-LENGTH' => '512']],
+            [-2, 0, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
+            [-2, 128, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
+            [-2, 128, ['CONTENT-LENGTH' => '512']],
+            [-2, 128, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
+        ];
+    }
+
+    public static function quotaChunkedFailProvider(): array {
+        return [
+            [400, 0, ['X-EXPECTED-ENTITY-LENGTH' => '1024']],
+            [400, 0, ['CONTENT-LENGTH' => '512']],
+            [400, 0, ['OC-TOTAL-LENGTH' => '1024', 'CONTENT-LENGTH' => '512']],
+            // with existing chunks (allowed size = total length - chunk total size)
+            [380, 128, ['X-EXPECTED-ENTITY-LENGTH' => '512']],
+            [380, 128, ['CONTENT-LENGTH' => '512']],
+            [380, 128, ['OC-TOTAL-LENGTH' => '512', 'CONTENT-LENGTH' => '500']],
+        ];
+    }
+
+    private function buildFileViewMock(string $quota, string $checkedPath): View {
+        // mock filesystem
+        $view = $this->getMockBuilder(View::class)
+            ->onlyMethods(['free_space'])
+            ->disableOriginalConstructor()
+            ->getMock();
+        $view->expects($this->any())
+            ->method('free_space')
+            ->with($checkedPath)
+            ->willReturn($quota);
+
+        return $view;
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
 	private QuotaPlugin $plugin;
 
 	private function init(int $quota, string $checkedPath = ''): void {
-		$view = $this->buildFileViewMock((string)$quota, $checkedPath);
+		$view = $this->buildFileViewMock((string) $quota, $checkedPath);
 		$this->server = new \Sabre\DAV\Server();
 		$this->plugin = new QuotaPlugin($view);
 		$this->plugin->initialize($this->server);

apps/dav/tests/unit/Connector/Sabre/FileTest.php

Indentation +966 added lines, -966 removed lines

@@ -51,983 +51,983 @@
  * @package OCA\DAV\Tests\unit\Connector\Sabre
  */
 class FileTest extends TestCase {
-	use MountProviderTrait;
-	use UserTrait;
-
-	private string $user;
-	protected IConfig&MockObject $config;
-	protected IRequestId&MockObject $requestId;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		\OC_Hook::clear();
-
-		$this->user = 'test_user';
-		$this->createUser($this->user, 'pass');
-
-		self::loginAsUser($this->user);
-
-		$this->config = $this->createMock(IConfig::class);
-		$this->requestId = $this->createMock(IRequestId::class);
-	}
-
-	protected function tearDown(): void {
-		$userManager = Server::get(IUserManager::class);
-		$userManager->get($this->user)->delete();
-
-		parent::tearDown();
-	}
-
-	private function getMockStorage(): MockObject&IStorage {
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('getId')
-			->willReturn('home::someuser');
-		return $storage;
-	}
-
-	private function getStream(string $string) {
-		$stream = fopen('php://temp', 'r+');
-		fwrite($stream, $string);
-		fseek($stream, 0);
-		return $stream;
-	}
-
-
-	public static function fopenFailuresProvider(): array {
-		return [
-			[
-				// return false
-				null,
-				'\Sabre\Dav\Exception',
-				false
-			],
-			[
-				new NotPermittedException(),
-				'Sabre\DAV\Exception\Forbidden'
-			],
-			[
-				new EntityTooLargeException(),
-				'OCA\DAV\Connector\Sabre\Exception\EntityTooLarge'
-			],
-			[
-				new InvalidContentException(),
-				'OCA\DAV\Connector\Sabre\Exception\UnsupportedMediaType'
-			],
-			[
-				new InvalidPathException(),
-				'Sabre\DAV\Exception\Forbidden'
-			],
-			[
-				new ForbiddenException('', true),
-				'OCA\DAV\Connector\Sabre\Exception\Forbidden'
-			],
-			[
-				new LockNotAcquiredException('/test.txt', 1),
-				'OCA\DAV\Connector\Sabre\Exception\FileLocked'
-			],
-			[
-				new LockedException('/test.txt'),
-				'OCA\DAV\Connector\Sabre\Exception\FileLocked'
-			],
-			[
-				new GenericEncryptionException(),
-				'Sabre\DAV\Exception\ServiceUnavailable'
-			],
-			[
-				new StorageNotAvailableException(),
-				'Sabre\DAV\Exception\ServiceUnavailable'
-			],
-			[
-				new \Sabre\DAV\Exception('Generic sabre exception'),
-				'Sabre\DAV\Exception',
-				false
-			],
-			[
-				new \Exception('Generic exception'),
-				'Sabre\DAV\Exception'
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider fopenFailuresProvider
-	 */
-	public function testSimplePutFails(?\Throwable $thrownException, string $expectedException, bool $checkPreviousClass = true): void {
-		// setup
-		$storage = $this->getMockBuilder(Local::class)
-			->onlyMethods(['writeStream'])
-			->setConstructorArgs([['datadir' => Server::get(ITempManager::class)->getTemporaryFolder()]])
-			->getMock();
-		Filesystem::mount($storage, [], $this->user . '/');
-		/** @var View&MockObject $view */
-		$view = $this->getMockBuilder(View::class)
-			->onlyMethods(['getRelativePath', 'resolvePath'])
-			->getMock();
-		$view->expects($this->atLeastOnce())
-			->method('resolvePath')
-			->willReturnCallback(
-				function ($path) use ($storage) {
-					return [$storage, $path];
-				}
-			);
-
-		if ($thrownException !== null) {
-			$storage->expects($this->once())
-				->method('writeStream')
-				->will($this->throwException($thrownException));
-		} else {
-			$storage->expects($this->once())
-				->method('writeStream')
-				->willReturn(0);
-		}
-
-		$view->expects($this->any())
-			->method('getRelativePath')
-			->willReturnArgument(0);
-
-		$info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_ALL,
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-
-		$file = new File($view, $info);
-
-		// action
-		$caughtException = null;
-		try {
-			$file->put('test data');
-		} catch (\Exception $e) {
-			$caughtException = $e;
-		}
-
-		$this->assertInstanceOf($expectedException, $caughtException);
-		if ($checkPreviousClass) {
-			$this->assertInstanceOf(get_class($thrownException), $caughtException->getPrevious());
-		}
-
-		$this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
-	}
-
-	/**
-	 * Simulate putting a file to the given path.
-	 *
-	 * @param string $path path to put the file into
-	 * @param ?string $viewRoot root to use for the view
-	 * @param null|Request $request the HTTP request
-	 *
-	 * @return null|string of the PUT operation which is usually the etag
-	 */
-	private function doPut(string $path, ?string $viewRoot = null, ?Request $request = null) {
-		$view = Filesystem::getView();
-		if (!is_null($viewRoot)) {
-			$view = new View($viewRoot);
-		} else {
-			$viewRoot = '/' . $this->user . '/files';
-		}
-
-		$info = new \OC\Files\FileInfo(
-			$viewRoot . '/' . ltrim($path, '/'),
-			$this->getMockStorage(),
-			null,
-			[
-				'permissions' => Constants::PERMISSION_ALL,
-				'type' => FileInfo::TYPE_FOLDER,
-			],
-			null
-		);
-
-		/** @var File&MockObject $file */
-		$file = $this->getMockBuilder(File::class)
-			->setConstructorArgs([$view, $info, null, $request])
-			->onlyMethods(['header'])
-			->getMock();
-
-		// beforeMethod locks
-		$view->lockFile($path, ILockingProvider::LOCK_SHARED);
-
-		$result = $file->put($this->getStream('test data'));
-
-		// afterMethod unlocks
-		$view->unlockFile($path, ILockingProvider::LOCK_SHARED);
-
-		return $result;
-	}
-
-	/**
-	 * Test putting a single file
-	 */
-	public function testPutSingleFile(): void {
-		$this->assertNotEmpty($this->doPut('/foo.txt'));
-	}
-
-	public static function legalMtimeProvider(): array {
-		return [
-			'string' => [
-				'requestMtime' => 'string',
-				'resultMtime' => null
-			],
-			'castable string (int)' => [
-				'requestMtime' => '987654321',
-				'resultMtime' => 987654321
-			],
-			'castable string (float)' => [
-				'requestMtime' => '123456789.56',
-				'resultMtime' => 123456789
-			],
-			'float' => [
-				'requestMtime' => 123456789.56,
-				'resultMtime' => 123456789
-			],
-			'zero' => [
-				'requestMtime' => 0,
-				'resultMtime' => null
-			],
-			'zero string' => [
-				'requestMtime' => '0',
-				'resultMtime' => null
-			],
-			'negative zero string' => [
-				'requestMtime' => '-0',
-				'resultMtime' => null
-			],
-			'string starting with number following by char' => [
-				'requestMtime' => '2345asdf',
-				'resultMtime' => null
-			],
-			'string castable hex int' => [
-				'requestMtime' => '0x45adf',
-				'resultMtime' => null
-			],
-			'string that looks like invalid hex int' => [
-				'requestMtime' => '0x123g',
-				'resultMtime' => null
-			],
-			'negative int' => [
-				'requestMtime' => -34,
-				'resultMtime' => null
-			],
-			'negative float' => [
-				'requestMtime' => -34.43,
-				'resultMtime' => null
-			],
-		];
-	}
-
-	/**
-	 * Test putting a file with string Mtime
-	 * @dataProvider legalMtimeProvider
-	 */
-	public function testPutSingleFileLegalMtime(mixed $requestMtime, ?int $resultMtime): void {
-		$request = new Request([
-			'server' => [
-				'HTTP_X_OC_MTIME' => (string)$requestMtime,
-			]
-		], $this->requestId, $this->config, null);
-		$file = 'foo.txt';
-
-		if ($resultMtime === null) {
-			$this->expectException(\InvalidArgumentException::class);
-		}
-
-		$this->doPut($file, null, $request);
-
-		if ($resultMtime !== null) {
-			$this->assertEquals($resultMtime, $this->getFileInfos($file)['mtime']);
-		}
-	}
-
-	/**
-	 * Test that putting a file triggers create hooks
-	 */
-	public function testPutSingleFileTriggersHooks(): void {
-		HookHelper::setUpHooks();
-
-		$this->assertNotEmpty($this->doPut('/foo.txt'));
-
-		$this->assertCount(4, HookHelper::$hookCalls);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[0],
-			Filesystem::signal_create,
-			'/foo.txt'
-		);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[1],
-			Filesystem::signal_write,
-			'/foo.txt'
-		);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[2],
-			Filesystem::signal_post_create,
-			'/foo.txt'
-		);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[3],
-			Filesystem::signal_post_write,
-			'/foo.txt'
-		);
-	}
-
-	/**
-	 * Test that putting a file triggers update hooks
-	 */
-	public function testPutOverwriteFileTriggersHooks(): void {
-		$view = Filesystem::getView();
-		$view->file_put_contents('/foo.txt', 'some content that will be replaced');
-
-		HookHelper::setUpHooks();
-
-		$this->assertNotEmpty($this->doPut('/foo.txt'));
-
-		$this->assertCount(4, HookHelper::$hookCalls);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[0],
-			Filesystem::signal_update,
-			'/foo.txt'
-		);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[1],
-			Filesystem::signal_write,
-			'/foo.txt'
-		);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[2],
-			Filesystem::signal_post_update,
-			'/foo.txt'
-		);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[3],
-			Filesystem::signal_post_write,
-			'/foo.txt'
-		);
-	}
-
-	/**
-	 * Test that putting a file triggers hooks with the correct path
-	 * if the passed view was chrooted (can happen with public webdav
-	 * where the root is the share root)
-	 */
-	public function testPutSingleFileTriggersHooksDifferentRoot(): void {
-		$view = Filesystem::getView();
-		$view->mkdir('noderoot');
-
-		HookHelper::setUpHooks();
-
-		// happens with public webdav where the view root is the share root
-		$this->assertNotEmpty($this->doPut('/foo.txt', '/' . $this->user . '/files/noderoot'));
-
-		$this->assertCount(4, HookHelper::$hookCalls);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[0],
-			Filesystem::signal_create,
-			'/noderoot/foo.txt'
-		);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[1],
-			Filesystem::signal_write,
-			'/noderoot/foo.txt'
-		);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[2],
-			Filesystem::signal_post_create,
-			'/noderoot/foo.txt'
-		);
-		$this->assertHookCall(
-			HookHelper::$hookCalls[3],
-			Filesystem::signal_post_write,
-			'/noderoot/foo.txt'
-		);
-	}
-
-	public static function cancellingHook($params): void {
-		self::$hookCalls[] = [
-			'signal' => Filesystem::signal_post_create,
-			'params' => $params
-		];
-	}
-
-	/**
-	 * Test put file with cancelled hook
-	 */
-	public function testPutSingleFileCancelPreHook(): void {
-		Util::connectHook(
-			Filesystem::CLASSNAME,
-			Filesystem::signal_create,
-			'\Test\HookHelper',
-			'cancellingCallback'
-		);
-
-		// action
-		$thrown = false;
-		try {
-			$this->doPut('/foo.txt');
-		} catch (\Sabre\DAV\Exception $e) {
-			$thrown = true;
-		}
-
-		$this->assertTrue($thrown);
-		$this->assertEmpty($this->listPartFiles(), 'No stray part files');
-	}
-
-	/**
-	 * Test exception when the uploaded size did not match
-	 */
-	public function testSimplePutFailsSizeCheck(): void {
-		// setup
-		/** @var View&MockObject */
-		$view = $this->getMockBuilder(View::class)
-			->onlyMethods(['rename', 'getRelativePath', 'filesize'])
-			->getMock();
-		$view->expects($this->any())
-			->method('rename')
-			->withAnyParameters()
-			->willReturn(false);
-		$view->expects($this->any())
-			->method('getRelativePath')
-			->willReturnArgument(0);
-
-		$view->expects($this->any())
-			->method('filesize')
-			->willReturn(123456);
-
-		$request = new Request([
-			'server' => [
-				'CONTENT_LENGTH' => '123456',
-			],
-			'method' => 'PUT',
-		], $this->requestId, $this->config, null);
-
-		$info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_ALL,
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-
-		$file = new File($view, $info, null, $request);
-
-		// action
-		$thrown = false;
-		try {
-			// beforeMethod locks
-			$file->acquireLock(ILockingProvider::LOCK_SHARED);
-
-			$file->put($this->getStream('test data'));
-
-			// afterMethod unlocks
-			$file->releaseLock(ILockingProvider::LOCK_SHARED);
-		} catch (\Sabre\DAV\Exception\BadRequest $e) {
-			$thrown = true;
-		}
-
-		$this->assertTrue($thrown);
-		$this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
-	}
-
-	/**
-	 * Test exception during final rename in simple upload mode
-	 */
-	public function testSimplePutFailsMoveFromStorage(): void {
-		$view = new View('/' . $this->user . '/files');
-
-		// simulate situation where the target file is locked
-		$view->lockFile('/test.txt', ILockingProvider::LOCK_EXCLUSIVE);
-
-		$info = new \OC\Files\FileInfo('/' . $this->user . '/files/test.txt', $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_ALL,
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-
-		$file = new File($view, $info);
-
-		// action
-		$thrown = false;
-		try {
-			// beforeMethod locks
-			$view->lockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
-
-			$file->put($this->getStream('test data'));
-
-			// afterMethod unlocks
-			$view->unlockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
-		} catch (FileLocked $e) {
-			$thrown = true;
-		}
-
-		$this->assertTrue($thrown);
-		$this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
-	}
-
-	/**
-	 * Test put file with invalid chars
-	 */
-	public function testSimplePutInvalidChars(): void {
-		// setup
-		/** @var View&MockObject */
-		$view = $this->getMockBuilder(View::class)
-			->onlyMethods(['getRelativePath'])
-			->getMock();
-		$view->expects($this->any())
-			->method('getRelativePath')
-			->willReturnArgument(0);
-
-		$info = new \OC\Files\FileInfo("/i\nvalid", $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_ALL,
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-		$file = new File($view, $info);
-
-		// action
-		$thrown = false;
-		try {
-			// beforeMethod locks
-			$view->lockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
-
-			$file->put($this->getStream('test data'));
-
-			// afterMethod unlocks
-			$view->unlockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
-		} catch (InvalidPath $e) {
-			$thrown = true;
-		}
-
-		$this->assertTrue($thrown);
-		$this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
-	}
-
-	/**
-	 * Test setting name with setName() with invalid chars
-	 *
-	 */
-	public function testSetNameInvalidChars(): void {
-		$this->expectException(InvalidPath::class);
-
-		// setup
-		/** @var View&MockObject */
-		$view = $this->getMockBuilder(View::class)
-			->onlyMethods(['getRelativePath'])
-			->getMock();
-
-		$view->expects($this->any())
-			->method('getRelativePath')
-			->willReturnArgument(0);
-
-		$info = new \OC\Files\FileInfo('/valid', $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_ALL,
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-		$file = new File($view, $info);
-
-		$file->setName("/i\nvalid");
-	}
-
-
-	public function testUploadAbort(): void {
-		// setup
-		/** @var View&MockObject */
-		$view = $this->getMockBuilder(View::class)
-			->onlyMethods(['rename', 'getRelativePath', 'filesize'])
-			->getMock();
-		$view->expects($this->any())
-			->method('rename')
-			->withAnyParameters()
-			->willReturn(false);
-		$view->expects($this->any())
-			->method('getRelativePath')
-			->willReturnArgument(0);
-		$view->expects($this->any())
-			->method('filesize')
-			->willReturn(123456);
-
-		$request = new Request([
-			'server' => [
-				'CONTENT_LENGTH' => '123456',
-			],
-			'method' => 'PUT',
-		], $this->requestId, $this->config, null);
-
-		$info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_ALL,
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-
-		$file = new File($view, $info, null, $request);
-
-		// action
-		$thrown = false;
-		try {
-			// beforeMethod locks
-			$view->lockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
-
-			$file->put($this->getStream('test data'));
-
-			// afterMethod unlocks
-			$view->unlockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
-		} catch (\Sabre\DAV\Exception\BadRequest $e) {
-			$thrown = true;
-		}
-
-		$this->assertTrue($thrown);
-		$this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
-	}
-
-
-	public function testDeleteWhenAllowed(): void {
-		// setup
-		/** @var View&MockObject */
-		$view = $this->getMockBuilder(View::class)
-			->getMock();
-
-		$view->expects($this->once())
-			->method('unlink')
-			->willReturn(true);
-
-		$info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_ALL,
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-
-		$file = new File($view, $info);
-
-		// action
-		$file->delete();
-	}
-
-
-	public function testDeleteThrowsWhenDeletionNotAllowed(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-
-		// setup
-		/** @var View&MockObject */
-		$view = $this->getMockBuilder(View::class)
-			->getMock();
-
-		$info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
-			'permissions' => 0,
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-
-		$file = new File($view, $info);
-
-		// action
-		$file->delete();
-	}
-
-
-	public function testDeleteThrowsWhenDeletionFailed(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-
-		// setup
-		/** @var View&MockObject */
-		$view = $this->getMockBuilder(View::class)
-			->getMock();
-
-		// but fails
-		$view->expects($this->once())
-			->method('unlink')
-			->willReturn(false);
-
-		$info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_ALL,
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-
-		$file = new File($view, $info);
-
-		// action
-		$file->delete();
-	}
-
-
-	public function testDeleteThrowsWhenDeletionThrows(): void {
-		$this->expectException(Forbidden::class);
-
-		// setup
-		/** @var View&MockObject */
-		$view = $this->getMockBuilder(View::class)
-			->getMock();
-
-		// but fails
-		$view->expects($this->once())
-			->method('unlink')
-			->willThrowException(new ForbiddenException('', true));
-
-		$info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_ALL,
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-
-		$file = new File($view, $info);
-
-		// action
-		$file->delete();
-	}
-
-	/**
-	 * Asserts hook call
-	 *
-	 * @param array $callData hook call data to check
-	 * @param string $signal signal name
-	 * @param string $hookPath hook path
-	 */
-	protected function assertHookCall($callData, $signal, $hookPath) {
-		$this->assertEquals($signal, $callData['signal']);
-		$params = $callData['params'];
-		$this->assertEquals(
-			$hookPath,
-			$params[Filesystem::signal_param_path]
-		);
-	}
-
-	/**
-	 * Test whether locks are set before and after the operation
-	 */
-	public function testPutLocking(): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		$path = 'test-locking.txt';
-		$info = new \OC\Files\FileInfo(
-			'/' . $this->user . '/files/' . $path,
-			$this->getMockStorage(),
-			null,
-			[
-				'permissions' => Constants::PERMISSION_ALL,
-				'type' => FileInfo::TYPE_FOLDER,
-			],
-			null
-		);
-
-		$file = new File($view, $info);
-
-		$this->assertFalse(
-			$this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED),
-			'File unlocked before put'
-		);
-		$this->assertFalse(
-			$this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE),
-			'File unlocked before put'
-		);
-
-		$wasLockedPre = false;
-		$wasLockedPost = false;
-		$eventHandler = $this->getMockBuilder(\stdclass::class)
-			->addMethods(['writeCallback', 'postWriteCallback'])
-			->getMock();
-
-		// both pre and post hooks might need access to the file,
-		// so only shared lock is acceptable
-		$eventHandler->expects($this->once())
-			->method('writeCallback')
-			->willReturnCallback(
-				function () use ($view, $path, &$wasLockedPre): void {
-					$wasLockedPre = $this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED);
-					$wasLockedPre = $wasLockedPre && !$this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE);
-				}
-			);
-		$eventHandler->expects($this->once())
-			->method('postWriteCallback')
-			->willReturnCallback(
-				function () use ($view, $path, &$wasLockedPost): void {
-					$wasLockedPost = $this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED);
-					$wasLockedPost = $wasLockedPost && !$this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE);
-				}
-			);
-
-		Util::connectHook(
-			Filesystem::CLASSNAME,
-			Filesystem::signal_write,
-			$eventHandler,
-			'writeCallback'
-		);
-		Util::connectHook(
-			Filesystem::CLASSNAME,
-			Filesystem::signal_post_write,
-			$eventHandler,
-			'postWriteCallback'
-		);
-
-		// beforeMethod locks
-		$view->lockFile($path, ILockingProvider::LOCK_SHARED);
-
-		$this->assertNotEmpty($file->put($this->getStream('test data')));
-
-		// afterMethod unlocks
-		$view->unlockFile($path, ILockingProvider::LOCK_SHARED);
-
-		$this->assertTrue($wasLockedPre, 'File was locked during pre-hooks');
-		$this->assertTrue($wasLockedPost, 'File was locked during post-hooks');
-
-		$this->assertFalse(
-			$this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED),
-			'File unlocked after put'
-		);
-		$this->assertFalse(
-			$this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE),
-			'File unlocked after put'
-		);
-	}
-
-	/**
-	 * Returns part files in the given path
-	 *
-	 * @param \OC\Files\View view which root is the current user's "files" folder
-	 * @param string $path path for which to list part files
-	 *
-	 * @return array list of part files
-	 */
-	private function listPartFiles(?View $userView = null, $path = '') {
-		if ($userView === null) {
-			$userView = Filesystem::getView();
-		}
-		$files = [];
-		[$storage, $internalPath] = $userView->resolvePath($path);
-		if ($storage instanceof Local) {
-			$realPath = $storage->getSourcePath($internalPath);
-			$dh = opendir($realPath);
-			while (($file = readdir($dh)) !== false) {
-				if (str_ends_with($file, '.part')) {
-					$files[] = $file;
-				}
-			}
-			closedir($dh);
-		}
-		return $files;
-	}
-
-	/**
-	 * returns an array of file information filesize, mtime, filetype,  mimetype
-	 *
-	 * @param string $path
-	 * @param View $userView
-	 * @return array
-	 */
-	private function getFileInfos($path = '', ?View $userView = null) {
-		if ($userView === null) {
-			$userView = Filesystem::getView();
-		}
-		return [
-			'filesize' => $userView->filesize($path),
-			'mtime' => $userView->filemtime($path),
-			'filetype' => $userView->filetype($path),
-			'mimetype' => $userView->getMimeType($path)
-		];
-	}
-
-
-	public function testGetFopenFails(): void {
-		$this->expectException(\Sabre\DAV\Exception\ServiceUnavailable::class);
-
-		/** @var View&MockObject */
-		$view = $this->getMockBuilder(View::class)
-			->onlyMethods(['fopen'])
-			->getMock();
-		$view->expects($this->atLeastOnce())
-			->method('fopen')
-			->willReturn(false);
-
-		$info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_ALL,
-			'type' => FileInfo::TYPE_FILE,
-		], null);
-
-		$file = new File($view, $info);
-
-		$file->get();
-	}
-
-
-	public function testGetFopenThrows(): void {
-		$this->expectException(Forbidden::class);
-
-		/** @var View&MockObject */
-		$view = $this->getMockBuilder(View::class)
-			->onlyMethods(['fopen'])
-			->getMock();
-		$view->expects($this->atLeastOnce())
-			->method('fopen')
-			->willThrowException(new ForbiddenException('', true));
-
-		$info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_ALL,
-			'type' => FileInfo::TYPE_FILE,
-		], null);
-
-		$file = new File($view, $info);
-
-		$file->get();
-	}
-
-
-	public function testGetThrowsIfNoPermission(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-
-		/** @var View&MockObject */
-		$view = $this->getMockBuilder(View::class)
-			->onlyMethods(['fopen'])
-			->getMock();
-		$view->expects($this->never())
-			->method('fopen');
-
-		$info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
-			'permissions' => Constants::PERMISSION_CREATE, // no read perm
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-
-		$file = new  File($view, $info);
-
-		$file->get();
-	}
-
-	public function testSimplePutNoCreatePermissions(): void {
-		$this->logout();
-
-		$storage = new Temporary([]);
-		$storage->file_put_contents('file.txt', 'old content');
-		$noCreateStorage = new PermissionsMask([
-			'storage' => $storage,
-			'mask' => Constants::PERMISSION_ALL - Constants::PERMISSION_CREATE
-		]);
-
-		$this->registerMount($this->user, $noCreateStorage, '/' . $this->user . '/files/root');
+    use MountProviderTrait;
+    use UserTrait;
+
+    private string $user;
+    protected IConfig&MockObject $config;
+    protected IRequestId&MockObject $requestId;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        \OC_Hook::clear();
+
+        $this->user = 'test_user';
+        $this->createUser($this->user, 'pass');
+
+        self::loginAsUser($this->user);
+
+        $this->config = $this->createMock(IConfig::class);
+        $this->requestId = $this->createMock(IRequestId::class);
+    }
+
+    protected function tearDown(): void {
+        $userManager = Server::get(IUserManager::class);
+        $userManager->get($this->user)->delete();
+
+        parent::tearDown();
+    }
+
+    private function getMockStorage(): MockObject&IStorage {
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('getId')
+            ->willReturn('home::someuser');
+        return $storage;
+    }
+
+    private function getStream(string $string) {
+        $stream = fopen('php://temp', 'r+');
+        fwrite($stream, $string);
+        fseek($stream, 0);
+        return $stream;
+    }
+
+
+    public static function fopenFailuresProvider(): array {
+        return [
+            [
+                // return false
+                null,
+                '\Sabre\Dav\Exception',
+                false
+            ],
+            [
+                new NotPermittedException(),
+                'Sabre\DAV\Exception\Forbidden'
+            ],
+            [
+                new EntityTooLargeException(),
+                'OCA\DAV\Connector\Sabre\Exception\EntityTooLarge'
+            ],
+            [
+                new InvalidContentException(),
+                'OCA\DAV\Connector\Sabre\Exception\UnsupportedMediaType'
+            ],
+            [
+                new InvalidPathException(),
+                'Sabre\DAV\Exception\Forbidden'
+            ],
+            [
+                new ForbiddenException('', true),
+                'OCA\DAV\Connector\Sabre\Exception\Forbidden'
+            ],
+            [
+                new LockNotAcquiredException('/test.txt', 1),
+                'OCA\DAV\Connector\Sabre\Exception\FileLocked'
+            ],
+            [
+                new LockedException('/test.txt'),
+                'OCA\DAV\Connector\Sabre\Exception\FileLocked'
+            ],
+            [
+                new GenericEncryptionException(),
+                'Sabre\DAV\Exception\ServiceUnavailable'
+            ],
+            [
+                new StorageNotAvailableException(),
+                'Sabre\DAV\Exception\ServiceUnavailable'
+            ],
+            [
+                new \Sabre\DAV\Exception('Generic sabre exception'),
+                'Sabre\DAV\Exception',
+                false
+            ],
+            [
+                new \Exception('Generic exception'),
+                'Sabre\DAV\Exception'
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider fopenFailuresProvider
+     */
+    public function testSimplePutFails(?\Throwable $thrownException, string $expectedException, bool $checkPreviousClass = true): void {
+        // setup
+        $storage = $this->getMockBuilder(Local::class)
+            ->onlyMethods(['writeStream'])
+            ->setConstructorArgs([['datadir' => Server::get(ITempManager::class)->getTemporaryFolder()]])
+            ->getMock();
+        Filesystem::mount($storage, [], $this->user . '/');
+        /** @var View&MockObject $view */
+        $view = $this->getMockBuilder(View::class)
+            ->onlyMethods(['getRelativePath', 'resolvePath'])
+            ->getMock();
+        $view->expects($this->atLeastOnce())
+            ->method('resolvePath')
+            ->willReturnCallback(
+                function ($path) use ($storage) {
+                    return [$storage, $path];
+                }
+            );
+
+        if ($thrownException !== null) {
+            $storage->expects($this->once())
+                ->method('writeStream')
+                ->will($this->throwException($thrownException));
+        } else {
+            $storage->expects($this->once())
+                ->method('writeStream')
+                ->willReturn(0);
+        }
+
+        $view->expects($this->any())
+            ->method('getRelativePath')
+            ->willReturnArgument(0);
+
+        $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_ALL,
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+
+        $file = new File($view, $info);
+
+        // action
+        $caughtException = null;
+        try {
+            $file->put('test data');
+        } catch (\Exception $e) {
+            $caughtException = $e;
+        }
+
+        $this->assertInstanceOf($expectedException, $caughtException);
+        if ($checkPreviousClass) {
+            $this->assertInstanceOf(get_class($thrownException), $caughtException->getPrevious());
+        }
+
+        $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
+    }
+
+    /**
+     * Simulate putting a file to the given path.
+     *
+     * @param string $path path to put the file into
+     * @param ?string $viewRoot root to use for the view
+     * @param null|Request $request the HTTP request
+     *
+     * @return null|string of the PUT operation which is usually the etag
+     */
+    private function doPut(string $path, ?string $viewRoot = null, ?Request $request = null) {
+        $view = Filesystem::getView();
+        if (!is_null($viewRoot)) {
+            $view = new View($viewRoot);
+        } else {
+            $viewRoot = '/' . $this->user . '/files';
+        }
+
+        $info = new \OC\Files\FileInfo(
+            $viewRoot . '/' . ltrim($path, '/'),
+            $this->getMockStorage(),
+            null,
+            [
+                'permissions' => Constants::PERMISSION_ALL,
+                'type' => FileInfo::TYPE_FOLDER,
+            ],
+            null
+        );
+
+        /** @var File&MockObject $file */
+        $file = $this->getMockBuilder(File::class)
+            ->setConstructorArgs([$view, $info, null, $request])
+            ->onlyMethods(['header'])
+            ->getMock();
+
+        // beforeMethod locks
+        $view->lockFile($path, ILockingProvider::LOCK_SHARED);
+
+        $result = $file->put($this->getStream('test data'));
+
+        // afterMethod unlocks
+        $view->unlockFile($path, ILockingProvider::LOCK_SHARED);
+
+        return $result;
+    }
+
+    /**
+     * Test putting a single file
+     */
+    public function testPutSingleFile(): void {
+        $this->assertNotEmpty($this->doPut('/foo.txt'));
+    }
+
+    public static function legalMtimeProvider(): array {
+        return [
+            'string' => [
+                'requestMtime' => 'string',
+                'resultMtime' => null
+            ],
+            'castable string (int)' => [
+                'requestMtime' => '987654321',
+                'resultMtime' => 987654321
+            ],
+            'castable string (float)' => [
+                'requestMtime' => '123456789.56',
+                'resultMtime' => 123456789
+            ],
+            'float' => [
+                'requestMtime' => 123456789.56,
+                'resultMtime' => 123456789
+            ],
+            'zero' => [
+                'requestMtime' => 0,
+                'resultMtime' => null
+            ],
+            'zero string' => [
+                'requestMtime' => '0',
+                'resultMtime' => null
+            ],
+            'negative zero string' => [
+                'requestMtime' => '-0',
+                'resultMtime' => null
+            ],
+            'string starting with number following by char' => [
+                'requestMtime' => '2345asdf',
+                'resultMtime' => null
+            ],
+            'string castable hex int' => [
+                'requestMtime' => '0x45adf',
+                'resultMtime' => null
+            ],
+            'string that looks like invalid hex int' => [
+                'requestMtime' => '0x123g',
+                'resultMtime' => null
+            ],
+            'negative int' => [
+                'requestMtime' => -34,
+                'resultMtime' => null
+            ],
+            'negative float' => [
+                'requestMtime' => -34.43,
+                'resultMtime' => null
+            ],
+        ];
+    }
+
+    /**
+     * Test putting a file with string Mtime
+     * @dataProvider legalMtimeProvider
+     */
+    public function testPutSingleFileLegalMtime(mixed $requestMtime, ?int $resultMtime): void {
+        $request = new Request([
+            'server' => [
+                'HTTP_X_OC_MTIME' => (string)$requestMtime,
+            ]
+        ], $this->requestId, $this->config, null);
+        $file = 'foo.txt';
+
+        if ($resultMtime === null) {
+            $this->expectException(\InvalidArgumentException::class);
+        }
+
+        $this->doPut($file, null, $request);
+
+        if ($resultMtime !== null) {
+            $this->assertEquals($resultMtime, $this->getFileInfos($file)['mtime']);
+        }
+    }
+
+    /**
+     * Test that putting a file triggers create hooks
+     */
+    public function testPutSingleFileTriggersHooks(): void {
+        HookHelper::setUpHooks();
+
+        $this->assertNotEmpty($this->doPut('/foo.txt'));
+
+        $this->assertCount(4, HookHelper::$hookCalls);
+        $this->assertHookCall(
+            HookHelper::$hookCalls[0],
+            Filesystem::signal_create,
+            '/foo.txt'
+        );
+        $this->assertHookCall(
+            HookHelper::$hookCalls[1],
+            Filesystem::signal_write,
+            '/foo.txt'
+        );
+        $this->assertHookCall(
+            HookHelper::$hookCalls[2],
+            Filesystem::signal_post_create,
+            '/foo.txt'
+        );
+        $this->assertHookCall(
+            HookHelper::$hookCalls[3],
+            Filesystem::signal_post_write,
+            '/foo.txt'
+        );
+    }
+
+    /**
+     * Test that putting a file triggers update hooks
+     */
+    public function testPutOverwriteFileTriggersHooks(): void {
+        $view = Filesystem::getView();
+        $view->file_put_contents('/foo.txt', 'some content that will be replaced');
+
+        HookHelper::setUpHooks();
+
+        $this->assertNotEmpty($this->doPut('/foo.txt'));
+
+        $this->assertCount(4, HookHelper::$hookCalls);
+        $this->assertHookCall(
+            HookHelper::$hookCalls[0],
+            Filesystem::signal_update,
+            '/foo.txt'
+        );
+        $this->assertHookCall(
+            HookHelper::$hookCalls[1],
+            Filesystem::signal_write,
+            '/foo.txt'
+        );
+        $this->assertHookCall(
+            HookHelper::$hookCalls[2],
+            Filesystem::signal_post_update,
+            '/foo.txt'
+        );
+        $this->assertHookCall(
+            HookHelper::$hookCalls[3],
+            Filesystem::signal_post_write,
+            '/foo.txt'
+        );
+    }
+
+    /**
+     * Test that putting a file triggers hooks with the correct path
+     * if the passed view was chrooted (can happen with public webdav
+     * where the root is the share root)
+     */
+    public function testPutSingleFileTriggersHooksDifferentRoot(): void {
+        $view = Filesystem::getView();
+        $view->mkdir('noderoot');
+
+        HookHelper::setUpHooks();
+
+        // happens with public webdav where the view root is the share root
+        $this->assertNotEmpty($this->doPut('/foo.txt', '/' . $this->user . '/files/noderoot'));
+
+        $this->assertCount(4, HookHelper::$hookCalls);
+        $this->assertHookCall(
+            HookHelper::$hookCalls[0],
+            Filesystem::signal_create,
+            '/noderoot/foo.txt'
+        );
+        $this->assertHookCall(
+            HookHelper::$hookCalls[1],
+            Filesystem::signal_write,
+            '/noderoot/foo.txt'
+        );
+        $this->assertHookCall(
+            HookHelper::$hookCalls[2],
+            Filesystem::signal_post_create,
+            '/noderoot/foo.txt'
+        );
+        $this->assertHookCall(
+            HookHelper::$hookCalls[3],
+            Filesystem::signal_post_write,
+            '/noderoot/foo.txt'
+        );
+    }
+
+    public static function cancellingHook($params): void {
+        self::$hookCalls[] = [
+            'signal' => Filesystem::signal_post_create,
+            'params' => $params
+        ];
+    }
+
+    /**
+     * Test put file with cancelled hook
+     */
+    public function testPutSingleFileCancelPreHook(): void {
+        Util::connectHook(
+            Filesystem::CLASSNAME,
+            Filesystem::signal_create,
+            '\Test\HookHelper',
+            'cancellingCallback'
+        );
+
+        // action
+        $thrown = false;
+        try {
+            $this->doPut('/foo.txt');
+        } catch (\Sabre\DAV\Exception $e) {
+            $thrown = true;
+        }
+
+        $this->assertTrue($thrown);
+        $this->assertEmpty($this->listPartFiles(), 'No stray part files');
+    }
+
+    /**
+     * Test exception when the uploaded size did not match
+     */
+    public function testSimplePutFailsSizeCheck(): void {
+        // setup
+        /** @var View&MockObject */
+        $view = $this->getMockBuilder(View::class)
+            ->onlyMethods(['rename', 'getRelativePath', 'filesize'])
+            ->getMock();
+        $view->expects($this->any())
+            ->method('rename')
+            ->withAnyParameters()
+            ->willReturn(false);
+        $view->expects($this->any())
+            ->method('getRelativePath')
+            ->willReturnArgument(0);
+
+        $view->expects($this->any())
+            ->method('filesize')
+            ->willReturn(123456);
+
+        $request = new Request([
+            'server' => [
+                'CONTENT_LENGTH' => '123456',
+            ],
+            'method' => 'PUT',
+        ], $this->requestId, $this->config, null);
+
+        $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_ALL,
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+
+        $file = new File($view, $info, null, $request);
+
+        // action
+        $thrown = false;
+        try {
+            // beforeMethod locks
+            $file->acquireLock(ILockingProvider::LOCK_SHARED);
+
+            $file->put($this->getStream('test data'));
+
+            // afterMethod unlocks
+            $file->releaseLock(ILockingProvider::LOCK_SHARED);
+        } catch (\Sabre\DAV\Exception\BadRequest $e) {
+            $thrown = true;
+        }
+
+        $this->assertTrue($thrown);
+        $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
+    }
+
+    /**
+     * Test exception during final rename in simple upload mode
+     */
+    public function testSimplePutFailsMoveFromStorage(): void {
+        $view = new View('/' . $this->user . '/files');
+
+        // simulate situation where the target file is locked
+        $view->lockFile('/test.txt', ILockingProvider::LOCK_EXCLUSIVE);
+
+        $info = new \OC\Files\FileInfo('/' . $this->user . '/files/test.txt', $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_ALL,
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+
+        $file = new File($view, $info);
+
+        // action
+        $thrown = false;
+        try {
+            // beforeMethod locks
+            $view->lockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
+
+            $file->put($this->getStream('test data'));
+
+            // afterMethod unlocks
+            $view->unlockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
+        } catch (FileLocked $e) {
+            $thrown = true;
+        }
+
+        $this->assertTrue($thrown);
+        $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
+    }
+
+    /**
+     * Test put file with invalid chars
+     */
+    public function testSimplePutInvalidChars(): void {
+        // setup
+        /** @var View&MockObject */
+        $view = $this->getMockBuilder(View::class)
+            ->onlyMethods(['getRelativePath'])
+            ->getMock();
+        $view->expects($this->any())
+            ->method('getRelativePath')
+            ->willReturnArgument(0);
+
+        $info = new \OC\Files\FileInfo("/i\nvalid", $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_ALL,
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+        $file = new File($view, $info);
+
+        // action
+        $thrown = false;
+        try {
+            // beforeMethod locks
+            $view->lockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
+
+            $file->put($this->getStream('test data'));
+
+            // afterMethod unlocks
+            $view->unlockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
+        } catch (InvalidPath $e) {
+            $thrown = true;
+        }
+
+        $this->assertTrue($thrown);
+        $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
+    }
+
+    /**
+     * Test setting name with setName() with invalid chars
+     *
+     */
+    public function testSetNameInvalidChars(): void {
+        $this->expectException(InvalidPath::class);
+
+        // setup
+        /** @var View&MockObject */
+        $view = $this->getMockBuilder(View::class)
+            ->onlyMethods(['getRelativePath'])
+            ->getMock();
+
+        $view->expects($this->any())
+            ->method('getRelativePath')
+            ->willReturnArgument(0);
+
+        $info = new \OC\Files\FileInfo('/valid', $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_ALL,
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+        $file = new File($view, $info);
+
+        $file->setName("/i\nvalid");
+    }
+
+
+    public function testUploadAbort(): void {
+        // setup
+        /** @var View&MockObject */
+        $view = $this->getMockBuilder(View::class)
+            ->onlyMethods(['rename', 'getRelativePath', 'filesize'])
+            ->getMock();
+        $view->expects($this->any())
+            ->method('rename')
+            ->withAnyParameters()
+            ->willReturn(false);
+        $view->expects($this->any())
+            ->method('getRelativePath')
+            ->willReturnArgument(0);
+        $view->expects($this->any())
+            ->method('filesize')
+            ->willReturn(123456);
+
+        $request = new Request([
+            'server' => [
+                'CONTENT_LENGTH' => '123456',
+            ],
+            'method' => 'PUT',
+        ], $this->requestId, $this->config, null);
+
+        $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_ALL,
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+
+        $file = new File($view, $info, null, $request);
+
+        // action
+        $thrown = false;
+        try {
+            // beforeMethod locks
+            $view->lockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
+
+            $file->put($this->getStream('test data'));
+
+            // afterMethod unlocks
+            $view->unlockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
+        } catch (\Sabre\DAV\Exception\BadRequest $e) {
+            $thrown = true;
+        }
+
+        $this->assertTrue($thrown);
+        $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
+    }
+
+
+    public function testDeleteWhenAllowed(): void {
+        // setup
+        /** @var View&MockObject */
+        $view = $this->getMockBuilder(View::class)
+            ->getMock();
+
+        $view->expects($this->once())
+            ->method('unlink')
+            ->willReturn(true);
+
+        $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_ALL,
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+
+        $file = new File($view, $info);
+
+        // action
+        $file->delete();
+    }
+
+
+    public function testDeleteThrowsWhenDeletionNotAllowed(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+
+        // setup
+        /** @var View&MockObject */
+        $view = $this->getMockBuilder(View::class)
+            ->getMock();
+
+        $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
+            'permissions' => 0,
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+
+        $file = new File($view, $info);
+
+        // action
+        $file->delete();
+    }
+
+
+    public function testDeleteThrowsWhenDeletionFailed(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+
+        // setup
+        /** @var View&MockObject */
+        $view = $this->getMockBuilder(View::class)
+            ->getMock();
+
+        // but fails
+        $view->expects($this->once())
+            ->method('unlink')
+            ->willReturn(false);
+
+        $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_ALL,
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+
+        $file = new File($view, $info);
+
+        // action
+        $file->delete();
+    }
+
+
+    public function testDeleteThrowsWhenDeletionThrows(): void {
+        $this->expectException(Forbidden::class);
+
+        // setup
+        /** @var View&MockObject */
+        $view = $this->getMockBuilder(View::class)
+            ->getMock();
+
+        // but fails
+        $view->expects($this->once())
+            ->method('unlink')
+            ->willThrowException(new ForbiddenException('', true));
+
+        $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_ALL,
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+
+        $file = new File($view, $info);
+
+        // action
+        $file->delete();
+    }
+
+    /**
+     * Asserts hook call
+     *
+     * @param array $callData hook call data to check
+     * @param string $signal signal name
+     * @param string $hookPath hook path
+     */
+    protected function assertHookCall($callData, $signal, $hookPath) {
+        $this->assertEquals($signal, $callData['signal']);
+        $params = $callData['params'];
+        $this->assertEquals(
+            $hookPath,
+            $params[Filesystem::signal_param_path]
+        );
+    }
+
+    /**
+     * Test whether locks are set before and after the operation
+     */
+    public function testPutLocking(): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        $path = 'test-locking.txt';
+        $info = new \OC\Files\FileInfo(
+            '/' . $this->user . '/files/' . $path,
+            $this->getMockStorage(),
+            null,
+            [
+                'permissions' => Constants::PERMISSION_ALL,
+                'type' => FileInfo::TYPE_FOLDER,
+            ],
+            null
+        );
+
+        $file = new File($view, $info);
+
+        $this->assertFalse(
+            $this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED),
+            'File unlocked before put'
+        );
+        $this->assertFalse(
+            $this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE),
+            'File unlocked before put'
+        );
+
+        $wasLockedPre = false;
+        $wasLockedPost = false;
+        $eventHandler = $this->getMockBuilder(\stdclass::class)
+            ->addMethods(['writeCallback', 'postWriteCallback'])
+            ->getMock();
+
+        // both pre and post hooks might need access to the file,
+        // so only shared lock is acceptable
+        $eventHandler->expects($this->once())
+            ->method('writeCallback')
+            ->willReturnCallback(
+                function () use ($view, $path, &$wasLockedPre): void {
+                    $wasLockedPre = $this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED);
+                    $wasLockedPre = $wasLockedPre && !$this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE);
+                }
+            );
+        $eventHandler->expects($this->once())
+            ->method('postWriteCallback')
+            ->willReturnCallback(
+                function () use ($view, $path, &$wasLockedPost): void {
+                    $wasLockedPost = $this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED);
+                    $wasLockedPost = $wasLockedPost && !$this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE);
+                }
+            );
+
+        Util::connectHook(
+            Filesystem::CLASSNAME,
+            Filesystem::signal_write,
+            $eventHandler,
+            'writeCallback'
+        );
+        Util::connectHook(
+            Filesystem::CLASSNAME,
+            Filesystem::signal_post_write,
+            $eventHandler,
+            'postWriteCallback'
+        );
+
+        // beforeMethod locks
+        $view->lockFile($path, ILockingProvider::LOCK_SHARED);
+
+        $this->assertNotEmpty($file->put($this->getStream('test data')));
+
+        // afterMethod unlocks
+        $view->unlockFile($path, ILockingProvider::LOCK_SHARED);
+
+        $this->assertTrue($wasLockedPre, 'File was locked during pre-hooks');
+        $this->assertTrue($wasLockedPost, 'File was locked during post-hooks');
+
+        $this->assertFalse(
+            $this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED),
+            'File unlocked after put'
+        );
+        $this->assertFalse(
+            $this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE),
+            'File unlocked after put'
+        );
+    }
+
+    /**
+     * Returns part files in the given path
+     *
+     * @param \OC\Files\View view which root is the current user's "files" folder
+     * @param string $path path for which to list part files
+     *
+     * @return array list of part files
+     */
+    private function listPartFiles(?View $userView = null, $path = '') {
+        if ($userView === null) {
+            $userView = Filesystem::getView();
+        }
+        $files = [];
+        [$storage, $internalPath] = $userView->resolvePath($path);
+        if ($storage instanceof Local) {
+            $realPath = $storage->getSourcePath($internalPath);
+            $dh = opendir($realPath);
+            while (($file = readdir($dh)) !== false) {
+                if (str_ends_with($file, '.part')) {
+                    $files[] = $file;
+                }
+            }
+            closedir($dh);
+        }
+        return $files;
+    }
+
+    /**
+     * returns an array of file information filesize, mtime, filetype,  mimetype
+     *
+     * @param string $path
+     * @param View $userView
+     * @return array
+     */
+    private function getFileInfos($path = '', ?View $userView = null) {
+        if ($userView === null) {
+            $userView = Filesystem::getView();
+        }
+        return [
+            'filesize' => $userView->filesize($path),
+            'mtime' => $userView->filemtime($path),
+            'filetype' => $userView->filetype($path),
+            'mimetype' => $userView->getMimeType($path)
+        ];
+    }
+
+
+    public function testGetFopenFails(): void {
+        $this->expectException(\Sabre\DAV\Exception\ServiceUnavailable::class);
+
+        /** @var View&MockObject */
+        $view = $this->getMockBuilder(View::class)
+            ->onlyMethods(['fopen'])
+            ->getMock();
+        $view->expects($this->atLeastOnce())
+            ->method('fopen')
+            ->willReturn(false);
+
+        $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_ALL,
+            'type' => FileInfo::TYPE_FILE,
+        ], null);
+
+        $file = new File($view, $info);
+
+        $file->get();
+    }
+
+
+    public function testGetFopenThrows(): void {
+        $this->expectException(Forbidden::class);
+
+        /** @var View&MockObject */
+        $view = $this->getMockBuilder(View::class)
+            ->onlyMethods(['fopen'])
+            ->getMock();
+        $view->expects($this->atLeastOnce())
+            ->method('fopen')
+            ->willThrowException(new ForbiddenException('', true));
+
+        $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_ALL,
+            'type' => FileInfo::TYPE_FILE,
+        ], null);
+
+        $file = new File($view, $info);
+
+        $file->get();
+    }
+
+
+    public function testGetThrowsIfNoPermission(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+
+        /** @var View&MockObject */
+        $view = $this->getMockBuilder(View::class)
+            ->onlyMethods(['fopen'])
+            ->getMock();
+        $view->expects($this->never())
+            ->method('fopen');
+
+        $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
+            'permissions' => Constants::PERMISSION_CREATE, // no read perm
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+
+        $file = new  File($view, $info);
+
+        $file->get();
+    }
+
+    public function testSimplePutNoCreatePermissions(): void {
+        $this->logout();
+
+        $storage = new Temporary([]);
+        $storage->file_put_contents('file.txt', 'old content');
+        $noCreateStorage = new PermissionsMask([
+            'storage' => $storage,
+            'mask' => Constants::PERMISSION_ALL - Constants::PERMISSION_CREATE
+        ]);
+
+        $this->registerMount($this->user, $noCreateStorage, '/' . $this->user . '/files/root');
 
-		$this->loginAsUser($this->user);
+        $this->loginAsUser($this->user);
 
-		$view = new View('/' . $this->user . '/files');
+        $view = new View('/' . $this->user . '/files');
 
-		$info = $view->getFileInfo('root/file.txt');
+        $info = $view->getFileInfo('root/file.txt');
 
-		$file = new File($view, $info);
+        $file = new File($view, $info);
 
-		// beforeMethod locks
-		$view->lockFile('root/file.txt', ILockingProvider::LOCK_SHARED);
+        // beforeMethod locks
+        $view->lockFile('root/file.txt', ILockingProvider::LOCK_SHARED);
 
-		$file->put($this->getStream('new content'));
+        $file->put($this->getStream('new content'));
 
-		// afterMethod unlocks
-		$view->unlockFile('root/file.txt', ILockingProvider::LOCK_SHARED);
+        // afterMethod unlocks
+        $view->unlockFile('root/file.txt', ILockingProvider::LOCK_SHARED);
 
-		$this->assertEquals('new content', $view->file_get_contents('root/file.txt'));
-	}
+        $this->assertEquals('new content', $view->file_get_contents('root/file.txt'));
+    }
 
-	public function testPutLockExpired(): void {
-		$view = new View('/' . $this->user . '/files/');
+    public function testPutLockExpired(): void {
+        $view = new View('/' . $this->user . '/files/');
 
-		$path = 'test-locking.txt';
-		$info = new \OC\Files\FileInfo(
-			'/' . $this->user . '/files/' . $path,
-			$this->getMockStorage(),
-			null,
-			[
-				'permissions' => Constants::PERMISSION_ALL,
-				'type' => FileInfo::TYPE_FOLDER,
-			],
-			null
-		);
+        $path = 'test-locking.txt';
+        $info = new \OC\Files\FileInfo(
+            '/' . $this->user . '/files/' . $path,
+            $this->getMockStorage(),
+            null,
+            [
+                'permissions' => Constants::PERMISSION_ALL,
+                'type' => FileInfo::TYPE_FOLDER,
+            ],
+            null
+        );
 
-		$file = new File($view, $info);
+        $file = new File($view, $info);
 
-		// don't lock before the PUT to simulate an expired shared lock
-		$this->assertNotEmpty($file->put($this->getStream('test data')));
+        // don't lock before the PUT to simulate an expired shared lock
+        $this->assertNotEmpty($file->put($this->getStream('test data')));
 
-		// afterMethod unlocks
-		$view->unlockFile($path, ILockingProvider::LOCK_SHARED);
-	}
+        // afterMethod unlocks
+        $view->unlockFile($path, ILockingProvider::LOCK_SHARED);
+    }
 }

Spacing +16 added lines, -16 removed lines

@@ -159,7 +159,7 @@ 
 			->onlyMethods(['writeStream'])
 			->setConstructorArgs([['datadir' => Server::get(ITempManager::class)->getTemporaryFolder()]])
 			->getMock();
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 		/** @var View&MockObject $view */
 		$view = $this->getMockBuilder(View::class)
 			->onlyMethods(['getRelativePath', 'resolvePath'])
@@ -167,7 +167,7 @@ 
 		$view->expects($this->atLeastOnce())
 			->method('resolvePath')
 			->willReturnCallback(
-				function ($path) use ($storage) {
+				function($path) use ($storage) {
 					return [$storage, $path];
 				}
 			);
@@ -223,11 +223,11 @@ 
 		if (!is_null($viewRoot)) {
 			$view = new View($viewRoot);
 		} else {
-			$viewRoot = '/' . $this->user . '/files';
+			$viewRoot = '/'.$this->user.'/files';
 		}
 
 		$info = new \OC\Files\FileInfo(
-			$viewRoot . '/' . ltrim($path, '/'),
+			$viewRoot.'/'.ltrim($path, '/'),
 			$this->getMockStorage(),
 			null,
 			[
@@ -321,7 +321,7 @@ 
 	public function testPutSingleFileLegalMtime(mixed $requestMtime, ?int $resultMtime): void {
 		$request = new Request([
 			'server' => [
-				'HTTP_X_OC_MTIME' => (string)$requestMtime,
+				'HTTP_X_OC_MTIME' => (string) $requestMtime,
 			]
 		], $this->requestId, $this->config, null);
 		$file = 'foo.txt';
@@ -414,7 +414,7 @@ 
 		HookHelper::setUpHooks();
 
 		// happens with public webdav where the view root is the share root
-		$this->assertNotEmpty($this->doPut('/foo.txt', '/' . $this->user . '/files/noderoot'));
+		$this->assertNotEmpty($this->doPut('/foo.txt', '/'.$this->user.'/files/noderoot'));
 
 		$this->assertCount(4, HookHelper::$hookCalls);
 		$this->assertHookCall(
@@ -526,12 +526,12 @@ 
 	 * Test exception during final rename in simple upload mode
 	 */
 	public function testSimplePutFailsMoveFromStorage(): void {
-		$view = new View('/' . $this->user . '/files');
+		$view = new View('/'.$this->user.'/files');
 
 		// simulate situation where the target file is locked
 		$view->lockFile('/test.txt', ILockingProvider::LOCK_EXCLUSIVE);
 
-		$info = new \OC\Files\FileInfo('/' . $this->user . '/files/test.txt', $this->getMockStorage(), null, [
+		$info = new \OC\Files\FileInfo('/'.$this->user.'/files/test.txt', $this->getMockStorage(), null, [
 			'permissions' => Constants::PERMISSION_ALL,
 			'type' => FileInfo::TYPE_FOLDER,
 		], null);
@@ -781,11 +781,11 @@ 
 	 * Test whether locks are set before and after the operation
 	 */
 	public function testPutLocking(): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$path = 'test-locking.txt';
 		$info = new \OC\Files\FileInfo(
-			'/' . $this->user . '/files/' . $path,
+			'/'.$this->user.'/files/'.$path,
 			$this->getMockStorage(),
 			null,
 			[
@@ -817,7 +817,7 @@ 
 		$eventHandler->expects($this->once())
 			->method('writeCallback')
 			->willReturnCallback(
-				function () use ($view, $path, &$wasLockedPre): void {
+				function() use ($view, $path, &$wasLockedPre): void {
 					$wasLockedPre = $this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED);
 					$wasLockedPre = $wasLockedPre && !$this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE);
 				}
@@ -825,7 +825,7 @@ 
 		$eventHandler->expects($this->once())
 			->method('postWriteCallback')
 			->willReturnCallback(
-				function () use ($view, $path, &$wasLockedPost): void {
+				function() use ($view, $path, &$wasLockedPost): void {
 					$wasLockedPost = $this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED);
 					$wasLockedPost = $wasLockedPost && !$this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE);
 				}
@@ -986,11 +986,11 @@ 
 			'mask' => Constants::PERMISSION_ALL - Constants::PERMISSION_CREATE
 		]);
 
-		$this->registerMount($this->user, $noCreateStorage, '/' . $this->user . '/files/root');
+		$this->registerMount($this->user, $noCreateStorage, '/'.$this->user.'/files/root');
 
 		$this->loginAsUser($this->user);
 
-		$view = new View('/' . $this->user . '/files');
+		$view = new View('/'.$this->user.'/files');
 
 		$info = $view->getFileInfo('root/file.txt');
 
@@ -1008,11 +1008,11 @@ 
 	}
 
 	public function testPutLockExpired(): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$path = 'test-locking.txt';
 		$info = new \OC\Files\FileInfo(
-			'/' . $this->user . '/files/' . $path,
+			'/'.$this->user.'/files/'.$path,
 			$this->getMockStorage(),
 			null,
 			[

apps/dav/tests/unit/Connector/Sabre/FilesReportPluginTest.php

Indentation +814 added lines, -814 removed lines

@@ -38,818 +38,818 @@
 
 class FilesReportPluginTest extends \Test\TestCase {
 
-	private \Sabre\DAV\Server&MockObject $server;
-	private Tree&MockObject $tree;
-	private ISystemTagObjectMapper&MockObject $tagMapper;
-	private ISystemTagManager&MockObject $tagManager;
-	private ITags&MockObject $privateTags;
-	private ITagManager&MockObject $privateTagManager;
-	private IUserSession&MockObject $userSession;
-	private FilesReportPluginImplementation $plugin;
-	private View&MockObject $view;
-	private IGroupManager&MockObject $groupManager;
-	private Folder&MockObject $userFolder;
-	private IPreview&MockObject $previewManager;
-	private IAppManager&MockObject $appManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->tree = $this->createMock(Tree::class);
-		$this->view = $this->createMock(View::class);
-
-		$this->server = $this->getMockBuilder(Server::class)
-			->setConstructorArgs([$this->tree])
-			->onlyMethods(['getRequestUri', 'getBaseUri'])
-			->getMock();
-
-		$this->server->expects($this->any())
-			->method('getBaseUri')
-			->willReturn('http://example.com/owncloud/remote.php/dav');
-
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userFolder = $this->createMock(Folder::class);
-		$this->previewManager = $this->createMock(IPreview::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->tagManager = $this->createMock(ISystemTagManager::class);
-		$this->tagMapper = $this->createMock(ISystemTagObjectMapper::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->privateTags = $this->createMock(ITags::class);
-		$this->privateTagManager = $this->createMock(ITagManager::class);
-		$this->privateTagManager->expects($this->any())
-			->method('load')
-			->with('files')
-			->willReturn($this->privateTags);
-
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('testuser');
-		$this->userSession->expects($this->any())
-			->method('getUser')
-			->willReturn($user);
-
-		$this->plugin = new FilesReportPluginImplementation(
-			$this->tree,
-			$this->view,
-			$this->tagManager,
-			$this->tagMapper,
-			$this->privateTagManager,
-			$this->userSession,
-			$this->groupManager,
-			$this->userFolder,
-			$this->appManager
-		);
-	}
-
-	public function testOnReportInvalidNode(): void {
-		$path = 'totally/unrelated/13';
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with('/' . $path)
-			->willReturn($this->createMock(INode::class));
-
-		$this->server->expects($this->any())
-			->method('getRequestUri')
-			->willReturn($path);
-		$this->plugin->initialize($this->server);
-
-		$this->assertNull($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, [], '/' . $path));
-	}
-
-	public function testOnReportInvalidReportName(): void {
-		$path = 'test';
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with('/' . $path)
-			->willReturn(
-				$this->getMockBuilder(INode::class)
-					->disableOriginalConstructor()
-					->getMock()
-			);
-
-		$this->server->expects($this->any())
-			->method('getRequestUri')
-			->willReturn($path);
-		$this->plugin->initialize($this->server);
-
-		$this->assertNull($this->plugin->onReport('{whoever}whatever', [], '/' . $path));
-	}
-
-	public function testOnReport(): void {
-		$path = 'test';
-
-		$parameters = [
-			[
-				'name' => '{DAV:}prop',
-				'value' => [
-					['name' => '{DAV:}getcontentlength', 'value' => ''],
-					['name' => '{http://owncloud.org/ns}size', 'value' => ''],
-				],
-			],
-			[
-				'name' => '{http://owncloud.org/ns}filter-rules',
-				'value' => [
-					['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-					['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-				],
-			],
-		];
-
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$reportTargetNode = $this->createMock(Directory::class);
-		$reportTargetNode->expects($this->any())
-			->method('getPath')
-			->willReturn('');
-
-		$response = $this->createMock(ResponseInterface::class);
-
-		$response->expects($this->once())
-			->method('setHeader')
-			->with('Content-Type', 'application/xml; charset=utf-8');
-
-		$response->expects($this->once())
-			->method('setStatus')
-			->with(207);
-
-		$response->expects($this->once())
-			->method('setBody');
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with('/' . $path)
-			->willReturn($reportTargetNode);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag123, $tag456]);
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->willReturnMap([
-				['OneTwoThree', 'testuser', 0, 0, [$filesNode1]],
-				['FourFiveSix', 'testuser', 0, 0, [$filesNode2]],
-			]);
-
-		$this->server->expects($this->any())
-			->method('getRequestUri')
-			->willReturn($path);
-		$this->server->httpResponse = $response;
-		$this->plugin->initialize($this->server);
-
-		$this->assertFalse($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, $parameters, '/' . $path));
-	}
-
-	public function testFindNodesByFileIdsRoot(): void {
-		$filesNode1 = $this->createMock(Folder::class);
-		$filesNode1->expects($this->once())
-			->method('getName')
-			->willReturn('first node');
-
-		$filesNode2 = $this->createMock(File::class);
-		$filesNode2->expects($this->once())
-			->method('getName')
-			->willReturn('second node');
-
-		$reportTargetNode = $this->createMock(Directory::class);
-		$reportTargetNode->expects($this->any())
-			->method('getPath')
-			->willReturn('/');
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('getFirstNodeById')
-			->willReturnMap([
-				[111, $filesNode1],
-				[222, $filesNode2],
-			]);
-
-		/** @var Directory&MockObject $reportTargetNode */
-		$result = $this->plugin->findNodesByFileIds($reportTargetNode, ['111', '222']);
-
-		$this->assertCount(2, $result);
-		$this->assertInstanceOf(Directory::class, $result[0]);
-		$this->assertEquals('first node', $result[0]->getName());
-		$this->assertInstanceOf(\OCA\DAV\Connector\Sabre\File::class, $result[1]);
-		$this->assertEquals('second node', $result[1]->getName());
-	}
-
-	public function testFindNodesByFileIdsSubDir(): void {
-		$filesNode1 = $this->createMock(Folder::class);
-		$filesNode1->expects($this->once())
-			->method('getName')
-			->willReturn('first node');
-
-		$filesNode2 = $this->createMock(File::class);
-		$filesNode2->expects($this->once())
-			->method('getName')
-			->willReturn('second node');
-
-		$reportTargetNode = $this->createMock(Directory::class);
-		$reportTargetNode->expects($this->any())
-			->method('getPath')
-			->willReturn('/sub1/sub2');
-
-
-		$subNode = $this->createMock(Folder::class);
-
-		$this->userFolder->expects($this->once())
-			->method('get')
-			->with('/sub1/sub2')
-			->willReturn($subNode);
-
-		$subNode->expects($this->exactly(2))
-			->method('getFirstNodeById')
-			->willReturnMap([
-				[111, $filesNode1],
-				[222, $filesNode2],
-			]);
-
-		/** @var Directory&MockObject $reportTargetNode */
-		$result = $this->plugin->findNodesByFileIds($reportTargetNode, ['111', '222']);
-
-		$this->assertCount(2, $result);
-		$this->assertInstanceOf(Directory::class, $result[0]);
-		$this->assertEquals('first node', $result[0]->getName());
-		$this->assertInstanceOf(\OCA\DAV\Connector\Sabre\File::class, $result[1]);
-		$this->assertEquals('second node', $result[1]->getName());
-	}
-
-	public function testPrepareResponses(): void {
-		$requestedProps = ['{DAV:}getcontentlength', '{http://owncloud.org/ns}fileid', '{DAV:}resourcetype'];
-
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->method('isReadable')->willReturn(true);
-
-		$node1 = $this->createMock(Directory::class);
-		$node2 = $this->createMock(\OCA\DAV\Connector\Sabre\File::class);
-
-		$node1->expects($this->once())
-			->method('getInternalFileId')
-			->willReturn('111');
-		$node1->expects($this->any())
-			->method('getPath')
-			->willReturn('/node1');
-		$node1->method('getFileInfo')->willReturn($fileInfo);
-		$node2->expects($this->once())
-			->method('getInternalFileId')
-			->willReturn('222');
-		$node2->expects($this->once())
-			->method('getSize')
-			->willReturn(1024);
-		$node2->expects($this->any())
-			->method('getPath')
-			->willReturn('/sub/node2');
-		$node2->method('getFileInfo')->willReturn($fileInfo);
-
-		$config = $this->createMock(IConfig::class);
-		$validator = $this->createMock(IFilenameValidator::class);
-		$accountManager = $this->createMock(IAccountManager::class);
-
-		$this->server->addPlugin(
-			new FilesPlugin(
-				$this->tree,
-				$config,
-				$this->createMock(IRequest::class),
-				$this->previewManager,
-				$this->createMock(IUserSession::class),
-				$validator,
-				$accountManager,
-			)
-		);
-		$this->plugin->initialize($this->server);
-		$responses = $this->plugin->prepareResponses('/files/username', $requestedProps, [$node1, $node2]);
-
-		$this->assertCount(2, $responses);
-
-		$this->assertEquals('http://example.com/owncloud/remote.php/dav/files/username/node1', $responses[0]->getHref());
-		$this->assertEquals('http://example.com/owncloud/remote.php/dav/files/username/sub/node2', $responses[1]->getHref());
-
-		$props1 = $responses[0]->getResponseProperties();
-		$this->assertEquals('111', $props1[200]['{http://owncloud.org/ns}fileid']);
-		$this->assertNull($props1[404]['{DAV:}getcontentlength']);
-		$this->assertInstanceOf('\Sabre\DAV\Xml\Property\ResourceType', $props1[200]['{DAV:}resourcetype']);
-		$resourceType1 = $props1[200]['{DAV:}resourcetype']->getValue();
-		$this->assertEquals('{DAV:}collection', $resourceType1[0]);
-
-		$props2 = $responses[1]->getResponseProperties();
-		$this->assertEquals('1024', $props2[200]['{DAV:}getcontentlength']);
-		$this->assertEquals('222', $props2[200]['{http://owncloud.org/ns}fileid']);
-		$this->assertInstanceOf('\Sabre\DAV\Xml\Property\ResourceType', $props2[200]['{DAV:}resourcetype']);
-		$this->assertCount(0, $props2[200]['{DAV:}resourcetype']->getValue());
-	}
-
-	public function testProcessFilterRulesSingle(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-		];
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123'])
-			->willReturn([$tag123]);
-
-		$this->userFolder->expects($this->once())
-			->method('searchBySystemTag')
-			->with('OneTwoThree')
-			->willReturn([$filesNode1, $filesNode2]);
-
-		$this->assertEquals([$filesNode1, $filesNode2], self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, 0, 0]));
-	}
-
-	public function testProcessFilterRulesAndCondition(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-		$filesNode3 = $this->createMock(File::class);
-		$filesNode3->expects($this->any())
-			->method('getSize')
-			->willReturn(14);
-		$filesNode3->expects($this->any())
-			->method('getId')
-			->willReturn(333);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag123, $tag456]);
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->willReturnMap([
-				['OneTwoThree', 'testuser', 0, 0, [$filesNode1, $filesNode2]],
-				['FourFiveSix', 'testuser', 0, 0, [$filesNode2, $filesNode3]],
-			]);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		$this->assertEquals([$filesNode2], array_values(self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
-	}
-
-	public function testProcessFilterRulesAndConditionWithOneEmptyResult(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag123, $tag456]);
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->willReturnMap([
-				['OneTwoThree', 'testuser', 0, 0, [$filesNode1, $filesNode2]],
-				['FourFiveSix', 'testuser', 0, 0, []],
-			]);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		$this->assertEquals([], self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]));
-	}
-
-	public function testProcessFilterRulesAndConditionWithFirstEmptyResult(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag123, $tag456]);
-
-		$this->userFolder->expects($this->once())
-			->method('searchBySystemTag')
-			->willReturnMap([
-				['OneTwoThree', 'testuser', 0, 0, []],
-			]);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		$this->assertEquals([], self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]));
-	}
-
-	public function testProcessFilterRulesAndConditionWithEmptyMidResult(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-		$filesNode3 = $this->createMock(Folder::class);
-		$filesNode3->expects($this->any())
-			->method('getSize')
-			->willReturn(13);
-		$filesNode3->expects($this->any())
-			->method('getId')
-			->willReturn(333);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag789 = $this->createMock(ISystemTag::class);
-		$tag789->expects($this->any())
-			->method('getName')
-			->willReturn('SevenEightNine');
-		$tag789->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456', '789'])
-			->willReturn([$tag123, $tag456, $tag789]);
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->willReturnMap([
-				['OneTwoThree', 'testuser', 0, 0, [$filesNode1, $filesNode2]],
-				['FourFiveSix', 'testuser', 0, 0, [$filesNode3]],
-			]);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '789'],
-		];
-
-		$this->assertEquals([], array_values(self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
-	}
-
-	public function testProcessFilterRulesInvisibleTagAsAdmin(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-		$filesNode3 = $this->createMock(Folder::class);
-		$filesNode3->expects($this->any())
-			->method('getSize')
-			->willReturn(13);
-		$filesNode3->expects($this->any())
-			->method('getId')
-			->willReturn(333);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(false);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag123, $tag456]);
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->willReturnMap([
-				['OneTwoThree', 'testuser', 0, 0, [$filesNode1, $filesNode2]],
-				['FourFiveSix', 'testuser', 0, 0, [$filesNode2, $filesNode3]],
-			]);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		$this->assertEquals([$filesNode2], array_values(self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
-	}
-
-
-	public function testProcessFilterRulesInvisibleTagAsUser(): void {
-		$this->expectException(TagNotFoundException::class);
-
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(false);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(false);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willThrowException(new TagNotFoundException());
-
-		$this->userFolder->expects($this->never())
-			->method('searchBySystemTag');
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]);
-	}
-
-	public function testProcessFilterRulesVisibleTagAsUser(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(false);
-
-		$tag1 = $this->createMock(ISystemTag::class);
-		$tag1->expects($this->any())
-			->method('getId')
-			->willReturn('123');
-		$tag1->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag1->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-
-		$tag2 = $this->createMock(ISystemTag::class);
-		$tag2->expects($this->any())
-			->method('getId')
-			->willReturn('123');
-		$tag2->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag2->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag1, $tag2]);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode3 = $this->createMock(Folder::class);
-		$filesNode3->expects($this->any())
-			->method('getId')
-			->willReturn(333);
-		$filesNode3->expects($this->any())
-			->method('getSize')
-			->willReturn(33);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag1, $tag2]);
-
-		// main assertion: only user visible tags are being passed through.
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->willReturnMap([
-				['OneTwoThree', 'testuser', 0, 0, [$filesNode1, $filesNode2]],
-				['FourFiveSix', 'testuser', 0, 0, [$filesNode2, $filesNode3]],
-			]);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		$this->assertEquals([$filesNode2], array_values(self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
-	}
-
-	public function testProcessFavoriteFilter(): void {
-		$rules = [
-			['name' => '{http://owncloud.org/ns}favorite', 'value' => '1'],
-		];
-
-		$this->privateTags->expects($this->once())
-			->method('getFavorites')
-			->willReturn(['456', '789']);
-
-		$this->assertEquals(['456', '789'], array_values(self::invokePrivate($this->plugin, 'processFilterRulesForFileIDs', [$rules])));
-	}
-
-	public static function filesBaseUriProvider(): array {
-		return [
-			['', '', ''],
-			['files/username', '', '/files/username'],
-			['files/username/test', '/test', '/files/username'],
-			['files/username/test/sub', '/test/sub', '/files/username'],
-			['test', '/test', ''],
-		];
-	}
-
-	/**
-	 * @dataProvider filesBaseUriProvider
-	 */
-	public function testFilesBaseUri(string $uri, string $reportPath, string $expectedUri): void {
-		$this->assertEquals($expectedUri, self::invokePrivate($this->plugin, 'getFilesBaseUri', [$uri, $reportPath]));
-	}
+    private \Sabre\DAV\Server&MockObject $server;
+    private Tree&MockObject $tree;
+    private ISystemTagObjectMapper&MockObject $tagMapper;
+    private ISystemTagManager&MockObject $tagManager;
+    private ITags&MockObject $privateTags;
+    private ITagManager&MockObject $privateTagManager;
+    private IUserSession&MockObject $userSession;
+    private FilesReportPluginImplementation $plugin;
+    private View&MockObject $view;
+    private IGroupManager&MockObject $groupManager;
+    private Folder&MockObject $userFolder;
+    private IPreview&MockObject $previewManager;
+    private IAppManager&MockObject $appManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->tree = $this->createMock(Tree::class);
+        $this->view = $this->createMock(View::class);
+
+        $this->server = $this->getMockBuilder(Server::class)
+            ->setConstructorArgs([$this->tree])
+            ->onlyMethods(['getRequestUri', 'getBaseUri'])
+            ->getMock();
+
+        $this->server->expects($this->any())
+            ->method('getBaseUri')
+            ->willReturn('http://example.com/owncloud/remote.php/dav');
+
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userFolder = $this->createMock(Folder::class);
+        $this->previewManager = $this->createMock(IPreview::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->tagManager = $this->createMock(ISystemTagManager::class);
+        $this->tagMapper = $this->createMock(ISystemTagObjectMapper::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->privateTags = $this->createMock(ITags::class);
+        $this->privateTagManager = $this->createMock(ITagManager::class);
+        $this->privateTagManager->expects($this->any())
+            ->method('load')
+            ->with('files')
+            ->willReturn($this->privateTags);
+
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('testuser');
+        $this->userSession->expects($this->any())
+            ->method('getUser')
+            ->willReturn($user);
+
+        $this->plugin = new FilesReportPluginImplementation(
+            $this->tree,
+            $this->view,
+            $this->tagManager,
+            $this->tagMapper,
+            $this->privateTagManager,
+            $this->userSession,
+            $this->groupManager,
+            $this->userFolder,
+            $this->appManager
+        );
+    }
+
+    public function testOnReportInvalidNode(): void {
+        $path = 'totally/unrelated/13';
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with('/' . $path)
+            ->willReturn($this->createMock(INode::class));
+
+        $this->server->expects($this->any())
+            ->method('getRequestUri')
+            ->willReturn($path);
+        $this->plugin->initialize($this->server);
+
+        $this->assertNull($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, [], '/' . $path));
+    }
+
+    public function testOnReportInvalidReportName(): void {
+        $path = 'test';
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with('/' . $path)
+            ->willReturn(
+                $this->getMockBuilder(INode::class)
+                    ->disableOriginalConstructor()
+                    ->getMock()
+            );
+
+        $this->server->expects($this->any())
+            ->method('getRequestUri')
+            ->willReturn($path);
+        $this->plugin->initialize($this->server);
+
+        $this->assertNull($this->plugin->onReport('{whoever}whatever', [], '/' . $path));
+    }
+
+    public function testOnReport(): void {
+        $path = 'test';
+
+        $parameters = [
+            [
+                'name' => '{DAV:}prop',
+                'value' => [
+                    ['name' => '{DAV:}getcontentlength', 'value' => ''],
+                    ['name' => '{http://owncloud.org/ns}size', 'value' => ''],
+                ],
+            ],
+            [
+                'name' => '{http://owncloud.org/ns}filter-rules',
+                'value' => [
+                    ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+                    ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+                ],
+            ],
+        ];
+
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $reportTargetNode = $this->createMock(Directory::class);
+        $reportTargetNode->expects($this->any())
+            ->method('getPath')
+            ->willReturn('');
+
+        $response = $this->createMock(ResponseInterface::class);
+
+        $response->expects($this->once())
+            ->method('setHeader')
+            ->with('Content-Type', 'application/xml; charset=utf-8');
+
+        $response->expects($this->once())
+            ->method('setStatus')
+            ->with(207);
+
+        $response->expects($this->once())
+            ->method('setBody');
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with('/' . $path)
+            ->willReturn($reportTargetNode);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag123, $tag456]);
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->willReturnMap([
+                ['OneTwoThree', 'testuser', 0, 0, [$filesNode1]],
+                ['FourFiveSix', 'testuser', 0, 0, [$filesNode2]],
+            ]);
+
+        $this->server->expects($this->any())
+            ->method('getRequestUri')
+            ->willReturn($path);
+        $this->server->httpResponse = $response;
+        $this->plugin->initialize($this->server);
+
+        $this->assertFalse($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, $parameters, '/' . $path));
+    }
+
+    public function testFindNodesByFileIdsRoot(): void {
+        $filesNode1 = $this->createMock(Folder::class);
+        $filesNode1->expects($this->once())
+            ->method('getName')
+            ->willReturn('first node');
+
+        $filesNode2 = $this->createMock(File::class);
+        $filesNode2->expects($this->once())
+            ->method('getName')
+            ->willReturn('second node');
+
+        $reportTargetNode = $this->createMock(Directory::class);
+        $reportTargetNode->expects($this->any())
+            ->method('getPath')
+            ->willReturn('/');
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('getFirstNodeById')
+            ->willReturnMap([
+                [111, $filesNode1],
+                [222, $filesNode2],
+            ]);
+
+        /** @var Directory&MockObject $reportTargetNode */
+        $result = $this->plugin->findNodesByFileIds($reportTargetNode, ['111', '222']);
+
+        $this->assertCount(2, $result);
+        $this->assertInstanceOf(Directory::class, $result[0]);
+        $this->assertEquals('first node', $result[0]->getName());
+        $this->assertInstanceOf(\OCA\DAV\Connector\Sabre\File::class, $result[1]);
+        $this->assertEquals('second node', $result[1]->getName());
+    }
+
+    public function testFindNodesByFileIdsSubDir(): void {
+        $filesNode1 = $this->createMock(Folder::class);
+        $filesNode1->expects($this->once())
+            ->method('getName')
+            ->willReturn('first node');
+
+        $filesNode2 = $this->createMock(File::class);
+        $filesNode2->expects($this->once())
+            ->method('getName')
+            ->willReturn('second node');
+
+        $reportTargetNode = $this->createMock(Directory::class);
+        $reportTargetNode->expects($this->any())
+            ->method('getPath')
+            ->willReturn('/sub1/sub2');
+
+
+        $subNode = $this->createMock(Folder::class);
+
+        $this->userFolder->expects($this->once())
+            ->method('get')
+            ->with('/sub1/sub2')
+            ->willReturn($subNode);
+
+        $subNode->expects($this->exactly(2))
+            ->method('getFirstNodeById')
+            ->willReturnMap([
+                [111, $filesNode1],
+                [222, $filesNode2],
+            ]);
+
+        /** @var Directory&MockObject $reportTargetNode */
+        $result = $this->plugin->findNodesByFileIds($reportTargetNode, ['111', '222']);
+
+        $this->assertCount(2, $result);
+        $this->assertInstanceOf(Directory::class, $result[0]);
+        $this->assertEquals('first node', $result[0]->getName());
+        $this->assertInstanceOf(\OCA\DAV\Connector\Sabre\File::class, $result[1]);
+        $this->assertEquals('second node', $result[1]->getName());
+    }
+
+    public function testPrepareResponses(): void {
+        $requestedProps = ['{DAV:}getcontentlength', '{http://owncloud.org/ns}fileid', '{DAV:}resourcetype'];
+
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->method('isReadable')->willReturn(true);
+
+        $node1 = $this->createMock(Directory::class);
+        $node2 = $this->createMock(\OCA\DAV\Connector\Sabre\File::class);
+
+        $node1->expects($this->once())
+            ->method('getInternalFileId')
+            ->willReturn('111');
+        $node1->expects($this->any())
+            ->method('getPath')
+            ->willReturn('/node1');
+        $node1->method('getFileInfo')->willReturn($fileInfo);
+        $node2->expects($this->once())
+            ->method('getInternalFileId')
+            ->willReturn('222');
+        $node2->expects($this->once())
+            ->method('getSize')
+            ->willReturn(1024);
+        $node2->expects($this->any())
+            ->method('getPath')
+            ->willReturn('/sub/node2');
+        $node2->method('getFileInfo')->willReturn($fileInfo);
+
+        $config = $this->createMock(IConfig::class);
+        $validator = $this->createMock(IFilenameValidator::class);
+        $accountManager = $this->createMock(IAccountManager::class);
+
+        $this->server->addPlugin(
+            new FilesPlugin(
+                $this->tree,
+                $config,
+                $this->createMock(IRequest::class),
+                $this->previewManager,
+                $this->createMock(IUserSession::class),
+                $validator,
+                $accountManager,
+            )
+        );
+        $this->plugin->initialize($this->server);
+        $responses = $this->plugin->prepareResponses('/files/username', $requestedProps, [$node1, $node2]);
+
+        $this->assertCount(2, $responses);
+
+        $this->assertEquals('http://example.com/owncloud/remote.php/dav/files/username/node1', $responses[0]->getHref());
+        $this->assertEquals('http://example.com/owncloud/remote.php/dav/files/username/sub/node2', $responses[1]->getHref());
+
+        $props1 = $responses[0]->getResponseProperties();
+        $this->assertEquals('111', $props1[200]['{http://owncloud.org/ns}fileid']);
+        $this->assertNull($props1[404]['{DAV:}getcontentlength']);
+        $this->assertInstanceOf('\Sabre\DAV\Xml\Property\ResourceType', $props1[200]['{DAV:}resourcetype']);
+        $resourceType1 = $props1[200]['{DAV:}resourcetype']->getValue();
+        $this->assertEquals('{DAV:}collection', $resourceType1[0]);
+
+        $props2 = $responses[1]->getResponseProperties();
+        $this->assertEquals('1024', $props2[200]['{DAV:}getcontentlength']);
+        $this->assertEquals('222', $props2[200]['{http://owncloud.org/ns}fileid']);
+        $this->assertInstanceOf('\Sabre\DAV\Xml\Property\ResourceType', $props2[200]['{DAV:}resourcetype']);
+        $this->assertCount(0, $props2[200]['{DAV:}resourcetype']->getValue());
+    }
+
+    public function testProcessFilterRulesSingle(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+        ];
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123'])
+            ->willReturn([$tag123]);
+
+        $this->userFolder->expects($this->once())
+            ->method('searchBySystemTag')
+            ->with('OneTwoThree')
+            ->willReturn([$filesNode1, $filesNode2]);
+
+        $this->assertEquals([$filesNode1, $filesNode2], self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, 0, 0]));
+    }
+
+    public function testProcessFilterRulesAndCondition(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+        $filesNode3 = $this->createMock(File::class);
+        $filesNode3->expects($this->any())
+            ->method('getSize')
+            ->willReturn(14);
+        $filesNode3->expects($this->any())
+            ->method('getId')
+            ->willReturn(333);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag123, $tag456]);
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->willReturnMap([
+                ['OneTwoThree', 'testuser', 0, 0, [$filesNode1, $filesNode2]],
+                ['FourFiveSix', 'testuser', 0, 0, [$filesNode2, $filesNode3]],
+            ]);
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        $this->assertEquals([$filesNode2], array_values(self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
+    }
+
+    public function testProcessFilterRulesAndConditionWithOneEmptyResult(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag123, $tag456]);
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->willReturnMap([
+                ['OneTwoThree', 'testuser', 0, 0, [$filesNode1, $filesNode2]],
+                ['FourFiveSix', 'testuser', 0, 0, []],
+            ]);
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        $this->assertEquals([], self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]));
+    }
+
+    public function testProcessFilterRulesAndConditionWithFirstEmptyResult(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag123, $tag456]);
+
+        $this->userFolder->expects($this->once())
+            ->method('searchBySystemTag')
+            ->willReturnMap([
+                ['OneTwoThree', 'testuser', 0, 0, []],
+            ]);
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        $this->assertEquals([], self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]));
+    }
+
+    public function testProcessFilterRulesAndConditionWithEmptyMidResult(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+        $filesNode3 = $this->createMock(Folder::class);
+        $filesNode3->expects($this->any())
+            ->method('getSize')
+            ->willReturn(13);
+        $filesNode3->expects($this->any())
+            ->method('getId')
+            ->willReturn(333);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag789 = $this->createMock(ISystemTag::class);
+        $tag789->expects($this->any())
+            ->method('getName')
+            ->willReturn('SevenEightNine');
+        $tag789->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456', '789'])
+            ->willReturn([$tag123, $tag456, $tag789]);
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->willReturnMap([
+                ['OneTwoThree', 'testuser', 0, 0, [$filesNode1, $filesNode2]],
+                ['FourFiveSix', 'testuser', 0, 0, [$filesNode3]],
+            ]);
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '789'],
+        ];
+
+        $this->assertEquals([], array_values(self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
+    }
+
+    public function testProcessFilterRulesInvisibleTagAsAdmin(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+        $filesNode3 = $this->createMock(Folder::class);
+        $filesNode3->expects($this->any())
+            ->method('getSize')
+            ->willReturn(13);
+        $filesNode3->expects($this->any())
+            ->method('getId')
+            ->willReturn(333);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(false);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag123, $tag456]);
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->willReturnMap([
+                ['OneTwoThree', 'testuser', 0, 0, [$filesNode1, $filesNode2]],
+                ['FourFiveSix', 'testuser', 0, 0, [$filesNode2, $filesNode3]],
+            ]);
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        $this->assertEquals([$filesNode2], array_values(self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
+    }
+
+
+    public function testProcessFilterRulesInvisibleTagAsUser(): void {
+        $this->expectException(TagNotFoundException::class);
+
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(false);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(false);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willThrowException(new TagNotFoundException());
+
+        $this->userFolder->expects($this->never())
+            ->method('searchBySystemTag');
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]);
+    }
+
+    public function testProcessFilterRulesVisibleTagAsUser(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(false);
+
+        $tag1 = $this->createMock(ISystemTag::class);
+        $tag1->expects($this->any())
+            ->method('getId')
+            ->willReturn('123');
+        $tag1->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag1->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+
+        $tag2 = $this->createMock(ISystemTag::class);
+        $tag2->expects($this->any())
+            ->method('getId')
+            ->willReturn('123');
+        $tag2->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag2->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag1, $tag2]);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode3 = $this->createMock(Folder::class);
+        $filesNode3->expects($this->any())
+            ->method('getId')
+            ->willReturn(333);
+        $filesNode3->expects($this->any())
+            ->method('getSize')
+            ->willReturn(33);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag1, $tag2]);
+
+        // main assertion: only user visible tags are being passed through.
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->willReturnMap([
+                ['OneTwoThree', 'testuser', 0, 0, [$filesNode1, $filesNode2]],
+                ['FourFiveSix', 'testuser', 0, 0, [$filesNode2, $filesNode3]],
+            ]);
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        $this->assertEquals([$filesNode2], array_values(self::invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
+    }
+
+    public function testProcessFavoriteFilter(): void {
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}favorite', 'value' => '1'],
+        ];
+
+        $this->privateTags->expects($this->once())
+            ->method('getFavorites')
+            ->willReturn(['456', '789']);
+
+        $this->assertEquals(['456', '789'], array_values(self::invokePrivate($this->plugin, 'processFilterRulesForFileIDs', [$rules])));
+    }
+
+    public static function filesBaseUriProvider(): array {
+        return [
+            ['', '', ''],
+            ['files/username', '', '/files/username'],
+            ['files/username/test', '/test', '/files/username'],
+            ['files/username/test/sub', '/test/sub', '/files/username'],
+            ['test', '/test', ''],
+        ];
+    }
+
+    /**
+     * @dataProvider filesBaseUriProvider
+     */
+    public function testFilesBaseUri(string $uri, string $reportPath, string $expectedUri): void {
+        $this->assertEquals($expectedUri, self::invokePrivate($this->plugin, 'getFilesBaseUri', [$uri, $reportPath]));
+    }
 }

Spacing +6 added lines, -6 removed lines

@@ -107,7 +107,7 @@ 
 
 		$this->tree->expects($this->any())
 			->method('getNodeForPath')
-			->with('/' . $path)
+			->with('/'.$path)
 			->willReturn($this->createMock(INode::class));
 
 		$this->server->expects($this->any())
@@ -115,7 +115,7 @@ 
 			->willReturn($path);
 		$this->plugin->initialize($this->server);
 
-		$this->assertNull($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, [], '/' . $path));
+		$this->assertNull($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, [], '/'.$path));
 	}
 
 	public function testOnReportInvalidReportName(): void {
@@ -123,7 +123,7 @@ 
 
 		$this->tree->expects($this->any())
 			->method('getNodeForPath')
-			->with('/' . $path)
+			->with('/'.$path)
 			->willReturn(
 				$this->getMockBuilder(INode::class)
 					->disableOriginalConstructor()
@@ -135,7 +135,7 @@ 
 			->willReturn($path);
 		$this->plugin->initialize($this->server);
 
-		$this->assertNull($this->plugin->onReport('{whoever}whatever', [], '/' . $path));
+		$this->assertNull($this->plugin->onReport('{whoever}whatever', [], '/'.$path));
 	}
 
 	public function testOnReport(): void {
@@ -182,7 +182,7 @@ 
 
 		$this->tree->expects($this->any())
 			->method('getNodeForPath')
-			->with('/' . $path)
+			->with('/'.$path)
 			->willReturn($reportTargetNode);
 
 		$filesNode1 = $this->createMock(File::class);
@@ -227,7 +227,7 @@ 
 		$this->server->httpResponse = $response;
 		$this->plugin->initialize($this->server);
 
-		$this->assertFalse($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, $parameters, '/' . $path));
+		$this->assertFalse($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, $parameters, '/'.$path));
 	}
 
 	public function testFindNodesByFileIdsRoot(): void {