Completed
Pull Request — master (#7418)
by Blizzz
13:24
created
apps/user_ldap/lib/Access.php 1 patch
Doc Comments   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -503,7 +503,7 @@  discard block
 block discarded – undo
503 503
 
504 504
 	/**
505 505
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
506
-	 * @param string $dn the dn of the user object
506
+	 * @param string $fdn the dn of the user object
507 507
 	 * @param string $ldapName optional, the display name of the object
508 508
 	 * @return string|false with with the name to use in Nextcloud
509 509
 	 */
@@ -790,7 +790,7 @@  discard block
 block discarded – undo
790 790
 	 * the login filter.
791 791
 	 *
792 792
 	 * @param string $loginName
793
-	 * @param array $attributes optional, list of attributes to read
793
+	 * @param string[] $attributes optional, list of attributes to read
794 794
 	 * @return array
795 795
 	 */
796 796
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -876,7 +876,7 @@  discard block
 block discarded – undo
876 876
 
877 877
 	/**
878 878
 	 * @param string $filter
879
-	 * @param string|string[] $attr
879
+	 * @param string[] $attr
880 880
 	 * @param int $limit
881 881
 	 * @param int $offset
882 882
 	 * @return array
@@ -924,7 +924,7 @@  discard block
 block discarded – undo
924 924
 
925 925
 	/**
926 926
 	 * @param string $filter
927
-	 * @param string|string[] $attr
927
+	 * @param string[] $attr
928 928
 	 * @param int $limit
929 929
 	 * @param int $offset
930 930
 	 * @return false|int
@@ -1023,7 +1023,7 @@  discard block
 block discarded – undo
1023 1023
 	/**
1024 1024
 	 * retrieved. Results will according to the order in the array.
1025 1025
 	 *
1026
-	 * @param $filter
1026
+	 * @param string $filter
1027 1027
 	 * @param $base
1028 1028
 	 * @param string[]|null $attr
1029 1029
 	 * @param int $limit optional, maximum results to be counted
@@ -1285,7 +1285,7 @@  discard block
 block discarded – undo
1285 1285
 
1286 1286
 	/**
1287 1287
 	 * @param string $name
1288
-	 * @return bool|mixed|string
1288
+	 * @return string
1289 1289
 	 */
1290 1290
 	public function sanitizeUsername($name) {
1291 1291
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1309,6 +1309,7 @@  discard block
 block discarded – undo
1309 1309
 	* escapes (user provided) parts for LDAP filter
1310 1310
 	* @param string $input, the provided value
1311 1311
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
1312
+	* @param string $input
1312 1313
 	* @return string the escaped string
1313 1314
 	*/
1314 1315
 	public function escapeFilterPart($input, $allowAsterisk = false) {
Please login to merge, or discard this patch.