Completed
Pull Request — master (#4303)
by Björn
23:11 queued 10:06
created
apps/sharebymail/lib/ShareByMailProvider.php 1 patch
Doc Comments   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -237,10 +237,10 @@  discard block
 block discarded – undo
237 237
 	 * publish activity if a file/folder was shared by mail
238 238
 	 *
239 239
 	 * @param $subject
240
-	 * @param $parameters
241
-	 * @param $affectedUser
240
+	 * @param string[] $parameters
241
+	 * @param string $affectedUser
242 242
 	 * @param $fileId
243
-	 * @param $filePath
243
+	 * @param string $filePath
244 244
 	 */
245 245
 	protected function publishActivity($subject, $parameters, $affectedUser, $fileId, $filePath) {
246 246
 		$event = $this->activityManager->generateEvent();
@@ -293,6 +293,12 @@  discard block
 block discarded – undo
293 293
 
294 294
 	}
295 295
 
296
+	/**
297
+	 * @param string $link
298
+	 * @param string $owner
299
+	 * @param string $initiator
300
+	 * @param string $shareWith
301
+	 */
296 302
 	protected function sendMailNotification($filename, $link, $owner, $initiator, $shareWith) {
297 303
 		$ownerUser = $this->userManager->get($owner);
298 304
 		$initiatorUser = $this->userManager->get($initiator);
@@ -326,6 +332,7 @@  discard block
 block discarded – undo
326 332
 	 * @param $link
327 333
 	 * @param $owner
328 334
 	 * @param $initiator
335
+	 * @param string $template
329 336
 	 * @return string plain text mail
330 337
 	 * @throws HintException
331 338
 	 */
@@ -497,6 +504,7 @@  discard block
 block discarded – undo
497 504
 	 * @param string $uidOwner
498 505
 	 * @param int $permissions
499 506
 	 * @param string $token
507
+	 * @param string $password
500 508
 	 * @return int
501 509
 	 */
502 510
 	protected function addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $uidOwner, $permissions, $token, $password) {
@@ -890,7 +898,7 @@  discard block
 block discarded – undo
890 898
 	/**
891 899
 	 * get database row of a give share
892 900
 	 *
893
-	 * @param $id
901
+	 * @param integer $id
894 902
 	 * @return array
895 903
 	 * @throws ShareNotFound
896 904
 	 */
Please login to merge, or discard this patch.