Completed
Pull Request — master (#657)
by Björn
14:39
created
lib/private/Repair/RepairUnmergedShares.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -219,7 +219,7 @@
 block discarded – undo
219 219
 	 * @param array $groupSharesById
220 220
 	 * @param array $subShares
221 221
 	 *
222
-	 * @return true if the share is valid, false if it needs repair
222
+	 * @return boolean if the share is valid, false if it needs repair
223 223
 	 */
224 224
 	private function isThisShareValid($groupSharesById, $subShares) {
225 225
 		$foundTargets = [];
Please login to merge, or discard this patch.
apps/user_ldap/lib/LDAPProvider.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -21,12 +21,10 @@
 block discarded – undo
21 21
 
22 22
 namespace OCA\User_LDAP;
23 23
 
24
-use OCP\IUserBackend;
25 24
 use OCP\LDAP\ILDAPProvider;
26 25
 use OCP\LDAP\IDeletionFlagSupport;
27 26
 use OCP\IServerContainer;
28 27
 use OCA\User_LDAP\User\DeletedUsersIndex;
29
-use OCA\User_LDAP\Mapping\UserMapping;
30 28
 
31 29
 /**
32 30
  * LDAP provider for pulic access to the LDAP backend.
Please login to merge, or discard this patch.
apps/user_ldap/lib/Wizard.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1104,7 +1104,7 @@
 block discarded – undo
1104 1104
 	}
1105 1105
 
1106 1106
 	/**
1107
-	 * @param array $reqs
1107
+	 * @param string[] $reqs
1108 1108
 	 * @return bool
1109 1109
 	 */
1110 1110
 	private function checkRequirements($reqs) {
Please login to merge, or discard this patch.
lib/private/Files/Cache/Wrapper/CacheJail.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 
72 72
 	/**
73 73
 	 * @param array $entry
74
-	 * @return array
74
+	 * @return string
75 75
 	 */
76 76
 	protected function formatCacheEntry($entry) {
77 77
 		if (isset($entry['path'])) {
@@ -190,6 +190,9 @@  discard block
 block discarded – undo
190 190
 		return $this->cache->getStatus($this->getSourcePath($file));
191 191
 	}
192 192
 
193
+	/**
194
+	 * @param \OCP\Files\Cache\ICacheEntry[] $results
195
+	 */
193 196
 	private function formatSearchResults($results) {
194 197
 		$results = array_filter($results, array($this, 'filterCacheEntry'));
195 198
 		$results = array_values($results);
Please login to merge, or discard this patch.
lib/private/IntegrityCheck/Helpers/FileAccessHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
 	 * Wrapper around file_put_contents($filename, $data)
54 54
 	 *
55 55
 	 * @param string $filename
56
-	 * @param $data
56
+	 * @param string $data
57 57
 	 * @return int|false
58 58
 	 */
59 59
 	public function file_put_contents($filename, $data) {
Please login to merge, or discard this patch.
lib/private/legacy/db.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -151,7 +151,6 @@
 block discarded – undo
151 151
 	/**
152 152
 	 * saves database schema to xml file
153 153
 	 * @param string $file name of file
154
-	 * @param int $mode
155 154
 	 * @return bool
156 155
 	 *
157 156
 	 * TODO: write more documentation
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -413,6 +413,10 @@
 block discarded – undo
413 413
 		return $url;
414 414
 	}
415 415
 
416
+	/**
417
+	 * @param string $feature
418
+	 * @param string $value
419
+	 */
416 420
 	public function triggerChange($feature, $value = null) {
417 421
 		if ($this->emitter) {
418 422
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value));
Please login to merge, or discard this patch.
lib/private/AllConfig.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -116,8 +116,8 @@
 block discarded – undo
116 116
 	 * Looks up a system wide defined value
117 117
 	 *
118 118
 	 * @param string $key the key of the value, under which it was saved
119
-	 * @param mixed $default the default value to be returned if the value isn't set
120
-	 * @return mixed the value or $default
119
+	 * @param string|false $default the default value to be returned if the value isn't set
120
+	 * @return string the value or $default
121 121
 	 */
122 122
 	public function getSystemValue($key, $default = '') {
123 123
 		return $this->systemConfig->getValue($key, $default);
Please login to merge, or discard this patch.
apps/sharebymail/lib/FederatedShareProvider.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 	 * Share a path
49 49
 	 *
50 50
 	 * @param IShare $share
51
-	 * @return IShare The share object
51
+	 * @return Share The share object
52 52
 	 * @throws ShareNotFound
53 53
 	 * @throws \Exception
54 54
 	 */
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
 	 * Get a share by token
397 397
 	 *
398 398
 	 * @param string $token
399
-	 * @return IShare
399
+	 * @return Share
400 400
 	 * @throws ShareNotFound
401 401
 	 */
402 402
 	public function getShareByToken($token) {
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
 	 * Create a share object from an database row
428 428
 	 *
429 429
 	 * @param array $data
430
-	 * @return IShare
430
+	 * @return Share
431 431
 	 * @throws InvalidShare
432 432
 	 * @throws ShareNotFound
433 433
 	 */
Please login to merge, or discard this patch.