nextcloud / server

tests/lib/User/UserTest.php

Indentation +996 added lines, -996 removed lines

@@ -33,1000 +33,1000 @@
  * @package Test\User
  */
 class UserTest extends TestCase {
-	/** @var IEventDispatcher|MockObject */
-	protected $dispatcher;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->dispatcher = Server::get(IEventDispatcher::class);
-	}
-
-	public function testDisplayName(): void {
-		/**
-		 * @var \OC\User\Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\OC\User\Backend::class);
-		$backend->expects($this->once())
-			->method('getDisplayName')
-			->with($this->equalTo('foo'))
-			->willReturn('Foo');
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->with($this->equalTo(\OC\User\Backend::GET_DISPLAYNAME))
-			->willReturn(true);
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertEquals('Foo', $user->getDisplayName());
-	}
-
-	/**
-	 * if the display name contain whitespaces only, we expect the uid as result
-	 */
-	public function testDisplayNameEmpty(): void {
-		/**
-		 * @var \OC\User\Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\OC\User\Backend::class);
-		$backend->expects($this->once())
-			->method('getDisplayName')
-			->with($this->equalTo('foo'))
-			->willReturn('  ');
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->with($this->equalTo(\OC\User\Backend::GET_DISPLAYNAME))
-			->willReturn(true);
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertEquals('foo', $user->getDisplayName());
-	}
-
-	public function testDisplayNameNotSupported(): void {
-		/**
-		 * @var \OC\User\Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\OC\User\Backend::class);
-		$backend->expects($this->never())
-			->method('getDisplayName');
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->with($this->equalTo(\OC\User\Backend::GET_DISPLAYNAME))
-			->willReturn(false);
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertEquals('foo', $user->getDisplayName());
-	}
-
-	public function testSetPassword(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-		$backend->expects($this->once())
-			->method('setPassword')
-			->with($this->equalTo('foo'), $this->equalTo('bar'));
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturnCallback(function ($actions) {
-				if ($actions === \OC\User\Backend::SET_PASSWORD) {
-					return true;
-				} else {
-					return false;
-				}
-			});
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertTrue($user->setPassword('bar', ''));
-	}
-
-	public function testSetPasswordNotSupported(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-		$backend->expects($this->never())
-			->method('setPassword');
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturn(false);
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertFalse($user->setPassword('bar', ''));
-	}
-
-	public function testChangeAvatarSupportedYes(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(AvatarUserDummy::class);
-		$backend->expects($this->once())
-			->method('canChangeAvatar')
-			->with($this->equalTo('foo'))
-			->willReturn(true);
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturnCallback(function ($actions) {
-				if ($actions === \OC\User\Backend::PROVIDE_AVATAR) {
-					return true;
-				} else {
-					return false;
-				}
-			});
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertTrue($user->canChangeAvatar());
-	}
-
-	public function testChangeAvatarSupportedNo(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(AvatarUserDummy::class);
-		$backend->expects($this->once())
-			->method('canChangeAvatar')
-			->with($this->equalTo('foo'))
-			->willReturn(false);
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturnCallback(function ($actions) {
-				if ($actions === \OC\User\Backend::PROVIDE_AVATAR) {
-					return true;
-				} else {
-					return false;
-				}
-			});
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertFalse($user->canChangeAvatar());
-	}
-
-	public function testChangeAvatarNotSupported(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(AvatarUserDummy::class);
-		$backend->expects($this->never())
-			->method('canChangeAvatar');
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturn(false);
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertTrue($user->canChangeAvatar());
-	}
-
-	public function testDelete(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-		$backend->expects($this->once())
-			->method('deleteUser')
-			->with($this->equalTo('foo'));
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertTrue($user->delete());
-	}
-
-	public function testDeleteWithDifferentHome(): void {
-		/** @var ObjectHomeMountProvider $homeProvider */
-		$homeProvider = \OC::$server->get(ObjectHomeMountProvider::class);
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('foo');
-		if ($homeProvider->getHomeMountForUser($user, $this->createMock(IStorageFactory::class)) !== null) {
-			$this->markTestSkipped('Skipping test for non local home storage');
-		}
-
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$backend->expects($this->once())
-			->method('implementsActions')
-			->willReturnCallback(function ($actions) {
-				if ($actions === \OC\User\Backend::GET_HOME) {
-					return true;
-				} else {
-					return false;
-				}
-			});
-
-		// important: getHome MUST be called before deleteUser because
-		// once the user is deleted, getHome implementations might not
-		// return anything
-		$backend->expects($this->once())
-			->method('getHome')
-			->with($this->equalTo('foo'))
-			->willReturn('/home/foo');
-
-		$backend->expects($this->once())
-			->method('deleteUser')
-			->with($this->equalTo('foo'));
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertTrue($user->delete());
-	}
-
-	public function testGetHome(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-		$backend->expects($this->once())
-			->method('getHome')
-			->with($this->equalTo('foo'))
-			->willReturn('/home/foo');
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturnCallback(function ($actions) {
-				if ($actions === \OC\User\Backend::GET_HOME) {
-					return true;
-				} else {
-					return false;
-				}
-			});
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertEquals('/home/foo', $user->getHome());
-	}
-
-	public function testGetBackendClassName(): void {
-		$user = new User('foo', new \Test\Util\User\Dummy(), $this->dispatcher);
-		$this->assertEquals('Dummy', $user->getBackendClassName());
-		$user = new User('foo', new \OC\User\Database(), $this->dispatcher);
-		$this->assertEquals('Database', $user->getBackendClassName());
-	}
-
-	public function testGetHomeNotSupported(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-		$backend->expects($this->never())
-			->method('getHome');
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturn(false);
-
-		$allConfig = $this->getMockBuilder(IConfig::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$allConfig->expects($this->any())
-			->method('getUserValue')
-			->willReturn(true);
-		$allConfig->expects($this->any())
-			->method('getSystemValueString')
-			->with($this->equalTo('datadirectory'))
-			->willReturn('arbitrary/path');
-
-		$user = new User('foo', $backend, $this->dispatcher, null, $allConfig);
-		$this->assertEquals('arbitrary/path/foo', $user->getHome());
-	}
-
-	public function testCanChangePassword(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturnCallback(function ($actions) {
-				if ($actions === \OC\User\Backend::SET_PASSWORD) {
-					return true;
-				} else {
-					return false;
-				}
-			});
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertTrue($user->canChangePassword());
-	}
-
-	public function testCanChangePasswordNotSupported(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturn(false);
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertFalse($user->canChangePassword());
-	}
-
-	public function testCanChangeDisplayName(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturnCallback(function ($actions) {
-				if ($actions === \OC\User\Backend::SET_DISPLAYNAME) {
-					return true;
-				} else {
-					return false;
-				}
-			});
-
-		$config = $this->createMock(IConfig::class);
-		$config->method('getSystemValueBool')
-			->with('allow_user_to_change_display_name')
-			->willReturn(true);
-
-		$user = new User('foo', $backend, $this->dispatcher, null, $config);
-		$this->assertTrue($user->canChangeDisplayName());
-	}
-
-	public function testCanChangeDisplayNameNotSupported(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturn(false);
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertFalse($user->canChangeDisplayName());
-	}
-
-	public function testSetDisplayNameSupported(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\OC\User\Database::class);
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturnCallback(function ($actions) {
-				if ($actions === \OC\User\Backend::SET_DISPLAYNAME) {
-					return true;
-				} else {
-					return false;
-				}
-			});
-
-		$backend->expects($this->once())
-			->method('setDisplayName')
-			->with('foo', 'Foo')
-			->willReturn(true);
-
-		$user = new User('foo', $backend, $this->createMock(IEventDispatcher::class));
-		$this->assertTrue($user->setDisplayName('Foo'));
-		$this->assertEquals('Foo', $user->getDisplayName());
-	}
-
-	/**
-	 * don't allow display names containing whitespaces only
-	 */
-	public function testSetDisplayNameEmpty(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\OC\User\Database::class);
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturnCallback(function ($actions) {
-				if ($actions === \OC\User\Backend::SET_DISPLAYNAME) {
-					return true;
-				} else {
-					return false;
-				}
-			});
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertFalse($user->setDisplayName(' '));
-		$this->assertEquals('foo', $user->getDisplayName());
-	}
-
-	public function testSetDisplayNameNotSupported(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\OC\User\Database::class);
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturn(false);
-
-		$backend->expects($this->never())
-			->method('setDisplayName');
-
-		$user = new User('foo', $backend, $this->dispatcher);
-		$this->assertFalse($user->setDisplayName('Foo'));
-		$this->assertEquals('foo', $user->getDisplayName());
-	}
-
-	public function testSetPasswordHooks(): void {
-		$hooksCalled = 0;
-		$test = $this;
-
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-		$backend->expects($this->once())
-			->method('setPassword');
-
-		/**
-		 * @param User $user
-		 * @param string $password
-		 */
-		$hook = function ($user, $password) use ($test, &$hooksCalled) {
-			$hooksCalled++;
-			$test->assertEquals('foo', $user->getUID());
-			$test->assertEquals('bar', $password);
-		};
-
-		$emitter = new PublicEmitter();
-		$emitter->listen('\OC\User', 'preSetPassword', $hook);
-		$emitter->listen('\OC\User', 'postSetPassword', $hook);
-
-		$backend->expects($this->any())
-			->method('implementsActions')
-			->willReturnCallback(function ($actions) {
-				if ($actions === \OC\User\Backend::SET_PASSWORD) {
-					return true;
-				} else {
-					return false;
-				}
-			});
-
-		$user = new User('foo', $backend, $this->dispatcher, $emitter);
-
-		$user->setPassword('bar', '');
-		$this->assertEquals(2, $hooksCalled);
-	}
-
-	public static function dataDeleteHooks(): array {
-		return [
-			[true, 2],
-			[false, 1],
-		];
-	}
-
-	/**
-	 * @dataProvider dataDeleteHooks
-	 * @param bool $result
-	 * @param int $expectedHooks
-	 */
-	public function testDeleteHooks($result, $expectedHooks): void {
-		$hooksCalled = 0;
-		$test = $this;
-
-		/**
-		 * @var UserInterface&MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-		$backend->expects($this->once())
-			->method('deleteUser')
-			->willReturn($result);
-
-		$config = $this->createMock(IConfig::class);
-		$config->method('getSystemValue')
-			->willReturnArgument(1);
-		$config->method('getSystemValueString')
-			->willReturnArgument(1);
-		$config->method('getSystemValueBool')
-			->willReturnArgument(1);
-		$config->method('getSystemValueInt')
-			->willReturnArgument(1);
-
-		$emitter = new PublicEmitter();
-		$user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
-
-		/**
-		 * @param User $user
-		 */
-		$hook = function ($user) use ($test, &$hooksCalled) {
-			$hooksCalled++;
-			$test->assertEquals('foo', $user->getUID());
-		};
-
-		$emitter->listen('\OC\User', 'preDelete', $hook);
-		$emitter->listen('\OC\User', 'postDelete', $hook);
-
-		$commentsManager = $this->createMock(ICommentsManager::class);
-		$notificationManager = $this->createMock(INotificationManager::class);
-
-		if ($result) {
-			$config->expects($this->atLeastOnce())
-				->method('deleteAllUserValues')
-				->with('foo');
-
-			$commentsManager->expects($this->once())
-				->method('deleteReferencesOfActor')
-				->with('users', 'foo');
-			$commentsManager->expects($this->once())
-				->method('deleteReadMarksFromUser')
-				->with($user);
-
-			$notification = $this->createMock(INotification::class);
-			$notification->expects($this->once())
-				->method('setUser')
-				->with('foo');
-
-			$notificationManager->expects($this->once())
-				->method('createNotification')
-				->willReturn($notification);
-			$notificationManager->expects($this->once())
-				->method('markProcessed')
-				->with($notification);
-		} else {
-			$config->expects($this->never())
-				->method('deleteAllUserValues');
-
-			$commentsManager->expects($this->never())
-				->method('deleteReferencesOfActor');
-			$commentsManager->expects($this->never())
-				->method('deleteReadMarksFromUser');
-
-			$notificationManager->expects($this->never())
-				->method('createNotification');
-			$notificationManager->expects($this->never())
-				->method('markProcessed');
-		}
-
-		$this->overwriteService(\OCP\Notification\IManager::class, $notificationManager);
-		$this->overwriteService(\OCP\Comments\ICommentsManager::class, $commentsManager);
-
-		$this->assertSame($result, $user->delete());
-
-		$this->restoreService(AllConfig::class);
-		$this->restoreService(\OCP\Comments\ICommentsManager::class);
-		$this->restoreService(\OCP\Notification\IManager::class);
-
-		$this->assertEquals($expectedHooks, $hooksCalled);
-	}
-
-	public function testDeleteRecoverState() {
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-		$backend->expects($this->once())
-			->method('deleteUser')
-			->willReturn(true);
-
-		$config = $this->createMock(IConfig::class);
-		$config->method('getSystemValue')
-			->willReturnArgument(1);
-		$config->method('getSystemValueString')
-			->willReturnArgument(1);
-		$config->method('getSystemValueBool')
-			->willReturnArgument(1);
-		$config->method('getSystemValueInt')
-			->willReturnArgument(1);
-
-		$userConfig = [];
-		$config->expects(self::atLeast(2))
-			->method('setUserValue')
-			->willReturnCallback(function () {
-				$userConfig[] = func_get_args();
-			});
-
-		$commentsManager = $this->createMock(ICommentsManager::class);
-		$commentsManager->expects($this->once())
-			->method('deleteReferencesOfActor')
-			->willThrowException(new \Error('Test exception'));
-
-		$this->overwriteService(\OCP\Comments\ICommentsManager::class, $commentsManager);
-		$this->expectException(\Error::class);
-
-		$user = $this->getMockBuilder(User::class)
-			->onlyMethods(['getHome'])
-			->setConstructorArgs(['foo', $backend, $this->dispatcher, null, $config])
-			->getMock();
-
-		$user->expects(self::atLeastOnce())
-			->method('getHome')
-			->willReturn('/home/path');
-
-		$user->delete();
-
-		$this->assertEqualsCanonicalizing(
-			[
-				['foo', 'core', 'deleted', 'true', null],
-				['foo', 'core', 'deleted.backup-home', '/home/path', null],
-			],
-			$userConfig,
-		);
-
-		$this->restoreService(\OCP\Comments\ICommentsManager::class);
-	}
-
-	public static function dataGetCloudId(): array {
-		return [
-			['https://localhost:8888/nextcloud', 'foo@localhost:8888/nextcloud'],
-			['http://localhost:8888/nextcloud', 'foo@http://localhost:8888/nextcloud'],
-		];
-	}
-
-	/**
-	 * @dataProvider dataGetCloudId
-	 */
-	public function testGetCloudId(string $absoluteUrl, string $cloudId): void {
-		/** @var Backend|MockObject $backend */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-		$urlGenerator = $this->createMock(IURLGenerator::class);
-		$urlGenerator->method('getAbsoluteURL')
-			->withAnyParameters()
-			->willReturn($absoluteUrl);
-		$user = new User('foo', $backend, $this->dispatcher, null, null, $urlGenerator);
-		$this->assertEquals($cloudId, $user->getCloudId());
-	}
-
-	public function testSetEMailAddressEmpty(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$test = $this;
-		$hooksCalled = 0;
-
-		/**
-		 * @param IUser $user
-		 * @param string $feature
-		 * @param string $value
-		 */
-		$hook = function (IUser $user, $feature, $value) use ($test, &$hooksCalled) {
-			$hooksCalled++;
-			$test->assertEquals('eMailAddress', $feature);
-			$test->assertEquals('', $value);
-		};
-
-		$emitter = new PublicEmitter();
-		$emitter->listen('\OC\User', 'changeUser', $hook);
-
-		$config = $this->createMock(IConfig::class);
-		$config->expects($this->once())
-			->method('deleteUserValue')
-			->with(
-				'foo',
-				'settings',
-				'email'
-			);
-
-		$user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
-		$user->setEMailAddress('');
-	}
-
-	public function testSetEMailAddress(): void {
-		/**
-		 * @var UserInterface | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$test = $this;
-		$hooksCalled = 0;
-
-		/**
-		 * @param IUser $user
-		 * @param string $feature
-		 * @param string $value
-		 */
-		$hook = function (IUser $user, $feature, $value) use ($test, &$hooksCalled) {
-			$hooksCalled++;
-			$test->assertEquals('eMailAddress', $feature);
-			$test->assertEquals('foo@bar.com', $value);
-		};
-
-		$emitter = new PublicEmitter();
-		$emitter->listen('\OC\User', 'changeUser', $hook);
-
-		$config = $this->createMock(IConfig::class);
-		$config->expects($this->once())
-			->method('setUserValue')
-			->with(
-				'foo',
-				'settings',
-				'email',
-				'foo@bar.com'
-			);
-
-		$user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
-		$user->setEMailAddress('foo@bar.com');
-	}
-
-	public function testSetEMailAddressNoChange(): void {
-		/**
-		 * @var UserInterface | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		/** @var PublicEmitter|MockObject $emitter */
-		$emitter = $this->createMock(PublicEmitter::class);
-		$emitter->expects($this->never())
-			->method('emit');
-
-		$dispatcher = $this->createMock(IEventDispatcher::class);
-		$dispatcher->expects($this->never())
-			->method('dispatch');
-
-		$config = $this->createMock(IConfig::class);
-		$config->expects($this->any())
-			->method('getUserValue')
-			->willReturn('foo@bar.com');
-		$config->expects($this->any())
-			->method('setUserValue');
-
-		$user = new User('foo', $backend, $dispatcher, $emitter, $config);
-		$user->setEMailAddress('foo@bar.com');
-	}
-
-	public function testSetQuota(): void {
-		/**
-		 * @var UserInterface | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$test = $this;
-		$hooksCalled = 0;
-
-		/**
-		 * @param IUser $user
-		 * @param string $feature
-		 * @param string $value
-		 */
-		$hook = function (IUser $user, $feature, $value) use ($test, &$hooksCalled) {
-			$hooksCalled++;
-			$test->assertEquals('quota', $feature);
-			$test->assertEquals('23 TB', $value);
-		};
-
-		$emitter = new PublicEmitter();
-		$emitter->listen('\OC\User', 'changeUser', $hook);
-
-		$config = $this->createMock(IConfig::class);
-		$config->expects($this->once())
-			->method('setUserValue')
-			->with(
-				'foo',
-				'files',
-				'quota',
-				'23 TB'
-			);
-
-		$user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
-		$user->setQuota('23 TB');
-	}
-
-	public function testGetDefaultUnlimitedQuota(): void {
-		/**
-		 * @var UserInterface | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		/** @var PublicEmitter|MockObject $emitter */
-		$emitter = $this->createMock(PublicEmitter::class);
-		$emitter->expects($this->never())
-			->method('emit');
-
-		$config = $this->createMock(IConfig::class);
-		$user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
-
-		$userValueMap = [
-			['foo', 'files', 'quota', 'default', 'default'],
-		];
-		$appValueMap = [
-			['files', 'default_quota', 'none', 'none'],
-			// allow unlimited quota
-			['files', 'allow_unlimited_quota', '1', '1'],
-		];
-		$config->method('getUserValue')
-			->will($this->returnValueMap($userValueMap));
-		$config->method('getAppValue')
-			->will($this->returnValueMap($appValueMap));
-
-		$quota = $user->getQuota();
-		$this->assertEquals('none', $quota);
-	}
-
-	public function testGetDefaultUnlimitedQuotaForbidden(): void {
-		/**
-		 * @var UserInterface | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		/** @var PublicEmitter|MockObject $emitter */
-		$emitter = $this->createMock(PublicEmitter::class);
-		$emitter->expects($this->never())
-			->method('emit');
-
-		$config = $this->createMock(IConfig::class);
-		$user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
-
-		$userValueMap = [
-			['foo', 'files', 'quota', 'default', 'default'],
-		];
-		$appValueMap = [
-			['files', 'default_quota', 'none', 'none'],
-			// do not allow unlimited quota
-			['files', 'allow_unlimited_quota', '1', '0'],
-			['files', 'quota_preset', '1 GB, 5 GB, 10 GB', '1 GB, 5 GB, 10 GB'],
-			// expect seeing 1 GB used as fallback value
-			['files', 'default_quota', '1 GB', '1 GB'],
-		];
-		$config->method('getUserValue')
-			->will($this->returnValueMap($userValueMap));
-		$config->method('getAppValue')
-			->will($this->returnValueMap($appValueMap));
-
-		$quota = $user->getQuota();
-		$this->assertEquals('1 GB', $quota);
-	}
-
-	public function testSetQuotaAddressNoChange(): void {
-		/**
-		 * @var UserInterface | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		/** @var PublicEmitter|MockObject $emitter */
-		$emitter = $this->createMock(PublicEmitter::class);
-		$emitter->expects($this->never())
-			->method('emit');
-
-		$config = $this->createMock(IConfig::class);
-		$config->expects($this->any())
-			->method('getUserValue')
-			->willReturn('23 TB');
-		$config->expects($this->never())
-			->method('setUserValue');
-
-		$user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
-		$user->setQuota('23 TB');
-	}
-
-	public function testGetLastLogin(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$config = $this->createMock(IConfig::class);
-		$config->method('getUserValue')
-			->willReturnCallback(function ($uid, $app, $key, $default) {
-				if ($uid === 'foo' && $app === 'login' && $key === 'lastLogin') {
-					return 42;
-				} else {
-					return $default;
-				}
-			});
-
-		$user = new User('foo', $backend, $this->dispatcher, null, $config);
-		$this->assertSame(42, $user->getLastLogin());
-	}
-
-	public function testSetEnabled(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$config = $this->createMock(IConfig::class);
-		$config->expects($this->once())
-			->method('setUserValue')
-			->with(
-				$this->equalTo('foo'),
-				$this->equalTo('core'),
-				$this->equalTo('enabled'),
-				'true'
-			);
-		/* dav event listener gets the manager list from config */
-		$config->expects(self::any())
-			->method('getUserValue')
-			->willReturnCallback(
-				fn ($user, $app, $key, $default) => ($key === 'enabled' ? 'false' : $default)
-			);
-
-		$user = new User('foo', $backend, $this->dispatcher, null, $config);
-		$user->setEnabled(true);
-	}
-
-	public function testSetDisabled(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$config = $this->createMock(IConfig::class);
-		$config->expects($this->once())
-			->method('setUserValue')
-			->with(
-				$this->equalTo('foo'),
-				$this->equalTo('core'),
-				$this->equalTo('enabled'),
-				'false'
-			);
-
-		$user = $this->getMockBuilder(User::class)
-			->setConstructorArgs([
-				'foo',
-				$backend,
-				$this->dispatcher,
-				null,
-				$config,
-			])
-			->onlyMethods(['isEnabled', 'triggerChange'])
-			->getMock();
-
-		$user->expects($this->once())
-			->method('isEnabled')
-			->willReturn(true);
-		$user->expects($this->once())
-			->method('triggerChange')
-			->with(
-				'enabled',
-				false
-			);
-
-		$user->setEnabled(false);
-	}
-
-	public function testSetDisabledAlreadyDisabled(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$config = $this->createMock(IConfig::class);
-		$config->expects($this->never())
-			->method('setUserValue');
-
-		$user = $this->getMockBuilder(User::class)
-			->setConstructorArgs([
-				'foo',
-				$backend,
-				$this->dispatcher,
-				null,
-				$config,
-			])
-			->onlyMethods(['isEnabled', 'triggerChange'])
-			->getMock();
-
-		$user->expects($this->once())
-			->method('isEnabled')
-			->willReturn(false);
-		$user->expects($this->never())
-			->method('triggerChange');
-
-		$user->setEnabled(false);
-	}
-
-	public function testGetEMailAddress(): void {
-		/**
-		 * @var Backend | MockObject $backend
-		 */
-		$backend = $this->createMock(\Test\Util\User\Dummy::class);
-
-		$config = $this->createMock(IConfig::class);
-		$config->method('getUserValue')
-			->willReturnCallback(function ($uid, $app, $key, $default) {
-				if ($uid === 'foo' && $app === 'settings' && $key === 'email') {
-					return 'foo@bar.com';
-				} else {
-					return $default;
-				}
-			});
-
-		$user = new User('foo', $backend, $this->dispatcher, null, $config);
-		$this->assertSame('foo@bar.com', $user->getEMailAddress());
-	}
+    /** @var IEventDispatcher|MockObject */
+    protected $dispatcher;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->dispatcher = Server::get(IEventDispatcher::class);
+    }
+
+    public function testDisplayName(): void {
+        /**
+         * @var \OC\User\Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\OC\User\Backend::class);
+        $backend->expects($this->once())
+            ->method('getDisplayName')
+            ->with($this->equalTo('foo'))
+            ->willReturn('Foo');
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->with($this->equalTo(\OC\User\Backend::GET_DISPLAYNAME))
+            ->willReturn(true);
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertEquals('Foo', $user->getDisplayName());
+    }
+
+    /**
+     * if the display name contain whitespaces only, we expect the uid as result
+     */
+    public function testDisplayNameEmpty(): void {
+        /**
+         * @var \OC\User\Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\OC\User\Backend::class);
+        $backend->expects($this->once())
+            ->method('getDisplayName')
+            ->with($this->equalTo('foo'))
+            ->willReturn('  ');
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->with($this->equalTo(\OC\User\Backend::GET_DISPLAYNAME))
+            ->willReturn(true);
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertEquals('foo', $user->getDisplayName());
+    }
+
+    public function testDisplayNameNotSupported(): void {
+        /**
+         * @var \OC\User\Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\OC\User\Backend::class);
+        $backend->expects($this->never())
+            ->method('getDisplayName');
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->with($this->equalTo(\OC\User\Backend::GET_DISPLAYNAME))
+            ->willReturn(false);
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertEquals('foo', $user->getDisplayName());
+    }
+
+    public function testSetPassword(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+        $backend->expects($this->once())
+            ->method('setPassword')
+            ->with($this->equalTo('foo'), $this->equalTo('bar'));
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturnCallback(function ($actions) {
+                if ($actions === \OC\User\Backend::SET_PASSWORD) {
+                    return true;
+                } else {
+                    return false;
+                }
+            });
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertTrue($user->setPassword('bar', ''));
+    }
+
+    public function testSetPasswordNotSupported(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+        $backend->expects($this->never())
+            ->method('setPassword');
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturn(false);
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertFalse($user->setPassword('bar', ''));
+    }
+
+    public function testChangeAvatarSupportedYes(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(AvatarUserDummy::class);
+        $backend->expects($this->once())
+            ->method('canChangeAvatar')
+            ->with($this->equalTo('foo'))
+            ->willReturn(true);
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturnCallback(function ($actions) {
+                if ($actions === \OC\User\Backend::PROVIDE_AVATAR) {
+                    return true;
+                } else {
+                    return false;
+                }
+            });
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertTrue($user->canChangeAvatar());
+    }
+
+    public function testChangeAvatarSupportedNo(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(AvatarUserDummy::class);
+        $backend->expects($this->once())
+            ->method('canChangeAvatar')
+            ->with($this->equalTo('foo'))
+            ->willReturn(false);
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturnCallback(function ($actions) {
+                if ($actions === \OC\User\Backend::PROVIDE_AVATAR) {
+                    return true;
+                } else {
+                    return false;
+                }
+            });
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertFalse($user->canChangeAvatar());
+    }
+
+    public function testChangeAvatarNotSupported(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(AvatarUserDummy::class);
+        $backend->expects($this->never())
+            ->method('canChangeAvatar');
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturn(false);
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertTrue($user->canChangeAvatar());
+    }
+
+    public function testDelete(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+        $backend->expects($this->once())
+            ->method('deleteUser')
+            ->with($this->equalTo('foo'));
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertTrue($user->delete());
+    }
+
+    public function testDeleteWithDifferentHome(): void {
+        /** @var ObjectHomeMountProvider $homeProvider */
+        $homeProvider = \OC::$server->get(ObjectHomeMountProvider::class);
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('foo');
+        if ($homeProvider->getHomeMountForUser($user, $this->createMock(IStorageFactory::class)) !== null) {
+            $this->markTestSkipped('Skipping test for non local home storage');
+        }
+
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $backend->expects($this->once())
+            ->method('implementsActions')
+            ->willReturnCallback(function ($actions) {
+                if ($actions === \OC\User\Backend::GET_HOME) {
+                    return true;
+                } else {
+                    return false;
+                }
+            });
+
+        // important: getHome MUST be called before deleteUser because
+        // once the user is deleted, getHome implementations might not
+        // return anything
+        $backend->expects($this->once())
+            ->method('getHome')
+            ->with($this->equalTo('foo'))
+            ->willReturn('/home/foo');
+
+        $backend->expects($this->once())
+            ->method('deleteUser')
+            ->with($this->equalTo('foo'));
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertTrue($user->delete());
+    }
+
+    public function testGetHome(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+        $backend->expects($this->once())
+            ->method('getHome')
+            ->with($this->equalTo('foo'))
+            ->willReturn('/home/foo');
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturnCallback(function ($actions) {
+                if ($actions === \OC\User\Backend::GET_HOME) {
+                    return true;
+                } else {
+                    return false;
+                }
+            });
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertEquals('/home/foo', $user->getHome());
+    }
+
+    public function testGetBackendClassName(): void {
+        $user = new User('foo', new \Test\Util\User\Dummy(), $this->dispatcher);
+        $this->assertEquals('Dummy', $user->getBackendClassName());
+        $user = new User('foo', new \OC\User\Database(), $this->dispatcher);
+        $this->assertEquals('Database', $user->getBackendClassName());
+    }
+
+    public function testGetHomeNotSupported(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+        $backend->expects($this->never())
+            ->method('getHome');
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturn(false);
+
+        $allConfig = $this->getMockBuilder(IConfig::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $allConfig->expects($this->any())
+            ->method('getUserValue')
+            ->willReturn(true);
+        $allConfig->expects($this->any())
+            ->method('getSystemValueString')
+            ->with($this->equalTo('datadirectory'))
+            ->willReturn('arbitrary/path');
+
+        $user = new User('foo', $backend, $this->dispatcher, null, $allConfig);
+        $this->assertEquals('arbitrary/path/foo', $user->getHome());
+    }
+
+    public function testCanChangePassword(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturnCallback(function ($actions) {
+                if ($actions === \OC\User\Backend::SET_PASSWORD) {
+                    return true;
+                } else {
+                    return false;
+                }
+            });
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertTrue($user->canChangePassword());
+    }
+
+    public function testCanChangePasswordNotSupported(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturn(false);
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertFalse($user->canChangePassword());
+    }
+
+    public function testCanChangeDisplayName(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturnCallback(function ($actions) {
+                if ($actions === \OC\User\Backend::SET_DISPLAYNAME) {
+                    return true;
+                } else {
+                    return false;
+                }
+            });
+
+        $config = $this->createMock(IConfig::class);
+        $config->method('getSystemValueBool')
+            ->with('allow_user_to_change_display_name')
+            ->willReturn(true);
+
+        $user = new User('foo', $backend, $this->dispatcher, null, $config);
+        $this->assertTrue($user->canChangeDisplayName());
+    }
+
+    public function testCanChangeDisplayNameNotSupported(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturn(false);
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertFalse($user->canChangeDisplayName());
+    }
+
+    public function testSetDisplayNameSupported(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\OC\User\Database::class);
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturnCallback(function ($actions) {
+                if ($actions === \OC\User\Backend::SET_DISPLAYNAME) {
+                    return true;
+                } else {
+                    return false;
+                }
+            });
+
+        $backend->expects($this->once())
+            ->method('setDisplayName')
+            ->with('foo', 'Foo')
+            ->willReturn(true);
+
+        $user = new User('foo', $backend, $this->createMock(IEventDispatcher::class));
+        $this->assertTrue($user->setDisplayName('Foo'));
+        $this->assertEquals('Foo', $user->getDisplayName());
+    }
+
+    /**
+     * don't allow display names containing whitespaces only
+     */
+    public function testSetDisplayNameEmpty(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\OC\User\Database::class);
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturnCallback(function ($actions) {
+                if ($actions === \OC\User\Backend::SET_DISPLAYNAME) {
+                    return true;
+                } else {
+                    return false;
+                }
+            });
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertFalse($user->setDisplayName(' '));
+        $this->assertEquals('foo', $user->getDisplayName());
+    }
+
+    public function testSetDisplayNameNotSupported(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\OC\User\Database::class);
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturn(false);
+
+        $backend->expects($this->never())
+            ->method('setDisplayName');
+
+        $user = new User('foo', $backend, $this->dispatcher);
+        $this->assertFalse($user->setDisplayName('Foo'));
+        $this->assertEquals('foo', $user->getDisplayName());
+    }
+
+    public function testSetPasswordHooks(): void {
+        $hooksCalled = 0;
+        $test = $this;
+
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+        $backend->expects($this->once())
+            ->method('setPassword');
+
+        /**
+         * @param User $user
+         * @param string $password
+         */
+        $hook = function ($user, $password) use ($test, &$hooksCalled) {
+            $hooksCalled++;
+            $test->assertEquals('foo', $user->getUID());
+            $test->assertEquals('bar', $password);
+        };
+
+        $emitter = new PublicEmitter();
+        $emitter->listen('\OC\User', 'preSetPassword', $hook);
+        $emitter->listen('\OC\User', 'postSetPassword', $hook);
+
+        $backend->expects($this->any())
+            ->method('implementsActions')
+            ->willReturnCallback(function ($actions) {
+                if ($actions === \OC\User\Backend::SET_PASSWORD) {
+                    return true;
+                } else {
+                    return false;
+                }
+            });
+
+        $user = new User('foo', $backend, $this->dispatcher, $emitter);
+
+        $user->setPassword('bar', '');
+        $this->assertEquals(2, $hooksCalled);
+    }
+
+    public static function dataDeleteHooks(): array {
+        return [
+            [true, 2],
+            [false, 1],
+        ];
+    }
+
+    /**
+     * @dataProvider dataDeleteHooks
+     * @param bool $result
+     * @param int $expectedHooks
+     */
+    public function testDeleteHooks($result, $expectedHooks): void {
+        $hooksCalled = 0;
+        $test = $this;
+
+        /**
+         * @var UserInterface&MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+        $backend->expects($this->once())
+            ->method('deleteUser')
+            ->willReturn($result);
+
+        $config = $this->createMock(IConfig::class);
+        $config->method('getSystemValue')
+            ->willReturnArgument(1);
+        $config->method('getSystemValueString')
+            ->willReturnArgument(1);
+        $config->method('getSystemValueBool')
+            ->willReturnArgument(1);
+        $config->method('getSystemValueInt')
+            ->willReturnArgument(1);
+
+        $emitter = new PublicEmitter();
+        $user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
+
+        /**
+         * @param User $user
+         */
+        $hook = function ($user) use ($test, &$hooksCalled) {
+            $hooksCalled++;
+            $test->assertEquals('foo', $user->getUID());
+        };
+
+        $emitter->listen('\OC\User', 'preDelete', $hook);
+        $emitter->listen('\OC\User', 'postDelete', $hook);
+
+        $commentsManager = $this->createMock(ICommentsManager::class);
+        $notificationManager = $this->createMock(INotificationManager::class);
+
+        if ($result) {
+            $config->expects($this->atLeastOnce())
+                ->method('deleteAllUserValues')
+                ->with('foo');
+
+            $commentsManager->expects($this->once())
+                ->method('deleteReferencesOfActor')
+                ->with('users', 'foo');
+            $commentsManager->expects($this->once())
+                ->method('deleteReadMarksFromUser')
+                ->with($user);
+
+            $notification = $this->createMock(INotification::class);
+            $notification->expects($this->once())
+                ->method('setUser')
+                ->with('foo');
+
+            $notificationManager->expects($this->once())
+                ->method('createNotification')
+                ->willReturn($notification);
+            $notificationManager->expects($this->once())
+                ->method('markProcessed')
+                ->with($notification);
+        } else {
+            $config->expects($this->never())
+                ->method('deleteAllUserValues');
+
+            $commentsManager->expects($this->never())
+                ->method('deleteReferencesOfActor');
+            $commentsManager->expects($this->never())
+                ->method('deleteReadMarksFromUser');
+
+            $notificationManager->expects($this->never())
+                ->method('createNotification');
+            $notificationManager->expects($this->never())
+                ->method('markProcessed');
+        }
+
+        $this->overwriteService(\OCP\Notification\IManager::class, $notificationManager);
+        $this->overwriteService(\OCP\Comments\ICommentsManager::class, $commentsManager);
+
+        $this->assertSame($result, $user->delete());
+
+        $this->restoreService(AllConfig::class);
+        $this->restoreService(\OCP\Comments\ICommentsManager::class);
+        $this->restoreService(\OCP\Notification\IManager::class);
+
+        $this->assertEquals($expectedHooks, $hooksCalled);
+    }
+
+    public function testDeleteRecoverState() {
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+        $backend->expects($this->once())
+            ->method('deleteUser')
+            ->willReturn(true);
+
+        $config = $this->createMock(IConfig::class);
+        $config->method('getSystemValue')
+            ->willReturnArgument(1);
+        $config->method('getSystemValueString')
+            ->willReturnArgument(1);
+        $config->method('getSystemValueBool')
+            ->willReturnArgument(1);
+        $config->method('getSystemValueInt')
+            ->willReturnArgument(1);
+
+        $userConfig = [];
+        $config->expects(self::atLeast(2))
+            ->method('setUserValue')
+            ->willReturnCallback(function () {
+                $userConfig[] = func_get_args();
+            });
+
+        $commentsManager = $this->createMock(ICommentsManager::class);
+        $commentsManager->expects($this->once())
+            ->method('deleteReferencesOfActor')
+            ->willThrowException(new \Error('Test exception'));
+
+        $this->overwriteService(\OCP\Comments\ICommentsManager::class, $commentsManager);
+        $this->expectException(\Error::class);
+
+        $user = $this->getMockBuilder(User::class)
+            ->onlyMethods(['getHome'])
+            ->setConstructorArgs(['foo', $backend, $this->dispatcher, null, $config])
+            ->getMock();
+
+        $user->expects(self::atLeastOnce())
+            ->method('getHome')
+            ->willReturn('/home/path');
+
+        $user->delete();
+
+        $this->assertEqualsCanonicalizing(
+            [
+                ['foo', 'core', 'deleted', 'true', null],
+                ['foo', 'core', 'deleted.backup-home', '/home/path', null],
+            ],
+            $userConfig,
+        );
+
+        $this->restoreService(\OCP\Comments\ICommentsManager::class);
+    }
+
+    public static function dataGetCloudId(): array {
+        return [
+            ['https://localhost:8888/nextcloud', 'foo@localhost:8888/nextcloud'],
+            ['http://localhost:8888/nextcloud', 'foo@http://localhost:8888/nextcloud'],
+        ];
+    }
+
+    /**
+     * @dataProvider dataGetCloudId
+     */
+    public function testGetCloudId(string $absoluteUrl, string $cloudId): void {
+        /** @var Backend|MockObject $backend */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+        $urlGenerator = $this->createMock(IURLGenerator::class);
+        $urlGenerator->method('getAbsoluteURL')
+            ->withAnyParameters()
+            ->willReturn($absoluteUrl);
+        $user = new User('foo', $backend, $this->dispatcher, null, null, $urlGenerator);
+        $this->assertEquals($cloudId, $user->getCloudId());
+    }
+
+    public function testSetEMailAddressEmpty(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $test = $this;
+        $hooksCalled = 0;
+
+        /**
+         * @param IUser $user
+         * @param string $feature
+         * @param string $value
+         */
+        $hook = function (IUser $user, $feature, $value) use ($test, &$hooksCalled) {
+            $hooksCalled++;
+            $test->assertEquals('eMailAddress', $feature);
+            $test->assertEquals('', $value);
+        };
+
+        $emitter = new PublicEmitter();
+        $emitter->listen('\OC\User', 'changeUser', $hook);
+
+        $config = $this->createMock(IConfig::class);
+        $config->expects($this->once())
+            ->method('deleteUserValue')
+            ->with(
+                'foo',
+                'settings',
+                'email'
+            );
+
+        $user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
+        $user->setEMailAddress('');
+    }
+
+    public function testSetEMailAddress(): void {
+        /**
+         * @var UserInterface | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $test = $this;
+        $hooksCalled = 0;
+
+        /**
+         * @param IUser $user
+         * @param string $feature
+         * @param string $value
+         */
+        $hook = function (IUser $user, $feature, $value) use ($test, &$hooksCalled) {
+            $hooksCalled++;
+            $test->assertEquals('eMailAddress', $feature);
+            $test->assertEquals('foo@bar.com', $value);
+        };
+
+        $emitter = new PublicEmitter();
+        $emitter->listen('\OC\User', 'changeUser', $hook);
+
+        $config = $this->createMock(IConfig::class);
+        $config->expects($this->once())
+            ->method('setUserValue')
+            ->with(
+                'foo',
+                'settings',
+                'email',
+                'foo@bar.com'
+            );
+
+        $user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
+        $user->setEMailAddress('foo@bar.com');
+    }
+
+    public function testSetEMailAddressNoChange(): void {
+        /**
+         * @var UserInterface | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        /** @var PublicEmitter|MockObject $emitter */
+        $emitter = $this->createMock(PublicEmitter::class);
+        $emitter->expects($this->never())
+            ->method('emit');
+
+        $dispatcher = $this->createMock(IEventDispatcher::class);
+        $dispatcher->expects($this->never())
+            ->method('dispatch');
+
+        $config = $this->createMock(IConfig::class);
+        $config->expects($this->any())
+            ->method('getUserValue')
+            ->willReturn('foo@bar.com');
+        $config->expects($this->any())
+            ->method('setUserValue');
+
+        $user = new User('foo', $backend, $dispatcher, $emitter, $config);
+        $user->setEMailAddress('foo@bar.com');
+    }
+
+    public function testSetQuota(): void {
+        /**
+         * @var UserInterface | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $test = $this;
+        $hooksCalled = 0;
+
+        /**
+         * @param IUser $user
+         * @param string $feature
+         * @param string $value
+         */
+        $hook = function (IUser $user, $feature, $value) use ($test, &$hooksCalled) {
+            $hooksCalled++;
+            $test->assertEquals('quota', $feature);
+            $test->assertEquals('23 TB', $value);
+        };
+
+        $emitter = new PublicEmitter();
+        $emitter->listen('\OC\User', 'changeUser', $hook);
+
+        $config = $this->createMock(IConfig::class);
+        $config->expects($this->once())
+            ->method('setUserValue')
+            ->with(
+                'foo',
+                'files',
+                'quota',
+                '23 TB'
+            );
+
+        $user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
+        $user->setQuota('23 TB');
+    }
+
+    public function testGetDefaultUnlimitedQuota(): void {
+        /**
+         * @var UserInterface | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        /** @var PublicEmitter|MockObject $emitter */
+        $emitter = $this->createMock(PublicEmitter::class);
+        $emitter->expects($this->never())
+            ->method('emit');
+
+        $config = $this->createMock(IConfig::class);
+        $user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
+
+        $userValueMap = [
+            ['foo', 'files', 'quota', 'default', 'default'],
+        ];
+        $appValueMap = [
+            ['files', 'default_quota', 'none', 'none'],
+            // allow unlimited quota
+            ['files', 'allow_unlimited_quota', '1', '1'],
+        ];
+        $config->method('getUserValue')
+            ->will($this->returnValueMap($userValueMap));
+        $config->method('getAppValue')
+            ->will($this->returnValueMap($appValueMap));
+
+        $quota = $user->getQuota();
+        $this->assertEquals('none', $quota);
+    }
+
+    public function testGetDefaultUnlimitedQuotaForbidden(): void {
+        /**
+         * @var UserInterface | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        /** @var PublicEmitter|MockObject $emitter */
+        $emitter = $this->createMock(PublicEmitter::class);
+        $emitter->expects($this->never())
+            ->method('emit');
+
+        $config = $this->createMock(IConfig::class);
+        $user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
+
+        $userValueMap = [
+            ['foo', 'files', 'quota', 'default', 'default'],
+        ];
+        $appValueMap = [
+            ['files', 'default_quota', 'none', 'none'],
+            // do not allow unlimited quota
+            ['files', 'allow_unlimited_quota', '1', '0'],
+            ['files', 'quota_preset', '1 GB, 5 GB, 10 GB', '1 GB, 5 GB, 10 GB'],
+            // expect seeing 1 GB used as fallback value
+            ['files', 'default_quota', '1 GB', '1 GB'],
+        ];
+        $config->method('getUserValue')
+            ->will($this->returnValueMap($userValueMap));
+        $config->method('getAppValue')
+            ->will($this->returnValueMap($appValueMap));
+
+        $quota = $user->getQuota();
+        $this->assertEquals('1 GB', $quota);
+    }
+
+    public function testSetQuotaAddressNoChange(): void {
+        /**
+         * @var UserInterface | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        /** @var PublicEmitter|MockObject $emitter */
+        $emitter = $this->createMock(PublicEmitter::class);
+        $emitter->expects($this->never())
+            ->method('emit');
+
+        $config = $this->createMock(IConfig::class);
+        $config->expects($this->any())
+            ->method('getUserValue')
+            ->willReturn('23 TB');
+        $config->expects($this->never())
+            ->method('setUserValue');
+
+        $user = new User('foo', $backend, $this->dispatcher, $emitter, $config);
+        $user->setQuota('23 TB');
+    }
+
+    public function testGetLastLogin(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $config = $this->createMock(IConfig::class);
+        $config->method('getUserValue')
+            ->willReturnCallback(function ($uid, $app, $key, $default) {
+                if ($uid === 'foo' && $app === 'login' && $key === 'lastLogin') {
+                    return 42;
+                } else {
+                    return $default;
+                }
+            });
+
+        $user = new User('foo', $backend, $this->dispatcher, null, $config);
+        $this->assertSame(42, $user->getLastLogin());
+    }
+
+    public function testSetEnabled(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $config = $this->createMock(IConfig::class);
+        $config->expects($this->once())
+            ->method('setUserValue')
+            ->with(
+                $this->equalTo('foo'),
+                $this->equalTo('core'),
+                $this->equalTo('enabled'),
+                'true'
+            );
+        /* dav event listener gets the manager list from config */
+        $config->expects(self::any())
+            ->method('getUserValue')
+            ->willReturnCallback(
+                fn ($user, $app, $key, $default) => ($key === 'enabled' ? 'false' : $default)
+            );
+
+        $user = new User('foo', $backend, $this->dispatcher, null, $config);
+        $user->setEnabled(true);
+    }
+
+    public function testSetDisabled(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $config = $this->createMock(IConfig::class);
+        $config->expects($this->once())
+            ->method('setUserValue')
+            ->with(
+                $this->equalTo('foo'),
+                $this->equalTo('core'),
+                $this->equalTo('enabled'),
+                'false'
+            );
+
+        $user = $this->getMockBuilder(User::class)
+            ->setConstructorArgs([
+                'foo',
+                $backend,
+                $this->dispatcher,
+                null,
+                $config,
+            ])
+            ->onlyMethods(['isEnabled', 'triggerChange'])
+            ->getMock();
+
+        $user->expects($this->once())
+            ->method('isEnabled')
+            ->willReturn(true);
+        $user->expects($this->once())
+            ->method('triggerChange')
+            ->with(
+                'enabled',
+                false
+            );
+
+        $user->setEnabled(false);
+    }
+
+    public function testSetDisabledAlreadyDisabled(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $config = $this->createMock(IConfig::class);
+        $config->expects($this->never())
+            ->method('setUserValue');
+
+        $user = $this->getMockBuilder(User::class)
+            ->setConstructorArgs([
+                'foo',
+                $backend,
+                $this->dispatcher,
+                null,
+                $config,
+            ])
+            ->onlyMethods(['isEnabled', 'triggerChange'])
+            ->getMock();
+
+        $user->expects($this->once())
+            ->method('isEnabled')
+            ->willReturn(false);
+        $user->expects($this->never())
+            ->method('triggerChange');
+
+        $user->setEnabled(false);
+    }
+
+    public function testGetEMailAddress(): void {
+        /**
+         * @var Backend | MockObject $backend
+         */
+        $backend = $this->createMock(\Test\Util\User\Dummy::class);
+
+        $config = $this->createMock(IConfig::class);
+        $config->method('getUserValue')
+            ->willReturnCallback(function ($uid, $app, $key, $default) {
+                if ($uid === 'foo' && $app === 'settings' && $key === 'email') {
+                    return 'foo@bar.com';
+                } else {
+                    return $default;
+                }
+            });
+
+        $user = new User('foo', $backend, $this->dispatcher, null, $config);
+        $this->assertSame('foo@bar.com', $user->getEMailAddress());
+    }
 }

tests/lib/Mail/MailerTest.php

Indentation +336 added lines, -336 removed lines

@@ -27,340 +27,340 @@
 use Test\TestCase;
 
 class MailerTest extends TestCase {
-	/** @var IConfig|MockObject */
-	private $config;
-	/** @var Defaults|MockObject */
-	private $defaults;
-	/** @var LoggerInterface|MockObject */
-	private $logger;
-	/** @var IURLGenerator|MockObject */
-	private $urlGenerator;
-	/** @var IL10N|MockObject */
-	private $l10n;
-	/** @var Mailer */
-	private $mailer;
-	/** @var IEventDispatcher&MockObject */
-	private $dispatcher;
-
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->createMock(IConfig::class);
-		$this->defaults = $this->createMock(Defaults::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->dispatcher = $this->createMock(IEventDispatcher::class);
-		$this->mailer = new Mailer(
-			$this->config,
-			$this->logger,
-			$this->defaults,
-			$this->urlGenerator,
-			$this->l10n,
-			$this->dispatcher,
-			$this->createMock(IFactory::class)
-		);
-	}
-
-	/**
-	 * @return array
-	 */
-	public static function sendmailModeProvider(): array {
-		return [
-			'smtp' => ['smtp', ' -bs'],
-			'pipe' => ['pipe', ' -t -i'],
-		];
-	}
-
-	/**
-	 * @dataProvider sendmailModeProvider
-	 * @param $sendmailMode
-	 * @param $binaryParam
-	 */
-	public function testGetSendmailInstanceSendMail($sendmailMode, $binaryParam): void {
-		$this->config
-			->expects($this->exactly(2))
-			->method('getSystemValueString')
-			->willReturnMap([
-				['mail_smtpmode', 'smtp', 'sendmail'],
-				['mail_sendmailmode', 'smtp', $sendmailMode],
-			]);
-
-		$path = \OCP\Server::get(IBinaryFinder::class)->findBinaryPath('sendmail');
-		if ($path === false) {
-			$path = '/usr/sbin/sendmail';
-		}
-
-		$expected = new SendmailTransport($path . $binaryParam, null, $this->logger);
-		$this->assertEquals($expected, self::invokePrivate($this->mailer, 'getSendMailInstance'));
-	}
-
-	/**
-	 * @dataProvider sendmailModeProvider
-	 * @param $sendmailMode
-	 * @param $binaryParam
-	 */
-	public function testGetSendmailInstanceSendMailQmail($sendmailMode, $binaryParam): void {
-		$this->config
-			->expects($this->exactly(2))
-			->method('getSystemValueString')
-			->willReturnMap([
-				['mail_smtpmode', 'smtp', 'qmail'],
-				['mail_sendmailmode', 'smtp', $sendmailMode],
-			]);
-
-		$sendmail = new SendmailTransport('/var/qmail/bin/sendmail' . $binaryParam, null, $this->logger);
-		$this->assertEquals($sendmail, self::invokePrivate($this->mailer, 'getSendMailInstance'));
-	}
-
-	public function testEventForNullTransport(): void {
-		$this->config
-			->expects($this->exactly(1))
-			->method('getSystemValueString')
-			->with('mail_smtpmode', 'smtp')
-			->willReturn('null');
-
-		$message = $this->createMock(Message::class);
-		$message->expects($this->once())
-			->method('getSymfonyEmail')
-			->willReturn((new Email())->to('foo@bar.com')->from('bar@foo.com')->text(''));
-
-		$event = new BeforeMessageSent($message);
-		$this->dispatcher->expects($this->once())
-			->method('dispatchTyped')
-			->with($this->equalTo($event));
-
-		$this->mailer->send($message);
-	}
-
-	public function testGetInstanceDefault(): void {
-		$this->config
-			->method('getSystemValue')
-			->willReturnMap([
-				['mail_smtphost', '127.0.0.1', '127.0.0.1'],
-				['mail_smtpport', 25, 25],
-				['mail_smtptimeout', 10, 10],
-			]);
-		$mailer = self::invokePrivate($this->mailer, 'getInstance');
-		$this->assertInstanceOf(SymfonyMailer::class, $mailer);
-		$transport = self::invokePrivate($mailer, 'transport');
-		$this->assertInstanceOf(EsmtpTransport::class, $transport);
-	}
-
-	public function testGetInstanceSendmail(): void {
-		$this->config
-			->method('getSystemValueString')
-			->willReturnMap([
-				['mail_smtpmode', 'smtp', 'sendmail'],
-				['mail_sendmailmode', 'smtp', 'smtp'],
-			]);
-
-		$mailer = self::invokePrivate($this->mailer, 'getInstance');
-		$this->assertInstanceOf(SymfonyMailer::class, $mailer);
-		$transport = self::invokePrivate($mailer, 'transport');
-		$this->assertInstanceOf(SendmailTransport::class, $transport);
-	}
-
-	public function testEvents(): void {
-		$this->config
-			->method('getSystemValue')
-			->willReturnMap([
-				['mail_smtphost', '127.0.0.1', '127.0.0.1'],
-				['mail_smtpport', 25, 25],
-			]);
-		$this->mailer = $this->getMockBuilder(Mailer::class)
-			->onlyMethods(['getInstance'])
-			->setConstructorArgs(
-				[
-					$this->config,
-					$this->logger,
-					$this->defaults,
-					$this->urlGenerator,
-					$this->l10n,
-					$this->dispatcher,
-					$this->createMock(IFactory::class)
-				]
-			)
-			->getMock();
-
-		$message = $this->createMock(Message::class);
-
-		$event = new BeforeMessageSent($message);
-		$this->dispatcher->expects($this->once())
-			->method('dispatchTyped')
-			->with($this->equalTo($event));
-
-		$this->mailer->send($message);
-	}
-
-	public function testCreateMessage(): void {
-		$this->config
-			->expects($this->any())
-			->method('getSystemValueBool')
-			->with('mail_send_plaintext_only', false)
-			->willReturn(false);
-		$this->assertInstanceOf('\OC\Mail\Message', $this->mailer->createMessage());
-	}
-
-
-	public function testSendInvalidMailException(): void {
-		$this->config
-			->method('getSystemValue')
-			->willReturnMap([
-				['mail_smtphost', '127.0.0.1', '127.0.0.1'],
-				['mail_smtpport', 25, 25],
-				['mail_smtptimeout', 10, 10],
-			]);
-		$this->expectException(\Exception::class);
-
-		/** @var Message&MockObject */
-		$message = $this->getMockBuilder('\OC\Mail\Message')
-			->disableOriginalConstructor()->getMock();
-		$message->expects($this->once())
-			->method('getSymfonyEmail')
-			->willReturn(new Email());
-
-		$this->mailer->send($message);
-	}
-
-	/**
-	 * @return array
-	 */
-	public static function mailAddressProvider(): array {
-		return [
-			['lukas@owncloud.com', true, false],
-			['lukas@localhost', true, false],
-			['lukas@192.168.1.1', true, false],
-			['lukas@éxämplè.com', true, false],
-			['asdf', false, false],
-			['', false, false],
-			['lukas@owncloud.org@owncloud.com', false, false],
-			['test@localhost', true, false],
-			['test@localhost', false, true],
-		];
-	}
-
-	/**
-	 * @dataProvider mailAddressProvider
-	 */
-	public function testValidateMailAddress($email, $expected, $strict): void {
-		$this->config
-			->expects($this->atMost(1))
-			->method('getAppValue')
-			->with('core', 'enforce_strict_email_check')
-			->willReturn($strict ? 'yes' : 'no');
-		$this->assertSame($expected, $this->mailer->validateMailAddress($email));
-	}
-
-	public function testCreateEMailTemplate(): void {
-		$this->config->method('getSystemValueString')
-			->with('mail_template_class', '')
-			->willReturnArgument(1);
-		$this->config->method('getAppValue')
-			->with('theming', 'logoDimensions', Mailer::DEFAULT_DIMENSIONS)
-			->willReturn(Mailer::DEFAULT_DIMENSIONS);
-
-		$this->assertSame(EMailTemplate::class, get_class($this->mailer->createEMailTemplate('tests.MailerTest')));
-	}
-
-	public function testStreamingOptions(): void {
-		$this->config->method('getSystemValue')
-			->willReturnMap([
-				['mail_smtpstreamoptions', [], ['foo' => 1]],
-			]);
-		$this->config->method('getSystemValueString')
-			->willReturnMap([
-				['mail_smtpmode', 'smtp', 'smtp'],
-				['overwrite.cli.url', '', ''],
-				['mail_smtphost', '127.0.0.1', '127.0.0.1'],
-			]);
-		$this->config->method('getSystemValueInt')
-			->willReturnMap([
-				['mail_smtpport', 25, 25],
-				['mail_smtptimeout', 10, 10],
-			]);
-		$mailer = self::invokePrivate($this->mailer, 'getInstance');
-		/** @var EsmtpTransport $transport */
-		$transport = self::invokePrivate($mailer, 'transport');
-		$this->assertInstanceOf(EsmtpTransport::class, $transport);
-		$this->assertEquals(1, count($transport->getStream()->getStreamOptions()));
-		$this->assertTrue(isset($transport->getStream()->getStreamOptions()['foo']));
-	}
-
-	public function testStreamingOptionsWrongType(): void {
-		$this->config->method('getSystemValue')
-			->willReturnMap([
-				['mail_smtpstreamoptions', [], 'bar'],
-			]);
-		$this->config->method('getSystemValueString')
-			->willReturnMap([
-				['mail_smtpmode', 'smtp', 'smtp'],
-				['overwrite.cli.url', '', ''],
-				['mail_smtphost', '127.0.0.1', '127.0.0.1'],
-			]);
-		$this->config->method('getSystemValueInt')
-			->willReturnMap([
-				['mail_smtpport', 25, 25],
-				['mail_smtptimeout', 10, 10],
-			]);
-
-		$mailer = self::invokePrivate($this->mailer, 'getInstance');
-		/** @var EsmtpTransport $transport */
-		$transport = self::invokePrivate($mailer, 'transport');
-		$this->assertInstanceOf(EsmtpTransport::class, $transport);
-		$this->assertEquals(0, count($transport->getStream()->getStreamOptions()));
-	}
-
-	public function testLocalDomain(): void {
-		$this->config->method('getSystemValueString')
-			->willReturnMap([
-				['mail_smtpmode', 'smtp', 'smtp'],
-				['overwrite.cli.url', '', 'https://some.valid.url.com:8080'],
-				['mail_smtphost', '127.0.0.1', '127.0.0.1'],
-			]);
-		$this->config->method('getSystemValueInt')
-			->willReturnMap([
-				['mail_smtpport', 25, 25],
-				['mail_smtptimeout', 10, 10],
-			]);
-
-		/** @var SymfonyMailer $mailer */
-		$mailer = self::invokePrivate($this->mailer, 'getInstance');
-		self::assertInstanceOf(SymfonyMailer::class, $mailer);
-
-		/** @var EsmtpTransport $transport */
-		$transport = self::invokePrivate($mailer, 'transport');
-		self::assertInstanceOf(EsmtpTransport::class, $transport);
-		self::assertEquals('some.valid.url.com', $transport->getLocalDomain());
-	}
-
-	public function testLocalDomainInvalidUrl(): void {
-		$this->config->method('getSystemValueString')
-			->willReturnMap([
-				['mail_smtpmode', 'smtp', 'smtp'],
-				['overwrite.cli.url', '', 'https:only.slash.does.not.work:8080'],
-				['mail_smtphost', '127.0.0.1', '127.0.0.1'],
-			]);
-		$this->config->method('getSystemValueInt')
-			->willReturnMap([
-				['mail_smtpport', 25, 25],
-				['mail_smtptimeout', 10, 10],
-			]);
-
-		/** @var SymfonyMailer $mailer */
-		$mailer = self::invokePrivate($this->mailer, 'getInstance');
-		self::assertInstanceOf(SymfonyMailer::class, $mailer);
-
-		/** @var EsmtpTransport $transport */
-		$transport = self::invokePrivate($mailer, 'transport');
-		self::assertInstanceOf(EsmtpTransport::class, $transport);
-		self::assertEquals('[127.0.0.1]', $transport->getLocalDomain());
-	}
-
-	public function testCaching(): void {
-		$symfonyMailer1 = self::invokePrivate($this->mailer, 'getInstance');
-		$symfonyMailer2 = self::invokePrivate($this->mailer, 'getInstance');
-		self::assertSame($symfonyMailer1, $symfonyMailer2);
-	}
+    /** @var IConfig|MockObject */
+    private $config;
+    /** @var Defaults|MockObject */
+    private $defaults;
+    /** @var LoggerInterface|MockObject */
+    private $logger;
+    /** @var IURLGenerator|MockObject */
+    private $urlGenerator;
+    /** @var IL10N|MockObject */
+    private $l10n;
+    /** @var Mailer */
+    private $mailer;
+    /** @var IEventDispatcher&MockObject */
+    private $dispatcher;
+
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->createMock(IConfig::class);
+        $this->defaults = $this->createMock(Defaults::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->dispatcher = $this->createMock(IEventDispatcher::class);
+        $this->mailer = new Mailer(
+            $this->config,
+            $this->logger,
+            $this->defaults,
+            $this->urlGenerator,
+            $this->l10n,
+            $this->dispatcher,
+            $this->createMock(IFactory::class)
+        );
+    }
+
+    /**
+     * @return array
+     */
+    public static function sendmailModeProvider(): array {
+        return [
+            'smtp' => ['smtp', ' -bs'],
+            'pipe' => ['pipe', ' -t -i'],
+        ];
+    }
+
+    /**
+     * @dataProvider sendmailModeProvider
+     * @param $sendmailMode
+     * @param $binaryParam
+     */
+    public function testGetSendmailInstanceSendMail($sendmailMode, $binaryParam): void {
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getSystemValueString')
+            ->willReturnMap([
+                ['mail_smtpmode', 'smtp', 'sendmail'],
+                ['mail_sendmailmode', 'smtp', $sendmailMode],
+            ]);
+
+        $path = \OCP\Server::get(IBinaryFinder::class)->findBinaryPath('sendmail');
+        if ($path === false) {
+            $path = '/usr/sbin/sendmail';
+        }
+
+        $expected = new SendmailTransport($path . $binaryParam, null, $this->logger);
+        $this->assertEquals($expected, self::invokePrivate($this->mailer, 'getSendMailInstance'));
+    }
+
+    /**
+     * @dataProvider sendmailModeProvider
+     * @param $sendmailMode
+     * @param $binaryParam
+     */
+    public function testGetSendmailInstanceSendMailQmail($sendmailMode, $binaryParam): void {
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getSystemValueString')
+            ->willReturnMap([
+                ['mail_smtpmode', 'smtp', 'qmail'],
+                ['mail_sendmailmode', 'smtp', $sendmailMode],
+            ]);
+
+        $sendmail = new SendmailTransport('/var/qmail/bin/sendmail' . $binaryParam, null, $this->logger);
+        $this->assertEquals($sendmail, self::invokePrivate($this->mailer, 'getSendMailInstance'));
+    }
+
+    public function testEventForNullTransport(): void {
+        $this->config
+            ->expects($this->exactly(1))
+            ->method('getSystemValueString')
+            ->with('mail_smtpmode', 'smtp')
+            ->willReturn('null');
+
+        $message = $this->createMock(Message::class);
+        $message->expects($this->once())
+            ->method('getSymfonyEmail')
+            ->willReturn((new Email())->to('foo@bar.com')->from('bar@foo.com')->text(''));
+
+        $event = new BeforeMessageSent($message);
+        $this->dispatcher->expects($this->once())
+            ->method('dispatchTyped')
+            ->with($this->equalTo($event));
+
+        $this->mailer->send($message);
+    }
+
+    public function testGetInstanceDefault(): void {
+        $this->config
+            ->method('getSystemValue')
+            ->willReturnMap([
+                ['mail_smtphost', '127.0.0.1', '127.0.0.1'],
+                ['mail_smtpport', 25, 25],
+                ['mail_smtptimeout', 10, 10],
+            ]);
+        $mailer = self::invokePrivate($this->mailer, 'getInstance');
+        $this->assertInstanceOf(SymfonyMailer::class, $mailer);
+        $transport = self::invokePrivate($mailer, 'transport');
+        $this->assertInstanceOf(EsmtpTransport::class, $transport);
+    }
+
+    public function testGetInstanceSendmail(): void {
+        $this->config
+            ->method('getSystemValueString')
+            ->willReturnMap([
+                ['mail_smtpmode', 'smtp', 'sendmail'],
+                ['mail_sendmailmode', 'smtp', 'smtp'],
+            ]);
+
+        $mailer = self::invokePrivate($this->mailer, 'getInstance');
+        $this->assertInstanceOf(SymfonyMailer::class, $mailer);
+        $transport = self::invokePrivate($mailer, 'transport');
+        $this->assertInstanceOf(SendmailTransport::class, $transport);
+    }
+
+    public function testEvents(): void {
+        $this->config
+            ->method('getSystemValue')
+            ->willReturnMap([
+                ['mail_smtphost', '127.0.0.1', '127.0.0.1'],
+                ['mail_smtpport', 25, 25],
+            ]);
+        $this->mailer = $this->getMockBuilder(Mailer::class)
+            ->onlyMethods(['getInstance'])
+            ->setConstructorArgs(
+                [
+                    $this->config,
+                    $this->logger,
+                    $this->defaults,
+                    $this->urlGenerator,
+                    $this->l10n,
+                    $this->dispatcher,
+                    $this->createMock(IFactory::class)
+                ]
+            )
+            ->getMock();
+
+        $message = $this->createMock(Message::class);
+
+        $event = new BeforeMessageSent($message);
+        $this->dispatcher->expects($this->once())
+            ->method('dispatchTyped')
+            ->with($this->equalTo($event));
+
+        $this->mailer->send($message);
+    }
+
+    public function testCreateMessage(): void {
+        $this->config
+            ->expects($this->any())
+            ->method('getSystemValueBool')
+            ->with('mail_send_plaintext_only', false)
+            ->willReturn(false);
+        $this->assertInstanceOf('\OC\Mail\Message', $this->mailer->createMessage());
+    }
+
+
+    public function testSendInvalidMailException(): void {
+        $this->config
+            ->method('getSystemValue')
+            ->willReturnMap([
+                ['mail_smtphost', '127.0.0.1', '127.0.0.1'],
+                ['mail_smtpport', 25, 25],
+                ['mail_smtptimeout', 10, 10],
+            ]);
+        $this->expectException(\Exception::class);
+
+        /** @var Message&MockObject */
+        $message = $this->getMockBuilder('\OC\Mail\Message')
+            ->disableOriginalConstructor()->getMock();
+        $message->expects($this->once())
+            ->method('getSymfonyEmail')
+            ->willReturn(new Email());
+
+        $this->mailer->send($message);
+    }
+
+    /**
+     * @return array
+     */
+    public static function mailAddressProvider(): array {
+        return [
+            ['lukas@owncloud.com', true, false],
+            ['lukas@localhost', true, false],
+            ['lukas@192.168.1.1', true, false],
+            ['lukas@éxämplè.com', true, false],
+            ['asdf', false, false],
+            ['', false, false],
+            ['lukas@owncloud.org@owncloud.com', false, false],
+            ['test@localhost', true, false],
+            ['test@localhost', false, true],
+        ];
+    }
+
+    /**
+     * @dataProvider mailAddressProvider
+     */
+    public function testValidateMailAddress($email, $expected, $strict): void {
+        $this->config
+            ->expects($this->atMost(1))
+            ->method('getAppValue')
+            ->with('core', 'enforce_strict_email_check')
+            ->willReturn($strict ? 'yes' : 'no');
+        $this->assertSame($expected, $this->mailer->validateMailAddress($email));
+    }
+
+    public function testCreateEMailTemplate(): void {
+        $this->config->method('getSystemValueString')
+            ->with('mail_template_class', '')
+            ->willReturnArgument(1);
+        $this->config->method('getAppValue')
+            ->with('theming', 'logoDimensions', Mailer::DEFAULT_DIMENSIONS)
+            ->willReturn(Mailer::DEFAULT_DIMENSIONS);
+
+        $this->assertSame(EMailTemplate::class, get_class($this->mailer->createEMailTemplate('tests.MailerTest')));
+    }
+
+    public function testStreamingOptions(): void {
+        $this->config->method('getSystemValue')
+            ->willReturnMap([
+                ['mail_smtpstreamoptions', [], ['foo' => 1]],
+            ]);
+        $this->config->method('getSystemValueString')
+            ->willReturnMap([
+                ['mail_smtpmode', 'smtp', 'smtp'],
+                ['overwrite.cli.url', '', ''],
+                ['mail_smtphost', '127.0.0.1', '127.0.0.1'],
+            ]);
+        $this->config->method('getSystemValueInt')
+            ->willReturnMap([
+                ['mail_smtpport', 25, 25],
+                ['mail_smtptimeout', 10, 10],
+            ]);
+        $mailer = self::invokePrivate($this->mailer, 'getInstance');
+        /** @var EsmtpTransport $transport */
+        $transport = self::invokePrivate($mailer, 'transport');
+        $this->assertInstanceOf(EsmtpTransport::class, $transport);
+        $this->assertEquals(1, count($transport->getStream()->getStreamOptions()));
+        $this->assertTrue(isset($transport->getStream()->getStreamOptions()['foo']));
+    }
+
+    public function testStreamingOptionsWrongType(): void {
+        $this->config->method('getSystemValue')
+            ->willReturnMap([
+                ['mail_smtpstreamoptions', [], 'bar'],
+            ]);
+        $this->config->method('getSystemValueString')
+            ->willReturnMap([
+                ['mail_smtpmode', 'smtp', 'smtp'],
+                ['overwrite.cli.url', '', ''],
+                ['mail_smtphost', '127.0.0.1', '127.0.0.1'],
+            ]);
+        $this->config->method('getSystemValueInt')
+            ->willReturnMap([
+                ['mail_smtpport', 25, 25],
+                ['mail_smtptimeout', 10, 10],
+            ]);
+
+        $mailer = self::invokePrivate($this->mailer, 'getInstance');
+        /** @var EsmtpTransport $transport */
+        $transport = self::invokePrivate($mailer, 'transport');
+        $this->assertInstanceOf(EsmtpTransport::class, $transport);
+        $this->assertEquals(0, count($transport->getStream()->getStreamOptions()));
+    }
+
+    public function testLocalDomain(): void {
+        $this->config->method('getSystemValueString')
+            ->willReturnMap([
+                ['mail_smtpmode', 'smtp', 'smtp'],
+                ['overwrite.cli.url', '', 'https://some.valid.url.com:8080'],
+                ['mail_smtphost', '127.0.0.1', '127.0.0.1'],
+            ]);
+        $this->config->method('getSystemValueInt')
+            ->willReturnMap([
+                ['mail_smtpport', 25, 25],
+                ['mail_smtptimeout', 10, 10],
+            ]);
+
+        /** @var SymfonyMailer $mailer */
+        $mailer = self::invokePrivate($this->mailer, 'getInstance');
+        self::assertInstanceOf(SymfonyMailer::class, $mailer);
+
+        /** @var EsmtpTransport $transport */
+        $transport = self::invokePrivate($mailer, 'transport');
+        self::assertInstanceOf(EsmtpTransport::class, $transport);
+        self::assertEquals('some.valid.url.com', $transport->getLocalDomain());
+    }
+
+    public function testLocalDomainInvalidUrl(): void {
+        $this->config->method('getSystemValueString')
+            ->willReturnMap([
+                ['mail_smtpmode', 'smtp', 'smtp'],
+                ['overwrite.cli.url', '', 'https:only.slash.does.not.work:8080'],
+                ['mail_smtphost', '127.0.0.1', '127.0.0.1'],
+            ]);
+        $this->config->method('getSystemValueInt')
+            ->willReturnMap([
+                ['mail_smtpport', 25, 25],
+                ['mail_smtptimeout', 10, 10],
+            ]);
+
+        /** @var SymfonyMailer $mailer */
+        $mailer = self::invokePrivate($this->mailer, 'getInstance');
+        self::assertInstanceOf(SymfonyMailer::class, $mailer);
+
+        /** @var EsmtpTransport $transport */
+        $transport = self::invokePrivate($mailer, 'transport');
+        self::assertInstanceOf(EsmtpTransport::class, $transport);
+        self::assertEquals('[127.0.0.1]', $transport->getLocalDomain());
+    }
+
+    public function testCaching(): void {
+        $symfonyMailer1 = self::invokePrivate($this->mailer, 'getInstance');
+        $symfonyMailer2 = self::invokePrivate($this->mailer, 'getInstance');
+        self::assertSame($symfonyMailer1, $symfonyMailer2);
+    }
 }

tests/lib/Mail/MessageTest.php

Indentation +263 added lines, -263 removed lines

@@ -19,275 +19,275 @@
 use Test\TestCase;
 
 class MessageTest extends TestCase {
-	/** @var Email */
-	private $symfonyEmail;
-	/** @var Message */
-	private $message;
-
-	/**
-	 * @return array
-	 */
-	public static function mailAddressProvider(): array {
-		return [
-			[
-				['lukas@owncloud.com' => 'Lukas Reschke'],
-				[new Address('lukas@owncloud.com', 'Lukas Reschke')]
-			],
-			[
-				[
-					'lukas@owncloud.com' => 'Lukas Reschke',
-					'lukas@öwnclöüd.com',
-					'lukäs@owncloud.örg' => 'Lükäs Réschke'
-				],
-				[
-					new Address('lukas@owncloud.com', 'Lukas Reschke'),
-					new Address('lukas@öwnclöüd.com'),
-					new Address('lukäs@owncloud.örg', 'Lükäs Réschke')
-				]
-			],
-			[
-				['lukas@öwnclöüd.com'],
-				[new Address('lukas@öwnclöüd.com')]
-			],
-		];
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getMailAddressProvider() {
-		return [
-			[[], []],
-			[['lukas@owncloud.com' => 'Lukas Reschke'], ['lukas@owncloud.com' => 'Lukas Reschke']],
-		];
-	}
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->symfonyEmail = $this->createMock(Email::class);
-
-		$this->message = new Message($this->symfonyEmail, false);
-	}
-
-	/**
-	 * @dataProvider mailAddressProvider
-	 *
-	 * @param string $unconverted
-	 * @param string $expected
-	 */
-	public function testConvertAddresses($unconverted, $expected): void {
-		$this->assertEquals($expected, self::invokePrivate($this->message, 'convertAddresses', [$unconverted]));
-	}
-
-	public function testSetRecipients(): void {
-		$this->message = $this->message->setFrom(['pierres-general-store@stardewvalley.com' => 'Pierres General Store']);
-		$this->message = $this->message->setTo(['lewis-tent@stardewvalley.com' => "Lewis' Tent Life"]);
-		$this->message = $this->message->setReplyTo(['penny@stardewvalley-library.co.edu' => 'Penny']);
-		$this->message = $this->message->setCc(['gunther@stardewvalley-library.co.edu' => 'Gunther']);
-		$this->message = $this->message->setBcc(['pam@stardewvalley-bus.com' => 'Pam']);
-
-		$this->symfonyEmail
-			->expects($this->once())
-			->method('from')
-			->with(new Address('pierres-general-store@stardewvalley.com', 'Pierres General Store'));
-		$this->symfonyEmail
-			->expects($this->once())
-			->method('to')
-			->with(new Address('lewis-tent@stardewvalley.com', "Lewis' Tent Life"));
-		$this->symfonyEmail
-			->expects($this->once())
-			->method('replyTo')
-			->with(new Address('penny@stardewvalley-library.co.edu', 'Penny'));
-		$this->symfonyEmail
-			->expects($this->once())
-			->method('cc')
-			->with(new Address('gunther@stardewvalley-library.co.edu', 'Gunther'));
-		$this->symfonyEmail
-			->expects($this->once())
-			->method('bcc')
-			->with(new Address('pam@stardewvalley-bus.com', 'Pam'));
-
-		$this->message->setRecipients();
-	}
-
-	public function testSetTo(): void {
-		$expected = ['pierres-general-store@stardewvalley.com' => 'Pierres General Store'];
-
-		$message = $this->message->setTo(['pierres-general-store@stardewvalley.com' => 'Pierres General Store']);
-
-		$this->assertEquals($expected, $message->getTo());
-	}
-	public function testSetRecipientsException(): void {
-		$message = $this->message->setTo(['lewis-tent@~~~~.com' => "Lewis' Tent Life"]);
-
-		$this->symfonyEmail
-			->expects($this->once())
-			->method('to')
-			->willThrowException(new RfcComplianceException());
-
-		$this->expectException(RfcComplianceException::class);
-		$message->setRecipients();
-	}
-
-	public function testSetRecipientsEmptyValues(): void {
-		$message = $this->message->setTo([]);
-
-		$this->symfonyEmail
-			->expects($this->once())
-			->method('to');
-
-		$message->setRecipients();
-	}
-
-	public function testSetGetFrom(): void {
-		$expected = ['pierres-general-store@stardewvalley.com' => 'Pierres General Store'];
-
-		$message = $this->message->setFrom(['pierres-general-store@stardewvalley.com' => 'Pierres General Store']);
-
-		$this->assertEquals($expected, $message->getFrom());
-	}
-
-	public function testSetGetTo(): void {
-		$expected = ['lewis-tent@stardewvalley.com' => "Lewis' Tent Life"];
-
-		$message = $this->message->setTo(['lewis-tent@stardewvalley.com' => "Lewis' Tent Life"]);
-
-		$this->assertEquals($expected, $message->getTo());
-	}
-
-	public function testSetGetReplyTo(): void {
-		$expected = ['penny@stardewvalley-library.co.edu' => 'Penny'];
-
-		$message = $this->message->setReplyTo(['penny@stardewvalley-library.co.edu' => 'Penny']);
-
-		$this->assertEquals($expected, $message->getReplyTo());
-	}
-
-	public function testSetGetCC(): void {
-		$expected = ['gunther@stardewvalley-library.co.edu' => 'Gunther'];
-
-		$message = $this->message->setCc(['gunther@stardewvalley-library.co.edu' => 'Gunther']);
-
-		$this->assertEquals($expected, $message->getCc());
-	}
-
-	public function testSetGetBCC(): void {
-		$expected = ['pam@stardewvalley-bus.com' => 'Pam'];
-
-		$message = $this->message->setBcc(['pam@stardewvalley-bus.com' => 'Pam']);
-
-		$this->assertEquals($expected, $message->getBcc());
-	}
-
-	public function testSetPlainBody(): void {
-		$this->symfonyEmail
-			->expects($this->once())
-			->method('text')
-			->with('Fancy Body');
-
-		$this->message->setPlainBody('Fancy Body');
-	}
-
-	public function testGetPlainBody(): void {
-		$this->symfonyEmail
-			->expects($this->once())
-			->method('getTextBody')
-			->willReturn('Fancy Body');
-
-		$this->assertSame('Fancy Body', $this->message->getPlainBody());
-	}
-
-	public function testSetHtmlBody(): void {
-		$this->symfonyEmail
-			->expects($this->once())
-			->method('html')
-			->with('<blink>Fancy Body</blink>', 'utf-8');
+    /** @var Email */
+    private $symfonyEmail;
+    /** @var Message */
+    private $message;
+
+    /**
+     * @return array
+     */
+    public static function mailAddressProvider(): array {
+        return [
+            [
+                ['lukas@owncloud.com' => 'Lukas Reschke'],
+                [new Address('lukas@owncloud.com', 'Lukas Reschke')]
+            ],
+            [
+                [
+                    'lukas@owncloud.com' => 'Lukas Reschke',
+                    'lukas@öwnclöüd.com',
+                    'lukäs@owncloud.örg' => 'Lükäs Réschke'
+                ],
+                [
+                    new Address('lukas@owncloud.com', 'Lukas Reschke'),
+                    new Address('lukas@öwnclöüd.com'),
+                    new Address('lukäs@owncloud.örg', 'Lükäs Réschke')
+                ]
+            ],
+            [
+                ['lukas@öwnclöüd.com'],
+                [new Address('lukas@öwnclöüd.com')]
+            ],
+        ];
+    }
+
+    /**
+     * @return array
+     */
+    public function getMailAddressProvider() {
+        return [
+            [[], []],
+            [['lukas@owncloud.com' => 'Lukas Reschke'], ['lukas@owncloud.com' => 'Lukas Reschke']],
+        ];
+    }
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->symfonyEmail = $this->createMock(Email::class);
+
+        $this->message = new Message($this->symfonyEmail, false);
+    }
+
+    /**
+     * @dataProvider mailAddressProvider
+     *
+     * @param string $unconverted
+     * @param string $expected
+     */
+    public function testConvertAddresses($unconverted, $expected): void {
+        $this->assertEquals($expected, self::invokePrivate($this->message, 'convertAddresses', [$unconverted]));
+    }
+
+    public function testSetRecipients(): void {
+        $this->message = $this->message->setFrom(['pierres-general-store@stardewvalley.com' => 'Pierres General Store']);
+        $this->message = $this->message->setTo(['lewis-tent@stardewvalley.com' => "Lewis' Tent Life"]);
+        $this->message = $this->message->setReplyTo(['penny@stardewvalley-library.co.edu' => 'Penny']);
+        $this->message = $this->message->setCc(['gunther@stardewvalley-library.co.edu' => 'Gunther']);
+        $this->message = $this->message->setBcc(['pam@stardewvalley-bus.com' => 'Pam']);
+
+        $this->symfonyEmail
+            ->expects($this->once())
+            ->method('from')
+            ->with(new Address('pierres-general-store@stardewvalley.com', 'Pierres General Store'));
+        $this->symfonyEmail
+            ->expects($this->once())
+            ->method('to')
+            ->with(new Address('lewis-tent@stardewvalley.com', "Lewis' Tent Life"));
+        $this->symfonyEmail
+            ->expects($this->once())
+            ->method('replyTo')
+            ->with(new Address('penny@stardewvalley-library.co.edu', 'Penny'));
+        $this->symfonyEmail
+            ->expects($this->once())
+            ->method('cc')
+            ->with(new Address('gunther@stardewvalley-library.co.edu', 'Gunther'));
+        $this->symfonyEmail
+            ->expects($this->once())
+            ->method('bcc')
+            ->with(new Address('pam@stardewvalley-bus.com', 'Pam'));
+
+        $this->message->setRecipients();
+    }
+
+    public function testSetTo(): void {
+        $expected = ['pierres-general-store@stardewvalley.com' => 'Pierres General Store'];
+
+        $message = $this->message->setTo(['pierres-general-store@stardewvalley.com' => 'Pierres General Store']);
+
+        $this->assertEquals($expected, $message->getTo());
+    }
+    public function testSetRecipientsException(): void {
+        $message = $this->message->setTo(['lewis-tent@~~~~.com' => "Lewis' Tent Life"]);
+
+        $this->symfonyEmail
+            ->expects($this->once())
+            ->method('to')
+            ->willThrowException(new RfcComplianceException());
+
+        $this->expectException(RfcComplianceException::class);
+        $message->setRecipients();
+    }
+
+    public function testSetRecipientsEmptyValues(): void {
+        $message = $this->message->setTo([]);
+
+        $this->symfonyEmail
+            ->expects($this->once())
+            ->method('to');
+
+        $message->setRecipients();
+    }
+
+    public function testSetGetFrom(): void {
+        $expected = ['pierres-general-store@stardewvalley.com' => 'Pierres General Store'];
+
+        $message = $this->message->setFrom(['pierres-general-store@stardewvalley.com' => 'Pierres General Store']);
+
+        $this->assertEquals($expected, $message->getFrom());
+    }
+
+    public function testSetGetTo(): void {
+        $expected = ['lewis-tent@stardewvalley.com' => "Lewis' Tent Life"];
+
+        $message = $this->message->setTo(['lewis-tent@stardewvalley.com' => "Lewis' Tent Life"]);
+
+        $this->assertEquals($expected, $message->getTo());
+    }
+
+    public function testSetGetReplyTo(): void {
+        $expected = ['penny@stardewvalley-library.co.edu' => 'Penny'];
+
+        $message = $this->message->setReplyTo(['penny@stardewvalley-library.co.edu' => 'Penny']);
+
+        $this->assertEquals($expected, $message->getReplyTo());
+    }
+
+    public function testSetGetCC(): void {
+        $expected = ['gunther@stardewvalley-library.co.edu' => 'Gunther'];
+
+        $message = $this->message->setCc(['gunther@stardewvalley-library.co.edu' => 'Gunther']);
+
+        $this->assertEquals($expected, $message->getCc());
+    }
+
+    public function testSetGetBCC(): void {
+        $expected = ['pam@stardewvalley-bus.com' => 'Pam'];
+
+        $message = $this->message->setBcc(['pam@stardewvalley-bus.com' => 'Pam']);
+
+        $this->assertEquals($expected, $message->getBcc());
+    }
+
+    public function testSetPlainBody(): void {
+        $this->symfonyEmail
+            ->expects($this->once())
+            ->method('text')
+            ->with('Fancy Body');
+
+        $this->message->setPlainBody('Fancy Body');
+    }
+
+    public function testGetPlainBody(): void {
+        $this->symfonyEmail
+            ->expects($this->once())
+            ->method('getTextBody')
+            ->willReturn('Fancy Body');
+
+        $this->assertSame('Fancy Body', $this->message->getPlainBody());
+    }
+
+    public function testSetHtmlBody(): void {
+        $this->symfonyEmail
+            ->expects($this->once())
+            ->method('html')
+            ->with('<blink>Fancy Body</blink>', 'utf-8');
 
-		$this->message->setHtmlBody('<blink>Fancy Body</blink>');
-	}
+        $this->message->setHtmlBody('<blink>Fancy Body</blink>');
+    }
 
-	public function testPlainTextRenderOption(): void {
-		/** @var MockObject|Email $symfonyEmail */
-		$symfonyEmail = $this->getMockBuilder(Email::class)
-			->disableOriginalConstructor()->getMock();
-		/** @var MockObject|IEMailTemplate $template */
-		$template = $this->getMockBuilder(IEMailTemplate::class)
-			->disableOriginalConstructor()->getMock();
+    public function testPlainTextRenderOption(): void {
+        /** @var MockObject|Email $symfonyEmail */
+        $symfonyEmail = $this->getMockBuilder(Email::class)
+            ->disableOriginalConstructor()->getMock();
+        /** @var MockObject|IEMailTemplate $template */
+        $template = $this->getMockBuilder(IEMailTemplate::class)
+            ->disableOriginalConstructor()->getMock();
 
-		$message = new Message($symfonyEmail, true);
+        $message = new Message($symfonyEmail, true);
 
-		$template
-			->expects($this->never())
-			->method('renderHTML');
-		$template
-			->expects($this->once())
-			->method('renderText');
-		$template
-			->expects($this->once())
-			->method('renderSubject');
+        $template
+            ->expects($this->never())
+            ->method('renderHTML');
+        $template
+            ->expects($this->once())
+            ->method('renderText');
+        $template
+            ->expects($this->once())
+            ->method('renderSubject');
 
-		$message->useTemplate($template);
-	}
+        $message->useTemplate($template);
+    }
 
-	public function testBothRenderingOptions(): void {
-		/** @var MockObject|Email $symfonyEmail */
-		$symfonyEmail = $this->getMockBuilder(Email::class)
-			->disableOriginalConstructor()->getMock();
-		/** @var MockObject|IEMailTemplate $template */
-		$template = $this->getMockBuilder(IEMailTemplate::class)
-			->disableOriginalConstructor()->getMock();
+    public function testBothRenderingOptions(): void {
+        /** @var MockObject|Email $symfonyEmail */
+        $symfonyEmail = $this->getMockBuilder(Email::class)
+            ->disableOriginalConstructor()->getMock();
+        /** @var MockObject|IEMailTemplate $template */
+        $template = $this->getMockBuilder(IEMailTemplate::class)
+            ->disableOriginalConstructor()->getMock();
 
-		$message = new Message($symfonyEmail, false);
+        $message = new Message($symfonyEmail, false);
 
-		$template
-			->expects($this->once())
-			->method('renderHTML');
-		$template
-			->expects($this->once())
-			->method('renderText');
-		$template
-			->expects($this->once())
-			->method('renderSubject');
-
-		$message->useTemplate($template);
-	}
-
-	public function testSetAutoSubmitted1(): void {
-		$headers = new Headers($this->createMock(HeaderInterface::class));
-		$headers->addTextHeader(AutoSubmitted::HEADER, 'yes');
-		$symfonyEmail = $this->createMock(Email::class);
-
-		$symfonyEmail->method('getHeaders')
-			->willReturn($headers);
-
-		$message = new Message($symfonyEmail, false);
-		$message->setAutoSubmitted(AutoSubmitted::VALUE_AUTO_GENERATED);
-		$this->assertNotSame('no', $message->getAutoSubmitted());
-	}
-
-	public function testSetAutoSubmitted2(): void {
-		$headers = new Headers($this->createMock(HeaderInterface::class));
-		$headers->addTextHeader(AutoSubmitted::HEADER, 'no');
-		$symfonyEmail = $this->createMock(Email::class);
-
-		$symfonyEmail->method('getHeaders')
-			->willReturn($headers);
-
-		$message = new Message($symfonyEmail, false);
-		$message->setAutoSubmitted(AutoSubmitted::VALUE_AUTO_GENERATED);
-		$this->assertSame('auto-generated', $message->getAutoSubmitted());
-	}
-
-	public function testGetAutoSubmitted(): void {
-		$headers = new Headers($this->createMock(HeaderInterface::class));
-		$headers->addTextHeader(AutoSubmitted::HEADER, 'no');
-		$symfonyEmail = $this->createMock(Email::class);
-
-		$symfonyEmail->method('getHeaders')
-			->willReturn($headers);
-
-		$message = new Message($symfonyEmail, false);
-		$this->assertSame('no', $message->getAutoSubmitted());
-	}
+        $template
+            ->expects($this->once())
+            ->method('renderHTML');
+        $template
+            ->expects($this->once())
+            ->method('renderText');
+        $template
+            ->expects($this->once())
+            ->method('renderSubject');
+
+        $message->useTemplate($template);
+    }
+
+    public function testSetAutoSubmitted1(): void {
+        $headers = new Headers($this->createMock(HeaderInterface::class));
+        $headers->addTextHeader(AutoSubmitted::HEADER, 'yes');
+        $symfonyEmail = $this->createMock(Email::class);
+
+        $symfonyEmail->method('getHeaders')
+            ->willReturn($headers);
+
+        $message = new Message($symfonyEmail, false);
+        $message->setAutoSubmitted(AutoSubmitted::VALUE_AUTO_GENERATED);
+        $this->assertNotSame('no', $message->getAutoSubmitted());
+    }
+
+    public function testSetAutoSubmitted2(): void {
+        $headers = new Headers($this->createMock(HeaderInterface::class));
+        $headers->addTextHeader(AutoSubmitted::HEADER, 'no');
+        $symfonyEmail = $this->createMock(Email::class);
+
+        $symfonyEmail->method('getHeaders')
+            ->willReturn($headers);
+
+        $message = new Message($symfonyEmail, false);
+        $message->setAutoSubmitted(AutoSubmitted::VALUE_AUTO_GENERATED);
+        $this->assertSame('auto-generated', $message->getAutoSubmitted());
+    }
+
+    public function testGetAutoSubmitted(): void {
+        $headers = new Headers($this->createMock(HeaderInterface::class));
+        $headers->addTextHeader(AutoSubmitted::HEADER, 'no');
+        $symfonyEmail = $this->createMock(Email::class);
+
+        $symfonyEmail->method('getHeaders')
+            ->willReturn($headers);
+
+        $message = new Message($symfonyEmail, false);
+        $this->assertSame('no', $message->getAutoSubmitted());
+    }
 }

tests/lib/Collaboration/Collaborators/UserPluginTest.php

Indentation +779 added lines, -779 removed lines

@@ -22,790 +22,790 @@
 use Test\TestCase;
 
 class UserPluginTest extends TestCase {
-	/** @var IConfig|MockObject */
-	protected $config;
+    /** @var IConfig|MockObject */
+    protected $config;
 
-	/** @var IUserManager|MockObject */
-	protected $userManager;
+    /** @var IUserManager|MockObject */
+    protected $userManager;
 
-	/** @var IGroupManager|MockObject */
-	protected $groupManager;
+    /** @var IGroupManager|MockObject */
+    protected $groupManager;
 
-	/** @var IUserSession|MockObject */
-	protected $session;
+    /** @var IUserSession|MockObject */
+    protected $session;
 
-	/** @var KnownUserService|MockObject */
-	protected $knownUserService;
+    /** @var KnownUserService|MockObject */
+    protected $knownUserService;
 
-	/** @var IUserStatusManager|MockObject */
-	protected $userStatusManager;
+    /** @var IUserStatusManager|MockObject */
+    protected $userStatusManager;
 
-	/** @var UserPlugin */
-	protected $plugin;
+    /** @var UserPlugin */
+    protected $plugin;
 
-	/** @var ISearchResult */
-	protected $searchResult;
-
-	protected int $limit = 2;
-
-	protected int $offset = 0;
-
-	/** @var IUser|MockObject */
-	protected $user;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->createMock(IConfig::class);
-
-		$this->userManager = $this->createMock(IUserManager::class);
-
-		$this->groupManager = $this->createMock(IGroupManager::class);
-
-		$this->session = $this->createMock(IUserSession::class);
-
-		$this->knownUserService = $this->createMock(KnownUserService::class);
-
-		$this->userStatusManager = $this->createMock(IUserStatusManager::class);
-
-		$this->searchResult = new SearchResult();
-
-		$this->user = $this->getUserMock('admin', 'Administrator');
-	}
-
-	public function instantiatePlugin() {
-		// cannot be done within setUp, because dependent mocks needs to be set
-		// up with configuration etc. first
-		$this->plugin = new UserPlugin(
-			$this->config,
-			$this->userManager,
-			$this->groupManager,
-			$this->session,
-			$this->knownUserService,
-			$this->userStatusManager
-		);
-	}
-
-	public function mockConfig($mockedSettings) {
-		$this->config->expects($this->any())
-			->method('getAppValue')
-			->willReturnCallback(
-				function ($appName, $key, $default) use ($mockedSettings) {
-					return $mockedSettings[$appName][$key] ?? $default;
-				}
-			);
-	}
-
-	public function getUserMock($uid, $displayName, $enabled = true, $groups = []) {
-		$user = $this->createMock(IUser::class);
-
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn($uid);
-
-		$user->expects($this->any())
-			->method('getDisplayName')
-			->willReturn($displayName);
-
-		$user->expects($this->any())
-			->method('isEnabled')
-			->willReturn($enabled);
-
-		return $user;
-	}
-
-	public function getGroupMock($gid) {
-		$group = $this->createMock(IGroup::class);
-
-		$group->expects($this->any())
-			->method('getGID')
-			->willReturn($gid);
-
-		return $group;
-	}
-
-	public function dataGetUsers(): array {
-		return [
-			['test', false, true, [], [], [], [], true, false],
-			['test', false, false, [], [], [], [], true, false],
-			['test', true, true, [], [], [], [], true, false],
-			['test', true, false, [], [], [], [], true, false],
-			[
-				'test', false, true, [], [],
-				[
-					['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
-				], [], true, $this->getUserMock('test', 'Test'),
-			],
-			[
-				'test', false, false, [], [],
-				[
-					['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
-				], [], true, $this->getUserMock('test', 'Test'),
-			],
-			[
-				'test', true, true, [], [],
-				[], [], true, $this->getUserMock('test', 'Test'),
-			],
-			[
-				'test', true, false, [], [],
-				[], [], true, $this->getUserMock('test', 'Test'),
-			],
-			[
-				'test', true, true, ['test-group'], [['test-group', 'test', 2, 0, []]],
-				[
-					['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
-				], [], true, $this->getUserMock('test', 'Test'),
-			],
-			[
-				'test', true, false, ['test-group'], [['test-group', 'test', 2, 0, []]],
-				[
-					['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
-				], [], true, $this->getUserMock('test', 'Test'),
-			],
-			[
-				'test',
-				false,
-				true,
-				[],
-				[
-					$this->getUserMock('test1', 'Test One'),
-				],
-				[],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
-				],
-				true,
-				false,
-			],
-			[
-				'test',
-				false,
-				false,
-				[],
-				[
-					$this->getUserMock('test1', 'Test One'),
-				],
-				[],
-				[],
-				true,
-				false,
-			],
-			[
-				'test',
-				false,
-				true,
-				[],
-				[
-					$this->getUserMock('test1', 'Test One'),
-					$this->getUserMock('test2', 'Test Two'),
-				],
-				[],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
-					['label' => 'Test Two', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test2'],
-				],
-				false,
-				false,
-			],
-			[
-				'test',
-				false,
-				false,
-				[],
-				[
-					$this->getUserMock('test1', 'Test One'),
-					$this->getUserMock('test2', 'Test Two'),
-				],
-				[],
-				[],
-				true,
-				false,
-			],
-			[
-				'test',
-				false,
-				true,
-				[],
-				[
-					$this->getUserMock('test0', 'Test'),
-					$this->getUserMock('test1', 'Test One'),
-					$this->getUserMock('test2', 'Test Two'),
-				],
-				[
-					['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test0'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test0'],
-				],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
-					['label' => 'Test Two', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test2'],
-				],
-				false,
-				false,
-			],
-			[
-				'test',
-				false,
-				true,
-				[],
-				[
-					$this->getUserMock('test0', 'Test'),
-					$this->getUserMock('test1', 'Test One'),
-					$this->getUserMock('test2', 'Test Two'),
-				],
-				[
-					['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test0'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test0'],
-				],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
-					['label' => 'Test Two', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test2'],
-				],
-				false,
-				false,
-				[],
-				true,
-			],
-			[
-				'test',
-				false,
-				false,
-				[],
-				[
-					$this->getUserMock('test0', 'Test'),
-					$this->getUserMock('test1', 'Test One'),
-					$this->getUserMock('test2', 'Test Two'),
-				],
-				[
-					['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test0'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test0'],
-				],
-				[],
-				true,
-				false,
-			],
-			[
-				'test',
-				true,
-				true,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, ['test1' => 'Test One']],
-					['xyz', 'test', 2, 0, []],
-				],
-				[],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
-				],
-				true,
-				false,
-				[['test1', $this->getUserMock('test1', 'Test One')]],
-			],
-			[
-				'test',
-				true,
-				false,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, ['test1' => 'Test One']],
-					['xyz', 'test', 2, 0, []],
-				],
-				[],
-				[],
-				true,
-				false,
-				[['test1', $this->getUserMock('test1', 'Test One')]],
-			],
-			[
-				'test',
-				true,
-				true,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, [
-						'test1' => 'Test One',
-						'test2' => 'Test Two',
-					]],
-					['xyz', 'test', 2, 0, [
-						'test1' => 'Test One',
-						'test2' => 'Test Two',
-					]],
-				],
-				[],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
-					['label' => 'Test Two', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test2'],
-				],
-				true,
-				false,
-				[
-					['test1', $this->getUserMock('test1', 'Test One')],
-					['test2', $this->getUserMock('test2', 'Test Two')],
-				],
-			],
-			[
-				'test',
-				true,
-				false,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, [
-						'test1' => 'Test One',
-						'test2' => 'Test Two',
-					]],
-					['xyz', 'test', 2, 0, [
-						'test1' => 'Test One',
-						'test2' => 'Test Two',
-					]],
-				],
-				[],
-				[],
-				true,
-				false,
-				[
-					['test1', $this->getUserMock('test1', 'Test One')],
-					['test2', $this->getUserMock('test2', 'Test Two')],
-				],
-			],
-			[
-				'test',
-				true,
-				true,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, [
-						'test' => 'Test One',
-					]],
-					['xyz', 'test', 2, 0, [
-						'test2' => 'Test Two',
-					]],
-				],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
-				],
-				[
-					['label' => 'Test Two', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test2'],
-				],
-				false,
-				false,
-				[
-					['test', $this->getUserMock('test', 'Test One')],
-					['test2', $this->getUserMock('test2', 'Test Two')],
-				],
-			],
-			[
-				'test',
-				true,
-				false,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, [
-						'test' => 'Test One',
-					]],
-					['xyz', 'test', 2, 0, [
-						'test2' => 'Test Two',
-					]],
-				],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
-				],
-				[],
-				true,
-				false,
-				[
-					['test', $this->getUserMock('test', 'Test One')],
-					['test2', $this->getUserMock('test2', 'Test Two')],
-				],
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider dataGetUsers
-	 *
-	 * @param string $searchTerm
-	 * @param bool $shareWithGroupOnly
-	 * @param bool $shareeEnumeration
-	 * @param array $groupResponse
-	 * @param array $userResponse
-	 * @param array $exactExpected
-	 * @param array $expected
-	 * @param bool $reachedEnd
-	 * @param bool|IUser $singleUser
-	 * @param array $users
-	 */
-	public function testSearch(
-		$searchTerm,
-		$shareWithGroupOnly,
-		$shareeEnumeration,
-		array $groupResponse,
-		array $userResponse,
-		array $exactExpected,
-		array $expected,
-		$reachedEnd,
-		$singleUser,
-		array $users = [],
-		$shareeEnumerationPhone = false,
-	): void {
-		$this->mockConfig(['core' => [
-			'shareapi_only_share_with_group_members' => $shareWithGroupOnly ? 'yes' : 'no',
-			'shareapi_allow_share_dialog_user_enumeration' => $shareeEnumeration? 'yes' : 'no',
-			'shareapi_restrict_user_enumeration_to_group' => false ? 'yes' : 'no',
-			'shareapi_restrict_user_enumeration_to_phone' => $shareeEnumerationPhone ? 'yes' : 'no',
-		]]);
-
-		$this->instantiatePlugin();
-
-		$this->session->expects($this->any())
-			->method('getUser')
-			->willReturn($this->user);
-
-		if (!$shareWithGroupOnly) {
-			if ($shareeEnumerationPhone) {
-				$this->userManager->expects($this->once())
-					->method('searchKnownUsersByDisplayName')
-					->with($this->user->getUID(), $searchTerm, $this->limit, $this->offset)
-					->willReturn($userResponse);
-
-				$this->knownUserService->method('isKnownToUser')
-					->willReturnMap([
-						[$this->user->getUID(), 'test0', true],
-						[$this->user->getUID(), 'test1', true],
-						[$this->user->getUID(), 'test2', true],
-					]);
-			} else {
-				$this->userManager->expects($this->once())
-					->method('searchDisplayName')
-					->with($searchTerm, $this->limit, $this->offset)
-					->willReturn($userResponse);
-			}
-		} else {
-			$this->groupManager->method('getUserGroupIds')
-				->with($this->user)
-				->willReturn($groupResponse);
-
-			if ($singleUser !== false) {
-				$this->groupManager->method('getUserGroupIds')
-					->with($singleUser)
-					->willReturn($groupResponse);
-			}
-
-			$this->groupManager->method('displayNamesInGroup')
-				->willReturnMap($userResponse);
-		}
-
-		if ($singleUser !== false) {
-			$users[] = [$searchTerm, $singleUser];
-		}
-
-		if (!empty($users)) {
-			$this->userManager->expects($this->atLeastOnce())
-				->method('get')
-				->willReturnMap($users);
-		}
-
-		$moreResults = $this->plugin->search($searchTerm, $this->limit, $this->offset, $this->searchResult);
-		$result = $this->searchResult->asArray();
-
-		$this->assertEquals($exactExpected, $result['exact']['users']);
-		$this->assertEquals($expected, $result['users']);
-		$this->assertSame($reachedEnd, $moreResults);
-	}
-
-	public static function takeOutCurrentUserProvider(): array {
-		$inputUsers = [
-			'alice' => 'Alice',
-			'bob' => 'Bob',
-			'carol' => 'Carol',
-		];
-		return [
-			[
-				$inputUsers,
-				['alice', 'carol'],
-				'bob',
-			],
-			[
-				$inputUsers,
-				['alice', 'bob', 'carol'],
-				'dave',
-			],
-			[
-				$inputUsers,
-				['alice', 'bob', 'carol'],
-				null,
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider takeOutCurrentUserProvider
-	 * @param array $users
-	 * @param array $expectedUIDs
-	 * @param $currentUserId
-	 */
-	public function testTakeOutCurrentUser(array $users, array $expectedUIDs, $currentUserId): void {
-		$this->instantiatePlugin();
-
-		$this->session->expects($this->once())
-			->method('getUser')
-			->willReturnCallback(function () use ($currentUserId) {
-				if ($currentUserId !== null) {
-					return $this->getUserMock($currentUserId, $currentUserId);
-				}
-				return null;
-			});
-
-		$this->plugin->takeOutCurrentUser($users);
-		$this->assertSame($expectedUIDs, array_keys($users));
-	}
-
-	public static function dataSearchEnumeration(): array {
-		return [
-			[
-				'test',
-				['groupA'],
-				[
-					['uid' => 'test1', 'groups' => ['groupA']],
-					['uid' => 'test2', 'groups' => ['groupB']],
-				],
-				['exact' => [], 'wide' => ['test1']],
-				['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
-			],
-			[
-				'test',
-				['groupA'],
-				[
-					['uid' => 'test1', 'displayName' => 'Test user 1', 'groups' => ['groupA']],
-					['uid' => 'test2', 'displayName' => 'Test user 2', 'groups' => ['groupA']],
-				],
-				['exact' => [], 'wide' => []],
-				['core' => ['shareapi_allow_share_dialog_user_enumeration' => 'no']],
-			],
-			[
-				'test1',
-				['groupA'],
-				[
-					['uid' => 'test1', 'displayName' => 'Test user 1', 'groups' => ['groupA']],
-					['uid' => 'test2', 'displayName' => 'Test user 2', 'groups' => ['groupA']],
-				],
-				['exact' => ['test1'], 'wide' => []],
-				['core' => ['shareapi_allow_share_dialog_user_enumeration' => 'no']],
-			],
-			[
-				'test1',
-				['groupA'],
-				[
-					['uid' => 'test1', 'displayName' => 'Test user 1', 'groups' => ['groupA']],
-					['uid' => 'test2', 'displayName' => 'Test user 2', 'groups' => ['groupA']],
-				],
-				['exact' => [], 'wide' => []],
-				[
-					'core' => [
-						'shareapi_allow_share_dialog_user_enumeration' => 'no',
-						'shareapi_restrict_user_enumeration_full_match_userid' => 'no',
-					],
-				]
-			],
-			[
-				'Test user 1',
-				['groupA'],
-				[
-					['uid' => 'test1', 'displayName' => 'Test user 1', 'groups' => ['groupA']],
-					['uid' => 'test2', 'displayName' => 'Test user 2', 'groups' => ['groupA']],
-				],
-				['exact' => ['test1'], 'wide' => []],
-				[
-					'core' => [
-						'shareapi_allow_share_dialog_user_enumeration' => 'no',
-						'shareapi_restrict_user_enumeration_full_match_userid' => 'no',
-					],
-				]
-			],
-			[
-				'Test user 1',
-				['groupA'],
-				[
-					['uid' => 'test1', 'displayName' => 'Test user 1 (Second displayName for user 1)', 'groups' => ['groupA']],
-					['uid' => 'test2', 'displayName' => 'Test user 2 (Second displayName for user 2)', 'groups' => ['groupA']],
-				],
-				['exact' => [], 'wide' => []],
-				['core' => ['shareapi_allow_share_dialog_user_enumeration' => 'no'],
-				]
-			],
-			[
-				'Test user 1',
-				['groupA'],
-				[
-					['uid' => 'test1', 'displayName' => 'Test user 1 (Second displayName for user 1)', 'groups' => ['groupA']],
-					['uid' => 'test2', 'displayName' => 'Test user 2 (Second displayName for user 2)', 'groups' => ['groupA']],
-				],
-				['exact' => ['test1'], 'wide' => []],
-				[
-					'core' => [
-						'shareapi_allow_share_dialog_user_enumeration' => 'no',
-						'shareapi_restrict_user_enumeration_full_match_ignore_second_dn' => 'yes',
-					],
-				]
-			],
-			[
-				'test1',
-				['groupA'],
-				[
-					['uid' => 'test1', 'groups' => ['groupA']],
-					['uid' => 'test2', 'groups' => ['groupB']],
-				],
-				['exact' => ['test1'], 'wide' => []],
-				['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
-			],
-			[
-				'test',
-				['groupA'],
-				[
-					['uid' => 'test1', 'groups' => ['groupA']],
-					['uid' => 'test2', 'groups' => ['groupB', 'groupA']],
-				],
-				['exact' => [], 'wide' => ['test1', 'test2']],
-				['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
-			],
-			[
-				'test',
-				['groupA'],
-				[
-					['uid' => 'test1', 'groups' => ['groupA', 'groupC']],
-					['uid' => 'test2', 'groups' => ['groupB', 'groupA']],
-				],
-				['exact' => [], 'wide' => ['test1', 'test2']],
-				['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
-			],
-			[
-				'test',
-				['groupC', 'groupB'],
-				[
-					['uid' => 'test1', 'groups' => ['groupA', 'groupC']],
-					['uid' => 'test2', 'groups' => ['groupB', 'groupA']],
-				],
-				['exact' => [], 'wide' => ['test1', 'test2']],
-				['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
-			],
-			[
-				'test',
-				[],
-				[
-					['uid' => 'test1', 'groups' => ['groupA']],
-					['uid' => 'test2', 'groups' => ['groupB', 'groupA']],
-				],
-				['exact' => [], 'wide' => []],
-				['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
-			],
-			[
-				'test',
-				['groupC', 'groupB'],
-				[
-					['uid' => 'test1', 'groups' => []],
-					['uid' => 'test2', 'groups' => []],
-				],
-				['exact' => [], 'wide' => []],
-				['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
-			],
-			[
-				'test',
-				['groupC', 'groupB'],
-				[
-					['uid' => 'test1', 'groups' => []],
-					['uid' => 'test2', 'groups' => []],
-				],
-				['exact' => [], 'wide' => []],
-				['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider dataSearchEnumeration
-	 */
-	public function testSearchEnumerationLimit($search, $userGroups, $matchingUsers, $result, $mockedSettings): void {
-		$this->mockConfig($mockedSettings);
-
-		$userResults = [];
-		foreach ($matchingUsers as $user) {
-			$userResults[$user['uid']] = $user['uid'];
-		}
-
-		$usersById = [];
-		foreach ($matchingUsers as $user) {
-			$usersById[$user['uid']] = $user;
-		}
-
-		$mappedResultExact = array_map(function ($user) use ($usersById, $search) {
-			return [
-				'label' => $search === $user ? $user : $usersById[$user]['displayName'],
-				'value' => ['shareType' => 0, 'shareWith' => $user],
-				'icon' => 'icon-user',
-				'subline' => null,
-				'status' => [],
-				'shareWithDisplayNameUnique' => $user,
-			];
-		}, $result['exact']);
-		$mappedResultWide = array_map(function ($user) {
-			return [
-				'label' => $user,
-				'value' => ['shareType' => 0, 'shareWith' => $user],
-				'icon' => 'icon-user',
-				'subline' => null,
-				'status' => [],
-				'shareWithDisplayNameUnique' => $user,
-			];
-		}, $result['wide']);
-
-		$this->userManager
-			->method('get')
-			->willReturnCallback(function ($userId) use ($userResults) {
-				if (isset($userResults[$userId])) {
-					return $this->getUserMock($userId, $userId);
-				}
-				return null;
-			});
-		$this->userManager
-			->method('searchDisplayName')
-			->willReturnCallback(function ($search) use ($matchingUsers) {
-				$users = array_filter(
-					$matchingUsers,
-					fn ($user) => str_contains(strtolower($user['displayName']), strtolower($search))
-				);
-				return array_map(
-					fn ($user) => $this->getUserMock($user['uid'], $user['displayName']),
-					$users);
-			});
-
-		$this->groupManager->method('displayNamesInGroup')
-			->willReturn($userResults);
-
-
-		$this->session->expects($this->any())
-			->method('getUser')
-			->willReturn($this->getUserMock('test', 'foo'));
-		$this->groupManager->expects($this->any())
-			->method('getUserGroupIds')
-			->willReturnCallback(function ($user) use ($matchingUsers, $userGroups) {
-				static $firstCall = true;
-				if ($firstCall) {
-					$firstCall = false;
-					// current user
-					return $userGroups;
-				}
-				$neededObject = array_filter(
-					$matchingUsers,
-					function ($e) use ($user) {
-						return $user->getUID() === $e['uid'];
-					}
-				);
-				if (count($neededObject) > 0) {
-					return array_shift($neededObject)['groups'];
-				}
-				return [];
-			});
-
-		$this->instantiatePlugin();
-		$this->plugin->search($search, $this->limit, $this->offset, $this->searchResult);
-		$result = $this->searchResult->asArray();
-
-		$this->assertEquals($mappedResultExact, $result['exact']['users']);
-		$this->assertEquals($mappedResultWide, $result['users']);
-	}
+    /** @var ISearchResult */
+    protected $searchResult;
+
+    protected int $limit = 2;
+
+    protected int $offset = 0;
+
+    /** @var IUser|MockObject */
+    protected $user;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->createMock(IConfig::class);
+
+        $this->userManager = $this->createMock(IUserManager::class);
+
+        $this->groupManager = $this->createMock(IGroupManager::class);
+
+        $this->session = $this->createMock(IUserSession::class);
+
+        $this->knownUserService = $this->createMock(KnownUserService::class);
+
+        $this->userStatusManager = $this->createMock(IUserStatusManager::class);
+
+        $this->searchResult = new SearchResult();
+
+        $this->user = $this->getUserMock('admin', 'Administrator');
+    }
+
+    public function instantiatePlugin() {
+        // cannot be done within setUp, because dependent mocks needs to be set
+        // up with configuration etc. first
+        $this->plugin = new UserPlugin(
+            $this->config,
+            $this->userManager,
+            $this->groupManager,
+            $this->session,
+            $this->knownUserService,
+            $this->userStatusManager
+        );
+    }
+
+    public function mockConfig($mockedSettings) {
+        $this->config->expects($this->any())
+            ->method('getAppValue')
+            ->willReturnCallback(
+                function ($appName, $key, $default) use ($mockedSettings) {
+                    return $mockedSettings[$appName][$key] ?? $default;
+                }
+            );
+    }
+
+    public function getUserMock($uid, $displayName, $enabled = true, $groups = []) {
+        $user = $this->createMock(IUser::class);
+
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn($uid);
+
+        $user->expects($this->any())
+            ->method('getDisplayName')
+            ->willReturn($displayName);
+
+        $user->expects($this->any())
+            ->method('isEnabled')
+            ->willReturn($enabled);
+
+        return $user;
+    }
+
+    public function getGroupMock($gid) {
+        $group = $this->createMock(IGroup::class);
+
+        $group->expects($this->any())
+            ->method('getGID')
+            ->willReturn($gid);
+
+        return $group;
+    }
+
+    public function dataGetUsers(): array {
+        return [
+            ['test', false, true, [], [], [], [], true, false],
+            ['test', false, false, [], [], [], [], true, false],
+            ['test', true, true, [], [], [], [], true, false],
+            ['test', true, false, [], [], [], [], true, false],
+            [
+                'test', false, true, [], [],
+                [
+                    ['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
+                ], [], true, $this->getUserMock('test', 'Test'),
+            ],
+            [
+                'test', false, false, [], [],
+                [
+                    ['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
+                ], [], true, $this->getUserMock('test', 'Test'),
+            ],
+            [
+                'test', true, true, [], [],
+                [], [], true, $this->getUserMock('test', 'Test'),
+            ],
+            [
+                'test', true, false, [], [],
+                [], [], true, $this->getUserMock('test', 'Test'),
+            ],
+            [
+                'test', true, true, ['test-group'], [['test-group', 'test', 2, 0, []]],
+                [
+                    ['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
+                ], [], true, $this->getUserMock('test', 'Test'),
+            ],
+            [
+                'test', true, false, ['test-group'], [['test-group', 'test', 2, 0, []]],
+                [
+                    ['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
+                ], [], true, $this->getUserMock('test', 'Test'),
+            ],
+            [
+                'test',
+                false,
+                true,
+                [],
+                [
+                    $this->getUserMock('test1', 'Test One'),
+                ],
+                [],
+                [
+                    ['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
+                ],
+                true,
+                false,
+            ],
+            [
+                'test',
+                false,
+                false,
+                [],
+                [
+                    $this->getUserMock('test1', 'Test One'),
+                ],
+                [],
+                [],
+                true,
+                false,
+            ],
+            [
+                'test',
+                false,
+                true,
+                [],
+                [
+                    $this->getUserMock('test1', 'Test One'),
+                    $this->getUserMock('test2', 'Test Two'),
+                ],
+                [],
+                [
+                    ['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
+                    ['label' => 'Test Two', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test2'],
+                ],
+                false,
+                false,
+            ],
+            [
+                'test',
+                false,
+                false,
+                [],
+                [
+                    $this->getUserMock('test1', 'Test One'),
+                    $this->getUserMock('test2', 'Test Two'),
+                ],
+                [],
+                [],
+                true,
+                false,
+            ],
+            [
+                'test',
+                false,
+                true,
+                [],
+                [
+                    $this->getUserMock('test0', 'Test'),
+                    $this->getUserMock('test1', 'Test One'),
+                    $this->getUserMock('test2', 'Test Two'),
+                ],
+                [
+                    ['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test0'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test0'],
+                ],
+                [
+                    ['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
+                    ['label' => 'Test Two', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test2'],
+                ],
+                false,
+                false,
+            ],
+            [
+                'test',
+                false,
+                true,
+                [],
+                [
+                    $this->getUserMock('test0', 'Test'),
+                    $this->getUserMock('test1', 'Test One'),
+                    $this->getUserMock('test2', 'Test Two'),
+                ],
+                [
+                    ['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test0'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test0'],
+                ],
+                [
+                    ['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
+                    ['label' => 'Test Two', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test2'],
+                ],
+                false,
+                false,
+                [],
+                true,
+            ],
+            [
+                'test',
+                false,
+                false,
+                [],
+                [
+                    $this->getUserMock('test0', 'Test'),
+                    $this->getUserMock('test1', 'Test One'),
+                    $this->getUserMock('test2', 'Test Two'),
+                ],
+                [
+                    ['label' => 'Test', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test0'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test0'],
+                ],
+                [],
+                true,
+                false,
+            ],
+            [
+                'test',
+                true,
+                true,
+                ['abc', 'xyz'],
+                [
+                    ['abc', 'test', 2, 0, ['test1' => 'Test One']],
+                    ['xyz', 'test', 2, 0, []],
+                ],
+                [],
+                [
+                    ['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
+                ],
+                true,
+                false,
+                [['test1', $this->getUserMock('test1', 'Test One')]],
+            ],
+            [
+                'test',
+                true,
+                false,
+                ['abc', 'xyz'],
+                [
+                    ['abc', 'test', 2, 0, ['test1' => 'Test One']],
+                    ['xyz', 'test', 2, 0, []],
+                ],
+                [],
+                [],
+                true,
+                false,
+                [['test1', $this->getUserMock('test1', 'Test One')]],
+            ],
+            [
+                'test',
+                true,
+                true,
+                ['abc', 'xyz'],
+                [
+                    ['abc', 'test', 2, 0, [
+                        'test1' => 'Test One',
+                        'test2' => 'Test Two',
+                    ]],
+                    ['xyz', 'test', 2, 0, [
+                        'test1' => 'Test One',
+                        'test2' => 'Test Two',
+                    ]],
+                ],
+                [],
+                [
+                    ['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test1'],
+                    ['label' => 'Test Two', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test2'],
+                ],
+                true,
+                false,
+                [
+                    ['test1', $this->getUserMock('test1', 'Test One')],
+                    ['test2', $this->getUserMock('test2', 'Test Two')],
+                ],
+            ],
+            [
+                'test',
+                true,
+                false,
+                ['abc', 'xyz'],
+                [
+                    ['abc', 'test', 2, 0, [
+                        'test1' => 'Test One',
+                        'test2' => 'Test Two',
+                    ]],
+                    ['xyz', 'test', 2, 0, [
+                        'test1' => 'Test One',
+                        'test2' => 'Test Two',
+                    ]],
+                ],
+                [],
+                [],
+                true,
+                false,
+                [
+                    ['test1', $this->getUserMock('test1', 'Test One')],
+                    ['test2', $this->getUserMock('test2', 'Test Two')],
+                ],
+            ],
+            [
+                'test',
+                true,
+                true,
+                ['abc', 'xyz'],
+                [
+                    ['abc', 'test', 2, 0, [
+                        'test' => 'Test One',
+                    ]],
+                    ['xyz', 'test', 2, 0, [
+                        'test2' => 'Test Two',
+                    ]],
+                ],
+                [
+                    ['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
+                ],
+                [
+                    ['label' => 'Test Two', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test2'],
+                ],
+                false,
+                false,
+                [
+                    ['test', $this->getUserMock('test', 'Test One')],
+                    ['test2', $this->getUserMock('test2', 'Test Two')],
+                ],
+            ],
+            [
+                'test',
+                true,
+                false,
+                ['abc', 'xyz'],
+                [
+                    ['abc', 'test', 2, 0, [
+                        'test' => 'Test One',
+                    ]],
+                    ['xyz', 'test', 2, 0, [
+                        'test2' => 'Test Two',
+                    ]],
+                ],
+                [
+                    ['label' => 'Test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'icon' => 'icon-user', 'subline' => null, 'status' => [], 'shareWithDisplayNameUnique' => 'test'],
+                ],
+                [],
+                true,
+                false,
+                [
+                    ['test', $this->getUserMock('test', 'Test One')],
+                    ['test2', $this->getUserMock('test2', 'Test Two')],
+                ],
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider dataGetUsers
+     *
+     * @param string $searchTerm
+     * @param bool $shareWithGroupOnly
+     * @param bool $shareeEnumeration
+     * @param array $groupResponse
+     * @param array $userResponse
+     * @param array $exactExpected
+     * @param array $expected
+     * @param bool $reachedEnd
+     * @param bool|IUser $singleUser
+     * @param array $users
+     */
+    public function testSearch(
+        $searchTerm,
+        $shareWithGroupOnly,
+        $shareeEnumeration,
+        array $groupResponse,
+        array $userResponse,
+        array $exactExpected,
+        array $expected,
+        $reachedEnd,
+        $singleUser,
+        array $users = [],
+        $shareeEnumerationPhone = false,
+    ): void {
+        $this->mockConfig(['core' => [
+            'shareapi_only_share_with_group_members' => $shareWithGroupOnly ? 'yes' : 'no',
+            'shareapi_allow_share_dialog_user_enumeration' => $shareeEnumeration? 'yes' : 'no',
+            'shareapi_restrict_user_enumeration_to_group' => false ? 'yes' : 'no',
+            'shareapi_restrict_user_enumeration_to_phone' => $shareeEnumerationPhone ? 'yes' : 'no',
+        ]]);
+
+        $this->instantiatePlugin();
+
+        $this->session->expects($this->any())
+            ->method('getUser')
+            ->willReturn($this->user);
+
+        if (!$shareWithGroupOnly) {
+            if ($shareeEnumerationPhone) {
+                $this->userManager->expects($this->once())
+                    ->method('searchKnownUsersByDisplayName')
+                    ->with($this->user->getUID(), $searchTerm, $this->limit, $this->offset)
+                    ->willReturn($userResponse);
+
+                $this->knownUserService->method('isKnownToUser')
+                    ->willReturnMap([
+                        [$this->user->getUID(), 'test0', true],
+                        [$this->user->getUID(), 'test1', true],
+                        [$this->user->getUID(), 'test2', true],
+                    ]);
+            } else {
+                $this->userManager->expects($this->once())
+                    ->method('searchDisplayName')
+                    ->with($searchTerm, $this->limit, $this->offset)
+                    ->willReturn($userResponse);
+            }
+        } else {
+            $this->groupManager->method('getUserGroupIds')
+                ->with($this->user)
+                ->willReturn($groupResponse);
+
+            if ($singleUser !== false) {
+                $this->groupManager->method('getUserGroupIds')
+                    ->with($singleUser)
+                    ->willReturn($groupResponse);
+            }
+
+            $this->groupManager->method('displayNamesInGroup')
+                ->willReturnMap($userResponse);
+        }
+
+        if ($singleUser !== false) {
+            $users[] = [$searchTerm, $singleUser];
+        }
+
+        if (!empty($users)) {
+            $this->userManager->expects($this->atLeastOnce())
+                ->method('get')
+                ->willReturnMap($users);
+        }
+
+        $moreResults = $this->plugin->search($searchTerm, $this->limit, $this->offset, $this->searchResult);
+        $result = $this->searchResult->asArray();
+
+        $this->assertEquals($exactExpected, $result['exact']['users']);
+        $this->assertEquals($expected, $result['users']);
+        $this->assertSame($reachedEnd, $moreResults);
+    }
+
+    public static function takeOutCurrentUserProvider(): array {
+        $inputUsers = [
+            'alice' => 'Alice',
+            'bob' => 'Bob',
+            'carol' => 'Carol',
+        ];
+        return [
+            [
+                $inputUsers,
+                ['alice', 'carol'],
+                'bob',
+            ],
+            [
+                $inputUsers,
+                ['alice', 'bob', 'carol'],
+                'dave',
+            ],
+            [
+                $inputUsers,
+                ['alice', 'bob', 'carol'],
+                null,
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider takeOutCurrentUserProvider
+     * @param array $users
+     * @param array $expectedUIDs
+     * @param $currentUserId
+     */
+    public function testTakeOutCurrentUser(array $users, array $expectedUIDs, $currentUserId): void {
+        $this->instantiatePlugin();
+
+        $this->session->expects($this->once())
+            ->method('getUser')
+            ->willReturnCallback(function () use ($currentUserId) {
+                if ($currentUserId !== null) {
+                    return $this->getUserMock($currentUserId, $currentUserId);
+                }
+                return null;
+            });
+
+        $this->plugin->takeOutCurrentUser($users);
+        $this->assertSame($expectedUIDs, array_keys($users));
+    }
+
+    public static function dataSearchEnumeration(): array {
+        return [
+            [
+                'test',
+                ['groupA'],
+                [
+                    ['uid' => 'test1', 'groups' => ['groupA']],
+                    ['uid' => 'test2', 'groups' => ['groupB']],
+                ],
+                ['exact' => [], 'wide' => ['test1']],
+                ['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
+            ],
+            [
+                'test',
+                ['groupA'],
+                [
+                    ['uid' => 'test1', 'displayName' => 'Test user 1', 'groups' => ['groupA']],
+                    ['uid' => 'test2', 'displayName' => 'Test user 2', 'groups' => ['groupA']],
+                ],
+                ['exact' => [], 'wide' => []],
+                ['core' => ['shareapi_allow_share_dialog_user_enumeration' => 'no']],
+            ],
+            [
+                'test1',
+                ['groupA'],
+                [
+                    ['uid' => 'test1', 'displayName' => 'Test user 1', 'groups' => ['groupA']],
+                    ['uid' => 'test2', 'displayName' => 'Test user 2', 'groups' => ['groupA']],
+                ],
+                ['exact' => ['test1'], 'wide' => []],
+                ['core' => ['shareapi_allow_share_dialog_user_enumeration' => 'no']],
+            ],
+            [
+                'test1',
+                ['groupA'],
+                [
+                    ['uid' => 'test1', 'displayName' => 'Test user 1', 'groups' => ['groupA']],
+                    ['uid' => 'test2', 'displayName' => 'Test user 2', 'groups' => ['groupA']],
+                ],
+                ['exact' => [], 'wide' => []],
+                [
+                    'core' => [
+                        'shareapi_allow_share_dialog_user_enumeration' => 'no',
+                        'shareapi_restrict_user_enumeration_full_match_userid' => 'no',
+                    ],
+                ]
+            ],
+            [
+                'Test user 1',
+                ['groupA'],
+                [
+                    ['uid' => 'test1', 'displayName' => 'Test user 1', 'groups' => ['groupA']],
+                    ['uid' => 'test2', 'displayName' => 'Test user 2', 'groups' => ['groupA']],
+                ],
+                ['exact' => ['test1'], 'wide' => []],
+                [
+                    'core' => [
+                        'shareapi_allow_share_dialog_user_enumeration' => 'no',
+                        'shareapi_restrict_user_enumeration_full_match_userid' => 'no',
+                    ],
+                ]
+            ],
+            [
+                'Test user 1',
+                ['groupA'],
+                [
+                    ['uid' => 'test1', 'displayName' => 'Test user 1 (Second displayName for user 1)', 'groups' => ['groupA']],
+                    ['uid' => 'test2', 'displayName' => 'Test user 2 (Second displayName for user 2)', 'groups' => ['groupA']],
+                ],
+                ['exact' => [], 'wide' => []],
+                ['core' => ['shareapi_allow_share_dialog_user_enumeration' => 'no'],
+                ]
+            ],
+            [
+                'Test user 1',
+                ['groupA'],
+                [
+                    ['uid' => 'test1', 'displayName' => 'Test user 1 (Second displayName for user 1)', 'groups' => ['groupA']],
+                    ['uid' => 'test2', 'displayName' => 'Test user 2 (Second displayName for user 2)', 'groups' => ['groupA']],
+                ],
+                ['exact' => ['test1'], 'wide' => []],
+                [
+                    'core' => [
+                        'shareapi_allow_share_dialog_user_enumeration' => 'no',
+                        'shareapi_restrict_user_enumeration_full_match_ignore_second_dn' => 'yes',
+                    ],
+                ]
+            ],
+            [
+                'test1',
+                ['groupA'],
+                [
+                    ['uid' => 'test1', 'groups' => ['groupA']],
+                    ['uid' => 'test2', 'groups' => ['groupB']],
+                ],
+                ['exact' => ['test1'], 'wide' => []],
+                ['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
+            ],
+            [
+                'test',
+                ['groupA'],
+                [
+                    ['uid' => 'test1', 'groups' => ['groupA']],
+                    ['uid' => 'test2', 'groups' => ['groupB', 'groupA']],
+                ],
+                ['exact' => [], 'wide' => ['test1', 'test2']],
+                ['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
+            ],
+            [
+                'test',
+                ['groupA'],
+                [
+                    ['uid' => 'test1', 'groups' => ['groupA', 'groupC']],
+                    ['uid' => 'test2', 'groups' => ['groupB', 'groupA']],
+                ],
+                ['exact' => [], 'wide' => ['test1', 'test2']],
+                ['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
+            ],
+            [
+                'test',
+                ['groupC', 'groupB'],
+                [
+                    ['uid' => 'test1', 'groups' => ['groupA', 'groupC']],
+                    ['uid' => 'test2', 'groups' => ['groupB', 'groupA']],
+                ],
+                ['exact' => [], 'wide' => ['test1', 'test2']],
+                ['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
+            ],
+            [
+                'test',
+                [],
+                [
+                    ['uid' => 'test1', 'groups' => ['groupA']],
+                    ['uid' => 'test2', 'groups' => ['groupB', 'groupA']],
+                ],
+                ['exact' => [], 'wide' => []],
+                ['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
+            ],
+            [
+                'test',
+                ['groupC', 'groupB'],
+                [
+                    ['uid' => 'test1', 'groups' => []],
+                    ['uid' => 'test2', 'groups' => []],
+                ],
+                ['exact' => [], 'wide' => []],
+                ['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
+            ],
+            [
+                'test',
+                ['groupC', 'groupB'],
+                [
+                    ['uid' => 'test1', 'groups' => []],
+                    ['uid' => 'test2', 'groups' => []],
+                ],
+                ['exact' => [], 'wide' => []],
+                ['core' => ['shareapi_restrict_user_enumeration_to_group' => 'yes']],
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider dataSearchEnumeration
+     */
+    public function testSearchEnumerationLimit($search, $userGroups, $matchingUsers, $result, $mockedSettings): void {
+        $this->mockConfig($mockedSettings);
+
+        $userResults = [];
+        foreach ($matchingUsers as $user) {
+            $userResults[$user['uid']] = $user['uid'];
+        }
+
+        $usersById = [];
+        foreach ($matchingUsers as $user) {
+            $usersById[$user['uid']] = $user;
+        }
+
+        $mappedResultExact = array_map(function ($user) use ($usersById, $search) {
+            return [
+                'label' => $search === $user ? $user : $usersById[$user]['displayName'],
+                'value' => ['shareType' => 0, 'shareWith' => $user],
+                'icon' => 'icon-user',
+                'subline' => null,
+                'status' => [],
+                'shareWithDisplayNameUnique' => $user,
+            ];
+        }, $result['exact']);
+        $mappedResultWide = array_map(function ($user) {
+            return [
+                'label' => $user,
+                'value' => ['shareType' => 0, 'shareWith' => $user],
+                'icon' => 'icon-user',
+                'subline' => null,
+                'status' => [],
+                'shareWithDisplayNameUnique' => $user,
+            ];
+        }, $result['wide']);
+
+        $this->userManager
+            ->method('get')
+            ->willReturnCallback(function ($userId) use ($userResults) {
+                if (isset($userResults[$userId])) {
+                    return $this->getUserMock($userId, $userId);
+                }
+                return null;
+            });
+        $this->userManager
+            ->method('searchDisplayName')
+            ->willReturnCallback(function ($search) use ($matchingUsers) {
+                $users = array_filter(
+                    $matchingUsers,
+                    fn ($user) => str_contains(strtolower($user['displayName']), strtolower($search))
+                );
+                return array_map(
+                    fn ($user) => $this->getUserMock($user['uid'], $user['displayName']),
+                    $users);
+            });
+
+        $this->groupManager->method('displayNamesInGroup')
+            ->willReturn($userResults);
+
+
+        $this->session->expects($this->any())
+            ->method('getUser')
+            ->willReturn($this->getUserMock('test', 'foo'));
+        $this->groupManager->expects($this->any())
+            ->method('getUserGroupIds')
+            ->willReturnCallback(function ($user) use ($matchingUsers, $userGroups) {
+                static $firstCall = true;
+                if ($firstCall) {
+                    $firstCall = false;
+                    // current user
+                    return $userGroups;
+                }
+                $neededObject = array_filter(
+                    $matchingUsers,
+                    function ($e) use ($user) {
+                        return $user->getUID() === $e['uid'];
+                    }
+                );
+                if (count($neededObject) > 0) {
+                    return array_shift($neededObject)['groups'];
+                }
+                return [];
+            });
+
+        $this->instantiatePlugin();
+        $this->plugin->search($search, $this->limit, $this->offset, $this->searchResult);
+        $result = $this->searchResult->asArray();
+
+        $this->assertEquals($mappedResultExact, $result['exact']['users']);
+        $this->assertEquals($mappedResultWide, $result['users']);
+    }
 }

tests/lib/Collaboration/Collaborators/SearchResultTest.php

Indentation +55 added lines, -55 removed lines

@@ -14,71 +14,71 @@
 use Test\TestCase;
 
 class SearchResultTest extends TestCase {
-	/** @var IContainer|\PHPUnit\Framework\MockObject\MockObject */
-	protected $container;
-	/** @var ISearch */
-	protected $search;
+    /** @var IContainer|\PHPUnit\Framework\MockObject\MockObject */
+    protected $container;
+    /** @var ISearch */
+    protected $search;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->container = $this->createMock(IContainer::class);
+        $this->container = $this->createMock(IContainer::class);
 
-		$this->search = new Search($this->container);
-	}
+        $this->search = new Search($this->container);
+    }
 
-	public static function dataAddResultSet(): array {
-		return [
-			[[], ['exact' => []]],
-			[['users' => ['exact' => null, 'loose' => []]], ['exact' => ['users' => []], 'users' => []]],
-			[['groups' => ['exact' => null, 'loose' => ['l1']]], ['exact' => ['groups' => []], 'groups' => ['l1']]],
-			[['users' => ['exact' => ['e1'], 'loose' => []]], ['exact' => ['users' => ['e1']], 'users' => []]],
-		];
-	}
+    public static function dataAddResultSet(): array {
+        return [
+            [[], ['exact' => []]],
+            [['users' => ['exact' => null, 'loose' => []]], ['exact' => ['users' => []], 'users' => []]],
+            [['groups' => ['exact' => null, 'loose' => ['l1']]], ['exact' => ['groups' => []], 'groups' => ['l1']]],
+            [['users' => ['exact' => ['e1'], 'loose' => []]], ['exact' => ['users' => ['e1']], 'users' => []]],
+        ];
+    }
 
-	/**
-	 * @dataProvider dataAddResultSet
-	 * @param array $toAdd
-	 * @param array $expected
-	 */
-	public function testAddResultSet(array $toAdd, array $expected): void {
-		$result = new SearchResult();
+    /**
+     * @dataProvider dataAddResultSet
+     * @param array $toAdd
+     * @param array $expected
+     */
+    public function testAddResultSet(array $toAdd, array $expected): void {
+        $result = new SearchResult();
 
-		foreach ($toAdd as $type => $results) {
-			$result->addResultSet(new SearchResultType($type), $results['loose'], $results['exact']);
-		}
+        foreach ($toAdd as $type => $results) {
+            $result->addResultSet(new SearchResultType($type), $results['loose'], $results['exact']);
+        }
 
-		$this->assertEquals($expected, $result->asArray());
-	}
+        $this->assertEquals($expected, $result->asArray());
+    }
 
-	public static function dataHasResult(): array {
-		$result = ['value' => ['shareWith' => 'l1']];
-		return [
-			[[],'users', 'n1', false],
-			[['users' => ['exact' => null,      'loose' => [$result]]], 'users',  'l1', true],
-			[['users' => ['exact' => null,      'loose' => [$result]]], 'users',  'l2', false],
-			[['users' => ['exact' => null,      'loose' => [$result]]], 'groups', 'l1', false],
-			[['users' => ['exact' => [$result], 'loose' => []]],        'users',  'l1', true],
-			[['users' => ['exact' => [$result], 'loose' => []]],        'users',  'l2', false],
-			[['users' => ['exact' => [$result], 'loose' => []]],        'groups', 'l1', false],
+    public static function dataHasResult(): array {
+        $result = ['value' => ['shareWith' => 'l1']];
+        return [
+            [[],'users', 'n1', false],
+            [['users' => ['exact' => null,      'loose' => [$result]]], 'users',  'l1', true],
+            [['users' => ['exact' => null,      'loose' => [$result]]], 'users',  'l2', false],
+            [['users' => ['exact' => null,      'loose' => [$result]]], 'groups', 'l1', false],
+            [['users' => ['exact' => [$result], 'loose' => []]],        'users',  'l1', true],
+            [['users' => ['exact' => [$result], 'loose' => []]],        'users',  'l2', false],
+            [['users' => ['exact' => [$result], 'loose' => []]],        'groups', 'l1', false],
 
-		];
-	}
+        ];
+    }
 
-	/**
-	 * @dataProvider dataHasResult
-	 * @param array $toAdd
-	 * @param string $type
-	 * @param string $id
-	 * @param bool $expected
-	 */
-	public function testHasResult(array $toAdd, $type, $id, $expected): void {
-		$result = new SearchResult();
+    /**
+     * @dataProvider dataHasResult
+     * @param array $toAdd
+     * @param string $type
+     * @param string $id
+     * @param bool $expected
+     */
+    public function testHasResult(array $toAdd, $type, $id, $expected): void {
+        $result = new SearchResult();
 
-		foreach ($toAdd as $addType => $results) {
-			$result->addResultSet(new SearchResultType($addType), $results['loose'], $results['exact']);
-		}
+        foreach ($toAdd as $addType => $results) {
+            $result->addResultSet(new SearchResultType($addType), $results['loose'], $results['exact']);
+        }
 
-		$this->assertSame($expected, $result->hasResult(new SearchResultType($type), $id));
-	}
+        $this->assertSame($expected, $result->hasResult(new SearchResultType($type), $id));
+    }
 }

Spacing +7 added lines, -7 removed lines

@@ -54,13 +54,13 @@
 	public static function dataHasResult(): array {
 		$result = ['value' => ['shareWith' => 'l1']];
 		return [
-			[[],'users', 'n1', false],
-			[['users' => ['exact' => null,      'loose' => [$result]]], 'users',  'l1', true],
-			[['users' => ['exact' => null,      'loose' => [$result]]], 'users',  'l2', false],
-			[['users' => ['exact' => null,      'loose' => [$result]]], 'groups', 'l1', false],
-			[['users' => ['exact' => [$result], 'loose' => []]],        'users',  'l1', true],
-			[['users' => ['exact' => [$result], 'loose' => []]],        'users',  'l2', false],
-			[['users' => ['exact' => [$result], 'loose' => []]],        'groups', 'l1', false],
+			[[], 'users', 'n1', false],
+			[['users' => ['exact' => null, 'loose' => [$result]]], 'users', 'l1', true],
+			[['users' => ['exact' => null, 'loose' => [$result]]], 'users', 'l2', false],
+			[['users' => ['exact' => null, 'loose' => [$result]]], 'groups', 'l1', false],
+			[['users' => ['exact' => [$result], 'loose' => []]], 'users', 'l1', true],
+			[['users' => ['exact' => [$result], 'loose' => []]], 'users', 'l2', false],
+			[['users' => ['exact' => [$result], 'loose' => []]], 'groups', 'l1', false],
 
 		];
 	}

tests/lib/Collaboration/Collaborators/SearchTest.php

Indentation +235 added lines, -235 removed lines

@@ -16,239 +16,239 @@
 use Test\TestCase;
 
 class SearchTest extends TestCase {
-	/** @var IContainer|\PHPUnit\Framework\MockObject\MockObject */
-	protected $container;
-	/** @var ISearch */
-	protected $search;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->container = $this->createMock(IContainer::class);
-
-		$this->search = new Search($this->container);
-	}
-
-	/**
-	 * @dataProvider dataSearchSharees
-	 */
-	public function testSearch(
-		string $searchTerm,
-		array $shareTypes,
-		int $page,
-		int $perPage,
-		array $mockedUserResult,
-		array $mockedGroupsResult,
-		array $mockedRemotesResult,
-		array $mockedMailResult,
-		array $expected,
-		bool $expectedMoreResults,
-	): void {
-		$searchResult = new SearchResult();
-
-		$userPlugin = $this->createMock(ISearchPlugin::class);
-		$userPlugin->expects($this->any())
-			->method('search')
-			->willReturnCallback(function () use ($searchResult, $mockedUserResult, $expectedMoreResults) {
-				$type = new SearchResultType('users');
-				$searchResult->addResultSet($type, $mockedUserResult);
-				return $expectedMoreResults;
-			});
-
-		$groupPlugin = $this->createMock(ISearchPlugin::class);
-		$groupPlugin->expects($this->any())
-			->method('search')
-			->willReturnCallback(function () use ($searchResult, $mockedGroupsResult, $expectedMoreResults) {
-				$type = new SearchResultType('groups');
-				$searchResult->addResultSet($type, $mockedGroupsResult);
-				return $expectedMoreResults;
-			});
-
-		$remotePlugin = $this->createMock(ISearchPlugin::class);
-		$remotePlugin->expects($this->any())
-			->method('search')
-			->willReturnCallback(function () use ($searchResult, $mockedRemotesResult, $expectedMoreResults) {
-				if ($mockedRemotesResult !== null) {
-					$type = new SearchResultType('remotes');
-					$searchResult->addResultSet($type, $mockedRemotesResult['results'], $mockedRemotesResult['exact']);
-					if ($mockedRemotesResult['exactIdMatch'] === true) {
-						$searchResult->markExactIdMatch($type);
-					}
-				}
-				return $expectedMoreResults;
-			});
-
-		$mailPlugin = $this->createMock(ISearchPlugin::class);
-		$mailPlugin->expects($this->any())
-			->method('search')
-			->willReturnCallback(function () use ($searchResult, $mockedMailResult, $expectedMoreResults) {
-				$type = new SearchResultType('emails');
-				$searchResult->addResultSet($type, $mockedMailResult);
-				return $expectedMoreResults;
-			});
-
-		$this->container->expects($this->any())
-			->method('resolve')
-			->willReturnCallback(function ($class) use ($searchResult, $userPlugin, $groupPlugin, $remotePlugin, $mailPlugin) {
-				if ($class === SearchResult::class) {
-					return $searchResult;
-				} elseif ($class === $userPlugin) {
-					return $userPlugin;
-				} elseif ($class === $groupPlugin) {
-					return $groupPlugin;
-				} elseif ($class === $remotePlugin) {
-					return $remotePlugin;
-				} elseif ($class === $mailPlugin) {
-					return $mailPlugin;
-				}
-				return null;
-			});
-
-		$this->search->registerPlugin(['shareType' => 'SHARE_TYPE_USER', 'class' => $userPlugin]);
-		$this->search->registerPlugin(['shareType' => 'SHARE_TYPE_GROUP', 'class' => $groupPlugin]);
-		$this->search->registerPlugin(['shareType' => 'SHARE_TYPE_REMOTE', 'class' => $remotePlugin]);
-		$this->search->registerPlugin(['shareType' => 'SHARE_TYPE_EMAIL', 'class' => $mailPlugin]);
-
-		[$results, $moreResults] = $this->search->search($searchTerm, $shareTypes, false, $perPage, $perPage * ($page - 1));
-
-		$this->assertEquals($expected, $results);
-		$this->assertSame($expectedMoreResults, $moreResults);
-	}
-
-	public static function dataSearchSharees(): array {
-		return [
-			// #0
-			[
-				'test', [IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_REMOTE], 1, 2, [], [], ['results' => [], 'exact' => [], 'exactIdMatch' => false],
-				[],
-				[
-					'exact' => ['users' => [], 'groups' => [], 'remotes' => []],
-					'users' => [],
-					'groups' => [],
-					'remotes' => [],
-				],
-				false
-			],
-			// #1
-			[
-				'test', [IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_REMOTE], 1, 2, [], [], ['results' => [], 'exact' => [], 'exactIdMatch' => false],
-				[],
-				[
-					'exact' => ['users' => [], 'groups' => [], 'remotes' => []],
-					'users' => [],
-					'groups' => [],
-					'remotes' => [],
-				],
-				false
-			],
-			// #2
-			[
-				'test', [IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_REMOTE], 1, 2, [
-					['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
-				], [
-					['label' => 'testgroup1', 'value' => ['shareType' => IShare::TYPE_GROUP, 'shareWith' => 'testgroup1']],
-				], [
-					'results' => [['label' => 'testz@remote', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote']]], 'exact' => [], 'exactIdMatch' => false,
-				],
-				[],
-				[
-					'exact' => ['users' => [], 'groups' => [], 'remotes' => []],
-					'users' => [
-						['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
-					],
-					'groups' => [
-						['label' => 'testgroup1', 'value' => ['shareType' => IShare::TYPE_GROUP, 'shareWith' => 'testgroup1']],
-					],
-					'remotes' => [
-						['label' => 'testz@remote', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote']],
-					],
-				], true,
-			],
-			// #3 No groups requested
-			[
-				'test', [IShare::TYPE_USER, IShare::TYPE_REMOTE], 1, 2, [
-					['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
-				], [], [
-					'results' => [['label' => 'testz@remote', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote']]], 'exact' => [], 'exactIdMatch' => false
-				],
-				[],
-				[
-					'exact' => ['users' => [], 'remotes' => []],
-					'users' => [
-						['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
-					],
-					'remotes' => [
-						['label' => 'testz@remote', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote']],
-					],
-				], false,
-			],
-			// #4 Share type restricted to user - Only one user
-			[
-				'test', [IShare::TYPE_USER], 1, 2, [
-					['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
-				], [], [], [],
-				[
-					'exact' => ['users' => []],
-					'users' => [
-						['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
-					],
-				], false,
-			],
-			// #5 Share type restricted to user - Multipage result
-			[
-				'test', [IShare::TYPE_USER], 1, 2, [
-					['label' => 'test 1', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
-					['label' => 'test 2', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2']],
-				], [], [], [],
-				[
-					'exact' => ['users' => []],
-					'users' => [
-						['label' => 'test 1', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
-						['label' => 'test 2', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2']],
-					],
-				], true,
-			],
-			// #6 Mail shares filtered out in favor of remote shares
-			[
-				'test', // search term
-				[IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_REMOTE, IShare::TYPE_EMAIL], // plugins
-				1, // page
-				10, // per page
-				[  // user result
-					['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
-				],
-				[  // group result
-					['label' => 'testgroup1', 'value' => ['shareType' => IShare::TYPE_GROUP, 'shareWith' => 'testgroup1']],
-				],
-				[  // remote result
-					'results' => [
-						['label' => 'testz@remote.tld', 'uuid' => 'f3d78140-abcc-46df-b58d-c7cc1176aadf','value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote.tld']]
-					],
-					'exact' => [],
-					'exactIdMatch' => false,
-				],
-				[  //  mail result
-					['label' => 'test Two', 'uuid' => 'b2321e9e-31af-43ac-a406-583fb26d1964', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test2@remote.tld']],
-					['label' => 'test One', 'uuid' => 'f3d78140-abcc-46df-b58d-c7cc1176aadf', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'testz@remote.tld']],
-				],
-				[  // expected result
-					'exact' => ['users' => [], 'groups' => [], 'remotes' => [], 'emails' => []],
-					'users' => [
-						['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
-					],
-					'groups' => [
-						['label' => 'testgroup1', 'value' => ['shareType' => IShare::TYPE_GROUP, 'shareWith' => 'testgroup1']],
-					],
-					'remotes' => [
-						['label' => 'testz@remote.tld', 'uuid' => 'f3d78140-abcc-46df-b58d-c7cc1176aadf', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote.tld']],
-					],
-					'emails' => [
-						//  one passes, another is filtered out
-						['label' => 'test Two', 'uuid' => 'b2321e9e-31af-43ac-a406-583fb26d1964', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test2@remote.tld']]
-					]
-				],
-				false, // expected more results indicator
-			],
-		];
-	}
+    /** @var IContainer|\PHPUnit\Framework\MockObject\MockObject */
+    protected $container;
+    /** @var ISearch */
+    protected $search;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->container = $this->createMock(IContainer::class);
+
+        $this->search = new Search($this->container);
+    }
+
+    /**
+     * @dataProvider dataSearchSharees
+     */
+    public function testSearch(
+        string $searchTerm,
+        array $shareTypes,
+        int $page,
+        int $perPage,
+        array $mockedUserResult,
+        array $mockedGroupsResult,
+        array $mockedRemotesResult,
+        array $mockedMailResult,
+        array $expected,
+        bool $expectedMoreResults,
+    ): void {
+        $searchResult = new SearchResult();
+
+        $userPlugin = $this->createMock(ISearchPlugin::class);
+        $userPlugin->expects($this->any())
+            ->method('search')
+            ->willReturnCallback(function () use ($searchResult, $mockedUserResult, $expectedMoreResults) {
+                $type = new SearchResultType('users');
+                $searchResult->addResultSet($type, $mockedUserResult);
+                return $expectedMoreResults;
+            });
+
+        $groupPlugin = $this->createMock(ISearchPlugin::class);
+        $groupPlugin->expects($this->any())
+            ->method('search')
+            ->willReturnCallback(function () use ($searchResult, $mockedGroupsResult, $expectedMoreResults) {
+                $type = new SearchResultType('groups');
+                $searchResult->addResultSet($type, $mockedGroupsResult);
+                return $expectedMoreResults;
+            });
+
+        $remotePlugin = $this->createMock(ISearchPlugin::class);
+        $remotePlugin->expects($this->any())
+            ->method('search')
+            ->willReturnCallback(function () use ($searchResult, $mockedRemotesResult, $expectedMoreResults) {
+                if ($mockedRemotesResult !== null) {
+                    $type = new SearchResultType('remotes');
+                    $searchResult->addResultSet($type, $mockedRemotesResult['results'], $mockedRemotesResult['exact']);
+                    if ($mockedRemotesResult['exactIdMatch'] === true) {
+                        $searchResult->markExactIdMatch($type);
+                    }
+                }
+                return $expectedMoreResults;
+            });
+
+        $mailPlugin = $this->createMock(ISearchPlugin::class);
+        $mailPlugin->expects($this->any())
+            ->method('search')
+            ->willReturnCallback(function () use ($searchResult, $mockedMailResult, $expectedMoreResults) {
+                $type = new SearchResultType('emails');
+                $searchResult->addResultSet($type, $mockedMailResult);
+                return $expectedMoreResults;
+            });
+
+        $this->container->expects($this->any())
+            ->method('resolve')
+            ->willReturnCallback(function ($class) use ($searchResult, $userPlugin, $groupPlugin, $remotePlugin, $mailPlugin) {
+                if ($class === SearchResult::class) {
+                    return $searchResult;
+                } elseif ($class === $userPlugin) {
+                    return $userPlugin;
+                } elseif ($class === $groupPlugin) {
+                    return $groupPlugin;
+                } elseif ($class === $remotePlugin) {
+                    return $remotePlugin;
+                } elseif ($class === $mailPlugin) {
+                    return $mailPlugin;
+                }
+                return null;
+            });
+
+        $this->search->registerPlugin(['shareType' => 'SHARE_TYPE_USER', 'class' => $userPlugin]);
+        $this->search->registerPlugin(['shareType' => 'SHARE_TYPE_GROUP', 'class' => $groupPlugin]);
+        $this->search->registerPlugin(['shareType' => 'SHARE_TYPE_REMOTE', 'class' => $remotePlugin]);
+        $this->search->registerPlugin(['shareType' => 'SHARE_TYPE_EMAIL', 'class' => $mailPlugin]);
+
+        [$results, $moreResults] = $this->search->search($searchTerm, $shareTypes, false, $perPage, $perPage * ($page - 1));
+
+        $this->assertEquals($expected, $results);
+        $this->assertSame($expectedMoreResults, $moreResults);
+    }
+
+    public static function dataSearchSharees(): array {
+        return [
+            // #0
+            [
+                'test', [IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_REMOTE], 1, 2, [], [], ['results' => [], 'exact' => [], 'exactIdMatch' => false],
+                [],
+                [
+                    'exact' => ['users' => [], 'groups' => [], 'remotes' => []],
+                    'users' => [],
+                    'groups' => [],
+                    'remotes' => [],
+                ],
+                false
+            ],
+            // #1
+            [
+                'test', [IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_REMOTE], 1, 2, [], [], ['results' => [], 'exact' => [], 'exactIdMatch' => false],
+                [],
+                [
+                    'exact' => ['users' => [], 'groups' => [], 'remotes' => []],
+                    'users' => [],
+                    'groups' => [],
+                    'remotes' => [],
+                ],
+                false
+            ],
+            // #2
+            [
+                'test', [IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_REMOTE], 1, 2, [
+                    ['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
+                ], [
+                    ['label' => 'testgroup1', 'value' => ['shareType' => IShare::TYPE_GROUP, 'shareWith' => 'testgroup1']],
+                ], [
+                    'results' => [['label' => 'testz@remote', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote']]], 'exact' => [], 'exactIdMatch' => false,
+                ],
+                [],
+                [
+                    'exact' => ['users' => [], 'groups' => [], 'remotes' => []],
+                    'users' => [
+                        ['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
+                    ],
+                    'groups' => [
+                        ['label' => 'testgroup1', 'value' => ['shareType' => IShare::TYPE_GROUP, 'shareWith' => 'testgroup1']],
+                    ],
+                    'remotes' => [
+                        ['label' => 'testz@remote', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote']],
+                    ],
+                ], true,
+            ],
+            // #3 No groups requested
+            [
+                'test', [IShare::TYPE_USER, IShare::TYPE_REMOTE], 1, 2, [
+                    ['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
+                ], [], [
+                    'results' => [['label' => 'testz@remote', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote']]], 'exact' => [], 'exactIdMatch' => false
+                ],
+                [],
+                [
+                    'exact' => ['users' => [], 'remotes' => []],
+                    'users' => [
+                        ['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
+                    ],
+                    'remotes' => [
+                        ['label' => 'testz@remote', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote']],
+                    ],
+                ], false,
+            ],
+            // #4 Share type restricted to user - Only one user
+            [
+                'test', [IShare::TYPE_USER], 1, 2, [
+                    ['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
+                ], [], [], [],
+                [
+                    'exact' => ['users' => []],
+                    'users' => [
+                        ['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
+                    ],
+                ], false,
+            ],
+            // #5 Share type restricted to user - Multipage result
+            [
+                'test', [IShare::TYPE_USER], 1, 2, [
+                    ['label' => 'test 1', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
+                    ['label' => 'test 2', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2']],
+                ], [], [], [],
+                [
+                    'exact' => ['users' => []],
+                    'users' => [
+                        ['label' => 'test 1', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
+                        ['label' => 'test 2', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2']],
+                    ],
+                ], true,
+            ],
+            // #6 Mail shares filtered out in favor of remote shares
+            [
+                'test', // search term
+                [IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_REMOTE, IShare::TYPE_EMAIL], // plugins
+                1, // page
+                10, // per page
+                [  // user result
+                    ['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
+                ],
+                [  // group result
+                    ['label' => 'testgroup1', 'value' => ['shareType' => IShare::TYPE_GROUP, 'shareWith' => 'testgroup1']],
+                ],
+                [  // remote result
+                    'results' => [
+                        ['label' => 'testz@remote.tld', 'uuid' => 'f3d78140-abcc-46df-b58d-c7cc1176aadf','value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote.tld']]
+                    ],
+                    'exact' => [],
+                    'exactIdMatch' => false,
+                ],
+                [  //  mail result
+                    ['label' => 'test Two', 'uuid' => 'b2321e9e-31af-43ac-a406-583fb26d1964', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test2@remote.tld']],
+                    ['label' => 'test One', 'uuid' => 'f3d78140-abcc-46df-b58d-c7cc1176aadf', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'testz@remote.tld']],
+                ],
+                [  // expected result
+                    'exact' => ['users' => [], 'groups' => [], 'remotes' => [], 'emails' => []],
+                    'users' => [
+                        ['label' => 'test One', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1']],
+                    ],
+                    'groups' => [
+                        ['label' => 'testgroup1', 'value' => ['shareType' => IShare::TYPE_GROUP, 'shareWith' => 'testgroup1']],
+                    ],
+                    'remotes' => [
+                        ['label' => 'testz@remote.tld', 'uuid' => 'f3d78140-abcc-46df-b58d-c7cc1176aadf', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'testz@remote.tld']],
+                    ],
+                    'emails' => [
+                        //  one passes, another is filtered out
+                        ['label' => 'test Two', 'uuid' => 'b2321e9e-31af-43ac-a406-583fb26d1964', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test2@remote.tld']]
+                    ]
+                ],
+                false, // expected more results indicator
+            ],
+        ];
+    }
 }

tests/lib/Collaboration/Collaborators/MailPluginTest.php

Indentation +677 added lines, -677 removed lines

@@ -26,681 +26,681 @@
 use Test\TestCase;
 
 class MailPluginTest extends TestCase {
-	/** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
-	protected $config;
-
-	/** @var IManager|\PHPUnit\Framework\MockObject\MockObject */
-	protected $contactsManager;
-
-	/** @var ICloudIdManager|\PHPUnit\Framework\MockObject\MockObject */
-	protected $cloudIdManager;
-
-	/** @var MailPlugin */
-	protected $plugin;
-
-	/** @var SearchResult */
-	protected $searchResult;
-
-	/** @var IGroupManager|\PHPUnit\Framework\MockObject\MockObject */
-	protected $groupManager;
-
-	/** @var KnownUserService|\PHPUnit\Framework\MockObject\MockObject */
-	protected $knownUserService;
-
-	/** @var IUserSession|\PHPUnit\Framework\MockObject\MockObject */
-	protected $userSession;
-
-	/** @var IMailer|\PHPUnit\Framework\MockObject\MockObject */
-	protected $mailer;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->createMock(IConfig::class);
-		$this->contactsManager = $this->createMock(IManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->knownUserService = $this->createMock(KnownUserService::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->mailer = $this->createMock(IMailer::class);
-		$this->cloudIdManager = new CloudIdManager(
-			$this->contactsManager,
-			$this->createMock(IURLGenerator::class),
-			$this->createMock(IUserManager::class),
-			$this->createMock(ICacheFactory::class),
-			$this->createMock(IEventDispatcher::class)
-		);
-
-		$this->searchResult = new SearchResult();
-	}
-
-	public function instantiatePlugin() {
-		$this->plugin = new MailPlugin(
-			$this->contactsManager,
-			$this->cloudIdManager,
-			$this->config,
-			$this->groupManager,
-			$this->knownUserService,
-			$this->userSession,
-			$this->mailer
-		);
-	}
-
-	/**
-	 * @dataProvider dataGetEmail
-	 *
-	 * @param string $searchTerm
-	 * @param array $contacts
-	 * @param bool $shareeEnumeration
-	 * @param array $expected
-	 * @param bool $reachedEnd
-	 */
-	public function testSearch($searchTerm, $contacts, $shareeEnumeration, $expected, $exactIdMatch, $reachedEnd, $validEmail): void {
-		$this->config->expects($this->any())
-			->method('getAppValue')
-			->willReturnCallback(
-				function ($appName, $key, $default) use ($shareeEnumeration) {
-					if ($appName === 'core' && $key === 'shareapi_allow_share_dialog_user_enumeration') {
-						return $shareeEnumeration ? 'yes' : 'no';
-					}
-					return $default;
-				}
-			);
-
-		$this->instantiatePlugin();
-
-		$currentUser = $this->createMock(IUser::class);
-		$currentUser->method('getUID')
-			->willReturn('current');
-		$this->userSession->method('getUser')
-			->willReturn($currentUser);
-
-		$this->mailer->method('validateMailAddress')
-			->willReturn($validEmail);
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturnCallback(function ($search, $searchAttributes) use ($searchTerm, $contacts) {
-				if ($search === $searchTerm) {
-					return $contacts;
-				}
-				return [];
-			});
-
-		$moreResults = $this->plugin->search($searchTerm, 2, 0, $this->searchResult);
-		$result = $this->searchResult->asArray();
-
-		$this->assertSame($exactIdMatch, $this->searchResult->hasExactIdMatch(new SearchResultType('emails')));
-		$this->assertEquals($expected, $result);
-		$this->assertSame($reachedEnd, $moreResults);
-	}
-
-	public static function dataGetEmail(): array {
-		return [
-			// data set 0
-			['test', [], true, ['emails' => [], 'exact' => ['emails' => []]], false, false, false],
-			// data set 1
-			['test', [], false, ['emails' => [], 'exact' => ['emails' => []]], false, false, false],
-			// data set 2
-			[
-				'test@remote.com',
-				[],
-				true,
-				['emails' => [], 'exact' => ['emails' => [['uuid' => 'test@remote.com', 'label' => 'test@remote.com', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@remote.com']]]]],
-				false,
-				false,
-				true,
-			],
-			// data set 3
-			[ // no valid email address
-				'test@remote',
-				[],
-				true,
-				['emails' => [], 'exact' => ['emails' => []]],
-				false,
-				false,
-				false,
-			],
-			// data set 4
-			[
-				'test@remote.com',
-				[],
-				false,
-				['emails' => [], 'exact' => ['emails' => [['uuid' => 'test@remote.com', 'label' => 'test@remote.com', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@remote.com']]]]],
-				false,
-				false,
-				true,
-			],
-			// data set 5
-			[
-				'test',
-				[
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'UID' => 'uid1',
-						'FN' => 'User @ Localhost',
-						'EMAIL' => [
-							'username@example.com',
-						],
-					],
-				],
-				true,
-				['emails' => [['uuid' => 'uid1', 'name' => 'User @ Localhost', 'type' => '', 'label' => 'User @ Localhost (username@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'username@example.com']]], 'exact' => ['emails' => []]],
-				false,
-				false,
-				false,
-			],
-			// data set 6
-			[
-				'test',
-				[
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'isLocalSystemBook' => true,
-						'UID' => 'uid1',
-						'FN' => 'User @ Localhost',
-						'EMAIL' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['emails' => [], 'exact' => ['emails' => []]],
-				false,
-				false,
-				false,
-			],
-			// data set 7
-			[
-				'test@remote.com',
-				[
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3 @ example.com',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2 @ example.com',
-						'EMAIL' => [
-						],
-					],
-					[
-						'UID' => 'uid1',
-						'FN' => 'User @ example.com',
-						'EMAIL' => [
-							'username@example.com',
-						],
-					],
-				],
-				true,
-				['emails' => [['uuid' => 'uid1', 'name' => 'User @ example.com', 'type' => '', 'label' => 'User @ example.com (username@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'username@example.com']]], 'exact' => ['emails' => [['label' => 'test@remote.com', 'uuid' => 'test@remote.com', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@remote.com']]]]],
-				false,
-				false,
-				true,
-			],
-			// data set 8
-			[
-				'test@remote.com',
-				[
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'isLocalSystemBook' => true,
-						'UID' => 'uid1',
-						'FN' => 'User @ Localhost',
-						'EMAIL' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['emails' => [], 'exact' => ['emails' => [['label' => 'test@remote.com', 'uuid' => 'test@remote.com', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@remote.com']]]]],
-				false,
-				false,
-				true,
-			],
-			// data set 9
-			[
-				'username@example.com',
-				[
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3 @ example.com',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2 @ example.com',
-						'EMAIL' => [
-						],
-					],
-					[
-						'UID' => 'uid1',
-						'FN' => 'User @ example.com',
-						'EMAIL' => [
-							'username@example.com',
-						],
-					],
-				],
-				true,
-				['emails' => [], 'exact' => ['emails' => [['name' => 'User @ example.com', 'uuid' => 'uid1', 'type' => '', 'label' => 'User @ example.com (username@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'username@example.com']]]]],
-				true,
-				false,
-				false,
-			],
-			// data set 10
-			[
-				'username@example.com',
-				[
-					[
-						'UID' => 'uid1',
-						'FN' => 'User3 @ example.com',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2 @ example.com',
-						'EMAIL' => [
-						],
-					],
-					[
-						'UID' => 'uid1',
-						'FN' => 'User @ example.com',
-						'EMAIL' => [
-							'username@example.com',
-						],
-					],
-				],
-				false,
-				['emails' => [], 'exact' => ['emails' => [['name' => 'User @ example.com', 'uuid' => 'uid1', 'type' => '', 'label' => 'User @ example.com (username@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'username@example.com']]]]],
-				true,
-				false,
-				false,
-			],
-			// data set 11
-			// contact with space
-			[
-				'user name@localhost',
-				[
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'UID' => 'uid1',
-						'FN' => 'User Name @ Localhost',
-						'EMAIL' => [
-							'user name@localhost',
-						],
-					],
-				],
-				false,
-				['emails' => [], 'exact' => ['emails' => []]],
-				false,
-				false,
-				false,
-			],
-			// data set 12
-			// remote with space, no contact
-			[
-				'user space@remote.com',
-				[
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'isLocalSystemBook' => true,
-						'UID' => 'uid1',
-						'FN' => 'User @ Localhost',
-						'EMAIL' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['emails' => [], 'exact' => ['emails' => []]],
-				false,
-				false,
-				false,
-			],
-			// data set 13
-			// Local user found by email
-			[
-				'test@example.com',
-				[
-					[
-						'UID' => 'uid1',
-						'FN' => 'User',
-						'EMAIL' => ['test@example.com'],
-						'CLOUD' => ['test@localhost'],
-						'isLocalSystemBook' => true,
-					]
-				],
-				false,
-				['users' => [], 'exact' => ['users' => [['uuid' => 'uid1', 'name' => 'User', 'label' => 'User (test@example.com)','value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'shareWithDisplayNameUnique' => 'test@example.com']]]],
-				true,
-				false,
-				true,
-			],
-			// data set 14
-			// Current local user found by email => no result
-			[
-				'test@example.com',
-				[
-					[
-						'UID' => 'uid1',
-						'FN' => 'User',
-						'EMAIL' => ['test@example.com'],
-						'CLOUD' => ['current@localhost'],
-						'isLocalSystemBook' => true,
-					]
-				],
-				true,
-				['exact' => []],
-				false,
-				false,
-				true,
-			],
-			// data set 15
-			// Pagination and "more results" for user matches byyyyyyy emails
-			[
-				'test@example',
-				[
-					[
-						'UID' => 'uid1',
-						'FN' => 'User1',
-						'EMAIL' => ['test@example.com'],
-						'CLOUD' => ['test1@localhost'],
-						'isLocalSystemBook' => true,
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2',
-						'EMAIL' => ['test@example.de'],
-						'CLOUD' => ['test2@localhost'],
-						'isLocalSystemBook' => true,
-					],
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3',
-						'EMAIL' => ['test@example.org'],
-						'CLOUD' => ['test3@localhost'],
-						'isLocalSystemBook' => true,
-					],
-					[
-						'UID' => 'uid4',
-						'FN' => 'User4',
-						'EMAIL' => ['test@example.net'],
-						'CLOUD' => ['test4@localhost'],
-						'isLocalSystemBook' => true,
-					],
-				],
-				true,
-				['users' => [
-					['uuid' => 'uid1', 'name' => 'User1', 'label' => 'User1 (test@example.com)', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'shareWithDisplayNameUnique' => 'test@example.com'],
-					['uuid' => 'uid2', 'name' => 'User2', 'label' => 'User2 (test@example.de)', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'shareWithDisplayNameUnique' => 'test@example.de'],
-				], 'emails' => [], 'exact' => ['users' => [], 'emails' => []]],
-				false,
-				true,
-				false,
-			],
-			// data set 16
-			// Pagination and "more results" for normal emails
-			[
-				'test@example',
-				[
-					[
-						'UID' => 'uid1',
-						'FN' => 'User1',
-						'EMAIL' => ['test@example.com'],
-						'CLOUD' => ['test1@localhost'],
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2',
-						'EMAIL' => ['test@example.de'],
-						'CLOUD' => ['test2@localhost'],
-					],
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3',
-						'EMAIL' => ['test@example.org'],
-						'CLOUD' => ['test3@localhost'],
-					],
-					[
-						'UID' => 'uid4',
-						'FN' => 'User4',
-						'EMAIL' => ['test@example.net'],
-						'CLOUD' => ['test4@localhost'],
-					],
-				],
-				true,
-				['emails' => [
-					['uuid' => 'uid1', 'name' => 'User1', 'type' => '', 'label' => 'User1 (test@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@example.com']],
-					['uuid' => 'uid2', 'name' => 'User2', 'type' => '', 'label' => 'User2 (test@example.de)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@example.de']],
-				], 'exact' => ['emails' => []]],
-				false,
-				true,
-				false,
-			],
-			// data set 17
-			// multiple email addresses with type
-			[
-				'User Name',
-				[
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2',
-						'EMAIL' => [
-						],
-					],
-					[
-						'UID' => 'uid1',
-						'FN' => 'User Name',
-						'EMAIL' => [
-							['type' => 'HOME', 'value' => 'username@example.com'],
-							['type' => 'WORK', 'value' => 'other@example.com'],
-						],
-					],
-				],
-				false,
-				['emails' => [
-				], 'exact' => ['emails' => [
-					['name' => 'User Name', 'uuid' => 'uid1', 'type' => 'HOME', 'label' => 'User Name (username@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'username@example.com']],
-					['name' => 'User Name', 'uuid' => 'uid1', 'type' => 'WORK', 'label' => 'User Name (other@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'other@example.com']]
-				]]],
-				false,
-				false,
-				false,
-			],
-			// data set 18
-			// idn email
-			[
-				'test@lölölölölölölöl.com',
-				[],
-				true,
-				['emails' => [], 'exact' => ['emails' => [['uuid' => 'test@lölölölölölölöl.com', 'label' => 'test@lölölölölölölöl.com', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@lölölölölölölöl.com']]]]],
-				false,
-				false,
-				true,
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider dataGetEmailGroupsOnly
-	 *
-	 * @param string $searchTerm
-	 * @param array $contacts
-	 * @param array $expected
-	 * @param bool $exactIdMatch
-	 * @param bool $reachedEnd
-	 * @param array groups
-	 */
-	public function testSearchGroupsOnly($searchTerm, $contacts, $expected, $exactIdMatch, $reachedEnd, $userToGroupMapping, $validEmail): void {
-		$this->config->expects($this->any())
-			->method('getAppValue')
-			->willReturnCallback(
-				function ($appName, $key, $default) {
-					if ($appName === 'core' && $key === 'shareapi_allow_share_dialog_user_enumeration') {
-						return 'yes';
-					} elseif ($appName === 'core' && $key === 'shareapi_only_share_with_group_members') {
-						return 'yes';
-					}
-					return $default;
-				}
-			);
-
-		$this->instantiatePlugin();
-
-		/** @var \OCP\IUser | \PHPUnit\Framework\MockObject\MockObject */
-		$currentUser = $this->createMock('\OCP\IUser');
-
-		$currentUser->expects($this->any())
-			->method('getUID')
-			->willReturn('currentUser');
-
-		$this->mailer->method('validateMailAddress')
-			->willReturn($validEmail);
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturnCallback(function ($search, $searchAttributes) use ($searchTerm, $contacts) {
-				if ($search === $searchTerm) {
-					return $contacts;
-				}
-				return [];
-			});
-
-		$this->userSession->expects($this->any())
-			->method('getUser')
-			->willReturn($currentUser);
-
-		$this->groupManager->expects($this->any())
-			->method('getUserGroupIds')
-			->willReturnCallback(function (\OCP\IUser $user) use ($userToGroupMapping) {
-				return $userToGroupMapping[$user->getUID()];
-			});
-
-		$this->groupManager->expects($this->any())
-			->method('isInGroup')
-			->willReturnCallback(function ($userId, $group) use ($userToGroupMapping) {
-				return in_array($group, $userToGroupMapping[$userId]);
-			});
-
-		$moreResults = $this->plugin->search($searchTerm, 2, 0, $this->searchResult);
-		$result = $this->searchResult->asArray();
-
-		$this->assertSame($exactIdMatch, $this->searchResult->hasExactIdMatch(new SearchResultType('emails')));
-		$this->assertEquals($expected, $result);
-		$this->assertSame($reachedEnd, $moreResults);
-	}
-
-	public static function dataGetEmailGroupsOnly(): array {
-		return [
-			// The user `User` can share with the current user
-			[
-				'test',
-				[
-					[
-						'FN' => 'User',
-						'EMAIL' => ['test@example.com'],
-						'CLOUD' => ['test@localhost'],
-						'isLocalSystemBook' => true,
-						'UID' => 'User'
-					]
-				],
-				['users' => [['label' => 'User (test@example.com)', 'uuid' => 'User', 'name' => 'User', 'value' => ['shareType' => 0, 'shareWith' => 'test'],'shareWithDisplayNameUnique' => 'test@example.com',]], 'emails' => [], 'exact' => ['emails' => [], 'users' => []]],
-				false,
-				false,
-				[
-					'currentUser' => ['group1'],
-					'User' => ['group1']
-				],
-				false,
-			],
-			// The user `User` cannot share with the current user
-			[
-				'test',
-				[
-					[
-						'FN' => 'User',
-						'EMAIL' => ['test@example.com'],
-						'CLOUD' => ['test@localhost'],
-						'isLocalSystemBook' => true,
-						'UID' => 'User'
-					]
-				],
-				['emails' => [], 'exact' => ['emails' => []]],
-				false,
-				false,
-				[
-					'currentUser' => ['group1'],
-					'User' => ['group2']
-				],
-				false,
-			],
-			// The user `User` cannot share with the current user, but there is an exact match on the e-mail address -> share by e-mail
-			[
-				'test@example.com',
-				[
-					[
-						'FN' => 'User',
-						'EMAIL' => ['test@example.com'],
-						'CLOUD' => ['test@localhost'],
-						'isLocalSystemBook' => true,
-						'UID' => 'User'
-					]
-				],
-				['emails' => [], 'exact' => ['emails' => [['label' => 'test@example.com', 'uuid' => 'test@example.com', 'value' => ['shareType' => 4,'shareWith' => 'test@example.com']]]]],
-				false,
-				false,
-				[
-					'currentUser' => ['group1'],
-					'User' => ['group2']
-				],
-				true,
-			]
-		];
-	}
+    /** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
+    protected $config;
+
+    /** @var IManager|\PHPUnit\Framework\MockObject\MockObject */
+    protected $contactsManager;
+
+    /** @var ICloudIdManager|\PHPUnit\Framework\MockObject\MockObject */
+    protected $cloudIdManager;
+
+    /** @var MailPlugin */
+    protected $plugin;
+
+    /** @var SearchResult */
+    protected $searchResult;
+
+    /** @var IGroupManager|\PHPUnit\Framework\MockObject\MockObject */
+    protected $groupManager;
+
+    /** @var KnownUserService|\PHPUnit\Framework\MockObject\MockObject */
+    protected $knownUserService;
+
+    /** @var IUserSession|\PHPUnit\Framework\MockObject\MockObject */
+    protected $userSession;
+
+    /** @var IMailer|\PHPUnit\Framework\MockObject\MockObject */
+    protected $mailer;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->createMock(IConfig::class);
+        $this->contactsManager = $this->createMock(IManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->knownUserService = $this->createMock(KnownUserService::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->mailer = $this->createMock(IMailer::class);
+        $this->cloudIdManager = new CloudIdManager(
+            $this->contactsManager,
+            $this->createMock(IURLGenerator::class),
+            $this->createMock(IUserManager::class),
+            $this->createMock(ICacheFactory::class),
+            $this->createMock(IEventDispatcher::class)
+        );
+
+        $this->searchResult = new SearchResult();
+    }
+
+    public function instantiatePlugin() {
+        $this->plugin = new MailPlugin(
+            $this->contactsManager,
+            $this->cloudIdManager,
+            $this->config,
+            $this->groupManager,
+            $this->knownUserService,
+            $this->userSession,
+            $this->mailer
+        );
+    }
+
+    /**
+     * @dataProvider dataGetEmail
+     *
+     * @param string $searchTerm
+     * @param array $contacts
+     * @param bool $shareeEnumeration
+     * @param array $expected
+     * @param bool $reachedEnd
+     */
+    public function testSearch($searchTerm, $contacts, $shareeEnumeration, $expected, $exactIdMatch, $reachedEnd, $validEmail): void {
+        $this->config->expects($this->any())
+            ->method('getAppValue')
+            ->willReturnCallback(
+                function ($appName, $key, $default) use ($shareeEnumeration) {
+                    if ($appName === 'core' && $key === 'shareapi_allow_share_dialog_user_enumeration') {
+                        return $shareeEnumeration ? 'yes' : 'no';
+                    }
+                    return $default;
+                }
+            );
+
+        $this->instantiatePlugin();
+
+        $currentUser = $this->createMock(IUser::class);
+        $currentUser->method('getUID')
+            ->willReturn('current');
+        $this->userSession->method('getUser')
+            ->willReturn($currentUser);
+
+        $this->mailer->method('validateMailAddress')
+            ->willReturn($validEmail);
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturnCallback(function ($search, $searchAttributes) use ($searchTerm, $contacts) {
+                if ($search === $searchTerm) {
+                    return $contacts;
+                }
+                return [];
+            });
+
+        $moreResults = $this->plugin->search($searchTerm, 2, 0, $this->searchResult);
+        $result = $this->searchResult->asArray();
+
+        $this->assertSame($exactIdMatch, $this->searchResult->hasExactIdMatch(new SearchResultType('emails')));
+        $this->assertEquals($expected, $result);
+        $this->assertSame($reachedEnd, $moreResults);
+    }
+
+    public static function dataGetEmail(): array {
+        return [
+            // data set 0
+            ['test', [], true, ['emails' => [], 'exact' => ['emails' => []]], false, false, false],
+            // data set 1
+            ['test', [], false, ['emails' => [], 'exact' => ['emails' => []]], false, false, false],
+            // data set 2
+            [
+                'test@remote.com',
+                [],
+                true,
+                ['emails' => [], 'exact' => ['emails' => [['uuid' => 'test@remote.com', 'label' => 'test@remote.com', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@remote.com']]]]],
+                false,
+                false,
+                true,
+            ],
+            // data set 3
+            [ // no valid email address
+                'test@remote',
+                [],
+                true,
+                ['emails' => [], 'exact' => ['emails' => []]],
+                false,
+                false,
+                false,
+            ],
+            // data set 4
+            [
+                'test@remote.com',
+                [],
+                false,
+                ['emails' => [], 'exact' => ['emails' => [['uuid' => 'test@remote.com', 'label' => 'test@remote.com', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@remote.com']]]]],
+                false,
+                false,
+                true,
+            ],
+            // data set 5
+            [
+                'test',
+                [
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2 @ Localhost',
+                        'EMAIL' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User @ Localhost',
+                        'EMAIL' => [
+                            'username@example.com',
+                        ],
+                    ],
+                ],
+                true,
+                ['emails' => [['uuid' => 'uid1', 'name' => 'User @ Localhost', 'type' => '', 'label' => 'User @ Localhost (username@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'username@example.com']]], 'exact' => ['emails' => []]],
+                false,
+                false,
+                false,
+            ],
+            // data set 6
+            [
+                'test',
+                [
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2 @ Localhost',
+                        'EMAIL' => [
+                        ],
+                    ],
+                    [
+                        'isLocalSystemBook' => true,
+                        'UID' => 'uid1',
+                        'FN' => 'User @ Localhost',
+                        'EMAIL' => [
+                            'username@localhost',
+                        ],
+                    ],
+                ],
+                false,
+                ['emails' => [], 'exact' => ['emails' => []]],
+                false,
+                false,
+                false,
+            ],
+            // data set 7
+            [
+                'test@remote.com',
+                [
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3 @ example.com',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2 @ example.com',
+                        'EMAIL' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User @ example.com',
+                        'EMAIL' => [
+                            'username@example.com',
+                        ],
+                    ],
+                ],
+                true,
+                ['emails' => [['uuid' => 'uid1', 'name' => 'User @ example.com', 'type' => '', 'label' => 'User @ example.com (username@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'username@example.com']]], 'exact' => ['emails' => [['label' => 'test@remote.com', 'uuid' => 'test@remote.com', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@remote.com']]]]],
+                false,
+                false,
+                true,
+            ],
+            // data set 8
+            [
+                'test@remote.com',
+                [
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2 @ Localhost',
+                        'EMAIL' => [
+                        ],
+                    ],
+                    [
+                        'isLocalSystemBook' => true,
+                        'UID' => 'uid1',
+                        'FN' => 'User @ Localhost',
+                        'EMAIL' => [
+                            'username@localhost',
+                        ],
+                    ],
+                ],
+                false,
+                ['emails' => [], 'exact' => ['emails' => [['label' => 'test@remote.com', 'uuid' => 'test@remote.com', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@remote.com']]]]],
+                false,
+                false,
+                true,
+            ],
+            // data set 9
+            [
+                'username@example.com',
+                [
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3 @ example.com',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2 @ example.com',
+                        'EMAIL' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User @ example.com',
+                        'EMAIL' => [
+                            'username@example.com',
+                        ],
+                    ],
+                ],
+                true,
+                ['emails' => [], 'exact' => ['emails' => [['name' => 'User @ example.com', 'uuid' => 'uid1', 'type' => '', 'label' => 'User @ example.com (username@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'username@example.com']]]]],
+                true,
+                false,
+                false,
+            ],
+            // data set 10
+            [
+                'username@example.com',
+                [
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User3 @ example.com',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2 @ example.com',
+                        'EMAIL' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User @ example.com',
+                        'EMAIL' => [
+                            'username@example.com',
+                        ],
+                    ],
+                ],
+                false,
+                ['emails' => [], 'exact' => ['emails' => [['name' => 'User @ example.com', 'uuid' => 'uid1', 'type' => '', 'label' => 'User @ example.com (username@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'username@example.com']]]]],
+                true,
+                false,
+                false,
+            ],
+            // data set 11
+            // contact with space
+            [
+                'user name@localhost',
+                [
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2 @ Localhost',
+                        'EMAIL' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User Name @ Localhost',
+                        'EMAIL' => [
+                            'user name@localhost',
+                        ],
+                    ],
+                ],
+                false,
+                ['emails' => [], 'exact' => ['emails' => []]],
+                false,
+                false,
+                false,
+            ],
+            // data set 12
+            // remote with space, no contact
+            [
+                'user space@remote.com',
+                [
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2 @ Localhost',
+                        'EMAIL' => [
+                        ],
+                    ],
+                    [
+                        'isLocalSystemBook' => true,
+                        'UID' => 'uid1',
+                        'FN' => 'User @ Localhost',
+                        'EMAIL' => [
+                            'username@localhost',
+                        ],
+                    ],
+                ],
+                false,
+                ['emails' => [], 'exact' => ['emails' => []]],
+                false,
+                false,
+                false,
+            ],
+            // data set 13
+            // Local user found by email
+            [
+                'test@example.com',
+                [
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User',
+                        'EMAIL' => ['test@example.com'],
+                        'CLOUD' => ['test@localhost'],
+                        'isLocalSystemBook' => true,
+                    ]
+                ],
+                false,
+                ['users' => [], 'exact' => ['users' => [['uuid' => 'uid1', 'name' => 'User', 'label' => 'User (test@example.com)','value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test'], 'shareWithDisplayNameUnique' => 'test@example.com']]]],
+                true,
+                false,
+                true,
+            ],
+            // data set 14
+            // Current local user found by email => no result
+            [
+                'test@example.com',
+                [
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User',
+                        'EMAIL' => ['test@example.com'],
+                        'CLOUD' => ['current@localhost'],
+                        'isLocalSystemBook' => true,
+                    ]
+                ],
+                true,
+                ['exact' => []],
+                false,
+                false,
+                true,
+            ],
+            // data set 15
+            // Pagination and "more results" for user matches byyyyyyy emails
+            [
+                'test@example',
+                [
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User1',
+                        'EMAIL' => ['test@example.com'],
+                        'CLOUD' => ['test1@localhost'],
+                        'isLocalSystemBook' => true,
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2',
+                        'EMAIL' => ['test@example.de'],
+                        'CLOUD' => ['test2@localhost'],
+                        'isLocalSystemBook' => true,
+                    ],
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3',
+                        'EMAIL' => ['test@example.org'],
+                        'CLOUD' => ['test3@localhost'],
+                        'isLocalSystemBook' => true,
+                    ],
+                    [
+                        'UID' => 'uid4',
+                        'FN' => 'User4',
+                        'EMAIL' => ['test@example.net'],
+                        'CLOUD' => ['test4@localhost'],
+                        'isLocalSystemBook' => true,
+                    ],
+                ],
+                true,
+                ['users' => [
+                    ['uuid' => 'uid1', 'name' => 'User1', 'label' => 'User1 (test@example.com)', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test1'], 'shareWithDisplayNameUnique' => 'test@example.com'],
+                    ['uuid' => 'uid2', 'name' => 'User2', 'label' => 'User2 (test@example.de)', 'value' => ['shareType' => IShare::TYPE_USER, 'shareWith' => 'test2'], 'shareWithDisplayNameUnique' => 'test@example.de'],
+                ], 'emails' => [], 'exact' => ['users' => [], 'emails' => []]],
+                false,
+                true,
+                false,
+            ],
+            // data set 16
+            // Pagination and "more results" for normal emails
+            [
+                'test@example',
+                [
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User1',
+                        'EMAIL' => ['test@example.com'],
+                        'CLOUD' => ['test1@localhost'],
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2',
+                        'EMAIL' => ['test@example.de'],
+                        'CLOUD' => ['test2@localhost'],
+                    ],
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3',
+                        'EMAIL' => ['test@example.org'],
+                        'CLOUD' => ['test3@localhost'],
+                    ],
+                    [
+                        'UID' => 'uid4',
+                        'FN' => 'User4',
+                        'EMAIL' => ['test@example.net'],
+                        'CLOUD' => ['test4@localhost'],
+                    ],
+                ],
+                true,
+                ['emails' => [
+                    ['uuid' => 'uid1', 'name' => 'User1', 'type' => '', 'label' => 'User1 (test@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@example.com']],
+                    ['uuid' => 'uid2', 'name' => 'User2', 'type' => '', 'label' => 'User2 (test@example.de)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@example.de']],
+                ], 'exact' => ['emails' => []]],
+                false,
+                true,
+                false,
+            ],
+            // data set 17
+            // multiple email addresses with type
+            [
+                'User Name',
+                [
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2',
+                        'EMAIL' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User Name',
+                        'EMAIL' => [
+                            ['type' => 'HOME', 'value' => 'username@example.com'],
+                            ['type' => 'WORK', 'value' => 'other@example.com'],
+                        ],
+                    ],
+                ],
+                false,
+                ['emails' => [
+                ], 'exact' => ['emails' => [
+                    ['name' => 'User Name', 'uuid' => 'uid1', 'type' => 'HOME', 'label' => 'User Name (username@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'username@example.com']],
+                    ['name' => 'User Name', 'uuid' => 'uid1', 'type' => 'WORK', 'label' => 'User Name (other@example.com)', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'other@example.com']]
+                ]]],
+                false,
+                false,
+                false,
+            ],
+            // data set 18
+            // idn email
+            [
+                'test@lölölölölölölöl.com',
+                [],
+                true,
+                ['emails' => [], 'exact' => ['emails' => [['uuid' => 'test@lölölölölölölöl.com', 'label' => 'test@lölölölölölölöl.com', 'value' => ['shareType' => IShare::TYPE_EMAIL, 'shareWith' => 'test@lölölölölölölöl.com']]]]],
+                false,
+                false,
+                true,
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider dataGetEmailGroupsOnly
+     *
+     * @param string $searchTerm
+     * @param array $contacts
+     * @param array $expected
+     * @param bool $exactIdMatch
+     * @param bool $reachedEnd
+     * @param array groups
+     */
+    public function testSearchGroupsOnly($searchTerm, $contacts, $expected, $exactIdMatch, $reachedEnd, $userToGroupMapping, $validEmail): void {
+        $this->config->expects($this->any())
+            ->method('getAppValue')
+            ->willReturnCallback(
+                function ($appName, $key, $default) {
+                    if ($appName === 'core' && $key === 'shareapi_allow_share_dialog_user_enumeration') {
+                        return 'yes';
+                    } elseif ($appName === 'core' && $key === 'shareapi_only_share_with_group_members') {
+                        return 'yes';
+                    }
+                    return $default;
+                }
+            );
+
+        $this->instantiatePlugin();
+
+        /** @var \OCP\IUser | \PHPUnit\Framework\MockObject\MockObject */
+        $currentUser = $this->createMock('\OCP\IUser');
+
+        $currentUser->expects($this->any())
+            ->method('getUID')
+            ->willReturn('currentUser');
+
+        $this->mailer->method('validateMailAddress')
+            ->willReturn($validEmail);
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturnCallback(function ($search, $searchAttributes) use ($searchTerm, $contacts) {
+                if ($search === $searchTerm) {
+                    return $contacts;
+                }
+                return [];
+            });
+
+        $this->userSession->expects($this->any())
+            ->method('getUser')
+            ->willReturn($currentUser);
+
+        $this->groupManager->expects($this->any())
+            ->method('getUserGroupIds')
+            ->willReturnCallback(function (\OCP\IUser $user) use ($userToGroupMapping) {
+                return $userToGroupMapping[$user->getUID()];
+            });
+
+        $this->groupManager->expects($this->any())
+            ->method('isInGroup')
+            ->willReturnCallback(function ($userId, $group) use ($userToGroupMapping) {
+                return in_array($group, $userToGroupMapping[$userId]);
+            });
+
+        $moreResults = $this->plugin->search($searchTerm, 2, 0, $this->searchResult);
+        $result = $this->searchResult->asArray();
+
+        $this->assertSame($exactIdMatch, $this->searchResult->hasExactIdMatch(new SearchResultType('emails')));
+        $this->assertEquals($expected, $result);
+        $this->assertSame($reachedEnd, $moreResults);
+    }
+
+    public static function dataGetEmailGroupsOnly(): array {
+        return [
+            // The user `User` can share with the current user
+            [
+                'test',
+                [
+                    [
+                        'FN' => 'User',
+                        'EMAIL' => ['test@example.com'],
+                        'CLOUD' => ['test@localhost'],
+                        'isLocalSystemBook' => true,
+                        'UID' => 'User'
+                    ]
+                ],
+                ['users' => [['label' => 'User (test@example.com)', 'uuid' => 'User', 'name' => 'User', 'value' => ['shareType' => 0, 'shareWith' => 'test'],'shareWithDisplayNameUnique' => 'test@example.com',]], 'emails' => [], 'exact' => ['emails' => [], 'users' => []]],
+                false,
+                false,
+                [
+                    'currentUser' => ['group1'],
+                    'User' => ['group1']
+                ],
+                false,
+            ],
+            // The user `User` cannot share with the current user
+            [
+                'test',
+                [
+                    [
+                        'FN' => 'User',
+                        'EMAIL' => ['test@example.com'],
+                        'CLOUD' => ['test@localhost'],
+                        'isLocalSystemBook' => true,
+                        'UID' => 'User'
+                    ]
+                ],
+                ['emails' => [], 'exact' => ['emails' => []]],
+                false,
+                false,
+                [
+                    'currentUser' => ['group1'],
+                    'User' => ['group2']
+                ],
+                false,
+            ],
+            // The user `User` cannot share with the current user, but there is an exact match on the e-mail address -> share by e-mail
+            [
+                'test@example.com',
+                [
+                    [
+                        'FN' => 'User',
+                        'EMAIL' => ['test@example.com'],
+                        'CLOUD' => ['test@localhost'],
+                        'isLocalSystemBook' => true,
+                        'UID' => 'User'
+                    ]
+                ],
+                ['emails' => [], 'exact' => ['emails' => [['label' => 'test@example.com', 'uuid' => 'test@example.com', 'value' => ['shareType' => 4,'shareWith' => 'test@example.com']]]]],
+                false,
+                false,
+                [
+                    'currentUser' => ['group1'],
+                    'User' => ['group2']
+                ],
+                true,
+            ]
+        ];
+    }
 }

tests/lib/Collaboration/Collaborators/RemotePluginTest.php

Indentation +378 added lines, -378 removed lines

@@ -23,408 +23,408 @@
 use Test\TestCase;
 
 class RemotePluginTest extends TestCase {
-	/** @var IUserManager|\PHPUnit\Framework\MockObject\MockObject */
-	protected $userManager;
+    /** @var IUserManager|\PHPUnit\Framework\MockObject\MockObject */
+    protected $userManager;
 
-	/** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
-	protected $config;
+    /** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
+    protected $config;
 
-	/** @var IManager|\PHPUnit\Framework\MockObject\MockObject */
-	protected $contactsManager;
+    /** @var IManager|\PHPUnit\Framework\MockObject\MockObject */
+    protected $contactsManager;
 
-	/** @var ICloudIdManager|\PHPUnit\Framework\MockObject\MockObject */
-	protected $cloudIdManager;
+    /** @var ICloudIdManager|\PHPUnit\Framework\MockObject\MockObject */
+    protected $cloudIdManager;
 
-	/** @var RemotePlugin */
-	protected $plugin;
+    /** @var RemotePlugin */
+    protected $plugin;
 
-	/** @var SearchResult */
-	protected $searchResult;
+    /** @var SearchResult */
+    protected $searchResult;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->contactsManager = $this->createMock(IManager::class);
-		$this->cloudIdManager = new CloudIdManager(
-			$this->contactsManager,
-			$this->createMock(IURLGenerator::class),
-			$this->createMock(IUserManager::class),
-			$this->createMock(ICacheFactory::class),
-			$this->createMock(IEventDispatcher::class)
-		);
-		$this->searchResult = new SearchResult();
-	}
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->contactsManager = $this->createMock(IManager::class);
+        $this->cloudIdManager = new CloudIdManager(
+            $this->contactsManager,
+            $this->createMock(IURLGenerator::class),
+            $this->createMock(IUserManager::class),
+            $this->createMock(ICacheFactory::class),
+            $this->createMock(IEventDispatcher::class)
+        );
+        $this->searchResult = new SearchResult();
+    }
 
-	public function instantiatePlugin() {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('admin');
-		$userSession = $this->createMock(IUserSession::class);
-		$userSession->expects($this->any())
-			->method('getUser')
-			->willReturn($user);
-		$this->plugin = new RemotePlugin($this->contactsManager, $this->cloudIdManager, $this->config, $this->userManager, $userSession);
-	}
+    public function instantiatePlugin() {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('admin');
+        $userSession = $this->createMock(IUserSession::class);
+        $userSession->expects($this->any())
+            ->method('getUser')
+            ->willReturn($user);
+        $this->plugin = new RemotePlugin($this->contactsManager, $this->cloudIdManager, $this->config, $this->userManager, $userSession);
+    }
 
-	/**
-	 * @dataProvider dataGetRemote
-	 *
-	 * @param string $searchTerm
-	 * @param array $contacts
-	 * @param bool $shareeEnumeration
-	 * @param array $expected
-	 * @param bool $exactIdMatch
-	 * @param bool $reachedEnd
-	 */
-	public function testSearch($searchTerm, array $contacts, $shareeEnumeration, array $expected, $exactIdMatch, $reachedEnd): void {
-		$this->config->expects($this->any())
-			->method('getAppValue')
-			->willReturnCallback(
-				function ($appName, $key, $default) use ($shareeEnumeration) {
-					if ($appName === 'core' && $key === 'shareapi_allow_share_dialog_user_enumeration') {
-						return $shareeEnumeration ? 'yes' : 'no';
-					}
-					return $default;
-				}
-			);
+    /**
+     * @dataProvider dataGetRemote
+     *
+     * @param string $searchTerm
+     * @param array $contacts
+     * @param bool $shareeEnumeration
+     * @param array $expected
+     * @param bool $exactIdMatch
+     * @param bool $reachedEnd
+     */
+    public function testSearch($searchTerm, array $contacts, $shareeEnumeration, array $expected, $exactIdMatch, $reachedEnd): void {
+        $this->config->expects($this->any())
+            ->method('getAppValue')
+            ->willReturnCallback(
+                function ($appName, $key, $default) use ($shareeEnumeration) {
+                    if ($appName === 'core' && $key === 'shareapi_allow_share_dialog_user_enumeration') {
+                        return $shareeEnumeration ? 'yes' : 'no';
+                    }
+                    return $default;
+                }
+            );
 
-		$this->instantiatePlugin();
+        $this->instantiatePlugin();
 
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturnCallback(function ($search, $searchAttributes) use ($searchTerm, $contacts) {
-				if ($search === $searchTerm) {
-					return $contacts;
-				}
-				return [];
-			});
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturnCallback(function ($search, $searchAttributes) use ($searchTerm, $contacts) {
+                if ($search === $searchTerm) {
+                    return $contacts;
+                }
+                return [];
+            });
 
-		$moreResults = $this->plugin->search($searchTerm, 2, 0, $this->searchResult);
-		$result = $this->searchResult->asArray();
+        $moreResults = $this->plugin->search($searchTerm, 2, 0, $this->searchResult);
+        $result = $this->searchResult->asArray();
 
-		$this->assertSame($exactIdMatch, $this->searchResult->hasExactIdMatch(new SearchResultType('remotes')));
-		$this->assertEquals($expected, $result);
-		$this->assertSame($reachedEnd, $moreResults);
-	}
+        $this->assertSame($exactIdMatch, $this->searchResult->hasExactIdMatch(new SearchResultType('remotes')));
+        $this->assertEquals($expected, $result);
+        $this->assertSame($reachedEnd, $moreResults);
+    }
 
-	/**
-	 * @dataProvider dataTestSplitUserRemote
-	 *
-	 * @param string $remote
-	 * @param string $expectedUser
-	 * @param string $expectedUrl
-	 */
-	public function testSplitUserRemote($remote, $expectedUser, $expectedUrl): void {
-		$this->instantiatePlugin();
+    /**
+     * @dataProvider dataTestSplitUserRemote
+     *
+     * @param string $remote
+     * @param string $expectedUser
+     * @param string $expectedUrl
+     */
+    public function testSplitUserRemote($remote, $expectedUser, $expectedUrl): void {
+        $this->instantiatePlugin();
 
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
 
-		[$remoteUser, $remoteUrl] = $this->plugin->splitUserRemote($remote);
-		$this->assertSame($expectedUser, $remoteUser);
-		$this->assertSame($expectedUrl, $remoteUrl);
-	}
+        [$remoteUser, $remoteUrl] = $this->plugin->splitUserRemote($remote);
+        $this->assertSame($expectedUser, $remoteUser);
+        $this->assertSame($expectedUrl, $remoteUrl);
+    }
 
-	/**
-	 * @dataProvider dataTestSplitUserRemoteError
-	 *
-	 * @param string $id
-	 */
-	public function testSplitUserRemoteError($id): void {
-		$this->expectException(\Exception::class);
+    /**
+     * @dataProvider dataTestSplitUserRemoteError
+     *
+     * @param string $id
+     */
+    public function testSplitUserRemoteError($id): void {
+        $this->expectException(\Exception::class);
 
-		$this->instantiatePlugin();
-		$this->plugin->splitUserRemote($id);
-	}
+        $this->instantiatePlugin();
+        $this->plugin->splitUserRemote($id);
+    }
 
-	public static function dataGetRemote() {
-		return [
-			['test', [], true, ['remotes' => [], 'exact' => ['remotes' => []]], false, true],
-			['test', [], false, ['remotes' => [], 'exact' => ['remotes' => []]], false, true],
-			[
-				'test@remote',
-				[],
-				true,
-				['remotes' => [], 'exact' => ['remotes' => [['label' => 'test (remote)', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'test@remote', 'server' => 'remote'], 'uuid' => 'test', 'name' => 'test']]]],
-				false,
-				true,
-			],
-			[
-				'test@remote',
-				[],
-				false,
-				['remotes' => [], 'exact' => ['remotes' => [['label' => 'test (remote)', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'test@remote', 'server' => 'remote'], 'uuid' => 'test', 'name' => 'test']]]],
-				false,
-				true,
-			],
-			[
-				'test',
-				[
-					[
-						'UID' => 'uid',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid',
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'UID' => 'uid1',
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				true,
-				['remotes' => [['name' => 'User @ Localhost', 'label' => 'User @ Localhost (username@localhost)', 'uuid' => 'uid1', 'type' => '', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]], 'exact' => ['remotes' => []]],
-				false,
-				true,
-			],
-			[
-				'test',
-				[
-					[
-						'UID' => 'uid',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid',
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'UID' => 'uid',
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['remotes' => [], 'exact' => ['remotes' => []]],
-				false,
-				true,
-			],
-			[
-				'test@remote',
-				[
-					[
-						'UID' => 'uid',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid',
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'UID' => 'uid',
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				true,
-				['remotes' => [['name' => 'User @ Localhost', 'label' => 'User @ Localhost (username@localhost)', 'uuid' => 'uid', 'type' => '', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]], 'exact' => ['remotes' => [['label' => 'test (remote)', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'test@remote', 'server' => 'remote'], 'uuid' => 'test', 'name' => 'test']]]],
-				false,
-				true,
-			],
-			[
-				'test@remote',
-				[
-					[
-						'UID' => 'uid',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid',
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'UID' => 'uid',
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['remotes' => [], 'exact' => ['remotes' => [['label' => 'test (remote)', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'test@remote', 'server' => 'remote'], 'uuid' => 'test', 'name' => 'test']]]],
-				false,
-				true,
-			],
-			[
-				'username@localhost',
-				[
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => '2',
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'UID' => 'uid1',
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				true,
-				['remotes' => [], 'exact' => ['remotes' => [['name' => 'User @ Localhost', 'label' => 'User @ Localhost (username@localhost)', 'uuid' => 'uid1', 'type' => '', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]]]],
-				true,
-				true,
-			],
-			[
-				'username@localhost',
-				[
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'UID' => 'uid1',
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['remotes' => [], 'exact' => ['remotes' => [['name' => 'User @ Localhost', 'label' => 'User @ Localhost (username@localhost)', 'uuid' => 'uid1', 'type' => '', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]]]],
-				true,
-				true,
-			],
-			// contact with space
-			[
-				'user name@localhost',
-				[
-					[
-						'UID' => 'uid1',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'UID' => 'uid3',
-						'FN' => 'User Name @ Localhost',
-						'CLOUD' => [
-							'user name@localhost',
-						],
-					],
-				],
-				false,
-				['remotes' => [], 'exact' => ['remotes' => [['name' => 'User Name @ Localhost', 'label' => 'User Name @ Localhost (user name@localhost)', 'uuid' => 'uid3', 'type' => '', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'user name@localhost', 'server' => 'localhost']]]]],
-				true,
-				true,
-			],
-			// remote with space, no contact
-			[
-				'user space@remote',
-				[
-					[
-						'UID' => 'uid3',
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'UID' => 'uid2',
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'UID' => 'uid1',
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['remotes' => [], 'exact' => ['remotes' => [['label' => 'user space (remote)', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'user space@remote', 'server' => 'remote'], 'uuid' => 'user space', 'name' => 'user space']]]],
-				false,
-				true,
-			],
-		];
-	}
+    public static function dataGetRemote() {
+        return [
+            ['test', [], true, ['remotes' => [], 'exact' => ['remotes' => []]], false, true],
+            ['test', [], false, ['remotes' => [], 'exact' => ['remotes' => []]], false, true],
+            [
+                'test@remote',
+                [],
+                true,
+                ['remotes' => [], 'exact' => ['remotes' => [['label' => 'test (remote)', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'test@remote', 'server' => 'remote'], 'uuid' => 'test', 'name' => 'test']]]],
+                false,
+                true,
+            ],
+            [
+                'test@remote',
+                [],
+                false,
+                ['remotes' => [], 'exact' => ['remotes' => [['label' => 'test (remote)', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'test@remote', 'server' => 'remote'], 'uuid' => 'test', 'name' => 'test']]]],
+                false,
+                true,
+            ],
+            [
+                'test',
+                [
+                    [
+                        'UID' => 'uid',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid',
+                        'FN' => 'User2 @ Localhost',
+                        'CLOUD' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User @ Localhost',
+                        'CLOUD' => [
+                            'username@localhost',
+                        ],
+                    ],
+                ],
+                true,
+                ['remotes' => [['name' => 'User @ Localhost', 'label' => 'User @ Localhost (username@localhost)', 'uuid' => 'uid1', 'type' => '', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]], 'exact' => ['remotes' => []]],
+                false,
+                true,
+            ],
+            [
+                'test',
+                [
+                    [
+                        'UID' => 'uid',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid',
+                        'FN' => 'User2 @ Localhost',
+                        'CLOUD' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid',
+                        'FN' => 'User @ Localhost',
+                        'CLOUD' => [
+                            'username@localhost',
+                        ],
+                    ],
+                ],
+                false,
+                ['remotes' => [], 'exact' => ['remotes' => []]],
+                false,
+                true,
+            ],
+            [
+                'test@remote',
+                [
+                    [
+                        'UID' => 'uid',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid',
+                        'FN' => 'User2 @ Localhost',
+                        'CLOUD' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid',
+                        'FN' => 'User @ Localhost',
+                        'CLOUD' => [
+                            'username@localhost',
+                        ],
+                    ],
+                ],
+                true,
+                ['remotes' => [['name' => 'User @ Localhost', 'label' => 'User @ Localhost (username@localhost)', 'uuid' => 'uid', 'type' => '', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]], 'exact' => ['remotes' => [['label' => 'test (remote)', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'test@remote', 'server' => 'remote'], 'uuid' => 'test', 'name' => 'test']]]],
+                false,
+                true,
+            ],
+            [
+                'test@remote',
+                [
+                    [
+                        'UID' => 'uid',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid',
+                        'FN' => 'User2 @ Localhost',
+                        'CLOUD' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid',
+                        'FN' => 'User @ Localhost',
+                        'CLOUD' => [
+                            'username@localhost',
+                        ],
+                    ],
+                ],
+                false,
+                ['remotes' => [], 'exact' => ['remotes' => [['label' => 'test (remote)', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'test@remote', 'server' => 'remote'], 'uuid' => 'test', 'name' => 'test']]]],
+                false,
+                true,
+            ],
+            [
+                'username@localhost',
+                [
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => '2',
+                        'FN' => 'User2 @ Localhost',
+                        'CLOUD' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User @ Localhost',
+                        'CLOUD' => [
+                            'username@localhost',
+                        ],
+                    ],
+                ],
+                true,
+                ['remotes' => [], 'exact' => ['remotes' => [['name' => 'User @ Localhost', 'label' => 'User @ Localhost (username@localhost)', 'uuid' => 'uid1', 'type' => '', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]]]],
+                true,
+                true,
+            ],
+            [
+                'username@localhost',
+                [
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2 @ Localhost',
+                        'CLOUD' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User @ Localhost',
+                        'CLOUD' => [
+                            'username@localhost',
+                        ],
+                    ],
+                ],
+                false,
+                ['remotes' => [], 'exact' => ['remotes' => [['name' => 'User @ Localhost', 'label' => 'User @ Localhost (username@localhost)', 'uuid' => 'uid1', 'type' => '', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]]]],
+                true,
+                true,
+            ],
+            // contact with space
+            [
+                'user name@localhost',
+                [
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2 @ Localhost',
+                        'CLOUD' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User Name @ Localhost',
+                        'CLOUD' => [
+                            'user name@localhost',
+                        ],
+                    ],
+                ],
+                false,
+                ['remotes' => [], 'exact' => ['remotes' => [['name' => 'User Name @ Localhost', 'label' => 'User Name @ Localhost (user name@localhost)', 'uuid' => 'uid3', 'type' => '', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'user name@localhost', 'server' => 'localhost']]]]],
+                true,
+                true,
+            ],
+            // remote with space, no contact
+            [
+                'user space@remote',
+                [
+                    [
+                        'UID' => 'uid3',
+                        'FN' => 'User3 @ Localhost',
+                    ],
+                    [
+                        'UID' => 'uid2',
+                        'FN' => 'User2 @ Localhost',
+                        'CLOUD' => [
+                        ],
+                    ],
+                    [
+                        'UID' => 'uid1',
+                        'FN' => 'User @ Localhost',
+                        'CLOUD' => [
+                            'username@localhost',
+                        ],
+                    ],
+                ],
+                false,
+                ['remotes' => [], 'exact' => ['remotes' => [['label' => 'user space (remote)', 'value' => ['shareType' => IShare::TYPE_REMOTE, 'shareWith' => 'user space@remote', 'server' => 'remote'], 'uuid' => 'user space', 'name' => 'user space']]]],
+                false,
+                true,
+            ],
+        ];
+    }
 
-	public static function dataTestSplitUserRemote(): array {
-		$userPrefix = ['user@name', 'username'];
-		$protocols = ['', 'http://', 'https://'];
-		$remotes = [
-			'localhost',
-			'local.host',
-			'dev.local.host',
-			'dev.local.host/path',
-			'dev.local.host/at@inpath',
-			'127.0.0.1',
-			'::1',
-			'::192.0.2.128',
-			'::192.0.2.128/at@inpath',
-		];
+    public static function dataTestSplitUserRemote(): array {
+        $userPrefix = ['user@name', 'username'];
+        $protocols = ['', 'http://', 'https://'];
+        $remotes = [
+            'localhost',
+            'local.host',
+            'dev.local.host',
+            'dev.local.host/path',
+            'dev.local.host/at@inpath',
+            '127.0.0.1',
+            '::1',
+            '::192.0.2.128',
+            '::192.0.2.128/at@inpath',
+        ];
 
-		$testCases = [];
-		foreach ($userPrefix as $user) {
-			foreach ($remotes as $remote) {
-				foreach ($protocols as $protocol) {
-					$baseUrl = $user . '@' . $protocol . $remote;
+        $testCases = [];
+        foreach ($userPrefix as $user) {
+            foreach ($remotes as $remote) {
+                foreach ($protocols as $protocol) {
+                    $baseUrl = $user . '@' . $protocol . $remote;
 
-					if ($protocol === 'https://') {
-						// https:// protocol is not expected in the final result
-						$protocol = '';
-					}
+                    if ($protocol === 'https://') {
+                        // https:// protocol is not expected in the final result
+                        $protocol = '';
+                    }
 
-					$testCases[] = [$baseUrl, $user, $protocol . $remote];
-					$testCases[] = [$baseUrl . '/', $user, $protocol . $remote];
-					$testCases[] = [$baseUrl . '/index.php', $user, $protocol . $remote];
-					$testCases[] = [$baseUrl . '/index.php/s/token', $user, $protocol . $remote];
-				}
-			}
-		}
-		return $testCases;
-	}
+                    $testCases[] = [$baseUrl, $user, $protocol . $remote];
+                    $testCases[] = [$baseUrl . '/', $user, $protocol . $remote];
+                    $testCases[] = [$baseUrl . '/index.php', $user, $protocol . $remote];
+                    $testCases[] = [$baseUrl . '/index.php/s/token', $user, $protocol . $remote];
+                }
+            }
+        }
+        return $testCases;
+    }
 
-	public static function dataTestSplitUserRemoteError(): array {
-		return [
-			// Invalid path
-			['user@'],
+    public static function dataTestSplitUserRemoteError(): array {
+        return [
+            // Invalid path
+            ['user@'],
 
-			// Invalid user
-			['@server'],
-			['us/er@server'],
-			['us:er@server'],
+            // Invalid user
+            ['@server'],
+            ['us/er@server'],
+            ['us:er@server'],
 
-			// Invalid splitting
-			['user'],
-			[''],
-			['us/erserver'],
-			['us:erserver'],
-		];
-	}
+            // Invalid splitting
+            ['user'],
+            [''],
+            ['us/erserver'],
+            ['us:erserver'],
+        ];
+    }
 }

tests/lib/Command/Integrity/SignCoreTest.php

Indentation +193 added lines, -193 removed lines

@@ -15,197 +15,197 @@
 use Test\TestCase;
 
 class SignCoreTest extends TestCase {
-	/** @var Checker|\PHPUnit\Framework\MockObject\MockObject */
-	private $checker;
-	/** @var FileAccessHelper|\PHPUnit\Framework\MockObject\MockObject */
-	private $fileAccessHelper;
-	/** @var SignCore */
-	private $signCore;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->checker = $this->createMock(Checker::class);
-		$this->fileAccessHelper = $this->createMock(FileAccessHelper::class);
-		$this->signCore = new SignCore(
-			$this->checker,
-			$this->fileAccessHelper
-		);
-	}
-
-	public function testExecuteWithMissingPrivateKey(): void {
-		$inputInterface = $this->createMock(InputInterface::class);
-		$outputInterface = $this->createMock(OutputInterface::class);
-
-		$inputInterface
-			->expects($this->exactly(3))
-			->method('getOption')
-			->willReturnMap([
-				['privateKey', null],
-				['certificate', 'certificate'],
-				['path', 'certificate'],
-			]);
-
-		$outputInterface
-			->expects($this->any())
-			->method('writeln')
-			->willReturnCallback(function (string $message) {
-				$this->assertEquals('--privateKey, --certificate and --path are required.', $message);
-			});
-
-		$this->assertSame(1, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
-	}
-
-	public function testExecuteWithMissingCertificate(): void {
-		$inputInterface = $this->createMock(InputInterface::class);
-		$outputInterface = $this->createMock(OutputInterface::class);
-
-		$inputInterface
-			->expects($this->exactly(3))
-			->method('getOption')
-			->willReturnMap([
-				['privateKey', 'privateKey'],
-				['certificate', null],
-				['path', 'certificate'],
-			]);
-
-		$outputInterface
-			->expects($this->any())
-			->method('writeln')
-			->willReturnCallback(function (string $message) {
-				$this->assertEquals('--privateKey, --certificate and --path are required.', $message);
-			});
-
-		$this->assertSame(1, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
-	}
-
-	public function testExecuteWithNotExistingPrivateKey(): void {
-		$inputInterface = $this->createMock(InputInterface::class);
-		$outputInterface = $this->createMock(OutputInterface::class);
-
-		$inputInterface
-			->expects($this->exactly(3))
-			->method('getOption')
-			->willReturnMap([
-				['privateKey', 'privateKey'],
-				['certificate', 'certificate'],
-				['path', 'certificate'],
-			]);
-
-		$this->fileAccessHelper
-			->method('file_get_contents')
-			->willReturnMap([
-				['privateKey', false],
-			]);
-
-		$outputInterface
-			->expects($this->any())
-			->method('writeln')
-			->willReturnCallback(function (string $message) {
-				$this->assertEquals('Private key "privateKey" does not exists.', $message);
-			});
-
-		$this->assertSame(1, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
-	}
-
-	public function testExecuteWithNotExistingCertificate(): void {
-		$inputInterface = $this->createMock(InputInterface::class);
-		$outputInterface = $this->createMock(OutputInterface::class);
-
-		$inputInterface
-			->expects($this->exactly(3))
-			->method('getOption')
-			->willReturnMap([
-				['privateKey', 'privateKey'],
-				['certificate', 'certificate'],
-				['path', 'certificate'],
-			]);
-
-		$this->fileAccessHelper
-			->expects($this->any())
-			->method('file_get_contents')
-			->willReturnMap([
-				['privateKey', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.key')],
-				['certificate', false],
-			]);
-
-		$outputInterface
-			->expects($this->any())
-			->method('writeln')
-			->willReturnCallback(function (string $message) {
-				$this->assertEquals('Certificate "certificate" does not exists.', $message);
-			});
-
-		$this->assertSame(1, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
-	}
-
-	public function testExecuteWithException(): void {
-		$inputInterface = $this->createMock(InputInterface::class);
-		$outputInterface = $this->createMock(OutputInterface::class);
-
-		$inputInterface
-			->expects($this->exactly(3))
-			->method('getOption')
-			->willReturnMap([
-				['privateKey', 'privateKey'],
-				['certificate', 'certificate'],
-				['path', 'certificate'],
-			]);
-
-		$this->fileAccessHelper
-			->expects($this->any())
-			->method('file_get_contents')
-			->willReturnMap([
-				['privateKey', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.key')],
-				['certificate', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.crt')],
-			]);
-
-		$this->checker
-			->expects($this->once())
-			->method('writeCoreSignature')
-			->willThrowException(new \Exception('My exception message'));
-
-		$outputInterface
-			->expects($this->any())
-			->method('writeln')
-			->willReturnCallback(function (string $message) {
-				$this->assertEquals('Error: My exception message', $message);
-			});
-
-		$this->assertEquals(1, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
-	}
-
-	public function testExecute(): void {
-		$inputInterface = $this->createMock(InputInterface::class);
-		$outputInterface = $this->createMock(OutputInterface::class);
-
-		$inputInterface
-			->expects($this->exactly(3))
-			->method('getOption')
-			->willReturnMap([
-				['privateKey', 'privateKey'],
-				['certificate', 'certificate'],
-				['path', 'certificate'],
-			]);
-
-		$this->fileAccessHelper
-			->expects($this->any())
-			->method('file_get_contents')
-			->willReturnMap([
-				['privateKey', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.key')],
-				['certificate', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.crt')],
-			]);
-
-		$this->checker
-			->expects($this->once())
-			->method('writeCoreSignature');
-
-		$outputInterface
-			->expects($this->any())
-			->method('writeln')
-			->willReturnCallback(function (string $message) {
-				$this->assertEquals('Successfully signed "core"', $message);
-			});
-
-		$this->assertEquals(0, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
-	}
+    /** @var Checker|\PHPUnit\Framework\MockObject\MockObject */
+    private $checker;
+    /** @var FileAccessHelper|\PHPUnit\Framework\MockObject\MockObject */
+    private $fileAccessHelper;
+    /** @var SignCore */
+    private $signCore;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->checker = $this->createMock(Checker::class);
+        $this->fileAccessHelper = $this->createMock(FileAccessHelper::class);
+        $this->signCore = new SignCore(
+            $this->checker,
+            $this->fileAccessHelper
+        );
+    }
+
+    public function testExecuteWithMissingPrivateKey(): void {
+        $inputInterface = $this->createMock(InputInterface::class);
+        $outputInterface = $this->createMock(OutputInterface::class);
+
+        $inputInterface
+            ->expects($this->exactly(3))
+            ->method('getOption')
+            ->willReturnMap([
+                ['privateKey', null],
+                ['certificate', 'certificate'],
+                ['path', 'certificate'],
+            ]);
+
+        $outputInterface
+            ->expects($this->any())
+            ->method('writeln')
+            ->willReturnCallback(function (string $message) {
+                $this->assertEquals('--privateKey, --certificate and --path are required.', $message);
+            });
+
+        $this->assertSame(1, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
+    }
+
+    public function testExecuteWithMissingCertificate(): void {
+        $inputInterface = $this->createMock(InputInterface::class);
+        $outputInterface = $this->createMock(OutputInterface::class);
+
+        $inputInterface
+            ->expects($this->exactly(3))
+            ->method('getOption')
+            ->willReturnMap([
+                ['privateKey', 'privateKey'],
+                ['certificate', null],
+                ['path', 'certificate'],
+            ]);
+
+        $outputInterface
+            ->expects($this->any())
+            ->method('writeln')
+            ->willReturnCallback(function (string $message) {
+                $this->assertEquals('--privateKey, --certificate and --path are required.', $message);
+            });
+
+        $this->assertSame(1, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
+    }
+
+    public function testExecuteWithNotExistingPrivateKey(): void {
+        $inputInterface = $this->createMock(InputInterface::class);
+        $outputInterface = $this->createMock(OutputInterface::class);
+
+        $inputInterface
+            ->expects($this->exactly(3))
+            ->method('getOption')
+            ->willReturnMap([
+                ['privateKey', 'privateKey'],
+                ['certificate', 'certificate'],
+                ['path', 'certificate'],
+            ]);
+
+        $this->fileAccessHelper
+            ->method('file_get_contents')
+            ->willReturnMap([
+                ['privateKey', false],
+            ]);
+
+        $outputInterface
+            ->expects($this->any())
+            ->method('writeln')
+            ->willReturnCallback(function (string $message) {
+                $this->assertEquals('Private key "privateKey" does not exists.', $message);
+            });
+
+        $this->assertSame(1, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
+    }
+
+    public function testExecuteWithNotExistingCertificate(): void {
+        $inputInterface = $this->createMock(InputInterface::class);
+        $outputInterface = $this->createMock(OutputInterface::class);
+
+        $inputInterface
+            ->expects($this->exactly(3))
+            ->method('getOption')
+            ->willReturnMap([
+                ['privateKey', 'privateKey'],
+                ['certificate', 'certificate'],
+                ['path', 'certificate'],
+            ]);
+
+        $this->fileAccessHelper
+            ->expects($this->any())
+            ->method('file_get_contents')
+            ->willReturnMap([
+                ['privateKey', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.key')],
+                ['certificate', false],
+            ]);
+
+        $outputInterface
+            ->expects($this->any())
+            ->method('writeln')
+            ->willReturnCallback(function (string $message) {
+                $this->assertEquals('Certificate "certificate" does not exists.', $message);
+            });
+
+        $this->assertSame(1, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
+    }
+
+    public function testExecuteWithException(): void {
+        $inputInterface = $this->createMock(InputInterface::class);
+        $outputInterface = $this->createMock(OutputInterface::class);
+
+        $inputInterface
+            ->expects($this->exactly(3))
+            ->method('getOption')
+            ->willReturnMap([
+                ['privateKey', 'privateKey'],
+                ['certificate', 'certificate'],
+                ['path', 'certificate'],
+            ]);
+
+        $this->fileAccessHelper
+            ->expects($this->any())
+            ->method('file_get_contents')
+            ->willReturnMap([
+                ['privateKey', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.key')],
+                ['certificate', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.crt')],
+            ]);
+
+        $this->checker
+            ->expects($this->once())
+            ->method('writeCoreSignature')
+            ->willThrowException(new \Exception('My exception message'));
+
+        $outputInterface
+            ->expects($this->any())
+            ->method('writeln')
+            ->willReturnCallback(function (string $message) {
+                $this->assertEquals('Error: My exception message', $message);
+            });
+
+        $this->assertEquals(1, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
+    }
+
+    public function testExecute(): void {
+        $inputInterface = $this->createMock(InputInterface::class);
+        $outputInterface = $this->createMock(OutputInterface::class);
+
+        $inputInterface
+            ->expects($this->exactly(3))
+            ->method('getOption')
+            ->willReturnMap([
+                ['privateKey', 'privateKey'],
+                ['certificate', 'certificate'],
+                ['path', 'certificate'],
+            ]);
+
+        $this->fileAccessHelper
+            ->expects($this->any())
+            ->method('file_get_contents')
+            ->willReturnMap([
+                ['privateKey', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.key')],
+                ['certificate', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.crt')],
+            ]);
+
+        $this->checker
+            ->expects($this->once())
+            ->method('writeCoreSignature');
+
+        $outputInterface
+            ->expects($this->any())
+            ->method('writeln')
+            ->willReturnCallback(function (string $message) {
+                $this->assertEquals('Successfully signed "core"', $message);
+            });
+
+        $this->assertEquals(0, self::invokePrivate($this->signCore, 'execute', [$inputInterface, $outputInterface]));
+    }
 }

Spacing +11 added lines, -11 removed lines

@@ -48,7 +48,7 @@ 
 		$outputInterface
 			->expects($this->any())
 			->method('writeln')
-			->willReturnCallback(function (string $message) {
+			->willReturnCallback(function(string $message) {
 				$this->assertEquals('--privateKey, --certificate and --path are required.', $message);
 			});
 
@@ -71,7 +71,7 @@ 
 		$outputInterface
 			->expects($this->any())
 			->method('writeln')
-			->willReturnCallback(function (string $message) {
+			->willReturnCallback(function(string $message) {
 				$this->assertEquals('--privateKey, --certificate and --path are required.', $message);
 			});
 
@@ -100,7 +100,7 @@ 
 		$outputInterface
 			->expects($this->any())
 			->method('writeln')
-			->willReturnCallback(function (string $message) {
+			->willReturnCallback(function(string $message) {
 				$this->assertEquals('Private key "privateKey" does not exists.', $message);
 			});
 
@@ -124,14 +124,14 @@ 
 			->expects($this->any())
 			->method('file_get_contents')
 			->willReturnMap([
-				['privateKey', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.key')],
+				['privateKey', file_get_contents(\OC::$SERVERROOT.'/tests/data/integritycheck/core.key')],
 				['certificate', false],
 			]);
 
 		$outputInterface
 			->expects($this->any())
 			->method('writeln')
-			->willReturnCallback(function (string $message) {
+			->willReturnCallback(function(string $message) {
 				$this->assertEquals('Certificate "certificate" does not exists.', $message);
 			});
 
@@ -155,8 +155,8 @@ 
 			->expects($this->any())
 			->method('file_get_contents')
 			->willReturnMap([
-				['privateKey', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.key')],
-				['certificate', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.crt')],
+				['privateKey', file_get_contents(\OC::$SERVERROOT.'/tests/data/integritycheck/core.key')],
+				['certificate', file_get_contents(\OC::$SERVERROOT.'/tests/data/integritycheck/core.crt')],
 			]);
 
 		$this->checker
@@ -167,7 +167,7 @@ 
 		$outputInterface
 			->expects($this->any())
 			->method('writeln')
-			->willReturnCallback(function (string $message) {
+			->willReturnCallback(function(string $message) {
 				$this->assertEquals('Error: My exception message', $message);
 			});
 
@@ -191,8 +191,8 @@ 
 			->expects($this->any())
 			->method('file_get_contents')
 			->willReturnMap([
-				['privateKey', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.key')],
-				['certificate', file_get_contents(\OC::$SERVERROOT . '/tests/data/integritycheck/core.crt')],
+				['privateKey', file_get_contents(\OC::$SERVERROOT.'/tests/data/integritycheck/core.key')],
+				['certificate', file_get_contents(\OC::$SERVERROOT.'/tests/data/integritycheck/core.crt')],
 			]);
 
 		$this->checker
@@ -202,7 +202,7 @@ 
 		$outputInterface
 			->expects($this->any())
 			->method('writeln')
-			->willReturnCallback(function (string $message) {
+			->willReturnCallback(function(string $message) {
 				$this->assertEquals('Successfully signed "core"', $message);
 			});