nextcloud / server

apps/twofactor_backupcodes/tests/Unit/Service/BackupCodeStorageTest.php

Indentation +197 added lines, -197 removed lines

@@ -20,201 +20,201 @@
 use Test\TestCase;
 
 class BackupCodeStorageTest extends TestCase {
-	private BackupCodeMapper&MockObject $mapper;
-	private ISecureRandom&MockObject $random;
-	private IHasher&MockObject $hasher;
-	private IEventDispatcher&MockObject $eventDispatcher;
-	private BackupCodeStorage $storage;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->mapper = $this->createMock(BackupCodeMapper::class);
-		$this->random = $this->createMock(ISecureRandom::class);
-		$this->hasher = $this->createMock(IHasher::class);
-		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
-
-		$this->storage = new BackupCodeStorage($this->mapper, $this->random, $this->hasher, $this->eventDispatcher);
-	}
-
-	public function testCreateCodes(): void {
-		$user = $this->createMock(IUser::class);
-		$number = 5;
-		$user->method('getUID')->willReturn('fritz');
-		$this->random->expects($this->exactly($number))
-			->method('generate')
-			->with(16, ISecureRandom::CHAR_HUMAN_READABLE)
-			->willReturn('CODEABCDEF');
-		$this->hasher->expects($this->exactly($number))
-			->method('hash')
-			->with('CODEABCDEF')
-			->willReturn('HASHEDCODE');
-		$row = new BackupCode();
-		$row->setUserId('fritz');
-		$row->setCode('HASHEDCODE');
-		$row->setUsed(0);
-		$this->mapper->expects($this->exactly($number))
-			->method('insert')
-			->with($this->equalTo($row));
-		$this->eventDispatcher->expects($this->once())
-			->method('dispatchTyped')
-			->with(
-				$this->equalTo(new CodesGenerated($user))
-			);
-
-		$codes = $this->storage->createCodes($user, $number);
-		$this->assertCount($number, $codes);
-		foreach ($codes as $code) {
-			$this->assertEquals('CODEABCDEF', $code);
-		}
-	}
-
-	public function testHasBackupCodes(): void {
-		$user = $this->createMock(IUser::class);
-		$codes = [
-			new BackupCode(),
-			new BackupCode(),
-		];
-
-		$this->mapper->expects($this->once())
-			->method('getBackupCodes')
-			->with($user)
-			->willReturn($codes);
-
-		$this->assertTrue($this->storage->hasBackupCodes($user));
-	}
-
-	public function testHasBackupCodesNoCodes(): void {
-		$user = $this->createMock(IUser::class);
-		$codes = [];
-
-		$this->mapper->expects($this->once())
-			->method('getBackupCodes')
-			->with($user)
-			->willReturn($codes);
-
-		$this->assertFalse($this->storage->hasBackupCodes($user));
-	}
-
-	public function testGetBackupCodeState(): void {
-		$user = $this->createMock(IUser::class);
-
-		$code1 = new BackupCode();
-		$code1->setUsed(1);
-		$code2 = new BackupCode();
-		$code2->setUsed('0');
-		$codes = [
-			$code1,
-			$code2,
-		];
-
-		$this->mapper->expects($this->once())
-			->method('getBackupCodes')
-			->with($user)
-			->willReturn($codes);
-
-		$expected = [
-			'enabled' => true,
-			'total' => 2,
-			'used' => 1,
-		];
-		$this->assertEquals($expected, $this->storage->getBackupCodesState($user));
-	}
-
-	public function testGetBackupCodeDisabled(): void {
-		$user = $this->createMock(IUser::class);
-
-		$codes = [];
-
-		$this->mapper->expects($this->once())
-			->method('getBackupCodes')
-			->with($user)
-			->willReturn($codes);
-
-		$expected = [
-			'enabled' => false,
-			'total' => 0,
-			'used' => 0,
-		];
-		$this->assertEquals($expected, $this->storage->getBackupCodesState($user));
-	}
-
-	public function testValidateCode(): void {
-		$user = $this->createMock(IUser::class);
-		$code = new BackupCode();
-		$code->setUsed(0);
-		$code->setCode('HASHEDVALUE');
-		$codes = [
-			$code,
-		];
-
-		$this->mapper->expects($this->once())
-			->method('getBackupCodes')
-			->with($user)
-			->willReturn($codes);
-		$this->hasher->expects($this->once())
-			->method('verify')
-			->with('CHALLENGE', 'HASHEDVALUE', $this->anything())
-			->willReturn(true);
-		$this->mapper->expects($this->once())
-			->method('update')
-			->with($code);
-
-		$this->assertTrue($this->storage->validateCode($user, 'CHALLENGE'));
-
-		$this->assertEquals(1, $code->getUsed());
-	}
-
-	public function testValidateUsedCode(): void {
-		$user = $this->createMock(IUser::class);
-		$code = new BackupCode();
-		$code->setUsed('1');
-		$code->setCode('HASHEDVALUE');
-		$codes = [
-			$code,
-		];
-
-		$this->mapper->expects($this->once())
-			->method('getBackupCodes')
-			->with($user)
-			->willReturn($codes);
-		$this->hasher->expects($this->never())
-			->method('verify');
-		$this->mapper->expects($this->never())
-			->method('update');
-
-		$this->assertFalse($this->storage->validateCode($user, 'CHALLENGE'));
-	}
-
-	public function testValidateCodeWithWrongHash(): void {
-		$user = $this->createMock(IUser::class);
-		$code = new BackupCode();
-		$code->setUsed(0);
-		$code->setCode('HASHEDVALUE');
-		$codes = [
-			$code,
-		];
-
-		$this->mapper->expects($this->once())
-			->method('getBackupCodes')
-			->with($user)
-			->willReturn($codes);
-		$this->hasher->expects($this->once())
-			->method('verify')
-			->with('CHALLENGE', 'HASHEDVALUE')
-			->willReturn(false);
-		$this->mapper->expects($this->never())
-			->method('update');
-
-		$this->assertFalse($this->storage->validateCode($user, 'CHALLENGE'));
-	}
-
-	public function testDeleteCodes(): void {
-		$user = $this->createMock(IUser::class);
-		$this->mapper->expects($this->once())
-			->method('deleteCodes')
-			->with($user);
-
-		$this->storage->deleteCodes($user);
-	}
+    private BackupCodeMapper&MockObject $mapper;
+    private ISecureRandom&MockObject $random;
+    private IHasher&MockObject $hasher;
+    private IEventDispatcher&MockObject $eventDispatcher;
+    private BackupCodeStorage $storage;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->mapper = $this->createMock(BackupCodeMapper::class);
+        $this->random = $this->createMock(ISecureRandom::class);
+        $this->hasher = $this->createMock(IHasher::class);
+        $this->eventDispatcher = $this->createMock(IEventDispatcher::class);
+
+        $this->storage = new BackupCodeStorage($this->mapper, $this->random, $this->hasher, $this->eventDispatcher);
+    }
+
+    public function testCreateCodes(): void {
+        $user = $this->createMock(IUser::class);
+        $number = 5;
+        $user->method('getUID')->willReturn('fritz');
+        $this->random->expects($this->exactly($number))
+            ->method('generate')
+            ->with(16, ISecureRandom::CHAR_HUMAN_READABLE)
+            ->willReturn('CODEABCDEF');
+        $this->hasher->expects($this->exactly($number))
+            ->method('hash')
+            ->with('CODEABCDEF')
+            ->willReturn('HASHEDCODE');
+        $row = new BackupCode();
+        $row->setUserId('fritz');
+        $row->setCode('HASHEDCODE');
+        $row->setUsed(0);
+        $this->mapper->expects($this->exactly($number))
+            ->method('insert')
+            ->with($this->equalTo($row));
+        $this->eventDispatcher->expects($this->once())
+            ->method('dispatchTyped')
+            ->with(
+                $this->equalTo(new CodesGenerated($user))
+            );
+
+        $codes = $this->storage->createCodes($user, $number);
+        $this->assertCount($number, $codes);
+        foreach ($codes as $code) {
+            $this->assertEquals('CODEABCDEF', $code);
+        }
+    }
+
+    public function testHasBackupCodes(): void {
+        $user = $this->createMock(IUser::class);
+        $codes = [
+            new BackupCode(),
+            new BackupCode(),
+        ];
+
+        $this->mapper->expects($this->once())
+            ->method('getBackupCodes')
+            ->with($user)
+            ->willReturn($codes);
+
+        $this->assertTrue($this->storage->hasBackupCodes($user));
+    }
+
+    public function testHasBackupCodesNoCodes(): void {
+        $user = $this->createMock(IUser::class);
+        $codes = [];
+
+        $this->mapper->expects($this->once())
+            ->method('getBackupCodes')
+            ->with($user)
+            ->willReturn($codes);
+
+        $this->assertFalse($this->storage->hasBackupCodes($user));
+    }
+
+    public function testGetBackupCodeState(): void {
+        $user = $this->createMock(IUser::class);
+
+        $code1 = new BackupCode();
+        $code1->setUsed(1);
+        $code2 = new BackupCode();
+        $code2->setUsed('0');
+        $codes = [
+            $code1,
+            $code2,
+        ];
+
+        $this->mapper->expects($this->once())
+            ->method('getBackupCodes')
+            ->with($user)
+            ->willReturn($codes);
+
+        $expected = [
+            'enabled' => true,
+            'total' => 2,
+            'used' => 1,
+        ];
+        $this->assertEquals($expected, $this->storage->getBackupCodesState($user));
+    }
+
+    public function testGetBackupCodeDisabled(): void {
+        $user = $this->createMock(IUser::class);
+
+        $codes = [];
+
+        $this->mapper->expects($this->once())
+            ->method('getBackupCodes')
+            ->with($user)
+            ->willReturn($codes);
+
+        $expected = [
+            'enabled' => false,
+            'total' => 0,
+            'used' => 0,
+        ];
+        $this->assertEquals($expected, $this->storage->getBackupCodesState($user));
+    }
+
+    public function testValidateCode(): void {
+        $user = $this->createMock(IUser::class);
+        $code = new BackupCode();
+        $code->setUsed(0);
+        $code->setCode('HASHEDVALUE');
+        $codes = [
+            $code,
+        ];
+
+        $this->mapper->expects($this->once())
+            ->method('getBackupCodes')
+            ->with($user)
+            ->willReturn($codes);
+        $this->hasher->expects($this->once())
+            ->method('verify')
+            ->with('CHALLENGE', 'HASHEDVALUE', $this->anything())
+            ->willReturn(true);
+        $this->mapper->expects($this->once())
+            ->method('update')
+            ->with($code);
+
+        $this->assertTrue($this->storage->validateCode($user, 'CHALLENGE'));
+
+        $this->assertEquals(1, $code->getUsed());
+    }
+
+    public function testValidateUsedCode(): void {
+        $user = $this->createMock(IUser::class);
+        $code = new BackupCode();
+        $code->setUsed('1');
+        $code->setCode('HASHEDVALUE');
+        $codes = [
+            $code,
+        ];
+
+        $this->mapper->expects($this->once())
+            ->method('getBackupCodes')
+            ->with($user)
+            ->willReturn($codes);
+        $this->hasher->expects($this->never())
+            ->method('verify');
+        $this->mapper->expects($this->never())
+            ->method('update');
+
+        $this->assertFalse($this->storage->validateCode($user, 'CHALLENGE'));
+    }
+
+    public function testValidateCodeWithWrongHash(): void {
+        $user = $this->createMock(IUser::class);
+        $code = new BackupCode();
+        $code->setUsed(0);
+        $code->setCode('HASHEDVALUE');
+        $codes = [
+            $code,
+        ];
+
+        $this->mapper->expects($this->once())
+            ->method('getBackupCodes')
+            ->with($user)
+            ->willReturn($codes);
+        $this->hasher->expects($this->once())
+            ->method('verify')
+            ->with('CHALLENGE', 'HASHEDVALUE')
+            ->willReturn(false);
+        $this->mapper->expects($this->never())
+            ->method('update');
+
+        $this->assertFalse($this->storage->validateCode($user, 'CHALLENGE'));
+    }
+
+    public function testDeleteCodes(): void {
+        $user = $this->createMock(IUser::class);
+        $this->mapper->expects($this->once())
+            ->method('deleteCodes')
+            ->with($user);
+
+        $this->storage->deleteCodes($user);
+    }
 }

apps/twofactor_backupcodes/tests/Unit/Migration/CheckBackupCodeTest.php

Indentation +18 added lines, -18 removed lines

@@ -15,27 +15,27 @@
 use Test\TestCase;
 
 class CheckBackupCodeTest extends TestCase {
-	private IJobList&MockObject $jobList;
-	private CheckBackupCodes $checkBackupsCodes;
+    private IJobList&MockObject $jobList;
+    private CheckBackupCodes $checkBackupsCodes;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->jobList = $this->createMock(IJobList::class);
-		$this->checkBackupsCodes = new CheckBackupCodes($this->jobList);
-	}
+        $this->jobList = $this->createMock(IJobList::class);
+        $this->checkBackupsCodes = new CheckBackupCodes($this->jobList);
+    }
 
-	public function testGetName(): void {
-		$this->assertSame('Add background job to check for backup codes', $this->checkBackupsCodes->getName());
-	}
+    public function testGetName(): void {
+        $this->assertSame('Add background job to check for backup codes', $this->checkBackupsCodes->getName());
+    }
 
-	public function testRun(): void {
-		$this->jobList->expects($this->once())
-			->method('add')
-			->with(
-				$this->equalTo(\OCA\TwoFactorBackupCodes\BackgroundJob\CheckBackupCodes::class)
-			);
+    public function testRun(): void {
+        $this->jobList->expects($this->once())
+            ->method('add')
+            ->with(
+                $this->equalTo(\OCA\TwoFactorBackupCodes\BackgroundJob\CheckBackupCodes::class)
+            );
 
-		$this->checkBackupsCodes->run($this->createMock(IOutput::class));
-	}
+        $this->checkBackupsCodes->run($this->createMock(IOutput::class));
+    }
 }

apps/twofactor_backupcodes/tests/Unit/Listener/ActivityPublisherTest.php

Indentation +43 added lines, -43 removed lines

@@ -19,54 +19,54 @@
 use Test\TestCase;
 
 class ActivityPublisherTest extends TestCase {
-	private IManager&MockObject $activityManager;
-	private LoggerInterface&MockObject $logger;
-	private ActivityPublisher $listener;
+    private IManager&MockObject $activityManager;
+    private LoggerInterface&MockObject $logger;
+    private ActivityPublisher $listener;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->activityManager = $this->createMock(IManager::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
+        $this->activityManager = $this->createMock(IManager::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
 
-		$this->listener = new ActivityPublisher($this->activityManager, $this->logger);
-	}
+        $this->listener = new ActivityPublisher($this->activityManager, $this->logger);
+    }
 
-	public function testHandleGenericEvent(): void {
-		$event = $this->createMock(Event::class);
-		$this->activityManager->expects($this->never())
-			->method('publish');
+    public function testHandleGenericEvent(): void {
+        $event = $this->createMock(Event::class);
+        $this->activityManager->expects($this->never())
+            ->method('publish');
 
-		$this->listener->handle($event);
-	}
+        $this->listener->handle($event);
+    }
 
-	public function testHandleCodesGeneratedEvent(): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')->willReturn('fritz');
-		$event = new CodesGenerated($user);
-		$activityEvent = $this->createMock(IEvent::class);
-		$this->activityManager->expects($this->once())
-			->method('generateEvent')
-			->willReturn($activityEvent);
-		$activityEvent->expects($this->once())
-			->method('setApp')
-			->with('twofactor_backupcodes')
-			->willReturnSelf();
-		$activityEvent->expects($this->once())
-			->method('setType')
-			->with('security')
-			->willReturnSelf();
-		$activityEvent->expects($this->once())
-			->method('setAuthor')
-			->with('fritz')
-			->willReturnSelf();
-		$activityEvent->expects($this->once())
-			->method('setAffectedUser')
-			->with('fritz')
-			->willReturnSelf();
-		$this->activityManager->expects($this->once())
-			->method('publish');
+    public function testHandleCodesGeneratedEvent(): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')->willReturn('fritz');
+        $event = new CodesGenerated($user);
+        $activityEvent = $this->createMock(IEvent::class);
+        $this->activityManager->expects($this->once())
+            ->method('generateEvent')
+            ->willReturn($activityEvent);
+        $activityEvent->expects($this->once())
+            ->method('setApp')
+            ->with('twofactor_backupcodes')
+            ->willReturnSelf();
+        $activityEvent->expects($this->once())
+            ->method('setType')
+            ->with('security')
+            ->willReturnSelf();
+        $activityEvent->expects($this->once())
+            ->method('setAuthor')
+            ->with('fritz')
+            ->willReturnSelf();
+        $activityEvent->expects($this->once())
+            ->method('setAffectedUser')
+            ->with('fritz')
+            ->willReturnSelf();
+        $this->activityManager->expects($this->once())
+            ->method('publish');
 
-		$this->listener->handle($event);
-	}
+        $this->listener->handle($event);
+    }
 }

apps/twofactor_backupcodes/tests/Unit/Listener/ProviderDisabledTest.php

Indentation +66 added lines, -66 removed lines

@@ -19,70 +19,70 @@
 use Test\TestCase;
 
 class ProviderDisabledTest extends TestCase {
-	private IRegistry&MockObject $registy;
-	private IJobList&MockObject $jobList;
-	private ProviderDisabled $listener;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->registy = $this->createMock(IRegistry::class);
-		$this->jobList = $this->createMock(IJobList::class);
-
-		$this->listener = new ProviderDisabled($this->registy, $this->jobList);
-	}
-
-	public function testHandleGenericEvent(): void {
-		$event = $this->createMock(Event::class);
-		$this->jobList->expects($this->never())
-			->method($this->anything());
-
-		$this->listener->handle($event);
-	}
-
-	public function testHandleStillActiveProvider(): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('myUID');
-		$event = $this->createMock(TwoFactorProviderForUserUnregistered::class);
-		$event->method('getUser')
-			->willReturn($user);
-
-		$this->registy->method('getProviderStates')
-			->with($user)
-			->willReturn([
-				'backup_codes' => false,
-				'foo' => true,
-			]);
-
-		$this->jobList->expects($this->never())
-			->method($this->anything());
-
-		$this->listener->handle($event);
-	}
-
-	public function testHandleNoActiveProvider(): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('myUID');
-		$event = $this->createMock(TwoFactorProviderForUserUnregistered::class);
-		$event->method('getUser')
-			->willReturn($user);
-
-		$this->registy->method('getProviderStates')
-			->with($user)
-			->willReturn([
-				'backup_codes' => false,
-				'foo' => false,
-			]);
-
-		$this->jobList->expects($this->once())
-			->method('remove')
-			->with(
-				$this->equalTo(RememberBackupCodesJob::class),
-				$this->equalTo(['uid' => 'myUID'])
-			);
-
-		$this->listener->handle($event);
-	}
+    private IRegistry&MockObject $registy;
+    private IJobList&MockObject $jobList;
+    private ProviderDisabled $listener;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->registy = $this->createMock(IRegistry::class);
+        $this->jobList = $this->createMock(IJobList::class);
+
+        $this->listener = new ProviderDisabled($this->registy, $this->jobList);
+    }
+
+    public function testHandleGenericEvent(): void {
+        $event = $this->createMock(Event::class);
+        $this->jobList->expects($this->never())
+            ->method($this->anything());
+
+        $this->listener->handle($event);
+    }
+
+    public function testHandleStillActiveProvider(): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('myUID');
+        $event = $this->createMock(TwoFactorProviderForUserUnregistered::class);
+        $event->method('getUser')
+            ->willReturn($user);
+
+        $this->registy->method('getProviderStates')
+            ->with($user)
+            ->willReturn([
+                'backup_codes' => false,
+                'foo' => true,
+            ]);
+
+        $this->jobList->expects($this->never())
+            ->method($this->anything());
+
+        $this->listener->handle($event);
+    }
+
+    public function testHandleNoActiveProvider(): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('myUID');
+        $event = $this->createMock(TwoFactorProviderForUserUnregistered::class);
+        $event->method('getUser')
+            ->willReturn($user);
+
+        $this->registy->method('getProviderStates')
+            ->with($user)
+            ->willReturn([
+                'backup_codes' => false,
+                'foo' => false,
+            ]);
+
+        $this->jobList->expects($this->once())
+            ->method('remove')
+            ->with(
+                $this->equalTo(RememberBackupCodesJob::class),
+                $this->equalTo(['uid' => 'myUID'])
+            );
+
+        $this->listener->handle($event);
+    }
 }

apps/twofactor_backupcodes/tests/Unit/Listener/RegistryUpdaterTest.php

Indentation +33 added lines, -33 removed lines

@@ -18,37 +18,37 @@
 use Test\TestCase;
 
 class RegistryUpdaterTest extends TestCase {
-	private IRegistry&MockObject $registry;
-	private BackupCodesProvider&MockObject $provider;
-	private RegistryUpdater $listener;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->registry = $this->createMock(IRegistry::class);
-		$this->provider = $this->createMock(BackupCodesProvider::class);
-
-		$this->listener = new RegistryUpdater($this->registry, $this->provider);
-	}
-
-	public function testHandleGenericEvent(): void {
-		$event = $this->createMock(Event::class);
-		$this->registry->expects($this->never())
-			->method('enableProviderFor');
-
-		$this->listener->handle($event);
-	}
-
-	public function testHandleCodesGeneratedEvent(): void {
-		$user = $this->createMock(IUser::class);
-		$event = new CodesGenerated($user);
-		$this->registry->expects($this->once())
-			->method('enableProviderFor')
-			->with(
-				$this->provider,
-				$user
-			);
-
-		$this->listener->handle($event);
-	}
+    private IRegistry&MockObject $registry;
+    private BackupCodesProvider&MockObject $provider;
+    private RegistryUpdater $listener;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->registry = $this->createMock(IRegistry::class);
+        $this->provider = $this->createMock(BackupCodesProvider::class);
+
+        $this->listener = new RegistryUpdater($this->registry, $this->provider);
+    }
+
+    public function testHandleGenericEvent(): void {
+        $event = $this->createMock(Event::class);
+        $this->registry->expects($this->never())
+            ->method('enableProviderFor');
+
+        $this->listener->handle($event);
+    }
+
+    public function testHandleCodesGeneratedEvent(): void {
+        $user = $this->createMock(IUser::class);
+        $event = new CodesGenerated($user);
+        $this->registry->expects($this->once())
+            ->method('enableProviderFor')
+            ->with(
+                $this->provider,
+                $user
+            );
+
+        $this->listener->handle($event);
+    }
 }

apps/twofactor_backupcodes/tests/Unit/Listener/ProviderEnabledTest.php

Indentation +64 added lines, -64 removed lines

@@ -19,68 +19,68 @@
 use Test\TestCase;
 
 class ProviderEnabledTest extends TestCase {
-	private IRegistry&MockObject $registy;
-	private IJobList&MockObject $jobList;
-	private ProviderEnabled $listener;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->registy = $this->createMock(IRegistry::class);
-		$this->jobList = $this->createMock(IJobList::class);
-
-		$this->listener = new ProviderEnabled($this->registy, $this->jobList);
-	}
-
-	public function testHandleGenericEvent(): void {
-		$event = $this->createMock(Event::class);
-		$this->jobList->expects($this->never())
-			->method($this->anything());
-
-		$this->listener->handle($event);
-	}
-
-	public function testHandleCodesGeneratedEventAlraedyBackupcodes(): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('myUID');
-		$event = $this->createMock(TwoFactorProviderForUserRegistered::class);
-		$event->method('getUser')
-			->willReturn($user);
-
-		$this->registy->method('getProviderStates')
-			->with($user)
-			->willReturn([
-				'backup_codes' => true,
-			]);
-
-		$this->jobList->expects($this->never())
-			->method($this->anything());
-
-		$this->listener->handle($event);
-	}
-
-	public function testHandleCodesGeneratedEventNoBackupcodes(): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('myUID');
-		$event = $this->createMock(TwoFactorProviderForUserRegistered::class);
-		$event->method('getUser')
-			->willReturn($user);
-
-		$this->registy->method('getProviderStates')
-			->with($user)
-			->willReturn([
-				'backup_codes' => false,
-			]);
-
-		$this->jobList->expects($this->once())
-			->method('add')
-			->with(
-				$this->equalTo(RememberBackupCodesJob::class),
-				$this->equalTo(['uid' => 'myUID'])
-			);
-
-		$this->listener->handle($event);
-	}
+    private IRegistry&MockObject $registy;
+    private IJobList&MockObject $jobList;
+    private ProviderEnabled $listener;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->registy = $this->createMock(IRegistry::class);
+        $this->jobList = $this->createMock(IJobList::class);
+
+        $this->listener = new ProviderEnabled($this->registy, $this->jobList);
+    }
+
+    public function testHandleGenericEvent(): void {
+        $event = $this->createMock(Event::class);
+        $this->jobList->expects($this->never())
+            ->method($this->anything());
+
+        $this->listener->handle($event);
+    }
+
+    public function testHandleCodesGeneratedEventAlraedyBackupcodes(): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('myUID');
+        $event = $this->createMock(TwoFactorProviderForUserRegistered::class);
+        $event->method('getUser')
+            ->willReturn($user);
+
+        $this->registy->method('getProviderStates')
+            ->with($user)
+            ->willReturn([
+                'backup_codes' => true,
+            ]);
+
+        $this->jobList->expects($this->never())
+            ->method($this->anything());
+
+        $this->listener->handle($event);
+    }
+
+    public function testHandleCodesGeneratedEventNoBackupcodes(): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('myUID');
+        $event = $this->createMock(TwoFactorProviderForUserRegistered::class);
+        $event->method('getUser')
+            ->willReturn($user);
+
+        $this->registy->method('getProviderStates')
+            ->with($user)
+            ->willReturn([
+                'backup_codes' => false,
+            ]);
+
+        $this->jobList->expects($this->once())
+            ->method('add')
+            ->with(
+                $this->equalTo(RememberBackupCodesJob::class),
+                $this->equalTo(['uid' => 'myUID'])
+            );
+
+        $this->listener->handle($event);
+    }
 }

apps/twofactor_backupcodes/tests/Unit/Listener/ClearNotificationsTest.php

Indentation +37 added lines, -37 removed lines

@@ -19,41 +19,41 @@
 use Test\TestCase;
 
 class ClearNotificationsTest extends TestCase {
-	private IManager&MockObject $notificationManager;
-	private ClearNotifications $listener;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->notificationManager = $this->createMock(IManager::class);
-		$this->notificationManager->method('createNotification')
-			->willReturn(Server::get(IManager::class)->createNotification());
-
-		$this->listener = new ClearNotifications($this->notificationManager);
-	}
-
-	public function testHandleGenericEvent(): void {
-		$event = $this->createMock(Event::class);
-		$this->notificationManager->expects($this->never())
-			->method($this->anything());
-
-		$this->listener->handle($event);
-	}
-
-	public function testHandleCodesGeneratedEvent(): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')->willReturn('fritz');
-		$event = new CodesGenerated($user);
-
-		$this->notificationManager->expects($this->once())
-			->method('markProcessed')
-			->with($this->callback(function (INotification $n) {
-				return $n->getUser() === 'fritz' &&
-					$n->getApp() === 'twofactor_backupcodes' &&
-					$n->getObjectType() === 'create' &&
-					$n->getObjectId() === 'codes';
-			}));
-
-		$this->listener->handle($event);
-	}
+    private IManager&MockObject $notificationManager;
+    private ClearNotifications $listener;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->notificationManager = $this->createMock(IManager::class);
+        $this->notificationManager->method('createNotification')
+            ->willReturn(Server::get(IManager::class)->createNotification());
+
+        $this->listener = new ClearNotifications($this->notificationManager);
+    }
+
+    public function testHandleGenericEvent(): void {
+        $event = $this->createMock(Event::class);
+        $this->notificationManager->expects($this->never())
+            ->method($this->anything());
+
+        $this->listener->handle($event);
+    }
+
+    public function testHandleCodesGeneratedEvent(): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')->willReturn('fritz');
+        $event = new CodesGenerated($user);
+
+        $this->notificationManager->expects($this->once())
+            ->method('markProcessed')
+            ->with($this->callback(function (INotification $n) {
+                return $n->getUser() === 'fritz' &&
+                    $n->getApp() === 'twofactor_backupcodes' &&
+                    $n->getObjectType() === 'create' &&
+                    $n->getObjectId() === 'codes';
+            }));
+
+        $this->listener->handle($event);
+    }
 }

apps/twofactor_backupcodes/tests/Unit/Notification/NotifierTest.php

Indentation +94 added lines, -94 removed lines

@@ -17,98 +17,98 @@
 use Test\TestCase;
 
 class NotifierTest extends TestCase {
-	protected IFactory&MockObject $factory;
-	protected IURLGenerator&MockObject $url;
-	protected IL10N&MockObject $l;
-	protected Notifier $notifier;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->l = $this->createMock(IL10N::class);
-		$this->l->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($string, $args) {
-				return vsprintf($string, $args);
-			});
-		$this->factory = $this->createMock(IFactory::class);
-		$this->url = $this->createMock(IURLGenerator::class);
-		$this->factory->expects($this->any())
-			->method('get')
-			->willReturn($this->l);
-
-		$this->notifier = new Notifier(
-			$this->factory,
-			$this->url
-		);
-	}
-
-
-	public function testPrepareWrongApp(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		/** @var INotification|MockObject $notification */
-		$notification = $this->createMock(INotification::class);
-		$notification->expects($this->once())
-			->method('getApp')
-			->willReturn('notifications');
-		$notification->expects($this->never())
-			->method('getSubject');
-
-		$this->notifier->prepare($notification, 'en');
-	}
-
-
-	public function testPrepareWrongSubject(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		/** @var INotification|MockObject $notification */
-		$notification = $this->createMock(INotification::class);
-		$notification->expects($this->once())
-			->method('getApp')
-			->willReturn('twofactor_backupcodes');
-		$notification->expects($this->once())
-			->method('getSubject')
-			->willReturn('wrong subject');
-
-		$this->notifier->prepare($notification, 'en');
-	}
-
-	public function testPrepare(): void {
-		/** @var INotification&MockObject $notification */
-		$notification = $this->createMock(INotification::class);
-
-		$notification->expects($this->once())
-			->method('getApp')
-			->willReturn('twofactor_backupcodes');
-		$notification->expects($this->once())
-			->method('getSubject')
-			->willReturn('create_backupcodes');
-
-		$this->factory->expects($this->once())
-			->method('get')
-			->with('twofactor_backupcodes', 'nl')
-			->willReturn($this->l);
-
-		$notification->expects($this->once())
-			->method('setParsedSubject')
-			->with('Generate backup codes')
-			->willReturnSelf();
-		$notification->expects($this->once())
-			->method('setParsedMessage')
-			->with('You enabled two-factor authentication but did not generate backup codes yet. They are needed to restore access to your account in case you lose your second factor.')
-			->willReturnSelf();
-
-		$this->url->expects($this->once())
-			->method('linkToRouteAbsolute')
-			->with('settings.PersonalSettings.index', ['section' => 'security'])
-			->willReturn('linkToRouteAbsolute');
-		$notification->expects($this->once())
-			->method('setLink')
-			->with('linkToRouteAbsolute')
-			->willReturnSelf();
-
-		$return = $this->notifier->prepare($notification, 'nl');
-		$this->assertEquals($notification, $return);
-	}
+    protected IFactory&MockObject $factory;
+    protected IURLGenerator&MockObject $url;
+    protected IL10N&MockObject $l;
+    protected Notifier $notifier;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->l = $this->createMock(IL10N::class);
+        $this->l->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($string, $args) {
+                return vsprintf($string, $args);
+            });
+        $this->factory = $this->createMock(IFactory::class);
+        $this->url = $this->createMock(IURLGenerator::class);
+        $this->factory->expects($this->any())
+            ->method('get')
+            ->willReturn($this->l);
+
+        $this->notifier = new Notifier(
+            $this->factory,
+            $this->url
+        );
+    }
+
+
+    public function testPrepareWrongApp(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        /** @var INotification|MockObject $notification */
+        $notification = $this->createMock(INotification::class);
+        $notification->expects($this->once())
+            ->method('getApp')
+            ->willReturn('notifications');
+        $notification->expects($this->never())
+            ->method('getSubject');
+
+        $this->notifier->prepare($notification, 'en');
+    }
+
+
+    public function testPrepareWrongSubject(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        /** @var INotification|MockObject $notification */
+        $notification = $this->createMock(INotification::class);
+        $notification->expects($this->once())
+            ->method('getApp')
+            ->willReturn('twofactor_backupcodes');
+        $notification->expects($this->once())
+            ->method('getSubject')
+            ->willReturn('wrong subject');
+
+        $this->notifier->prepare($notification, 'en');
+    }
+
+    public function testPrepare(): void {
+        /** @var INotification&MockObject $notification */
+        $notification = $this->createMock(INotification::class);
+
+        $notification->expects($this->once())
+            ->method('getApp')
+            ->willReturn('twofactor_backupcodes');
+        $notification->expects($this->once())
+            ->method('getSubject')
+            ->willReturn('create_backupcodes');
+
+        $this->factory->expects($this->once())
+            ->method('get')
+            ->with('twofactor_backupcodes', 'nl')
+            ->willReturn($this->l);
+
+        $notification->expects($this->once())
+            ->method('setParsedSubject')
+            ->with('Generate backup codes')
+            ->willReturnSelf();
+        $notification->expects($this->once())
+            ->method('setParsedMessage')
+            ->with('You enabled two-factor authentication but did not generate backup codes yet. They are needed to restore access to your account in case you lose your second factor.')
+            ->willReturnSelf();
+
+        $this->url->expects($this->once())
+            ->method('linkToRouteAbsolute')
+            ->with('settings.PersonalSettings.index', ['section' => 'security'])
+            ->willReturn('linkToRouteAbsolute');
+        $notification->expects($this->once())
+            ->method('setLink')
+            ->with('linkToRouteAbsolute')
+            ->willReturnSelf();
+
+        $return = $this->notifier->prepare($notification, 'nl');
+        $this->assertEquals($notification, $return);
+    }
 }

apps/twofactor_backupcodes/tests/Unit/Activity/ProviderTest.php

Indentation +86 added lines, -86 removed lines

@@ -19,90 +19,90 @@
 use Test\TestCase;
 
 class ProviderTest extends TestCase {
-	private IFactory&MockObject $l10n;
-	private IURLGenerator&MockObject $urlGenerator;
-	private IManager&MockObject $activityManager;
-	private Provider $provider;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->l10n = $this->createMock(IFactory::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->activityManager = $this->createMock(IManager::class);
-
-		$this->provider = new Provider($this->l10n, $this->urlGenerator, $this->activityManager);
-	}
-
-	public function testParseUnrelated(): void {
-		$lang = 'ru';
-		$event = $this->createMock(IEvent::class);
-		$event->expects($this->once())
-			->method('getApp')
-			->willReturn('comments');
-		$this->expectException(UnknownActivityException::class);
-
-		$this->provider->parse($lang, $event);
-	}
-
-	public static function subjectData(): array {
-		return [
-			['codes_generated'],
-		];
-	}
-
-	/**
-	 * @dataProvider subjectData
-	 */
-	public function testParse(string $subject): void {
-		$lang = 'ru';
-		$event = $this->createMock(IEvent::class);
-		$l = $this->createMock(IL10N::class);
-
-		$event->expects($this->once())
-			->method('getApp')
-			->willReturn('twofactor_backupcodes');
-		$this->l10n->expects($this->once())
-			->method('get')
-			->with('twofactor_backupcodes', $lang)
-			->willReturn($l);
-		$this->urlGenerator->expects($this->once())
-			->method('imagePath')
-			->with('core', 'actions/password.svg')
-			->willReturn('path/to/image');
-		$this->urlGenerator->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('path/to/image')
-			->willReturn('absolute/path/to/image');
-		$event->expects($this->once())
-			->method('setIcon')
-			->with('absolute/path/to/image');
-		$event->expects($this->once())
-			->method('getSubject')
-			->willReturn($subject);
-		$event->expects($this->once())
-			->method('setParsedSubject');
-
-		$this->provider->parse($lang, $event);
-	}
-
-	public function testParseInvalidSubject(): void {
-		$lang = 'ru';
-		$l = $this->createMock(IL10N::class);
-		$event = $this->createMock(IEvent::class);
-
-		$event->expects($this->once())
-			->method('getApp')
-			->willReturn('twofactor_backupcodes');
-		$this->l10n->expects($this->once())
-			->method('get')
-			->with('twofactor_backupcodes', $lang)
-			->willReturn($l);
-		$event->expects($this->once())
-			->method('getSubject')
-			->willReturn('unrelated');
-
-		$this->expectException(UnknownActivityException::class);
-		$this->provider->parse($lang, $event);
-	}
+    private IFactory&MockObject $l10n;
+    private IURLGenerator&MockObject $urlGenerator;
+    private IManager&MockObject $activityManager;
+    private Provider $provider;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->l10n = $this->createMock(IFactory::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->activityManager = $this->createMock(IManager::class);
+
+        $this->provider = new Provider($this->l10n, $this->urlGenerator, $this->activityManager);
+    }
+
+    public function testParseUnrelated(): void {
+        $lang = 'ru';
+        $event = $this->createMock(IEvent::class);
+        $event->expects($this->once())
+            ->method('getApp')
+            ->willReturn('comments');
+        $this->expectException(UnknownActivityException::class);
+
+        $this->provider->parse($lang, $event);
+    }
+
+    public static function subjectData(): array {
+        return [
+            ['codes_generated'],
+        ];
+    }
+
+    /**
+     * @dataProvider subjectData
+     */
+    public function testParse(string $subject): void {
+        $lang = 'ru';
+        $event = $this->createMock(IEvent::class);
+        $l = $this->createMock(IL10N::class);
+
+        $event->expects($this->once())
+            ->method('getApp')
+            ->willReturn('twofactor_backupcodes');
+        $this->l10n->expects($this->once())
+            ->method('get')
+            ->with('twofactor_backupcodes', $lang)
+            ->willReturn($l);
+        $this->urlGenerator->expects($this->once())
+            ->method('imagePath')
+            ->with('core', 'actions/password.svg')
+            ->willReturn('path/to/image');
+        $this->urlGenerator->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('path/to/image')
+            ->willReturn('absolute/path/to/image');
+        $event->expects($this->once())
+            ->method('setIcon')
+            ->with('absolute/path/to/image');
+        $event->expects($this->once())
+            ->method('getSubject')
+            ->willReturn($subject);
+        $event->expects($this->once())
+            ->method('setParsedSubject');
+
+        $this->provider->parse($lang, $event);
+    }
+
+    public function testParseInvalidSubject(): void {
+        $lang = 'ru';
+        $l = $this->createMock(IL10N::class);
+        $event = $this->createMock(IEvent::class);
+
+        $event->expects($this->once())
+            ->method('getApp')
+            ->willReturn('twofactor_backupcodes');
+        $this->l10n->expects($this->once())
+            ->method('get')
+            ->with('twofactor_backupcodes', $lang)
+            ->willReturn($l);
+        $event->expects($this->once())
+            ->method('getSubject')
+            ->willReturn('unrelated');
+
+        $this->expectException(UnknownActivityException::class);
+        $this->provider->parse($lang, $event);
+    }
 }