nextcloud / server

tests/lib/Authentication/Login/LoggedInCheckCommandTest.php

Indentation +26 added lines, -26 removed lines

@@ -16,40 +16,40 @@
 use Psr\Log\LoggerInterface;
 
 class LoggedInCheckCommandTest extends ALoginTestCommand {
-	/** @var LoggerInterface|MockObject */
-	private $logger;
+    /** @var LoggerInterface|MockObject */
+    private $logger;
 
-	/** @var IEventDispatcher|MockObject */
-	private $dispatcher;
+    /** @var IEventDispatcher|MockObject */
+    private $dispatcher;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->dispatcher = $this->createMock(IEventDispatcher::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->dispatcher = $this->createMock(IEventDispatcher::class);
 
-		$this->cmd = new LoggedInCheckCommand(
-			$this->logger,
-			$this->dispatcher
-		);
-	}
+        $this->cmd = new LoggedInCheckCommand(
+            $this->logger,
+            $this->dispatcher
+        );
+    }
 
-	public function testProcessSuccessfulLogin(): void {
-		$data = $this->getLoggedInLoginData();
+    public function testProcessSuccessfulLogin(): void {
+        $data = $this->getLoggedInLoginData();
 
-		$result = $this->cmd->process($data);
+        $result = $this->cmd->process($data);
 
-		$this->assertTrue($result->isSuccess());
-	}
+        $this->assertTrue($result->isSuccess());
+    }
 
-	public function testProcessFailedLogin(): void {
-		$data = $this->getFailedLoginData();
-		$this->logger->expects($this->once())
-			->method('warning');
+    public function testProcessFailedLogin(): void {
+        $data = $this->getFailedLoginData();
+        $this->logger->expects($this->once())
+            ->method('warning');
 
-		$result = $this->cmd->process($data);
+        $result = $this->cmd->process($data);
 
-		$this->assertFalse($result->isSuccess());
-		$this->assertSame(LoginController::LOGIN_MSG_INVALIDPASSWORD, $result->getErrorMessage());
-	}
+        $this->assertFalse($result->isSuccess());
+        $this->assertSame(LoginController::LOGIN_MSG_INVALIDPASSWORD, $result->getErrorMessage());
+    }
 }

tests/lib/Authentication/Login/TwoFactorCommandTest.php

Indentation +319 added lines, -319 removed lines

@@ -19,323 +19,323 @@
 use PHPUnit\Framework\MockObject\MockObject;
 
 class TwoFactorCommandTest extends ALoginTestCommand {
-	/** @var Manager|MockObject */
-	private $twoFactorManager;
-
-	/** @var MandatoryTwoFactor|MockObject */
-	private $mandatoryTwoFactor;
-
-	/** @var IURLGenerator|MockObject */
-	private $urlGenerator;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->twoFactorManager = $this->createMock(Manager::class);
-		$this->mandatoryTwoFactor = $this->createMock(MandatoryTwoFactor::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-
-		$this->cmd = new TwoFactorCommand(
-			$this->twoFactorManager,
-			$this->mandatoryTwoFactor,
-			$this->urlGenerator
-		);
-	}
-
-	public function testNotTwoFactorAuthenticated(): void {
-		$data = $this->getLoggedInLoginData();
-		$this->twoFactorManager->expects($this->once())
-			->method('isTwoFactorAuthenticated')
-			->willReturn(false);
-		$this->twoFactorManager->expects($this->never())
-			->method('prepareTwoFactorLogin');
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-	}
-
-	public function testProcessOneActiveProvider(): void {
-		$data = $this->getLoggedInLoginData();
-		$this->twoFactorManager->expects($this->once())
-			->method('isTwoFactorAuthenticated')
-			->willReturn(true);
-		$this->twoFactorManager->expects($this->once())
-			->method('prepareTwoFactorLogin')
-			->with(
-				$this->user,
-				$data->isRememberLogin()
-			);
-		$provider = $this->createMock(ITwoFactorAuthProvider::class);
-		$this->twoFactorManager->expects($this->once())
-			->method('getProviderSet')
-			->willReturn(new ProviderSet([
-				$provider,
-			], false));
-		$this->twoFactorManager->expects($this->once())
-			->method('getLoginSetupProviders')
-			->with($this->user)
-			->willReturn([]);
-		$this->mandatoryTwoFactor->expects($this->any())
-			->method('isEnforcedFor')
-			->with($this->user)
-			->willReturn(false);
-		$provider->expects($this->once())
-			->method('getId')
-			->willReturn('test');
-		$this->urlGenerator->expects($this->once())
-			->method('linkToRoute')
-			->with(
-				'core.TwoFactorChallenge.showChallenge',
-				[
-					'challengeProviderId' => 'test'
-				]
-			)
-			->willReturn('two/factor/url');
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-		$this->assertEquals('two/factor/url', $result->getRedirectUrl());
-	}
-
-	public function testProcessMissingProviders(): void {
-		$data = $this->getLoggedInLoginData();
-		$this->twoFactorManager->expects($this->once())
-			->method('isTwoFactorAuthenticated')
-			->willReturn(true);
-		$this->twoFactorManager->expects($this->once())
-			->method('prepareTwoFactorLogin')
-			->with(
-				$this->user,
-				$data->isRememberLogin()
-			);
-		$provider = $this->createMock(ITwoFactorAuthProvider::class);
-		$provider->expects($this->once())
-			->method('getId')
-			->willReturn('test1');
-		$this->twoFactorManager->expects($this->once())
-			->method('getProviderSet')
-			->willReturn(new ProviderSet([
-				$provider,
-			], true));
-		$this->twoFactorManager->expects($this->once())
-			->method('getLoginSetupProviders')
-			->with($this->user)
-			->willReturn([]);
-		$this->mandatoryTwoFactor->expects($this->any())
-			->method('isEnforcedFor')
-			->with($this->user)
-			->willReturn(false);
-		$this->urlGenerator->expects($this->once())
-			->method('linkToRoute')
-			->with(
-				'core.TwoFactorChallenge.selectChallenge'
-			)
-			->willReturn('two/factor/url');
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-		$this->assertEquals('two/factor/url', $result->getRedirectUrl());
-	}
-
-	public function testProcessTwoActiveProviders(): void {
-		$data = $this->getLoggedInLoginData();
-		$this->twoFactorManager->expects($this->once())
-			->method('isTwoFactorAuthenticated')
-			->willReturn(true);
-		$this->twoFactorManager->expects($this->once())
-			->method('prepareTwoFactorLogin')
-			->with(
-				$this->user,
-				$data->isRememberLogin()
-			);
-		$provider1 = $this->createMock(ITwoFactorAuthProvider::class);
-		$provider2 = $this->createMock(ITwoFactorAuthProvider::class);
-		$provider1->expects($this->once())
-			->method('getId')
-			->willReturn('test1');
-		$provider2->expects($this->once())
-			->method('getId')
-			->willReturn('test2');
-		$this->twoFactorManager->expects($this->once())
-			->method('getProviderSet')
-			->willReturn(new ProviderSet([
-				$provider1,
-				$provider2,
-			], false));
-		$this->twoFactorManager->expects($this->once())
-			->method('getLoginSetupProviders')
-			->with($this->user)
-			->willReturn([]);
-		$this->mandatoryTwoFactor->expects($this->any())
-			->method('isEnforcedFor')
-			->with($this->user)
-			->willReturn(false);
-		$this->urlGenerator->expects($this->once())
-			->method('linkToRoute')
-			->with(
-				'core.TwoFactorChallenge.selectChallenge'
-			)
-			->willReturn('two/factor/url');
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-		$this->assertEquals('two/factor/url', $result->getRedirectUrl());
-	}
-
-	public function testProcessFailingProviderAndEnforcedButNoSetupProviders(): void {
-		$data = $this->getLoggedInLoginData();
-		$this->twoFactorManager->expects($this->once())
-			->method('isTwoFactorAuthenticated')
-			->willReturn(true);
-		$this->twoFactorManager->expects($this->once())
-			->method('prepareTwoFactorLogin')
-			->with(
-				$this->user,
-				$data->isRememberLogin()
-			);
-		$this->twoFactorManager->expects($this->once())
-			->method('getProviderSet')
-			->willReturn(new ProviderSet([], true));
-		$this->twoFactorManager->expects($this->once())
-			->method('getLoginSetupProviders')
-			->with($this->user)
-			->willReturn([]);
-		$this->mandatoryTwoFactor->expects($this->any())
-			->method('isEnforcedFor')
-			->with($this->user)
-			->willReturn(true);
-		$this->urlGenerator->expects($this->once())
-			->method('linkToRoute')
-			->with(
-				'core.TwoFactorChallenge.selectChallenge'
-			)
-			->willReturn('two/factor/url');
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-		$this->assertEquals('two/factor/url', $result->getRedirectUrl());
-	}
-
-	public function testProcessFailingProviderAndEnforced(): void {
-		$data = $this->getLoggedInLoginData();
-		$this->twoFactorManager->expects($this->once())
-			->method('isTwoFactorAuthenticated')
-			->willReturn(true);
-		$this->twoFactorManager->expects($this->once())
-			->method('prepareTwoFactorLogin')
-			->with(
-				$this->user,
-				$data->isRememberLogin()
-			);
-		$provider = $this->createMock(IActivatableAtLogin::class);
-		$this->twoFactorManager->expects($this->once())
-			->method('getProviderSet')
-			->willReturn(new ProviderSet([
-				$provider,
-			], true));
-		$this->twoFactorManager->expects($this->once())
-			->method('getLoginSetupProviders')
-			->with($this->user)
-			->willReturn([]);
-		$this->mandatoryTwoFactor->expects($this->any())
-			->method('isEnforcedFor')
-			->with($this->user)
-			->willReturn(true);
-		$this->urlGenerator->expects($this->once())
-			->method('linkToRoute')
-			->with(
-				'core.TwoFactorChallenge.selectChallenge'
-			)
-			->willReturn('two/factor/url');
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-		$this->assertEquals('two/factor/url', $result->getRedirectUrl());
-	}
-
-	public function testProcessNoProvidersButEnforced(): void {
-		$data = $this->getLoggedInLoginData();
-		$this->twoFactorManager->expects($this->once())
-			->method('isTwoFactorAuthenticated')
-			->willReturn(true);
-		$this->twoFactorManager->expects($this->once())
-			->method('prepareTwoFactorLogin')
-			->with(
-				$this->user,
-				$data->isRememberLogin()
-			);
-		$this->twoFactorManager->expects($this->once())
-			->method('getProviderSet')
-			->willReturn(new ProviderSet([], false));
-		$this->twoFactorManager->expects($this->once())
-			->method('getLoginSetupProviders')
-			->with($this->user)
-			->willReturn([]);
-		$this->mandatoryTwoFactor->expects($this->any())
-			->method('isEnforcedFor')
-			->with($this->user)
-			->willReturn(true);
-		$this->urlGenerator->expects($this->once())
-			->method('linkToRoute')
-			->with(
-				'core.TwoFactorChallenge.selectChallenge'
-			)
-			->willReturn('two/factor/url');
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-		$this->assertEquals('two/factor/url', $result->getRedirectUrl());
-	}
-
-	public function testProcessWithRedirectUrl(): void {
-		$data = $this->getLoggedInLoginDataWithRedirectUrl();
-		$this->twoFactorManager->expects($this->once())
-			->method('isTwoFactorAuthenticated')
-			->willReturn(true);
-		$this->twoFactorManager->expects($this->once())
-			->method('prepareTwoFactorLogin')
-			->with(
-				$this->user,
-				$data->isRememberLogin()
-			);
-		$provider = $this->createMock(ITwoFactorAuthProvider::class);
-		$this->twoFactorManager->expects($this->once())
-			->method('getProviderSet')
-			->willReturn(new ProviderSet([
-				$provider,
-			], false));
-		$this->twoFactorManager->expects($this->once())
-			->method('getLoginSetupProviders')
-			->with($this->user)
-			->willReturn([]);
-		$this->mandatoryTwoFactor->expects($this->any())
-			->method('isEnforcedFor')
-			->with($this->user)
-			->willReturn(false);
-		$provider->expects($this->once())
-			->method('getId')
-			->willReturn('test');
-		$this->urlGenerator->expects($this->once())
-			->method('linkToRoute')
-			->with(
-				'core.TwoFactorChallenge.showChallenge',
-				[
-					'challengeProviderId' => 'test',
-					'redirect_url' => $this->redirectUrl,
-				]
-			)
-			->willReturn('two/factor/url');
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-		$this->assertEquals('two/factor/url', $result->getRedirectUrl());
-	}
+    /** @var Manager|MockObject */
+    private $twoFactorManager;
+
+    /** @var MandatoryTwoFactor|MockObject */
+    private $mandatoryTwoFactor;
+
+    /** @var IURLGenerator|MockObject */
+    private $urlGenerator;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->twoFactorManager = $this->createMock(Manager::class);
+        $this->mandatoryTwoFactor = $this->createMock(MandatoryTwoFactor::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+
+        $this->cmd = new TwoFactorCommand(
+            $this->twoFactorManager,
+            $this->mandatoryTwoFactor,
+            $this->urlGenerator
+        );
+    }
+
+    public function testNotTwoFactorAuthenticated(): void {
+        $data = $this->getLoggedInLoginData();
+        $this->twoFactorManager->expects($this->once())
+            ->method('isTwoFactorAuthenticated')
+            ->willReturn(false);
+        $this->twoFactorManager->expects($this->never())
+            ->method('prepareTwoFactorLogin');
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+    }
+
+    public function testProcessOneActiveProvider(): void {
+        $data = $this->getLoggedInLoginData();
+        $this->twoFactorManager->expects($this->once())
+            ->method('isTwoFactorAuthenticated')
+            ->willReturn(true);
+        $this->twoFactorManager->expects($this->once())
+            ->method('prepareTwoFactorLogin')
+            ->with(
+                $this->user,
+                $data->isRememberLogin()
+            );
+        $provider = $this->createMock(ITwoFactorAuthProvider::class);
+        $this->twoFactorManager->expects($this->once())
+            ->method('getProviderSet')
+            ->willReturn(new ProviderSet([
+                $provider,
+            ], false));
+        $this->twoFactorManager->expects($this->once())
+            ->method('getLoginSetupProviders')
+            ->with($this->user)
+            ->willReturn([]);
+        $this->mandatoryTwoFactor->expects($this->any())
+            ->method('isEnforcedFor')
+            ->with($this->user)
+            ->willReturn(false);
+        $provider->expects($this->once())
+            ->method('getId')
+            ->willReturn('test');
+        $this->urlGenerator->expects($this->once())
+            ->method('linkToRoute')
+            ->with(
+                'core.TwoFactorChallenge.showChallenge',
+                [
+                    'challengeProviderId' => 'test'
+                ]
+            )
+            ->willReturn('two/factor/url');
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+        $this->assertEquals('two/factor/url', $result->getRedirectUrl());
+    }
+
+    public function testProcessMissingProviders(): void {
+        $data = $this->getLoggedInLoginData();
+        $this->twoFactorManager->expects($this->once())
+            ->method('isTwoFactorAuthenticated')
+            ->willReturn(true);
+        $this->twoFactorManager->expects($this->once())
+            ->method('prepareTwoFactorLogin')
+            ->with(
+                $this->user,
+                $data->isRememberLogin()
+            );
+        $provider = $this->createMock(ITwoFactorAuthProvider::class);
+        $provider->expects($this->once())
+            ->method('getId')
+            ->willReturn('test1');
+        $this->twoFactorManager->expects($this->once())
+            ->method('getProviderSet')
+            ->willReturn(new ProviderSet([
+                $provider,
+            ], true));
+        $this->twoFactorManager->expects($this->once())
+            ->method('getLoginSetupProviders')
+            ->with($this->user)
+            ->willReturn([]);
+        $this->mandatoryTwoFactor->expects($this->any())
+            ->method('isEnforcedFor')
+            ->with($this->user)
+            ->willReturn(false);
+        $this->urlGenerator->expects($this->once())
+            ->method('linkToRoute')
+            ->with(
+                'core.TwoFactorChallenge.selectChallenge'
+            )
+            ->willReturn('two/factor/url');
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+        $this->assertEquals('two/factor/url', $result->getRedirectUrl());
+    }
+
+    public function testProcessTwoActiveProviders(): void {
+        $data = $this->getLoggedInLoginData();
+        $this->twoFactorManager->expects($this->once())
+            ->method('isTwoFactorAuthenticated')
+            ->willReturn(true);
+        $this->twoFactorManager->expects($this->once())
+            ->method('prepareTwoFactorLogin')
+            ->with(
+                $this->user,
+                $data->isRememberLogin()
+            );
+        $provider1 = $this->createMock(ITwoFactorAuthProvider::class);
+        $provider2 = $this->createMock(ITwoFactorAuthProvider::class);
+        $provider1->expects($this->once())
+            ->method('getId')
+            ->willReturn('test1');
+        $provider2->expects($this->once())
+            ->method('getId')
+            ->willReturn('test2');
+        $this->twoFactorManager->expects($this->once())
+            ->method('getProviderSet')
+            ->willReturn(new ProviderSet([
+                $provider1,
+                $provider2,
+            ], false));
+        $this->twoFactorManager->expects($this->once())
+            ->method('getLoginSetupProviders')
+            ->with($this->user)
+            ->willReturn([]);
+        $this->mandatoryTwoFactor->expects($this->any())
+            ->method('isEnforcedFor')
+            ->with($this->user)
+            ->willReturn(false);
+        $this->urlGenerator->expects($this->once())
+            ->method('linkToRoute')
+            ->with(
+                'core.TwoFactorChallenge.selectChallenge'
+            )
+            ->willReturn('two/factor/url');
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+        $this->assertEquals('two/factor/url', $result->getRedirectUrl());
+    }
+
+    public function testProcessFailingProviderAndEnforcedButNoSetupProviders(): void {
+        $data = $this->getLoggedInLoginData();
+        $this->twoFactorManager->expects($this->once())
+            ->method('isTwoFactorAuthenticated')
+            ->willReturn(true);
+        $this->twoFactorManager->expects($this->once())
+            ->method('prepareTwoFactorLogin')
+            ->with(
+                $this->user,
+                $data->isRememberLogin()
+            );
+        $this->twoFactorManager->expects($this->once())
+            ->method('getProviderSet')
+            ->willReturn(new ProviderSet([], true));
+        $this->twoFactorManager->expects($this->once())
+            ->method('getLoginSetupProviders')
+            ->with($this->user)
+            ->willReturn([]);
+        $this->mandatoryTwoFactor->expects($this->any())
+            ->method('isEnforcedFor')
+            ->with($this->user)
+            ->willReturn(true);
+        $this->urlGenerator->expects($this->once())
+            ->method('linkToRoute')
+            ->with(
+                'core.TwoFactorChallenge.selectChallenge'
+            )
+            ->willReturn('two/factor/url');
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+        $this->assertEquals('two/factor/url', $result->getRedirectUrl());
+    }
+
+    public function testProcessFailingProviderAndEnforced(): void {
+        $data = $this->getLoggedInLoginData();
+        $this->twoFactorManager->expects($this->once())
+            ->method('isTwoFactorAuthenticated')
+            ->willReturn(true);
+        $this->twoFactorManager->expects($this->once())
+            ->method('prepareTwoFactorLogin')
+            ->with(
+                $this->user,
+                $data->isRememberLogin()
+            );
+        $provider = $this->createMock(IActivatableAtLogin::class);
+        $this->twoFactorManager->expects($this->once())
+            ->method('getProviderSet')
+            ->willReturn(new ProviderSet([
+                $provider,
+            ], true));
+        $this->twoFactorManager->expects($this->once())
+            ->method('getLoginSetupProviders')
+            ->with($this->user)
+            ->willReturn([]);
+        $this->mandatoryTwoFactor->expects($this->any())
+            ->method('isEnforcedFor')
+            ->with($this->user)
+            ->willReturn(true);
+        $this->urlGenerator->expects($this->once())
+            ->method('linkToRoute')
+            ->with(
+                'core.TwoFactorChallenge.selectChallenge'
+            )
+            ->willReturn('two/factor/url');
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+        $this->assertEquals('two/factor/url', $result->getRedirectUrl());
+    }
+
+    public function testProcessNoProvidersButEnforced(): void {
+        $data = $this->getLoggedInLoginData();
+        $this->twoFactorManager->expects($this->once())
+            ->method('isTwoFactorAuthenticated')
+            ->willReturn(true);
+        $this->twoFactorManager->expects($this->once())
+            ->method('prepareTwoFactorLogin')
+            ->with(
+                $this->user,
+                $data->isRememberLogin()
+            );
+        $this->twoFactorManager->expects($this->once())
+            ->method('getProviderSet')
+            ->willReturn(new ProviderSet([], false));
+        $this->twoFactorManager->expects($this->once())
+            ->method('getLoginSetupProviders')
+            ->with($this->user)
+            ->willReturn([]);
+        $this->mandatoryTwoFactor->expects($this->any())
+            ->method('isEnforcedFor')
+            ->with($this->user)
+            ->willReturn(true);
+        $this->urlGenerator->expects($this->once())
+            ->method('linkToRoute')
+            ->with(
+                'core.TwoFactorChallenge.selectChallenge'
+            )
+            ->willReturn('two/factor/url');
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+        $this->assertEquals('two/factor/url', $result->getRedirectUrl());
+    }
+
+    public function testProcessWithRedirectUrl(): void {
+        $data = $this->getLoggedInLoginDataWithRedirectUrl();
+        $this->twoFactorManager->expects($this->once())
+            ->method('isTwoFactorAuthenticated')
+            ->willReturn(true);
+        $this->twoFactorManager->expects($this->once())
+            ->method('prepareTwoFactorLogin')
+            ->with(
+                $this->user,
+                $data->isRememberLogin()
+            );
+        $provider = $this->createMock(ITwoFactorAuthProvider::class);
+        $this->twoFactorManager->expects($this->once())
+            ->method('getProviderSet')
+            ->willReturn(new ProviderSet([
+                $provider,
+            ], false));
+        $this->twoFactorManager->expects($this->once())
+            ->method('getLoginSetupProviders')
+            ->with($this->user)
+            ->willReturn([]);
+        $this->mandatoryTwoFactor->expects($this->any())
+            ->method('isEnforcedFor')
+            ->with($this->user)
+            ->willReturn(false);
+        $provider->expects($this->once())
+            ->method('getId')
+            ->willReturn('test');
+        $this->urlGenerator->expects($this->once())
+            ->method('linkToRoute')
+            ->with(
+                'core.TwoFactorChallenge.showChallenge',
+                [
+                    'challengeProviderId' => 'test',
+                    'redirect_url' => $this->redirectUrl,
+                ]
+            )
+            ->willReturn('two/factor/url');
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+        $this->assertEquals('two/factor/url', $result->getRedirectUrl());
+    }
 }

tests/lib/Authentication/Login/UserDisabledCheckCommandTest.php

Indentation +60 added lines, -60 removed lines

@@ -16,64 +16,64 @@
 use Psr\Log\LoggerInterface;
 
 class UserDisabledCheckCommandTest extends ALoginTestCommand {
-	/** @var IUserManager|MockObject */
-	private $userManager;
-
-	/** @var LoggerInterface|MockObject */
-	private $logger;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-
-		$this->cmd = new UserDisabledCheckCommand(
-			$this->userManager,
-			$this->logger
-		);
-	}
-
-	public function testProcessNonExistingUser(): void {
-		$data = $this->getBasicLoginData();
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with($this->username)
-			->willReturn(null);
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-	}
-
-	public function testProcessDisabledUser(): void {
-		$data = $this->getBasicLoginData();
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with($this->username)
-			->willReturn($this->user);
-		$this->user->expects($this->once())
-			->method('isEnabled')
-			->willReturn(false);
-
-		$result = $this->cmd->process($data);
-
-		$this->assertFalse($result->isSuccess());
-		$this->assertSame(LoginController::LOGIN_MSG_USERDISABLED, $result->getErrorMessage());
-	}
-
-	public function testProcess(): void {
-		$data = $this->getBasicLoginData();
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with($this->username)
-			->willReturn($this->user);
-		$this->user->expects($this->once())
-			->method('isEnabled')
-			->willReturn(true);
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-	}
+    /** @var IUserManager|MockObject */
+    private $userManager;
+
+    /** @var LoggerInterface|MockObject */
+    private $logger;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+
+        $this->cmd = new UserDisabledCheckCommand(
+            $this->userManager,
+            $this->logger
+        );
+    }
+
+    public function testProcessNonExistingUser(): void {
+        $data = $this->getBasicLoginData();
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with($this->username)
+            ->willReturn(null);
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+    }
+
+    public function testProcessDisabledUser(): void {
+        $data = $this->getBasicLoginData();
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with($this->username)
+            ->willReturn($this->user);
+        $this->user->expects($this->once())
+            ->method('isEnabled')
+            ->willReturn(false);
+
+        $result = $this->cmd->process($data);
+
+        $this->assertFalse($result->isSuccess());
+        $this->assertSame(LoginController::LOGIN_MSG_USERDISABLED, $result->getErrorMessage());
+    }
+
+    public function testProcess(): void {
+        $data = $this->getBasicLoginData();
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with($this->username)
+            ->willReturn($this->user);
+        $this->user->expects($this->once())
+            ->method('isEnabled')
+            ->willReturn(true);
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+    }
 }

tests/lib/Authentication/Login/PreLoginHookCommandTest.php

Indentation +30 added lines, -30 removed lines

@@ -15,34 +15,34 @@
 use PHPUnit\Framework\MockObject\MockObject;
 
 class PreLoginHookCommandTest extends ALoginTestCommand {
-	/** @var IUserManager|MockObject */
-	private $userManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(Manager::class);
-
-		$this->cmd = new PreLoginHookCommand(
-			$this->userManager
-		);
-	}
-
-	public function testProcess(): void {
-		$data = $this->getBasicLoginData();
-		$this->userManager->expects($this->once())
-			->method('emit')
-			->with(
-				'\OC\User',
-				'preLogin',
-				[
-					$this->username,
-					$this->password,
-				]
-			);
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-	}
+    /** @var IUserManager|MockObject */
+    private $userManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(Manager::class);
+
+        $this->cmd = new PreLoginHookCommand(
+            $this->userManager
+        );
+    }
+
+    public function testProcess(): void {
+        $data = $this->getBasicLoginData();
+        $this->userManager->expects($this->once())
+            ->method('emit')
+            ->with(
+                '\OC\User',
+                'preLogin',
+                [
+                    $this->username,
+                    $this->password,
+                ]
+            );
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+    }
 }

tests/lib/Authentication/Login/FinishRememberedLoginCommandTest.php

Indentation +56 added lines, -56 removed lines

@@ -15,60 +15,60 @@
 use PHPUnit\Framework\MockObject\MockObject;
 
 class FinishRememberedLoginCommandTest extends ALoginTestCommand {
-	/** @var Session|MockObject */
-	private $userSession;
-	/** @var IConfig|MockObject */
-	private $config;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userSession = $this->createMock(Session::class);
-		$this->config = $this->createMock(IConfig::class);
-
-		$this->cmd = new FinishRememberedLoginCommand(
-			$this->userSession,
-			$this->config
-		);
-	}
-
-	public function testProcessNotRememberedLogin(): void {
-		$data = $this->getLoggedInLoginData();
-		$data->setRememberLogin(false);
-		$this->userSession->expects($this->never())
-			->method('createRememberMeToken');
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-	}
-
-	public function testProcess(): void {
-		$data = $this->getLoggedInLoginData();
-		$this->config->expects($this->once())
-			->method('getSystemValueBool')
-			->with('auto_logout', false)
-			->willReturn(false);
-		$this->userSession->expects($this->once())
-			->method('createRememberMeToken')
-			->with($this->user);
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-	}
-
-	public function testProcessNotRemeberedLoginWithAutologout(): void {
-		$data = $this->getLoggedInLoginData();
-		$this->config->expects($this->once())
-			->method('getSystemValueBool')
-			->with('auto_logout', false)
-			->willReturn(true);
-		$this->userSession->expects($this->never())
-			->method('createRememberMeToken');
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-	}
+    /** @var Session|MockObject */
+    private $userSession;
+    /** @var IConfig|MockObject */
+    private $config;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userSession = $this->createMock(Session::class);
+        $this->config = $this->createMock(IConfig::class);
+
+        $this->cmd = new FinishRememberedLoginCommand(
+            $this->userSession,
+            $this->config
+        );
+    }
+
+    public function testProcessNotRememberedLogin(): void {
+        $data = $this->getLoggedInLoginData();
+        $data->setRememberLogin(false);
+        $this->userSession->expects($this->never())
+            ->method('createRememberMeToken');
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+    }
+
+    public function testProcess(): void {
+        $data = $this->getLoggedInLoginData();
+        $this->config->expects($this->once())
+            ->method('getSystemValueBool')
+            ->with('auto_logout', false)
+            ->willReturn(false);
+        $this->userSession->expects($this->once())
+            ->method('createRememberMeToken')
+            ->with($this->user);
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+    }
+
+    public function testProcessNotRemeberedLoginWithAutologout(): void {
+        $data = $this->getLoggedInLoginData();
+        $this->config->expects($this->once())
+            ->method('getSystemValueBool')
+            ->with('auto_logout', false)
+            ->willReturn(true);
+        $this->userSession->expects($this->never())
+            ->method('createRememberMeToken');
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+    }
 }

tests/lib/Authentication/Login/UidLoginCommandTest.php

Indentation +44 added lines, -44 removed lines

@@ -14,48 +14,48 @@
 use PHPUnit\Framework\MockObject\MockObject;
 
 class UidLoginCommandTest extends ALoginTestCommand {
-	/** @var Manager|MockObject */
-	private $userManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(Manager::class);
-
-		$this->cmd = new UidLoginCommand(
-			$this->userManager
-		);
-	}
-
-	public function testProcessFailingLogin(): void {
-		$data = $this->getBasicLoginData();
-		$this->userManager->expects($this->once())
-			->method('checkPasswordNoLogging')
-			->with(
-				$this->username,
-				$this->password
-			)
-			->willReturn(false);
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-		$this->assertFalse($data->getUser());
-	}
-
-	public function testProcess(): void {
-		$data = $this->getBasicLoginData();
-		$this->userManager->expects($this->once())
-			->method('checkPasswordNoLogging')
-			->with(
-				$this->username,
-				$this->password
-			)
-			->willReturn($this->user);
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-		$this->assertEquals($this->user, $data->getUser());
-	}
+    /** @var Manager|MockObject */
+    private $userManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(Manager::class);
+
+        $this->cmd = new UidLoginCommand(
+            $this->userManager
+        );
+    }
+
+    public function testProcessFailingLogin(): void {
+        $data = $this->getBasicLoginData();
+        $this->userManager->expects($this->once())
+            ->method('checkPasswordNoLogging')
+            ->with(
+                $this->username,
+                $this->password
+            )
+            ->willReturn(false);
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+        $this->assertFalse($data->getUser());
+    }
+
+    public function testProcess(): void {
+        $data = $this->getBasicLoginData();
+        $this->userManager->expects($this->once())
+            ->method('checkPasswordNoLogging')
+            ->with(
+                $this->username,
+                $this->password
+            )
+            ->willReturn($this->user);
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+        $this->assertEquals($this->user, $data->getUser());
+    }
 }

tests/lib/Authentication/Login/ClearLostPasswordTokensCommandTest.php

Indentation +30 added lines, -30 removed lines

@@ -14,34 +14,34 @@
 use PHPUnit\Framework\MockObject\MockObject;
 
 class ClearLostPasswordTokensCommandTest extends ALoginTestCommand {
-	/** @var IConfig|MockObject */
-	private $config;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->createMock(IConfig::class);
-
-		$this->cmd = new ClearLostPasswordTokensCommand(
-			$this->config
-		);
-	}
-
-	public function testProcess(): void {
-		$data = $this->getLoggedInLoginData();
-		$this->user->expects($this->once())
-			->method('getUID')
-			->willReturn($this->username);
-		$this->config->expects($this->once())
-			->method('deleteUserValue')
-			->with(
-				$this->username,
-				'core',
-				'lostpassword'
-			);
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-	}
+    /** @var IConfig|MockObject */
+    private $config;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->createMock(IConfig::class);
+
+        $this->cmd = new ClearLostPasswordTokensCommand(
+            $this->config
+        );
+    }
+
+    public function testProcess(): void {
+        $data = $this->getLoggedInLoginData();
+        $this->user->expects($this->once())
+            ->method('getUID')
+            ->willReturn($this->username);
+        $this->config->expects($this->once())
+            ->method('deleteUserValue')
+            ->with(
+                $this->username,
+                'core',
+                'lostpassword'
+            );
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+    }
 }

tests/lib/Authentication/Login/ALoginTestCommand.php

Indentation +85 added lines, -85 removed lines

@@ -15,89 +15,89 @@
 use Test\TestCase;
 
 abstract class ALoginTestCommand extends TestCase {
-	/** @var IRequest|MockObject */
-	protected $request;
-
-	/** @var string */
-	protected $username = 'user123';
-
-	/** @var string */
-	protected $password = '123456';
-
-	/** @var string */
-	protected $redirectUrl = '/apps/contacts';
-
-	/** @var string */
-	protected $timezone = 'Europe/Vienna';
-
-	protected $timeZoneOffset = '2';
-
-	/** @var IUser|MockObject */
-	protected $user;
-
-	/** @var ALoginTestCommand */
-	protected $cmd;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->request = $this->createMock(IRequest::class);
-		$this->user = $this->createMock(IUser::class);
-	}
-
-	protected function getBasicLoginData(): LoginData {
-		return new LoginData(
-			$this->request,
-			$this->username,
-			$this->password
-		);
-	}
-
-	protected function getInvalidLoginData(): LoginData {
-		return new LoginData(
-			$this->request,
-			$this->username,
-			$this->password
-		);
-	}
-
-	protected function getFailedLoginData(): LoginData {
-		$data = new LoginData(
-			$this->request,
-			$this->username,
-			$this->password
-		);
-		$data->setUser(false);
-		return $data;
-	}
-
-	protected function getLoggedInLoginData(): LoginData {
-		$basic = $this->getBasicLoginData();
-		$basic->setUser($this->user);
-		return $basic;
-	}
-
-	protected function getLoggedInLoginDataWithRedirectUrl(): LoginData {
-		$data = new LoginData(
-			$this->request,
-			$this->username,
-			$this->password,
-			$this->redirectUrl
-		);
-		$data->setUser($this->user);
-		return $data;
-	}
-
-	protected function getLoggedInLoginDataWithTimezone(): LoginData {
-		$data = new LoginData(
-			$this->request,
-			$this->username,
-			$this->password,
-			null,
-			$this->timezone,
-			$this->timeZoneOffset
-		);
-		$data->setUser($this->user);
-		return $data;
-	}
+    /** @var IRequest|MockObject */
+    protected $request;
+
+    /** @var string */
+    protected $username = 'user123';
+
+    /** @var string */
+    protected $password = '123456';
+
+    /** @var string */
+    protected $redirectUrl = '/apps/contacts';
+
+    /** @var string */
+    protected $timezone = 'Europe/Vienna';
+
+    protected $timeZoneOffset = '2';
+
+    /** @var IUser|MockObject */
+    protected $user;
+
+    /** @var ALoginTestCommand */
+    protected $cmd;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->request = $this->createMock(IRequest::class);
+        $this->user = $this->createMock(IUser::class);
+    }
+
+    protected function getBasicLoginData(): LoginData {
+        return new LoginData(
+            $this->request,
+            $this->username,
+            $this->password
+        );
+    }
+
+    protected function getInvalidLoginData(): LoginData {
+        return new LoginData(
+            $this->request,
+            $this->username,
+            $this->password
+        );
+    }
+
+    protected function getFailedLoginData(): LoginData {
+        $data = new LoginData(
+            $this->request,
+            $this->username,
+            $this->password
+        );
+        $data->setUser(false);
+        return $data;
+    }
+
+    protected function getLoggedInLoginData(): LoginData {
+        $basic = $this->getBasicLoginData();
+        $basic->setUser($this->user);
+        return $basic;
+    }
+
+    protected function getLoggedInLoginDataWithRedirectUrl(): LoginData {
+        $data = new LoginData(
+            $this->request,
+            $this->username,
+            $this->password,
+            $this->redirectUrl
+        );
+        $data->setUser($this->user);
+        return $data;
+    }
+
+    protected function getLoggedInLoginDataWithTimezone(): LoginData {
+        $data = new LoginData(
+            $this->request,
+            $this->username,
+            $this->password,
+            null,
+            $this->timezone,
+            $this->timeZoneOffset
+        );
+        $data->setUser($this->user);
+        return $data;
+    }
 }

tests/lib/Authentication/Login/UpdateLastPasswordConfirmCommandTest.php

Indentation +29 added lines, -29 removed lines

@@ -14,33 +14,33 @@
 use PHPUnit\Framework\MockObject\MockObject;
 
 class UpdateLastPasswordConfirmCommandTest extends ALoginTestCommand {
-	/** @var ISession|MockObject */
-	private $session;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->session = $this->createMock(ISession::class);
-
-		$this->cmd = new UpdateLastPasswordConfirmCommand(
-			$this->session
-		);
-	}
-
-	public function testProcess(): void {
-		$data = $this->getLoggedInLoginData();
-		$this->user->expects($this->once())
-			->method('getLastLogin')
-			->willReturn(1234);
-		$this->session->expects($this->once())
-			->method('set')
-			->with(
-				'last-password-confirm',
-				1234
-			);
-
-		$result = $this->cmd->process($data);
-
-		$this->assertTrue($result->isSuccess());
-	}
+    /** @var ISession|MockObject */
+    private $session;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->session = $this->createMock(ISession::class);
+
+        $this->cmd = new UpdateLastPasswordConfirmCommand(
+            $this->session
+        );
+    }
+
+    public function testProcess(): void {
+        $data = $this->getLoggedInLoginData();
+        $this->user->expects($this->once())
+            ->method('getLastLogin')
+            ->willReturn(1234);
+        $this->session->expects($this->once())
+            ->method('set')
+            ->with(
+                'last-password-confirm',
+                1234
+            );
+
+        $result = $this->cmd->process($data);
+
+        $this->assertTrue($result->isSuccess());
+    }
 }