nextcloud / server

tests/lib/Files/ObjectStore/LocalTest.php

Indentation +7 added lines, -7 removed lines

@@ -10,11 +10,11 @@
 use OC\Files\Storage\Temporary;
 
 class LocalTest extends ObjectStoreTestCase {
-	/**
-	 * @return \OCP\Files\ObjectStore\IObjectStore
-	 */
-	protected function getInstance() {
-		$storage = new Temporary();
-		return new StorageObjectStore($storage);
-	}
+    /**
+     * @return \OCP\Files\ObjectStore\IObjectStore
+     */
+    protected function getInstance() {
+        $storage = new Temporary();
+        return new StorageObjectStore($storage);
+    }
 }

tests/lib/Files/ObjectStore/ObjectStoreStoragesDifferentBucketTest.php

Indentation +19 added lines, -19 removed lines

@@ -15,27 +15,27 @@
  * @group DB
  */
 class ObjectStoreStoragesDifferentBucketTest extends StoragesTestCase {
-	/**
-	 * @var \OCP\Files\ObjectStore\IObjectStore
-	 */
-	private $objectStore1;
+    /**
+     * @var \OCP\Files\ObjectStore\IObjectStore
+     */
+    private $objectStore1;
 
-	/**
-	 * @var \OCP\Files\ObjectStore\IObjectStore
-	 */
-	private $objectStore2;
+    /**
+     * @var \OCP\Files\ObjectStore\IObjectStore
+     */
+    private $objectStore2;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$baseStorage1 = new Temporary();
-		$this->objectStore1 = new StorageObjectStore($baseStorage1);
-		$config['objectstore'] = $this->objectStore1;
-		$this->storage1 = new ObjectStoreStorageOverwrite($config);
+        $baseStorage1 = new Temporary();
+        $this->objectStore1 = new StorageObjectStore($baseStorage1);
+        $config['objectstore'] = $this->objectStore1;
+        $this->storage1 = new ObjectStoreStorageOverwrite($config);
 
-		$baseStorage2 = new Temporary();
-		$this->objectStore2 = new StorageObjectStore($baseStorage2);
-		$config['objectstore'] = $this->objectStore2;
-		$this->storage2 = new ObjectStoreStorageOverwrite($config);
-	}
+        $baseStorage2 = new Temporary();
+        $this->objectStore2 = new StorageObjectStore($baseStorage2);
+        $config['objectstore'] = $this->objectStore2;
+        $this->storage2 = new ObjectStoreStorageOverwrite($config);
+    }
 }

tests/lib/Files/ObjectStore/SwiftTest.php

Indentation +13 added lines, -13 removed lines

@@ -13,19 +13,19 @@
  * @group PRIMARY-swift
  */
 class SwiftTest extends ObjectStoreTestCase {
-	/**
-	 * @return \OCP\Files\ObjectStore\IObjectStore
-	 */
-	protected function getInstance() {
-		$config = \OC::$server->getConfig()->getSystemValue('objectstore');
-		if (!is_array($config) || $config['class'] !== 'OC\\Files\\ObjectStore\\Swift') {
-			$this->markTestSkipped('objectstore not configured for swift');
-		}
+    /**
+     * @return \OCP\Files\ObjectStore\IObjectStore
+     */
+    protected function getInstance() {
+        $config = \OC::$server->getConfig()->getSystemValue('objectstore');
+        if (!is_array($config) || $config['class'] !== 'OC\\Files\\ObjectStore\\Swift') {
+            $this->markTestSkipped('objectstore not configured for swift');
+        }
 
-		return new Swift($config['arguments']);
-	}
+        return new Swift($config['arguments']);
+    }
 
-	public function testFseekSize(): void {
-		$this->markTestSkipped('Swift does not support seeking at the moment');
-	}
+    public function testFseekSize(): void {
+        $this->markTestSkipped('Swift does not support seeking at the moment');
+    }
 }

tests/lib/Files/ObjectStore/AzureTest.php

Indentation +10 added lines, -10 removed lines

@@ -12,16 +12,16 @@
  * @group PRIMARY-azure
  */
 class AzureTest extends ObjectStoreTestCase {
-	protected function getInstance() {
-		$config = \OC::$server->getConfig()->getSystemValue('objectstore');
-		if (!is_array($config) || $config['class'] !== 'OC\\Files\\ObjectStore\\Azure') {
-			$this->markTestSkipped('objectstore not configured for azure');
-		}
+    protected function getInstance() {
+        $config = \OC::$server->getConfig()->getSystemValue('objectstore');
+        if (!is_array($config) || $config['class'] !== 'OC\\Files\\ObjectStore\\Azure') {
+            $this->markTestSkipped('objectstore not configured for azure');
+        }
 
-		return new Azure($config['arguments']);
-	}
+        return new Azure($config['arguments']);
+    }
 
-	public function testFseekSize(): void {
-		$this->markTestSkipped('azure does not support seeking at the moment');
-	}
+    public function testFseekSize(): void {
+        $this->markTestSkipped('azure does not support seeking at the moment');
+    }
 }

tests/lib/Files/ObjectStore/ObjectStoreStoragesSameBucketTest.php

Indentation +13 added lines, -13 removed lines

@@ -15,19 +15,19 @@
  * @group DB
  */
 class ObjectStoreStoragesSameBucketTest extends StoragesTestCase {
-	/**
-	 * @var \OCP\Files\ObjectStore\IObjectStore
-	 */
-	private $objectStore;
+    /**
+     * @var \OCP\Files\ObjectStore\IObjectStore
+     */
+    private $objectStore;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$baseStorage = new Temporary();
-		$this->objectStore = new StorageObjectStore($baseStorage);
-		$config['objectstore'] = $this->objectStore;
-		// storage1 and storage2 share the same object store.
-		$this->storage1 = new ObjectStoreStorageOverwrite($config);
-		$this->storage2 = new ObjectStoreStorageOverwrite($config);
-	}
+        $baseStorage = new Temporary();
+        $this->objectStore = new StorageObjectStore($baseStorage);
+        $config['objectstore'] = $this->objectStore;
+        // storage1 and storage2 share the same object store.
+        $this->storage1 = new ObjectStoreStorageOverwrite($config);
+        $this->storage2 = new ObjectStoreStorageOverwrite($config);
+    }
 }

tests/lib/Files/ObjectStore/S3Test.php

Indentation +145 added lines, -145 removed lines

@@ -10,164 +10,164 @@
 use OC\Files\ObjectStore\S3;
 
 class MultiPartUploadS3 extends S3 {
-	public function writeObject($urn, $stream, ?string $mimetype = null) {
-		$this->getConnection()->upload($this->bucket, $urn, $stream, 'private', [
-			'mup_threshold' => 1,
-		]);
-	}
+    public function writeObject($urn, $stream, ?string $mimetype = null) {
+        $this->getConnection()->upload($this->bucket, $urn, $stream, 'private', [
+            'mup_threshold' => 1,
+        ]);
+    }
 }
 
 class NonSeekableStream extends Wrapper {
-	public static function wrap($source) {
-		$context = stream_context_create([
-			'nonseek' => [
-				'source' => $source,
-			],
-		]);
-		return Wrapper::wrapSource($source, $context, 'nonseek', self::class);
-	}
-
-	public function dir_opendir($path, $options) {
-		return false;
-	}
-
-	public function stream_open($path, $mode, $options, &$opened_path) {
-		$this->loadContext('nonseek');
-		return true;
-	}
-
-	public function stream_seek($offset, $whence = SEEK_SET) {
-		return false;
-	}
+    public static function wrap($source) {
+        $context = stream_context_create([
+            'nonseek' => [
+                'source' => $source,
+            ],
+        ]);
+        return Wrapper::wrapSource($source, $context, 'nonseek', self::class);
+    }
+
+    public function dir_opendir($path, $options) {
+        return false;
+    }
+
+    public function stream_open($path, $mode, $options, &$opened_path) {
+        $this->loadContext('nonseek');
+        return true;
+    }
+
+    public function stream_seek($offset, $whence = SEEK_SET) {
+        return false;
+    }
 }
 
 /**
  * @group PRIMARY-s3
  */
 class S3Test extends ObjectStoreTestCase {
-	public function setUp(): void {
-		parent::setUp();
-		$s3 = $this->getInstance();
-		$s3->deleteObject('multiparttest');
-	}
-
-	protected function getInstance() {
-		$config = \OC::$server->getConfig()->getSystemValue('objectstore');
-		if (!is_array($config) || $config['class'] !== S3::class) {
-			$this->markTestSkipped('objectstore not configured for s3');
-		}
-
-		return new S3($config['arguments']);
-	}
+    public function setUp(): void {
+        parent::setUp();
+        $s3 = $this->getInstance();
+        $s3->deleteObject('multiparttest');
+    }
+
+    protected function getInstance() {
+        $config = \OC::$server->getConfig()->getSystemValue('objectstore');
+        if (!is_array($config) || $config['class'] !== S3::class) {
+            $this->markTestSkipped('objectstore not configured for s3');
+        }
+
+        return new S3($config['arguments']);
+    }
 
-	public function testUploadNonSeekable(): void {
-		$this->cleanupAfter('multiparttest');
-
-		$s3 = $this->getInstance();
-
-		$s3->writeObject('multiparttest', NonSeekableStream::wrap(fopen(__FILE__, 'r')));
-
-		$result = $s3->readObject('multiparttest');
-
-		$this->assertEquals(file_get_contents(__FILE__), stream_get_contents($result));
-	}
-
-	public function testSeek(): void {
-		$this->cleanupAfter('seek');
-
-		$data = file_get_contents(__FILE__);
-
-		$instance = $this->getInstance();
-		$instance->writeObject('seek', $this->stringToStream($data));
-
-		$read = $instance->readObject('seek');
-		$this->assertEquals(substr($data, 0, 100), fread($read, 100));
-
-		fseek($read, 10);
-		$this->assertEquals(substr($data, 10, 100), fread($read, 100));
-
-		fseek($read, 100, SEEK_CUR);
-		$this->assertEquals(substr($data, 210, 100), fread($read, 100));
-	}
-
-	public function assertNoUpload($objectUrn) {
-		/** @var \OC\Files\ObjectStore\S3 */
-		$s3 = $this->getInstance();
-		$s3client = $s3->getConnection();
-		$uploads = $s3client->listMultipartUploads([
-			'Bucket' => $s3->getBucket(),
-			'Prefix' => $objectUrn,
-		]);
-		$this->assertArrayNotHasKey('Uploads', $uploads, 'Assert is not uploaded');
-	}
-
-	public function testEmptyUpload(): void {
-		$s3 = $this->getInstance();
-
-		$emptyStream = fopen('php://memory', 'r');
-		fwrite($emptyStream, '');
-
-		$s3->writeObject('emptystream', $emptyStream);
-
-		$this->assertNoUpload('emptystream');
-		$this->assertTrue($s3->objectExists('emptystream'), 'Object exists on S3');
-
-		$thrown = false;
-		try {
-			self::assertFalse($s3->readObject('emptystream'), 'Reading empty stream object should return false');
-		} catch (\Exception $e) {
-			// An exception is expected here since 0 byte files are wrapped
-			// to be read from an empty memory stream in the ObjectStoreStorage
-			$thrown = true;
-		}
-		self::assertTrue($thrown, 'readObject with range requests are not expected to work on empty objects');
-
-		$s3->deleteObject('emptystream');
-	}
-
-	/** File size to upload in bytes */
-	public static function dataFileSizes(): array {
-		return [
-			[1000000], [2000000], [5242879], [5242880], [5242881], [10000000]
-		];
-	}
-
-	/** @dataProvider dataFileSizes */
-	public function testFileSizes($size): void {
-		if (str_starts_with(PHP_VERSION, '8.3') && getenv('CI')) {
-			$this->markTestSkipped('Test is unreliable and skipped on 8.3');
-		}
-
-		$this->cleanupAfter('testfilesizes');
-		$s3 = $this->getInstance();
-
-		$sourceStream = fopen('php://memory', 'wb+');
-		$writeChunkSize = 1024;
-		$chunkCount = $size / $writeChunkSize;
-		for ($i = 0; $i < $chunkCount; $i++) {
-			fwrite($sourceStream, str_repeat('A',
-				($i < $chunkCount - 1) ? $writeChunkSize : $size - ($i * $writeChunkSize)
-			));
-		}
-		rewind($sourceStream);
-		$s3->writeObject('testfilesizes', $sourceStream);
+    public function testUploadNonSeekable(): void {
+        $this->cleanupAfter('multiparttest');
+
+        $s3 = $this->getInstance();
+
+        $s3->writeObject('multiparttest', NonSeekableStream::wrap(fopen(__FILE__, 'r')));
+
+        $result = $s3->readObject('multiparttest');
+
+        $this->assertEquals(file_get_contents(__FILE__), stream_get_contents($result));
+    }
+
+    public function testSeek(): void {
+        $this->cleanupAfter('seek');
+
+        $data = file_get_contents(__FILE__);
+
+        $instance = $this->getInstance();
+        $instance->writeObject('seek', $this->stringToStream($data));
+
+        $read = $instance->readObject('seek');
+        $this->assertEquals(substr($data, 0, 100), fread($read, 100));
+
+        fseek($read, 10);
+        $this->assertEquals(substr($data, 10, 100), fread($read, 100));
+
+        fseek($read, 100, SEEK_CUR);
+        $this->assertEquals(substr($data, 210, 100), fread($read, 100));
+    }
+
+    public function assertNoUpload($objectUrn) {
+        /** @var \OC\Files\ObjectStore\S3 */
+        $s3 = $this->getInstance();
+        $s3client = $s3->getConnection();
+        $uploads = $s3client->listMultipartUploads([
+            'Bucket' => $s3->getBucket(),
+            'Prefix' => $objectUrn,
+        ]);
+        $this->assertArrayNotHasKey('Uploads', $uploads, 'Assert is not uploaded');
+    }
+
+    public function testEmptyUpload(): void {
+        $s3 = $this->getInstance();
+
+        $emptyStream = fopen('php://memory', 'r');
+        fwrite($emptyStream, '');
+
+        $s3->writeObject('emptystream', $emptyStream);
+
+        $this->assertNoUpload('emptystream');
+        $this->assertTrue($s3->objectExists('emptystream'), 'Object exists on S3');
+
+        $thrown = false;
+        try {
+            self::assertFalse($s3->readObject('emptystream'), 'Reading empty stream object should return false');
+        } catch (\Exception $e) {
+            // An exception is expected here since 0 byte files are wrapped
+            // to be read from an empty memory stream in the ObjectStoreStorage
+            $thrown = true;
+        }
+        self::assertTrue($thrown, 'readObject with range requests are not expected to work on empty objects');
+
+        $s3->deleteObject('emptystream');
+    }
+
+    /** File size to upload in bytes */
+    public static function dataFileSizes(): array {
+        return [
+            [1000000], [2000000], [5242879], [5242880], [5242881], [10000000]
+        ];
+    }
+
+    /** @dataProvider dataFileSizes */
+    public function testFileSizes($size): void {
+        if (str_starts_with(PHP_VERSION, '8.3') && getenv('CI')) {
+            $this->markTestSkipped('Test is unreliable and skipped on 8.3');
+        }
+
+        $this->cleanupAfter('testfilesizes');
+        $s3 = $this->getInstance();
+
+        $sourceStream = fopen('php://memory', 'wb+');
+        $writeChunkSize = 1024;
+        $chunkCount = $size / $writeChunkSize;
+        for ($i = 0; $i < $chunkCount; $i++) {
+            fwrite($sourceStream, str_repeat('A',
+                ($i < $chunkCount - 1) ? $writeChunkSize : $size - ($i * $writeChunkSize)
+            ));
+        }
+        rewind($sourceStream);
+        $s3->writeObject('testfilesizes', $sourceStream);
 
-		$this->assertNoUpload('testfilesizes');
-		self::assertTrue($s3->objectExists('testfilesizes'), 'Object exists on S3');
+        $this->assertNoUpload('testfilesizes');
+        self::assertTrue($s3->objectExists('testfilesizes'), 'Object exists on S3');
 
-		$result = $s3->readObject('testfilesizes');
+        $result = $s3->readObject('testfilesizes');
 
-		// compare first 100 bytes
-		self::assertEquals(str_repeat('A', 100), fread($result, 100), 'Compare first 100 bytes');
+        // compare first 100 bytes
+        self::assertEquals(str_repeat('A', 100), fread($result, 100), 'Compare first 100 bytes');
 
-		// compare last 100 bytes
-		fseek($result, $size - 100);
-		self::assertEquals(str_repeat('A', 100), fread($result, 100), 'Compare last 100 bytes');
+        // compare last 100 bytes
+        fseek($result, $size - 100);
+        self::assertEquals(str_repeat('A', 100), fread($result, 100), 'Compare last 100 bytes');
 
-		// end of file reached
-		fseek($result, $size);
-		self::assertTrue(feof($result), 'End of file reached');
-
-		$this->assertNoUpload('testfilesizes');
-	}
+        // end of file reached
+        fseek($result, $size);
+        self::assertTrue(feof($result), 'End of file reached');
+
+        $this->assertNoUpload('testfilesizes');
+    }
 }

tests/lib/Files/ObjectStore/MapperTest.php

Indentation +48 added lines, -48 removed lines

@@ -12,52 +12,52 @@
 use OCP\IUser;
 
 class MapperTest extends \Test\TestCase {
-	/** @var IUser|\PHPUnit\Framework\MockObject\MockObject */
-	private $user;
-
-	/** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
-	private $config;
-
-	/** @var Mapper */
-	private $mapper;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->user = $this->createMock(IUser::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->mapper = new Mapper($this->user, $this->config);
-	}
-
-	public static function dataGetBucket(): array {
-		return [
-			['user', 64, 0, '17'],
-			['USER', 64, 0, '0'],
-			['bc0e8b52-a66c-1035-90c6-d9663bda9e3f', 64, 0, '56'],
-			['user', 8, 0, '1'],
-			['user', 2, 0, '1'],
-			['USER', 2, 0, '0'],
-			['user', 128, 64, '81'],
-		];
-	}
-
-	/**
-	 * @dataProvider dataGetBucket
-	 * @param string $username
-	 * @param int $numBuckets
-	 * @param string $expectedBucket
-	 */
-	public function testGetBucket($username, $numBuckets, $bucketShift, $expectedBucket): void {
-		$this->user->expects($this->once())
-			->method('getUID')
-			->willReturn($username);
-
-		$this->config->expects($this->once())
-			->method('getSystemValue')
-			->with('objectstore_multibucket')
-			->willReturn(['arguments' => ['min_bucket' => $bucketShift]]);
-
-		$result = $this->mapper->getBucket($numBuckets);
-		$this->assertEquals($expectedBucket, $result);
-	}
+    /** @var IUser|\PHPUnit\Framework\MockObject\MockObject */
+    private $user;
+
+    /** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
+    private $config;
+
+    /** @var Mapper */
+    private $mapper;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->user = $this->createMock(IUser::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->mapper = new Mapper($this->user, $this->config);
+    }
+
+    public static function dataGetBucket(): array {
+        return [
+            ['user', 64, 0, '17'],
+            ['USER', 64, 0, '0'],
+            ['bc0e8b52-a66c-1035-90c6-d9663bda9e3f', 64, 0, '56'],
+            ['user', 8, 0, '1'],
+            ['user', 2, 0, '1'],
+            ['USER', 2, 0, '0'],
+            ['user', 128, 64, '81'],
+        ];
+    }
+
+    /**
+     * @dataProvider dataGetBucket
+     * @param string $username
+     * @param int $numBuckets
+     * @param string $expectedBucket
+     */
+    public function testGetBucket($username, $numBuckets, $bucketShift, $expectedBucket): void {
+        $this->user->expects($this->once())
+            ->method('getUID')
+            ->willReturn($username);
+
+        $this->config->expects($this->once())
+            ->method('getSystemValue')
+            ->with('objectstore_multibucket')
+            ->willReturn(['arguments' => ['min_bucket' => $bucketShift]]);
+
+        $result = $this->mapper->getBucket($numBuckets);
+        $this->assertEquals($expectedBucket, $result);
+    }
 }

tests/lib/Files/FilenameValidatorTest.php

Indentation +482 added lines, -482 removed lines

@@ -26,486 +26,486 @@
 
 class FilenameValidatorTest extends TestCase {
 
-	protected IFactory&MockObject $l10n;
-	protected IConfig&MockObject $config;
-	protected IDBConnection&MockObject $database;
-	protected LoggerInterface&MockObject $logger;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$l10n = $this->createMock(IL10N::class);
-		$l10n->method('t')
-			->willReturnCallback(fn ($string, $params) => sprintf($string, ...$params));
-		$this->l10n = $this->createMock(IFactory::class);
-		$this->l10n
-			->method('get')
-			->with('core')
-			->willReturn($l10n);
-
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->database = $this->createMock(IDBConnection::class);
-		$this->database->method('supports4ByteText')->willReturn(true);
-	}
-
-	/**
-	 * @dataProvider dataValidateFilename
-	 */
-	public function testValidateFilename(
-		string $filename,
-		array $forbiddenNames,
-		array $forbiddenBasenames,
-		array $forbiddenExtensions,
-		array $forbiddenCharacters,
-		?string $exception,
-	): void {
-		/** @var FilenameValidator&MockObject */
-		$validator = $this->getMockBuilder(FilenameValidator::class)
-			->onlyMethods([
-				'getForbiddenBasenames',
-				'getForbiddenCharacters',
-				'getForbiddenExtensions',
-				'getForbiddenFilenames',
-			])
-			->setConstructorArgs([$this->l10n, $this->database, $this->config, $this->logger])
-			->getMock();
-
-		$validator->method('getForbiddenBasenames')
-			->willReturn($forbiddenBasenames);
-		$validator->method('getForbiddenCharacters')
-			->willReturn($forbiddenCharacters);
-		$validator->method('getForbiddenExtensions')
-			->willReturn($forbiddenExtensions);
-		$validator->method('getForbiddenFilenames')
-			->willReturn($forbiddenNames);
-
-		if ($exception !== null) {
-			$this->expectException($exception);
-		} else {
-			$this->expectNotToPerformAssertions();
-		}
-		$validator->validateFilename($filename);
-	}
-
-	/**
-	 * @dataProvider dataValidateFilename
-	 */
-	public function testIsFilenameValid(
-		string $filename,
-		array $forbiddenNames,
-		array $forbiddenBasenames,
-		array $forbiddenExtensions,
-		array $forbiddenCharacters,
-		?string $exception,
-	): void {
-		/** @var FilenameValidator&MockObject */
-		$validator = $this->getMockBuilder(FilenameValidator::class)
-			->onlyMethods([
-				'getForbiddenBasenames',
-				'getForbiddenExtensions',
-				'getForbiddenFilenames',
-				'getForbiddenCharacters',
-			])
-			->setConstructorArgs([$this->l10n, $this->database, $this->config, $this->logger])
-			->getMock();
-
-		$validator->method('getForbiddenBasenames')
-			->willReturn($forbiddenBasenames);
-		$validator->method('getForbiddenCharacters')
-			->willReturn($forbiddenCharacters);
-		$validator->method('getForbiddenExtensions')
-			->willReturn($forbiddenExtensions);
-		$validator->method('getForbiddenFilenames')
-			->willReturn($forbiddenNames);
-
-
-		$this->assertEquals($exception === null, $validator->isFilenameValid($filename));
-	}
-
-	public static function dataValidateFilename(): array {
-		return [
-			'valid name' => [
-				'a: b.txt', ['.htaccess'], [], [], [], null
-			],
-			'forbidden name in the middle is ok' => [
-				'a.htaccess.txt', ['.htaccess'], [], [], [], null
-			],
-			'valid name with some more parameters' => [
-				'a: b.txt', ['.htaccess'], [], ['exe'], ['~'], null
-			],
-			'valid name checks only the full name' => [
-				'.htaccess.sample', ['.htaccess'], [], [], [], null
-			],
-			'forbidden name' => [
-				'.htaccess', ['.htaccess'], [], [], [], ReservedWordException::class
-			],
-			'forbidden name - name is case insensitive' => [
-				'COM1', ['.htaccess', 'com1'], [], [], [], ReservedWordException::class
-			],
-			'forbidden basename' => [
-				// needed for Windows namespaces
-				'com1.suffix', ['.htaccess'], ['com1'], [], [], ReservedWordException::class
-			],
-			'forbidden basename case insensitive' => [
-				// needed for Windows namespaces
-				'COM1.suffix', ['.htaccess'], ['com1'], [], [], ReservedWordException::class
-			],
-			'forbidden basename for hidden files' => [
-				// needed for Windows namespaces
-				'.thumbs.db', ['.htaccess'], ['.thumbs'], [], [], ReservedWordException::class
-			],
-			'invalid character' => [
-				'a: b.txt', ['.htaccess'], [], [], [':'], InvalidCharacterInPathException::class
-			],
-			'invalid path' => [
-				'../../foo.bar', ['.htaccess'], [], [], ['/', '\\'], InvalidCharacterInPathException::class,
-			],
-			'invalid extension' => [
-				'a: b.txt', ['.htaccess'], [], ['.txt'], [], InvalidPathException::class
-			],
-			'invalid extension case insensitive' => [
-				'a: b.TXT', ['.htaccess'], [], ['.txt'], [], InvalidPathException::class
-			],
-			'empty filename' => [
-				'', [], [], [], [], EmptyFileNameException::class
-			],
-			'reserved unix name "."' => [
-				'.', [], [], [], [], InvalidDirectoryException::class
-			],
-			'reserved unix name ".."' => [
-				'..', [], [], [], [], InvalidDirectoryException::class
-			],
-			'weird but valid tripple dot name' => [
-				'...', [], [], [], [], null // is valid
-			],
-			'too long filename "."' => [
-				str_repeat('a', 251), [], [], [], [], FileNameTooLongException::class
-			],
-			// make sure to not split the list entries as they migh contain Unicode sequences
-			// in this example the "face in clouds" emoji contains the clouds emoji so only having clouds is ok
-			['

tests/lib/Files/Node/FileTest.php

Indentation +285 added lines, -285 removed lines

@@ -17,289 +17,289 @@
  * @package Test\Files\Node
  */
 class FileTest extends NodeTestCase {
-	protected function createTestNode($root, $view, $path, array $data = [], $internalPath = '', $storage = null) {
-		if ($data || $internalPath || $storage) {
-			return new \OC\Files\Node\File($root, $view, $path, $this->getFileInfo($data, $internalPath, $storage));
-		} else {
-			return new \OC\Files\Node\File($root, $view, $path);
-		}
-	}
-
-	protected function getNodeClass() {
-		return '\OC\Files\Node\File';
-	}
-
-	protected function getNonExistingNodeClass() {
-		return '\OC\Files\Node\NonExistingFile';
-	}
-
-	protected function getViewDeleteMethod() {
-		return 'unlink';
-	}
-
-	public function testGetContent(): void {
-		/** @var \OC\Files\Node\Root|\PHPUnit\Framework\MockObject\MockObject $root */
-		$root = $this->getMockBuilder(Root::class)
-			->setConstructorArgs([$this->manager, $this->view, $this->user, $this->userMountCache, $this->logger, $this->userManager, $this->eventDispatcher, $this->cacheFactory])
-			->getMock();
-
-		$hook = function ($file) {
-			throw new \Exception('Hooks are not supposed to be called');
-		};
-
-		$root->listen('\OC\Files', 'preWrite', $hook);
-		$root->listen('\OC\Files', 'postWrite', $hook);
-
-		$this->view->expects($this->once())
-			->method('file_get_contents')
-			->with('/bar/foo')
-			->willReturn('bar');
-
-		$this->view->expects($this->once())
-			->method('getFileInfo')
-			->with('/bar/foo')
-			->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_READ]));
-
-		$node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
-		$this->assertEquals('bar', $node->getContent());
-	}
-
-
-	public function testGetContentNotPermitted(): void {
-		$this->expectException(\OCP\Files\NotPermittedException::class);
-
-		/** @var \OC\Files\Node\Root|\PHPUnit\Framework\MockObject\MockObject $root */
-		$root = $this->getMockBuilder(Root::class)
-			->setConstructorArgs([$this->manager, $this->view, $this->user, $this->userMountCache, $this->logger, $this->userManager, $this->eventDispatcher, $this->cacheFactory])
-			->getMock();
-
-		$root->expects($this->any())
-			->method('getUser')
-			->willReturn($this->user);
-
-		$this->view->expects($this->once())
-			->method('getFileInfo')
-			->with('/bar/foo')
-			->willReturn($this->getFileInfo(['permissions' => 0]));
-
-		$node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
-		$node->getContent();
-	}
-
-	public function testPutContent(): void {
-		/** @var \OC\Files\Node\Root|\PHPUnit\Framework\MockObject\MockObject $root */
-		$root = $this->getMockBuilder(Root::class)
-			->setConstructorArgs([$this->manager, $this->view, $this->user, $this->userMountCache, $this->logger, $this->userManager, $this->eventDispatcher, $this->cacheFactory])
-			->getMock();
-
-		$root->expects($this->any())
-			->method('getUser')
-			->willReturn($this->user);
-
-		$this->view->expects($this->once())
-			->method('getFileInfo')
-			->with('/bar/foo')
-			->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_ALL]));
-
-		$this->view->expects($this->once())
-			->method('file_put_contents')
-			->with('/bar/foo', 'bar')
-			->willReturn(true);
-
-		$node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
-		$node->putContent('bar');
-	}
-
-
-	public function testPutContentNotPermitted(): void {
-		$this->expectException(\OCP\Files\NotPermittedException::class);
-
-		/** @var \OC\Files\Node\Root|\PHPUnit\Framework\MockObject\MockObject $root */
-		$root = $this->getMockBuilder(Root::class)
-			->setConstructorArgs([$this->manager, $this->view, $this->user, $this->userMountCache, $this->logger, $this->userManager, $this->eventDispatcher, $this->cacheFactory])
-			->getMock();
-
-		$this->view->expects($this->once())
-			->method('getFileInfo')
-			->with('/bar/foo')
-			->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_READ]));
-
-		$node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
-		$node->putContent('bar');
-	}
-
-	public function testGetMimeType(): void {
-		/** @var \OC\Files\Node\Root|\PHPUnit\Framework\MockObject\MockObject $root */
-		$root = $this->getMockBuilder(Root::class)
-			->setConstructorArgs([$this->manager, $this->view, $this->user, $this->userMountCache, $this->logger, $this->userManager, $this->eventDispatcher, $this->cacheFactory])
-			->getMock();
-
-		$this->view->expects($this->once())
-			->method('getFileInfo')
-			->with('/bar/foo')
-			->willReturn($this->getFileInfo(['mimetype' => 'text/plain']));
-
-		$node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
-		$this->assertEquals('text/plain', $node->getMimeType());
-	}
-
-	public function testFOpenRead(): void {
-		$stream = fopen('php://memory', 'w+');
-		fwrite($stream, 'bar');
-		rewind($stream);
-
-		$root = new \OC\Files\Node\Root(
-			$this->manager,
-			$this->view,
-			$this->user,
-			$this->userMountCache,
-			$this->logger,
-			$this->userManager,
-			$this->eventDispatcher,
-			$this->cacheFactory,
-		);
-
-		$hook = function ($file) {
-			throw new \Exception('Hooks are not supposed to be called');
-		};
-
-		$root->listen('\OC\Files', 'preWrite', $hook);
-		$root->listen('\OC\Files', 'postWrite', $hook);
-
-		$this->view->expects($this->once())
-			->method('fopen')
-			->with('/bar/foo', 'r')
-			->willReturn($stream);
-
-		$this->view->expects($this->once())
-			->method('getFileInfo')
-			->with('/bar/foo')
-			->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_ALL]));
-
-		$node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
-		$fh = $node->fopen('r');
-		$this->assertEquals($stream, $fh);
-		$this->assertEquals('bar', fread($fh, 3));
-	}
-
-	public function testFOpenWrite(): void {
-		$stream = fopen('php://memory', 'w+');
-
-		$root = new \OC\Files\Node\Root(
-			$this->manager,
-			$this->view,
-			$this->user,
-			$this->userMountCache,
-			$this->logger,
-			$this->userManager,
-			$this->eventDispatcher,
-			$this->cacheFactory,
-		);
-		$hooksCalled = 0;
-		$hook = function ($file) use (&$hooksCalled) {
-			$hooksCalled++;
-		};
-
-		$root->listen('\OC\Files', 'preWrite', $hook);
-		$root->listen('\OC\Files', 'postWrite', $hook);
-
-		$this->view->expects($this->once())
-			->method('fopen')
-			->with('/bar/foo', 'w')
-			->willReturn($stream);
-
-		$this->view->expects($this->once())
-			->method('getFileInfo')
-			->with('/bar/foo')
-			->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_ALL]));
-
-		$node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
-		$fh = $node->fopen('w');
-		$this->assertEquals($stream, $fh);
-		fwrite($fh, 'bar');
-		rewind($fh);
-		$this->assertEquals('bar', fread($stream, 3));
-		$this->assertEquals(2, $hooksCalled);
-	}
-
-
-	public function testFOpenReadNotPermitted(): void {
-		$this->expectException(\OCP\Files\NotPermittedException::class);
-
-		$root = new \OC\Files\Node\Root(
-			$this->manager,
-			$this->view,
-			$this->user,
-			$this->userMountCache,
-			$this->logger,
-			$this->userManager,
-			$this->eventDispatcher,
-			$this->cacheFactory,
-		);
-		$hook = function ($file) {
-			throw new \Exception('Hooks are not supposed to be called');
-		};
-
-		$this->view->expects($this->once())
-			->method('getFileInfo')
-			->with('/bar/foo')
-			->willReturn($this->getFileInfo(['permissions' => 0]));
-
-		$node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
-		$node->fopen('r');
-	}
-
-
-	public function testFOpenReadWriteNoReadPermissions(): void {
-		$this->expectException(\OCP\Files\NotPermittedException::class);
-
-		$root = new \OC\Files\Node\Root(
-			$this->manager,
-			$this->view,
-			$this->user,
-			$this->userMountCache,
-			$this->logger,
-			$this->userManager,
-			$this->eventDispatcher,
-			$this->cacheFactory,
-		);
-		$hook = function () {
-			throw new \Exception('Hooks are not supposed to be called');
-		};
-
-		$this->view->expects($this->once())
-			->method('getFileInfo')
-			->with('/bar/foo')
-			->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_UPDATE]));
-
-		$node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
-		$node->fopen('w');
-	}
-
-
-	public function testFOpenReadWriteNoWritePermissions(): void {
-		$this->expectException(\OCP\Files\NotPermittedException::class);
-
-		$root = new \OC\Files\Node\Root(
-			$this->manager,
-			$this->view,
-			$this->user,
-			$this->userMountCache,
-			$this->logger,
-			$this->userManager,
-			$this->eventDispatcher,
-			$this->cacheFactory,
-		);
-		$hook = function () {
-			throw new \Exception('Hooks are not supposed to be called');
-		};
-
-		$this->view->expects($this->once())
-			->method('getFileInfo')
-			->with('/bar/foo')
-			->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_READ]));
-
-		$node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
-		$node->fopen('w');
-	}
+    protected function createTestNode($root, $view, $path, array $data = [], $internalPath = '', $storage = null) {
+        if ($data || $internalPath || $storage) {
+            return new \OC\Files\Node\File($root, $view, $path, $this->getFileInfo($data, $internalPath, $storage));
+        } else {
+            return new \OC\Files\Node\File($root, $view, $path);
+        }
+    }
+
+    protected function getNodeClass() {
+        return '\OC\Files\Node\File';
+    }
+
+    protected function getNonExistingNodeClass() {
+        return '\OC\Files\Node\NonExistingFile';
+    }
+
+    protected function getViewDeleteMethod() {
+        return 'unlink';
+    }
+
+    public function testGetContent(): void {
+        /** @var \OC\Files\Node\Root|\PHPUnit\Framework\MockObject\MockObject $root */
+        $root = $this->getMockBuilder(Root::class)
+            ->setConstructorArgs([$this->manager, $this->view, $this->user, $this->userMountCache, $this->logger, $this->userManager, $this->eventDispatcher, $this->cacheFactory])
+            ->getMock();
+
+        $hook = function ($file) {
+            throw new \Exception('Hooks are not supposed to be called');
+        };
+
+        $root->listen('\OC\Files', 'preWrite', $hook);
+        $root->listen('\OC\Files', 'postWrite', $hook);
+
+        $this->view->expects($this->once())
+            ->method('file_get_contents')
+            ->with('/bar/foo')
+            ->willReturn('bar');
+
+        $this->view->expects($this->once())
+            ->method('getFileInfo')
+            ->with('/bar/foo')
+            ->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_READ]));
+
+        $node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
+        $this->assertEquals('bar', $node->getContent());
+    }
+
+
+    public function testGetContentNotPermitted(): void {
+        $this->expectException(\OCP\Files\NotPermittedException::class);
+
+        /** @var \OC\Files\Node\Root|\PHPUnit\Framework\MockObject\MockObject $root */
+        $root = $this->getMockBuilder(Root::class)
+            ->setConstructorArgs([$this->manager, $this->view, $this->user, $this->userMountCache, $this->logger, $this->userManager, $this->eventDispatcher, $this->cacheFactory])
+            ->getMock();
+
+        $root->expects($this->any())
+            ->method('getUser')
+            ->willReturn($this->user);
+
+        $this->view->expects($this->once())
+            ->method('getFileInfo')
+            ->with('/bar/foo')
+            ->willReturn($this->getFileInfo(['permissions' => 0]));
+
+        $node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
+        $node->getContent();
+    }
+
+    public function testPutContent(): void {
+        /** @var \OC\Files\Node\Root|\PHPUnit\Framework\MockObject\MockObject $root */
+        $root = $this->getMockBuilder(Root::class)
+            ->setConstructorArgs([$this->manager, $this->view, $this->user, $this->userMountCache, $this->logger, $this->userManager, $this->eventDispatcher, $this->cacheFactory])
+            ->getMock();
+
+        $root->expects($this->any())
+            ->method('getUser')
+            ->willReturn($this->user);
+
+        $this->view->expects($this->once())
+            ->method('getFileInfo')
+            ->with('/bar/foo')
+            ->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_ALL]));
+
+        $this->view->expects($this->once())
+            ->method('file_put_contents')
+            ->with('/bar/foo', 'bar')
+            ->willReturn(true);
+
+        $node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
+        $node->putContent('bar');
+    }
+
+
+    public function testPutContentNotPermitted(): void {
+        $this->expectException(\OCP\Files\NotPermittedException::class);
+
+        /** @var \OC\Files\Node\Root|\PHPUnit\Framework\MockObject\MockObject $root */
+        $root = $this->getMockBuilder(Root::class)
+            ->setConstructorArgs([$this->manager, $this->view, $this->user, $this->userMountCache, $this->logger, $this->userManager, $this->eventDispatcher, $this->cacheFactory])
+            ->getMock();
+
+        $this->view->expects($this->once())
+            ->method('getFileInfo')
+            ->with('/bar/foo')
+            ->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_READ]));
+
+        $node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
+        $node->putContent('bar');
+    }
+
+    public function testGetMimeType(): void {
+        /** @var \OC\Files\Node\Root|\PHPUnit\Framework\MockObject\MockObject $root */
+        $root = $this->getMockBuilder(Root::class)
+            ->setConstructorArgs([$this->manager, $this->view, $this->user, $this->userMountCache, $this->logger, $this->userManager, $this->eventDispatcher, $this->cacheFactory])
+            ->getMock();
+
+        $this->view->expects($this->once())
+            ->method('getFileInfo')
+            ->with('/bar/foo')
+            ->willReturn($this->getFileInfo(['mimetype' => 'text/plain']));
+
+        $node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
+        $this->assertEquals('text/plain', $node->getMimeType());
+    }
+
+    public function testFOpenRead(): void {
+        $stream = fopen('php://memory', 'w+');
+        fwrite($stream, 'bar');
+        rewind($stream);
+
+        $root = new \OC\Files\Node\Root(
+            $this->manager,
+            $this->view,
+            $this->user,
+            $this->userMountCache,
+            $this->logger,
+            $this->userManager,
+            $this->eventDispatcher,
+            $this->cacheFactory,
+        );
+
+        $hook = function ($file) {
+            throw new \Exception('Hooks are not supposed to be called');
+        };
+
+        $root->listen('\OC\Files', 'preWrite', $hook);
+        $root->listen('\OC\Files', 'postWrite', $hook);
+
+        $this->view->expects($this->once())
+            ->method('fopen')
+            ->with('/bar/foo', 'r')
+            ->willReturn($stream);
+
+        $this->view->expects($this->once())
+            ->method('getFileInfo')
+            ->with('/bar/foo')
+            ->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_ALL]));
+
+        $node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
+        $fh = $node->fopen('r');
+        $this->assertEquals($stream, $fh);
+        $this->assertEquals('bar', fread($fh, 3));
+    }
+
+    public function testFOpenWrite(): void {
+        $stream = fopen('php://memory', 'w+');
+
+        $root = new \OC\Files\Node\Root(
+            $this->manager,
+            $this->view,
+            $this->user,
+            $this->userMountCache,
+            $this->logger,
+            $this->userManager,
+            $this->eventDispatcher,
+            $this->cacheFactory,
+        );
+        $hooksCalled = 0;
+        $hook = function ($file) use (&$hooksCalled) {
+            $hooksCalled++;
+        };
+
+        $root->listen('\OC\Files', 'preWrite', $hook);
+        $root->listen('\OC\Files', 'postWrite', $hook);
+
+        $this->view->expects($this->once())
+            ->method('fopen')
+            ->with('/bar/foo', 'w')
+            ->willReturn($stream);
+
+        $this->view->expects($this->once())
+            ->method('getFileInfo')
+            ->with('/bar/foo')
+            ->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_ALL]));
+
+        $node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
+        $fh = $node->fopen('w');
+        $this->assertEquals($stream, $fh);
+        fwrite($fh, 'bar');
+        rewind($fh);
+        $this->assertEquals('bar', fread($stream, 3));
+        $this->assertEquals(2, $hooksCalled);
+    }
+
+
+    public function testFOpenReadNotPermitted(): void {
+        $this->expectException(\OCP\Files\NotPermittedException::class);
+
+        $root = new \OC\Files\Node\Root(
+            $this->manager,
+            $this->view,
+            $this->user,
+            $this->userMountCache,
+            $this->logger,
+            $this->userManager,
+            $this->eventDispatcher,
+            $this->cacheFactory,
+        );
+        $hook = function ($file) {
+            throw new \Exception('Hooks are not supposed to be called');
+        };
+
+        $this->view->expects($this->once())
+            ->method('getFileInfo')
+            ->with('/bar/foo')
+            ->willReturn($this->getFileInfo(['permissions' => 0]));
+
+        $node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
+        $node->fopen('r');
+    }
+
+
+    public function testFOpenReadWriteNoReadPermissions(): void {
+        $this->expectException(\OCP\Files\NotPermittedException::class);
+
+        $root = new \OC\Files\Node\Root(
+            $this->manager,
+            $this->view,
+            $this->user,
+            $this->userMountCache,
+            $this->logger,
+            $this->userManager,
+            $this->eventDispatcher,
+            $this->cacheFactory,
+        );
+        $hook = function () {
+            throw new \Exception('Hooks are not supposed to be called');
+        };
+
+        $this->view->expects($this->once())
+            ->method('getFileInfo')
+            ->with('/bar/foo')
+            ->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_UPDATE]));
+
+        $node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
+        $node->fopen('w');
+    }
+
+
+    public function testFOpenReadWriteNoWritePermissions(): void {
+        $this->expectException(\OCP\Files\NotPermittedException::class);
+
+        $root = new \OC\Files\Node\Root(
+            $this->manager,
+            $this->view,
+            $this->user,
+            $this->userMountCache,
+            $this->logger,
+            $this->userManager,
+            $this->eventDispatcher,
+            $this->cacheFactory,
+        );
+        $hook = function () {
+            throw new \Exception('Hooks are not supposed to be called');
+        };
+
+        $this->view->expects($this->once())
+            ->method('getFileInfo')
+            ->with('/bar/foo')
+            ->willReturn($this->getFileInfo(['permissions' => \OCP\Constants::PERMISSION_READ]));
+
+        $node = new \OC\Files\Node\File($root, $this->view, '/bar/foo');
+        $node->fopen('w');
+    }
 }