Passed
Push — master ( 32f79c...03cdff )
by Roeland
10:27 queued 11s
created
lib/private/Files/Filesystem.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -409,17 +409,17 @@  discard block
 block discarded – undo
409 409
 		$userObject = $userManager->get($user);
410 410
 
411 411
 		if (is_null($userObject)) {
412
-			\OCP\Util::writeLog('files', ' Backends provided no user object for ' . $user, ILogger::ERROR);
412
+			\OCP\Util::writeLog('files', ' Backends provided no user object for '.$user, ILogger::ERROR);
413 413
 			// reset flag, this will make it possible to rethrow the exception if called again
414 414
 			unset(self::$usersSetup[$user]);
415
-			throw new \OC\User\NoUserException('Backends provided no user object for ' . $user);
415
+			throw new \OC\User\NoUserException('Backends provided no user object for '.$user);
416 416
 		}
417 417
 
418 418
 		$realUid = $userObject->getUID();
419 419
 		// workaround in case of different casings
420 420
 		if ($user !== $realUid) {
421 421
 			$stack = json_encode(debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 50));
422
-			\OCP\Util::writeLog('files', 'initMountPoints() called with wrong user casing. This could be a bug. Expected: "' . $realUid . '" got "' . $user . '". Stack: ' . $stack, ILogger::WARN);
422
+			\OCP\Util::writeLog('files', 'initMountPoints() called with wrong user casing. This could be a bug. Expected: "'.$realUid.'" got "'.$user.'". Stack: '.$stack, ILogger::WARN);
423 423
 			$user = $realUid;
424 424
 
425 425
 			// again with the correct casing
@@ -452,11 +452,11 @@  discard block
 block discarded – undo
452 452
 		} else {
453 453
 			self::getMountManager()->addMount(new MountPoint(
454 454
 				new NullStorage([]),
455
-				'/' . $user
455
+				'/'.$user
456 456
 			));
457 457
 			self::getMountManager()->addMount(new MountPoint(
458 458
 				new NullStorage([]),
459
-				'/' . $user . '/files'
459
+				'/'.$user.'/files'
460 460
 			));
461 461
 		}
462 462
 		\OC_Hook::emit('OC_Filesystem', 'post_initMountPoints', array('user' => $user));
@@ -471,7 +471,7 @@  discard block
 block discarded – undo
471 471
 	private static function listenForNewMountProviders(MountProviderCollection $mountConfigManager, IUserManager $userManager) {
472 472
 		if (!self::$listeningForProviders) {
473 473
 			self::$listeningForProviders = true;
474
-			$mountConfigManager->listen('\OC\Files\Config', 'registerMountProvider', function (IMountProvider $provider) use ($userManager) {
474
+			$mountConfigManager->listen('\OC\Files\Config', 'registerMountProvider', function(IMountProvider $provider) use ($userManager) {
475 475
 				foreach (Filesystem::$usersSetup as $user => $setup) {
476 476
 					$userObject = $userManager->get($user);
477 477
 					if ($userObject) {
@@ -566,7 +566,7 @@  discard block
 block discarded – undo
566 566
 	 * @return string
567 567
 	 */
568 568
 	static public function getLocalPath($path) {
569
-		$datadir = \OC_User::getHome(\OC_User::getUser()) . '/files';
569
+		$datadir = \OC_User::getHome(\OC_User::getUser()).'/files';
570 570
 		$newpath = $path;
571 571
 		if (strncmp($newpath, $datadir, strlen($datadir)) == 0) {
572 572
 			$newpath = substr($path, strlen($datadir));
@@ -583,7 +583,7 @@  discard block
 block discarded – undo
583 583
 	static public function isValidPath($path) {
584 584
 		$path = self::normalizePath($path);
585 585
 		if (!$path || $path[0] !== '/') {
586
-			$path = '/' . $path;
586
+			$path = '/'.$path;
587 587
 		}
588 588
 		if (strpos($path, '/../') !== false || strrchr($path, '/') === '/..') {
589 589
 			return false;
@@ -804,7 +804,7 @@  discard block
 block discarded – undo
804 804
 		 *        conversion should get removed as soon as all existing
805 805
 		 *        function calls have been fixed.
806 806
 		 */
807
-		$path = (string)$path;
807
+		$path = (string) $path;
808 808
 
809 809
 		$cacheKey = json_encode([$path, $stripTrailingSlash, $isAbsolutePath, $keepUnicode]);
810 810
 
@@ -822,13 +822,13 @@  discard block
 block discarded – undo
822 822
 		}
823 823
 
824 824
 		//add leading slash, if it is already there we strip it anyway
825
-		$path = '/' . $path;
825
+		$path = '/'.$path;
826 826
 
827 827
 		$patterns = [
828
-			'/\\\\/s',          // no windows style slashes
828
+			'/\\\\/s', // no windows style slashes
829 829
 			'/\/\.(\/\.)?\//s', // remove '/./'
830
-			'/\/{2,}/s',        // remove squence of slashes
831
-			'/\/\.$/s',         // remove trailing /.
830
+			'/\/{2,}/s', // remove squence of slashes
831
+			'/\/\.$/s', // remove trailing /.
832 832
 		];
833 833
 
834 834
 		do {
Please login to merge, or discard this patch.
core/Command/Encryption/DecryptAll.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
 	}
124 124
 
125 125
 	protected function execute(InputInterface $input, OutputInterface $output) {
126
-		if ( !$input->isInteractive() ) {
126
+		if (!$input->isInteractive()) {
127 127
 			$output->writeln('Invalid TTY.');
128 128
 			$output->writeln('If you are trying to execute the command in a Docker ');
129 129
 			$output->writeln("container, do not forget to execute 'docker exec' with");
Please login to merge, or discard this patch.
core/Command/Encryption/EncryptAll.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
 	}
124 124
 
125 125
 	protected function execute(InputInterface $input, OutputInterface $output) {
126
-		if ( !$input->isInteractive() ) {
126
+		if (!$input->isInteractive()) {
127 127
 			$output->writeln('Invalid TTY.');
128 128
 			$output->writeln('If you are trying to execute the command in a Docker ');
129 129
 			$output->writeln("container, do not forget to execute 'docker exec' with");
Please login to merge, or discard this patch.
core/Command/TwoFactorAuth/Enforce.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -98,10 +98,10 @@
 block discarded – undo
98 98
 		if (empty($state->getEnforcedGroups())) {
99 99
 			$message = 'Two-factor authentication is enforced for all users';
100 100
 		} else {
101
-			$message = 'Two-factor authentication is enforced for members of the group(s) ' . implode(', ', $state->getEnforcedGroups());
101
+			$message = 'Two-factor authentication is enforced for members of the group(s) '.implode(', ', $state->getEnforcedGroups());
102 102
 		}
103 103
 		if (!empty($state->getExcludedGroups())) {
104
-			$message .= ', except members of ' . implode(', ', $state->getExcludedGroups());
104
+			$message .= ', except members of '.implode(', ', $state->getExcludedGroups());
105 105
 		}
106 106
 		$output->writeln($message);
107 107
 	}
Please login to merge, or discard this patch.
lib/public/Accounts/PropertyDoesNotExistException.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,8 +37,8 @@
 block discarded – undo
37 37
 	 * @param string $msg the error message
38 38
 	 * @since 15.0.0
39 39
 	 */
40
-	public function __construct($property){
41
-		parent::__construct('Property ' . $property . ' does not exist.');
40
+	public function __construct($property) {
41
+		parent::__construct('Property '.$property.' does not exist.');
42 42
 	}
43 43
 
44 44
 }
Please login to merge, or discard this patch.
apps/dav/lib/Migration/BuildCalendarSearchIndex.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,9 +70,9 @@
 block discarded – undo
70 70
 		}
71 71
 
72 72
 		$query = $this->db->getQueryBuilder();
73
-		$query->select($query->createFunction('MAX(' . $query->getColumnName('id') . ')'))
73
+		$query->select($query->createFunction('MAX('.$query->getColumnName('id').')'))
74 74
 			->from('calendarobjects');
75
-		$maxId = (int)$query->execute()->fetchColumn();
75
+		$maxId = (int) $query->execute()->fetchColumn();
76 76
 
77 77
 		$output->info('Add background job');
78 78
 		$this->jobList->add(BuildCalendarSearchIndexBackgroundJob::class, [
Please login to merge, or discard this patch.
apps/files_sharing/lib/SharedStorage.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 	 * @return string
183 183
 	 */
184 184
 	public function getId() {
185
-		return 'shared::' . $this->getMountPoint();
185
+		return 'shared::'.$this->getMountPoint();
186 186
 	}
187 187
 
188 188
 	/**
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
 					}
286 286
 			}
287 287
 			$info = array(
288
-				'target' => $this->getMountPoint() . $path,
288
+				'target' => $this->getMountPoint().$path,
289 289
 				'source' => $source,
290 290
 				'mode' => $mode,
291 291
 			);
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 		if (!$storage) {
379 379
 			$storage = $this;
380 380
 		}
381
-		$sourceRoot  = $this->getSourceRootInfo();
381
+		$sourceRoot = $this->getSourceRootInfo();
382 382
 		if ($this->storage instanceof FailedStorage) {
383 383
 			return new FailedCache();
384 384
 		}
@@ -484,7 +484,7 @@  discard block
 block discarded – undo
484 484
 
485 485
 	public function file_get_contents($path) {
486 486
 		$info = [
487
-			'target' => $this->getMountPoint() . '/' . $path,
487
+			'target' => $this->getMountPoint().'/'.$path,
488 488
 			'source' => $this->getUnjailedPath($path),
489 489
 		];
490 490
 		\OCP\Util::emitHook('\OC\Files\Storage\Shared', 'file_get_contents', $info);
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
 
494 494
 	public function file_put_contents($path, $data) {
495 495
 		$info = [
496
-			'target' => $this->getMountPoint() . '/' . $path,
496
+			'target' => $this->getMountPoint().'/'.$path,
497 497
 			'source' => $this->getUnjailedPath($path),
498 498
 		];
499 499
 		\OCP\Util::emitHook('\OC\Files\Storage\Shared', 'file_put_contents', $info);
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Outbox.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -74,12 +74,12 @@  discard block
 block discarded – undo
74 74
 			],
75 75
 			[
76 76
 				'privilege' => '{DAV:}read',
77
-				'principal' => $this->getOwner() . '/calendar-proxy-read',
77
+				'principal' => $this->getOwner().'/calendar-proxy-read',
78 78
 				'protected' => true,
79 79
 			],
80 80
 			[
81 81
 				'privilege' => '{DAV:}read',
82
-				'principal' => $this->getOwner() . '/calendar-proxy-write',
82
+				'principal' => $this->getOwner().'/calendar-proxy-write',
83 83
 				'protected' => true,
84 84
 			],
85 85
 		];
@@ -94,23 +94,23 @@  discard block
 block discarded – undo
94 94
 		if ($this->disableFreeBusy) {
95 95
 			return array_merge($commonAcl, [
96 96
 				[
97
-					'privilege' => '{' . CalDAVPlugin::NS_CALDAV . '}schedule-send-invite',
97
+					'privilege' => '{'.CalDAVPlugin::NS_CALDAV.'}schedule-send-invite',
98 98
 					'principal' => $this->getOwner(),
99 99
 					'protected' => true,
100 100
 				],
101 101
 				[
102
-					'privilege' => '{' . CalDAVPlugin::NS_CALDAV . '}schedule-send-invite',
103
-					'principal' => $this->getOwner() . '/calendar-proxy-write',
102
+					'privilege' => '{'.CalDAVPlugin::NS_CALDAV.'}schedule-send-invite',
103
+					'principal' => $this->getOwner().'/calendar-proxy-write',
104 104
 					'protected' => true,
105 105
 				],
106 106
 				[
107
-					'privilege' => '{' . CalDAVPlugin::NS_CALDAV . '}schedule-send-reply',
107
+					'privilege' => '{'.CalDAVPlugin::NS_CALDAV.'}schedule-send-reply',
108 108
 					'principal' => $this->getOwner(),
109 109
 					'protected' => true,
110 110
 				],
111 111
 				[
112
-					'privilege' => '{' . CalDAVPlugin::NS_CALDAV . '}schedule-send-reply',
113
-					'principal' => $this->getOwner() . '/calendar-proxy-write',
112
+					'privilege' => '{'.CalDAVPlugin::NS_CALDAV.'}schedule-send-reply',
113
+					'principal' => $this->getOwner().'/calendar-proxy-write',
114 114
 					'protected' => true,
115 115
 				],
116 116
 			]);
@@ -118,13 +118,13 @@  discard block
 block discarded – undo
118 118
 
119 119
 		return array_merge($commonAcl, [
120 120
 			[
121
-				'privilege' => '{' . CalDAVPlugin::NS_CALDAV . '}schedule-send',
121
+				'privilege' => '{'.CalDAVPlugin::NS_CALDAV.'}schedule-send',
122 122
 				'principal' => $this->getOwner(),
123 123
 				'protected' => true,
124 124
 			],
125 125
 			[
126
-				'privilege' => '{' . CalDAVPlugin::NS_CALDAV . '}schedule-send',
127
-				'principal' => $this->getOwner() . '/calendar-proxy-write',
126
+				'privilege' => '{'.CalDAVPlugin::NS_CALDAV.'}schedule-send',
127
+				'principal' => $this->getOwner().'/calendar-proxy-write',
128 128
 				'protected' => true,
129 129
 			],
130 130
 		]);
Please login to merge, or discard this patch.
lib/public/BackgroundJob/Job.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -73,17 +73,17 @@
 block discarded – undo
73 73
 
74 74
 		try {
75 75
 			$jobStartTime = $this->time->getTime();
76
-			$logger->debug('Run ' . get_class($this) . ' job with ID ' . $this->getId(), ['app' => 'cron']);
76
+			$logger->debug('Run '.get_class($this).' job with ID '.$this->getId(), ['app' => 'cron']);
77 77
 			$this->run($this->argument);
78 78
 			$timeTaken = $this->time->getTime() - $jobStartTime;
79 79
 
80
-			$logger->debug('Finished ' . get_class($this) . ' job with ID ' . $this->getId() . ' in ' . $timeTaken . ' seconds', ['app' => 'cron']);
80
+			$logger->debug('Finished '.get_class($this).' job with ID '.$this->getId().' in '.$timeTaken.' seconds', ['app' => 'cron']);
81 81
 			$jobList->setExecutionTime($this, $timeTaken);
82 82
 		} catch (\Exception $e) {
83 83
 			if ($logger) {
84 84
 				$logger->logException($e, [
85 85
 					'app' => 'core',
86
-					'message' => 'Error while running background job (class: ' . get_class($this) . ', arguments: ' . print_r($this->argument, true) . ')'
86
+					'message' => 'Error while running background job (class: '.get_class($this).', arguments: '.print_r($this->argument, true).')'
87 87
 				]);
88 88
 			}
89 89
 		}
Please login to merge, or discard this patch.